[Intel-gfx] ✗ Fi.CI.IGT: failure for Tiger Lake: MOCS table handling

2019-07-26 Thread Patchwork
== Series Details == Series: Tiger Lake: MOCS table handling URL : https://patchwork.freedesktop.org/series/64275/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6557_full -> Patchwork_13766_full Summary --- **FAILURE

[Intel-gfx] ✓ Fi.CI.IGT: success for Tiger Lake: add workarounds

2019-07-26 Thread Patchwork
== Series Details == Series: Tiger Lake: add workarounds URL : https://patchwork.freedesktop.org/series/64274/ State : success == Summary == CI Bug Log - changes from CI_DRM_6557_full -> Patchwork_13765_full Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.IGT: success for Tiger Lake: DKL phy PLLs

2019-07-26 Thread Patchwork
== Series Details == Series: Tiger Lake: DKL phy PLLs URL : https://patchwork.freedesktop.org/series/64273/ State : success == Summary == CI Bug Log - changes from CI_DRM_6557_full -> Patchwork_13764_full Summary --- **SUCCESS** N

[Intel-gfx] ✓ Fi.CI.IGT: success for Tiger Lake: interrupts

2019-07-26 Thread Patchwork
== Series Details == Series: Tiger Lake: interrupts URL : https://patchwork.freedesktop.org/series/64272/ State : success == Summary == CI Bug Log - changes from CI_DRM_6557_full -> Patchwork_13763_full Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915/tgl: skip setting PORT_CL_DW12_* on initialization

2019-07-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/tgl: skip setting PORT_CL_DW12_* on initialization URL : https://patchwork.freedesktop.org/series/64271/ State : success == Summary == CI Bug Log - changes from CI_DRM_6557_full -> Patchwork_13762_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Allow sharing the idle-barrier from other kernel requests

2019-07-26 Thread Patchwork
== Series Details == Series: drm/i915: Allow sharing the idle-barrier from other kernel requests URL : https://patchwork.freedesktop.org/series/64340/ State : success == Summary == CI Bug Log - changes from CI_DRM_6567 -> Patchwork_13778 Su

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Allow sharing the idle-barrier from other kernel requests

2019-07-26 Thread Patchwork
== Series Details == Series: drm/i915: Allow sharing the idle-barrier from other kernel requests URL : https://patchwork.freedesktop.org/series/64340/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3adf242161ce drm/i915: Allow sharing the idle-barrier from other kernel requests

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: ignore generated files for header test

2019-07-26 Thread Patchwork
== Series Details == Series: drm/i915: ignore generated files for header test URL : https://patchwork.freedesktop.org/series/64339/ State : success == Summary == CI Bug Log - changes from CI_DRM_6566 -> Patchwork_13777 Summary --- **

[Intel-gfx] [PATCH] drm/i915: Allow sharing the idle-barrier from other kernel requests

2019-07-26 Thread Chris Wilson
By placing our idle-barriers in the i915_active fence tree, we expose those for reuse by other components that are issuing requests along the kernel_context. Reusing the proto-barrier active_node is perfectly fine as the new request implies a context-switch, and so an opportune point to run the idl

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-26 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-07-26 23:19:38) > Hmmn. We're still on orthogonal perspectives as far as our previous arguments > stand. But it doesn't matter because while thinking through your replies, I > realized there is one argument in favour, which trumps all my previous > arguments against

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-26 Thread Bloomfield, Jon
Hmmn. We're still on orthogonal perspectives as far as our previous arguments stand. But it doesn't matter because while thinking through your replies, I realized there is one argument in favour, which trumps all my previous arguments against this patch - it makes things deterministic. Without t

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: ignore generated files for header test

2019-07-26 Thread Patchwork
== Series Details == Series: drm/i915: ignore generated files for header test URL : https://patchwork.freedesktop.org/series/64339/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5b8f13a2b32f drm/i915: ignore generated files for header test -:11: WARNING:FILE_PATH_CHANGES: added

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/1] drm/vblank: drop use of DRM_WAIT_ON()

2019-07-26 Thread Patchwork
== Series Details == Series: series starting with [v3,1/1] drm/vblank: drop use of DRM_WAIT_ON() URL : https://patchwork.freedesktop.org/series/64337/ State : success == Summary == CI Bug Log - changes from CI_DRM_6565 -> Patchwork_13776 Su

Re: [Intel-gfx] [PATCH] drm/i915: ignore generated files for header test

2019-07-26 Thread Lucas De Marchi
On Fri, Jul 26, 2019 at 10:34:50PM +0100, Chris Wilson wrote: Quoting Lucas De Marchi (2019-07-26 22:23:44) These are generated source that can be ignored by git. They're the stale generated headers from our old mechanism, right? No. They are still in the Makefiles: $ git grep -l header_tes

Re: [Intel-gfx] [PATCH] drm/i915: ignore generated files for header test

2019-07-26 Thread Chris Wilson
Quoting Lucas De Marchi (2019-07-26 22:23:44) > These are generated source that can be ignored by git. They're the stale generated headers from our old mechanism, right? See commit e846f0dc57f441e5e93194d39bc9b8ac2ab5e0a4 Author: Jani Nikula Date: Tue Jun 4 15:42:48 2019 +0300 kbuild: add

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-26 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-07-26 21:58:38) > > From: Chris Wilson > > It's no more often than before, you have to fail to advance within an > > interval, and then deny preemption request. > > It's entrapment. You are creating an artificial workload for the context to > impede. Before that art

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/1] drm/vblank: drop use of DRM_WAIT_ON()

2019-07-26 Thread Patchwork
== Series Details == Series: series starting with [v3,1/1] drm/vblank: drop use of DRM_WAIT_ON() URL : https://patchwork.freedesktop.org/series/64337/ State : warning == Summary == $ dim checkpatch origin/drm-tip c558d403f099 drm/vblank: drop use of DRM_WAIT_ON() -:47: WARNING:TYPO_SPELLING: '

[Intel-gfx] [PATCH] drm/i915: ignore generated files for header test

2019-07-26 Thread Lucas De Marchi
These are generated source that can be ignored by git. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/.gitignore | 1 + 1 file changed, 1 insertion(+) create mode 100644 drivers/gpu/drm/i915/.gitignore diff --git a/drivers/gpu/drm/i915/.gitignore b/drivers/gpu/drm/i915/.gitignore new

Re: [Intel-gfx] [PATCH] drm/i915/uc: Don't fail on HuC firmware failure

2019-07-26 Thread Michal Wajdeczko
On Fri, 26 Jul 2019 20:57:12 +0200, Chris Wilson wrote: Quoting Michal Wajdeczko (2019-07-26 18:12:40) HuC is usually not a critical component, so we can safely ignore firmware load or authentication failures unless HuC was explicitly requested by the user. Signed-off-by: Michal Wajdeczko

[Intel-gfx] [PATCH v3 1/1] drm/vblank: drop use of DRM_WAIT_ON()

2019-07-26 Thread Sam Ravnborg
DRM_WAIT_ON() is from the deprecated drm_os_linux header and the modern replacement is the wait_event_*. The return values differ, so a conversion is needed to keep the original interface towards userspace. Introduced a switch/case to make code obvious. Analysis from Michel Dänzer: The waiting c

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-26 Thread Bloomfield, Jon
> -Original Message- > From: Chris Wilson > Sent: Friday, July 26, 2019 1:11 PM > To: Bloomfield, Jon ; intel- > g...@lists.freedesktop.org > Cc: Joonas Lahtinen ; Ursulin, Tvrtko > > Subject: RE: [PATCH] drm/i915: Replace hangcheck by heartbeats > > Quoting Bloomfield, Jon (2019-07-26 1

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Capture vma contents outside of spinlock (rev2)

2019-07-26 Thread Patchwork
== Series Details == Series: drm/i915: Capture vma contents outside of spinlock (rev2) URL : https://patchwork.freedesktop.org/series/64256/ State : success == Summary == CI Bug Log - changes from CI_DRM_6555_full -> Patchwork_13759_full Su

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915/uc: Remove redundant header_offset/size definitions

2019-07-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/uc: Remove redundant header_offset/size definitions URL : https://patchwork.freedesktop.org/series/64332/ State : success == Summary == CI Bug Log - changes from CI_DRM_6564 -> Patchwork_13775

Re: [Intel-gfx] [PATCH 2/4] drm/i915/tgl: Define MOCS entries for Tigerlake

2019-07-26 Thread Daniele Ceraolo Spurio
On 7/26/19 12:31 PM, Lucas De Marchi wrote: On Fri, Jul 26, 2019 at 11:38:16AM -0700, Daniele Ceraolo Spurio wrote: On 7/25/19 5:12 PM, Lucas De Marchi wrote: From: Tomasz Lis The MOCS table is published as part of bspec, and versioned. Entries are supposed to never be modified, but new o

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-26 Thread Chris Wilson
Quoting Bloomfield, Jon (2019-07-26 16:00:06) > > -Original Message- > > From: Chris Wilson > > Sent: Thursday, July 25, 2019 4:52 PM > > To: Bloomfield, Jon ; intel- > > g...@lists.freedesktop.org > > Cc: Joonas Lahtinen ; Ursulin, Tvrtko > > > > Subject: RE: [PATCH] drm/i915: Replace ha

Re: [Intel-gfx] [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Alex Deucher
On Fri, Jul 26, 2019 at 3:42 PM Andrzej Pietrasiewicz wrote: > > Hi Alex, > > > W dniu 26.07.2019 o 21:28, Alex Deucher pisze: > > On Fri, Jul 26, 2019 at 1:28 PM Andrzej Pietrasiewicz > > wrote: > >> > >> Use the ddc pointer provided by the generic connector. > >> > >> Signed-off-by: Andrzej Pie

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/3] drm/i915/uc: Remove redundant header_offset/size definitions

2019-07-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/uc: Remove redundant header_offset/size definitions URL : https://patchwork.freedesktop.org/series/64332/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/uc: Remove redundant

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/gt: Add to timeline requires the timeline mutex (rev2)

2019-07-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Add to timeline requires the timeline mutex (rev2) URL : https://patchwork.freedesktop.org/series/64227/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6564 -> Patchwork_13774

Re: [Intel-gfx] [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Hi Alex, W dniu 26.07.2019 o 21:28, Alex Deucher pisze: On Fri, Jul 26, 2019 at 1:28 PM Andrzej Pietrasiewicz wrote: Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Note that this only covers the legacy display code. The new DC display code al

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/gt: Add to timeline requires the timeline mutex (rev2)

2019-07-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Add to timeline requires the timeline mutex (rev2) URL : https://patchwork.freedesktop.org/series/64227/ State : warning == Summary == $ dim checkpatch origin/drm-tip ff62d595c38e drm/i915: Allow sharing the idle-barrier fro

Re: [Intel-gfx] [PATCH 2/4] drm/i915/tgl: Define MOCS entries for Tigerlake

2019-07-26 Thread Lucas De Marchi
On Fri, Jul 26, 2019 at 11:38:16AM -0700, Daniele Ceraolo Spurio wrote: On 7/25/19 5:12 PM, Lucas De Marchi wrote: From: Tomasz Lis The MOCS table is published as part of bspec, and versioned. Entries are supposed to never be modified, but new ones can be added. Adding entries increases tabl

Re: [Intel-gfx] [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-26 Thread Chris Wilson
Quoting Thomas Gleixner (2019-07-26 20:18:32) > On Fri, 26 Jul 2019, Chris Wilson wrote: > > Quoting Thomas Gleixner (2019-07-25 22:55:45) > > > On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > > > > > > > Objtool reports: > > > > > > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: obj

Re: [Intel-gfx] [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Alex Deucher
On Fri, Jul 26, 2019 at 1:28 PM Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Note that this only covers the legacy display code. The new DC display code also needs to be converted. See: drivers/gpu/drm/amd/disp

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/uc: Reorder params in intel_uc_fw_fetch

2019-07-26 Thread Patchwork
== Series Details == Series: drm/i915/uc: Reorder params in intel_uc_fw_fetch URL : https://patchwork.freedesktop.org/series/64265/ State : success == Summary == CI Bug Log - changes from CI_DRM_6555_full -> Patchwork_13758_full Summary ---

Re: [Intel-gfx] [PATCH v6 23/24] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Alex Deucher
On Fri, Jul 26, 2019 at 1:29 PM Andrzej Pietrasiewicz wrote: > > Use the ddc pointer provided by the generic connector. > > Signed-off-by: Andrzej Pietrasiewicz Acked-by: Alex Deucher > --- > drivers/gpu/drm/radeon/radeon_connectors.c | 142 +++-- > 1 file changed, 106 inserti

Re: [Intel-gfx] [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-26 Thread Thomas Gleixner
On Fri, 26 Jul 2019, Chris Wilson wrote: > Quoting Thomas Gleixner (2019-07-25 22:55:45) > > On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > > > > > Objtool reports: > > > > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > > > .altinstr_replacement+0x36: redundant UACCESS d

Re: [Intel-gfx] [PATCH] drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-26 Thread Chris Wilson
Quoting Thomas Gleixner (2019-07-25 22:55:45) > On Thu, 25 Jul 2019, Josh Poimboeuf wrote: > > > Objtool reports: > > > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > > .altinstr_replacement+0x36: redundant UACCESS disable > > > > __copy_from_user() already does both ST

Re: [Intel-gfx] [PATCH 2/3] drm/i915/tgl: allow the reg_read ioctl to read the RCS TIMESTAMP register

2019-07-26 Thread Rodrigo Vivi
On Thu, Jul 25, 2019 at 05:24:11PM -0700, Lucas De Marchi wrote: > From: Jordan Justen > > This enables the Mesa driver to advertise support for ARB_timer_query, > and thus an OpenGL version higher than 3.2. > > Based on the ICL patch by Paulo Zanoni and CNL patch by Nanley Chery. > > Cc: Joona

[Intel-gfx] Review required [Was: Associate ddc adapters with connectors]

2019-07-26 Thread Sam Ravnborg
Hi all. Andrzej have done a good job following up on feedback and this series is now ready. We need ack on the patches touching the individual drivers before we can proceed. Please check your drivers and get back. Sam > Hi Andezej. > > On Fri, Jul 26, 2019 at 07:22:54PM +0200, Andrzej

Re: [Intel-gfx] [PATCH] drm/i915/uc: Don't fail on HuC firmware failure

2019-07-26 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-07-26 18:12:40) > HuC is usually not a critical component, so we can safely ignore > firmware load or authentication failures unless HuC was explicitly > requested by the user. > > Signed-off-by: Michal Wajdeczko > Cc: Daniele Ceraolo Spurio > Cc: Chris Wilson > C

[Intel-gfx] ✓ Fi.CI.BAT: success for Associate ddc adapters with connectors (rev3)

2019-07-26 Thread Patchwork
== Series Details == Series: Associate ddc adapters with connectors (rev3) URL : https://patchwork.freedesktop.org/series/63558/ State : success == Summary == CI Bug Log - changes from CI_DRM_6562 -> Patchwork_13773 Summary --- **SUC

Re: [Intel-gfx] [PATCH 3/4] drm/i915/tgl: Tigerlake only has global MOCS registers

2019-07-26 Thread Daniele Ceraolo Spurio
On 7/25/19 5:12 PM, Lucas De Marchi wrote: From: Michel Thierry Until Icelake, each engine had its own set of 64 MOCS registers. In order to simplify, Tigerlake moves to only 64 Global MOCS registers, which are no longer part of the engine context. Since these registers are now global, they a

Re: [Intel-gfx] [PATCH 3/4] drm/i915/tgl: Tigerlake only has global MOCS registers

2019-07-26 Thread Lis, Tomasz
On 2019-07-26 02:12, Lucas De Marchi wrote: From: Michel Thierry Until Icelake, each engine had its own set of 64 MOCS registers. In order to simplify, Tigerlake moves to only 64 Global MOCS registers, which are no longer part of the engine context. Since these registers are now global, they

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uc: Don't fail on HuC firmware failure

2019-07-26 Thread Patchwork
== Series Details == Series: drm/i915/uc: Don't fail on HuC firmware failure URL : https://patchwork.freedesktop.org/series/64326/ State : success == Summary == CI Bug Log - changes from CI_DRM_6562 -> Patchwork_13772 Summary --- **S

[Intel-gfx] [CI 3/3] drm/i915/uc: Remove redundant RSA offset definition

2019-07-26 Thread Michal Wajdeczko
According to Firmware layout definition, RSA signature is located after CSS header and uCode so actual RSA offset in the blob can be easily calculated when needed (and we need it only once). Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Reviewed-by: Daniele Ceraolo Spurio --- driv

[Intel-gfx] [CI 2/3] drm/i915/uc: Remove redundant ucode offset definition

2019-07-26 Thread Michal Wajdeczko
According to Firmware layout definition, uCode is located right after CSS header, so ucode offset is always same as header size. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Reviewed-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 6 ++ drivers/gpu/d

[Intel-gfx] [CI 1/3] drm/i915/uc: Remove redundant header_offset/size definitions

2019-07-26 Thread Michal Wajdeczko
According to Firmware layout definition, CSS header is located in front of the firmware blob, so header offset is always 0. Similarly, size of the CSS header is constant and currently used version is exactly 128. While here, move type/status enums up and keep them together. v2: use sizeof consist

Re: [Intel-gfx] [PATCH v6 00/24] Associate ddc adapters with connectors

2019-07-26 Thread Sam Ravnborg
Hi Andezej. On Fri, Jul 26, 2019 at 07:22:54PM +0200, Andrzej Pietrasiewicz wrote: > It is difficult for a user to know which of the i2c adapters is for which > drm connector. This series addresses this problem. > > The idea is to have a symbolic link in connector's sysfs directory, e.g.: > > ls

Re: [Intel-gfx] [PATCH 2/4] drm/i915/tgl: Define MOCS entries for Tigerlake

2019-07-26 Thread Daniele Ceraolo Spurio
On 7/25/19 5:12 PM, Lucas De Marchi wrote: From: Tomasz Lis The MOCS table is published as part of bspec, and versioned. Entries are supposed to never be modified, but new ones can be added. Adding entries increases table version. The patch includes version 1 entries. Two of the 3 legacy ent

Re: [Intel-gfx] [PATCH 1/3] drm/i915/tgl: Add hpd interrupt handling

2019-07-26 Thread Matt Roper
On Thu, Jul 25, 2019 at 04:48:11PM -0700, Lucas De Marchi wrote: > Add hotdplug detection for all ports on TGP. icp_hpd_detection_setup() > is refactored to be shared with TGP. > > While we increase the number of pins, add a BUILD_BUG_ON() to avoid > going over the number of bits allowed. > > v2:

[Intel-gfx] [PATCH v2] drm/i915: Allow sharing the idle-barrier from other kernel requests

2019-07-26 Thread Chris Wilson
By placing our idle-barriers in the i915_active fence tree, we expose those for reuse by other components that are issuing requests along the kernel_context. Reusing the proto-barrier active_node is perfectly fine as the new request implies a context-switch, and so an opportune point to run the idl

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Associate ddc adapters with connectors (rev3)

2019-07-26 Thread Patchwork
== Series Details == Series: Associate ddc adapters with connectors (rev3) URL : https://patchwork.freedesktop.org/series/63558/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5470455b0f61 drm: Add ddc link in sysfs created by drm_connector ab31f78e9dd9 drm: Add drm_connector_in

Re: [Intel-gfx] [PATCH 1/4] drm/i915/tgl: Move fault registers to their new offset

2019-07-26 Thread Daniele Ceraolo Spurio
On 7/25/19 5:12 PM, Lucas De Marchi wrote: The fault registers moved to another offset. The old location is now taken by the global MOCS registers, to be added in a follow up change. Based on previous patches by Michel Thierry . Cc: Daniele Ceraolo Spurio Signed-off-by: Lucas De Marchi Re

Re: [Intel-gfx] [PATCH 1/3] drm/i915/uc: Remove redundant header_offset/size definitions

2019-07-26 Thread Daniele Ceraolo Spurio
On 7/26/19 10:49 AM, Michal Wajdeczko wrote: On Fri, 26 Jul 2019 19:33:18 +0200, Daniele Ceraolo Spurio wrote: On 7/26/19 8:58 AM, Michal Wajdeczko wrote: According to Firmware layout definition, CSS header is located in front of the firmware blob, so header offset is always 0. Similarly

Re: [Intel-gfx] [PATCH 1/3] drm/i915/uc: Remove redundant header_offset/size definitions

2019-07-26 Thread Michal Wajdeczko
On Fri, 26 Jul 2019 19:33:18 +0200, Daniele Ceraolo Spurio wrote: On 7/26/19 8:58 AM, Michal Wajdeczko wrote: According to Firmware layout definition, CSS header is located in front of the firmware blob, so header offset is always 0. Similarly, size of the CSS header is constant and is 128

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uc: Remove redundant RSA offset definition

2019-07-26 Thread Daniele Ceraolo Spurio
On 7/26/19 8:58 AM, Michal Wajdeczko wrote: According to Firmware layout definition, RSA signature is located after CSS header and uCode so actual RSA offset in the blob can be easily calculated when needed (and we need it only once). Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio

Re: [Intel-gfx] [PATCH 2/3] drm/i915/uc: Remove redundant ucode offset definition

2019-07-26 Thread Daniele Ceraolo Spurio
On 7/26/19 8:58 AM, Michal Wajdeczko wrote: According to Firmware layout definition, uCode is located right after CSS header, so ucode offset is always same as header size. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 8 +++-

[Intel-gfx] [PATCH v6 19/24] drm/bridge: dumb-vga-dac: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/dumb-vga-dac.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/dumb-vga-dac.c b/drivers/gpu/drm/bridge/dumb-vga-dac.c index d32

Re: [Intel-gfx] [PATCH 1/3] drm/i915/uc: Remove redundant header_offset/size definitions

2019-07-26 Thread Daniele Ceraolo Spurio
On 7/26/19 8:58 AM, Michal Wajdeczko wrote: According to Firmware layout definition, CSS header is located in front of the firmware blob, so header offset is always 0. Similarly, size of the CSS header is constant and is 128. While here, move type/status enums up and keep them together. Signe

[Intel-gfx] [PATCH v6 23/24] drm/radeon: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/radeon/radeon_connectors.c | 142 +++-- 1 file changed, 106 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_connectors.c b/drivers/gpu/drm/r

[Intel-gfx] [PATCH v6 24/24] drm/i915: Provide ddc symlink in hdmi connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/i915/display/intel_hdmi.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_hdmi.c b/drivers/gpu/drm/i915/display/int

Re: [Intel-gfx] [PATCH v12 1/2] drm: Introduce new DRM_FORMAT_XYUV

2019-07-26 Thread Matt Roper
On Tue, Nov 20, 2018 at 04:27:21PM +0200, Ville Syrjälä wrote: > On Fri, Nov 09, 2018 at 11:39:15AM +0200, Stanislav Lisovskiy wrote: > > v5: This is YUV444 packed format same as AYUV, but without alpha, > > as supported by i915. > > > > v6: Removed unneeded initializer for new XYUV format. >

[Intel-gfx] [PATCH v6 22/24] drm/amdgpu: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- .../gpu/drm/amd/amdgpu/amdgpu_connectors.c| 96 ++- 1 file changed, 70 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c b/drivers/gpu/dr

[Intel-gfx] [PATCH v6 20/24] drm/bridge: dw-hdmi: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi

[Intel-gfx] [PATCH v6 21/24] drm/bridge: ti-tfp410: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/bridge/ti-tfp410.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-tfp410.c b/drivers/gpu/drm/bridge/ti-tfp410.c index dbf35c7bc85e

[Intel-gfx] [PATCH v6 17/24] drm/mgag200: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/mgag200/mgag200_mode.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drive

[Intel-gfx] [PATCH v6 18/24] drm/ast: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz Reviewed-by: Thomas Zimmermann --- drivers/gpu/drm/ast/ast_mode.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/as

[Intel-gfx] [PATCH v6 16/24] drm: sti: Provide ddc symlink in hdmi connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sti/sti_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/sti/sti_hdmi.c b/drivers/gpu/drm/sti/sti_hdmi.c index f03d617edc4c..33d06e0a916

[Intel-gfx] [PATCH v6 15/24] drm/tilcdc: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c index

[Intel-gfx] [PATCH v6 13/24] drm: zte: Provide ddc symlink in hdmi connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_hdmi.c b/drivers/gpu/drm/zte/zx_hdmi.c index a50f5a1f09b8..b98a1420dcd3 1

[Intel-gfx] [PATCH v6 14/24] drm: zte: Provide ddc symlink in vga connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/zte/zx_vga.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/zte/zx_vga.c b/drivers/gpu/drm/zte/zx_vga.c index 9b67e419280c..c4fa3bbaba78 1006

[Intel-gfx] [PATCH v6 12/24] drm/vc4: Provide ddc symlink in connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/vc4/vc4_hdmi.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index ee7d4e7b0ee3..eb57

[Intel-gfx] [PATCH v6 11/24] drm/imx: imx-tve: Provide ddc symlink in connector's sysfs

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-tve.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-tve.c b/drivers/gpu/drm/imx/imx-tve.c index 649515868f86..5bbfaa2cd0f4 1

[Intel-gfx] [PATCH v6 10/24] drm/imx: imx-ldb: Provide ddc symlink in connector's sysfs

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/imx/imx-ldb.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-ldb.c b/drivers/gpu/drm/imx/imx-ldb.c index de62a4cd4827..db461b6a257f

[Intel-gfx] [PATCH v6 09/24] drm/tegra: Provide ddc symlink in output connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/tegra/hdmi.c | 7 --- drivers/gpu/drm/tegra/sor.c | 7 --- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tegra/hdmi.c b/drivers/gpu/drm/tegra/

[Intel-gfx] [PATCH v6 08/24] drm/mediatek: Provide ddc symlink in hdmi connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/mediatek/mtk_hdmi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi.c b/drivers/gpu/drm/mediatek/mtk_hdmi.c index ce91b613

[Intel-gfx] [PATCH v6 06/24] drm/msm/hdmi: Provide ddc symlink in hdmi connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/msm/hdmi/hdmi_connector.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/msm/hdmi/hdmi_connector.c b/drivers/gpu/drm/msm/hdmi/hdmi_connector

[Intel-gfx] [PATCH v6 05/24] drm: rockchip: Provide ddc symlink in inno_hdmi sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/inno_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c index ed344a

[Intel-gfx] [PATCH v6 07/24] drm/sun4i: hdmi: Provide ddc symlink in sun4i hdmi connector sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c b/drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c index

[Intel-gfx] [PATCH v6 04/24] drm: rockchip: Provide ddc symlink in rk3066_hdmi sysfs directory

2019-07-26 Thread Andrzej Pietrasiewicz
Use the ddc pointer provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/rockchip/rk3066_hdmi.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c index

[Intel-gfx] [PATCH v6 03/24] drm/exynos: Provide ddc symlink in connector's sysfs

2019-07-26 Thread Andrzej Pietrasiewicz
Switch to using the ddc provided by the generic connector. Signed-off-by: Andrzej Pietrasiewicz --- drivers/gpu/drm/exynos/exynos_hdmi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c index bc

[Intel-gfx] [PATCH v6 02/24] drm: Add drm_connector_init() variant with ddc

2019-07-26 Thread Andrzej Pietrasiewicz
Allow passing ddc adapter pointer to the init function. Even if drm_connector_init() sometime in the future decides to e.g. memset() all connector fields to zeros, the newly added function ensures that at its completion the ddc member of connector is correctly set. Signed-off-by: Andrzej Pietrasie

[Intel-gfx] [PATCH v6 01/24] drm: Add ddc link in sysfs created by drm_connector

2019-07-26 Thread Andrzej Pietrasiewicz
Add generic code which creates symbolic links in sysfs, pointing to ddc interface used by a particular video output. For example: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0-HDMI-A-1/ddc \ -> ../../../../soc/1388.i2c/i2c-2 This ma

[Intel-gfx] [PATCH v6 00/24] Associate ddc adapters with connectors

2019-07-26 Thread Andrzej Pietrasiewicz
It is difficult for a user to know which of the i2c adapters is for which drm connector. This series addresses this problem. The idea is to have a symbolic link in connector's sysfs directory, e.g.: ls -l /sys/class/drm/card0-HDMI-A-1/ddc lrwxrwxrwx 1 root root 0 Jun 24 10:42 /sys/class/drm/card0

Re: [Intel-gfx] [PATCH] drm/i915/uc: Don't fail on HuC firmware failure

2019-07-26 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-07-26 18:12:40) > HuC is usually not a critical component, so we can safely ignore > firmware load or authentication failures unless HuC was explicitly > requested by the user. How soon before on-demand loading? :) -Chris _

[Intel-gfx] [PATCH] drm/i915/uc: Don't fail on HuC firmware failure

2019-07-26 Thread Michal Wajdeczko
HuC is usually not a critical component, so we can safely ignore firmware load or authentication failures unless HuC was explicitly requested by the user. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Chris Wilson Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/gt/uc/intel_uc.c

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/uc: Remove redundant header_offset/size definitions

2019-07-26 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/uc: Remove redundant header_offset/size definitions URL : https://patchwork.freedesktop.org/series/64322/ State : success == Summary == CI Bug Log - changes from CI_DRM_6560 -> Patchwork_13771 ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/uc: Remove redundant header_offset/size definitions

2019-07-26 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/uc: Remove redundant header_offset/size definitions URL : https://patchwork.freedesktop.org/series/64322/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/uc: Remove redundant hea

[Intel-gfx] [PATCH 2/3] drm/i915/uc: Remove redundant ucode offset definition

2019-07-26 Thread Michal Wajdeczko
According to Firmware layout definition, uCode is located right after CSS header, so ucode offset is always same as header size. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 8 +++- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 1 -

[Intel-gfx] [PATCH 1/3] drm/i915/uc: Remove redundant header_offset/size definitions

2019-07-26 Thread Michal Wajdeczko
According to Firmware layout definition, CSS header is located in front of the firmware blob, so header offset is always 0. Similarly, size of the CSS header is constant and is 128. While here, move type/status enums up and keep them together. Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo

[Intel-gfx] [PATCH 3/3] drm/i915/uc: Remove redundant RSA offset definition

2019-07-26 Thread Michal Wajdeczko
According to Firmware layout definition, RSA signature is located after CSS header and uCode so actual RSA offset in the blob can be easily calculated when needed (and we need it only once). Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/uc: Don't sanitize guc_log_level modparam

2019-07-26 Thread Patchwork
== Series Details == Series: drm/i915/uc: Don't sanitize guc_log_level modparam URL : https://patchwork.freedesktop.org/series/64264/ State : success == Summary == CI Bug Log - changes from CI_DRM_6553_full -> Patchwork_13757_full Summary -

Re: [Intel-gfx] [PATCH] drm/i915: Replace hangcheck by heartbeats

2019-07-26 Thread Bloomfield, Jon
> -Original Message- > From: Chris Wilson > Sent: Thursday, July 25, 2019 4:52 PM > To: Bloomfield, Jon ; intel- > g...@lists.freedesktop.org > Cc: Joonas Lahtinen ; Ursulin, Tvrtko > > Subject: RE: [PATCH] drm/i915: Replace hangcheck by heartbeats > > Quoting Bloomfield, Jon (2019-07-26

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Remove redundant user_access_end() from __copy_from_user() error path

2019-07-26 Thread Patchwork
== Series Details == Series: drm/i915: Remove redundant user_access_end() from __copy_from_user() error path URL : https://patchwork.freedesktop.org/series/64262/ State : success == Summary == CI Bug Log - changes from CI_DRM_6553_full -> Patchwork_13756_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915/perf: Initialise err to 0 before looping over ce->engines (rev2)

2019-07-26 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915/perf: Initialise err to 0 before looping over ce->engines (rev2) URL : https://patchwork.freedesktop.org/series/64309/ State : success == Summary == CI Bug Log - changes from CI_DRM_6559 -> Patchwork_13770 ===

Re: [Intel-gfx] [PATCH 2/3] drm/i915/tgl: Implement Wa_1604555607

2019-07-26 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-07-26 14:34:56) > > On 26/07/2019 14:20, Chris Wilson wrote: > > We can do rmw inside ctx_wa if we have to thanks to MI_MATH. Should we > > start preparing for that nightmare? :) > > When you say preparing it makes it sounds complicated so I want to say > no. But sur

Re: [Intel-gfx] [PATCH 1/5] drm/i915/userptr: Beware recursive lock_page()

2019-07-26 Thread Lionel Landwerlin
On 17/07/2019 21:09, Tvrtko Ursulin wrote: On 17/07/2019 15:06, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:46:15) On 17/07/2019 14:35, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-17 14:23:55) On 17/07/2019 14:17, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-1

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Add to timeline requires the timeline mutex

2019-07-26 Thread Tvrtko Ursulin
On 25/07/2019 14:14, Chris Wilson wrote: Modifying a remote context requires careful serialisation with requests on that context, and that serialisation requires us to take their timeline->mutex. Make it so. Note that while struct_mutex rules, we can't create more than one request in parallel,

Re: [Intel-gfx] [PATCH 2/3] drm/i915/tgl: Implement Wa_1604555607

2019-07-26 Thread Tvrtko Ursulin
On 26/07/2019 14:20, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-26 14:15:51) On 26/07/2019 01:10, Chris Wilson wrote: Quoting Lucas De Marchi (2019-07-26 01:02:25) From: Michel Thierry Implement Wa_1604555607 (set the DS pairing timer to 128 cycles). FF_MODE2 is part of the regist

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/perf: Initialise err to 0 before looping over ce->engines

2019-07-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/perf: Initialise err to 0 before looping over ce->engines URL : https://patchwork.freedesktop.org/series/64309/ State : success == Summary == CI Bug Log - changes from CI_DRM_6559 -> Patchwork_13769 =

  1   2   >