[Intel-gfx] ✗ Fi.CI.BAT: failure for More mmio and intel_gt cleanups and refactorings (rev2)

2019-07-02 Thread Patchwork
== Series Details == Series: More mmio and intel_gt cleanups and refactorings (rev2) URL : https://patchwork.freedesktop.org/series/63063/ State : failure == Summary == Patch format detection failed. ___ Intel-gfx mailing list Intel-gfx@lists.freede

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Report if i915_active is still busy upon waiting

2019-07-02 Thread Patchwork
== Series Details == Series: drm/i915: Report if i915_active is still busy upon waiting URL : https://patchwork.freedesktop.org/series/63062/ State : success == Summary == CI Bug Log - changes from CI_DRM_6394_full -> Patchwork_13487_full S

[Intel-gfx] ✓ Fi.CI.BAT: success for Improve whitelist selftest for read-only registers

2019-07-02 Thread Patchwork
== Series Details == Series: Improve whitelist selftest for read-only registers URL : https://patchwork.freedesktop.org/series/63102/ State : success == Summary == CI Bug Log - changes from CI_DRM_6398 -> Patchwork_13499 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Implement read-only support in whitelist selftest

2019-07-02 Thread John Harrison
Patches sent. I haven't made any changes to dmesg output as I'm not sure what you mean. Ah, do you mean the debug print in wa_init_finish()? Sure, I can add the engine name to that. John. On 6/25/2019 01:33, Tvrtko Ursulin wrote: Ping. We agreed to follow up with a test ASAP after mergin

[Intel-gfx] [PATCH 0/2] Improve whitelist selftest for read-only registers

2019-07-02 Thread John . C . Harrison
From: John Harrison Follow up patch to earlier whitelist updates. This series adds some extra sanity checking to the driver and improves the self-test. John Harrison (2): drm/i915: Add test for invalid flag bits in whitelist entries drm/i915: Implement read-only support in whitelist selftest

[Intel-gfx] [PATCH 1/2] drm/i915: Add test for invalid flag bits in whitelist entries

2019-07-02 Thread John . C . Harrison
From: John Harrison As per review feedback by Tvrtko, added a check that no invalid bits are being set in the whitelist flags fields. Also updated the read/write access definitions to make it clearer that they are an enum field not a set of single bit flags. Signed-off-by: John Harrison CC: Tv

[Intel-gfx] [PATCH 2/2] drm/i915: Implement read-only support in whitelist selftest

2019-07-02 Thread John . C . Harrison
From: John Harrison Newer hardware supports extra feature in the whitelist registers. This patch updates the selftest to test that entries marked as read only are actually read only. Signed-off-by: John Harrison CC: Tvrtko Ursulin --- .../gpu/drm/i915/gt/selftest_workarounds.c| 43 +++

[Intel-gfx] ✓ Fi.CI.IGT: success for Support mipi dsi video mode on TGL

2019-07-02 Thread Patchwork
== Series Details == Series: Support mipi dsi video mode on TGL URL : https://patchwork.freedesktop.org/series/63058/ State : success == Summary == CI Bug Log - changes from CI_DRM_6394_full -> Patchwork_13486_full Summary --- **SUCC

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Remove preemption support for current fw (rev2)

2019-07-02 Thread Patchwork
== Series Details == Series: drm/i915/guc: Remove preemption support for current fw (rev2) URL : https://patchwork.freedesktop.org/series/56767/ State : success == Summary == CI Bug Log - changes from CI_DRM_6394_full -> Patchwork_13485_full

Re: [Intel-gfx] [RFC 6/7] drm/i915: Try to make bigjoiner work in atomic check.

2019-07-02 Thread Manasi Navare
On Tue, Jul 02, 2019 at 09:42:04PM +0200, Maarten Lankhorst wrote: > When the clock is higher than the dotclock, try with 2 pipes enabled. > If we can enable 2, then we will go into big joiner mode, and steal > the adjacent crtc. > > This only links the planes in software, no hardware programming

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Free pages before rcu-freeing the object (rev2)

2019-07-02 Thread Patchwork
== Series Details == Series: drm/i915/gem: Free pages before rcu-freeing the object (rev2) URL : https://patchwork.freedesktop.org/series/63042/ State : success == Summary == CI Bug Log - changes from CI_DRM_6394_full -> Patchwork_13484_full

Re: [Intel-gfx] [RFC 4/7] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid()

2019-07-02 Thread Manasi Navare
On Tue, Jul 02, 2019 at 09:42:02PM +0200, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/display/intel_dp.c | 10 -- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/display/intel_dp.c > b/drivers/gpu/drm/i

[Intel-gfx] [PATCH v4 1/4] drm/panel: Add helper for reading DT rotation

2019-07-02 Thread Derek Basehore
This adds a helper function for reading the rotation (panel orientation) from the device tree. Signed-off-by: Derek Basehore --- drivers/gpu/drm/drm_panel.c | 43 + include/drm/drm_panel.h | 7 ++ 2 files changed, 50 insertions(+) diff --git a/driver

[Intel-gfx] [PATCH v4 4/4] drm/mtk: add panel orientation property

2019-07-02 Thread Derek Basehore
This inits the panel orientation property for the mediatek dsi driver if the panel orientation (connector.display_info.panel_orientation) is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN. Signed-off-by: Derek Basehore --- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 1 file changed, 8 insertions(+)

[Intel-gfx] [PATCH v4 0/4] Panel rotation patches

2019-07-02 Thread Derek Basehore
This adds the plumbing for reading panel rotation from the devicetree and sets up adding a panel property for the panel orientation on Mediatek SoCs when a rotation is present. v4 changes: -fixed some changes made to the i915 driver -clarified comments on of orientation helper v3 changes: -change

[Intel-gfx] [PATCH v4 3/4] drm/connector: Split out orientation quirk detection

2019-07-02 Thread Derek Basehore
Not every platform needs quirk detection for panel orientation, so split the drm_connector_init_panel_orientation_property into two functions. One for platforms without the need for quirks, and the other for platforms that need quirks. Signed-off-by: Derek Basehore --- drivers/gpu/drm/drm_connec

[Intel-gfx] [PATCH v4 2/4] drm/panel: set display info in panel attach

2019-07-02 Thread Derek Basehore
Devicetree systems can set panel orientation via a panel binding, but there's no way, as is, to propagate this setting to the connector, where the property need to be added. To address this, this patch sets orientation, as well as other fixed values for the panel, in the drm_panel_attach function.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Common live setup/teardown

2019-07-02 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Common live setup/teardown URL : https://patchwork.freedesktop.org/series/63099/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6398 -> Patchwork_13498 Summary --- **FA

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/guc: Remove preemption support for current fw

2019-07-02 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/guc: Remove preemption support for current fw URL : https://patchwork.freedesktop.org/series/63095/ State : success == Summary == CI Bug Log - changes from CI_DRM_6398 -> Patchwork_13497 =

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Common live setup/teardown

2019-07-02 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Common live setup/teardown URL : https://patchwork.freedesktop.org/series/63099/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5f846dba1d19 drm/i915/selftests: Common live setup/teardown -:239: CHECK:MACRO_ARG_REUSE: Macro argume

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use the "display core" power domain in vlv/chv set_cdclk()

2019-07-02 Thread Patchwork
== Series Details == Series: drm/i915: Use the "display core" power domain in vlv/chv set_cdclk() URL : https://patchwork.freedesktop.org/series/63045/ State : success == Summary == CI Bug Log - changes from CI_DRM_6394_full -> Patchwork_13483_full =

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/guc: Remove preemption support for current fw

2019-07-02 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/guc: Remove preemption support for current fw URL : https://patchwork.freedesktop.org/series/63095/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/guc: Remove preemption support

[Intel-gfx] ✓ Fi.CI.BAT: success for Bigjoiner atomic preparations.

2019-07-02 Thread Patchwork
== Series Details == Series: Bigjoiner atomic preparations. URL : https://patchwork.freedesktop.org/series/63094/ State : success == Summary == CI Bug Log - changes from CI_DRM_6398 -> Patchwork_13496 Summary --- **SUCCESS** No re

[Intel-gfx] [PATCH] drm/i915/selftests: Common live setup/teardown

2019-07-02 Thread Chris Wilson
We frequently, and not frequently enough, remember to flush residual openations and objects at the end of a live subtest. The purpose is to cleanup after every subtest, leaving a clean slate for the next subtest, and perform early detection of leaky state. Signed-off-by: Chris Wilson Cc: Tvrtko U

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/6] drm/i915: Check crtc_state->wm.need_postvbl_update before grabbing wm.mutex

2019-07-02 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915: Check crtc_state->wm.need_postvbl_update before grabbing wm.mutex URL : https://patchwork.freedesktop.org/series/63044/ State : success == Summary == CI Bug Log - changes from CI_DRM_6394_full -> Patchwork_13482_full ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Bigjoiner atomic preparations.

2019-07-02 Thread Patchwork
== Series Details == Series: Bigjoiner atomic preparations. URL : https://patchwork.freedesktop.org/series/63094/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Prepare to split crtc state in uapi and hw state -O:drivers/gpu/drm/i915/intel_pm

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Bigjoiner atomic preparations.

2019-07-02 Thread Patchwork
== Series Details == Series: Bigjoiner atomic preparations. URL : https://patchwork.freedesktop.org/series/63094/ State : warning == Summary == $ dim checkpatch origin/drm-tip b9e17bf6bac7 drm/i915: Prepare to split crtc state in uapi and hw state -:11: WARNING:COMMIT_LOG_LONG_LINE: Possible u

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: synchronize_irq() against the actual irq (rev2)

2019-07-02 Thread Patchwork
== Series Details == Series: drm/i915: synchronize_irq() against the actual irq (rev2) URL : https://patchwork.freedesktop.org/series/63081/ State : success == Summary == CI Bug Log - changes from CI_DRM_6398 -> Patchwork_13494 Summary

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dmc: protect against reading random memory (rev2)

2019-07-02 Thread Patchwork
== Series Details == Series: drm/i915/dmc: protect against reading random memory (rev2) URL : https://patchwork.freedesktop.org/series/61695/ State : failure == Summary == Applying: drm/i915/dmc: protect against reading random memory Using index info to reconstruct a base tree... M drive

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uc: replace uc init/fini misc

2019-07-02 Thread Daniele Ceraolo Spurio
On 7/2/19 1:52 PM, Michal Wajdeczko wrote: On Tue, 02 Jul 2019 22:09:47 +0200, Daniele Ceraolo Spurio wrote: The "misc" terminology doesn't clearly explain what we intend to cover in this phase. The only thing we do in there apart from FW fetch is initializing the log workqueue. We can move

Re: [Intel-gfx] [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-07-02 Thread Kees Cook
On Sat, Jun 29, 2019 at 09:45:10AM -0700, Joe Perches wrote: > On Sat, 2019-06-29 at 17:25 +0300, Alexey Dobriyan wrote: > > On Tue, Jun 11, 2019 at 03:00:10PM -0600, Andreas Dilger wrote: > > > On Jun 11, 2019, at 2:48 PM, Andrew Morton > > > wrote: > > > > On Wed, 12 Jun 2019 01:08:36 +0530 Shy

Re: [Intel-gfx] [PATCH 3/3] drm/i915/uc: replace uc init/fini misc

2019-07-02 Thread Michal Wajdeczko
On Tue, 02 Jul 2019 22:09:47 +0200, Daniele Ceraolo Spurio wrote: The "misc" terminology doesn't clearly explain what we intend to cover in this phase. The only thing we do in there apart from FW fetch is initializing the log workqueue. We can move the latter to the init_early phase and renam

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Enable hotplug retry

2019-07-02 Thread Souza, Jose
On Tue, 2019-07-02 at 23:29 +0300, Timo Aaltonen wrote: > On 2.7.2019 22.54, Souza, Jose wrote: > > Here a dmesg output of this patch working in a unpowered type-c > > dongle: > > https://gist.github.com/zehortigoza/93c54b03fb65237cc1a2e193acef61a8 > > > > With the latest type-c patches from Imre

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Enable hotplug retry

2019-07-02 Thread Timo Aaltonen
On 2.7.2019 22.54, Souza, Jose wrote: > Here a dmesg output of this patch working in a unpowered type-c dongle: > https://gist.github.com/zehortigoza/93c54b03fb65237cc1a2e193acef61a8 > > With the latest type-c patches from Imre it is becoming really hard to > reproduce this but is still possible,

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/gt: Use caller provided forcewake for intel_mocs_init_engine

2019-07-02 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gt: Use caller provided forcewake for intel_mocs_init_engine URL : https://patchwork.freedesktop.org/series/63082/ State : success == Summary == CI Bug Log - changes from CI_DRM_6397 -> Patchwork_13493 ==

[Intel-gfx] [PATCH 1/3] drm/i915/guc: Remove preemption support for current fw

2019-07-02 Thread Daniele Ceraolo Spurio
From: Chris Wilson Preemption via GuC submission is not being supported with its current legacy incarnation. The current FW does support a similar pre-emption flow via H2G, but it is class-based instead of being instance-based, which doesn't fit well with the i915 tracking. To fix this, the firmw

[Intel-gfx] [PATCH 3/3] drm/i915/uc: replace uc init/fini misc

2019-07-02 Thread Daniele Ceraolo Spurio
The "misc" terminology doesn't clearly explain what we intend to cover in this phase. The only thing we do in there apart from FW fetch is initializing the log workqueue. We can move the latter to the init_early phase and rename the function to clarify that they only fetch/release the blobs. Signe

[Intel-gfx] [PATCH 2/3] drm/i915/guc: simplify guc client

2019-07-02 Thread Daniele Ceraolo Spurio
We originally added support, in some cases partial, for different modes of operations via guc clients: - proxy vs direct submission; - variable engine mask per-client. We only ever used one flow (all submissions via a single proxy), so the other code paths haven't been exercised and are most like

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Enable hotplug retry

2019-07-02 Thread Souza, Jose
Here a dmesg output of this patch working in a unpowered type-c dongle: https://gist.github.com/zehortigoza/93c54b03fb65237cc1a2e193acef61a8 With the latest type-c patches from Imre it is becoming really hard to reproduce this but is still possible, also looks like due some internal error on the d

[Intel-gfx] [RFC 4/7] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid()

2019-07-02 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_dp.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index d5c56ea079a4..b41ff88d3258 100644 --- a/drivers/gpu/

[Intel-gfx] [RFC 2/7] drm/i915: Handle a few more cases for hw/sw split

2019-07-02 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_display.c | 38 ++-- drivers/gpu/drm/i915/display/intel_dp_mst.c | 2 +- drivers/gpu/drm/i915/display/intel_psr.c | 4 +-- 3 files changed, 22 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/dr

[Intel-gfx] [RFC 0/7] Bigjoiner atomic preparations.

2019-07-02 Thread Maarten Lankhorst
This is just a proof of concept for the software state, not sure I handled every case correctly, and completely untested on real hardware. Maarten Lankhorst (7): drm/i915: Prepare to split crtc state in uapi and hw state drm/i915: Handle a few more cases for hw/sw split drm/i915: Complete sw

[Intel-gfx] [RFC 3/7] drm/i915: Complete sw/hw split

2019-07-02 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_atomic.c | 44 drivers/gpu/drm/i915/display/intel_atomic.h | 2 + drivers/gpu/drm/i915/display/intel_display.c | 39 ++--- drivers/gpu/drm/i915/intel_drv.h | 8 ++-- 4 files ch

[Intel-gfx] [RFC 5/7] drm/i915/dp: Validate modes that can only be handled in a bigjoiner configuration

2019-07-02 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_dp.c | 234 +--- drivers/gpu/drm/i915/display/intel_dp.h | 4 - 2 files changed, 130 insertions(+), 108 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/

[Intel-gfx] [RFC 6/7] drm/i915: Try to make bigjoiner work in atomic check.

2019-07-02 Thread Maarten Lankhorst
When the clock is higher than the dotclock, try with 2 pipes enabled. If we can enable 2, then we will go into big joiner mode, and steal the adjacent crtc. This only links the planes in software, no hardware programming is done yet. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/dis

[Intel-gfx] [RFC 7/7] drm/i915: Allow vdsc functions to be called without encoder.

2019-07-02 Thread Maarten Lankhorst
This can be useful when calling the vdsc enable functions directly without encoder. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_vdsc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_vdsc.c b/drivers/gpu/

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gt: Use caller provided forcewake for intel_mocs_init_engine

2019-07-02 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gt: Use caller provided forcewake for intel_mocs_init_engine URL : https://patchwork.freedesktop.org/series/63082/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1d27975cb696 drm/i915/gt: Use caller provided force

[Intel-gfx] [PATCH stable-4.9+] drm/i915/dmc: protect against reading random memory

2019-07-02 Thread Lucas De Marchi
commit bc7b488b1d1c71dc4c5182206911127bc6c410d6 upstream. While loading the DMC firmware we were double checking the headers made sense, but in no place we checked that we were actually reading memory we were supposed to. This could be wrong in case the firmware file is truncated or malformed. Be

[Intel-gfx] ✓ Fi.CI.IGT: success for Extend BT2020 support in iCSC and fixes (rev5)

2019-07-02 Thread Patchwork
== Series Details == Series: Extend BT2020 support in iCSC and fixes (rev5) URL : https://patchwork.freedesktop.org/series/60480/ State : success == Summary == CI Bug Log - changes from CI_DRM_6379_full -> Patchwork_13466_full Summary -

[Intel-gfx] [PATCH i-g-t] i915/gem_create: Show number of pages cleared

2019-07-02 Thread Chris Wilson
Just a little bit of feedback at the end of an otherwise quiet 20s. Signed-off-by: Chris Wilson --- tests/i915/gem_create.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c index 9008cd8a2..aed7d1cec 100644 ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/display: Exploratory patch for fi-icl-dsi (rev2)

2019-07-02 Thread Patchwork
== Series Details == Series: drm/i915/display: Exploratory patch for fi-icl-dsi (rev2) URL : https://patchwork.freedesktop.org/series/63069/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6396 -> Patchwork_13492 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Vulkan performance query support (rev6)

2019-07-02 Thread Patchwork
== Series Details == Series: drm/i915: Vulkan performance query support (rev6) URL : https://patchwork.freedesktop.org/series/60916/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6390_full -> Patchwork_13480_full Summary --

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with drm/i915/gem: Free pages before rcu-freeing the object (rev2)

2019-07-02 Thread Patchwork
== Series Details == Series: series starting with drm/i915/gem: Free pages before rcu-freeing the object (rev2) URL : https://patchwork.freedesktop.org/series/63076/ State : success == Summary == CI Bug Log - changes from CI_DRM_6396 -> Patchwork_13491

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Rework some interrupt handling functions to take intel_gt

2019-07-02 Thread Daniele Ceraolo Spurio
On 7/2/19 4:45 AM, Tvrtko Ursulin wrote: On 02/07/2019 11:34, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-02 11:23:11) From: Tvrtko Ursulin Some interrupt handling functions already have gt in their names suggesting them as obvious candidates to make them take struct intel_gt inste

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tgl: Enable HDCP 1.4 and 2.2 on Gen12+

2019-07-02 Thread Patchwork
== Series Details == Series: drm/i915/tgl: Enable HDCP 1.4 and 2.2 on Gen12+ URL : https://patchwork.freedesktop.org/series/63074/ State : success == Summary == CI Bug Log - changes from CI_DRM_6396 -> Patchwork_13490 Summary --- **W

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] Revert "drm/i915: Introduce private PAT management"

2019-07-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] Revert "drm/i915: Introduce private PAT management" URL : https://patchwork.freedesktop.org/series/63065/ State : success == Summary == CI Bug Log - changes from CI_DRM_6396 -> Patchwork_13489

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] Revert "drm/i915: Introduce private PAT management"

2019-07-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] Revert "drm/i915: Introduce private PAT management" URL : https://patchwork.freedesktop.org/series/63065/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: Revert "drm/i915: Introduce private PAT ma

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] Revert "drm/i915: Introduce private PAT management"

2019-07-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] Revert "drm/i915: Introduce private PAT management" URL : https://patchwork.freedesktop.org/series/63065/ State : warning == Summary == $ dim checkpatch origin/drm-tip 73077b75c985 Revert "drm/i915: Introduce private PAT management" -:26

[Intel-gfx] [PATCH v2] drm/i915: synchronize_irq() against the actual irq

2019-07-02 Thread Ville Syrjala
From: Ville Syrjälä When eliminating our use of drm_irq_install() I failed to convert all our synchronize_irq() calls to consult pdev->irq instead of dev_priv->drm.irq. As we no longer populate dev_priv->drm.irq we're no longer synchronizing against anything. v2: Add intel_syncrhonize_irq() (Chr

Re: [Intel-gfx] [PATCH] drm/i915: synchronize_irq() against the actual irq

2019-07-02 Thread Imre Deak
On Tue, Jul 02, 2019 at 03:58:46PM +0100, Chris Wilson wrote: > Quoting Ville Syrjala (2019-07-02 15:49:47) > > From: Ville Syrjälä > > > > When eliminating our use of drm_irq_install() I failed to convert > > all our synchronize_irq() calls to consult pdev->irq instead of > > dev_priv->drm.irq.

Re: [Intel-gfx] [CI] drm/i915: Fix memleak in runtime wakeref tracking

2019-07-02 Thread Chris Wilson
Quoting Mika Kuoppala (2019-07-01 11:44:42) > If we untrack wakerefs, the actual count may reach zero. > However the krealloced owners array is still there and > needs to be taken care of. Free the owners unconditionally > to fix the leak. > > Fixes: bd780f37a361 ("drm/i915: Track all held rpm wak

[Intel-gfx] [PATCH 3/3] drm/i915/gt: Ignore forcewake acquisition for posting_reads

2019-07-02 Thread Chris Wilson
We don't care about the result of the read, so it may be garbage, we only care that the mmio is flushed. As such, we can forgo using an individual forcewake and lock around any posting-read for an engine. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_engine.h | 2 +- 1 file chang

[Intel-gfx] [PATCH 2/3] drm/i915/gt: Assume we hold forcewake for execlists resume

2019-07-02 Thread Chris Wilson
We can assume the caller is holding a blanket forcewake for the register writes during resume, and so we can skip taking individual locks around each write inside execlists resume. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 23 --- 1 file changed, 1

[Intel-gfx] [PATCH 1/3] drm/i915/gt: Use caller provided forcewake for intel_mocs_init_engine

2019-07-02 Thread Chris Wilson
During post-reset resume, we call intel_mocs_init_engine to reinitialise the MOCS registers. Suprisingly, especially when enhanced by lockdep, the acquisition of the forcewake lock around each register write takes a substantial portion of the reset time. We don't need to use the individual forcewak

[Intel-gfx] [PATCH] drm/i915: synchronize_irq() against the actual irq

2019-07-02 Thread Ville Syrjala
From: Ville Syrjälä When eliminating our use of drm_irq_install() I failed to convert all our synchronize_irq() calls to consult pdev->irq instead of dev_priv->drm.irq. As we no longer populate dev_priv->drm.irq we're no longer synchronizing against anything. Cc: Chris Wilson Reported-by: Imre

Re: [Intel-gfx] [PATCH] drm/i915: synchronize_irq() against the actual irq

2019-07-02 Thread Chris Wilson
Quoting Ville Syrjala (2019-07-02 15:49:47) > From: Ville Syrjälä > > When eliminating our use of drm_irq_install() I failed to convert > all our synchronize_irq() calls to consult pdev->irq instead of > dev_priv->drm.irq. As we no longer populate dev_priv->drm.irq > we're no longer synchronizing

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix memleak in runtime wakeref tracking

2019-07-02 Thread Patchwork
== Series Details == Series: drm/i915: Fix memleak in runtime wakeref tracking URL : https://patchwork.freedesktop.org/series/63031/ State : success == Summary == CI Bug Log - changes from CI_DRM_6390_full -> Patchwork_13479_full Summary --

[Intel-gfx] [PATCH i-g-t] i915/gem_eio: Assert the hanging request is correctly identified

2019-07-02 Thread Chris Wilson
When forcing a reset, it is crucial that the kernel correctly identifies the injected hang. Verify this is the case for reset-stress. Signed-off-by: Chris Wilson --- Keep the igt_spin_free at the end to avoid issues where we fail to bypass the guilty batch. --- tests/i915/gem_eio.c | 17

[Intel-gfx] [PATCH] drm/i915/display: Handle lost primary_port across suspend

2019-07-02 Thread Chris Wilson
icl-dsi is dying on suspend/resume at RIP: 0010:icl_update_active_dpll+0x2c/0xa0 [i915] which appears due to the loss of the time primary_port across suspend. Protect against the potential NULL dereference by assuming ICL_PORT_DPLL_DEFAULT unless the port is actively specified otherwise.

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/12] drm/i915/guc: Avoid reclaim locks during reset

2019-07-02 Thread Patchwork
== Series Details == Series: series starting with [01/12] drm/i915/guc: Avoid reclaim locks during reset URL : https://patchwork.freedesktop.org/series/63029/ State : success == Summary == CI Bug Log - changes from CI_DRM_6390_full -> Patchwork_13478_full =

Re: [Intel-gfx] [PATCH] drm/i915/display: Exploratory patch for fi-icl-dsi

2019-07-02 Thread Imre Deak
On Tue, Jul 02, 2019 at 01:33:26PM +0100, Chris Wilson wrote: > icl-dsi is dying on suspend/resume at > > RIP: 0010:icl_update_active_dpll+0x2c/0xa0 [i915] > > so take a guess that it is the primary_port is NULL. Yes, DSI ports are not intel_digital_ports but use the shared DPLL code. Not

Re: [Intel-gfx] [PATCH 1/2] drm: report dp downstream port type as a subconnector property

2019-07-02 Thread Emil Velikov
Hi Oleg, On Mon, 1 Jul 2019 at 09:00, Oleg Vasilev wrote: > > Currently, downstream port type is only reported in debugfs. This > information should be considered important since it reflects the actual > physical connector type. Some userspace (e.g. window compositors) > may want to show this inf

[Intel-gfx] [PATCH] drm/i915/gem: Free pages before rcu-freeing the object

2019-07-02 Thread Chris Wilson
As we have dropped the final reference to the object, we do not need to wait until after the rcu grace period to drop its pages. We still require struct_mutex to completely unbind the object to release the pages, so we still need a free-worker to manage that from process context. By scheduling the

[Intel-gfx] [PATCH 4/4] drm/i915/selftests: Lock the drm_mm while modifying

2019-07-02 Thread Chris Wilson
Remember to lock the drm_mm as we modify it, lest it be modified in the background by retire/free workers! Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_mman.c

[Intel-gfx] [PATCH 2/4] drm/i915: Markup potential lock for i915_active

2019-07-02 Thread Chris Wilson
Make the lockchains more deterministic via i915_active by flagging the potential lock. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_active.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_active.c b/drivers/gpu/drm/i915/i915_active.c index 584b247df

[Intel-gfx] [PATCH 1/4] drm/i915/gem: Free pages before rcu-freeing the object

2019-07-02 Thread Chris Wilson
As we have dropped the final reference to the object, we do not need to wait until after the rcu grace period to drop its pages. We still require struct_mutex to completely unbind the object to release the pages, so we still need a free-worker to manage that from process context. By scheduling the

[Intel-gfx] [PATCH 3/4] drm/i915: Mark up vma->active as safe for use inside shrinkers

2019-07-02 Thread Chris Wilson
Since a shrinker may be forced to wait on GPU activity, i915_active_wait(&vma->active) must be safe for use inside a shrinker, and so let's mark up the lock as being acquired by the shrinker to avoid any nasty surprises creeping in. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_vma.c

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Extend BT2020 support in iCSC and fixes (rev5)

2019-07-02 Thread Shankar, Uma
>-Original Message- >From: Peres, Martin >Sent: Monday, July 1, 2019 7:05 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org >Subject: Re: ✗ Fi.CI.BAT: failure for Extend BT2020 support in iCSC and fixes >(rev5) > >On 28/06/2019 18:06, Shankar, Uma wrote: >> >> >>> -Original Mess

[Intel-gfx] [PATCH] drm/i915/tgl: Enable HDCP 1.4 and 2.2 on Gen12+

2019-07-02 Thread Ramalingam C
From Gen12 onwards, HDCP HW block is implemented within transcoders. Till Gen11 HDCP HW block was part of DDI. Hence required changes in HW programming is handled here. v2: _MMIO_TRANS is used [Lucas and Daniel] platform check is moved into the caller [Lucas] v3: platform check is moved int

Re: [Intel-gfx] [PATCH 1/2] drm: report dp downstream port type as a subconnector property

2019-07-02 Thread Ville Syrjälä
On Mon, Jul 01, 2019 at 11:00:21AM +0300, Oleg Vasilev wrote: > Currently, downstream port type is only reported in debugfs. This > information should be considered important since it reflects the actual > physical connector type. Some userspace (e.g. window compositors) > may want to show this inf

[Intel-gfx] [PATCH] drm/i915/display: Exploratory patch for fi-icl-dsi

2019-07-02 Thread Chris Wilson
icl-dsi is dying on suspend/resume at RIP: 0010:icl_update_active_dpll+0x2c/0xa0 [i915] so take a guess that it is the primary_port is NULL. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-)

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT

2019-07-02 Thread Lionel Landwerlin
On 02/07/2019 15:30, Mika Kuoppala wrote: Lionel Landwerlin writes: The same tests failing on CFL+ platforms are also failing on ICL. Documentation doesn't list the WaAllowPMDepthAndInvocationCountAccessFromUMD workaround for ICL but applying it fixes the same tests as CFL. Didn't find more d

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT

2019-07-02 Thread Mika Kuoppala
Lionel Landwerlin writes: > The same tests failing on CFL+ platforms are also failing on ICL. > Documentation doesn't list the > WaAllowPMDepthAndInvocationCountAccessFromUMD workaround for ICL but > applying it fixes the same tests as CFL. Didn't find more documentation either but I have asked

Re: [Intel-gfx] [PATCH v7 2/3] drm/i915: whitelist PS_(DEPTH|INVOCATION)_COUNT

2019-07-02 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Lionel Landwerlin (2019-06-28 13:07:19) >> CFL:C0+ changed the status of those registers which are now >> blacklisted by default. >> >> This is breaking a number of CTS tests on GL & Vulkan : >> >> >> KHR-GL45.pipeline_statistics_query_tests_ARB.functional_frag

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915: Introduce private PAT management"

2019-07-02 Thread Chris Wilson
Quoting Michał Winiarski (2019-07-02 12:31:48) > This reverts commit 4395890a48551982549d222d1923e2833dac47cf. > > It's been over a year since this was merged, and the actual users of > intel_ppat_get / intel_ppat_put never materialized. > > Time to remove it! > > v2: Unbreak suspend (Chris) > v

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gtt: Don't check PPGTT presence on PPGTT-only platforms

2019-07-02 Thread Chris Wilson
Quoting Michał Winiarski (2019-07-02 12:31:49) > We missed one place where we check PPGTT-only platform for PPGTT > presence. Let's remove it. > While I'm here let's assert that this particular code is never called on > pre-gen8 platforms. > > References: 4bdafb9ddfa4 ("drm/i915: Remove i915.enabl

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Rework some interrupt handling functions to take intel_gt

2019-07-02 Thread Tvrtko Ursulin
On 02/07/2019 11:34, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-07-02 11:23:11) From: Tvrtko Ursulin Some interrupt handling functions already have gt in their names suggesting them as obvious candidates to make them take struct intel_gt instead of i915. Signed-off-by: Paulo Zanoni Co

Re: [Intel-gfx] [PATCH i-g-t] i915: Fix gem_context_has_engine_map() for older kernels

2019-07-02 Thread Tvrtko Ursulin
On 02/07/2019 11:50, Chris Wilson wrote: CI is currently breaking on linus/drm-intel-fixes due to the assert that the kernel supports context engine maps. Report the lack of maps on older kernels gracefully! Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- lib/i915/gem_engine_topology.c |

[Intel-gfx] [PATCH i-g-t] i915/gem_eio: Assert the hanging request is correctly identified

2019-07-02 Thread Chris Wilson
When forcing a reset, it is crucial that the kernel correctly identifies the injected hang. Verify this is the case for reset-stress. Signed-off-by: Chris Wilson --- tests/i915/gem_eio.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/tests/i915/gem_eio.c

[Intel-gfx] [PATCH 1/2] Revert "drm/i915: Introduce private PAT management"

2019-07-02 Thread Michał Winiarski
This reverts commit 4395890a48551982549d222d1923e2833dac47cf. It's been over a year since this was merged, and the actual users of intel_ppat_get / intel_ppat_put never materialized. Time to remove it! v2: Unbreak suspend (Chris) v3: Rebase, drop fixes tag to avoid confusion Signed-off-by: Mich

Re: [Intel-gfx] [PATCH v6 06/11] drm/i915: introduce a mechanism to extend execbuf2

2019-07-02 Thread Lionel Landwerlin
On 01/07/2019 18:17, Chris Wilson wrote: Quoting Lionel Landwerlin (2019-07-01 12:34:32) We're planning to use this for a couple of new feature where we need to provide additional parameters to execbuf. Signed-off-by: Lionel Landwerlin Looks ok, are you convinced by I915_EXEC_EXT? It doesn't

[Intel-gfx] [PATCH 2/2] drm/i915/gtt: Don't check PPGTT presence on PPGTT-only platforms

2019-07-02 Thread Michał Winiarski
We missed one place where we check PPGTT-only platform for PPGTT presence. Let's remove it. While I'm here let's assert that this particular code is never called on pre-gen8 platforms. References: 4bdafb9ddfa4 ("drm/i915: Remove i915.enable_ppgtt override") Signed-off-by: Michał Winiarski Cc: Chr

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: CTS fixes (rev7)

2019-07-02 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-06-29 14:00:40) > Okay to land? Pushed with my ack. Thanks for the patches and sorry that simple changes with such clear causality take so long to get reviewed. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm: report dp downstream port type as a subconnector property

2019-07-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm: report dp downstream port type as a subconnector property URL : https://patchwork.freedesktop.org/series/63026/ State : success == Summary == CI Bug Log - changes from CI_DRM_6389_full -> Patchwork_13477_full ===

Re: [Intel-gfx] [PATCH] drm/i915: fix whitelist selftests with readonly registers

2019-07-02 Thread Chris Wilson
Quoting Chris Wilson (2019-06-29 14:13:50) > From: Lionel Landwerlin > > When a register is readonly there is not much we can tell about its > value (apart from its default value?). This can be covered by tests > exercising the value of the register from userspace. > > For PS_INVOCATION_COUNT we

Re: [Intel-gfx] [PATCH v7 3/3] drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT

2019-07-02 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-06-28 13:07:20) > The same tests failing on CFL+ platforms are also failing on ICL. > Documentation doesn't list the > WaAllowPMDepthAndInvocationCountAccessFromUMD workaround for ICL but > applying it fixes the same tests as CFL. > > v2: Use only one whitelist entr

Re: [Intel-gfx] [PATCH v7 2/3] drm/i915: whitelist PS_(DEPTH|INVOCATION)_COUNT

2019-07-02 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-06-28 13:07:19) > CFL:C0+ changed the status of those registers which are now > blacklisted by default. > > This is breaking a number of CTS tests on GL & Vulkan : > > > KHR-GL45.pipeline_statistics_query_tests_ARB.functional_fragment_shader_invocations > (GL)

[Intel-gfx] ✗ Fi.CI.BAT: failure for More mmio and intel_gt cleanups and refactorings

2019-07-02 Thread Patchwork
== Series Details == Series: More mmio and intel_gt cleanups and refactorings URL : https://patchwork.freedesktop.org/series/63063/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6394 -> Patchwork_13488 Summary --- **

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Report if i915_active is still busy upon waiting

2019-07-02 Thread Patchwork
== Series Details == Series: drm/i915: Report if i915_active is still busy upon waiting URL : https://patchwork.freedesktop.org/series/63062/ State : success == Summary == CI Bug Log - changes from CI_DRM_6394 -> Patchwork_13487 Summary ---

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for More mmio and intel_gt cleanups and refactorings

2019-07-02 Thread Chris Wilson
Quoting Patchwork (2019-07-02 11:46:48) > == Series Details == > > Series: More mmio and intel_gt cleanups and refactorings > URL : https://patchwork.freedesktop.org/series/63063/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > a59370ad3ca8 drm/i915: Rework some inter

  1   2   >