[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/7] drm/i915: Teach execbuffer to take the engine wakeref not GT

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Teach execbuffer to take the engine wakeref not GT URL : https://patchwork.freedesktop.org/series/62814/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Teach execbuffer to tak

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/7] drm/i915: Teach execbuffer to take the engine wakeref not GT

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Teach execbuffer to take the engine wakeref not GT URL : https://patchwork.freedesktop.org/series/62814/ State : warning == Summary == $ dim checkpatch origin/drm-tip 721f8ff8918f drm/i915: Teach execbuffer to take the engine w

[Intel-gfx] [PATCH 4/7] drm/i915/gt: Guard timeline pinning with its own mutex

2019-06-26 Thread Chris Wilson
In preparation for removing struct_mutex from around context retirement, we need to make timeline pinning safe. Since multiple engines/contexts can share a single timeline, it needs to be protected by a mutex. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_timeline.c | 27 +++

[Intel-gfx] [PATCH 5/7] drm/i915: Include the breadcrumb when asserting request completion

2019-06-26 Thread Chris Wilson
As we explode, include the breadcrumb results in the trace for why we choose to explode on the request completion assertion failure. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 2 +- drivers/gpu/drm/i915/i915_request.c | 2 +- drivers/gpu/drm/i915/i915_request.h | 12

[Intel-gfx] [PATCH 6/7] drm/i915: Protect request retirement with timeline->mutex

2019-06-26 Thread Chris Wilson
Forgo the struct_mutex requirement for request retirement as we have been transitioning over to only using the timeline->mutex for controlling the lifetime of a request on that timeline. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gem/i915_gem_execbuffer.c| 192 ++ drive

[Intel-gfx] [PATCH 7/7] drm/i915: Replace struct_mutex for batch pool serialisation

2019-06-26 Thread Chris Wilson
Switch to tracking activity via i915_active on individual nodes, only keeping a list of retired objects in the cache, and reaping the cache when the engine itself idles. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/Makefile | 2 +- .../gpu/drm

[Intel-gfx] [PATCH 3/7] drm/i915/gt: Convert timeline tracking to spinlock

2019-06-26 Thread Chris Wilson
Convert the list manipulation of active to use spinlocks so that we can perform the updates from underneath a quick interrupt callback. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_gt_types.h | 2 +- drivers/gpu/drm/i915/gt/intel_reset.c| 13 ++--- drivers/gpu/drm/i

[Intel-gfx] [PATCH 2/7] drm/i915/gt: Track timeline activeness in enter/exit

2019-06-26 Thread Chris Wilson
Lift moving the timeline to/from the active_list on enter/exit in order to shorten the active tracking span in comparison to the existing pin/unpin. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_pm.c| 1 - drivers/gpu/drm/i915/gt/intel_context.c | 2 + drivers

[Intel-gfx] [PATCH 1/7] drm/i915: Teach execbuffer to take the engine wakeref not GT

2019-06-26 Thread Chris Wilson
In the next patch, we would like to couple into the engine wakeref to free the batch pool on idling. The caveat here is that we therefore want to track the engine wakeref more precisely and to hold it instead of the broader GT wakeref as we process the ioctl. Signed-off-by: Chris Wilson --- .../

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Add a wakeref getter for iff the wakeref is already active

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Add a wakeref getter for iff the wakeref is already active URL : https://patchwork.freedesktop.org/series/62795/ State : success == Summary == CI Bug Log - changes from CI_DRM_6362_full -> Patchwork_13443_full =

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/drm_vblank: Change EINVAL by the correct errno (rev5)

2019-06-26 Thread Patchwork
== Series Details == Series: drm/drm_vblank: Change EINVAL by the correct errno (rev5) URL : https://patchwork.freedesktop.org/series/51147/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6370 -> Patchwork_13447 Summary

[Intel-gfx] [PATCH V5] drm/drm_vblank: Change EINVAL by the correct errno

2019-06-26 Thread Rodrigo Siqueira
For historical reasons, the function drm_wait_vblank_ioctl always return -EINVAL if something gets wrong. This scenario limits the flexibility for the userspace to make detailed verification of any problem and take some action. In particular, the validation of “if (!dev->irq_enabled)” in the drm_wa

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2,01/13] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [v2,01/13] drm/i915: prefix header search path with $(srctree)/ URL : https://patchwork.freedesktop.org/series/62791/ State : success == Summary == CI Bug Log - changes from CI_DRM_6359_full -> Patchwork_13442_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: prefix header search path with $(srctree)/ URL : https://patchwork.freedesktop.org/series/62790/ State : success == Summary == CI Bug Log - changes from CI_DRM_6359_full -> Patchwork_13441_full =

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Add support for DPLL4 (v8)

2019-06-26 Thread Souza, Jose
On Fri, 2019-06-21 at 19:00 -0700, Vivek Kasireddy wrote: > This patch adds support for DPLL4 on EHL that include the > following restrictions: > > - DPLL4 cannot be used with DDIA (combo port A internal eDP usage). > DPLL4 can be used with other DDIs, including DDID > (combo port A external u

Re: [Intel-gfx] [PATCH v2 12/23] drm/i915: Sanitize the TypeC connect/detect sequences

2019-06-26 Thread Souza, Jose
On Thu, 2019-06-20 at 17:05 +0300, Imre Deak wrote: > Make the order during detection more consistent: first reset the > TypeC > port mode if needed (adding new helpers for this), then detect any > connected sink. > > To check if a port mode reset is needed determine first the target > port > mode

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915/selftests: Serialise nop reset with retirement

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/selftests: Serialise nop reset with retirement URL : https://patchwork.freedesktop.org/series/62784/ State : success == Summary == CI Bug Log - changes from CI_DRM_6359_full -> Patchwork_13440_full ===

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Make i945gm_vblank_work_func static

2019-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Make i945gm_vblank_work_func static URL : https://patchwork.freedesktop.org/series/62807/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6366 -> Patchwork_13446 Summary --- **FAI

Re: [Intel-gfx] [PATCH 13/28] drm/i915/tgl: Add new pll ids

2019-06-26 Thread Srivatsa, Anusha
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Lucas De Marchi >Sent: Tuesday, June 25, 2019 10:54 AM >To: intel-gfx@lists.freedesktop.org >Cc: De Marchi, Lucas >Subject: [Intel-gfx] [PATCH 13/28] drm/i915/tgl: Add new pll ids > >From:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Make i945gm_vblank_work_func static

2019-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Make i945gm_vblank_work_func static URL : https://patchwork.freedesktop.org/series/62807/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Make i945gm_vblank_work_func static -O:drivers/gpu/drm/i915/i915_i

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Move OA files to separate folder

2019-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Move OA files to separate folder URL : https://patchwork.freedesktop.org/series/62779/ State : success == Summary == CI Bug Log - changes from CI_DRM_6359_full -> Patchwork_13439_full Summary ---

Re: [Intel-gfx] [CI v3 09/23] drm/i915: Factor out common parts from TypeC port handling functions

2019-06-26 Thread Souza, Jose
On Wed, 2019-06-26 at 23:50 +0300, Imre Deak wrote: > Factor out helpers reading/parsing the TypeC specific registers, > making > current users of them clearer and letting us use them later. > > While at it also: > - Simplify icl_tc_phy_connect() with an early return in legacy mode. > - Simplify t

[Intel-gfx] [PATCH] drm/i915: Make i945gm_vblank_work_func static

2019-06-26 Thread Chris Wilson
drivers/gpu/drm/i915/i915_irq.c:3382:6: warning: symbol 'i945gm_vblank_work_func' was not declared. Should it be static? CC [M] drivers/gpu/drm/i915/i915_irq.o drivers/gpu/drm/i915/i915_irq.c:3382:6: error: no previous prototype for ‘i945gm_vblank_work_func’ [-Werror=missing-prototypes] void

Re: [Intel-gfx] [PATCH] drm/i915: Move OA files to separate folder

2019-06-26 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-06-26 13:38:26) > OA files look to be auto-generated so we can keep them all in > dedicated subdirectory. > > Signed-off-by: Michal Wajdeczko > Cc: Lionel Landwerlin > Cc: Chris Wilson > Cc: Jani Nikula We all seem content with the idea, so pushed while it still

Re: [Intel-gfx] [PATCH v3 11/23] drm/i915: Handle the TCCOLD power-down event

2019-06-26 Thread Souza, Jose
On Wed, 2019-06-26 at 21:04 +0300, Imre Deak wrote: > Based on a recent BSpec update (Index/21750) we must handle the > TCCOLD > event associated with the DP-alt mode. We can detect this event by > reading an invalid all-1s value from FIA registers. > > After detecting TCCOLD we will: > - fall bac

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix TypeC port mode switching (rev7)

2019-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Fix TypeC port mode switching (rev7) URL : https://patchwork.freedesktop.org/series/61590/ State : failure == Summary == Applying: drm/i915/icl: Add support to read out the TBT PLL HW state Applying: drm/i915: Tune down WARNs about TBT AUX power well enab

Re: [Intel-gfx] [PATCH] drm: Allow range of 0 for drm_mm_insert_node_in_range()

2019-06-26 Thread Daniel Vetter
On Wed, Jun 26, 2019 at 10:43:30AM +0100, Chris Wilson wrote: > We gracefully handle the caller specifying a zero range, so don't force > them to special case that condition if it naturally falls out of their > setup. What we don't check is if the end < start, so keep that as an > assert for an ill

Re: [Intel-gfx] [PATCH 09/28] drm/i915/tgl: Check if pipe D is fused

2019-06-26 Thread Srivatsa, Anusha
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Lucas De Marchi >Sent: Tuesday, June 25, 2019 10:54 AM >To: intel-gfx@lists.freedesktop.org >Cc: De Marchi, Lucas >Subject: [Intel-gfx] [PATCH 09/28] drm/i915/tgl: Check if pipe D is fused

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/ehl: Enable DDI-D

2019-06-26 Thread Souza, Jose
On Tue, 2019-06-25 at 17:03 -0700, Matt Roper wrote: > EHL has four DDI's (DDI-A and DDI-D share combo PHY A). Reviewed-by: José Roberto de Souza > > Cc: José Roberto de Souza > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_display.c | 1 + > 1 file changed, 1 insertio

Re: [Intel-gfx] [PATCH v3 3/5] drm/i915/ehl: Don't program PHY_MISC on EHL PHY C

2019-06-26 Thread Souza, Jose
On Tue, 2019-06-25 at 17:03 -0700, Matt Roper wrote: > Although EHL added a third combo PHY, no PHY_MISC register was added > for > PHY C. The bspec indicates that there's no need to program the "DE > to > IO Comp Pwr Down" setting for this PHY that we usually need to set in > PHY_MISC. > > v2: >

Re: [Intel-gfx] [PATCH 5/5] drm/i915/ehl: Enable DDI-D

2019-06-26 Thread Souza, Jose
On Tue, 2019-06-25 at 15:19 -0700, Matt Roper wrote: > On Fri, Jun 21, 2019 at 01:52:16PM -0700, Souza, Jose wrote: > > On Thu, 2019-06-20 at 19:01 -0700, Matt Roper wrote: > > > EHL has four DDI's (DDI-A and DDI-D share combo PHY A). > > > > > > Cc: José Roberto de Souza > > > Signed-off-by: Mat

[Intel-gfx] [PULL] drm-misc-fixes

2019-06-26 Thread Sean Paul
Hi maintainers, One patch this week, no magic. drm-misc-fixes-2019-06-26: virtio- Don't call drm_connector_update_edid_property() while holding spinlock Cc: Gerd Hoffmann Cheers, Sean The following changes since commit 5eab9cf87b6c261f4e2f6c7623171cc2f5ea1a9c: Merge tag 'imx-drm-fixes-20

[Intel-gfx] [CI v3 13/23] drm/i915: Fix the TypeC port mode sanitization during loading/resume

2019-06-26 Thread Imre Deak
For using the correct AUX power domains we have to sanitize the TypeC port mode early, so move that before encoder sanitization. To do this properly read out the actual port mode instead of just relying on the VBT legacy port flag (which can be incorrect). We also verify that the PHY is connected

[Intel-gfx] [CI v3 21/23] drm/i915: Add state verification for the TypeC port mode

2019-06-26 Thread Imre Deak
Add state verification for the TypeC port mode wrt. the port's AUX power well enabling/disabling. Also check the correctness of changing the port mode: - When enabling/disabling the AUX power well for a TypeC port we must hold the TypeC port lock - the case for AUX transfers - or hold a Type C

[Intel-gfx] [CI v3 11/23] drm/i915: Handle the TCCOLD power-down event

2019-06-26 Thread Imre Deak
Based on a recent BSpec update (Index/21750) we must handle the TCCOLD event associated with the DP-alt mode. We can detect this event by reading an invalid all-1s value from FIA registers. After detecting TCCOLD we will: - fall back to TBT-alt mode when attempting to switch to DP-alt mode - concl

[Intel-gfx] [CI v3 09/23] drm/i915: Factor out common parts from TypeC port handling functions

2019-06-26 Thread Imre Deak
Factor out helpers reading/parsing the TypeC specific registers, making current users of them clearer and letting us use them later. While at it also: - Simplify icl_tc_phy_connect() with an early return in legacy mode. - Simplify the live status check using one bitmask for all HPD bits. - Remove

Re: [Intel-gfx] [RFC 3/4] drm/i915: introduce display_uncore

2019-06-26 Thread Daniele Ceraolo Spurio
On 6/26/19 11:42 AM, Ville Syrjälä wrote: On Mon, Jun 24, 2019 at 01:31:51PM -0700, Daniele Ceraolo Spurio wrote: A forcewake-less uncore to be used to decouple GT accesses from display ones to avoid serializing them when there is no need. New accessors that implicitly use the new uncore have

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add icl mipi dsi properties

2019-06-26 Thread Patchwork
== Series Details == Series: drm/i915: Add icl mipi dsi properties URL : https://patchwork.freedesktop.org/series/62770/ State : success == Summary == CI Bug Log - changes from CI_DRM_6357_full -> Patchwork_13436_full Summary --- **S

[Intel-gfx] ✓ Fi.CI.BAT: success for Finish the ack+handler split for irq handler

2019-06-26 Thread Patchwork
== Series Details == Series: Finish the ack+handler split for irq handler URL : https://patchwork.freedesktop.org/series/62800/ State : success == Summary == CI Bug Log - changes from CI_DRM_6364 -> Patchwork_13444 Summary --- **SUCC

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Add missing VECS engine

2019-06-26 Thread Bloomfield, Jon
> -Original Message- > From: Intel-gfx On Behalf Of Tvrtko > Ursulin > Sent: Tuesday, June 25, 2019 10:22 PM > To: Ceraolo Spurio, Daniele ; Roper, > Matthew D ; Souza, Jose > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915/ehl: Add missing VECS engine > >

Re: [Intel-gfx] [PATCH] drm/connector: Allow max possible encoders to attach to a connector

2019-06-26 Thread Dhinakaran Pandiyan
On Wed, 2019-06-26 at 16:31 +0200, Daniel Vetter wrote: > On Wed, Jun 26, 2019 at 04:43:28PM +0300, Ville Syrjälä wrote: > > On Tue, Jun 25, 2019 at 04:40:45PM -0700, Dhinakaran Pandiyan wrote: > > > Currently we restrict the number of encoders that can be linked to > > > a connector to 3, increase

Re: [Intel-gfx] [PATCH] drm/i915: Move OA files to separate folder

2019-06-26 Thread Umesh Nerlige Ramappa
On Wed, Jun 26, 2019 at 12:38:26PM +, Michal Wajdeczko wrote: OA files look to be auto-generated so we can keep them all in dedicated subdirectory. Signed-off-by: Michal Wajdeczko Cc: Lionel Landwerlin Cc: Chris Wilson Cc: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 3

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v3,1/3] drm/i915/icl: Add new supported CD clocks

2019-06-26 Thread Souza, Jose
On Wed, 2019-06-26 at 11:54 +, Patchwork wrote: > == Series Details == > > Series: series starting with [v3,1/3] drm/i915/icl: Add new supported > CD clocks > URL : https://patchwork.freedesktop.org/series/62748/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_6351

Re: [Intel-gfx] [RFC 3/4] drm/i915: introduce display_uncore

2019-06-26 Thread Ville Syrjälä
On Mon, Jun 24, 2019 at 01:31:51PM -0700, Daniele Ceraolo Spurio wrote: > A forcewake-less uncore to be used to decouple GT accesses from display > ones to avoid serializing them when there is no need. > > New accessors that implicitly use the new uncore have also been added. > > Signed-off-by: D

Re: [Intel-gfx] [PATCH 06/28] drm/i915/tgl: Add TGL PCH detection in virtualized environment

2019-06-26 Thread Srivatsa, Anusha
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Lucas De Marchi >Sent: Tuesday, June 25, 2019 10:54 AM >To: intel-gfx@lists.freedesktop.org >Cc: Mahesh Kumar ; De Marchi, Lucas > >Subject: [Intel-gfx] [PATCH 06/28] drm/i915/tgl: Add TGL

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Add a wakeref getter for iff the wakeref is already active

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Add a wakeref getter for iff the wakeref is already active URL : https://patchwork.freedesktop.org/series/62795/ State : success == Summary == CI Bug Log - changes from CI_DRM_6362 -> Patchwork_13443 ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm: Allow range of 0 for drm_mm_insert_node_in_range()

2019-06-26 Thread Patchwork
== Series Details == Series: drm: Allow range of 0 for drm_mm_insert_node_in_range() URL : https://patchwork.freedesktop.org/series/62768/ State : success == Summary == CI Bug Log - changes from CI_DRM_6356_full -> Patchwork_13435_full Summ

Re: [Intel-gfx] [RFC 1/4] drm/i915: split out uncore_mmio_debug

2019-06-26 Thread Daniele Ceraolo Spurio
On 6/26/19 10:58 AM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-06-26 18:38:45) On 6/26/19 3:02 AM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-06-24 21:31:49) @@ -605,18 +614,20 @@ void intel_uncore_forcewake_get(struct intel_uncore *uncore, void intel_uncor

[Intel-gfx] [PATCH v3 11/23] drm/i915: Handle the TCCOLD power-down event

2019-06-26 Thread Imre Deak
Based on a recent BSpec update (Index/21750) we must handle the TCCOLD event associated with the DP-alt mode. We can detect this event by reading an invalid all-1s value from FIA registers. After detecting TCCOLD we will: - fall back to TBT-alt mode when attempting to switch to DP-alt mode - concl

[Intel-gfx] [PATCH v3 13/23] drm/i915: Fix the TypeC port mode sanitization during loading/resume

2019-06-26 Thread Imre Deak
For using the correct AUX power domains we have to sanitize the TypeC port mode early, so move that before encoder sanitization. To do this properly read out the actual port mode instead of just relying on the VBT legacy port flag (which can be incorrect). We also verify that the PHY is connected

[Intel-gfx] [v3 21/23] drm/i915: Add state verification for the TypeC port mode

2019-06-26 Thread Imre Deak
Add state verification for the TypeC port mode wrt. the port's AUX power well enabling/disabling. Also check the correctness of changing the port mode: - When enabling/disabling the AUX power well for a TypeC port we must hold the TypeC port lock - the case for AUX transfers - or hold a Type C

[Intel-gfx] [PATCH v2 5/5] drm/i915: Use raw_reg_read()/write() in ilk+ irq handlers

2019-06-26 Thread Ville Syrjala
From: Ville Syrjälä Optimize the irq handlers a bit by switching to the raw register access functions. It seems we can go fully lockless due to WaSerializeKmdDisplayAccess, so in order to protect against that we grab the irq_lock around the ack. I *think* that should be sufficient as that's held

[Intel-gfx] [PATCH v2 4/5] drm/i915: Finish the irq ack+handler split for ilk+

2019-06-26 Thread Ville Syrjala
From: Ville Syrjälä All the older platforms already follow the ack+handler apporoach for interrupts. Convert ilk+ as well. As the number of registers involved is rather large we'll introduce a few more structs to carry the register values around. The unfortunate side effect of this is some growt

[Intel-gfx] [PATCH v2 0/5] Finish the ack+handler split for irq handler

2019-06-26 Thread Ville Syrjala
From: Ville Syrjälä Rebased version of the irq ack+handle split series. Tried to accommodate Chris's review feedback. I also tossed in a patch at the end to shrink the code by using the raw read/write stuff. A bit scared of that one due to the same cacheline reg access system hangs, so tried to

[Intel-gfx] [PATCH v3 09/23] drm/i915: Factor out common parts from TypeC port handling functions

2019-06-26 Thread Imre Deak
Factor out helpers reading/parsing the TypeC specific registers, making current users of them clearer and letting us use them later. While at it also: - Simplify icl_tc_phy_connect() with an early return in legacy mode. - Simplify the live status check using one bitmask for all HPD bits. - Remove

[Intel-gfx] [PATCH v2 1/5] drm/i915: Add gen8_de_pipe_fault_mask()

2019-06-26 Thread Ville Syrjala
From: Ville Syrjälä Reduce the clutter a bit by introducing gen8_de_pipe_fault_mask(). Signed-off-by: Ville Syrjälä Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_irq.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c

[Intel-gfx] [PATCH v2 2/5] drm/i915: Introduce struct hpd_irq_regs

2019-06-26 Thread Ville Syrjala
From: Ville Syrjälä Collect the hpd related register values into a struct for so that it's more convenient to pass them around. v2: Drop the zero initialization (Chris) Adapt to PCH_MCC changes Signed-off-by: Ville Syrjälä Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_irq.c | 2

[Intel-gfx] [PATCH v2 3/5] drm/i915: Split pch irq handling to ack+handler

2019-06-26 Thread Ville Syrjala
From: Ville Syrjälä The proper way to process interrupts is to first acknowledge them all, and later process them. Start down that path for pch interrupts by collecting the relevant register values into a struct so that we can carry them from the ack part to the handler part. v2: Drop the zero i

Re: [Intel-gfx] [RFC 1/4] drm/i915: split out uncore_mmio_debug

2019-06-26 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-06-26 18:38:45) > > > On 6/26/19 3:02 AM, Chris Wilson wrote: > > Quoting Daniele Ceraolo Spurio (2019-06-24 21:31:49) > >> @@ -605,18 +614,20 @@ void intel_uncore_forcewake_get(struct intel_uncore > >> *uncore, > >> void intel_uncore_forcewake_user_get(str

Re: [Intel-gfx] [PATCH 01/28] drm/i915: Add modular FIA

2019-06-26 Thread Ville Syrjälä
On Wed, Jun 26, 2019 at 10:48:01AM -0700, Lucas De Marchi wrote: > On Wed, Jun 26, 2019 at 06:50:14PM +0300, Ville Syrjälä wrote: > >On Tue, Jun 25, 2019 at 10:54:10AM -0700, Lucas De Marchi wrote: > >> From: Anusha Srivatsa > >> > >> Some platforms may have Modular FIA. If Modular FIA is used in

Re: [Intel-gfx] [PATCH 01/28] drm/i915: Add modular FIA

2019-06-26 Thread Lucas De Marchi
On Wed, Jun 26, 2019 at 06:50:14PM +0300, Ville Syrjälä wrote: On Tue, Jun 25, 2019 at 10:54:10AM -0700, Lucas De Marchi wrote: From: Anusha Srivatsa Some platforms may have Modular FIA. If Modular FIA is used in the SOC, then Display Driver will access the additional instances of FIA based on

Re: [Intel-gfx] [PATCH 04/28] drm/i915/tgl: add initial Tiger Lake definitions

2019-06-26 Thread Srivatsa, Anusha
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Lucas De Marchi >Sent: Tuesday, June 25, 2019 10:54 AM >To: intel-gfx@lists.freedesktop.org >Cc: De Marchi, Lucas >Subject: [Intel-gfx] [PATCH 04/28] drm/i915/tgl: add initial Tiger Lake

Re: [Intel-gfx] [RFC 1/4] drm/i915: split out uncore_mmio_debug

2019-06-26 Thread Daniele Ceraolo Spurio
On 6/26/19 3:02 AM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-06-24 21:31:49) @@ -605,18 +614,20 @@ void intel_uncore_forcewake_get(struct intel_uncore *uncore, void intel_uncore_forcewake_user_get(struct intel_uncore *uncore) { spin_lock_irq(&uncore->lock); +

Re: [Intel-gfx] [PATCH] drm: Allow range of 0 for drm_mm_insert_node_in_range()

2019-06-26 Thread Daniele Ceraolo Spurio
On 6/26/19 2:43 AM, Chris Wilson wrote: We gracefully handle the caller specifying a zero range, so don't force them to special case that condition if it naturally falls out of their setup. What we don't check is if the end < start, so keep that as an assert for an illegal call. Signed-off-by:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Add a wakeref getter for iff the wakeref is already active

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Add a wakeref getter for iff the wakeref is already active URL : https://patchwork.freedesktop.org/series/62795/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5ae7c187d1c0 drm/i915: Add a wakeref getter for iff

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Lift intel_engines_resume() to callers

2019-06-26 Thread Mika Kuoppala
Chris Wilson writes: > Since the reset path wants to recover the engines itself, it only wants > to reinitialise the hardware using i915_gem_init_hw(). Pull the call to > intel_engines_resume() to the module init/resume path so we can avoid it > during reset. > > Signed-off-by: Chris Wilson Rev

[Intel-gfx] [PATCH 2/3] drm/i915: Only recover active engines

2019-06-26 Thread Chris Wilson
If we issue a reset to a currently idle engine, leave it idle afterwards. This is useful to excise a linkage between reset and the shrinker. When waking the engine, we need to pin the default context image which we use for overwriting a guilty context -- if the engine is idle we do not need this pi

[Intel-gfx] [PATCH 3/3] drm/i915: Lift intel_engines_resume() to callers

2019-06-26 Thread Chris Wilson
Since the reset path wants to recover the engines itself, it only wants to reinitialise the hardware using i915_gem_init_hw(). Pull the call to intel_engines_resume() to the module init/resume path so we can avoid it during reset. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem

[Intel-gfx] [PATCH 1/3] drm/i915: Add a wakeref getter for iff the wakeref is already active

2019-06-26 Thread Chris Wilson
For use in the next patch, we want to acquire a wakeref without having to wake the device up -- i.e. only acquire the engine wakeref if the engine is already active. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_engine_pm.h | 7 ++- drivers/gpu/dr

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,01/13] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Jani Nikula
On Wed, 26 Jun 2019, Patchwork wrote: > == Series Details == > > Series: series starting with [v2,01/13] drm/i915: prefix header search path > with $(srctree)/ > URL : https://patchwork.freedesktop.org/series/62791/ > State : warning > > == Summary == > > $ dim sparse origin/drm-tip > Sparse ve

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,01/13] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [v2,01/13] drm/i915: prefix header search path with $(srctree)/ URL : https://patchwork.freedesktop.org/series/62791/ State : success == Summary == CI Bug Log - changes from CI_DRM_6359 -> Patchwork_13442 ==

Re: [Intel-gfx] [PATCH 02/28] drm/i915: rework reading pipe disable fuses

2019-06-26 Thread Ville Syrjälä
On Tue, Jun 25, 2019 at 10:54:11AM -0700, Lucas De Marchi wrote: > This prepares to have possibly more than 3 pipes. I didn't want to > continue the previous approach since the check for "are the disabled > pipes the last ones" poses a combinatory explosion. We need that check > because in several

Re: [Intel-gfx] [PATCH 01/28] drm/i915: Add modular FIA

2019-06-26 Thread Ville Syrjälä
On Tue, Jun 25, 2019 at 10:54:10AM -0700, Lucas De Marchi wrote: > From: Anusha Srivatsa > > Some platforms may have Modular FIA. If Modular FIA is used in the SOC, > then Display Driver will access the additional instances of > FIA based on pre-assigned offset in GTTMADDR space. > > Each Modula

Re: [Intel-gfx] [PATCH v2 04/13] drm/i915: make i915_gem_gtt.h self-contained

2019-06-26 Thread Jani Nikula
On Wed, 26 Jun 2019, Jani Nikula wrote: > On Wed, 26 Jun 2019, Michal Wajdeczko wrote: >> On Wed, 26 Jun 2019 16:40:11 +0200, Jani Nikula >> wrote: >> >>> Add the minimal includes/declarations to make the header self-contained, >>> and ensure it stays that way. >>> >>> Reviewed-by: Chris Wilso

Re: [Intel-gfx] [PATCH v2 04/13] drm/i915: make i915_gem_gtt.h self-contained

2019-06-26 Thread Jani Nikula
On Wed, 26 Jun 2019, Michal Wajdeczko wrote: > On Wed, 26 Jun 2019 16:40:11 +0200, Jani Nikula > wrote: > >> Add the minimal includes/declarations to make the header self-contained, >> and ensure it stays that way. >> >> Reviewed-by: Chris Wilson >> Signed-off-by: Jani Nikula >> --- >> drive

Re: [Intel-gfx] [PATCH v2 04/13] drm/i915: make i915_gem_gtt.h self-contained

2019-06-26 Thread Michal Wajdeczko
On Wed, 26 Jun 2019 16:40:11 +0200, Jani Nikula wrote: Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_gem_gtt.h | 2 ++ 1 file changed, 2 insertions(+

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: prefix header search path with $(srctree)/ URL : https://patchwork.freedesktop.org/series/62790/ State : success == Summary == CI Bug Log - changes from CI_DRM_6359 -> Patchwork_13441 ===

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/6] drm/i915/selftests: Serialise nop reset with retirement

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915/selftests: Serialise nop reset with retirement URL : https://patchwork.freedesktop.org/series/62756/ State : success == Summary == CI Bug Log - changes from CI_DRM_6354_full -> Patchwork_13434_full ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,01/13] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [v2,01/13] drm/i915: prefix header search path with $(srctree)/ URL : https://patchwork.freedesktop.org/series/62791/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: prefix header search path

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915/selftests: Serialise nop reset with retirement

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/selftests: Serialise nop reset with retirement URL : https://patchwork.freedesktop.org/series/62784/ State : success == Summary == CI Bug Log - changes from CI_DRM_6359 -> Patchwork_13440 =

Re: [Intel-gfx] [V2] drm/i915: Add icl mipi dsi properties

2019-06-26 Thread Kulkarni, Vandita
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, June 26, 2019 7:29 PM > To: Nikula, Jani > Cc: Kulkarni, Vandita ; intel- > g...@lists.freedesktop.org; Syrjala, Ville > Subject: Re: [Intel-gfx] [V2] drm/i915: Add icl mipi dsi properties > > On Wed, Jun 26, 2019 at 03:53:19

Re: [Intel-gfx] [PATCH v3] drm/i915: Check backlight type while doing eDP backlight initializaiton

2019-06-26 Thread Jani Nikula
On Tue, 25 Jun 2019, "Lee, Shawn C" wrote: > On Tue, 25 Jun 2019, Jani Nikula wrote: >>On Thu, 20 Jun 2019, Lee Shawn C wrote: >>> If LFP backlight type setting from VBT was "VESA eDP AUX Interface". >>> Driver should check panel capability and try to initialize aux backlight. >>> No matter i915

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: prefix header search path with $(srctree)/ URL : https://patchwork.freedesktop.org/series/62790/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: prefix header search path with

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Only recover active engines

2019-06-26 Thread Chris Wilson
Quoting Mika Kuoppala (2019-06-26 15:44:56) > Chris Wilson writes: > > > If we issue a reset to a currently idle engine, leave it idle > > afterwards. This is useful to excise a linkage between reset and the > > shrinker. When waking the engine, we need to pin the default context > > default con

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Only recover active engines

2019-06-26 Thread Mika Kuoppala
Chris Wilson writes: > If we issue a reset to a currently idle engine, leave it idle > afterwards. This is useful to excise a linkage between reset and the > shrinker. When waking the engine, we need to pin the default context default context, kernel context, golden context... if we ever revisit

Re: [Intel-gfx] [PATCH 2/2] drm/i915: add header search path to subdir Makefiles

2019-06-26 Thread Chris Wilson
Quoting Jani Nikula (2019-06-26 15:36:18) > With the subdirectories we lost the ability to build individual files on > the command line, for example: > > $ make drivers/gpu/drm/i915/display/intel_display.o > > This was due to the top level directory missing from header search > path. Add the head

[Intel-gfx] [PATCH v2 04/13] drm/i915: make i915_gem_gtt.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_gem_gtt.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/driver

Re: [Intel-gfx] [PATCH 1/2] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Chris Wilson
Quoting Jani Nikula (2019-06-26 15:36:17) > Per commit 43068cb7ba1f ("drm: prefix header search paths with > $(srctree)/") this is what we should be doing. Follow suit. Bleugh, it's not mentioned in Documention/kbuild but it is used in one of their examples. > Cc: Chris Wilson > Signed-off-by:

Re: [Intel-gfx] [PATCH v4 5/7] lib/hexdump.c: Allow multiple groups to be separated by lines '|'

2019-06-26 Thread Alastair D'Silva
On Mon, 2019-06-24 at 22:37 -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > With the wider display format, it can become hard to identify how > > many > > bytes into the line you are looking at. > > > > The patch adds new

Re: [Intel-gfx] [PATCH v4 0/7] Hexdump Enhancements

2019-06-26 Thread Alastair D'Silva
On Mon, 2019-06-24 at 22:01 -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > Apologies for the large CC list, it's a heads up for those > > responsible > > for subsystems where a prototype change in generic code causes a > >

Re: [Intel-gfx] [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-06-26 Thread Alastair D'Silva
On Mon, 2019-06-24 at 22:01 -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 13:17 +1000, Alastair D'Silva wrote: > > From: Alastair D'Silva > > > > In order to support additional features, rename hex_dump_to_buffer > > to > > hex_dump_to_buffer_ext, and replace the ascii bool parameter with > >

Re: [Intel-gfx] [PATCH v4 4/7] lib/hexdump.c: Replace ascii bool in hex_dump_to_buffer with flags

2019-06-26 Thread Alastair D'Silva
On Mon, 2019-06-24 at 22:19 -0700, Joe Perches wrote: > On Tue, 2019-06-25 at 15:06 +1000, Alastair D'Silva wrote: > > The change actions Jani's suggestion: > > https://lkml.org/lkml/2019/6/20/343 > > I suggest not changing any of the existing uses of > hex_dump_to_buffer and only use hex_dump_to_

[Intel-gfx] [PATCH v2 10/13] drm/i915: make intel_guc_reg.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. v2: also include i915_reg.h (Michal) Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_guc_reg.h | 5 ++

[Intel-gfx] [PATCH v2 08/13] drm/i915: make intel_guc_ct.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_guc_ct.h | 7 +-- 2 files changed, 6 insertions(+

[Intel-gfx] [PATCH v2 07/13] drm/i915: make i915_vgpu.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/i915_vgpu.h | 1 + 2 files changed, 2 insertions(+) dif

[Intel-gfx] [PATCH v2 01/13] drm/i915: prefix header search path with $(srctree)/

2019-06-26 Thread Jani Nikula
Per commit 43068cb7ba1f ("drm: prefix header search paths with $(srctree)/") this is what we should be doing. Follow suit. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/Makefile b/drivers/gpu/

[Intel-gfx] [PATCH v2 06/13] drm/i915: make i915_pvinfo.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/i915_pvinfo.h| 2 ++ 2 files changed, 3 insertions(+) di

[Intel-gfx] [PATCH v2 09/13] drm/i915: make intel_guc_fwif.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_guc_fwif.h | 4 2 files changed, 5 insertions(+)

[Intel-gfx] [PATCH v2 03/13] drm/i915: make i915_fixed.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/i915_fixed.h | 5 + 2 files changed, 6 insertions(+)

[Intel-gfx] [PATCH v2 12/13] drm/i915: make intel_uc_fw.h self-contained

2019-06-26 Thread Jani Nikula
Add the minimal includes/declarations to make the header self-contained, and ensure it stays that way. Reviewed-by: Chris Wilson Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/Makefile.header-test | 1 + drivers/gpu/drm/i915/intel_uc_fw.h| 2 ++ 2 files changed, 3 insertions(+) di

  1   2   >