[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/blt: Remove recursive vma->lock (rev2)

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/blt: Remove recursive vma->lock (rev2) URL : https://patchwork.freedesktop.org/series/62290/ State : success == Summary == CI Bug Log - changes from CI_DRM_6328_full -> Patchwork_13395_full Summary

[Intel-gfx] [PATCH v3 0/4] Panel rotation patches

2019-06-21 Thread Derek Basehore
This adds the plumbing for reading panel rotation from the devicetree and sets up adding a panel property for the panel orientation on Mediatek SoCs when a rotation is present. v3 changes: -changed from attach/detach callbacks to directly setting fixed panel values in drm_panel_attach -removed up

[Intel-gfx] [PATCH v3 3/4] drm/connector: Split out orientation quirk detection

2019-06-21 Thread Derek Basehore
Not every platform needs quirk detection for panel orientation, so split the drm_connector_init_panel_orientation_property into two functions. One for platforms without the need for quirks, and the other for platforms that need quirks. Signed-off-by: Derek Basehore --- drivers/gpu/drm/drm_connec

[Intel-gfx] [PATCH v4 4/4] drm/mtk: add panel orientation property

2019-06-21 Thread Derek Basehore
This inits the panel orientation property for the mediatek dsi driver if the panel orientation (connector.display_info.panel_orientation) is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN. Signed-off-by: Derek Basehore --- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 1 file changed, 8 insertions(+)

[Intel-gfx] [PATCH v3 2/4] drm/panel: set display info in panel attach

2019-06-21 Thread Derek Basehore
Devicetree systems can set panel orientation via a panel binding, but there's no way, as is, to propagate this setting to the connector, where the property need to be added. To address this, this patch sets orientation, as well as other fixed values for the panel, in the drm_panel_attach function.

[Intel-gfx] [PATCH v3 1/4] drm/panel: Add helper for reading DT rotation

2019-06-21 Thread Derek Basehore
This adds a helper function for reading the rotation (panel orientation) from the device tree. Signed-off-by: Derek Basehore --- drivers/gpu/drm/drm_panel.c | 42 + include/drm/drm_panel.h | 7 +++ 2 files changed, 49 insertions(+) diff --git a/drive

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915/guc: reorder enable/disable communication steps

2019-06-21 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/guc: reorder enable/disable communication steps URL : https://patchwork.freedesktop.org/series/62545/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6326_full -> Patchwork_13391_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ehl: Add support for DPLL4 (v5) (rev3)

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Add support for DPLL4 (v5) (rev3) URL : https://patchwork.freedesktop.org/series/61684/ State : success == Summary == CI Bug Log - changes from CI_DRM_6329 -> Patchwork_13397 Summary --- **S

[Intel-gfx] [PATCH] drm/i915/ehl: Add support for DPLL4 (v8)

2019-06-21 Thread Vivek Kasireddy
This patch adds support for DPLL4 on EHL that include the following restrictions: - DPLL4 cannot be used with DDIA (combo port A internal eDP usage). DPLL4 can be used with other DDIs, including DDID (combo port A external usage). - DPLL4 cannot be enabled when DC5 or DC6 are enabled. - The

Re: [Intel-gfx] [PATCH 3/5] drm/panel: Add attach/detach callbacks

2019-06-21 Thread dbasehore .
On Fri, Jun 21, 2019 at 2:19 AM Thierry Reding wrote: > > On Tue, Jun 11, 2019 at 05:25:47PM -0700, dbasehore . wrote: > > On Tue, Jun 11, 2019 at 1:57 AM Daniel Vetter wrote: > > > > > > On Mon, Jun 10, 2019 at 09:03:48PM -0700, Derek Basehore wrote: > > > > This adds the attach/detach callbacks

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Always clear ring_pause if we do not submit

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Always clear ring_pause if we do not submit URL : https://patchwork.freedesktop.org/series/62540/ State : success == Summary == CI Bug Log - changes from CI_DRM_6324_full -> Patchwork_13390_full ==

Re: [Intel-gfx] [PATCH 4/5] drm/i915/gen11: Start distinguishing 'phy' from 'port'

2019-06-21 Thread Souza, Jose
On Fri, 2019-06-21 at 07:08 -0700, Matt Roper wrote: > Our past DDI-based Intel platforms have had a fixed DDI<->PHY > mapping. > Because of this, both the bspec documentation and our i915 code has > used > the term "port" when talking about either DDI's or PHY's; it was > always > easy to tell wha

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ehl: Add port_cl_dw10 to combo phy vswing sequence

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Add port_cl_dw10 to combo phy vswing sequence URL : https://patchwork.freedesktop.org/series/62563/ State : success == Summary == CI Bug Log - changes from CI_DRM_6328 -> Patchwork_13396 Summary --

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ehl: Add one additional PCH ID to MCC

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Add one additional PCH ID to MCC URL : https://patchwork.freedesktop.org/series/62534/ State : success == Summary == CI Bug Log - changes from CI_DRM_6324_full -> Patchwork_13389_full Summary -

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/blt: Remove recursive vma->lock (rev2)

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/blt: Remove recursive vma->lock (rev2) URL : https://patchwork.freedesktop.org/series/62290/ State : success == Summary == CI Bug Log - changes from CI_DRM_6328 -> Patchwork_13395 Summary --- **S

[Intel-gfx] PR-Latest GuC

2019-06-21 Thread Srivatsa, Anusha
The following changes since commit acb56f2fae3235195bc99ecb7d09742fb4b65e63: cavium: Add firmware for CNN55XX crypto driver. (2019-06-18 09:12:52 -0400) are available in the Git repository at: git://anongit.freedesktop.org/drm/drm-firmware guc_v33 for you to fetch changes up to c1f789d2a868

Re: [Intel-gfx] [PATCH 0/5] drm: Aspect ratio fixes

2019-06-21 Thread Alex Deucher
On Thu, Jun 20, 2019 at 10:26 AM Ville Syrjala wrote: > > From: Ville Syrjälä > > Ilia pointed out some oddball crap in the i915 aspect ratio handling. > While looking at that I noticed a bunch of fail in the core as well. > This series aims to fix it all. > > Cc: Ilia Mirkin > > Ville Syrjälä (

Re: [Intel-gfx] [PATCH 1/5] drm/i915/icl: Drop port parameter to icl_get_combo_buf_trans()

2019-06-21 Thread Clinton Taylor
Logical, since its not being used. Reviewed-by: Clint Taylor -Clint On 6/20/19 7:01 PM, Matt Roper wrote: The port parameter hasn't been used since the last bspec phy programming update. Drop it to make some upcoming changes simpler. References: 9659c1af451a ("drm/i915/icl: combo port vswi

[Intel-gfx] [PATCH] drm/i915/ehl: Add port_cl_dw10 to combo phy vswing sequence

2019-06-21 Thread clinton . a . taylor
From: Clint Taylor Elkhart Lake has additional bits in port_cl_dw10 that should be set during vswing programming. According to BSPEC these bits should be set based on OEM selection. Since VBT does not contain a definition for these bits we will currently clear them until VBT is updated to give OE

[Intel-gfx] [CI] drm/i915/blt: Remove recursive vma->lock

2019-06-21 Thread Chris Wilson
As we have already plugged the w->dma into the reservation_object, and have set ourselves up to automatically signal the request and w->dma on completion, we do not need to export the rq->fence directly and just use the w->dma fence. This avoids having to take the reservation_lock inside the worke

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Disable preemption under GVT

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Disable preemption under GVT URL : https://patchwork.freedesktop.org/series/62533/ State : success == Summary == CI Bug Log - changes from CI_DRM_6324_full -> Patchwork_13388_full Summary ---

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: CTS fixes (rev2)

2019-06-21 Thread Chris Wilson
Quoting Lionel Landwerlin (2019-06-20 14:46:45) > On 20/06/2019 16:41, Chris Wilson wrote: > > Quoting Patchwork (2019-06-20 14:35:27) > >> == Series Details == > >> > >> Series: drm/i915: CTS fixes (rev2) > >> URL : https://patchwork.freedesktop.org/series/62437/ > >> State : failure > >> > >> =

[Intel-gfx] ✗ Fi.CI.IGT: failure for EHL port programming (rev2)

2019-06-21 Thread Patchwork
== Series Details == Series: EHL port programming (rev2) URL : https://patchwork.freedesktop.org/series/62492/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6323_full -> Patchwork_13387_full Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH] drm/i915/guc: Add debug capture of GuC exception

2019-06-21 Thread Robert Fosha
On 6/21/19 1:40 PM, Michal Wajdeczko wrote: On Fri, 21 Jun 2019 22:09:40 +0200, Robert M. Fosha wrote: Detect GuC firmware load failure due to an exception during execution in GuC firmware. Output the GuC EIP where excpetion occured to dmesg two typos here I'll correct the typos. for G

Re: [Intel-gfx] [PATCH 5/5] drm/i915/ehl: Enable DDI-D

2019-06-21 Thread Souza, Jose
On Thu, 2019-06-20 at 19:01 -0700, Matt Roper wrote: > EHL has four DDI's (DDI-A and DDI-D share combo PHY A). > > Cc: José Roberto de Souza > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/display/intel_display.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm

Re: [Intel-gfx] [PATCH] drm/i915/guc: Add debug capture of GuC exception

2019-06-21 Thread Michal Wajdeczko
On Fri, 21 Jun 2019 22:09:40 +0200, Robert M. Fosha wrote: Detect GuC firmware load failure due to an exception during execution in GuC firmware. Output the GuC EIP where excpetion occured to dmesg two typos here for GuC debug information. Signed-off-by: Robert M. Fosha Cc: Daniele Cera

Re: [Intel-gfx] [PATCH 3/5] drm/i915/ehl: Don't program PHY_MISC on EHL PHY C

2019-06-21 Thread Souza, Jose
On Thu, 2019-06-20 at 19:01 -0700, Matt Roper wrote: > Although EHL added a third combo PHY, no PHY_MISC register was added > for > PHY C. The bspec indicates that there's no need to program the "DE > to > IO Comp Pwr Down" setting for this PHY that we usually need to set in > PHY_MISC. > > Bspec

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Add debug capture of GuC exception

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/guc: Add debug capture of GuC exception URL : https://patchwork.freedesktop.org/series/62554/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6327 -> Patchwork_13394 Summary --- **

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Prevent dereference of engine before NULL check in error capture

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915: Prevent dereference of engine before NULL check in error capture URL : https://patchwork.freedesktop.org/series/62528/ State : success == Summary == CI Bug Log - changes from CI_DRM_6323_full -> Patchwork_13386_full ==

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/guc: Add debug capture of GuC exception

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/guc: Add debug capture of GuC exception URL : https://patchwork.freedesktop.org/series/62554/ State : warning == Summary == $ dim checkpatch origin/drm-tip 91a0d06b79dd drm/i915/guc: Add debug capture of GuC exception -:7: WARNING:TYPO_SPELLING: 'occured'

Re: [Intel-gfx] [PATCH 2/5] drm/i915/ehl: Add third combo PHY offset

2019-06-21 Thread Souza, Jose
On Thu, 2019-06-20 at 19:01 -0700, Matt Roper wrote: > Cc: José Roberto de Souza > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/i915_reg.h | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_reg.h > b/drivers/gpu/drm/i915/i915_reg.h >

[Intel-gfx] [PATCH] drm/i915/guc: Add debug capture of GuC exception

2019-06-21 Thread Robert M. Fosha
Detect GuC firmware load failure due to an exception during execution in GuC firmware. Output the GuC EIP where excpetion occured to dmesg for GuC debug information. Signed-off-by: Robert M. Fosha Cc: Daniele Ceraolo Spurio Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/intel_guc_fw.c | 7

Re: [Intel-gfx] [PATCH] drm/i915/ehl: Add one additional PCH ID to MCC

2019-06-21 Thread Souza, Jose
On Fri, 2019-06-21 at 08:18 -0700, Matt Roper wrote: > There's one additional ID that we should treat as Mule Creek Canyon. > Reviewed-by: José Roberto de Souza > Cc: José Roberto de Souza > Signed-off-by: Matt Roper > --- > drivers/gpu/drm/i915/i915_drv.c | 1 + > drivers/gpu/drm/i915/i915_

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/execlists: Disable preemption under GVT (rev2)

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Disable preemption under GVT (rev2) URL : https://patchwork.freedesktop.org/series/62533/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6327 -> Patchwork_13393 Summary --

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/gt: Rename i915_gt_timelines

2019-06-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Rename i915_gt_timelines URL : https://patchwork.freedesktop.org/series/62527/ State : success == Summary == CI Bug Log - changes from CI_DRM_6323_full -> Patchwork_13385_full =

[Intel-gfx] [PATCH] drm/i915/execlists: Disable preemption under GVT

2019-06-21 Thread Chris Wilson
Preempt-to-busy uses a GPU semaphore to enforce an idle-barrier across preemption, but mediated gvt does not fully support semaphores. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/drivers/gp

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/5] drm/i915: Remove waiting & retiring from shrinker paths

2019-06-21 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915: Remove waiting & retiring from shrinker paths URL : https://patchwork.freedesktop.org/series/62546/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6326 -> Patchwork_13392 =

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/guc: reorder enable/disable communication steps

2019-06-21 Thread Chris Wilson
Quoting Patchwork (2019-06-21 20:02:53) > == Series Details == > > Series: series starting with [v2,1/2] drm/i915/guc: reorder enable/disable > communication steps > URL : https://patchwork.freedesktop.org/series/62545/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/guc: reorder enable/disable communication steps

2019-06-21 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/guc: reorder enable/disable communication steps URL : https://patchwork.freedesktop.org/series/62545/ State : success == Summary == CI Bug Log - changes from CI_DRM_6326 -> Patchwork_13391

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/5] drm/i915: Remove waiting & retiring from shrinker paths

2019-06-21 Thread Patchwork
== Series Details == Series: series starting with [CI,1/5] drm/i915: Remove waiting & retiring from shrinker paths URL : https://patchwork.freedesktop.org/series/62546/ State : warning == Summary == $ dim checkpatch origin/drm-tip ae144d746212 drm/i915: Remove waiting & retiring from shrinker

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915: Remove waiting & retiring from shrinker paths

2019-06-21 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Remove waiting & retiring from shrinker paths URL : https://patchwork.freedesktop.org/series/62526/ State : success == Summary == CI Bug Log - changes from CI_DRM_6323_full -> Patchwork_13384_full ==

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/icl: Assign Master slave crtc links for Transcoder Port Sync

2019-06-21 Thread Manasi Navare
As per the feedback, I tested the code with saving master_transcoder instead of master_crtc and in the HW state readout I loop through all transcoders to fill the trans_port_sync_slaves bitmask. This is working great and i dont see any pipe state mismatches now. Thanks for all the feedback and I

[Intel-gfx] [CI 3/5] drm/i915: Throw away the active object retirement complexity

2019-06-21 Thread Chris Wilson
Remove the accumulated optimisations that we have for i915_vma_retire and reduce it to the bare essential of tracking the active object reference. This allows us to only use atomic operations, and so will be able to avoid the struct_mutex requirement. The principal loss here is the shrinker MRU bu

[Intel-gfx] [CI 5/5] drm/i915: Local debug BUG_ON for intel_wakeref

2019-06-21 Thread Chris Wilson
Avoid pulling in i915_gem.h just so that we can use a conditional BUG_ON for debugging. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/intel_wakeref.c | 9 + drivers/gpu/drm/i915/intel_wakeref.h | 7 +++ 2 files changed, 12 insertions(+), 4 deletions(

[Intel-gfx] [CI 4/5] drm/i915: Provide an i915_active.acquire callback

2019-06-21 Thread Chris Wilson
If we introduce a callback for i915_active that is only called the first time we use the i915_active and is symmetrically paired with the i915_active.retire callback, we can replace the open-coded and non-atomic implementations -- which will be very fragile (i.e. broken) upon removing the struct_mu

[Intel-gfx] [CI 2/5] drm/i915: Track i915_active using debugobjects

2019-06-21 Thread Chris Wilson
Provide runtime asserts and tracking of i915_active via debugobjects. For example, this should allow us to check that the i915_active is only active when we expect it to be and is never freed too early. One consequence is that, for simplicity, we no longer allow i915_active to be on-stack which on

[Intel-gfx] [CI 1/5] drm/i915: Remove waiting & retiring from shrinker paths

2019-06-21 Thread Chris Wilson
i915_gem_wait_for_idle() and i915_retire_requests() introduce a dependency on the timeline->mutex. This is problematic as we want to later perform allocations underneath i915_active.mutex, forming a link between the shrinker, the timeline and active mutexes. Nip this cycle in the bud by removing th

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/guc: handle GuC messages received with CTB disabled

2019-06-21 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-06-21 19:21:23) > There is a very small chance of triggering a log flush event when > enabling or disabling CT buffers. Events triggered while CT buffers > are disabled are logged in the SCRATCH_15 register using the same bits > used in the CT message payload. S

[Intel-gfx] [PATCH v2 2/2] drm/i915/guc: handle GuC messages received with CTB disabled

2019-06-21 Thread Daniele Ceraolo Spurio
There is a very small chance of triggering a log flush event when enabling or disabling CT buffers. Events triggered while CT buffers are disabled are logged in the SCRATCH_15 register using the same bits used in the CT message payload. Since our communication channel with GuC is turned off, we can

[Intel-gfx] [PATCH v2 1/2] drm/i915/guc: reorder enable/disable communication steps

2019-06-21 Thread Daniele Ceraolo Spurio
Make sure we always have CT buffers enabled when the interrupts are enabled, so we can always handle interrupts from GuC. Also move the setting of the guc->send and guc->handler functions to the GuC communication control functions for consistency. The reorder also fixes the onion unwinding of inte

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Always clear ring_pause if we do not submit

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Always clear ring_pause if we do not submit URL : https://patchwork.freedesktop.org/series/62540/ State : success == Summary == CI Bug Log - changes from CI_DRM_6324 -> Patchwork_13390 Summar

Re: [Intel-gfx] [PATCH] drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl

2019-06-21 Thread Daniel Vetter
On Fri, Jun 07, 2019 at 11:24:01AM +0100, Emil Velikov wrote: > On Wed, 5 Jun 2019 at 13:08, Daniel Vetter wrote: > > > > This completes Emil's series of removing DRM_UNLOCKED from modern > > drivers. It's entirely cargo-culted since we ignore it on > > non-DRIVER_LEGACY drivers since: > > > > com

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ehl: Add one additional PCH ID to MCC

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Add one additional PCH ID to MCC URL : https://patchwork.freedesktop.org/series/62534/ State : success == Summary == CI Bug Log - changes from CI_DRM_6324 -> Patchwork_13389 Summary --- **SU

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Disable preemption under GVT

2019-06-21 Thread Chris Wilson
Quoting Patchwork (2019-06-21 17:42:58) > == Series Details == > > Series: drm/i915/execlists: Disable preemption under GVT > URL : https://patchwork.freedesktop.org/series/62533/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_6324 -> Patchwork_13388 > ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Disable preemption under GVT

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Disable preemption under GVT URL : https://patchwork.freedesktop.org/series/62533/ State : success == Summary == CI Bug Log - changes from CI_DRM_6324 -> Patchwork_13388 Summary --- **

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v10

2019-06-21 Thread Daniel Vetter
On Fri, Jun 21, 2019 at 02:06:54PM +0200, Christian König wrote: > Am 21.06.19 um 12:32 schrieb Daniel Vetter: > > On Fri, Jun 21, 2019 at 11:55 AM Christian König > > wrote: > > > Am 21.06.19 um 11:20 schrieb Daniel Vetter: > > > > On Tue, Jun 18, 2019 at 01:54:50PM +0200, Christian König wrote:

[Intel-gfx] [PATCH] drm/i915/execlists: Always clear ring_pause if we do not submit

2019-06-21 Thread Chris Wilson
In the unlikely case (thank you CI!), we may find ourselves wanting to issue a preemption but having no runnable requests left. In this case, we set the semaphore before computing the preemption and so must unset it before forgetting (or else we leave the machine busywaiting until the next request

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/ehl: Add voltage level requirement table

2019-06-21 Thread Matt Roper
On Thu, Jun 20, 2019 at 05:45:56PM -0700, José Roberto de Souza wrote: > EHL has it own voltage level requirement depending on cd clock. > > BSpec: 21809 > Cc: Clint Taylor > Cc: Matt Roper > Cc: Ville Syrjälä > Signed-off-by: José Roberto de Souza Matches bspec. Reviewed-by: Matt Roper >

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915/ehl: Remove unsupported cd clocks

2019-06-21 Thread Matt Roper
On Thu, Jun 20, 2019 at 05:45:55PM -0700, José Roberto de Souza wrote: > EHL do not support 648 and 652.8 MHz. > > v2: > - Limiting maximum CD clock by max_cdclk_freq instead of remove it > from icl_calc_cdclk()(Ville and Jani) > > BSpec: 20598 > Cc: Clint Taylor > Cc: Matt Roper > Cc: Ville Sy

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/icl: Add new supported CD clocks

2019-06-21 Thread Matt Roper
On Thu, Jun 20, 2019 at 05:45:54PM -0700, José Roberto de Souza wrote: > Now 180, 172.8 and 192 MHz are supported. > > 180 and 172.8 MHz CD clocks will only be used when audio is not > enabled as state by BSpec and implemented in > intel_crtc_compute_min_cdclk(), CD clock must be at least twice of

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Local debug BUG_ON for intel_wakeref

2019-06-21 Thread Matthew Auld
On 21/06/2019 14:05, Chris Wilson wrote: Avoid pulling in i915_gem.h just so that we can use a conditional BUG_ON for debugging. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https:

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Track i915_active using debugobjects

2019-06-21 Thread Chris Wilson
Quoting Matthew Auld (2019-06-21 16:25:05) > On 21/06/2019 14:05, Chris Wilson wrote: > > Provide runtime asserts and tracking of i915_active via debugobjects. > > For example, this should allow us to check that the i915_active is only > > active when we expect it to be and is never freed too early

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Track i915_active using debugobjects

2019-06-21 Thread Matthew Auld
On 21/06/2019 14:05, Chris Wilson wrote: Provide runtime asserts and tracking of i915_active via debugobjects. For example, this should allow us to check that the i915_active is only active when we expect it to be and is never freed too early. One consequence is that, for simplicity, we no longe

[Intel-gfx] [PATCH] drm/i915/ehl: Add one additional PCH ID to MCC

2019-06-21 Thread Matt Roper
There's one additional ID that we should treat as Mule Creek Canyon. Cc: José Roberto de Souza Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_drv.c | 1 + drivers/gpu/drm/i915/i915_drv.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Rename i915_gt_timelines

2019-06-21 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-06-21 16:00:15) > > On 21/06/2019 14:16, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/i915_gem.c > > b/drivers/gpu/drm/i915/i915_gem.c > > index 8dff3b8f12c3..e59be5c05e1b 100644 > > --- a/drivers/gpu/drm/i915/i915_gem.c > > +++ b/drivers/gpu/drm/i915/i91

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Remove waiting & retiring from shrinker paths

2019-06-21 Thread Matthew Auld
On 21/06/2019 14:05, Chris Wilson wrote: i915_gem_wait_for_idle() and i915_retire_requests() introduce a dependency on the timeline->mutex. This is problematic as we want to later perform allocations underneath i915_active.mutex, forming a link between the shrinker, the timeline and active mutexe

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gt: Fixup kerneldoc parameters

2019-06-21 Thread Tvrtko Ursulin
On 21/06/2019 14:16, Chris Wilson wrote: drivers/gpu/drm/i915/gt/intel_mocs.c:513: warning: Function parameter or member 'gt' not described in 'intel_mocs_init_l3cc_table' drivers/gpu/drm/i915/gt/intel_mocs.c:513: warning: Excess function parameter 'dev_priv' description in 'intel_mocs_ini

[Intel-gfx] [PATCH] drm/i915/execlists: Disable preemption under GVT

2019-06-21 Thread Chris Wilson
Preempt-to-busy uses a GPU semaphore to enforce an idle-barrier across preemption, but mediated gvt does not fully support semaphores. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gt: Rename i915_gt_timelines

2019-06-21 Thread Tvrtko Ursulin
On 21/06/2019 14:16, Chris Wilson wrote: Since the anonymous i915_gt became struct intel_gt and encloses struct i915_gt_timelines, rename i915_gt_timelines to intel_gt_timelines to match its parentage. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gt_types

[Intel-gfx] ✓ Fi.CI.BAT: success for EHL port programming (rev2)

2019-06-21 Thread Patchwork
== Series Details == Series: EHL port programming (rev2) URL : https://patchwork.freedesktop.org/series/62492/ State : success == Summary == CI Bug Log - changes from CI_DRM_6323 -> Patchwork_13387 Summary --- **SUCCESS** No regre

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Prevent dereference of engine before NULL check in error capture

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915: Prevent dereference of engine before NULL check in error capture URL : https://patchwork.freedesktop.org/series/62528/ State : success == Summary == CI Bug Log - changes from CI_DRM_6323 -> Patchwork_13386

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for EHL port programming (rev2)

2019-06-21 Thread Patchwork
== Series Details == Series: EHL port programming (rev2) URL : https://patchwork.freedesktop.org/series/62492/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5685d98b6706 drm/i915/icl: Drop port parameter to icl_get_combo_buf_trans() -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible

Re: [Intel-gfx] [PATCH] drm/i915: Prevent dereference of engine before NULL check in error capture

2019-06-21 Thread Tvrtko Ursulin
On 21/06/2019 14:52, Chris Wilson wrote: drivers/gpu/drm/i915//i915_gpu_error.c:1418 gem_record_rings() warn: variable dereferenced before check 'engine' (see line 1413) Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gpu_error.c | 3 +-- 1 file changed, 1 ins

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Prevent dereference of engine before NULL check in error capture

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915: Prevent dereference of engine before NULL check in error capture URL : https://patchwork.freedesktop.org/series/62528/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7cc507b17f06 drm/i915: Prevent dereference of engine before NULL check in

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/gt: Rename i915_gt_timelines

2019-06-21 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/gt: Rename i915_gt_timelines URL : https://patchwork.freedesktop.org/series/62527/ State : success == Summary == CI Bug Log - changes from CI_DRM_6323 -> Patchwork_13385 Summa

[Intel-gfx] [PATCH 4/5] drm/i915/gen11: Start distinguishing 'phy' from 'port'

2019-06-21 Thread Matt Roper
Our past DDI-based Intel platforms have had a fixed DDI<->PHY mapping. Because of this, both the bspec documentation and our i915 code has used the term "port" when talking about either DDI's or PHY's; it was always easy to tell what terms like "Port A" were referring to from the context. Unfortun

[Intel-gfx] XDC 2019: Less than three weeks to go to submit your talks, workshops or demos!

2019-06-21 Thread Mark Filion
Hello! Less than three weeks to go to submit your talks, workshops or demos for this year's X.Org Developer Conference, which will be taking place in Montréal, Canada on October 2-4, 2019! The 2019 X.Org Developers Conference is the annual technical meeting for X Window System and Free Desktop de

[Intel-gfx] [PATCH] drm/i915: Prevent dereference of engine before NULL check in error capture

2019-06-21 Thread Chris Wilson
drivers/gpu/drm/i915//i915_gpu_error.c:1418 gem_record_rings() warn: variable dereferenced before check 'engine' (see line 1413) Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gpu_error.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/driver

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Remove waiting & retiring from shrinker paths

2019-06-21 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Remove waiting & retiring from shrinker paths URL : https://patchwork.freedesktop.org/series/62526/ State : success == Summary == CI Bug Log - changes from CI_DRM_6323 -> Patchwork_13384

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: Remove waiting & retiring from shrinker paths

2019-06-21 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Remove waiting & retiring from shrinker paths URL : https://patchwork.freedesktop.org/series/62526/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2576c15160f4 drm/i915: Remove waiting & retiring from shrinker pa

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Keep context alive until after we kick (rev2)

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Keep context alive until after we kick (rev2) URL : https://patchwork.freedesktop.org/series/62503/ State : success == Summary == CI Bug Log - changes from CI_DRM_6320_full -> Patchwork_13383_full

[Intel-gfx] [PATCH 1/2] drm/i915/gt: Rename i915_gt_timelines

2019-06-21 Thread Chris Wilson
Since the anonymous i915_gt became struct intel_gt and encloses struct i915_gt_timelines, rename i915_gt_timelines to intel_gt_timelines to match its parentage. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gt_types.h | 2 +- drivers/gpu/drm/i915/gt/intel_tim

[Intel-gfx] [PATCH 2/2] drm/i915/gt: Fixup kerneldoc parameters

2019-06-21 Thread Chris Wilson
drivers/gpu/drm/i915/gt/intel_mocs.c:513: warning: Function parameter or member 'gt' not described in 'intel_mocs_init_l3cc_table' drivers/gpu/drm/i915/gt/intel_mocs.c:513: warning: Excess function parameter 'dev_priv' description in 'intel_mocs_init_l3cc_table' intel_vgt_balloon/deballoon, i9

[Intel-gfx] [PATCH 4/5] drm/i915: Provide an i915_active.acquire callback

2019-06-21 Thread Chris Wilson
If we introduce a callback for i915_active that is only called the first time we use the i915_active and is symmetrically paired with the i915_active.retire callback, we can replace the open-coded and non-atomic implementations -- which will be very fragile (i.e. broken) upon removing the struct_mu

[Intel-gfx] [PATCH 3/5] drm/i915: Throw away the active object retirement complexity

2019-06-21 Thread Chris Wilson
Remove the accumulated optimisations that we have for i915_vma_retire and reduce it to the bare essential of tracking the active object reference. This allows us to only use atomic operations, and so will be able to avoid the struct_mutex requirement. The principal loss here is the shrinker MRU bu

[Intel-gfx] [PATCH 5/5] drm/i915: Local debug BUG_ON for intel_wakeref

2019-06-21 Thread Chris Wilson
Avoid pulling in i915_gem.h just so that we can use a conditional BUG_ON for debugging. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_wakeref.c | 9 + drivers/gpu/drm/i915/intel_wakeref.h | 7 +++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/gp

[Intel-gfx] [PATCH 2/5] drm/i915: Track i915_active using debugobjects

2019-06-21 Thread Chris Wilson
Provide runtime asserts and tracking of i915_active via debugobjects. For example, this should allow us to check that the i915_active is only active when we expect it to be and is never freed too early. One consequence is that, for simplicity, we no longer allow i915_active to be on-stack which on

[Intel-gfx] [PATCH 1/5] drm/i915: Remove waiting & retiring from shrinker paths

2019-06-21 Thread Chris Wilson
i915_gem_wait_for_idle() and i915_retire_requests() introduce a dependency on the timeline->mutex. This is problematic as we want to later perform allocations underneath i915_active.mutex, forming a link between the shrinker, the timeline and active mutexes. Nip this cycle in the bud by removing th

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,01/33] drm/i915: Convert intel_vgt_(de)balloon to uncore

2019-06-21 Thread Tvrtko Ursulin
On 21/06/2019 08:49, Patchwork wrote: == Series Details == Series: series starting with [CI,01/33] drm/i915: Convert intel_vgt_(de)balloon to uncore URL : https://patchwork.freedesktop.org/series/62496/ State : success == Summary == CI Bug Log - changes from CI_DRM_6320 -> Patchwork_13381

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,01/33] drm/i915: Convert intel_vgt_(de)balloon to uncore

2019-06-21 Thread Patchwork
== Series Details == Series: series starting with [CI,01/33] drm/i915: Convert intel_vgt_(de)balloon to uncore URL : https://patchwork.freedesktop.org/series/62496/ State : success == Summary == CI Bug Log - changes from CI_DRM_6320_full -> Patchwork_13381_full ===

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v10

2019-06-21 Thread Christian König
Am 21.06.19 um 12:32 schrieb Daniel Vetter: On Fri, Jun 21, 2019 at 11:55 AM Christian König wrote: Am 21.06.19 um 11:20 schrieb Daniel Vetter: On Tue, Jun 18, 2019 at 01:54:50PM +0200, Christian König wrote: [SNIP] Imo the below semantics would be much cleaner: - invalidate may add new fence

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Refine eDP aux backlight enable/disable sequence

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915: Refine eDP aux backlight enable/disable sequence URL : https://patchwork.freedesktop.org/series/62494/ State : success == Summary == CI Bug Log - changes from CI_DRM_6319_full -> Patchwork_13380_full S

Re: [Intel-gfx] [PATCH 09/59] drm/prime: Align gem_prime_export with obj_funcs.export

2019-06-21 Thread Daniel Vetter
On Fri, Jun 14, 2019 at 10:35:25PM +0200, Daniel Vetter wrote: > The idea is that gem_prime_export is deprecated in favor of > obj_funcs.export. That's much easier to do if both have matching > function signatures. > > Signed-off-by: Daniel Vetter > Cc: Russell King > Cc: Maarten Lankhorst > Cc

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v10

2019-06-21 Thread Daniel Vetter
On Fri, Jun 21, 2019 at 11:55 AM Christian König wrote: > > Am 21.06.19 um 11:20 schrieb Daniel Vetter: > > On Tue, Jun 18, 2019 at 01:54:50PM +0200, Christian König wrote: > >> On the exporter side we add optional explicit pinning callbacks. If those > >> callbacks are implemented the framework n

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v10

2019-06-21 Thread Christian König
Am 21.06.19 um 11:20 schrieb Daniel Vetter: On Tue, Jun 18, 2019 at 01:54:50PM +0200, Christian König wrote: On the exporter side we add optional explicit pinning callbacks. If those callbacks are implemented the framework no longer caches sg tables and the map/unmap callbacks are always called

Re: [Intel-gfx] [PATCH 1/6] dma-buf: add dynamic DMA-buf handling v10

2019-06-21 Thread Daniel Vetter
On Tue, Jun 18, 2019 at 01:54:50PM +0200, Christian König wrote: > On the exporter side we add optional explicit pinning callbacks. If those > callbacks are implemented the framework no longer caches sg tables and the > map/unmap callbacks are always called with the lock of the reservation object >

Re: [Intel-gfx] [PATCH 3/5] drm/panel: Add attach/detach callbacks

2019-06-21 Thread Thierry Reding
On Tue, Jun 11, 2019 at 05:25:47PM -0700, dbasehore . wrote: > On Tue, Jun 11, 2019 at 1:57 AM Daniel Vetter wrote: > > > > On Mon, Jun 10, 2019 at 09:03:48PM -0700, Derek Basehore wrote: > > > This adds the attach/detach callbacks. These are for setting up > > > internal state for the connector/p

[Intel-gfx] ✓ Fi.CI.IGT: success for EHL port programming

2019-06-21 Thread Patchwork
== Series Details == Series: EHL port programming URL : https://patchwork.freedesktop.org/series/62492/ State : success == Summary == CI Bug Log - changes from CI_DRM_6319_full -> Patchwork_13379_full Summary --- **SUCCESS** No re

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Keep context alive until after we kick (rev2)

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Keep context alive until after we kick (rev2) URL : https://patchwork.freedesktop.org/series/62503/ State : success == Summary == CI Bug Log - changes from CI_DRM_6320 -> Patchwork_13383 Summ

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Keep context alive until after we kick

2019-06-21 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Keep context alive until after we kick URL : https://patchwork.freedesktop.org/series/62503/ State : success == Summary == CI Bug Log - changes from CI_DRM_6320 -> Patchwork_13382 Summary ---

  1   2   >