[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Refine placement of gt.reset_lockmap

2019-06-12 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Refine placement of gt.reset_lockmap URL : https://patchwork.freedesktop.org/series/61991/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2fa70e0be054 drm/i915: Refine placement of gt.reset_lockmap c4b1fa3b38d7 d

[Intel-gfx] [PATCH 3/4] drm/i915: Move fence register tracking from i915->mm to ggtt

2019-06-12 Thread Chris Wilson
As the fence registers only apply to regions inside the GGTT is makes more sense that we track these as part of the i915_ggtt and not the general mm. In the next patch, we will then pull the register locking underneath the i915_ggtt.mutex. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala -

[Intel-gfx] [PATCH 4/4] drm/i915: Track ggtt fence reservations under its own mutex

2019-06-12 Thread Chris Wilson
We can reduce the locking for fence registers from the dev->struct_mutex to a local mutex. We could introduce a mutex for the sole purpose of tracking the fence acquisition, except there is a little bit of overlap with the fault tracking, so use the i915_ggtt.mutex as it covers both. Signed-off-by

[Intel-gfx] [PATCH 1/4] drm/i915: Refine placement of gt.reset_lockmap

2019-06-12 Thread Chris Wilson
If we pull the lockmap into reset_prepare/reset_finish, it will naturally cover i915_gem_set_wedged() as well as i915_reset(). And with another tweak, we can pull __i915_gem_unset_wedged() underneath the lockmap covering the mutexes used there. As a bonus, it should hide the ugliness of the i915_r

[Intel-gfx] [PATCH 2/4] drm/i915: Avoid tainting i915_gem_park() with wakeref.lock

2019-06-12 Thread Chris Wilson
While we need to flush the wakeref before parking, we do not need to perform the i915_gem_park() itself underneath the wakeref lock, merely the struct_mutex. If we rearrange the locks, we can avoid the unnecessary tainting. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_pm.c |

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/8] drm/i915: Keep contexts pinned until after the next kernel context switch

2019-06-12 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/i915: Keep contexts pinned until after the next kernel context switch URL : https://patchwork.freedesktop.org/series/61946/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6244_full -> Patchwork_13250_full

Re: [Intel-gfx] [PATCH] gpu/drm/i915: globally replace dev_priv with i915

2019-06-12 Thread Lucas De Marchi
On Thu, Jun 13, 2019 at 07:07:28AM +0100, Chris Wilson wrote: Quoting Lucas De Marchi (2019-06-12 17:29:00) We are slowly converting dev_priv to i915 everywhere, spread into smaller series. While this is good to avoid unrelated breakages to other inflight patches, it's bad because inflight patch

Re: [Intel-gfx] [PATCH] gpu/drm/i915: globally replace dev_priv with i915

2019-06-12 Thread Chris Wilson
Quoting Lucas De Marchi (2019-06-12 17:29:00) > We are slowly converting dev_priv to i915 everywhere, spread into > smaller series. While this is good to avoid unrelated breakages to other > inflight patches, it's bad because inflight patches on nearby paths keep > breaking. Paired with other code

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Refine eDP aux backlight enable sequence.

2019-06-12 Thread Patchwork
== Series Details == Series: drm/i915: Refine eDP aux backlight enable sequence. URL : https://patchwork.freedesktop.org/series/61990/ State : success == Summary == CI Bug Log - changes from CI_DRM_6253 -> Patchwork_13264 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Refine eDP aux backlight enable sequence.

2019-06-12 Thread Patchwork
== Series Details == Series: drm/i915: Refine eDP aux backlight enable sequence. URL : https://patchwork.freedesktop.org/series/61990/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Refine eDP aux backlight enable sequence. +drivers/gpu/drm/i

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/drm_vblank: Change EINVAL by the correct errno (rev3)

2019-06-12 Thread Patchwork
== Series Details == Series: drm/drm_vblank: Change EINVAL by the correct errno (rev3) URL : https://patchwork.freedesktop.org/series/51147/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6253 -> Patchwork_13263 Summary

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Prevent lock-cycles between GPU waits and GPU resets (rev2)

2019-06-12 Thread Patchwork
== Series Details == Series: drm/i915: Prevent lock-cycles between GPU waits and GPU resets (rev2) URL : https://patchwork.freedesktop.org/series/61901/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6244_full -> Patchwork_13249_full

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/drm_vblank: Change EINVAL by the correct errno (rev3)

2019-06-12 Thread Patchwork
== Series Details == Series: drm/drm_vblank: Change EINVAL by the correct errno (rev3) URL : https://patchwork.freedesktop.org/series/51147/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8534a60ab43b Drop use of DRM_WAIT_ON() [Was: drm/drm_vblank: Change EINVAL by the correct

[Intel-gfx] [PATCH] drm/i915: Refine eDP aux backlight enable sequence.

2019-06-12 Thread Lee, Shawn C
Modify aux backlight enable sequence just like what we did for genernal eDP panel. 1. Setup PWM freq and brightness level before enable display backlight. 2. Add T8 (valid data to backlight enable) delay. Cc: Jani Nikula Cc: Jose Roberto de Souza Cc: Cooper Chiou Signed-off-by: Lee, Shawn C -

[Intel-gfx] Drop use of DRM_WAIT_ON() [Was: drm/drm_vblank: Change EINVAL by the correct errno]

2019-06-12 Thread Sam Ravnborg
Hi Rodrigo. On Wed, Jun 12, 2019 at 11:10:54PM -0300, Rodrigo Siqueira wrote: > For historical reason, the function drm_wait_vblank_ioctl always return > -EINVAL if something gets wrong. This scenario limits the flexibility > for the userspace make detailed verification of the problem and take > s

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/drm_vblank: Change EINVAL by the correct errno (rev2)

2019-06-12 Thread Patchwork
== Series Details == Series: drm/drm_vblank: Change EINVAL by the correct errno (rev2) URL : https://patchwork.freedesktop.org/series/51147/ State : success == Summary == CI Bug Log - changes from CI_DRM_6253 -> Patchwork_13262 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for gpu/drm/i915: globally replace dev_priv with i915

2019-06-12 Thread Patchwork
== Series Details == Series: gpu/drm/i915: globally replace dev_priv with i915 URL : https://patchwork.freedesktop.org/series/61983/ State : success == Summary == CI Bug Log - changes from CI_DRM_6253 -> Patchwork_13261 Summary --- *

[Intel-gfx] [PATCH V6 i-g-t 6/6] kms_writeback: Add tests using a cloned output

2019-06-12 Thread Brian Starkey
Update the connector search to also optionally attempt to find a non-writeback connector to clone to. Add a subtest which is the same as writeback-check-output, but also clones to the second connector. Signed-off-by: Brian Starkey [rebased and addressed comments by Maarten] Signed-off-by: Liviu

[Intel-gfx] [PATCH V6 i-g-t 5/6] lib/igt_kms: Add igt_output_clone_pipe for cloning

2019-06-12 Thread Brian Starkey
An output can be added as a clone of any other output(s) attached to a pipe using igt_output_clone_pipe() v5: Drop field out_fence_requested from struct igt_pipe (Brian Starkey) Signed-off-by: Brian Starkey --- lib/igt_kms.c | 100 +++--- lib/igt_kms.

[Intel-gfx] [PATCH V6 i-g-t 4/6] kms_writeback: Add writeback-check-output

2019-06-12 Thread Brian Starkey
Add a test which makes commits using the writeback connector, and checks the output buffer hash to make sure it is/isn't written as appropriate. Signed-off-by: Brian Starkey --- tests/kms_writeback.c | 124 ++ 1 file changed, 124 insertions(+) diff --git

[Intel-gfx] [PATCH V6 i-g-t 3/6] lib: Add function to hash a framebuffer

2019-06-12 Thread Brian Starkey
To use writeback buffers as a CRC source, we need to be able to hash them. Implement a simple FVA-1a hashing routine for this purpose. Doing a bytewise hash on the framebuffer directly can be very slow if the memory is noncached. By making a copy of each line in the FB first (which can take advant

[Intel-gfx] [PATCH V6 i-g-t 2/6] kms_writeback: Add initial writeback tests

2019-06-12 Thread Brian Starkey
Add tests for the WRITEBACK_PIXEL_FORMATS, WRITEBACK_OUT_FENCE_PTR and WRITEBACK_FB_ID properties on writeback connectors, ensuring their behaviour is correct. Signed-off-by: Brian Starkey [rebased and updated do_writeback_test() function to address feedback] Signed-off-by: Liviu Dudau --- test

[Intel-gfx] [PATCH V6 i-g-t 1/6] lib/igt_kms: Add writeback support

2019-06-12 Thread Brian Starkey
Add support in igt_kms for writeback connectors, with the ability to attach framebuffers. v5: Rebase and add DRM_CLIENT_CAP_WRITEBACK_CONNECTORS before drmModeGetResources() Signed-off-by: Brian Starkey [rebased and updated to the latest igt style] Signed-off-by: Liviu Dudau --- lib/igt_kms.c

[Intel-gfx] ✓ Fi.CI.BAT: success for include: linux: Regularise the use of FIELD_SIZEOF macro

2019-06-12 Thread Patchwork
== Series Details == Series: include: linux: Regularise the use of FIELD_SIZEOF macro URL : https://patchwork.freedesktop.org/series/61982/ State : success == Summary == CI Bug Log - changes from CI_DRM_6253 -> Patchwork_13260 Summary -

[Intel-gfx] [PATCH V6 i-g-t 0/6] igt: Add support for testing writeback connectors

2019-06-12 Thread Rodrigo Siqueira
DRM already have writeback connectors support, which is a way to expose in DRM the hardware functionality from display engines that allows writing back into memory the result of the DE's composition of supported planes. These days, I'm working to add the writeback support into the vkms[1], and I u

[Intel-gfx] [RESEND PATCH V3] drm/drm_vblank: Change EINVAL by the correct errno

2019-06-12 Thread Rodrigo Siqueira
For historical reason, the function drm_wait_vblank_ioctl always return -EINVAL if something gets wrong. This scenario limits the flexibility for the userspace make detailed verification of the problem and take some action. In particular, the validation of “if (!dev->irq_enabled)” in the drm_wait_v

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gvt: remove duplicate entry of trace (rev2)

2019-06-12 Thread Patchwork
== Series Details == Series: drm/i915/gvt: remove duplicate entry of trace (rev2) URL : https://patchwork.freedesktop.org/series/61281/ State : success == Summary == CI Bug Log - changes from CI_DRM_6242_full -> Patchwork_13247_full Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for gpu/drm/i915: globally replace dev_priv with i915

2019-06-12 Thread Patchwork
== Series Details == Series: gpu/drm/i915: globally replace dev_priv with i915 URL : https://patchwork.freedesktop.org/series/61983/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: gpu/drm/i915: globally replace dev_priv with i915 -O:drivers/gpu/drm/i91

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for gpu/drm/i915: globally replace dev_priv with i915

2019-06-12 Thread Patchwork
== Series Details == Series: gpu/drm/i915: globally replace dev_priv with i915 URL : https://patchwork.freedesktop.org/series/61983/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5585dfe286e9 gpu/drm/i915: globally replace dev_priv with i915 -:633: CHECK:COMPARISON_TO_NULL: Com

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for include: linux: Regularise the use of FIELD_SIZEOF macro

2019-06-12 Thread Patchwork
== Series Details == Series: include: linux: Regularise the use of FIELD_SIZEOF macro URL : https://patchwork.freedesktop.org/series/61982/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9c1c7908df88 include: linux: Regularise the use of FIELD_SIZEOF macro -:116: CHECK:PARENTHES

Re: [Intel-gfx] [PATCH] drm/i915/gvt: remove duplicate entry of trace

2019-06-12 Thread Hariprasad Kelam
On Wed, Jun 12, 2019 at 11:22:36AM +0800, Zhenyu Wang wrote: > On 2019.05.26 13:26:33 +0530, Hariprasad Kelam wrote: > > Remove duplicate include of trace.h > > > > Issue identified by includecheck > > > > Signed-off-by: Hariprasad Kelam > > --- > > drivers/gpu/drm/i915/gvt/trace_points.c | 1 -

Re: [Intel-gfx] [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-06-12 Thread Alexei Starovoitov
On Tue, Jun 11, 2019 at 5:00 PM Shyam Saini wrote: > > Currently, there are 3 different macros, namely sizeof_field, SIZEOF_FIELD > and FIELD_SIZEOF which are used to calculate the size of a member of > structure, so to bring uniformity in entire kernel source tree lets use > FIELD_SIZEOF and repl

Re: [Intel-gfx] [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-06-12 Thread Andreas Dilger
On Jun 11, 2019, at 2:48 PM, Andrew Morton wrote: > > On Wed, 12 Jun 2019 01:08:36 +0530 Shyam Saini > wrote: > >> Currently, there are 3 different macros, namely sizeof_field, SIZEOF_FIELD >> and FIELD_SIZEOF which are used to calculate the size of a member of >> structure, so to bring unifor

Re: [Intel-gfx] [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-06-12 Thread Andreas Dilger
On Jun 11, 2019, at 3:09 PM, Andrew Morton wrote: > > On Tue, 11 Jun 2019 15:00:10 -0600 Andreas Dilger wrote: > to FIELD_SIZEOF >>> >>> As Alexey has pointed out, C structs and unions don't have fields - >>> they have members. So this is an opportunity to switch everything to >>> a new

Re: [Intel-gfx] [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-06-12 Thread Shyam Saini
Hi Kees, Cc'ing William Kucharski, > On Wed, Jun 12, 2019 at 01:08:36AM +0530, Shyam Saini wrote: > > In favour of FIELD_SIZEOF, this patch also deprecates other two similar > > macros sizeof_field and SIZEOF_FIELD. > > > > For code compatibility reason, retain sizeof_field macro as a wrapper mac

Re: [Intel-gfx] [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-06-12 Thread Shyam Saini
Hi Andrew, > > On Tue, 11 Jun 2019 15:00:10 -0600 Andreas Dilger wrote: > > > >> to FIELD_SIZEOF > > > > > > As Alexey has pointed out, C structs and unions don't have fields - > > > they have members. So this is an opportunity to switch everything to > > > a new member_sizeof(). > > > > > > Wha

[Intel-gfx] [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-06-12 Thread Shyam Saini
Currently, there are 3 different macros, namely sizeof_field, SIZEOF_FIELD and FIELD_SIZEOF which are used to calculate the size of a member of structure, so to bring uniformity in entire kernel source tree lets use FIELD_SIZEOF and replace all occurrences of other two macros with this. For this p

Re: [Intel-gfx] [PATCH 2/5] dt-bindings: display/panel: Expand rotation documentation

2019-06-12 Thread Rob Herring
On Mon, Jun 10, 2019 at 10:03 PM Derek Basehore wrote: > > This adds to the rotation documentation to explain how drivers should > use the property and gives an example of the property in a devicetree > node. > > Signed-off-by: Derek Basehore > --- > .../bindings/display/panel/panel.txt

Re: [Intel-gfx] [PATCH v2 0/8] RPM Encapsulation

2019-06-12 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-06-12 19:37:39) > Rebased series after the display power code has been split out. > Mostly the same as V1, just small fixes based on review comments > and CI results. The last patch is new. > > The series grows the code a bit, but I believe it is worth it for t

Re: [Intel-gfx] [PATCH v2 8/8] drm/i915: make intel_wakeref work on the rpm struct

2019-06-12 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-06-12 19:37:47) > intel_runtime_pm is the only thing they use from the i915 structure, > so use that directly. > > Signed-off-by: Daniele Ceraolo Spurio > --- > drivers/gpu/drm/i915/gt/intel_engine_pm.c | 4 +-- > drivers/gpu/drm/i915/gt/intel_gt_pm.c |

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915: move and rename i915_runtime_pm

2019-06-12 Thread Daniele Ceraolo Spurio
On 6/12/19 3:14 PM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-06-12 19:37:43) Asserts aside, all the code working on this structure is in intel_runtime_pm.c and uses the intel_ prefix, so move the structure to intel_runtime_pm.h and adopt the same prefix. Since all the asserts

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915: move and rename i915_runtime_pm

2019-06-12 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-06-12 19:37:43) > Asserts aside, all the code working on this structure is in > intel_runtime_pm.c and uses the intel_ prefix, so move the > structure to intel_runtime_pm.h and adopt the same prefix. > > Since all the asserts are now working on the runtime_pm s

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915: prefer i915_runtime_pm in intel_runtime function

2019-06-12 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-06-12 19:37:40) > As a first step towards updating the code to work on the runtime_pm > structure instead of i915, rework all the internals to use and pass > around that. > > v2: add comment for kdev (Jani), move rpm init after pdev init for > mock_device > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/9] drm/i915/gtt: No need to zero the table for page dirs

2019-06-12 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915/gtt: No need to zero the table for page dirs URL : https://patchwork.freedesktop.org/series/61914/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6240_full -> Patchwork_13246_full

Re: [Intel-gfx] [PATCH 1/5] drm/panel: Add helper for reading DT rotation

2019-06-12 Thread Sam Ravnborg
Hi Derek. On Mon, Jun 10, 2019 at 09:03:46PM -0700, Derek Basehore wrote: > This adds a helper function for reading the rotation (panel > orientation) from the device tree. > > Signed-off-by: Derek Basehore > --- > drivers/gpu/drm/drm_panel.c | 41 + > includ

Re: [Intel-gfx] [PATCH 1/5] drm/panel: Add helper for reading DT rotation

2019-06-12 Thread Sam Ravnborg
Hi Derek. On Mon, Jun 10, 2019 at 09:03:46PM -0700, Derek Basehore wrote: > This adds a helper function for reading the rotation (panel > orientation) from the device tree. > > Signed-off-by: Derek Basehore > --- > drivers/gpu/drm/drm_panel.c | 41 + > includ

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/icl: Assign Master slave crtc links for Transcoder Port Sync

2019-06-12 Thread Manasi Navare
On Wed, Jun 12, 2019 at 10:30:55PM +0300, Ville Syrjälä wrote: > On Wed, Jun 12, 2019 at 12:11:02PM -0700, Manasi Navare wrote: > > On Wed, Jun 12, 2019 at 10:04:26PM +0300, Ville Syrjälä wrote: > > > On Wed, Jun 12, 2019 at 11:39:03AM +0200, Maarten Lankhorst wrote: > > > > Op 23-04-2019 om 17:48

Re: [Intel-gfx] [PATCH v3] drm/i915: Add Wa_1409120013:icl,ehl

2019-06-12 Thread Clinton Taylor
Looks good now. Reviewed-by: Clint Taylor -Clint On 6/12/19 11:36 AM, Matt Roper wrote: This chicken bit should be set before enabling FBC to avoid screen corruption when the plane size has odd vertical and horizontal dimensions. It is safe to leave the bit set even when FBC is disabled.

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/icl: Assign Master slave crtc links for Transcoder Port Sync

2019-06-12 Thread Ville Syrjälä
On Wed, Jun 12, 2019 at 12:11:02PM -0700, Manasi Navare wrote: > On Wed, Jun 12, 2019 at 10:04:26PM +0300, Ville Syrjälä wrote: > > On Wed, Jun 12, 2019 at 11:39:03AM +0200, Maarten Lankhorst wrote: > > > Op 23-04-2019 om 17:48 schreef Manasi Navare: > > > > In case of tiled displays when the two t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add Wa_1409120013:icl,ehl (rev3)

2019-06-12 Thread Patchwork
== Series Details == Series: drm/i915: Add Wa_1409120013:icl,ehl (rev3) URL : https://patchwork.freedesktop.org/series/61867/ State : success == Summary == CI Bug Log - changes from CI_DRM_6253 -> Patchwork_13258 Summary --- **SUCCES

[Intel-gfx] ✗ Fi.CI.BAT: failure for RPM Encapsulation

2019-06-12 Thread Patchwork
== Series Details == Series: RPM Encapsulation URL : https://patchwork.freedesktop.org/series/61976/ State : failure == Summary == Applying: drm/i915: prefer i915_runtime_pm in intel_runtime function Applying: drm/i915: Remove rpm asserts that use i915 Applying: drm/i915: make enable/disable r

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/icl: Assign Master slave crtc links for Transcoder Port Sync

2019-06-12 Thread Manasi Navare
On Wed, Jun 12, 2019 at 10:04:26PM +0300, Ville Syrjälä wrote: > On Wed, Jun 12, 2019 at 11:39:03AM +0200, Maarten Lankhorst wrote: > > Op 23-04-2019 om 17:48 schreef Manasi Navare: > > > In case of tiled displays when the two tiles are sent across two CRTCs > > > over two separate DP SST connector

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/4] drm/i915: Don't clobber M/N values during fastset check (rev2)

2019-06-12 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm/i915: Don't clobber M/N values during fastset check (rev2) URL : https://patchwork.freedesktop.org/series/61960/ State : success == Summary == CI Bug Log - changes from CI_DRM_6253 -> Patchwork_13257 ==

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/icl: Assign Master slave crtc links for Transcoder Port Sync

2019-06-12 Thread Ville Syrjälä
On Wed, Jun 12, 2019 at 11:39:03AM +0200, Maarten Lankhorst wrote: > Op 23-04-2019 om 17:48 schreef Manasi Navare: > > In case of tiled displays when the two tiles are sent across two CRTCs > > over two separate DP SST connectors, we need a mechanism to synchronize > > the two CRTCs and their corre

[Intel-gfx] [PATCH v2 3/8] drm/i915: make enable/disable rpm assert function use the rpm structure

2019-06-12 Thread Daniele Ceraolo Spurio
With this all the rpm assert-related functions consistently work on the i915_runtime_pm structure Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/i915_drv.c | 48 +++-- drivers/gpu/drm/i915/i915_irq.c | 32 +-- drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH v2 6/8] drm/i915: update rpm_get/put to use the rpm structure

2019-06-12 Thread Daniele Ceraolo Spurio
The functions where internally already only using the structure, so we need to just flip the interface. v2: rebase Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 11 +++-- drivers/gpu/drm/i915/gem/i915_gem_object.c| 4 +- drivers/gpu/drm/i915/gem/

[Intel-gfx] [PATCH v2 5/8] drm/i915: move a few more functions to accept the rpm structure

2019-06-12 Thread Daniele Ceraolo Spurio
Focusing on the functions called in few places. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.c | 22 ++- drivers/gpu/drm/i915/intel_runtime_pm.c | 19 +++- drivers/gp

[Intel-gfx] [PATCH v2 7/8] drm/i915: update with_intel_runtime_pm to use the rpm structure

2019-06-12 Thread Daniele Ceraolo Spurio
Matching the underlying get/put functions. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gem/i915_gem_shrinker.c | 8 +++ .../drm/i915/gem/selftests/i915_gem_context.c | 6 ++--- drivers/gpu/drm/i915/gt/intel_context.c | 2 +- drivers/gpu/drm/i915/gt/intel_reset.c

[Intel-gfx] [PATCH v2 8/8] drm/i915: make intel_wakeref work on the rpm struct

2019-06-12 Thread Daniele Ceraolo Spurio
intel_runtime_pm is the only thing they use from the i915 structure, so use that directly. Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gt/intel_engine_pm.c | 4 +-- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 4 +-- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/

[Intel-gfx] [PATCH v2 1/8] drm/i915: prefer i915_runtime_pm in intel_runtime function

2019-06-12 Thread Daniele Ceraolo Spurio
As a first step towards updating the code to work on the runtime_pm structure instead of i915, rework all the internals to use and pass around that. v2: add comment for kdev (Jani), move rpm init after pdev init for mock_device Signed-off-by: Daniele Ceraolo Spurio Cc: Jani Nikula --- drivers/

[Intel-gfx] [PATCH v2 0/8] RPM Encapsulation

2019-06-12 Thread Daniele Ceraolo Spurio
Rebased series after the display power code has been split out. Mostly the same as V1, just small fixes based on review comments and CI results. The last patch is new. The series grows the code a bit, but I believe it is worth it for the extra logical encapsulation. With all debug options disabled

[Intel-gfx] [PATCH v2 4/8] drm/i915: move and rename i915_runtime_pm

2019-06-12 Thread Daniele Ceraolo Spurio
Asserts aside, all the code working on this structure is in intel_runtime_pm.c and uses the intel_ prefix, so move the structure to intel_runtime_pm.h and adopt the same prefix. Since all the asserts are now working on the runtime_pm structure, bring them across as well. v2: drop unneeded include

[Intel-gfx] [PATCH v2 2/8] drm/i915: Remove rpm asserts that use i915

2019-06-12 Thread Daniele Ceraolo Spurio
Quite a few of the call points have already switched to the version working directly on the runtime_pm structure, so let's switch over the rest and kill the i915-based asserts. v2: rebase Signed-off-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 2 +- drivers/gpu/d

[Intel-gfx] [PATCH v3] drm/i915: Add Wa_1409120013:icl,ehl

2019-06-12 Thread Matt Roper
This chicken bit should be set before enabling FBC to avoid screen corruption when the plane size has odd vertical and horizontal dimensions. It is safe to leave the bit set even when FBC is disabled. v2: - The bspec's name for this bit on these platforms ("Spare 14") is pretty meaningless.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/4] drm/i915: Don't clobber M/N values during fastset check (rev2)

2019-06-12 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm/i915: Don't clobber M/N values during fastset check (rev2) URL : https://patchwork.freedesktop.org/series/61960/ State : warning == Summary == $ dim checkpatch origin/drm-tip f31b23cc1b1a drm/i915: Don't clobber M/N values during

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Refine placement of gt.reset_lockmap

2019-06-12 Thread Patchwork
== Series Details == Series: drm/i915: Refine placement of gt.reset_lockmap URL : https://patchwork.freedesktop.org/series/61973/ State : success == Summary == CI Bug Log - changes from CI_DRM_6253 -> Patchwork_13256 Summary --- **SU

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/dp: Trigger modeset if master_crtc or slaves bitmask changes

2019-06-12 Thread Manasi Navare
On Wed, Jun 12, 2019 at 10:32:04AM +0200, Maarten Lankhorst wrote: > Op 23-04-2019 om 17:49 schreef Manasi Navare: > > Add the comparison between the current state and new_crtc_state for > > newly added master_crtc pointer and slave bitmask so that > > if any of those change then the curernt master

Re: [Intel-gfx] [PATCH v2] drm/i915: Add Wa_1409120013:icl,ehl

2019-06-12 Thread Matt Roper
On Wed, Jun 12, 2019 at 11:16:02AM -0700, Matt Roper wrote: > This chicken bit should be set before enabling FBC to avoid screen > corruption when the plane size has odd vertical and horizontal > dimensions. It is safe to leave the bit set even when FBC is disabled. > > v2: > - The bspec's name

[Intel-gfx] [PATCH v2] drm/i915: Add Wa_1409120013:icl,ehl

2019-06-12 Thread Matt Roper
This chicken bit should be set before enabling FBC to avoid screen corruption when the plane size has odd vertical and horizontal dimensions. It is safe to leave the bit set even when FBC is disabled. v2: - The bspec's name for this bit on these platforms ("Spare 14") is pretty meaningless.

Re: [Intel-gfx] [PATCH] drm/i915: Add Wa_1409120013:icl,ehl

2019-06-12 Thread Clinton Taylor
On 6/10/19 3:27 PM, Matt Roper wrote: This chicken bit should be set before enabling FBC to avoid screen corruption when the plane size has odd vertical and horizontal dimensions. It is safe to leave the bit set even when FBC is disabled. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gtt: Skip initializing PT with scratch if full

2019-06-12 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Skip initializing PT with scratch if full URL : https://patchwork.freedesktop.org/series/61900/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230_full -> Patchwork_13244_full Summ

[Intel-gfx] [PATCH v2 1/4] drm/i915: Don't clobber M/N values during fastset check

2019-06-12 Thread Ville Syrjala
From: Ville Syrjälä We're now calling intel_pipe_config_compare(..., true) uncoditionally which means we're always going clobber the calculated M/N values with the old values if the fuzzy M/N check passes. That causes problems because the fuzzy check allows for a huge difference in the values. I

[Intel-gfx] [PATCH] drm/i915: Refine placement of gt.reset_lockmap

2019-06-12 Thread Chris Wilson
If we pull the lockmap into reset_prepare/reset_finish, it will naturally cover i915_gem_set_wedged() as well as i915_reset(). And with another tweak, we can pull __i915_gem_unset_wedged() underneath the lockmap covering the mutexes used there. As a bonus, it should hide the ugliness of the i915_r

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: kerneldoc warnings squelched

2019-06-12 Thread Patchwork
== Series Details == Series: drm/i915: kerneldoc warnings squelched URL : https://patchwork.freedesktop.org/series/61969/ State : success == Summary == CI Bug Log - changes from CI_DRM_6252 -> Patchwork_13255 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Nuke atomic set/get prop plane stubs

2019-06-12 Thread Patchwork
== Series Details == Series: drm/i915: Nuke atomic set/get prop plane stubs URL : https://patchwork.freedesktop.org/series/61898/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230_full -> Patchwork_13242_full Summary -

Re: [Intel-gfx] [REBASED PATCH 1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi

2019-06-12 Thread Kulkarni, Vandita
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjälä > Sent: Tuesday, June 11, 2019 5:52 PM > To: Nikula, Jani > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [REBASED PATCH 1/2] drm/i915: Move > intel_add_dsi_properties to intel_dsi > > On Mon, Jun 10, 2

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: kerneldoc warnings squelched

2019-06-12 Thread Patchwork
== Series Details == Series: drm/i915: kerneldoc warnings squelched URL : https://patchwork.freedesktop.org/series/61969/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0df0f9fce05a drm/i915: kerneldoc warnings squelched -:9: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped comm

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2] drm/i915: Keep contexts pinned until after the next kernel context switch (rev2)

2019-06-12 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915: Keep contexts pinned until after the next kernel context switch (rev2) URL : https://patchwork.freedesktop.org/series/61946/ State : success == Summary == CI Bug Log - changes from CI_DRM_6251 -> Patchwork_13254

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Make pipe_config_err() vs. fastset less confusing

2019-06-12 Thread Imre Deak
On Wed, Jun 12, 2019 at 04:08:00PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Rename pipe_config_err() to pipe_config_mismatch(), and also print > whether we're doing the fastset check or the sw vs. hw state readout > check. Should make the logs a bit less confusing when they're not >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2] drm/i915: Keep contexts pinned until after the next kernel context switch (rev2)

2019-06-12 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915: Keep contexts pinned until after the next kernel context switch (rev2) URL : https://patchwork.freedesktop.org/series/61946/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Keep

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2] drm/i915: Keep contexts pinned until after the next kernel context switch (rev2)

2019-06-12 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915: Keep contexts pinned until after the next kernel context switch (rev2) URL : https://patchwork.freedesktop.org/series/61946/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8566c15aaa58 drm/i915: Keep contexts pinn

Re: [Intel-gfx] [PATCH] drm/i915: kerneldoc warnings squelched

2019-06-12 Thread Ville Syrjälä
On Wed, Jun 12, 2019 at 04:13:11PM +0100, Chris Wilson wrote: > drivers/gpu/drm/i915//gem/i915_gem_shrinker.c:142: warning: Function > parameter or member 'shrink' not described in 'i915_gem_shrink' > drivers/gpu/drm/i915//gem/i915_gem_shrinker.c:142: warning: Excess function > parameter 'flags'

[Intel-gfx] [PATCH] drm/i915: kerneldoc warnings squelched

2019-06-12 Thread Chris Wilson
drivers/gpu/drm/i915//gem/i915_gem_shrinker.c:142: warning: Function parameter or member 'shrink' not described in 'i915_gem_shrink' drivers/gpu/drm/i915//gem/i915_gem_shrinker.c:142: warning: Excess function parameter 'flags' description in 'i915_gem_shrink' drivers/gpu/drm/i915//intel_display.

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size (rev2)

2019-06-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size (rev2) URL : https://patchwork.freedesktop.org/series/61887/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230_full -> Patchwork_13240_full

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for dma-fence/reservation: Markup rcu protected access for DEBUG_MUTEXES

2019-06-12 Thread Chris Wilson
Quoting Patchwork (2019-06-12 15:07:50) > == Series Details == > > Series: dma-fence/reservation: Markup rcu protected access for DEBUG_MUTEXES > URL : https://patchwork.freedesktop.org/series/61963/ > State : warning > > == Summary == > > $ dim sparse origin/drm-tip > Sparse version: v0.5.2 >

[Intel-gfx] ✓ Fi.CI.BAT: success for dma-fence/reservation: Markup rcu protected access for DEBUG_MUTEXES

2019-06-12 Thread Patchwork
== Series Details == Series: dma-fence/reservation: Markup rcu protected access for DEBUG_MUTEXES URL : https://patchwork.freedesktop.org/series/61963/ State : success == Summary == CI Bug Log - changes from CI_DRM_6249 -> Patchwork_13253 S

[Intel-gfx] [PATCH v2] drm/i915: Keep contexts pinned until after the next kernel context switch

2019-06-12 Thread Chris Wilson
We need to keep the context image pinned in memory until after the GPU has finished writing into it. Since it continues to write as we signal the final breadcrumb, we need to keep it pinned until the request after it is complete. Currently we know the order in which requests execute on each engine,

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Keep contexts pinned until after the next kernel context switch

2019-06-12 Thread Chris Wilson
Quoting Mika Kuoppala (2019-06-12 15:09:49) > Chris Wilson writes: > >> > +int i915_active_acquire_preallocate_barrier(struct i915_active *ref, > >> > + struct intel_engine_cs *engine) > >> > +{ > >> > + struct drm_i915_private *i915 = engine->i915; > >>

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Keep contexts pinned until after the next kernel context switch

2019-06-12 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-06-12 14:29:48) >> Chris Wilson writes: >> >> > We need to keep the context image pinned in memory until after the GPU >> > has finished writing into it. Since it continues to write as we signal >> > the final breadcrumb, we need to keep it pin

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for dma-fence/reservation: Markup rcu protected access for DEBUG_MUTEXES

2019-06-12 Thread Patchwork
== Series Details == Series: dma-fence/reservation: Markup rcu protected access for DEBUG_MUTEXES URL : https://patchwork.freedesktop.org/series/61963/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: dma-fence/reservation: Markup rcu protected access fo

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Don't clobber M/N values during fastset check

2019-06-12 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Don't clobber M/N values during fastset check URL : https://patchwork.freedesktop.org/series/61960/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6248 -> Patchwork_13252

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/6] drm/i915: Remove I915_READ8

2019-06-12 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915: Remove I915_READ8 URL : https://patchwork.freedesktop.org/series/61886/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230_full -> Patchwork_13236_full Su

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Keep contexts pinned until after the next kernel context switch

2019-06-12 Thread Chris Wilson
Quoting Mika Kuoppala (2019-06-12 14:29:48) > Chris Wilson writes: > > > We need to keep the context image pinned in memory until after the GPU > > has finished writing into it. Since it continues to write as we signal > > the final breadcrumb, we need to keep it pinned until the request after >

Re: [Intel-gfx] [PATCH] dma-fence/reservation: Markup rcu protected access for DEBUG_MUTEXES

2019-06-12 Thread Christian König
Am 12.06.19 um 15:28 schrieb Chris Wilson: Mark the access to reservation_object.fence as being protected to silence sparse. Signed-off-by: Chris Wilson Reviewed-by: Christian König --- include/linux/reservation.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Keep contexts pinned until after the next kernel context switch

2019-06-12 Thread Mika Kuoppala
Chris Wilson writes: > We need to keep the context image pinned in memory until after the GPU > has finished writing into it. Since it continues to write as we signal > the final breadcrumb, we need to keep it pinned until the request after > it is complete. Currently we know the order in which r

[Intel-gfx] [PATCH] dma-fence/reservation: Markup rcu protected access for DEBUG_MUTEXES

2019-06-12 Thread Chris Wilson
Mark the access to reservation_object.fence as being protected to silence sparse. Signed-off-by: Chris Wilson --- include/linux/reservation.h | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/include/linux/reservation.h b/include/linux/reservation.h index ee750765cc94..

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Combine unbound/bound list tracking for objects

2019-06-12 Thread Patchwork
== Series Details == Series: drm/i915: Combine unbound/bound list tracking for objects URL : https://patchwork.freedesktop.org/series/61952/ State : success == Summary == CI Bug Log - changes from CI_DRM_6248 -> Patchwork_13251 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Don't clobber M/N values during fastset check

2019-06-12 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Don't clobber M/N values during fastset check URL : https://patchwork.freedesktop.org/series/61960/ State : warning == Summary == $ dim checkpatch origin/drm-tip bc29623ab5e2 drm/i915: Don't clobber M/N values during fastset ch

[Intel-gfx] [PATCH 2/4] drm/i915: Constify intel_pipe_config_compare()

2019-06-12 Thread Ville Syrjala
From: Ville Syrjälä Now that intel_pipe_config_compare() no longer clobbers the passed in state we can make both crtc states const. And while at we simplify the calling convention, and clean up intel_compare_link_m_n() a bit. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.

[Intel-gfx] [PATCH 4/4] drm/i915: Drop the _INCOMPLETE for has_infoframe

2019-06-12 Thread Ville Syrjala
From: Ville Syrjälä We have full infoframe readout now so we can replace the PIPE_CONF_CHECK_BOOL_INCOMPLETE(has_infoframe) with the normal PIPE_CONF_CHECK_BOOL(has_infoframe). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

  1   2   >