Re: [Intel-gfx] [PATCH] drm/i915/perf: fix ICL perf register offsets

2019-06-11 Thread Lionel Landwerlin
On 10/06/2019 18:25, Kenneth Graunke wrote: On Monday, June 10, 2019 1:19:14 AM PDT Lionel Landwerlin wrote: We got the wrong offsets (could they have changed?). New values were computed off an error state by looking up the register offset in the context image as written by the HW. Signed-off-b

[Intel-gfx] ✗ Fi.CI.BAT: failure for Enable Multi-segmented-gamma for ICL (rev4)

2019-06-11 Thread Patchwork
== Series Details == Series: Enable Multi-segmented-gamma for ICL (rev4) URL : https://patchwork.freedesktop.org/series/60126/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6242 -> Patchwork_13248 Summary --- **FAILU

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add Wa_1409120013:icl,ehl

2019-06-11 Thread Patchwork
== Series Details == Series: drm/i915: Add Wa_1409120013:icl,ehl URL : https://patchwork.freedesktop.org/series/61867/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230_full -> Patchwork_13231_full Summary --- **WAR

Re: [Intel-gfx] [CI 6/6] drm/i915: Remove I915_READ64 and I915_READ64_32x2

2019-06-11 Thread Tvrtko Ursulin
On 11/06/2019 18:11, Ville Syrjälä wrote: On Mon, Jun 10, 2019 at 01:06:08PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Now that all their users are gone we can remove the macros and accompanying duplicated comment. Signed-off-by: Tvrtko Ursulin Suggested-by: Jani Nikula Reviewed-by

[Intel-gfx] [v4 4/4] drm/i915/icl: Add Multi-segmented gamma support

2019-06-11 Thread Uma Shankar
From: Shashank Sharma ICL introduces a new gamma correction mode in display engine, called multi-segmented-gamma mode. This mode allows users to program the darker region of the gamma curve with sueprfine precision. An example use case for this is HDR curves (like PQ ST-2084). If we plot a gamma

[Intel-gfx] [v4 3/4] drm/i915: Rename ivb_load_lut_10_max

2019-06-11 Thread Uma Shankar
From: Shashank Sharma This patch renames function ivb_load_lut_10_max to ivb_load_lut_ext_max. V3: Added Vill'es r-b. Cc: Uma Shankar Suggested-by: Ville Syrjala Reviewed-by: Ville Syrjala Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_color.c | 14 +++--- 1 file ch

[Intel-gfx] [v4 2/4] drm/i915/icl: Add register definitions for Multi Segmented gamma

2019-06-11 Thread Uma Shankar
Add macros to define multi segmented gamma registers V2: Addressed Ville's comments: Add gen-lable before bit definition Addressed Jani's comment - Use REG_GENMASK() and REG_BIT() V3: Addressed Ville's comments: - Put comments at the end of line. - Change the comment at

[Intel-gfx] [v4 0/4] Enable Multi-segmented-gamma for ICL

2019-06-11 Thread Uma Shankar
This patch series enables programming of Multi-segmented-gamma palette for ICL. Note: Due to the roundup and eventual precision loss, there are CRC failures with IGT color tests when multi segmented gamma mode is enabled. v4: Rebase and addressed Ville's review comments. Shashank Sharma (3): d

[Intel-gfx] [v4 1/4] drm/i915: Change gamma/degamma_lut_size data type to u32

2019-06-11 Thread Uma Shankar
From: Shashank Sharma Currently, data type of gamma_lut_size & degamma_lut_size elements in intel_device_info is u16, which means it can accommodate maximum 64k values. In case of ICL multisegmented gamma, the size of gamma LUT is 256K. This patch changes the data type of both of these elements

Re: [Intel-gfx] [PATCH 00/33] fbcon notifier begone v3!

2019-06-11 Thread Lee Jones
On Tue, 11 Jun 2019, Daniel Thompson wrote: > On Fri, Jun 07, 2019 at 12:07:55PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On 6/6/19 9:38 AM, Daniel Vetter wrote: > > > > >> - Hash out actual merge plan. > > > > > > I'd like to stuff this into drm.git somehow, I guess topic branch works > > > t

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [RFC,1/2] drm/i915: move modesetting output/encoder code under display/

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915: move modesetting output/encoder code under display/ URL : https://patchwork.freedesktop.org/series/61865/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230_full -> Patchwork_13230_full

[Intel-gfx] ✓ Fi.CI.IGT: success for Use ranges for voltage level lookup

2019-06-11 Thread Patchwork
== Series Details == Series: Use ranges for voltage level lookup URL : https://patchwork.freedesktop.org/series/61864/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230_full -> Patchwork_13229_full Summary --- **SUC

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: remove duplicate entry of trace (rev2)

2019-06-11 Thread Patchwork
== Series Details == Series: drm/i915/gvt: remove duplicate entry of trace (rev2) URL : https://patchwork.freedesktop.org/series/61281/ State : success == Summary == CI Bug Log - changes from CI_DRM_6242 -> Patchwork_13247 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: remove duplicate entry of trace (rev2)

2019-06-11 Thread Patchwork
== Series Details == Series: drm/i915/gvt: remove duplicate entry of trace (rev2) URL : https://patchwork.freedesktop.org/series/61281/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1e63ef1847a7 drm/i915/gvt: remove duplicate entry of trace -:16: WARNING:COMMIT_LOG_LONG_LINE: P

Re: [Intel-gfx] [PATCH] drm/i915/gvt: remove duplicate entry of trace

2019-06-11 Thread Zhenyu Wang
On 2019.05.26 13:26:33 +0530, Hariprasad Kelam wrote: > Remove duplicate include of trace.h > > Issue identified by includecheck > > Signed-off-by: Hariprasad Kelam > --- > drivers/gpu/drm/i915/gvt/trace_points.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/gvt/

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the amdgpu tree

2019-06-11 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/amd/display/dc/dce/dce_audio.c between commit: c7c7192c56d2 ("drm/amd/display: add audio related regs") from the amdgpu tree and commit: 4fc4dca8320e ("drm/amd: drop use of drmp.h in os_types.h") f

Re: [Intel-gfx] [PATCH 3/5] drm/panel: Add attach/detach callbacks

2019-06-11 Thread dbasehore .
On Tue, Jun 11, 2019 at 1:57 AM Daniel Vetter wrote: > > On Mon, Jun 10, 2019 at 09:03:48PM -0700, Derek Basehore wrote: > > This adds the attach/detach callbacks. These are for setting up > > internal state for the connector/panel pair that can't be done at > > probe (since the connector doesn't

Re: [Intel-gfx] [PATCH] drm/i915: Engine relative MMIO

2019-06-11 Thread Rodrigo Vivi
On Mon, May 20, 2019 at 07:19:58AM +0100, Tvrtko Ursulin wrote: > > On 17/05/2019 02:25, John Harrison wrote: > > On 5/15/2019 01:52, Tvrtko Ursulin wrote: > > > > > > On 13/05/2019 20:45, john.c.harri...@intel.com wrote: > > > > From: John Harrison > > > > > > > > With virtual engines, it is n

Re: [Intel-gfx] [PATCH 4/5] drm/connector: Split out orientation quirk detection

2019-06-11 Thread dbasehore .
On Tue, Jun 11, 2019 at 1:54 AM Hans de Goede wrote: > > Hi, > > On 11-06-19 10:08, Jani Nikula wrote: > > On Mon, 10 Jun 2019, Derek Basehore wrote: > >> This removes the orientation quirk detection from the code to add > >> an orientation property to a panel. This is used only for legacy x86 >

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [REBASED,1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [REBASED,1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi URL : https://patchwork.freedesktop.org/series/61862/ State : success == Summary == CI Bug Log - changes from CI_DRM_6227_full -> Patchwork_13228_full =

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/icl: Assign Master slave crtc links for Transcoder Port Sync

2019-06-11 Thread Manasi Navare
Need some suggestions on what could be stored in slave_crtc_state to point to the master, See my comments/questions inline On Tue, Apr 23, 2019 at 08:48:58AM -0700, Manasi Navare wrote: > In case of tiled displays when the two tiles are sent across two CRTCs > over two separate DP SST connectors,

[Intel-gfx] ✓ Fi.CI.IGT: success for Implicit dev_priv removal (rev2)

2019-06-11 Thread Patchwork
== Series Details == Series: Implicit dev_priv removal (rev2) URL : https://patchwork.freedesktop.org/series/61705/ State : success == Summary == CI Bug Log - changes from CI_DRM_6227_full -> Patchwork_13227_full Summary --- **WARNIN

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Promote i915->mm.obj_lock to be irqsafe (rev3)

2019-06-11 Thread Patchwork
== Series Details == Series: drm/i915: Promote i915->mm.obj_lock to be irqsafe (rev3) URL : https://patchwork.freedesktop.org/series/61832/ State : success == Summary == CI Bug Log - changes from CI_DRM_6227_full -> Patchwork_13226_full Sum

Re: [Intel-gfx] [PATCH 2/5] dt-bindings: display/panel: Expand rotation documentation

2019-06-11 Thread dbasehore .
On Tue, Jun 11, 2019 at 8:25 AM Rob Herring wrote: > > On Mon, Jun 10, 2019 at 10:03 PM Derek Basehore > wrote: > > > > This adds to the rotation documentation to explain how drivers should > > use the property and gives an example of the property in a devicetree > > node. > > > > Signed-off-by:

Re: [Intel-gfx] [PATCH 8/9] drm/i915/gtt: Make swapping the pd entry generic

2019-06-11 Thread Chris Wilson
Quoting Chris Wilson (2019-06-11 20:50:09) > Quoting Mika Kuoppala (2019-06-11 18:27:30) > > Swapping a pd entry is same across the page directories, if > > we succeed we need to increment the count and write the phys page > > entry. Make a common function for it. > > > > Signed-off-by: Mika Kuopp

Re: [Intel-gfx] [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-06-11 Thread Andrew Morton
On Tue, 11 Jun 2019 15:00:10 -0600 Andreas Dilger wrote: > >> to FIELD_SIZEOF > > > > As Alexey has pointed out, C structs and unions don't have fields - > > they have members. So this is an opportunity to switch everything to > > a new member_sizeof(). > > > > What do people think of that and

Re: [Intel-gfx] [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-06-11 Thread Andrew Morton
On Wed, 12 Jun 2019 01:08:36 +0530 Shyam Saini wrote: > Currently, there are 3 different macros, namely sizeof_field, SIZEOF_FIELD > and FIELD_SIZEOF which are used to calculate the size of a member of > structure, so to bring uniformity in entire kernel source tree lets use > FIELD_SIZEOF and r

Re: [Intel-gfx] [PATCH V2] include: linux: Regularise the use of FIELD_SIZEOF macro

2019-06-11 Thread Kees Cook
On Wed, Jun 12, 2019 at 01:08:36AM +0530, Shyam Saini wrote: > In favour of FIELD_SIZEOF, this patch also deprecates other two similar > macros sizeof_field and SIZEOF_FIELD. > > For code compatibility reason, retain sizeof_field macro as a wrapper macro > to FIELD_SIZEOF Can you explain this par

Re: [Intel-gfx] [RFC 7/8] drm/i915: introduce display_uncore

2019-06-11 Thread Daniele Ceraolo Spurio
On 6/7/19 1:58 AM, Tvrtko Ursulin wrote: + Jani & Ville Jani, Ville, any feedback on this approach? BTW, If we want to keep the accesses short we could also have display_* register access wrappers that take i915 and internally use &i915->de_uncore. On 06/06/2019 22:52, Daniele Ceraolo

Re: [Intel-gfx] [PATCH 2/9] drm/i915/gtt: Use a common type for page directories

2019-06-11 Thread Chris Wilson
Quoting Chris Wilson (2019-06-11 20:41:59) > Quoting Mika Kuoppala (2019-06-11 18:27:24) > > struct i915_page_table { > > struct i915_page_dma base; > > - atomic_t used_ptes; > > + atomic_t used; > > }; > > > > struct i915_page_directory { > > struct i915_page_dma b

Re: [Intel-gfx] [PATCH 8/9] drm/i915/gtt: Make swapping the pd entry generic

2019-06-11 Thread Chris Wilson
Quoting Mika Kuoppala (2019-06-11 18:27:30) > Swapping a pd entry is same across the page directories, if > we succeed we need to increment the count and write the phys page > entry. Make a common function for it. > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 41

Re: [Intel-gfx] [PATCH 3/9] drm/i915/gtt: Introduce init_pd_with_page

2019-06-11 Thread Chris Wilson
Quoting Mika Kuoppala (2019-06-11 18:27:25) > We set the page directory entries to point into a page table. > There is no gen specifics in here so make it simple and > obvious. > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 16 > 1 file changed, 8

Re: [Intel-gfx] [PATCH 2/9] drm/i915/gtt: Use a common type for page directories

2019-06-11 Thread Chris Wilson
Quoting Mika Kuoppala (2019-06-11 18:27:24) > All page directories are identical in function, only the position in the > hierarchy differ. Use same base type for directory functionality. > > Cc: Chris Wilson > Cc: Joonas Lahtinen > Cc: Matthew Auld > Cc: Abdiel Janulgue > Signed-off-by: Mika K

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "drm/i915/icl: More workaround for port F detection due to broken VBTs"

2019-06-11 Thread Patchwork
== Series Details == Series: Revert "drm/i915/icl: More workaround for port F detection due to broken VBTs" URL : https://patchwork.freedesktop.org/series/61846/ State : success == Summary == CI Bug Log - changes from CI_DRM_6227_full -> Patchwork_13225_full ==

Re: [Intel-gfx] [PATCH 2/9] drm/i915/gtt: Use a common type for page directories

2019-06-11 Thread Chris Wilson
Quoting Mika Kuoppala (2019-06-11 18:27:24) > struct i915_page_table { > struct i915_page_dma base; > - atomic_t used_ptes; > + atomic_t used; > }; > > struct i915_page_directory { > struct i915_page_dma base; > - > - struct i915_page_table *page_table[I915_PD

Re: [Intel-gfx] [PATCH 1/9] drm/i915/gtt: No need to zero the table for page dirs

2019-06-11 Thread Chris Wilson
Quoting Mika Kuoppala (2019-06-11 18:27:23) > We set them to scratch right after allocation so prevent > useless zeroing before. > > v2: atomic_t > > Cc: Chris Wilson > Signed-off-by: Mika Kuoppala > Reviewed-by: Chris Wilson > --- > drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++-- > 1 file chan

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915: Do not touch the PCH SSC reference if a PLL is using it (rev2)

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Do not touch the PCH SSC reference if a PLL is using it (rev2) URL : https://patchwork.freedesktop.org/series/61608/ State : success == Summary == CI Bug Log - changes from CI_DRM_6227_full -> Patchwork_13224_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/9] drm/i915/gtt: No need to zero the table for page dirs

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915/gtt: No need to zero the table for page dirs URL : https://patchwork.freedesktop.org/series/61914/ State : success == Summary == CI Bug Log - changes from CI_DRM_6240 -> Patchwork_13246 ==

Re: [Intel-gfx] [PATCH 3/4] drm/fb-helper: Set up gamma_lut during restore_fbdev_mode_atomic()

2019-06-11 Thread Ville Syrjälä
On Tue, Jun 11, 2019 at 07:55:45PM +0200, Daniel Vetter wrote: > On Tue, Jun 11, 2019 at 7:50 PM Ville Syrjälä > wrote: > > > > On Fri, Jun 07, 2019 at 08:40:15PM +0200, Daniel Vetter wrote: > > > On Fri, Jun 07, 2019 at 07:26:10PM +0300, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > > > >

Re: [Intel-gfx] [PATCH v5 04/11] drm: Convert connector_helper_funcs->atomic_check to accept drm_atomic_state

2019-06-11 Thread Laurent Pinchart
Hi Sean, Thank you for the patch. On Tue, Jun 11, 2019 at 12:08:18PM -0400, Sean Paul wrote: > From: Sean Paul > > Everyone who implements connector_helper_funcs->atomic_check reaches > into the connector state to get the atomic state. Instead of continuing > this pattern, change the callback s

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/9] drm/i915/gtt: No need to zero the table for page dirs

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915/gtt: No need to zero the table for page dirs URL : https://patchwork.freedesktop.org/series/61914/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/gtt: No need to zero the table

Re: [Intel-gfx] [PATCH 3/4] drm/fb-helper: Set up gamma_lut during restore_fbdev_mode_atomic()

2019-06-11 Thread Daniel Vetter
On Tue, Jun 11, 2019 at 7:50 PM Ville Syrjälä wrote: > > On Fri, Jun 07, 2019 at 08:40:15PM +0200, Daniel Vetter wrote: > > On Fri, Jun 07, 2019 at 07:26:10PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > i915 will now refuse to enable a C8 plane unless the gamma_lut > > > is

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/9] drm/i915/gtt: No need to zero the table for page dirs

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [1/9] drm/i915/gtt: No need to zero the table for page dirs URL : https://patchwork.freedesktop.org/series/61914/ State : warning == Summary == $ dim checkpatch origin/drm-tip 84806e55a140 drm/i915/gtt: No need to zero the table for page dirs

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Throw away the BIOS fb if has the wrong depth/bpp

2019-06-11 Thread Ville Syrjälä
On Fri, Jun 07, 2019 at 08:43:56PM +0200, Daniel Vetter wrote: > On Fri, Jun 07, 2019 at 07:26:11PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Respect the user's choice of depth/bpp for the fbdev framebuffer > > and throw out the fb we inherited from the BIOS if it doesn't > > ma

Re: [Intel-gfx] [PATCH 3/4] drm/fb-helper: Set up gamma_lut during restore_fbdev_mode_atomic()

2019-06-11 Thread Ville Syrjälä
On Fri, Jun 07, 2019 at 08:40:15PM +0200, Daniel Vetter wrote: > On Fri, Jun 07, 2019 at 07:26:10PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > i915 will now refuse to enable a C8 plane unless the gamma_lut > > is already enabled (to avoid scanning out whatever garbage got > > lef

[Intel-gfx] [PATCH 2/9] drm/i915/gtt: Use a common type for page directories

2019-06-11 Thread Mika Kuoppala
All page directories are identical in function, only the position in the hierarchy differ. Use same base type for directory functionality. Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Matthew Auld Cc: Abdiel Janulgue Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/gem/i915_gem_context.c |

[Intel-gfx] [PATCH 8/9] drm/i915/gtt: Make swapping the pd entry generic

2019-06-11 Thread Mika Kuoppala
Swapping a pd entry is same across the page directories, if we succeed we need to increment the count and write the phys page entry. Make a common function for it. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_gtt.c | 41 +++-- 1 file changed, 27 insertio

[Intel-gfx] [PATCH 3/9] drm/i915/gtt: Introduce init_pd_with_page

2019-06-11 Thread Mika Kuoppala
We set the page directory entries to point into a page table. There is no gen specifics in here so make it simple and obvious. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_gtt.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 9/9] drm/i915/gtt: Tear down setup and cleanup macros for page dma

2019-06-11 Thread Mika Kuoppala
We don't use common codepaths to setup and cleanup page directories vs page tables. So their setup and cleanup macros are of no use. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_gtt.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 7/9] drm/i915/gtt: Check for physical page for pd entry always

2019-06-11 Thread Mika Kuoppala
Check the physical page before writing the entry into the physical page. This further generalizes the pd so that manipulation in callsites will be identical, removing the need to handle pdps differently for gen8. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_gtt.c | 20 +++--

[Intel-gfx] [PATCH 5/9] drm/i915/gtt: Generalize alloc_pd

2019-06-11 Thread Mika Kuoppala
Allocate all page directory variants with alloc_pd. As the lvl3 and lvl4 variants differ in manipulation, we need to check for existence of backing phys page before accessing it. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_gtt.c | 100 1 file chang

[Intel-gfx] [PATCH 1/9] drm/i915/gtt: No need to zero the table for page dirs

2019-06-11 Thread Mika Kuoppala
We set them to scratch right after allocation so prevent useless zeroing before. v2: atomic_t Cc: Chris Wilson Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 6/9] drm/i915/gtt: pde entry encoding is identical

2019-06-11 Thread Mika Kuoppala
For all page directory entries, the pde encoding is identical. Don't compilicate call sites with different versions of doing the same thing. Only wart that remains is a 4 entry gen8/bsw pdp, for which we need to check the backing phys page. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 4/9] drm/i915/gtt: Introduce init_pd

2019-06-11 Thread Mika Kuoppala
All page directories, excluding last level, are initialized with pointer to next level page directories. Make common function for it. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem_gtt.c | 37 +++-- 1 file changed, 14 insertions(+), 23 deletions(-) diff -

Re: [Intel-gfx] [RFC 1/2] drm/i915: move modesetting output/encoder code under display/

2019-06-11 Thread Rodrigo Vivi
On Tue, Jun 11, 2019 at 08:47:07AM +0100, Chris Wilson wrote: > Quoting Jani Nikula (2019-06-10 22:53:11) > > Add a new subdirectory for display code, and start off by moving > > modesetting output/encoder code. Judging by the include changes, this is > > a surprisingly clean operation. > > > > Cc

Re: [Intel-gfx] [RFC 2/2] drm/i915: move modesetting core code under display/

2019-06-11 Thread Rodrigo Vivi
On Tue, Jun 11, 2019 at 08:52:31AM +0100, Chris Wilson wrote: > Quoting Jani Nikula (2019-06-10 22:53:12) > > Now that we have a new subdirectory for display code, continue by moving > > modesetting core code. > > > > display/intel_frontbuffer.h sticks out like a sore thumb, otherwise this > > is,

Re: [Intel-gfx] [CI 6/6] drm/i915: Remove I915_READ64 and I915_READ64_32x2

2019-06-11 Thread Ville Syrjälä
On Mon, Jun 10, 2019 at 01:06:08PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Now that all their users are gone we can remove the macros and > accompanying duplicated comment. > > Signed-off-by: Tvrtko Ursulin > Suggested-by: Jani Nikula > Reviewed-by: Jani Nikula > --- > driver

Re: [Intel-gfx] [PATCH] drm/i915: Nuke atomic set/get prop plane stubs

2019-06-11 Thread Ville Syrjälä
On Tue, Jun 11, 2019 at 03:28:20PM +0200, Maarten Lankhorst wrote: > They have been unused since rotation was added to drm core in 2015, > time to get rid of them. > > Signed-off-by: Maarten Lankhorst Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_atomic_plane.c | 45 --

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Skip initializing PT with scratch if full

2019-06-11 Thread Mika Kuoppala
Chris Wilson writes: > If we will completely overwrite the PT with PTEs for the object, we can > forgo filling it with scratch entries. > > References: 14826673247e ("drm/i915: Only initialize partially filled > pagetables") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen > Cc: Mika Kuoppa

Re: [Intel-gfx] [RFC 08/14] drm/i915: Store backpointer to intel_gt in the engine

2019-06-11 Thread Daniele Ceraolo Spurio
On 6/11/2019 2:36 AM, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-06-11 09:41:02) On 10/06/2019 19:17, Daniele Ceraolo Spurio wrote: On 6/10/19 9:16 AM, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-06-10 16:54:13) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_types.h b/drivers/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Prevent lock-cycles between GPU waits and GPU resets

2019-06-11 Thread Patchwork
== Series Details == Series: drm/i915: Prevent lock-cycles between GPU waits and GPU resets URL : https://patchwork.freedesktop.org/series/61901/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230 -> Patchwork_13245 Summary

[Intel-gfx] [PATCH v5 04/11] drm: Convert connector_helper_funcs->atomic_check to accept drm_atomic_state

2019-06-11 Thread Sean Paul
From: Sean Paul Everyone who implements connector_helper_funcs->atomic_check reaches into the connector state to get the atomic state. Instead of continuing this pattern, change the callback signature to just give atomic state and let the driver determine what it does and does not need from it.

Re: [Intel-gfx] [PATCH 00/33] fbcon notifier begone v3!

2019-06-11 Thread Daniel Vetter
On Tue, Jun 11, 2019 at 03:16:35PM +0100, Daniel Thompson wrote: > On Fri, Jun 07, 2019 at 12:07:55PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > > On 6/6/19 9:38 AM, Daniel Vetter wrote: > > > Hi Bart, > > > > Hi Daniel, > > > > > On Tue, May 28, 2019 at 11:02:31AM +0200, Daniel Vetter wrote:

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915/icl: use ranges for voltage level lookup

2019-06-11 Thread Ville Syrjälä
On Mon, Jun 10, 2019 at 02:48:19PM -0700, Lucas De Marchi wrote: > Spec shows voltage level 0 as 307.2, 312, or lower and suggests to use > range checks. Prepare for having other frequencies in these ranges by > not comparing the exact frequency. > > v2: invert checks by comparing biggest cdclk fi

Re: [Intel-gfx] [PATCH 24/33] Revert "backlight/fbcon: Add FB_EVENT_CONBLANK"

2019-06-11 Thread Daniel Vetter
On Tue, Jun 11, 2019 at 03:09:29PM +0100, Daniel Thompson wrote: > On Tue, May 28, 2019 at 11:02:55AM +0200, Daniel Vetter wrote: > > This reverts commit 994efacdf9a087b52f71e620b58dfa526b0cf928. > > > > The justification is that if hw blanking fails (i.e. fbops->fb_blank) > > fails, then we still

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: Skip initializing PT with scratch if full

2019-06-11 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Skip initializing PT with scratch if full URL : https://patchwork.freedesktop.org/series/61900/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230 -> Patchwork_13244 Summary --

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: Skip initializing PT with scratch if full

2019-06-11 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Skip initializing PT with scratch if full URL : https://patchwork.freedesktop.org/series/61900/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6afacc870ab4 drm/i915/gtt: Skip initializing PT with scratch if full -:9: WARNING:COMMIT_LOG_

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Check the right binding exists in i915_vma_misplaced()

2019-06-11 Thread Patchwork
== Series Details == Series: drm/i915: Check the right binding exists in i915_vma_misplaced() URL : https://patchwork.freedesktop.org/series/61899/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6230 -> Patchwork_13243 Summa

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hangcheck: Look at instdone for all engines

2019-06-11 Thread Patchwork
== Series Details == Series: drm/i915/hangcheck: Look at instdone for all engines URL : https://patchwork.freedesktop.org/series/61843/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225_full -> Patchwork_13223_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Nuke atomic set/get prop plane stubs

2019-06-11 Thread Patchwork
== Series Details == Series: drm/i915: Nuke atomic set/get prop plane stubs URL : https://patchwork.freedesktop.org/series/61898/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230 -> Patchwork_13242 Summary --- **SU

[Intel-gfx] [PATCH] drm/i915: Prevent lock-cycles between GPU waits and GPU resets

2019-06-11 Thread Chris Wilson
We cannot allow ourselves to wait on the GPU while holding any lock we may need to reset the GPU. While there is not an explicit lock between the two operations, lockdep cannot detect the dependency. So let's tell lockdep about the wait/reset dependency with an explicit lockmap. Signed-off-by: Chr

[Intel-gfx] [PATCH] drm/i915/gtt: Skip initializing PT with scratch if full

2019-06-11 Thread Chris Wilson
If we will completely overwrite the PT with PTEs for the object, we can forgo filling it with scratch entries. References: 14826673247e ("drm/i915: Only initialize partially filled pagetables") Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Mika Kuoppala Cc: Matthew Auld Reviewed-by: Mat

Re: [Intel-gfx] [PATCH 00/33] fbcon notifier begone v3!

2019-06-11 Thread Daniel Thompson
On Fri, Jun 07, 2019 at 12:07:55PM +0200, Bartlomiej Zolnierkiewicz wrote: > > On 6/6/19 9:38 AM, Daniel Vetter wrote: > > Hi Bart, > > Hi Daniel, > > > On Tue, May 28, 2019 at 11:02:31AM +0200, Daniel Vetter wrote: > >> Hi all, > >> > >> I think we're slowly getting there. Previous cover letter

Re: [Intel-gfx] [PATCH 33/33] backlight: simplify lcd notifier

2019-06-11 Thread Daniel Thompson
On Tue, May 28, 2019 at 11:03:04AM +0200, Daniel Vetter wrote: > With all the work I've done on replacing fb notifier calls with direct > calls into fbcon the backlight/lcd notifier is the only user left. > > It will only receive events now that it cares about, hence we can > remove this check. >

Re: [Intel-gfx] [PATCH 28/33] fbcon: replace FB_EVENT_MODE_CHANGE/_ALL with direct calls

2019-06-11 Thread Daniel Thompson
On Tue, May 28, 2019 at 11:02:59AM +0200, Daniel Vetter wrote: > Create a new wrapper function for this, feels like there's some > refactoring room here between the two modes. > > v2: backlight notifier is also interested in the mode change event, > it calls lcd->set_mode, of which there are 3 imp

Re: [Intel-gfx] [PATCH 24/33] Revert "backlight/fbcon: Add FB_EVENT_CONBLANK"

2019-06-11 Thread Daniel Thompson
On Tue, May 28, 2019 at 11:02:55AM +0200, Daniel Vetter wrote: > This reverts commit 994efacdf9a087b52f71e620b58dfa526b0cf928. > > The justification is that if hw blanking fails (i.e. fbops->fb_blank) > fails, then we still want to shut down the backlight. Which is exactly > _not_ what fb_blank()

[Intel-gfx] [PATCH] drm/i915: Check the right binding exists in i915_vma_misplaced()

2019-06-11 Thread Chris Wilson
As a final check, after checking the various alignment and placement, check that we exist in the right binding alias. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_vma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Make read_subslice_reg take engine

2019-06-11 Thread Patchwork
== Series Details == Series: drm/i915: Make read_subslice_reg take engine URL : https://patchwork.freedesktop.org/series/61841/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225_full -> Patchwork_13222_full Summary ---

[Intel-gfx] [PATCH] drm/i915: Nuke atomic set/get prop plane stubs

2019-06-11 Thread Maarten Lankhorst
They have been unused since rotation was added to drm core in 2015, time to get rid of them. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic_plane.c | 45 --- drivers/gpu/drm/i915/intel_atomic_plane.h | 8 drivers/gpu/drm/i915/intel_display.c

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Make GuC GGTT reservation work on ggtt

2019-06-11 Thread Michal Wajdeczko
On Tue, 11 Jun 2019 15:13:21 +0200, Tvrtko Ursulin wrote: Michal, On 11/06/2019 13:23, Tvrtko Ursulin wrote: From: Tvrtko Ursulin These functions operate on ggtt so make them take that directly as parameter. At the same time move the USES_GUC conditional down to intel_guc_reserve_ggtt_t

Re: [Intel-gfx] [PATCH v4 2/2] drm/i915: Make GuC GGTT reservation work on ggtt

2019-06-11 Thread Tvrtko Ursulin
Michal, On 11/06/2019 13:23, Tvrtko Ursulin wrote: From: Tvrtko Ursulin These functions operate on ggtt so make them take that directly as parameter. At the same time move the USES_GUC conditional down to intel_guc_reserve_ggtt_top for symmetry with intel_guc_reserved_gtt_size. v2: * Rena

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size (rev2)

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size (rev2) URL : https://patchwork.freedesktop.org/series/61887/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230 -> Patchwork_13240 ==

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Move fence register tracking from i915->mm to ggtt

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move fence register tracking from i915->mm to ggtt URL : https://patchwork.freedesktop.org/series/61895/ State : failure == Summary == Applying: drm/i915: Move fence register tracking from i915->mm to ggtt Using index info to r

Re: [Intel-gfx] [PATCH v8 0/5] drm/fb-helper: Move modesetting code to drm_client

2019-06-11 Thread Noralf Trønnes
Den 08.06.2019 17.26, skrev Noralf Trønnes: > This moves the modesetting code from drm_fb_helper to drm_client so it > can be shared by all internal clients. > > Let's see what the CI says about the remaining patches. I have added the > bootsplash todo entry patch adding Sam as contact. > > Nor

[Intel-gfx] [PATCH 2/2] drm/i915: Track ggtt fence reservations under its own mutex

2019-06-11 Thread Chris Wilson
We can reduce the locking for fence registers from the dev->struct_mutex to a local mutex. We could introduce a mutex for the sole purpose of tracking the fence acquisition, except there is a little bit of overlap with the fault tracking, so use the i915_ggtt.mutex as it covers both. Signed-off-by

[Intel-gfx] [PATCH 1/2] drm/i915: Move fence register tracking from i915->mm to ggtt

2019-06-11 Thread Chris Wilson
As the fence registers only apply to regions inside the GGTT is makes more sense that we track these as part of the i915_ggtt and not the general mm. In the next patch, we will then pull the register locking underneath the i915_ggtt.mutex. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala -

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size (rev2)

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size (rev2) URL : https://patchwork.freedesktop.org/series/61887/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/guc: Mo

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Move fence register tracking from i915->mm to ggtt

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move fence register tracking from i915->mm to ggtt URL : https://patchwork.freedesktop.org/series/61893/ State : failure == Summary == Applying: drm/i915: Move fence register tracking from i915->mm to ggtt Using index info to r

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/6] drm/i915: Eliminate unused mmio accessors

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915: Eliminate unused mmio accessors URL : https://patchwork.freedesktop.org/series/61837/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225_full -> Patchwork_13221_full ==

[Intel-gfx] [PATCH v4 2/2] drm/i915: Make GuC GGTT reservation work on ggtt

2019-06-11 Thread Tvrtko Ursulin
From: Tvrtko Ursulin These functions operate on ggtt so make them take that directly as parameter. At the same time move the USES_GUC conditional down to intel_guc_reserve_ggtt_top for symmetry with intel_guc_reserved_gtt_size. v2: * Rename and move functions to be static in i915_gem_gtt.c (Mi

[Intel-gfx] [PATCH 1/2] drm/i915: Move fence register tracking from i915->mm to ggtt

2019-06-11 Thread Chris Wilson
As the fence registers only apply to regions inside the GGTT is makes more sense that we track these as part of the i915_ggtt and not the general mm. In the next patch, we will then pull the register locking underneath the i915_ggtt.mutex. Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala -

[Intel-gfx] [PATCH 2/2] drm/i915: Track ggtt fence reservations under its own mutex

2019-06-11 Thread Chris Wilson
We can reduce the locking for fence registers from the dev->struct_mutex to a local mutex. We could introduce a mutex for the sole purpose of tracking the fence acquisition, except there is a little bit of overlap with the fault tracking, so use the i915_ggtt.mutex as it covers both. Signed-off-by

Re: [Intel-gfx] [RFC 01/14] drm/i915: Make i915_check_and_clear_faults take uncore

2019-06-11 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-06-11 13:05:58) > > On 11/06/2019 09:52, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-06-11 09:35:07) > >> > >> On 10/06/2019 17:26, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2019-06-10 16:54:06) > From: Tvrtko Ursulin > > Continuing the

Re: [Intel-gfx] [REBASED PATCH 1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi

2019-06-11 Thread Ville Syrjälä
On Mon, Jun 10, 2019 at 10:45:14PM +0300, Jani Nikula wrote: > From: Vandita Kulkarni > > Since intel_add_dsi_properties will be used by other > platforms too move it out of platform specific file. > > Signed-off-by: Vandita Kulkarni > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i

Re: [Intel-gfx] [RFC 01/14] drm/i915: Make i915_check_and_clear_faults take uncore

2019-06-11 Thread Tvrtko Ursulin
On 11/06/2019 09:52, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-06-11 09:35:07) On 10/06/2019 17:26, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-06-10 16:54:06) From: Tvrtko Ursulin Continuing the conversion and elimination of implicit dev_priv. Signed-off-by: Tvrtko Ursulin S

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size URL : https://patchwork.freedesktop.org/series/61887/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230 -> Patchwork_13237 =

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Move fence register tracking from i915->mm to ggtt

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move fence register tracking from i915->mm to ggtt URL : https://patchwork.freedesktop.org/series/61891/ State : failure == Summary == Applying: drm/i915: Move fence register tracking from i915->mm to ggtt Using index info to r

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size URL : https://patchwork.freedesktop.org/series/61887/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/guc: Move inte

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size URL : https://patchwork.freedesktop.org/series/61887/ State : warning == Summary == $ dim checkpatch origin/drm-tip 08010f3675e3 drm/i915/guc: Move intel_guc_reserved

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/6] drm/i915: Remove I915_READ8

2019-06-11 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915: Remove I915_READ8 URL : https://patchwork.freedesktop.org/series/61886/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230 -> Patchwork_13236 Summary

  1   2   >