[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/edid: abstract override/firmware EDID retrieval (rev2)

2019-06-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/edid: abstract override/firmware EDID retrieval (rev2) URL : https://patchwork.freedesktop.org/series/61764/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225_full -> Patchwork_13217_full ===

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Deal with machines that expose less than three QGV points

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Deal with machines that expose less than three QGV points URL : https://patchwork.freedesktop.org/series/61713/ State : success == Summary == CI Bug Log - changes from CI_DRM_6206_full -> Patchwork_13193_full ==

[Intel-gfx] ✓ Fi.CI.BAT: success for linux-next: manual merge of the drm-misc tree with the drm tree

2019-06-10 Thread Patchwork
== Series Details == Series: linux-next: manual merge of the drm-misc tree with the drm tree URL : https://patchwork.freedesktop.org/series/61878/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230 -> Patchwork_13233 Summar

[Intel-gfx] ✗ Fi.CI.BAT: failure for Panel rotation patches (rev2)

2019-06-10 Thread Patchwork
== Series Details == Series: Panel rotation patches (rev2) URL : https://patchwork.freedesktop.org/series/61870/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h GEN .version

[Intel-gfx] [PATCH 5/5] drm/mtk: add panel orientation property

2019-06-10 Thread Derek Basehore
This inits the panel orientation property for the mediatek dsi driver if the panel orientation (connector.display_info.panel_orientation) is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN. Signed-off-by: Derek Basehore --- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 1 file changed, 8 insertions(+)

[Intel-gfx] [PATCH 1/5] drm/panel: Add helper for reading DT rotation

2019-06-10 Thread Derek Basehore
This adds a helper function for reading the rotation (panel orientation) from the device tree. Signed-off-by: Derek Basehore --- drivers/gpu/drm/drm_panel.c | 41 + include/drm/drm_panel.h | 7 +++ 2 files changed, 48 insertions(+) diff --git a/drive

[Intel-gfx] [PATCH 4/5] drm/connector: Split out orientation quirk detection

2019-06-10 Thread Derek Basehore
This removes the orientation quirk detection from the code to add an orientation property to a panel. This is used only for legacy x86 systems, yet we'd like to start using this on devicetree systems where quirk detection like this is not needed. Signed-off-by: Derek Basehore --- drivers/gpu/drm

[Intel-gfx] [PATCH 3/5] drm/panel: Add attach/detach callbacks

2019-06-10 Thread Derek Basehore
This adds the attach/detach callbacks. These are for setting up internal state for the connector/panel pair that can't be done at probe (since the connector doesn't exist) and which don't need to be repeatedly done for every get/modes, prepare, or enable callback. Values such as the panel orientati

[Intel-gfx] [PATCH v2 0/5] Panel rotation patches

2019-06-10 Thread Derek Basehore
This adds the plumbing for reading panel rotation from the devicetree and sets up adding a panel property for the panel orientation on Mediatek SoCs when a rotation is present. v2 changes: fixed build errors in i915 Derek Basehore (5): drm/panel: Add helper for reading DT rotation dt-bindings

[Intel-gfx] [PATCH 2/5] dt-bindings: display/panel: Expand rotation documentation

2019-06-10 Thread Derek Basehore
This adds to the rotation documentation to explain how drivers should use the property and gives an example of the property in a devicetree node. Signed-off-by: Derek Basehore --- .../bindings/display/panel/panel.txt | 32 +++ 1 file changed, 32 insertions(+) diff --git

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/perf: fix ICL perf register offsets

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915/perf: fix ICL perf register offsets URL : https://patchwork.freedesktop.org/series/61826/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225_full -> Patchwork_13216_full Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for linux-next: manual merge of the drm-misc tree with the drm tree

2019-06-10 Thread Patchwork
== Series Details == Series: linux-next: manual merge of the drm-misc tree with the drm tree URL : https://patchwork.freedesktop.org/series/61878/ State : warning == Summary == $ dim checkpatch origin/drm-tip e0a1e1173fb0 linux-next: manual merge of the drm-misc tree with the drm tree -:15: ER

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

2019-06-10 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/amd/display/dc/dce/dce_clk_mgr.c between commit: 9b93eb475aa9 ("drm/amd/display: move clk_mgr files to right place") from the drm tree and commit: 4fc4dca8320e ("drm/amd: drop use of drmp.h in os_ty

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

2019-06-10 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c between commit: 899fbde14646 ("drm/amdgpu: replace get_user_pages with HMM mirror helpers") from the drm tree and commit: c366be543c5e ("drm/amd: drop dependencies on drm_os_

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Backlight control via VESA eDP aux interface

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Backlight control via VESA eDP aux interface URL : https://patchwork.freedesktop.org/series/61825/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225_full -> Patchwork_13215_full Summa

Re: [Intel-gfx] [PATCH 5/5] drm/mtk: add panel orientation property

2019-06-10 Thread CK Hu
Hi, Derek: On Mon, 2019-06-10 at 17:22 -0700, Derek Basehore wrote: > This inits the panel orientation property for the mediatek dsi driver > if the panel orientation (connector.display_info.panel_orientation) is > not DRM_MODE_PANEL_ORIENTATION_UNKNOWN. > Looks good to me, Acked-by: CK Hu >

[Intel-gfx] ✗ Fi.CI.BAT: failure for Panel rotation patches

2019-06-10 Thread Patchwork
== Series Details == Series: Panel rotation patches URL : https://patchwork.freedesktop.org/series/61870/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/generated/compile.h AR drivers/gpu/drm/

[Intel-gfx] [PATCH 5/5] drm/mtk: add panel orientation property

2019-06-10 Thread Derek Basehore
This inits the panel orientation property for the mediatek dsi driver if the panel orientation (connector.display_info.panel_orientation) is not DRM_MODE_PANEL_ORIENTATION_UNKNOWN. Signed-off-by: Derek Basehore --- drivers/gpu/drm/mediatek/mtk_dsi.c | 8 1 file changed, 8 insertions(+)

[Intel-gfx] [PATCH 4/5] drm/connector: Split out orientation quirk detection

2019-06-10 Thread Derek Basehore
This removes the orientation quirk detection from the code to add an orientation property to a panel. This is used only for legacy x86 systems, yet we'd like to start using this on device tree systems where quirk detection like this is not needed. Signed-off-by: Derek Basehore --- drivers/gpu/dr

[Intel-gfx] [PATCH 1/5] drm/panel: Add helper for reading DT rotation

2019-06-10 Thread Derek Basehore
This adds a helper function for reading the rotation (panel orientation) from the device tree. Signed-off-by: Derek Basehore --- drivers/gpu/drm/drm_panel.c | 41 + include/drm/drm_panel.h | 7 +++ 2 files changed, 48 insertions(+) diff --git a/drive

[Intel-gfx] [PATCH 3/5] drm/panel: Add attach/detach callbacks

2019-06-10 Thread Derek Basehore
This adds the attach/detach callbacks. These are for setting up internal state for the connector/panel pair that can't be done at probe (since the connector doesn't exist) and which don't need to be repeatedly done for every get/modes, prepare, or enable callback. Values such as the panel orientati

[Intel-gfx] [PATCH 2/5] dt-bindings: display/panel: Expand rotation documentation

2019-06-10 Thread Derek Basehore
This adds to the rotation documentation to explain how drivers should use the property and gives an example of the property in a devicetree node. Signed-off-by: Derek Basehore --- .../bindings/display/panel/panel.txt | 32 +++ 1 file changed, 32 insertions(+) diff --git

[Intel-gfx] [PATCH 0/5] Panel rotation patches

2019-06-10 Thread Derek Basehore
This adds the plumbing for reading panel rotation from the devicetree and sets up adding a panel property for the panel orientation on Mediatek SoCs when a rotation is present. Derek Basehore (5): drm/panel: Add helper for reading DT rotation dt-bindings: display/panel: Expand rotation documen

Re: [Intel-gfx] [PATCH 04/23] drm/i915: Sanitize the terminology used for TypeC port modes

2019-06-10 Thread Lucas De Marchi
On Tue, Jun 04, 2019 at 05:58:07PM +0300, Imre Deak wrote: The TypeC port mode can switch dynamically, to reflect that better call the port's mode as 'mode' rather than 'type'. While at it: - s/TC_PORT_TBT/TC_PORT_TBT_ALT/ and s/TC_PORT_TYPEC/TC_PORT_DP_ALT/. 'TYPEC' is ambiguous, TBT_ALT and D

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add Wa_1409120013:icl,ehl

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Add Wa_1409120013:icl,ehl URL : https://patchwork.freedesktop.org/series/61867/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230 -> Patchwork_13231 Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/fb-helper: Move modesetting code to drm_client (rev9)

2019-06-10 Thread Patchwork
== Series Details == Series: drm/fb-helper: Move modesetting code to drm_client (rev9) URL : https://patchwork.freedesktop.org/series/58597/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225_full -> Patchwork_13211_full Su

Re: [Intel-gfx] [PATCH 03/23] drm/i915: Move the TypeC port handling code to a separate file

2019-06-10 Thread Lucas De Marchi
On Thu, Jun 06, 2019 at 11:42:46AM +0300, Jani Nikula wrote: On Tue, 04 Jun 2019, Imre Deak wrote: Move the TypeC port handling functions to a new file for clarity. While at it: - s/icl_tc_port_connected()/intel_tc_port_connected()/ icl_tc_phy_disconnect(), will be unexported later. - s/int

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [RFC,1/2] drm/i915: move modesetting output/encoder code under display/

2019-06-10 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915: move modesetting output/encoder code under display/ URL : https://patchwork.freedesktop.org/series/61865/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230 -> Patchwork_13230 ==

[Intel-gfx] [PATCH] drm/i915: Add Wa_1409120013:icl,ehl

2019-06-10 Thread Matt Roper
This chicken bit should be set before enabling FBC to avoid screen corruption when the plane size has odd vertical and horizontal dimensions. It is safe to leave the bit set even when FBC is disabled. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/in

[Intel-gfx] ✓ Fi.CI.BAT: success for Use ranges for voltage level lookup

2019-06-10 Thread Patchwork
== Series Details == Series: Use ranges for voltage level lookup URL : https://patchwork.freedesktop.org/series/61864/ State : success == Summary == CI Bug Log - changes from CI_DRM_6230 -> Patchwork_13229 Summary --- **SUCCESS**

[Intel-gfx] [RFC 2/2] drm/i915: move modesetting core code under display/

2019-06-10 Thread Jani Nikula
Now that we have a new subdirectory for display code, continue by moving modesetting core code. display/intel_frontbuffer.h sticks out like a sore thumb, otherwise this is, again, a surprisingly clean operation. Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Ville Syrjälä Signed-of

[Intel-gfx] [RFC 1/2] drm/i915: move modesetting output/encoder code under display/

2019-06-10 Thread Jani Nikula
Add a new subdirectory for display code, and start off by moving modesetting output/encoder code. Judging by the include changes, this is a surprisingly clean operation. Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH v2 3/3] drm/i915/skl: use ranges for voltage level lookup

2019-06-10 Thread Lucas De Marchi
Like was done for ICL, let's convert the voltage level lookup to use frequency ranges rather than individual frequencies. For deciding the voltage, the individual value doesn't really matter. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_cdclk.c | 20 +++- 1 file

[Intel-gfx] [PATCH v2 2/3] drm/i915/cnl: use ranges for voltage level lookup

2019-06-10 Thread Lucas De Marchi
Like was done for ICL, let's convert the voltage level lookup to use frequency ranges rather than individual frequencies. For deciding the voltage, the individual value doesn't really matter. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_cdclk.c | 13 + 1 file changed

[Intel-gfx] [PATCH v2 1/3] drm/i915/icl: use ranges for voltage level lookup

2019-06-10 Thread Lucas De Marchi
Spec shows voltage level 0 as 307.2, 312, or lower and suggests to use range checks. Prepare for having other frequencies in these ranges by not comparing the exact frequency. v2: invert checks by comparing biggest cdclk first (suggested by Ville) Signed-off-by: Lucas De Marchi --- drivers/gpu/

[Intel-gfx] [PATCH v2 0/3] Use ranges for voltage level lookup

2019-06-10 Thread Lucas De Marchi
Version 2 of https://patchwork.freedesktop.org/series/61742/, this time applied to all possible platforms, not only Ice Lake. I also changed the if else chain to use big to small frequency values according to the suggestion from Ville. $ git grep -e "static.*_calc_voltage_level" -- drivers/gpu/dr

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [REBASED,1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi

2019-06-10 Thread Patchwork
== Series Details == Series: series starting with [REBASED,1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi URL : https://patchwork.freedesktop.org/series/61862/ State : success == Summary == CI Bug Log - changes from CI_DRM_6227 -> Patchwork_13228 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [REBASED,1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi

2019-06-10 Thread Patchwork
== Series Details == Series: series starting with [REBASED,1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi URL : https://patchwork.freedesktop.org/series/61862/ State : warning == Summary == $ dim checkpatch origin/drm-tip bfc796027b45 drm/i915: Move intel_add_dsi_properties to inte

Re: [Intel-gfx] [PATCH 27/28] drm/i915: Allow vma binding to occur asynchronously

2019-06-10 Thread Chris Wilson
Quoting Matthew Auld (2019-06-10 18:34:52) > On Mon, 10 Jun 2019 at 08:21, Chris Wilson wrote: > > > > If we let pages be allocated asynchronously, we also then want to push > > the binding process into an asynchronous task. Make it so, utilising the > > recent improvements to fence error tracking

Re: [Intel-gfx] [REBASED PATCH 2/2] drm/i915: Add intel_dsi properties support for icl

2019-06-10 Thread Jani Nikula
This is also by Vandita, I screwed up the authorship while rebasing the patches. I'll fix while applying. BR, Jani. On Mon, 10 Jun 2019, Jani Nikula wrote: > Support dsi properties on icl > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110693 > Signed-off-by: Vandita Kulkarni > Sig

[Intel-gfx] [REBASED PATCH 1/2] drm/i915: Move intel_add_dsi_properties to intel_dsi

2019-06-10 Thread Jani Nikula
From: Vandita Kulkarni Since intel_add_dsi_properties will be used by other platforms too move it out of platform specific file. Signed-off-by: Vandita Kulkarni Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.c | 32 drivers/gpu/drm/i915/intel_dsi.h | 3

[Intel-gfx] [REBASED PATCH 2/2] drm/i915: Add intel_dsi properties support for icl

2019-06-10 Thread Jani Nikula
Support dsi properties on icl Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110693 Signed-off-by: Vandita Kulkarni Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/icl_dsi.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/icl_dsi.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [RFC 14/14] drm/i915: Make GuC GGTT reservation work on ggtt

2019-06-10 Thread Michal Wajdeczko
On Mon, 10 Jun 2019 17:54:19 +0200, Tvrtko Ursulin wrote: From: Tvrtko Ursulin These functions operate on ggtt so make them take that directly as parameter. At the same time move the USES_GUC conditional down to intel_guc_reserve_ggtt_top for symmetry with intel_guc_reserved_gtt_size. v2:

Re: [Intel-gfx] [RFC 13/14] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size

2019-06-10 Thread Michal Wajdeczko
On Mon, 10 Jun 2019 17:54:18 +0200, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Reduces pointer chasing and gets more to the point. Signed-off-by: Tvrtko Ursulin Suggested-by: Michal Wajdeczko Cc: Michal Wajdeczko Reviewed-by: Michal Wajdeczko with small nit below --- drivers/gpu/

Re: [Intel-gfx] [PATCH 3/9] drm/i915/dmc: add support for package_header with version 2

2019-06-10 Thread Srivatsa, Anusha
>-Original Message- >From: De Marchi, Lucas >Sent: Friday, June 7, 2019 2:12 AM >To: intel-gfx@lists.freedesktop.org >Cc: Vivi, Rodrigo ; Srivatsa, Anusha >; De Marchi, Lucas >Subject: [PATCH 3/9] drm/i915/dmc: add support for package_header with >version 2 > >The only meaninful change i

Re: [Intel-gfx] [PATCH 2/9] drm/i915/dmc: extract fw_info and table walk from intel_package_header

2019-06-10 Thread Srivatsa, Anusha
>-Original Message- >From: De Marchi, Lucas >Sent: Friday, June 7, 2019 2:12 AM >To: intel-gfx@lists.freedesktop.org >Cc: Vivi, Rodrigo ; Srivatsa, Anusha >; De Marchi, Lucas >Subject: [PATCH 2/9] drm/i915/dmc: extract fw_info and table walk from >intel_package_header > >Move fw_info out

Re: [Intel-gfx] [RFC 08/14] drm/i915: Store backpointer to intel_gt in the engine

2019-06-10 Thread Daniele Ceraolo Spurio
On 6/10/19 9:16 AM, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-06-10 16:54:13) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_types.h b/drivers/gpu/drm/i915/gt/intel_engine_types.h index 01223864237a..343c4459e8a3 100644 --- a/drivers/gpu/drm/i915/gt/intel_engine_types.h +++ b/driver

[Intel-gfx] ✓ Fi.CI.BAT: success for Implicit dev_priv removal (rev2)

2019-06-10 Thread Patchwork
== Series Details == Series: Implicit dev_priv removal (rev2) URL : https://patchwork.freedesktop.org/series/61705/ State : success == Summary == CI Bug Log - changes from CI_DRM_6227 -> Patchwork_13227 Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Promote i915->mm.obj_lock to be irqsafe (rev3)

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Promote i915->mm.obj_lock to be irqsafe (rev3) URL : https://patchwork.freedesktop.org/series/61832/ State : success == Summary == CI Bug Log - changes from CI_DRM_6227 -> Patchwork_13226 Summary -

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915/icl: More workaround for port F detection due to broken VBTs"

2019-06-10 Thread Patchwork
== Series Details == Series: Revert "drm/i915/icl: More workaround for port F detection due to broken VBTs" URL : https://patchwork.freedesktop.org/series/61846/ State : success == Summary == CI Bug Log - changes from CI_DRM_6227 -> Patchwork_13225

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Implicit dev_priv removal (rev2)

2019-06-10 Thread Patchwork
== Series Details == Series: Implicit dev_priv removal (rev2) URL : https://patchwork.freedesktop.org/series/61705/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Make i915_check_and_clear_faults take uncore Okay! Commit: drm/i915: Convert i

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Implicit dev_priv removal (rev2)

2019-06-10 Thread Patchwork
== Series Details == Series: Implicit dev_priv removal (rev2) URL : https://patchwork.freedesktop.org/series/61705/ State : warning == Summary == $ dim checkpatch origin/drm-tip 885d95410d8d drm/i915: Make i915_check_and_clear_faults take uncore 4594ba392e2c drm/i915: Convert intel_vgt_(de)bal

Re: [Intel-gfx] [PATCH 27/28] drm/i915: Allow vma binding to occur asynchronously

2019-06-10 Thread Matthew Auld
On Mon, 10 Jun 2019 at 08:21, Chris Wilson wrote: > > If we let pages be allocated asynchronously, we also then want to push > the binding process into an asynchronous task. Make it so, utilising the > recent improvements to fence error tracking and struct_mutex reduction. > > Signed-off-by: Chris

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Promote i915->mm.obj_lock to be irqsafe (rev3)

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Promote i915->mm.obj_lock to be irqsafe (rev3) URL : https://patchwork.freedesktop.org/series/61832/ State : warning == Summary == $ dim checkpatch origin/drm-tip 4f61077ee587 drm/i915: Promote i915->mm.obj_lock to be irqsafe -:135: WARNING:UNSPECIFIED_IN

Re: [Intel-gfx] [v7][PATCH 03/12] drm/i915: Add func to compare hw/sw gamma lut

2019-06-10 Thread Ville Syrjälä
On Mon, Jun 10, 2019 at 04:24:54PM +0530, Sharma, Swati2 wrote: > On 31-May-19 8:58 PM, Ville Syrjälä wrote: > > > On Wed, May 29, 2019 at 03:20:53PM +0530, Swati Sharma wrote: > >> v3: -Rebase > >> v4: -Renamed intel_compare_color_lut() to intel_color_lut_equal() [Jani] > >> -Added the defau

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Do not touch the PCH SSC reference if a PLL is using it (rev2)

2019-06-10 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Do not touch the PCH SSC reference if a PLL is using it (rev2) URL : https://patchwork.freedesktop.org/series/61608/ State : success == Summary == CI Bug Log - changes from CI_DRM_6227 -> Patchwork_13224 ===

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Revert "drm/i915/icl: More workaround for port F detection due to broken VBTs"

2019-06-10 Thread Patchwork
== Series Details == Series: Revert "drm/i915/icl: More workaround for port F detection due to broken VBTs" URL : https://patchwork.freedesktop.org/series/61846/ State : warning == Summary == $ dim checkpatch origin/drm-tip bc1d12322f5f Revert "drm/i915/icl: More workaround for port F detecti

Re: [Intel-gfx] [RFC 01/14] drm/i915: Make i915_check_and_clear_faults take uncore

2019-06-10 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-06-10 16:54:06) > From: Tvrtko Ursulin > > Continuing the conversion and elimination of implicit dev_priv. > > Signed-off-by: Tvrtko Ursulin > Suggested-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- > drivers/gpu/drm/i915/gt/intel_res

Re: [Intel-gfx] [RFC 04/14] drm/i915: Add a couple intel_gt helpers

2019-06-10 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-06-10 16:54:09) > From: Tvrtko Ursulin > > Two trivial helpers to convert from intel_gt to i915 and uncore which will > be needed by the following patches. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/gt/intel_gt.h | 26 ++

Re: [Intel-gfx] [RFC 08/14] drm/i915: Store backpointer to intel_gt in the engine

2019-06-10 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-06-10 16:54:13) > diff --git a/drivers/gpu/drm/i915/gt/intel_engine_types.h > b/drivers/gpu/drm/i915/gt/intel_engine_types.h > index 01223864237a..343c4459e8a3 100644 > --- a/drivers/gpu/drm/i915/gt/intel_engine_types.h > +++ b/drivers/gpu/drm/i915/gt/intel_engine_type

[Intel-gfx] [RFC 11/14] drm/i915: Consolidate some open coded mmio rmw

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Replace some gen6/7 open coded rmw with intel_uncore_rmw. Signed-off-by: Tvrtko Ursulin Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_gem_gtt.c | 41 + 1 file changed, 18 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [RFC 14/14] drm/i915: Make GuC GGTT reservation work on ggtt

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin These functions operate on ggtt so make them take that directly as parameter. At the same time move the USES_GUC conditional down to intel_guc_reserve_ggtt_top for symmetry with intel_guc_reserved_gtt_size. v2: * Rename and move functions to be static in i915_gem_gtt.c (Mi

[Intel-gfx] [RFC 03/14] drm/i915: Introduce struct intel_gt as replacement for anonymous i915->gt

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We have long been slighlty annoyed by the anonymous i915->gt. Promote it to a separate structure and give it its own header. This is a first step towards cleaning up the separation between i915 and gt. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gt_ty

[Intel-gfx] [RFC 10/14] drm/i915: Convert i915_ppgtt_init_hw to intel_gt

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More removal of implicit dev_priv from using old mmio accessors. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 102 ++-- drivers/gpu/drm/i915/i915_gem_gtt.h | 3 +- 3 files ch

[Intel-gfx] [RFC 07/14] drm/i915: Convert gt workarounds to intel_gt

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More conversion of i915_gem_init_hw to uncore. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 11 ++- drivers/gpu/drm/i915/gt/intel_workarounds.h | 6 +++--- drivers/gpu/drm/i915/i915_gem.c | 4 ++-- 3 files changed, 1

[Intel-gfx] [RFC 08/14] drm/i915: Store backpointer to intel_gt in the engine

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It will come useful in the next patch. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 1 + drivers/gpu/drm/i915/gt/intel_engine_types.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/dri

[Intel-gfx] [RFC 09/14] drm/i915: Convert intel_mocs_init_l3cc_table to intel_gt

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More removal of implicit dev_priv from using old mmio accessors. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_mocs.c | 52 +--- drivers/gpu/drm/i915/gt/intel_mocs.h | 3 +- drivers/gpu/drm/i915/i915_gem.c | 2 +- 3 files ch

[Intel-gfx] [RFC 06/14] drm/i915: Convert init_unused_rings to intel_gt

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More removal of implicit dev_priv from using old mmio accessors. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c | 42 ++--- 1 file changed, 23 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/driv

[Intel-gfx] [RFC 13/14] drm/i915/guc: Move intel_guc_reserved_gtt_size to intel_wopcm_guc_size

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Reduces pointer chasing and gets more to the point. Signed-off-by: Tvrtko Ursulin Suggested-by: Michal Wajdeczko Cc: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +- drivers/gpu/drm/i915/intel_guc.c| 17 - drivers/gpu/drm/i915/intel_g

[Intel-gfx] [RFC 01/14] drm/i915: Make i915_check_and_clear_faults take uncore

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Continuing the conversion and elimination of implicit dev_priv. Signed-off-by: Tvrtko Ursulin Suggested-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- drivers/gpu/drm/i915/gt/intel_reset.c | 28 --- drivers/gpu/drm/i915/gt/

[Intel-gfx] [RFC 02/14] drm/i915: Convert intel_vgt_(de)balloon to uncore

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More removal of implicit dev_priv from using old mmio accessors. Furthermore these calls really operate on ggtt so it logically makes sense if they take it as parameter. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++-- drivers/gpu/drm/i915/

[Intel-gfx] [RFC 12/14] drm/i915: Convert i915_gem_init_hw to intel_gt

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin More removal of implicit dev_priv from using old mmio accessors. Actually the top level function remains but is split into a part which writes to i915 and part which operates on uncore to initialize the hardware. GuC and engines are the only odd ones out remaining. Signed-

[Intel-gfx] [RFC 05/14] drm/i915: Convert i915_gem_init_swizzling to intel_gt

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Start using the newly introduced struct intel_gt to fuse together correct logical init flow with uncore for more removal of implicit dev_priv in mmio access. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/gt/intel_gt.c | 4

[Intel-gfx] [RFC v2 00/14] Implicit dev_priv removal

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Mostly patches reworking the code and GEM init paths to remove some implicit dev_priv dependencies (I915_READ/I915_WRITE), plus some small tweaks to tidy GEM init paths to use more logical input parameters (enabled by the conversion to uncore mmio accessors). v2: * Introduc

[Intel-gfx] [RFC 04/14] drm/i915: Add a couple intel_gt helpers

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Two trivial helpers to convert from intel_gt to i915 and uncore which will be needed by the following patches. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_gt.h | 26 ++ 1 file changed, 26 insertions(+) create mode 100644 drivers

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hangcheck: Look at instdone for all engines

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915/hangcheck: Look at instdone for all engines URL : https://patchwork.freedesktop.org/series/61843/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225 -> Patchwork_13223 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/perf: fix ICL perf register offsets

2019-06-10 Thread Kenneth Graunke
On Monday, June 10, 2019 1:19:14 AM PDT Lionel Landwerlin wrote: > We got the wrong offsets (could they have changed?). New values were > computed off an error state by looking up the register offset in the > context image as written by the HW. > > Signed-off-by: Lionel Landwerlin > Fixes: 1de401

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make read_subslice_reg take engine

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Make read_subslice_reg take engine URL : https://patchwork.freedesktop.org/series/61841/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225 -> Patchwork_13222 Summary --- **SUCC

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/6] drm/i915: Eliminate unused mmio accessors

2019-06-10 Thread Patchwork
== Series Details == Series: series starting with [CI,1/6] drm/i915: Eliminate unused mmio accessors URL : https://patchwork.freedesktop.org/series/61837/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225 -> Patchwork_13221

Re: [Intel-gfx] [PATCH] Revert "drm/i915/icl: More workaround for port F detection due to broken VBTs"

2019-06-10 Thread Chris Wilson
Quoting Imre Deak (2019-06-10 15:40:13) > On Mon, Jun 10, 2019 at 02:34:13PM +0100, Chris Wilson wrote: > > This reverts commit 1aa3750885fbcece5a0c9e6bbcd014ac526cea41. > > > > References: https://bugs.freedesktop.org/show_bug.cgi?id=110882 > > How is it related? None of the above bug reports ar

[Intel-gfx] [CI] drm/i915: Promote i915->mm.obj_lock to be irqsafe

2019-06-10 Thread Chris Wilson
The intent is to be able to update the mm.lists from inside an irqsoff section (e.g. from a softirq rcu workqueue), ergo we need to make the i915->mm.obj_lock irqsafe. v2: can_discard_pages() ensures we are shrinkable v3: Beware shadowing of 'flags' Fixes: 3b4fa9640ccd ("drm/i915: Track the purge

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ehl: Add support for DPLL4 (v5) (rev2)

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Add support for DPLL4 (v5) (rev2) URL : https://patchwork.freedesktop.org/series/61684/ State : success == Summary == CI Bug Log - changes from CI_DRM_6222_full -> Patchwork_13210_full Summary

Re: [Intel-gfx] [PATCH] Revert "drm/i915/icl: More workaround for port F detection due to broken VBTs"

2019-06-10 Thread Imre Deak
On Mon, Jun 10, 2019 at 02:34:13PM +0100, Chris Wilson wrote: > This reverts commit 1aa3750885fbcece5a0c9e6bbcd014ac526cea41. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=110882 How is it related? None of the above bug reports are about a 0x8A5D box. 0x8A56 is one and 0x8A5A is th

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Promote i915->mm.obj_lock to be irqsafe (rev2)

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Promote i915->mm.obj_lock to be irqsafe (rev2) URL : https://patchwork.freedesktop.org/series/61832/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6225 -> Patchwork_13220 Summary -

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Allow interrupts when taking the timeline->mutex

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Allow interrupts when taking the timeline->mutex URL : https://patchwork.freedesktop.org/series/61833/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225 -> Patchwork_13219 Summary ---

[Intel-gfx] [PATCH] Revert "drm/i915/icl: More workaround for port F detection due to broken VBTs"

2019-06-10 Thread Chris Wilson
This reverts commit 1aa3750885fbcece5a0c9e6bbcd014ac526cea41. References: https://bugs.freedesktop.org/show_bug.cgi?id=110882 --- include/drm/i915_pciids.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index 6d60ea68c

[Intel-gfx] [PATCH v2 2/5] drm/i915: Rename HSW/BDW PLL bits

2019-06-10 Thread Ville Syrjala
From: Ville Syrjälä Give the PLL control register bits better names on HSW/BDW. v2: Fix the copy paste fails in SPLL_REF defines (Maarten) Cc: Maarten Lankhorst Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_reg.h | 32 +-- drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [RFC] drm/i915/hangcheck: Look at instdone for all engines

2019-06-10 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-06-10 14:16:32) > > On 10/06/2019 14:05, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-06-10 14:01:10) > >> From: Tvrtko Ursulin > >> > >> It seems intel_engine_get_instdone is able to get instdone for all engines > >> but intel_hangcheck.c/subunits_stuck decid

Re: [Intel-gfx] [RFC] drm/i915/hangcheck: Look at instdone for all engines

2019-06-10 Thread Tvrtko Ursulin
On 10/06/2019 14:05, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-06-10 14:01:10) From: Tvrtko Ursulin It seems intel_engine_get_instdone is able to get instdone for all engines but intel_hangcheck.c/subunits_stuck decides to ignore it for non render. We can just drop the check in subuni

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix GVT balloon fail path handling

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Fix GVT balloon fail path handling URL : https://patchwork.freedesktop.org/series/61830/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225 -> Patchwork_13218 Summary --- **SUCC

Re: [Intel-gfx] [RFC] drm/i915/hangcheck: Look at instdone for all engines

2019-06-10 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-06-10 14:01:10) > From: Tvrtko Ursulin > > It seems intel_engine_get_instdone is able to get instdone for all engines > but intel_hangcheck.c/subunits_stuck decides to ignore it for non render. > > We can just drop the check in subunits_stuck since the checks on > un

[Intel-gfx] [PATCH i-g-t v2] i915/gem_mmap_gtt: Disregard forked subtests on ICL for reasons

2019-06-10 Thread Chris Wilson
Nothing to see here, please move along. References: https://bugs.freedesktop.org/show_bug.cgi?id=110882 Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Martin Peres --- tests/i915/gem_mmap_gtt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/i915/gem_mmap_gtt.c b/tests/i915/gem

[Intel-gfx] [RFC] drm/i915/hangcheck: Look at instdone for all engines

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It seems intel_engine_get_instdone is able to get instdone for all engines but intel_hangcheck.c/subunits_stuck decides to ignore it for non render. We can just drop the check in subunits_stuck since the checks on unavailable fields will always return stuck, which when bitwi

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_mmap_gtt: Disregard forked subtests on ICL for reasons

2019-06-10 Thread Martin Peres
On 10/06/2019 15:55, Chris Wilson wrote: > Nothing to see here, please move along. > > XXX: Update with better bugzilla https://bugs.freedesktop.org/show_bug.cgi?id=110882 > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107713#c125 > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala

[Intel-gfx] [PATCH v2] drm/i915: Make read_subslice_reg take engine

2019-06-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin The function operates on the render engine so make the input reflect it. v2: * Pass engine to read_subslice_reg. (Chris) * Drop inline from read_subslice_reg. Signed-off-by: Tvrtko Ursulin Suggested-by: Rodrigo Vivi Cc: Chris Wilson Reviewed-by: Chris Wilson --- driv

[Intel-gfx] [PATCH i-g-t] i915/gem_mmap_gtt: Disregard forked subtests on ICL for reasons

2019-06-10 Thread Chris Wilson
Nothing to see here, please move along. XXX: Update with better bugzilla Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107713#c125 Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Martin Peres --- tests/i915/gem_mmap_gtt.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/edid: abstract override/firmware EDID retrieval (rev2)

2019-06-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/edid: abstract override/firmware EDID retrieval (rev2) URL : https://patchwork.freedesktop.org/series/61764/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225 -> Patchwork_13217 =

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: fix ICL perf register offsets

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915/perf: fix ICL perf register offsets URL : https://patchwork.freedesktop.org/series/61826/ State : success == Summary == CI Bug Log - changes from CI_DRM_6225 -> Patchwork_13216 Summary --- **SUCC

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix TypeC port mode switching (rev2)

2019-06-10 Thread Patchwork
== Series Details == Series: drm/i915: Fix TypeC port mode switching (rev2) URL : https://patchwork.freedesktop.org/series/61590/ State : success == Summary == CI Bug Log - changes from CI_DRM_6221_full -> Patchwork_13209_full Summary -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/edid: abstract override/firmware EDID retrieval (rev2)

2019-06-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/edid: abstract override/firmware EDID retrieval (rev2) URL : https://patchwork.freedesktop.org/series/61764/ State : warning == Summary == $ dim checkpatch origin/drm-tip d5896a186b31 drm/edid: abstract override/firmware EDID retriev

  1   2   >