[Intel-gfx] ✓ Fi.CI.IGT: success for Document fixes for DRM UAPI and HDR

2019-05-29 Thread Patchwork
== Series Details == Series: Document fixes for DRM UAPI and HDR URL : https://patchwork.freedesktop.org/series/61349/ State : success == Summary == CI Bug Log - changes from CI_DRM_6165_full -> Patchwork_13134_full Summary --- **SUC

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv

2019-05-29 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv URL : https://patchwork.freedesktop.org/series/61345/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6165_full -> Patchwork_13133_full ===

Re: [Intel-gfx] [PULL] gvt-fixes

2019-05-29 Thread Zhenyu Wang
On 2019.05.29 15:07:09 +0300, Joonas Lahtinen wrote: > Quoting Zhenyu Wang (2019-05-29 12:06:08) > > > > Hi, > > > > Here's more gvt fixes for 5.2. This includes fixes for recently > > seen arbitrary DMA map fault with sane gtt entry initialization, > > and several enforcement fixes for e.g ggtt

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gtt: Avoid overflowing the WC stash

2019-05-29 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Avoid overflowing the WC stash URL : https://patchwork.freedesktop.org/series/61301/ State : success == Summary == CI Bug Log - changes from CI_DRM_6163_full -> Patchwork_13125_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl

2019-05-29 Thread Patchwork
== Series Details == Series: drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl URL : https://patchwork.freedesktop.org/series/61299/ State : success == Summary == CI Bug Log - changes from CI_DRM_6163_full -> Patchwork_13124_full =

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsc: Add Per connector debugfs node for DSC BPP enable

2019-05-29 Thread Patchwork
== Series Details == Series: drm/i915/dsc: Add Per connector debugfs node for DSC BPP enable URL : https://patchwork.freedesktop.org/series/61357/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6166 -> Patchwork_13135 Summar

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] lib/tests: fix conflicting args test

2019-05-29 Thread Patchwork
== Series Details == Series: series starting with [1/5] lib/tests: fix conflicting args test URL : https://patchwork.freedesktop.org/series/61355/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6166 -> IGTPW_3078 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsc: Add Per connector debugfs node for DSC BPP enable

2019-05-29 Thread Patchwork
== Series Details == Series: drm/i915/dsc: Add Per connector debugfs node for DSC BPP enable URL : https://patchwork.freedesktop.org/series/61357/ State : warning == Summary == $ dim checkpatch origin/drm-tip 56bc2ed24c4c drm/i915/dsc: Add Per connector debugfs node for DSC BPP enable -:105: C

Re: [Intel-gfx] [PATCH i-g-t 4/5] testdisplay: use first available option values

2019-05-29 Thread Antonio Argenziano
On 29/05/19 16:27, Lucas De Marchi wrote: Now that core options are set to 500 and above, start from the lowest values without causing problems with conflicts. This also rename the constants to follow the names from the core. Signed-off-by: Lucas De Marchi Acked-by: Antonio Argenziano --

Re: [Intel-gfx] [PATCH i-g-t 2/5] lib/igt_core: reserve long options for individual tests

2019-05-29 Thread Antonio Argenziano
On 29/05/19 16:27, Lucas De Marchi wrote: Start the core optiosn from 500 so the individual tests can have their own options starting from 0. This makes it easier to set the long options without conflicting. 500 is just a magic number, higher than any ascii char that could be used in the indiv

[Intel-gfx] [PATCH] drm/i915/dsc: Add Per connector debugfs node for DSC BPP enable

2019-05-29 Thread Anusha
From: Anusha Srivatsa DSC can be supported per DP connector. This patch creates a per connector debugfs node to expose the Input and Compressed BPP. The same node can be used from userspace to force DSC to a certain BPP. force_dsc_bpp is written through this debugfs node to force DSC BPP to all

[Intel-gfx] [PATCH i-g-t 1/5] lib/tests: fix conflicting args test

2019-05-29 Thread Lucas De Marchi
We want to check if the long option conflicts with one from the core. The check for conflicting short option already exists just above. Signed-off-by: Lucas De Marchi --- lib/tests/igt_conflicting_args.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/tests/igt_conflictin

[Intel-gfx] [PATCH i-g-t 3/5] lib/igt_core: 0 is a valid val for long options

2019-05-29 Thread Lucas De Marchi
This is usually used by long options when working with enum to set long option values. So replace the strchr() with a memchr() to take that into account. Signed-off-by: Lucas De Marchi --- lib/igt_core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/igt_core.c b/li

[Intel-gfx] [PATCH i-g-t 5/5] lib/igt_core: add -h to usage

2019-05-29 Thread Lucas De Marchi
We also accept the short option -h. Signed-off-by: Lucas De Marchi --- lib/igt_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index a0b7e581..6b9f0425 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -558,7 +558,7 @@ static void prin

[Intel-gfx] [PATCH i-g-t 2/5] lib/igt_core: reserve long options for individual tests

2019-05-29 Thread Lucas De Marchi
Start the core optiosn from 500 so the individual tests can have their own options starting from 0. This makes it easier to set the long options without conflicting. 500 is just a magic number, higher than any ascii char that could be used in the individual test. While at it, fix the coding style

[Intel-gfx] [PATCH i-g-t 4/5] testdisplay: use first available option values

2019-05-29 Thread Lucas De Marchi
Now that core options are set to 500 and above, start from the lowest values without causing problems with conflicts. This also rename the constants to follow the names from the core. Signed-off-by: Lucas De Marchi --- tests/testdisplay.c | 14 -- 1 file changed, 8 insertions(+), 6 d

[Intel-gfx] [PULL] drm-misc-fixes

2019-05-29 Thread Sean Paul
Hi Da.*, One line pull-request, one-line summary. Please pull :) drm-misc-fixes-2019-05-29: qxl: Drop WARN when u/s tries to mmap a prime buffer (Gerd) Cc: Gerd Hoffmann Cheers, Sean The following changes since commit f3617b449d0bcf3b5d80a97f51498dcf7463cf7e: drm/panfrost: Select devfreq

[Intel-gfx] [PATCH i-g-t] i915/gem_workarounds: Mix and match SRM with mmio reads

2019-05-29 Thread Chris Wilson
On apl, mmio reads fail, reading 0. On cml, SRM reads fail, reading 0. Combine both approaches, starting with SRM and fixing in the blanks with mmio reads. Signed-off-by: Chris Wilson Cc: Matthew Auld Cc: Mika Kuoppala --- tests/i915/gem_workarounds.c | 70

[Intel-gfx] ✓ Fi.CI.BAT: success for Document fixes for DRM UAPI and HDR

2019-05-29 Thread Patchwork
== Series Details == Series: Document fixes for DRM UAPI and HDR URL : https://patchwork.freedesktop.org/series/61349/ State : success == Summary == CI Bug Log - changes from CI_DRM_6165 -> Patchwork_13134 Summary --- **SUCCESS**

[Intel-gfx] [PATCH 4/4] video/hdmi: Dropped static functions from kernel doc

2019-05-29 Thread Uma Shankar
Dropped static functions from kernel documentation. Suggested-by: Daniel Vetter Signed-off-by: Uma Shankar --- drivers/video/hdmi.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/video/hdmi.c b/drivers/video/hdmi.c index b99ba01..7

[Intel-gfx] [PATCH 3/4] drm: Fixed doc warnings in drm uapi header

2019-05-29 Thread Uma Shankar
Fixed doc warnings in drm uapi header. All the UAPI structures are now documented in kernel doc. Signed-off-by: Uma Shankar --- include/uapi/drm/drm_mode.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/include/uapi/drm/drm_mode.h b/include/uapi/drm/drm_mode.h index

[Intel-gfx] [PATCH 2/4] drm: Fix docbook warnings in hdr metadata helper structures

2019-05-29 Thread Uma Shankar
Fixes the following warnings: ./include/drm/drm_mode_config.h:841: warning: Incorrect use of kernel-doc format: * hdr_output_metadata_property: Connector property containing hdr ./include/drm/drm_mode_config.h:918: warning: Function parameter or member 'hdr_output_metadata_property' not d

[Intel-gfx] [PATCH 1/4] drm: Drop a redundant unused variable

2019-05-29 Thread Uma Shankar
Drop a redundant and unused variable "hdr_output_metadata" from drm_connector. Suggested-by: Daniel Vetter Signed-off-by: Uma Shankar --- include/drm/drm_connector.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/drm/drm_connector.h b/include/drm/drm_connector.h index f8f4003..547

[Intel-gfx] [PATCH 0/4] Document fixes for DRM UAPI and HDR

2019-05-29 Thread Uma Shankar
This series adds DRM UAPI header structure documentation to kernel docs. Fixes issues with existing structure documentation in drm uapi header. This also fixes warnings in HDR doc and addresses suggestions from Daniel Vetter. Also dropped static function documentation in hdmi core. Uma Shankar (

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv

2019-05-29 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv URL : https://patchwork.freedesktop.org/series/61345/ State : success == Summary == CI Bug Log - changes from CI_DRM_6165 -> Patchwork_13133 =

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv

2019-05-29 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv URL : https://patchwork.freedesktop.org/series/61345/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Add windowing for pri

Re: [Intel-gfx] [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer

2019-05-29 Thread Shankar, Uma
>> >-Original Message- >> >From: Daniel Vetter [mailto:dan...@ffwll.ch] >> >Sent: Wednesday, May 29, 2019 8:33 PM >> >To: Shankar, Uma >> >Cc: intel-gfx ; dri-devel > >de...@lists.freedesktop.org>; Daniele Castagna >> >; jo...@kwiboo.se; Sean Paul >> >; Sharma, Shashank >> >; Syrjala, Vi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv

2019-05-29 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv URL : https://patchwork.freedesktop.org/series/61345/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5682a7985cac drm/i915: Add windowing for primary planes on

Re: [Intel-gfx] [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer

2019-05-29 Thread Daniel Vetter
On Wed, May 29, 2019 at 7:29 PM Shankar, Uma wrote: > > > > >-Original Message- > >From: Daniel Vetter [mailto:dan...@ffwll.ch] > >Sent: Wednesday, May 29, 2019 8:33 PM > >To: Shankar, Uma > >Cc: intel-gfx ; dri-devel >de...@lists.freedesktop.org>; Daniele Castagna ; > >jo...@kwiboo.se;

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix uninitialized variable 'subslice_mask'

2019-05-29 Thread Patchwork
== Series Details == Series: drm/i915: fix uninitialized variable 'subslice_mask' URL : https://patchwork.freedesktop.org/series/61340/ State : failure == Summary == Applying: drm/i915: fix uninitialized variable 'subslice_mask' Using index info to reconstruct a base tree... M drivers/gp

Re: [Intel-gfx] [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer

2019-05-29 Thread Shankar, Uma
>-Original Message- >From: Daniel Vetter [mailto:dan...@ffwll.ch] >Sent: Wednesday, May 29, 2019 8:33 PM >To: Shankar, Uma >Cc: intel-gfx ; dri-devel de...@lists.freedesktop.org>; Daniele Castagna ; >jo...@kwiboo.se; Sean Paul ; Sharma, Shashank >; Syrjala, Ville >Subject: Re: [Intel-gf

Re: [Intel-gfx] [PATCH] drm: Fix docbook warnings in hdr metadata helper structures

2019-05-29 Thread Shankar, Uma
>-Original Message- >From: Daniel Vetter [mailto:dan...@ffwll.ch] >Sent: Wednesday, May 29, 2019 8:31 PM >To: Shankar, Uma >Cc: intel-gfx ; dri-devel de...@lists.freedesktop.org>; Sharma, Shashank ; >Ville Syrjälä ; Maarten Lankhorst >; Maxime Ripard >; Sean Paul ; David Airlie >; Bartlo

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: adding state checker for gamma lut values (rev12)

2019-05-29 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev12) URL : https://patchwork.freedesktop.org/series/58039/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6164 -> Patchwork_13131 Summary --

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Fix docbook warnings in hdr metadata helper structures

2019-05-29 Thread Patchwork
== Series Details == Series: drm: Fix docbook warnings in hdr metadata helper structures URL : https://patchwork.freedesktop.org/series/61334/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6164 -> Patchwork_13129 Summary --

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: adding state checker for gamma lut values (rev12)

2019-05-29 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev12) URL : https://patchwork.freedesktop.org/series/58039/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Introduce vfunc read_luts() to create hw lut Okay!

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: adding state checker for gamma lut values (rev12)

2019-05-29 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev12) URL : https://patchwork.freedesktop.org/series/58039/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1cfa0479b4b6 drm/i915: Introduce vfunc read_luts() to create hw lut 22a23431817f drm/i915

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix uninitialized variable 'mask'

2019-05-29 Thread Patchwork
== Series Details == Series: drm/i915: fix uninitialized variable 'mask' URL : https://patchwork.freedesktop.org/series/61335/ State : failure == Summary == Applying: drm/i915: fix uninitialized variable 'mask' Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/gt/inte

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v6,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-29 Thread Patchwork
== Series Details == Series: series starting with [v6,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range URL : https://patchwork.freedesktop.org/series/61323/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6163 -> Patchwork_13128 ===

[Intel-gfx] [PATCH 07/10] drm/i915: Add support for half float framebuffers for skl+

2019-05-29 Thread Ville Syrjala
From: Ville Syrjälä skl+ supports fp16 pixel formats on all universal planes. Add the necessary bits to expose that capability. The main different to icl is that we can't scale fp16, so need to add the relevant checks. v2: Rebase on top of icl fp16 Split skl+ bits into a separate patch Sign

[Intel-gfx] [PATCH 05/10] drm/i915: Cosmetic fix for skl+ plane switch statement

2019-05-29 Thread Ville Syrjala
From: Ville Syrjälä One of the switch cases has the byte order vs. format bits reversed to all the other cases. Appease the ocd and reorder them. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

[Intel-gfx] [PATCH 09/10] drm/i915: Add support for half float framebuffers for ivb+ sprites

2019-05-29 Thread Ville Syrjala
From: Ville Syrjälä ivb+ supports fp16 pixel formats on the sprite planes planes. Expose that capability. On ivb/hsw fp16 scanout is slightly busted. The output from the plane will have 1/4 the expected value. For the sprite plane we can fix that up with the plane gamma unit. This was fixed on b

[Intel-gfx] [PATCH 08/10] drm/i915: Add support for half float framebuffers for gen4+ primary planes

2019-05-29 Thread Ville Syrjala
From: Ville Syrjälä gen4+ supports fp16 pixel formats on the primary planes. Add the relevant code. On ivb fp16 scanout is slightly busted. The output from the plane will have 1/4 the expected value. For the primary plane we would have to use the pipe gamma or pipe csc to correct that which woul

[Intel-gfx] [PATCH 10/10] drm/i915: Add support for half float framebuffers on snb sprites

2019-05-29 Thread Ville Syrjala
From: Ville Syrjälä snb supports fp16 pixel formats on the sprite planes. Expose that capability. Nothing special needs to be done, it just works. v2: Rebase on top of icl fp16 Split snb+ sprite bits into a separate patch Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_sprite.

[Intel-gfx] [PATCH 06/10] drm/i915: Clean up skl vs. icl plane formats

2019-05-29 Thread Ville Syrjala
From: Ville Syrjälä Split the format lists for different planes on skl/icl more cleanly. On skl+ we have just two types of planes: those can do planar and those that can't. On icl we have three types of planes: hdr planes, sdr planes that can do planar, and sdr planes that can't do planar. Thos

[Intel-gfx] [PATCH 04/10] drm/i915: Deal with cpp==8 for g4x watermarks

2019-05-29 Thread Ville Syrjala
From: Ville Syrjälä Docs tell us that on g4x we have to compute the SR watermarks using 4 bytes per pixel. I'm going to assume that only applies to 1 and 2 byte per pixel formats, and not 8 byte per pixel formats. That seems like a recipe for an insufficient watermark which could lead to underrun

[Intel-gfx] [PATCH 03/10] drm/i915: Program plane gamma ramps

2019-05-29 Thread Ville Syrjala
From: Ville Syrjälä All sprite planes have a progammable gamma ramp. Set it up with a linear ramp on all platforms. This actually matches the reset value but soon we'll want to reprogram this ramp on some machines, so let's just set it up across the board. Note that on pre-IVB the hardware bypa

[Intel-gfx] [PATCH 02/10] drm/i915: Disable sprite gamma on ivb-bdw

2019-05-29 Thread Ville Syrjala
From: Ville Syrjälä We don't currently have any use for the sprite gamma on ivb-bdw. Let's disable it. We already do that on skl+. On pre-ivb there is no way to disable the sprite gamma, and it only affects YCbCr pixel formats, whereas on ivb+ it also affects RGB formats. Signed-off-by: Ville S

[Intel-gfx] [PATCH 01/10] drm/i915: Add windowing for primary planes on gen2/3 and chv

2019-05-29 Thread Ville Syrjala
From: Ville Syrjälä Plane B and C (note that we don't actually expose plane C currently) on gen2/3 have a window generator, as does the primary plane on CHV pipe B. So let's allow positioning of these planes freely within the pipe source area. Plane A on gen2/3 seems to have some kind of partial

Re: [Intel-gfx] [CI 0/5] Refactor to expand subslice mask

2019-05-29 Thread Summers, Stuart
On Wed, 2019-05-29 at 07:21 -0700, Daniele Ceraolo Spurio wrote: > > On 5/28/19 11:48 PM, Saarinen, Jani wrote: > > Hi, > > > > > -Original Message- > > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] > > > On Behalf Of > > > Summers, Stuart > > > Sent: tiistai 28. touk

Re: [Intel-gfx] [CI 5/5] drm/i915: Expand subslice mask

2019-05-29 Thread Summers, Stuart
On Wed, 2019-05-29 at 17:58 +0300, Jani Nikula wrote: > On Fri, 24 May 2019, Stuart Summers wrote: > > Currently, the subslice_mask runtime parameter is stored as an > > array of subslices per slice. Expand the subslice mask array to > > better match what is presented to userspace through the > >

Re: [Intel-gfx] [CI,5/5] drm/i915: Expand subslice mask

2019-05-29 Thread Summers, Stuart
On Wed, 2019-05-29 at 17:33 +0300, Jani Nikula wrote: > On Wed, 29 May 2019, Nathan Chancellor > wrote: > > Hi Stuart, > > > > On Fri, May 24, 2019 at 08:40:22AM -0700, Stuart Summers wrote: > > > Currently, the subslice_mask runtime parameter is stored as an > > > array of subslices per slice. E

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v6,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-29 Thread Patchwork
== Series Details == Series: series starting with [v6,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range URL : https://patchwork.freedesktop.org/series/61323/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/gtt: grab wakeref in gen6_alloc_

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v6,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-29 Thread Patchwork
== Series Details == Series: series starting with [v6,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range URL : https://patchwork.freedesktop.org/series/61323/ State : warning == Summary == $ dim checkpatch origin/drm-tip eb05eacc4cba drm/i915/gtt: grab wakeref in gen6_alloc_va_range 51411

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: Avoid overflowing the WC stash

2019-05-29 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Avoid overflowing the WC stash URL : https://patchwork.freedesktop.org/series/61301/ State : success == Summary == CI Bug Log - changes from CI_DRM_6163 -> Patchwork_13125 Summary --- **SUCC

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Initialise subslice prior to potential zero-length loop

2019-05-29 Thread Patchwork
== Series Details == Series: drm/i915: Initialise subslice prior to potential zero-length loop URL : https://patchwork.freedesktop.org/series/61318/ State : failure == Summary == Applying: drm/i915: Initialise subslice prior to potential zero-length loop Using index info to reconstruct a base

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: selftest_lrc: Check the correct variable

2019-05-29 Thread Patchwork
== Series Details == Series: drm/i915: selftest_lrc: Check the correct variable URL : https://patchwork.freedesktop.org/series/61312/ State : failure == Summary == Applying: drm/i915: selftest_lrc: Check the correct variable Using index info to reconstruct a base tree... M drivers/gpu/dr

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Avoid overflowing the WC stash

2019-05-29 Thread Matthew Auld
On 29/05/2019 10:34, Chris Wilson wrote: An interesting issue cropped with making the pagetables be allocated and freed concurrently (i.e. removing their grandeous struct_mutex guard) was that we would overflow the page stash. This happens when we have multiple allocators grabbing WC pages such t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl

2019-05-29 Thread Patchwork
== Series Details == Series: drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl URL : https://patchwork.freedesktop.org/series/61299/ State : success == Summary == CI Bug Log - changes from CI_DRM_6163 -> Patchwork_13124 Summa

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "drm/i915: Expand subslice mask"

2019-05-29 Thread Patchwork
== Series Details == Series: Revert "drm/i915: Expand subslice mask" URL : https://patchwork.freedesktop.org/series/61293/ State : success == Summary == CI Bug Log - changes from CI_DRM_6160_full -> Patchwork_13123_full Summary --- *

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/gtt: Avoid overflowing the WC stash

2019-05-29 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Avoid overflowing the WC stash URL : https://patchwork.freedesktop.org/series/61301/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/gtt: Avoid overflowing the WC stash -O:drivers/gpu/drm/i915/i915_gem

Re: [Intel-gfx] [PATCH][next] drm/i915: fix uninitialized variable 'subslice_mask'

2019-05-29 Thread Colin Ian King
On 29/05/2019 16:04, Jani Nikula wrote: > On Wed, 29 May 2019, Colin King wrote: >> From: Colin Ian King >> >> Currently subslice_mask is not initialized and so data is being >> bit-wise or'd into a garbage value. Fix this by inintializing >> subslice_mask to zero. >> >> Addresses-Coverity: ("Uni

Re: [Intel-gfx] [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer

2019-05-29 Thread Daniel Vetter
On Wed, May 29, 2019 at 3:59 PM Shankar, Uma wrote: > > > > >-Original Message- > >From: Daniel Vetter [mailto:dan...@ffwll.ch] > >Sent: Wednesday, May 29, 2019 3:13 PM > >To: Shankar, Uma > >Cc: intel-gfx ; dri-devel >de...@lists.freedesktop.org>; Daniele Castagna ; > >jo...@kwiboo.se;

Re: [Intel-gfx] [PATCH][next] drm/i915: fix uninitialized variable 'subslice_mask'

2019-05-29 Thread Jani Nikula
On Wed, 29 May 2019, Colin King wrote: > From: Colin Ian King > > Currently subslice_mask is not initialized and so data is being > bit-wise or'd into a garbage value. Fix this by inintializing > subslice_mask to zero. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 1ac159e23c2

Re: [Intel-gfx] [PATCH] drm: Fix docbook warnings in hdr metadata helper structures

2019-05-29 Thread Daniel Vetter
On Wed, May 29, 2019 at 4:16 PM Uma Shankar wrote: > > Fixes the following warnings: > ./include/drm/drm_mode_config.h:841: warning: Incorrect use of > kernel-doc format: * hdr_output_metadata_property: Connector > property containing hdr > ./include/drm/drm_mode_config.h:918: warning: Fu

Re: [Intel-gfx] [PATCH][next] drm/i915: fix uninitialized variable 'mask'

2019-05-29 Thread Jani Nikula
On Wed, 29 May 2019, Colin King wrote: > From: Colin Ian King > > Currently mask is not initialized and so data is being bit-wise or'd into > a garbage value. Fix this by inintializing mask to zero. > > Addresses-Coverity: ("Uninitialized scalar variable") > Fixes: 1ac159e23c2c ("drm/i915: Expand

Re: [Intel-gfx] [CI 5/5] drm/i915: Expand subslice mask

2019-05-29 Thread Jani Nikula
On Fri, 24 May 2019, Stuart Summers wrote: > Currently, the subslice_mask runtime parameter is stored as an > array of subslices per slice. Expand the subslice mask array to > better match what is presented to userspace through the > I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is > t

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl

2019-05-29 Thread Patchwork
== Series Details == Series: drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl URL : https://patchwork.freedesktop.org/series/61299/ State : warning == Summary == $ dim checkpatch origin/drm-tip 82c3759de56a drm/ioctl: Ditch DRM_UNLOCKED except for the legacy vblank ioctl -:11:

[Intel-gfx] [PATCH][next] drm/i915: fix uninitialized variable 'subslice_mask'

2019-05-29 Thread Colin King
From: Colin Ian King Currently subslice_mask is not initialized and so data is being bit-wise or'd into a garbage value. Fix this by inintializing subslice_mask to zero. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 1ac159e23c2c ("drm/i915: Expand subslice mask") Signed-off-by: Co

Re: [Intel-gfx] [PATCH] drm: Fix docbook warnings in hdr metadata helper structures

2019-05-29 Thread Sean Paul
On Wed, May 29, 2019 at 08:13:50PM +0530, Uma Shankar wrote: > Fixes the following warnings: > ./include/drm/drm_mode_config.h:841: warning: Incorrect use of > kernel-doc format: * hdr_output_metadata_property: Connector > property containing hdr > ./include/drm/drm_mode_config.h:918: warn

Re: [Intel-gfx] [PATCH i-g-t] lib: Fix intel_get_current_physical_engine() iterator

2019-05-29 Thread Andi Shyti
Hi Chris, On Wed, May 29, 2019 at 02:24:21PM +0100, Chris Wilson wrote: > If we run out of engines, intel_get_current_physical_engine() degrades > into an infinite loop as although it advanced the iterator, it did not > update its local engine pointer. The patch looks like it does everything "but

Re: [Intel-gfx] [PATCH] drm/i915: Fix off-by-one in looking up icl sseu slice

2019-05-29 Thread Saarinen, Jani
HI, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Jani > Nikula > Sent: keskiviikko 29. toukokuuta 2019 17.23 > To: Chris Wilson ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix off-by-one in looki

Re: [Intel-gfx] [CI,5/5] drm/i915: Expand subslice mask

2019-05-29 Thread Jani Nikula
On Wed, 29 May 2019, Nathan Chancellor wrote: > Hi Stuart, > > On Fri, May 24, 2019 at 08:40:22AM -0700, Stuart Summers wrote: >> Currently, the subslice_mask runtime parameter is stored as an >> array of subslices per slice. Expand the subslice mask array to >> better match what is presented to u

[Intel-gfx] [PATCH][next] drm/i915: fix uninitialized variable 'mask'

2019-05-29 Thread Colin King
From: Colin Ian King Currently mask is not initialized and so data is being bit-wise or'd into a garbage value. Fix this by inintializing mask to zero. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: 1ac159e23c2c ("drm/i915: Expand subslice mask") Signed-off-by: Colin Ian King ---

Re: [Intel-gfx] [CI 0/5] Refactor to expand subslice mask

2019-05-29 Thread Jani Nikula
On Wed, 29 May 2019, "Saarinen, Jani" wrote: > Hi, > >> -Original Message- >> From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >> Summers, Stuart >> Sent: tiistai 28. toukokuuta 2019 21.33 >> To: Navare, Manasi D >> Cc: intel-gfx@lists.freedesktop.org >> Subj

Re: [Intel-gfx] [PATCH] drm/i915: Fix off-by-one in looking up icl sseu slice

2019-05-29 Thread Jani Nikula
On Wed, 29 May 2019, Jani Nikula wrote: > On Tue, 28 May 2019, Chris Wilson wrote: >> We want the index corresponding to the set bit but fls() returns the >> 1-index value. >> >> Otherwise, we trigger the sanitycheck >> intel_sseu_get_subslices:46 GEM_BUG_ON(slice >= sseu->max_slices) >> whe

Re: [Intel-gfx] [CI 0/5] Refactor to expand subslice mask

2019-05-29 Thread Daniele Ceraolo Spurio
On 5/28/19 11:48 PM, Saarinen, Jani wrote: Hi, -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Summers, Stuart Sent: tiistai 28. toukokuuta 2019 21.33 To: Navare, Manasi D Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [C

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915: Expand subslice mask"

2019-05-29 Thread Jani Nikula
On Wed, 29 May 2019, "Saarinen, Jani" wrote: > Hi, > Decisions here? Pushed with Daniel's irc ack. BR, Jani. > >> -Original Message- >> From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >> Patchwork >> Sent: keskiviikko 29. toukokuuta 2019 14.38 >> To: Niku

[Intel-gfx] [PATCH] drm: Fix docbook warnings in hdr metadata helper structures

2019-05-29 Thread Uma Shankar
Fixes the following warnings: ./include/drm/drm_mode_config.h:841: warning: Incorrect use of kernel-doc format: * hdr_output_metadata_property: Connector property containing hdr ./include/drm/drm_mode_config.h:918: warning: Function parameter or member 'hdr_output_metadata_property' not d

Re: [Intel-gfx] [v11 00/12] Add HDR Metadata Parsing and handling in DRM layer

2019-05-29 Thread Shankar, Uma
>-Original Message- >From: Daniel Vetter [mailto:dan...@ffwll.ch] >Sent: Wednesday, May 29, 2019 3:13 PM >To: Shankar, Uma >Cc: intel-gfx ; dri-devel de...@lists.freedesktop.org>; Daniele Castagna ; >jo...@kwiboo.se; Sean Paul ; Sharma, Shashank >; Syrjala, Ville >Subject: Re: [Intel-gf

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915: Expand subslice mask"

2019-05-29 Thread Saarinen, Jani
Hi, Decisions here? > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Patchwork > Sent: keskiviikko 29. toukokuuta 2019 14.38 > To: Nikula, Jani > Cc: intel-gfx@lists.freedesktop.org > Subject: [Intel-gfx] ✓ Fi.CI.BAT: success for Reve

[Intel-gfx] [PATCH i-g-t] lib: Fix intel_get_current_physical_engine() iterator

2019-05-29 Thread Chris Wilson
If we run out of engines, intel_get_current_physical_engine() degrades into an infinite loop as although it advanced the iterator, it did not update its local engine pointer. Reported-by: Petri Latvala Fixes: 17c77e7b0c3c ("lib/i915: add gem_engine_topology library and for_each loop definition")

[Intel-gfx] [PATCH v6 1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-29 Thread Matthew Auld
Some steps in gen6_alloc_va_range require the HW to be awake, so ideally we should be grabbing the wakeref ourselves and not relying on the caller already holding it for us. Suggested-by: Chris Wilson Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c

[Intel-gfx] [PATCH v6 2/2] drm/i915: add in-kernel blitter client

2019-05-29 Thread Matthew Auld
The plan is to use the blitter engine for async object clearing when using local memory, but before we can move the worker to get_pages() we have to first tame some more of our struct_mutex usage. With this in mind we should be able to upstream the object clearing as some selftests, which should se

Re: [Intel-gfx] [PATCH] drm/i915: selftest_lrc: Check the correct variable

2019-05-29 Thread Chris Wilson
Quoting Chris Wilson (2019-05-29 12:06:57) > Quoting Dan Carpenter (2019-05-29 12:03:55) > > We should check "request[n]" instead of just "request". > > > > Fixes: 78e41ddd2198 ("drm/i915: Apply an execution_mask to the > > virtual_engine") > > Signed-off-by: Dan Carpenter > > Oops. > Reviewd-b

Re: [Intel-gfx] [bug report] drm/i915: Engine discovery query

2019-05-29 Thread Dan Carpenter
On Wed, May 29, 2019 at 01:08:59PM +0100, Chris Wilson wrote: > Quoting Dan Carpenter (2019-05-29 12:52:43) > > Hello Tvrtko Ursulin, > > > > The patch c5d3e39caa45: "drm/i915: Engine discovery query" from May > > 22, 2019, leads to the following static checker warning: > > > > drivers/gp

Re: [Intel-gfx] [PATCH] drm/i915: Avoid refcount_inc on known zero count

2019-05-29 Thread Mika Kuoppala
Chris Wilson writes: > In intel_wakeref_auto, we use refcount_inc_not_zero to detect the first > use and initialise the timer. On doing so, we have to avoid using > refcount_inc on that zero count as the debug code flags that as an > error: > refcount_t: increment on 0; use-after-free. > Y

Re: [Intel-gfx] [bug report] drm/i915: Engine discovery query

2019-05-29 Thread Chris Wilson
Quoting Dan Carpenter (2019-05-29 12:52:43) > Hello Tvrtko Ursulin, > > The patch c5d3e39caa45: "drm/i915: Engine discovery query" from May > 22, 2019, leads to the following static checker warning: > > drivers/gpu/drm/i915/i915_query.c:134 query_engine_info() > warn: calling '__c

Re: [Intel-gfx] [PULL] gvt-fixes

2019-05-29 Thread Joonas Lahtinen
Quoting Zhenyu Wang (2019-05-29 12:06:08) > > Hi, > > Here's more gvt fixes for 5.2. This includes fixes for recently > seen arbitrary DMA map fault with sane gtt entry initialization, > and several enforcement fixes for e.g ggtt range validation, some > mode register handler and one cmd length f

[Intel-gfx] [bug report] drm/i915: Engine discovery query

2019-05-29 Thread Dan Carpenter
Hello Tvrtko Ursulin, The patch c5d3e39caa45: "drm/i915: Engine discovery query" from May 22, 2019, leads to the following static checker warning: drivers/gpu/drm/i915/i915_query.c:134 query_engine_info() warn: calling '__copy_to_user()' without access_ok() drivers/gpu/drm/i915/i

[Intel-gfx] ✓ Fi.CI.BAT: success for Revert "drm/i915: Expand subslice mask"

2019-05-29 Thread Patchwork
== Series Details == Series: Revert "drm/i915: Expand subslice mask" URL : https://patchwork.freedesktop.org/series/61293/ State : success == Summary == CI Bug Log - changes from CI_DRM_6160 -> Patchwork_13123 Summary --- **SUCCESS**

[Intel-gfx] [PATCH] drm/i915: Initialise subslice prior to potential zero-length loop

2019-05-29 Thread Chris Wilson
Appease static analysers by making sure subslice always have a value. drivers/gpu/drm/i915//gt/intel_engine_cs.c:971 intel_sseu_fls_subslice() error: uninitialized symbol 'subslice'. There's also the nagging question of whether that fls() is off-by-one... Fixes: 1ac159e23c2c ("drm/i915: Expand

Re: [Intel-gfx] [PATCH V3 i-g-t] lib: Drop __kms_addfb() wrapper

2019-05-29 Thread Rodrigo Siqueira
Hi Chris, Thank you for your feedback and the explanation about igt_ioctl, now I've got it. On Mon, May 27, 2019 at 7:13 AM Chris Wilson wrote: > > Quoting Rodrigo Siqueira (2019-05-27 02:19:51) > > The function __kms_addfb() and drmModeAddFB2WithModifiers() have a > > similar code. Due to this

Re: [Intel-gfx] [PATCH] drm/i915: selftest_lrc: Check the correct variable

2019-05-29 Thread Chris Wilson
Quoting Dan Carpenter (2019-05-29 12:03:55) > We should check "request[n]" instead of just "request". > > Fixes: 78e41ddd2198 ("drm/i915: Apply an execution_mask to the > virtual_engine") > Signed-off-by: Dan Carpenter Oops. Reviewd-by: Chris Wilson -Chris _

[Intel-gfx] [PATCH] drm/i915: selftest_lrc: Check the correct variable

2019-05-29 Thread Dan Carpenter
We should check "request[n]" instead of just "request". Fixes: 78e41ddd2198 ("drm/i915: Apply an execution_mask to the virtual_engine") Signed-off-by: Dan Carpenter --- drivers/gpu/drm/i915/gt/selftest_lrc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Revert "drm/i915: Expand subslice mask"

2019-05-29 Thread Patchwork
== Series Details == Series: Revert "drm/i915: Expand subslice mask" URL : https://patchwork.freedesktop.org/series/61293/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: Revert "drm/i915: Expand subslice mask" -O:drivers/gpu/drm/i915/i915_drv.c:469:24:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Revert "drm/i915: Expand subslice mask"

2019-05-29 Thread Patchwork
== Series Details == Series: Revert "drm/i915: Expand subslice mask" URL : https://patchwork.freedesktop.org/series/61293/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2ec02f472bf8 Revert "drm/i915: Expand subslice mask" -:20: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped c

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_workarounds: Verify regs directly

2019-05-29 Thread Chris Wilson
Quoting Mika Kuoppala (2019-05-29 11:15:46) > Chris Wilson writes: > > > It seems like the HW validator is getting better at preventing our > > snooping of system registers from non-privileged batches! If we can't > > use SRM, let's probe the register directly through mmio, making sure we > > hav

Re: [Intel-gfx] [bug report] drm/i915: Make sure we have enough memory bandwidth on ICL

2019-05-29 Thread Ville Syrjälä
On Wed, May 29, 2019 at 01:03:35PM +0300, Dan Carpenter wrote: > Hi Syrjälä, > > I had a question about commit c457d9cf256e: ("drm/i915: Make sure we have > enough memory bandwidth on ICL"). > > drivers/gpu/drm/i915/intel_bw.c > 64 static int icl_pcode_read_qgv_point_info(struct drm_i915_pri

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_workarounds: Verify regs directly

2019-05-29 Thread Mika Kuoppala
Chris Wilson writes: > It seems like the HW validator is getting better at preventing our > snooping of system registers from non-privileged batches! If we can't > use SRM, let's probe the register directly through mmio, making sure we > have the context spinning on the GPU first. > > v2: Hold fo

[Intel-gfx] [bug report] drm/i915: Make sure we have enough memory bandwidth on ICL

2019-05-29 Thread Dan Carpenter
Hi Syrjälä, I had a question about commit c457d9cf256e: ("drm/i915: Make sure we have enough memory bandwidth on ICL"). drivers/gpu/drm/i915/intel_bw.c 64 static int icl_pcode_read_qgv_point_info(struct drm_i915_private *dev_priv, 65 struct inte

  1   2   >