Re: [Intel-gfx] [PATCH v3 0/5] drm/gma500: drop use of drmP.h

On Sat, May 25, 2019 at 10:43 PM Sam Ravnborg wrote: > > Just a quick (final) probe. If there are no further feedback I will > commit this set sunday. > Added intel-gfx@lists.freedesktop.org just to get a bit more coverage. Hi Sam v2 of this series is already applied to drm-misc-next Thanks Patr

[Intel-gfx] [PATCH v3 5/5] drm/gma500: drop drmP.h include from all .c files

Drop remaining uses of the deprecated drmP.h header file in drm/gma500. Replaced drmp.h with forward declarations and/or include files as relevant. Moved all include files to blocks in following order: \#include \#include \#include \#include "" And within each block sort the include files

[Intel-gfx] [PATCH v3 1/5] drm/gma500: remove empty gma_drm.h header file

The header file gma_drm.h is empty so remove it and drop all uses of the file. Signed-off-by: Sam Ravnborg Acked-by: Daniel Vetter Acked-by: Patrik Jakobsson Cc: David Airlie --- drivers/gpu/drm/gma500/cdv_device.c | 2 +- drivers/gpu/drm/gma500/gem.c | 2 +- drivers/gpu/dr

[Intel-gfx] [PATCH v3 3/5] drm/gma500: make local header files more self-contained

Add proper forward declarations to minimize dependencies on other header files. Just add enough that we can safely include all header files in alphabetically order in relevant files. Signed-off-by: Sam Ravnborg Acked-by: Daniel Vetter Acked-by: Patrik Jakobsson Cc: David Airlie --- drivers/g

[Intel-gfx] [PATCH v3 2/5] drm/gma500: drop drmP.h from header files

Drop use of drmP.h from all header files in drm/gma500. Fix fallout in all files. In some cases moved include lines and sorted them too. With drmP.h removed from all header files it can now be removed from each .c file without any further dependencies Signed-off-by: Sam Ravnborg Acked-by: Daniel

[Intel-gfx] [PATCH v3 4/5] drm/gma500: drop use of DRM_UDELAY wrapper

The DRM_UDELAY wrapper from drm_os_linux.h is used in a few places, all other places calls udelay() with no wrapper. There is no reason to continue to use this wrapper - so drop it and direct call udelay(). Signed-off-by: Sam Ravnborg Acked-by: Daniel Vetter Acked-by: Patrik Jakobsson Cc: Davi

[Intel-gfx] [PATCH v3 0/5] drm/gma500: drop use of drmP.h

Just a quick (final) probe. If there are no further feedback I will commit this set sunday. Added intel-gfx@lists.freedesktop.org just to get a bit more coverage. The following patchset remove use of the deprecated drmP.h header file in the gma500 driver. As preparation an empty header file is r

[Intel-gfx] ✗ Fi.CI.IGT: failure for fbcon notifier begone! (rev3)

== Series Details == Series: fbcon notifier begone! (rev3) URL : https://patchwork.freedesktop.org/series/60843/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6140_full -> Patchwork_13088_full Summary --- **FAILURE**

Re: [Intel-gfx] [PATCH 00/33] fbcon notifier begone!

Hi Daniel. Good work, nice cleanup all over. A few comments to a few patches - not something that warrant a new series to be posted as long as it is fixed before the patches are applied. > btw for future plans: I think this is tricky enough (it's old code and all > that) that we should let this

Re: [Intel-gfx] [PATCH 25/33] fbmem: pull fbcon_fb_blanked out of fb_blank

Hi Daniel. On Fri, May 24, 2019 at 10:53:46AM +0200, Daniel Vetter wrote: > There's a callchain of: > > fbcon_fb_blaned -> do_(un)blank_screen -> consw->con_blank ^^ Spelling error - as this is a callchain it would be good to have it fixed. Patch itself looks fine. Sam >

Re: [Intel-gfx] [PATCH 09/33] fbcon: Remove fbcon_has_exited

Hi Daniel. One detail I noticed while brosing the changes. > > @@ -1064,9 +1062,13 @@ static void fbcon_init(struct vc_data *vc, int init) > int logo = 1, new_rows, new_cols, rows, cols, charcnt = 256; > int cap, ret; > > - if (info_idx == -1 || info == NULL) > + if (WARN_

Re: [Intel-gfx] [PATCH 11/33] fbdev/sh_mobile: remove sh_mobile_lcdc_display_notify

Hi Daniel > It's dead code, and removing it avoids me having to understand > what it's doing with lock_fb_info. I pushed the series through my build tests which include the sh architecture. One error and one warning was triggered from sh_mobile_lcdcfb.c. The rest was fine. The patch below remov

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for GuC 32.0.3 (rev5)

On Sat, 25 May 2019 12:39:13 +0200, Patchwork wrote: == Series Details == Series: GuC 32.0.3 (rev5) URL : https://patchwork.freedesktop.org/series/58760/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6137_full -> Patchwork_13086_full =

[Intel-gfx] ✗ Fi.CI.IGT: failure for GuC 32.0.3 (rev5)

== Series Details == Series: GuC 32.0.3 (rev5) URL : https://patchwork.freedesktop.org/series/58760/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6137_full -> Patchwork_13086_full Summary --- **FAILURE** Serious

[Intel-gfx] [bug report] drm/i915: Load balancing across a virtual engine

Hello Chris Wilson, The patch 6d06779e8672: "drm/i915: Load balancing across a virtual engine" from May 21, 2019, leads to the following static checker warning: drivers/gpu/drm/i915/gt/intel_lrc.c:3338 intel_execlists_create_virtual() warn: assigning (-2) to unsigned variable 've

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY (rev3)

== Series Details == Series: drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY (rev3) URL : https://patchwork.freedesktop.org/series/60839/ State : success == Summary == CI Bug Log - changes from CI_DRM_6137_full -> Patchwork_13085_full

[Intel-gfx] [PATCH i-g-t] i915/gem_workarounds: Verify regs directly

--- tests/i915/gem_workarounds.c | 45 +--- 1 file changed, 37 insertions(+), 8 deletions(-) diff --git a/tests/i915/gem_workarounds.c b/tests/i915/gem_workarounds.c index 44e3dce8a..bf8b4f630 100644 --- a/tests/i915/gem_workarounds.c +++ b/tests/i915/gem_workaroun