Re: [Intel-gfx] [PATCH 1/1] drm/i915: remove unused IO_TLB_SEGPAGES which should be defined by swiotlb

2019-05-20 Thread Chris Wilson
Quoting Dongli Zhang (2019-05-21 05:40:39) > This patch removes IO_TLB_SEGPAGES which is no longer used since > commit 5584f1b1d73e ("drm/i915: fix i915 running as dom0 under Xen"). > > As the define of both IO_TLB_SEGSIZE and IO_TLB_SHIFT are from swiotlb, > IO_TLB_SEGPAGES should be defined on s

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-20 Thread Pekka Paalanen
On Mon, 20 May 2019 18:11:07 +0200 Daniel Vetter wrote: > On Fri, May 17, 2019 at 01:08:24PM +0300, Pekka Paalanen wrote: > > On Thu, 16 May 2019 14:24:55 +0200 > > Daniel Vetter wrote: > > > > > On Thu, May 16, 2019 at 11:22:11AM +0300, Pekka Paalanen wrote: > > > > On Wed, 15 May 2019 10:

Re: [Intel-gfx] [PATCH v8 2/6] drm: Rename struct edp_vsc_psr to struct dp_sdp

2019-05-20 Thread Jani Nikula
On Mon, 20 May 2019, Gwan-gyeong Mun wrote: > VSC SDP Payload for PSR is one of data block type of SDP (Secondaray Data > Packet). In order to generalize SDP packet structure name, it renames > struct edp_vsc_psr to struct dp_sdp. And each SDP data blocks have > different usages, each SDP type has

[Intel-gfx] [PULL] gvt-fixes

2019-05-20 Thread Zhenyu Wang
Hi, Here's gvt-fixes for 5.2-rc. It contains vgpu reset fix with proper timeline handling, fixes for guest TRTT setting which should be handled in context state instead of pushing directly to hardware and one error return fix. Thanks. -- The following changes since commit a491cc8e1597ea25803191c

Re: [Intel-gfx] [PATCH] Revert "ICL HACK: Disable ACPI idle driver"

2019-05-20 Thread Saarinen, Jani
HI, > -Original Message- > From: Vivi, Rodrigo > Sent: tiistai 21. toukokuuta 2019 3.12 > To: Saarinen, Jani > Cc: Swarup, Aditya ; Gupta, Anshuman > ; Vetter, Daniel ; intel- > g...@lists.freedesktop.org; Syrjala, Ville ; Peres, > Martin > ; Wilson, Chris P > Subject: Re: [Intel-gfx]

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-20 Thread Patchwork
== Series Details == Series: linux-next: manual merge of the drm-misc tree with Linus' tree URL : https://patchwork.freedesktop.org/series/60886/ State : warning == Summary == $ dim checkpatch origin/drm-tip 75ba999b2c56 linux-next: manual merge of the drm-misc tree with Linus' tree -:15: ERRO

[Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2019-05-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: Documentation/devicetree/bindings/vendor-prefixes.txt between commit: 8122de54602e ("dt-bindings: Convert vendor prefixes to json-schema") from Linus' tree and commits: b4a2c0055a4f ("dt-bindings: Add vendor prefix

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the amdgpu tree

2019-05-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/amd/amdgpu/amdgpu_device.c between commit: 56965ce261af ("drm/amdgpu: cancel late_init_work before gpu reset") from the amdgpu tree and commit: 1d721ed679db ("drm/amdgpu: Avoid HW reset if guilty jo

Re: [Intel-gfx] [PATCH] Revert "ICL HACK: Disable ACPI idle driver"

2019-05-20 Thread Rodrigo Vivi
On Mon, May 20, 2019 at 01:42:35PM +, Saarinen, Jani wrote: > HI, > > > -Original Message- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > > Of > > Aditya Swarup > > Sent: lauantai 18. toukokuuta 2019 1.00 > > To: Gupta, Anshuman > > Cc: Vetter, Dani

Re: [Intel-gfx] [PATCH] drm: Allow modeset on unregisted connectors unconditionally

2019-05-20 Thread Imre Deak
On Mon, May 20, 2019 at 08:41:09PM +0300, Imre Deak wrote: > We allowed modesetting an unregistered connector only in the case the > mode is getting disabled on the connector. > > The reason for this check was the lack of proper refcounting for the > backing memory objects. That problem has been s

Re: [Intel-gfx] [igt-dev] [PATCH V2 i-g-t] lib: Drop __kms_addfb() wrapper

2019-05-20 Thread Rodrigo Siqueira
Hi Simon, Thank you very much for your review. I'll fix the issue in the next version. On Mon, May 20, 2019 at 3:22 AM Ser, Simon wrote: > > Hi Rodrigo, > > On Sun, 2019-05-19 at 20:00 -0300, Rodrigo Siqueira wrote: > > The function __kms_addfb() and drmModeAddFB2WithModifiers() have a > > simil

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix the interpretation of MAX_PRE-EMPHASIS_REACHED bit inorder to pass Link Layer compliance test number 400.3.1.15

2019-05-20 Thread Patchwork
== Series Details == Series: drm/i915: Fix the interpretation of MAX_PRE-EMPHASIS_REACHED bit inorder to pass Link Layer compliance test number 400.3.1.15 URL : https://patchwork.freedesktop.org/series/60880/ State : warning == Summary == $ dim checkpatch origin/drm-tip bc6664a25925 drm/i915:

[Intel-gfx] [PATCH] drm/i915: Fix the interpretation of MAX_PRE-EMPHASIS_REACHED bit inorder to pass Link Layer compliance test number 400.3.1.15

2019-05-20 Thread Khaled Almahallawy
According to DP 1.4 standard, if the source supports four pre-emphasis levels, then the source shall set the bit MAX_PRE-EMPHASIS_REACHED = 1 only when trasmitter programmed PRE-EMPHASIS_SET field (bits 4:3) to 11b (Level 3). Pre-emphasis level 3 is the maximum pre-emphasis level that the source

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] mm: Check if mmu notifier callbacks are allowed to fail

2019-05-20 Thread Patchwork
== Series Details == Series: series starting with [1/4] mm: Check if mmu notifier callbacks are allowed to fail URL : https://patchwork.freedesktop.org/series/60874/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool C

Re: [Intel-gfx] [PATCH 18/33] fbdev: make unregister/unlink functions not fail

2019-05-20 Thread kbuild test robot
Hi Daniel, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.2-rc1 next-20190520] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

[Intel-gfx] [PATCH 4/4] mm, notifier: Add a lockdep map for invalidate_range_start

2019-05-20 Thread Daniel Vetter
This is a similar idea to the fs_reclaim fake lockdep lock. It's fairly easy to provoke a specific notifier to be run on a specific range: Just prep it, and then munmap() it. A bit harder, but still doable, is to provoke the mmu notifiers for all the various callchains that might lead to them. But

[Intel-gfx] [PATCH 2/4] kernel.h: Add non_block_start/end()

2019-05-20 Thread Daniel Vetter
In some special cases we must not block, but there's not a spinlock, preempt-off, irqs-off or similar critical section already that arms the might_sleep() debug checks. Add a non_block_start/end() pair to annotate these. This will be used in the oom paths of mmu-notifiers, where blocking is not al

[Intel-gfx] [PATCH 1/4] mm: Check if mmu notifier callbacks are allowed to fail

2019-05-20 Thread Daniel Vetter
Just a bit of paranoia, since if we start pushing this deep into callchains it's hard to spot all places where an mmu notifier implementation might fail when it's not allowed to. Inspired by some confusion we had discussing i915 mmu notifiers and whether we could use the newly-introduced return va

[Intel-gfx] [PATCH 3/4] mm, notifier: Catch sleeping/blocking for !blockable

2019-05-20 Thread Daniel Vetter
We need to make sure implementations don't cheat and don't have a possible schedule/blocking point deeply burried where review can't catch it. I'm not sure whether this is the best way to make sure all the might_sleep() callsites trigger, and it's a bit ugly in the code flow. But it gets the job d

Re: [Intel-gfx] [PATCH] drm/i915: We don't need display's suspend/resume operations when !HAS_DISPLAY

2019-05-20 Thread Souza, Jose
On Sun, 2019-05-19 at 21:56 -0700, Rodrigo Vivi wrote: > Suspend resume is broken if we try to enable/disable dc9 on > cases with disabled displays. > Reviewed-by: José Roberto de Souza > Cc: José Roberto de Souza > Signed-off-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_drv.c | 103 ++

Re: [Intel-gfx] [PATCH] drm: Allow modeset on unregisted connectors unconditionally

2019-05-20 Thread Imre Deak
On Mon, May 20, 2019 at 10:59:35PM +0200, Daniel Vetter wrote: > On Mon, May 20, 2019 at 10:51 PM Imre Deak wrote: > > > > On Mon, May 20, 2019 at 10:15:20PM +0200, Daniel Vetter wrote: > > > On Mon, May 20, 2019 at 10:06 PM Imre Deak wrote: > > > > On Mon, May 20, 2019 at 09:23:00PM +0200, Danie

Re: [Intel-gfx] [PATCH] drm: Allow modeset on unregisted connectors unconditionally

2019-05-20 Thread Daniel Vetter
On Mon, May 20, 2019 at 10:51 PM Imre Deak wrote: > > On Mon, May 20, 2019 at 10:15:20PM +0200, Daniel Vetter wrote: > > On Mon, May 20, 2019 at 10:06 PM Imre Deak wrote: > > > On Mon, May 20, 2019 at 09:23:00PM +0200, Daniel Vetter wrote: > > > > On Mon, May 20, 2019 at 10:09:24PM +0300, Imre De

Re: [Intel-gfx] [PATCH] drm: Allow modeset on unregisted connectors unconditionally

2019-05-20 Thread Imre Deak
On Mon, May 20, 2019 at 10:15:20PM +0200, Daniel Vetter wrote: > On Mon, May 20, 2019 at 10:06 PM Imre Deak wrote: > > On Mon, May 20, 2019 at 09:23:00PM +0200, Daniel Vetter wrote: > > > On Mon, May 20, 2019 at 10:09:24PM +0300, Imre Deak wrote: > > > > On Mon, May 20, 2019 at 08:37:46PM +0200, D

Re: [Intel-gfx] [PATCH] drm: Allow modeset on unregisted connectors unconditionally

2019-05-20 Thread Daniel Vetter
On Mon, May 20, 2019 at 10:06 PM Imre Deak wrote: > On Mon, May 20, 2019 at 09:23:00PM +0200, Daniel Vetter wrote: > > On Mon, May 20, 2019 at 10:09:24PM +0300, Imre Deak wrote: > > > On Mon, May 20, 2019 at 08:37:46PM +0200, Daniel Vetter wrote: > > > > On Mon, May 20, 2019 at 08:41:09PM +0300, I

Re: [Intel-gfx] [PATCH] drm: Allow modeset on unregisted connectors unconditionally

2019-05-20 Thread Imre Deak
On Mon, May 20, 2019 at 09:23:00PM +0200, Daniel Vetter wrote: > On Mon, May 20, 2019 at 10:09:24PM +0300, Imre Deak wrote: > > On Mon, May 20, 2019 at 08:37:46PM +0200, Daniel Vetter wrote: > > > On Mon, May 20, 2019 at 08:41:09PM +0300, Imre Deak wrote: > > > > We allowed modesetting an unregiste

Re: [Intel-gfx] [PATCH 31/33] fbcon: Call con2fb_map functions directly

2019-05-20 Thread kbuild test robot
Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.2-rc1 next-20190520] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [Intel-gfx] [PATCH 31/33] fbcon: Call con2fb_map functions directly

2019-05-20 Thread kbuild test robot
Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.2-rc1 next-20190520] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [Intel-gfx] [PATCH 18/33] fbdev: make unregister/unlink functions not fail

2019-05-20 Thread kbuild test robot
Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.2-rc1 next-20190520] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [Intel-gfx] [PATCH 21/33] fbdev: directly call fbcon_suspended/resumed

2019-05-20 Thread kbuild test robot
Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.2-rc1 next-20190520] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [Intel-gfx] [PATCH] drm: Allow modeset on unregisted connectors unconditionally

2019-05-20 Thread Daniel Vetter
On Mon, May 20, 2019 at 10:09:24PM +0300, Imre Deak wrote: > On Mon, May 20, 2019 at 08:37:46PM +0200, Daniel Vetter wrote: > > On Mon, May 20, 2019 at 08:41:09PM +0300, Imre Deak wrote: > > > We allowed modesetting an unregistered connector only in the case the > > > mode is getting disabled on th

[Intel-gfx] XDC 2019: Registration & Call for Proposals now open!

2019-05-20 Thread Mark Filion
Hello! Registration & Call for Proposals are now open for XDC 2019, which will take place at the Concordia University Conference Centre in Montréal, Canada on October 2-4, 2019. Thanks to LWN.net, this year we have a brand new website using the Indico platform, a fully open source event managemen

Re: [Intel-gfx] [RFC PATCH 0/5] cgroup support for GPU devices

2019-05-20 Thread Chris Down
Leon Romanovsky writes: First group (programmers) is using special API [1] through libibverbs [2] without any notion of cgroups or any limitations. Second group (sysadmins) is less interested in application specifics and for them "device memory" means "memory" and not "rdma, nic specific, interna

Re: [Intel-gfx] [PATCH] drm: Allow modeset on unregisted connectors unconditionally

2019-05-20 Thread Imre Deak
On Mon, May 20, 2019 at 08:37:46PM +0200, Daniel Vetter wrote: > On Mon, May 20, 2019 at 08:41:09PM +0300, Imre Deak wrote: > > We allowed modesetting an unregistered connector only in the case the > > mode is getting disabled on the connector. > > > > The reason for this check was the lack of pro

Re: [Intel-gfx] [PATCH 18/33] fbdev: make unregister/unlink functions not fail

2019-05-20 Thread kbuild test robot
Hi Daniel, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.2-rc1 next-20190520] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [Intel-gfx] [PATCH] drm: Allow modeset on unregisted connectors unconditionally

2019-05-20 Thread Daniel Vetter
On Mon, May 20, 2019 at 08:41:09PM +0300, Imre Deak wrote: > We allowed modesetting an unregistered connector only in the case the > mode is getting disabled on the connector. > > The reason for this check was the lack of proper refcounting for the > backing memory objects. That problem has been s

Re: [Intel-gfx] [PATCH 27/33] fbdev: remove FBINFO_MISC_USEREVENT around fb_blank

2019-05-20 Thread Sam Ravnborg
Hi Daniel. On Mon, May 20, 2019 at 07:29:52PM +0200, Daniel Vetter wrote: > On Mon, May 20, 2019 at 7:20 PM Sam Ravnborg wrote: > > > > Hi Daniel. > > > > > With the recursion broken in the previous patch we can drop the > > > FBINFO_MISC_USEREVENT flag around calls to fb_blank - recursion > > >

[Intel-gfx] [PATCH] drm: Allow modeset on unregisted connectors unconditionally

2019-05-20 Thread Imre Deak
We allowed modesetting an unregistered connector only in the case the mode is getting disabled on the connector. The reason for this check was the lack of proper refcounting for the backing memory objects. That problem has been solved meanwhile so there is no reason any more to reject the modesett

Re: [Intel-gfx] [PATCH 27/33] fbdev: remove FBINFO_MISC_USEREVENT around fb_blank

2019-05-20 Thread Daniel Vetter
On Mon, May 20, 2019 at 7:20 PM Sam Ravnborg wrote: > > Hi Daniel. > > > With the recursion broken in the previous patch we can drop the > > FBINFO_MISC_USEREVENT flag around calls to fb_blank - recursion > > prevention was it's only job. > > > When grepping for FBINFO_MISC_USEREVENT I get a few h

Re: [Intel-gfx] [PATCH 10/33] fbcon: call fbcon_fb_(un)registered directly

2019-05-20 Thread Daniel Vetter
On Mon, May 20, 2019 at 7:08 PM Sam Ravnborg wrote: > > Hi Daniel. > > While browsing this nice patch series I stumbled upon a detail. > > On Mon, May 20, 2019 at 10:21:53AM +0200, Daniel Vetter wrote: > > With > > > > commit 6104c37094e729f3d4ce65797002112735d49cd1 > > Author: Daniel Vetter > >

Re: [Intel-gfx] [PATCH 27/33] fbdev: remove FBINFO_MISC_USEREVENT around fb_blank

2019-05-20 Thread Sam Ravnborg
Hi Daniel. > With the recursion broken in the previous patch we can drop the > FBINFO_MISC_USEREVENT flag around calls to fb_blank - recursion > prevention was it's only job. > When grepping for FBINFO_MISC_USEREVENT I get a few hits not addressed in the patch below: drivers/video/fbdev/core/fbc

Re: [Intel-gfx] [PATCH 10/33] fbcon: call fbcon_fb_(un)registered directly

2019-05-20 Thread Sam Ravnborg
Hi Daniel. While browsing this nice patch series I stumbled upon a detail. On Mon, May 20, 2019 at 10:21:53AM +0200, Daniel Vetter wrote: > With > > commit 6104c37094e729f3d4ce65797002112735d49cd1 > Author: Daniel Vetter > Date: Tue Aug 1 17:32:07 2017 +0200 > > fbcon: Make fbcon a built

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-20 Thread Paul Kocialkowski
Le lundi 20 mai 2019 à 18:11 +0200, Daniel Vetter a écrit : > On Fri, May 17, 2019 at 01:08:24PM +0300, Pekka Paalanen wrote: > > On Thu, 16 May 2019 14:24:55 +0200 > > Daniel Vetter wrote: > > > > > On Thu, May 16, 2019 at 11:22:11AM +0300, Pekka Paalanen wrote: > > > > On Wed, 15 May 2019 10:24

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-20 Thread Daniel Vetter
On Fri, May 17, 2019 at 01:08:24PM +0300, Pekka Paalanen wrote: > On Thu, 16 May 2019 14:24:55 +0200 > Daniel Vetter wrote: > > > On Thu, May 16, 2019 at 11:22:11AM +0300, Pekka Paalanen wrote: > > > On Wed, 15 May 2019 10:24:49 +0200 > > > Daniel Vetter wrote: > > > > > > > On Wed, May 15, 2

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/2] drm/i915/selftests: Verify context workarounds (rev2)

2019-05-20 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915/selftests: Verify context workarounds (rev2) URL : https://patchwork.freedesktop.org/series/60857/ State : success == Summary == CI Bug Log - changes from CI_DRM_6101 -> Patchwork_13047 ===

Re: [Intel-gfx] [PATCH v4 8/8] drm/i915: Bump gen7+ fb size limits to 16kx16k

2019-05-20 Thread Ville Syrjälä
On Thu, May 16, 2019 at 06:33:21PM +0200, Maarten Lankhorst wrote: > Op 09-05-2019 om 14:21 schreef Ville Syrjala: > > From: Ville Syrjälä > > > > With gtt remapping in place we can use arbitrarily large > > framebuffers. Let's bump the limits to 16kx16k on gen7+. > > The limit was chosen to match

[Intel-gfx] [PATCH v3] drm/i915: add i2c symlink under hdmi connector

2019-05-20 Thread Oleg Vasilev
Currently, the i2c adapter is available only under DP connectors. Add i2c symlink under hdmi connector pointing to i2c adapter in order to make this behaviour consistent. The initial motivation was to make igt i2c subtest patch [1] work on all connectors. [1]: https://patchwork.freedesktop.org/s

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: added i2c symlink to hdmi connector (rev2)

2019-05-20 Thread Patchwork
== Series Details == Series: drm/i915: added i2c symlink to hdmi connector (rev2) URL : https://patchwork.freedesktop.org/series/60794/ State : success == Summary == CI Bug Log - changes from CI_DRM_6101 -> Patchwork_13046 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/selftests: Verify context workarounds

2019-05-20 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/selftests: Verify context workarounds URL : https://patchwork.freedesktop.org/series/60855/ State : success == Summary == CI Bug Log - changes from CI_DRM_6101 -> Patchwork_13045 ==

[Intel-gfx] [PATCH i-g-t 24/27] gem_wsim: Discover engines

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Instead of hardcoding the VCS balancing engines, discover, both with the new engines query, or with the legacy get_param in the fallback case, so class based addressing always works. v2: * Simplify has_engine_query check. (Andi) * Fix assert on uninitialized variable. (And

[Intel-gfx] [PATCH i-g-t 23/27] gem_wsim: Consolidate engine assignments into helpers

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This will allow applying the discovered engine configuration from a single place. v2: * Consolidate enum to ci conversion. Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 163 -- 1 file changed, 94 insertions(+), 69 delet

[Intel-gfx] [PATCH i-g-t 27/27] gem_wsim: Allow random seed control

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin New command line option to allow controling the initial pseudo random generator seed in order to allow repeatable runs. Signed-off-by: Tvrtko Ursulin Suggested-by: Chris Wilson Suggested-by: Simon Ser --- benchmarks/gem_wsim.c | 12 +--- 1 file changed, 9 inserti

[Intel-gfx] [PATCH i-g-t 20/27] gem_wsim: Per context SSEU control

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A new workload command ('S') is added which allows per context slice (re-)configuration. v2: * Only query device SSEU on first use. (Chris) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- benchmarks/gem_wsim.c | 83 --

[Intel-gfx] [PATCH i-g-t 25/27] gem_wsim: Support Icelake parts

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin On Icelake second vcs engine is vcs2 instead of vcs1 so add some logical to physical instance remapping based on engine discovery to support it. v2: * Rebase. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- benchmarks/gem_wsim.c | 22 +-

[Intel-gfx] [PATCH i-g-t 21/27] gem_wsim: Allow RCS virtual engine with SSEU control

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To allow exercising the SSEU configuration in combination with Virtual Engine, allow RCS to be specified in the engine map and use appropriate index based addressing when applying SSEU configuration to it. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- benchm

[Intel-gfx] [PATCH i-g-t 26/27] gem_wsim: Fix prng usage

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Back when gem_wsim used forking it was safe to use the common storage prng, but after converting to threads it no longer is. Fix by storing and using a new per workload seed for batch buffer duration randomness. Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 17

[Intel-gfx] [PATCH i-g-t 17/27] gem_wsim: Some more example workloads

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A few additional workloads useful for experimenting with scheduling. Signed-off-by: Tvrtko Ursulin Acked-by: Chris Wilson --- benchmarks/wsim/frame-split-60fps.wsim | 16 benchmarks/wsim/high-composited-game.wsim | 11 +++ benchmarks/wsim/m

[Intel-gfx] [PATCH i-g-t 18/27] gem_wsim: Infinite batch support

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin For simulating frame split workloads it is useful to express a batch which ends at the same time as the parallel submission on the respective bonded engine. For this we add support for infinite batch durations and the batch terminate command ('T'). Syntax looks like this:

[Intel-gfx] [PATCH i-g-t 22/27] tests/i915_query: Engine discovery tests

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Test the new engine discovery query. Signed-off-by: Tvrtko Ursulin --- tests/i915/i915_query.c | 247 1 file changed, 247 insertions(+) diff --git a/tests/i915/i915_query.c b/tests/i915/i915_query.c index 7d0c0e3a061c..ecbec3ae141d

[Intel-gfx] [PATCH i-g-t 15/27] gem_wsim: Engine map load balance command

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A new workload command for enabling a load balanced context map (aka Virtual Engine). Example usage: B.1 This turns on load balancing for context one, assuming it has already been configured with an engine map. Only DEFAULT engine specifier can be used with load balanced

[Intel-gfx] [PATCH i-g-t 19/27] gem_wsim: Command line switch for specifying low slice count workloads

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A new command line switch ('-s') is added which toggles the low slice count mode for workloads following on the command line. This enables easy benchmarking of the effect of running the existing media workloads in parallel against another client. For example: ./gem_wsim -

[Intel-gfx] [PATCH i-g-t 13/27] gem_wsim: Save some lines by changing to implicit NULL checking

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We can improve the parsing loop readability a bit more by avoiding some line breaks caused by explicit NULL checks. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- benchmarks/gem_wsim.c | 39 +++ 1 file changed, 15 insertion

[Intel-gfx] [PATCH i-g-t 12/27] gem_wsim: Engine map support

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Support new i915 uAPI for configuring contexts with engine maps. Please refer to the README file for more detailed explanation. v2: * Allow defining engine maps by class. Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 211 +++-

[Intel-gfx] [PATCH i-g-t 14/27] gem_wsim: Compact int command parsing with a macro

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Parsing an integer workload descriptor field is a common pattern which we can extract to a helper macro and by doing so further improve the readability of the main parsing loop. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- benchmarks/gem_wsim.c | 80 +++

[Intel-gfx] [PATCH i-g-t 16/27] gem_wsim: Engine bond command

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Engine bonds are an i915 uAPI applicable to load balanced contexts with engine map. They allow expression rules of engine selection between two contexts when submissions are also tied with submit fences. Please refer to the README for a more detailed description. v2: * Use

[Intel-gfx] [PATCH i-g-t 08/27] gem_wsim: Factor out common error handling

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin There is a repeated pattern with error handling which can be moved to a macro to for better readability in the command parsing loop. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- benchmarks/gem_wsim.c | 244 +++--- 1 file

[Intel-gfx] [PATCH i-g-t 05/27] trace.pl: Virtual engine preemption support

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the 'completed?' tracepoint field to detect more robustly when a request has been preempted and remove it from the engine database if so. Otherwise the script can hit a scenario where the same global seqno will be mentioned multiple times (on an engine seqno) which abort

[Intel-gfx] [PATCH i-g-t 11/27] gem_wsim: Extract str to engine lookup

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin v2: * Remove redundant check. (Chris) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- benchmarks/gem_wsim.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c

[Intel-gfx] [PATCH i-g-t 10/27] gem_wsim: Submit fence support

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add support for submit fences in a way similar to how normal input fences are handled. Eg: 1.RCS.500-1000.0.0 1.VCS1.3000.s-1.0 1.VCS2.3000.s-2.0 Submit fences are signalled when the originating request enters the submission backend. Signed-off-by: Tvrtko Ursulin Re

[Intel-gfx] [PATCH i-g-t 09/27] gem_wsim: More wsim_err

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A few more opportunities to compact the code by using the error logging helper. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- benchmarks/gem_wsim.c | 54 --- 1 file changed, 15 insertions(+), 39 deletions(-) diff --gi

[Intel-gfx] [PATCH i-g-t 02/27] trace.pl: Ignore signaling on non i915 fences

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin gem_wsim uses the sw_fence timeline and confuses the script. v2: * Check the correct timeline as well. (Chris) Signed-off-by: Tvrtko Ursulin --- scripts/trace.pl | 3 +++ 1 file changed, 3 insertions(+) diff --git a/scripts/trace.pl b/scripts/trace.pl index 8c896cfde6b0

[Intel-gfx] [PATCH i-g-t 06/27] wsim/media-bench: i915 balancing

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Support i915 virtual engine from gem_wsim (-b i915) and media-bench.pl v2: * Add vm_destroy. (Chris) * Remove unneeded braces. (Chris) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- benchmarks/gem_wsim.c | 302 +++-- sc

[Intel-gfx] [PATCH i-g-t 07/27] gem_wsim: Use IGT uapi headers

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We are moving towards bumping the uAPI headers more often instead of using too much local struct/ioctl/param definitions since the latter are more challenging for rebase and maintenance. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- benchmarks/gem_wsim.c | 1

[Intel-gfx] [PATCH i-g-t 04/27] trace.pl: Virtual engine support

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add virtual/queue timelines to both stdout and HTML output. A new timeline is created for each queue/virtual engine to display associated requests in queued and runnable states. Once requests are submitted to a real engine for executing they show up on the physical engine ti

[Intel-gfx] [PATCH i-g-t 03/27] headers: bump

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Catch up to drm-tip headers. Signed-off-by: Tvrtko Ursulin --- include/drm-uapi/amdgpu_drm.h | 52 +++- include/drm-uapi/drm.h | 36 ++ include/drm-uapi/drm_mode.h| 4 +- include/drm-uapi/i915_drm.h| 209 - inclu

[Intel-gfx] [PATCH i-g-t 00/27] Media scalability tooling

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Review feedback and some other fixes: * prng seed fix and control via command line parameter. * trace.pl dma_fence_signal_notify fix. * Further consolidation in gem_wsim "un-hardcoding" patches. Tvrtko Ursulin (27): scripts/trace.pl: Fix after intel_engine_notify remova

[Intel-gfx] [PATCH i-g-t 01/27] scripts/trace.pl: Fix after intel_engine_notify removal

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin After the removal of engine global seqnos and the corresponding intel_engine_notify tracepoints the script needs to be adjusted to cope with the new state of things. To keep working it switches over using the dma_fence:dma_fence_signaled: tracepoint and keeps one extra inter

[Intel-gfx] [PATCH v4 1/2] drm/i915/selftests: Verify context workarounds

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Test context workarounds have been correctly applied in newly created contexts. To accomplish this the existing engine_wa_list_verify helper is extended to take in a context from which reading of the workaround list will be done. Context workaround verification is done from

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: added i2c symlink to hdmi connector (rev2)

2019-05-20 Thread Patchwork
== Series Details == Series: drm/i915: added i2c symlink to hdmi connector (rev2) URL : https://patchwork.freedesktop.org/series/60794/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7cf050cd9642 drm/i915: add i2c symlink under hdmi connector -:44: WARNING:LINE_SPACING: Missing

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915/selftests: Verify context workarounds

2019-05-20 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/selftests: Verify context workarounds URL : https://patchwork.freedesktop.org/series/60855/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/selftests: Verify context workaroun

Re: [Intel-gfx] [PATCH] Revert "ICL HACK: Disable ACPI idle driver"

2019-05-20 Thread Saarinen, Jani
HI, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Aditya Swarup > Sent: lauantai 18. toukokuuta 2019 1.00 > To: Gupta, Anshuman > Cc: Vetter, Daniel ; intel-gfx@lists.freedesktop.org; > Syrjala, Ville ; Peres, Martin > > Subject:

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/33] drm/i915: Restore control over ppgtt for context creation ABI

2019-05-20 Thread Patchwork
== Series Details == Series: series starting with [01/33] drm/i915: Restore control over ppgtt for context creation ABI URL : https://patchwork.freedesktop.org/series/60842/ State : failure == Summary == Applying: drm/i915: Restore control over ppgtt for context creation ABI Applying: drm/i91

Re: [Intel-gfx] [PATCH 18/33] drm/i915: Move more GEM objects under gem/

2019-05-20 Thread Mika Kuoppala
Chris Wilson writes: > Continuing the theme of separating out the GEM clutter. > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-

[Intel-gfx] linux-next: Fixes tag needs some work in the drm-intel tree

2019-05-20 Thread Stephen Rothwell
Hi all, In commit 0d90ccb70211 ("drm/i915: Delay semaphore submission until the start of the signaler") Fixes tag Fixes: e88619646971 ("drm/i915: Use HW semaphores for inter-engine synchroni has these problem(s): - Subject has leading but no trailing parentheses - Subject has leading

Re: [Intel-gfx] [PATCH v2] drm/i915/huc: Don't try to check HuC status if it's not loaded

2019-05-20 Thread Michal Wajdeczko
On Mon, 20 May 2019 12:44:43 +0200, Chris Wilson wrote: Quoting Michal Wajdeczko (2019-05-20 11:24:37) On Mon, 20 May 2019 11:35:26 +0200, Chris Wilson wrote: > Quoting Michal Wajdeczko (2019-05-19 22:50:43) >> If we never attempted to load HuC firmware, or we already wedged >> or reset Gu

[Intel-gfx] [PATCH v2 02/25] trace.pl: Ignore signaling on non i915 fences

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin gem_wsim uses the sw_fence timeline and confuses the script. v2: * Check the correct timeline as well. (Chris) Signed-off-by: Tvrtko Ursulin --- scripts/trace.pl | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/trace.pl b/scripts/trace.pl index b7bbabc79f68.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: Support for DP YCbCr4:2:0 outputs (rev3)

2019-05-20 Thread Patchwork
== Series Details == Series: drm/i915/dp: Support for DP YCbCr4:2:0 outputs (rev3) URL : https://patchwork.freedesktop.org/series/60404/ State : success == Summary == CI Bug Log - changes from CI_DRM_6097_full -> Patchwork_13043_full Summar

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 12/25] gem_wsim: Engine map support

2019-05-20 Thread Tvrtko Ursulin
On 20/05/2019 11:59, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-20 11:49:13) On 17/05/2019 20:35, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-17 12:25:13) + /* +* Ensure VCS is not allowed with engine map contexts. +*/ + for (j = 0; j < wrk->nr_ct

[Intel-gfx] [PATCH v3 1/2] drm/i915/selftests: Verify context workarounds

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Test context workarounds have been correctly applied in newly created contexts. To accomplish this the existing engine_wa_list_verify helper is extended to take in a context from which reading of the workaround list will be done. Context workaround verification is done from

[Intel-gfx] [PATCH v3 2/2] drm/i915/icl: Add WaDisableBankHangMode

2019-05-20 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Disable GPU hang by default on unrecoverable ECC cache errors. v2: * Rebase. v3: * Use intel_uncore_read. (Chris) Fixes: cc38cae7c4e9 ("drm/i915/icl: Introduce initial Icelake Workarounds") Signed-off-by: Tvrtko Ursulin Acked-by: Chris Wilson --- drivers/gpu/drm/i915/

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 12/25] gem_wsim: Engine map support

2019-05-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-20 11:49:13) > > On 17/05/2019 20:35, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-05-17 12:25:13) > >> + /* > >> +* Ensure VCS is not allowed with engine map contexts. > >> +*/ > >> + for (j = 0; j < wrk->nr_ctxs; j += 2) { > >>

Re: [Intel-gfx] [RFC PATCH] drm/i915: Tolerate file owned GEM contexts on hot unbind

2019-05-20 Thread Janusz Krzysztofik
On Friday, May 17, 2019 4:32:35 PM CEST Chris Wilson wrote: > Quoting Janusz Krzysztofik (2019-05-17 15:06:17) > > From: Janusz Krzysztofik > > > > During i915_driver_unload(), GEM contexts are verified restrictively > > inside i915_gem_fini() if they don't consume shared resources which > > shou

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 12/25] gem_wsim: Engine map support

2019-05-20 Thread Tvrtko Ursulin
On 17/05/2019 20:35, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-17 12:25:13) From: Tvrtko Ursulin Support new i915 uAPI for configuring contexts with engine maps. Please refer to the README file for more detailed explanation. v2: * Allow defining engine maps by class. Signed-off

Re: [Intel-gfx] [PATCH v2] drm/i915/huc: Don't try to check HuC status if it's not loaded

2019-05-20 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-05-20 11:24:37) > On Mon, 20 May 2019 11:35:26 +0200, Chris Wilson > wrote: > > > Quoting Michal Wajdeczko (2019-05-19 22:50:43) > >> If we never attempted to load HuC firmware, or we already wedged > >> or reset GuC/HuC, then there is no reason to wake up the dev

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/selftests: Add live_context_workarounds

2019-05-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/selftests: Add live_context_workarounds URL : https://patchwork.freedesktop.org/series/60846/ State : success == Summary == CI Bug Log - changes from CI_DRM_6097_full -> Patchwork_13042_full =

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/icl: Add WaDisableBankHangMode

2019-05-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-20 11:18:16) > diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c > b/drivers/gpu/drm/i915/gt/intel_workarounds.c > index 468928cd8fb3..1a730424eba7 100644 > --- a/drivers/gpu/drm/i915/gt/intel_workarounds.c > +++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/selftests: Verify context workarounds

2019-05-20 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-20 11:18:15) > @@ -1352,11 +1357,11 @@ static int engine_wa_list_verify(struct > intel_engine_cs *engine, > if (!wal->count) > return 0; > > - vma = create_scratch(&engine->i915->ggtt.vm, wal->count); > + vma = create_scratch(&c

Re: [Intel-gfx] [PATCH i-g-t 02/25] trace.pl: Ignore signaling on non i915 fences

2019-05-20 Thread Tvrtko Ursulin
On 17/05/2019 20:20, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-17 12:25:03) From: Tvrtko Ursulin gem_wsim uses the sw_fence timeline and confuses the script. sw_sync How does this fare with clflush fences (which are .driver="i915") and all of the future .driver="i915" fences? Lo

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 15/25] gem_wsim: Engine map load balance command

2019-05-20 Thread Tvrtko Ursulin
On 17/05/2019 20:36, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-17 12:25:16) From: Tvrtko Ursulin A new workload command for enabling a load balanced context map (aka Virtual Engine). Example usage: B.1 This turns on load balancing for context one, assuming it has already been c

Re: [Intel-gfx] [PATCH v2] drm/i915/huc: Don't try to check HuC status if it's not loaded

2019-05-20 Thread Michal Wajdeczko
On Mon, 20 May 2019 11:35:26 +0200, Chris Wilson wrote: Quoting Michal Wajdeczko (2019-05-19 22:50:43) If we never attempted to load HuC firmware, or we already wedged or reset GuC/HuC, then there is no reason to wake up the device to check one bit in the register that will be for sure clear

[Intel-gfx] [PATCH v2] drm/i915: add i2c symlink under hdmi connector

2019-05-20 Thread Oleg Vasilev
Currently, the i2c adapter is available only under DP connectors. Add i2c symlink under hdmi connector pointing to i2c adapter in order to make this behaviour consistent. The initial motivation was to make igt i2c subtest patch [1] work on all connectors. [1]: https://patchwork.freedesktop.org/s

  1   2   >