Re: [Intel-gfx] [PATCH i-g-t 08/16] i915: Exercise creating context with shared GTT

2019-05-14 Thread Tvrtko Ursulin
On 08/05/2019 11:09, Chris Wilson wrote: v2: Test each shared context is its own timeline and allows request reordering between shared contexts. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Tvrtko Ursulin Cc: Mika Kuoppala Cc: Michal Wajdeczko --- lib/i915/gem_context.c|

Re: [Intel-gfx] [PATCH] drm/i915: drop unneeded -Wall addition

2019-05-14 Thread Chris Wilson
Quoting Masahiro Yamada (2019-05-15 05:37:53) > The top level Makefile adds -Wall globally: > > KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \ > > I see two "-Wall" added for compiling under drivers/gpu/drm/i915/. Does it matter? Is the statement in i915/Makefile n

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

2019-05-14 Thread Tvrtko Ursulin
On 15/05/2019 01:06, Rodrigo Vivi wrote: On Tue, May 14, 2019 at 06:32:01PM +, Summers, Stuart wrote: On Tue, 2019-05-14 at 17:53 +0100, Chris Wilson wrote: Quoting Stuart Summers (2019-05-14 17:46:52) To allow easier debug of platforms which do not fully support power-saving render C-sta

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: drop unneeded -Wall addition

2019-05-14 Thread Patchwork
== Series Details == Series: drm/i915: drop unneeded -Wall addition URL : https://patchwork.freedesktop.org/series/60652/ State : success == Summary == CI Bug Log - changes from CI_DRM_6085 -> Patchwork_13019 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: drop unneeded -Wall addition

2019-05-14 Thread Patchwork
== Series Details == Series: drm/i915: drop unneeded -Wall addition URL : https://patchwork.freedesktop.org/series/60652/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: drop unneeded -Wall addition - +./arch/x86/include/asm/pgtable_64.h:61:9:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: drop unneeded -Wall addition

2019-05-14 Thread Patchwork
== Series Details == Series: drm/i915: drop unneeded -Wall addition URL : https://patchwork.freedesktop.org/series/60652/ State : warning == Summary == $ dim checkpatch origin/drm-tip a38bfd30109f drm/i915: drop unneeded -Wall addition -:8: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped comm

[Intel-gfx] [PATCH] drm/i915: drop unneeded -Wall addition

2019-05-14 Thread Masahiro Yamada
The top level Makefile adds -Wall globally: KBUILD_CFLAGS := -Wall -Wundef -Werror=strict-prototypes -Wno-trigraphs \ I see two "-Wall" added for compiling under drivers/gpu/drm/i915/. Signed-off-by: Masahiro Yamada --- BTW, I have a question in the comment: "Note the danger in using -Wa

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with drm/i915: Mark semaphores as complete on unsubmit out if payload was started (rev2)

2019-05-14 Thread Patchwork
== Series Details == Series: series starting with drm/i915: Mark semaphores as complete on unsubmit out if payload was started (rev2) URL : https://patchwork.freedesktop.org/series/60642/ State : success == Summary == CI Bug Log - changes from CI_DRM_6082_full -> Patchwork_13018_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for Add HDR Metadata Parsing and handling in DRM layer (rev10)

2019-05-14 Thread Patchwork
== Series Details == Series: Add HDR Metadata Parsing and handling in DRM layer (rev10) URL : https://patchwork.freedesktop.org/series/25091/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6081_full -> Patchwork_13017_full S

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Re-add enable_rc6 modparam

2019-05-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Re-add enable_rc6 modparam URL : https://patchwork.freedesktop.org/series/60637/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6081_full -> Patchwork_13016_full ==

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

2019-05-14 Thread Rodrigo Vivi
On Tue, May 14, 2019 at 06:32:01PM +, Summers, Stuart wrote: > On Tue, 2019-05-14 at 17:53 +0100, Chris Wilson wrote: > > Quoting Stuart Summers (2019-05-14 17:46:52) > > > To allow easier debug of platforms which do not fully support > > > power-saving render C-state 6, add back the module par

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: adding state checker for gamma lut values (rev9)

2019-05-14 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev9) URL : https://patchwork.freedesktop.org/series/58039/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6080_full -> Patchwork_13015_full S

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 19/21] gem_wsim: Per context SSEU control

2019-05-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-08 13:10:56) > +static void get_device_sseu(void) > +{ > + struct drm_i915_gem_context_param param = { }; > + > + param.param = I915_CONTEXT_PARAM_SSEU; > + param.value = (uintptr_t)&device_sseu; > + > + gem_context_get_param(fd, ¶m); This is

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with drm/i915: Mark semaphores as complete on unsubmit out if payload was started (rev2)

2019-05-14 Thread Patchwork
== Series Details == Series: series starting with drm/i915: Mark semaphores as complete on unsubmit out if payload was started (rev2) URL : https://patchwork.freedesktop.org/series/60642/ State : success == Summary == CI Bug Log - changes from CI_DRM_6082 -> Patchwork_13018 ==

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

2019-05-14 Thread Summers, Stuart
On Tue, 2019-05-14 at 17:53 +0100, Chris Wilson wrote: > Quoting Stuart Summers (2019-05-14 17:46:52) > > To allow easier debug of platforms which do not fully support > > power-saving render C-state 6, add back the module parameter > > to allow RC6 flows to be disabled. Instead of directly affecti

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with drm/i915: Mark semaphores as complete on unsubmit out if payload was started (rev2)

2019-05-14 Thread Patchwork
== Series Details == Series: series starting with drm/i915: Mark semaphores as complete on unsubmit out if payload was started (rev2) URL : https://patchwork.freedesktop.org/series/60642/ State : warning == Summary == $ dim checkpatch origin/drm-tip b89780ed0a75 drm/i915: Mark semaphores as c

Re: [Intel-gfx] [PATCH] drm/i915/perf: Refactor oa object to better manage resources

2019-05-14 Thread Umesh Nerlige Ramappa
On Tue, May 14, 2019 at 10:34:49AM +0100, Lionel Landwerlin wrote: Hi Umesh, I just noticed this different between v1 & v2. My understanding is that if destroy() is called, stream should be the same as dev_priv->perf.exclusive_stream. If it's not it sounds like a bug. So why change this? v2 f

[Intel-gfx] [PATCH] drm/i915: Mark semaphores as complete on unsubmit out if payload was started

2019-05-14 Thread Chris Wilson
Avoid charging us for the presumed busywait if the request was preempted after successfully using semaphores to reduce inter-engine latency. v2: Bump the priority to reflect the lack of semaphores now required. References: ca6e56f654e7 ("drm/i915: Disable semaphore busywaits on saturated systems

[Intel-gfx] [PATCH 3/4] drm/i915: Bump signaler priority on adding a waiter

2019-05-14 Thread Chris Wilson
The handling of the no-preemption priority level imposes the restriction that we need to maintain the implied ordering even though preemption is disabled. Otherwise we may end up with an AB-BA deadlock across multiple engine due to a real preemption event reordering the no-preemption WAITs. To reso

[Intel-gfx] [PATCH 1/4] drm/i915: Mark semaphores as complete on unsubmit out if payload was started

2019-05-14 Thread Chris Wilson
Avoid charging us for the presumed busywait if the request was preempted after successfully using semaphores to reduce inter-engine latency. References: ca6e56f654e7 ("drm/i915: Disable semaphore busywaits on saturated systems") Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- drivers/gpu/dr

[Intel-gfx] [PATCH 4/4] drm/i915: Downgrade NEWCLIENT to non-preemptive

2019-05-14 Thread Chris Wilson
Commit 1413b2bc0717 ("drm/i915: Trim NEWCLIENT boosting") had the intended consequence of not allowing a sequence of work that merely crossed into a new engine the privilege to be promoted to NEWCLIENT status. It also had the unintended consequence of actually making NEWCLIENT effective on heavily

[Intel-gfx] [PATCH 2/4] drm/i915: Truly bump ready tasks ahead of busywaits

2019-05-14 Thread Chris Wilson
In commit b7404c7ecb38 ("drm/i915: Bump ready tasks ahead of busywaits"), I tried cutting a corner in order to not install a signal for each of our dependencies, and only listened to requests on which we were intending to busywait. The compromise that was made was that instead of then being able to

[Intel-gfx] ✓ Fi.CI.BAT: success for Add HDR Metadata Parsing and handling in DRM layer (rev10)

2019-05-14 Thread Patchwork
== Series Details == Series: Add HDR Metadata Parsing and handling in DRM layer (rev10) URL : https://patchwork.freedesktop.org/series/25091/ State : success == Summary == CI Bug Log - changes from CI_DRM_6081 -> Patchwork_13017 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add HDR Metadata Parsing and handling in DRM layer (rev10)

2019-05-14 Thread Patchwork
== Series Details == Series: Add HDR Metadata Parsing and handling in DRM layer (rev10) URL : https://patchwork.freedesktop.org/series/25091/ State : warning == Summary == $ dim checkpatch origin/drm-tip d7b17f998fd9 drm: Add HDR source metadata property -:72: CHECK:PARENTHESIS_ALIGNMENT: Alig

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Re-add enable_rc6 modparam

2019-05-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Re-add enable_rc6 modparam URL : https://patchwork.freedesktop.org/series/60637/ State : success == Summary == CI Bug Log - changes from CI_DRM_6081 -> Patchwork_13016 Summar

[Intel-gfx] [v10 11/12] video/hdmi: Add Unpack function for DRM infoframe

2019-05-14 Thread Uma Shankar
Added unpack function for DRM infoframe for dynamic range and mastering infoframe readout. v2: Addressed Ville's review comments. Suggested-by: Ville Syrjälä Signed-off-by: Uma Shankar --- drivers/video/hdmi.c | 70 include/linux/hdmi.h | 1

[Intel-gfx] [v10 12/12] drm/i915: Add state readout for DRM infoframe

2019-05-14 Thread Uma Shankar
Added state readout for DRM infoframe and enabled state validation for DRM infoframe. v2: Addressed Ville's review comments and dropped the unused drm infoframe read at intel_hdmi_init. Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/intel_ddi.c | 4 drivers/gpu/drm/i915/intel_disp

[Intel-gfx] [v10 08/12] drm/i915: Enable infoframes on GLK+ for HDR

2019-05-14 Thread Uma Shankar
From: Ville Syrjälä This patch enables infoframes on GLK+ to be used to send HDR metadata to HDMI sink. v2: Addressed Shashank's review comment. v3: Addressed Shashank's review comment. v4: Added Shashank's RB. v5: Dropped hdr_metadata_change check while modeset, as per Ville's suggestion. S

[Intel-gfx] [v10 10/12] drm/i915: Added DRM Infoframe handling for BYT/CHT

2019-05-14 Thread Uma Shankar
BYT/CHT doesn't support DRM Infoframe. This caused a WARN_ON due to a missing CASE while executing intel_hdmi_infoframes_enabled function. This patch fixes the same. Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu

[Intel-gfx] [v10 07/12] drm: Add HLG EOTF

2019-05-14 Thread Uma Shankar
From: Ville Syrjälä ADD HLG EOTF to the list of EOTF transfer functions supported. Hybrid Log-Gamma (HLG) is a high dynamic range (HDR) standard. HLG defines a nonlinear transfer function in which the lower half of the signal values use a gamma curve and the upper half of the signal values use a

[Intel-gfx] [v10 04/12] drm: Enable HDR infoframe support

2019-05-14 Thread Uma Shankar
Enable Dynamic Range and Mastering Infoframe for HDR content, which is defined in CEA 861.3 spec. The metadata will be computed based on blending policy in userspace compositors and passed as a connector property blob to driver. The same will be sent as infoframe to panel which support HDR. Added

[Intel-gfx] [v10 09/12] drm/i915:Enabled Modeset when HDR Infoframe changes

2019-05-14 Thread Uma Shankar
This patch enables modeset whenever HDR metadata needs to be updated to sink. v2: Addressed Shashank's review comments. v3: Added Shashank's RB. v4: Addressed Ville's review comments. Signed-off-by: Ville Syrjälä Signed-off-by: Uma Shankar Reviewed-by: Shashank Sharma --- drivers/gpu/drm/i9

[Intel-gfx] [v10 01/12] drm: Add HDR source metadata property

2019-05-14 Thread Uma Shankar
This patch adds a blob property to get HDR metadata information from userspace. This will be send as part of AVI Infoframe to panel. It also implements get() and set() functions for HDR output metadata property.The blob data is received from userspace and saved in connector state, the same is retu

[Intel-gfx] [v10 02/12] drm: Add reference counting on HDR metadata blob

2019-05-14 Thread Uma Shankar
From: Jonas Karlman This adds reference count for HDR metadata blob, handled as part of duplicate and destroy connector state functions. Signed-off-by: Jonas Karlman Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_atomic_state_helper.c | 6 ++ 1 file changed, 6 insertions(+) diff --gi

[Intel-gfx] [v10 06/12] drm/i915: Write HDR infoframe and send to panel

2019-05-14 Thread Uma Shankar
Enable writing of HDR metadata infoframe to panel. The data will be provid by usersapace compositors, based on blending policies and passsed to driver through a blob property. v2: Rebase v3: Fixed a warning message v4: Addressed Shashank's review comments v5: Rebase. Added infoframe calculation

[Intel-gfx] [v10 05/12] drm/i915: Attach HDR metadata property to connector

2019-05-14 Thread Uma Shankar
Attach HDR metadata property to connector object. v2: Rebase v3: Updated the property name as per updated name while creating hdr metadata property Signed-off-by: Uma Shankar Reviewed-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_hdmi.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Intel-gfx] [v10 00/12] Add HDR Metadata Parsing and handling in DRM layer

2019-05-14 Thread Uma Shankar
This patch series enables HDR support in drm. It basically defines HDR metadata structures, property to pass content (after blending) metadata from user space compositors to driver. Dynamic Range and Mastering infoframe creation and sending. ToDo: 1. We need to get the color framework in place fo

[Intel-gfx] [v10 03/12] drm: Parse HDR metadata info from EDID

2019-05-14 Thread Uma Shankar
HDR metadata block is introduced in CEA-861.3 spec. Parsing the same to get the panel's HDR metadata. v2: Rebase and added Ville's POC changes to the patch. v3: No Change v4: Addressed Shashank's review comments v5: Addressed Shashank's comment and added his RB. v6: Addressed Jonas Karlman rev

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Re-add enable_rc6 modparam

2019-05-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Re-add enable_rc6 modparam URL : https://patchwork.freedesktop.org/series/60637/ State : warning == Summary == $ dim checkpatch origin/drm-tip 14d287f37981 drm/i915: Re-add enable_rc6 modparam -:25: CHECK:PARENTHESIS_ALIGNMENT:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Extend reset modparam to domain resets

2019-05-14 Thread Summers, Stuart
On Tue, 2019-05-14 at 17:54 +0100, Chris Wilson wrote: > Quoting Stuart Summers (2019-05-14 17:46:53) > > In the event a platform does not properly implement reset, > > Then don't enable reset. Hey Chris, I'm not sure I fully understand your comment here. The module parameter is there to do just

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

2019-05-14 Thread Chris Wilson
Quoting Stuart Summers (2019-05-14 17:46:52) > To allow easier debug of platforms which do not fully support > power-saving render C-state 6, add back the module parameter > to allow RC6 flows to be disabled. Instead of directly affecting > the RC6 states via a bitmask as done previously, use this

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Extend reset modparam to domain resets

2019-05-14 Thread Chris Wilson
Quoting Stuart Summers (2019-05-14 17:46:53) > In the event a platform does not properly implement reset, Then don't enable reset. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 2/2] drm/i915: Extend reset modparam to domain resets

2019-05-14 Thread Stuart Summers
In the event a platform does not properly implement reset, do not go through reset flows for engine domains to avoid an unlikely situation where writes are accepted but register values are never cleared, as this can result in GPU wedges in these cases. Signed-off-by: Stuart Summers --- drivers/g

[Intel-gfx] [PATCH 1/2] drm/i915: Re-add enable_rc6 modparam

2019-05-14 Thread Stuart Summers
To allow easier debug of platforms which do not fully support power-saving render C-state 6, add back the module parameter to allow RC6 flows to be disabled. Instead of directly affecting the RC6 states via a bitmask as done previously, use this module parameter to clear the has_rc6 field for these

Re: [Intel-gfx] [v9 10/13] drm/i915: Set Infoframe for non modeset case for HDR

2019-05-14 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Tuesday, May 14, 2019 1:10 AM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >dcasta...@chromium.org; jo...@kwiboo.se; emil.l.veli...@gmail.com; >seanp...@chro

Re: [Intel-gfx] [v9 12/13] video/hdmi: Add Unpack function for DRM infoframe

2019-05-14 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Ville >Syrjälä >Sent: Tuesday, May 14, 2019 1:20 AM >To: Shankar, Uma >Cc: dcasta...@chromium.org; jo...@kwiboo.se; intel-gfx@lists.freedesktop.org; >emil.l.veli...@gmail.com; dri-de...@l

Re: [Intel-gfx] [v6][PATCH 03/12] drm/i915: Add intel_color_lut_equal() to compare hw and sw gamma/degamma lut values

2019-05-14 Thread Ville Syrjälä
On Tue, May 14, 2019 at 03:13:21PM +0530, Swati Sharma wrote: > v3: -Rebase > v4: -Renamed intel_compare_color_lut() to intel_color_lut_equal() [Jani] > -Added the default label above the correct label [Jani] > -Corrected smatch warn "variable dereferenced before check" [Dan > Carpenter] >

Re: [Intel-gfx] [v6][PATCH 01/12] drm/i915: Introduce vfunc read_luts() to create hw lut

2019-05-14 Thread Ville Syrjälä
On Tue, May 14, 2019 at 03:13:19PM +0530, Swati Sharma wrote: > In this patch, a vfunc read_luts() is introduced to create a hw lut > i.e. lut having values read from gamma/degamma registers which will > later be used to compare with sw lut to validate gamma/degamma lut values. > > v3: -Rebase > v

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: adding state checker for gamma lut values (rev9)

2019-05-14 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev9) URL : https://patchwork.freedesktop.org/series/58039/ State : success == Summary == CI Bug Log - changes from CI_DRM_6080 -> Patchwork_13015 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915: Truly bump ready tasks ahead of busywaits

2019-05-14 Thread Chris Wilson
Quoting Chris Wilson (2019-05-14 09:04:39) > In commit b7404c7ecb38 ("drm/i915: Bump ready tasks ahead of > busywaits"), I tried cutting a corner in order to not install a signal > for each of our dependencies, and only listened to requests on which we > were intending to busywait. The compromise t

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-14 Thread Daniel Vetter
On Tue, May 14, 2019 at 3:36 PM Pekka Paalanen wrote: > > On Tue, 14 May 2019 13:02:09 +0200 > Daniel Vetter wrote: > > > On Tue, May 14, 2019 at 10:18 AM Ser, Simon wrote: > > > > > > On Tue, 2019-05-14 at 11:02 +0300, Pekka Paalanen wrote: > > > > On Mon, 13 May 2019 11:34:58 +0200 > > > > Dan

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: adding state checker for gamma lut values (rev9)

2019-05-14 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev9) URL : https://patchwork.freedesktop.org/series/58039/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Introduce vfunc read_luts() to create hw lut Okay! C

Re: [Intel-gfx] [PATCH v5 00/11] drm/fb-helper: Move modesetting code to drm_client

2019-05-14 Thread Noralf Trønnes
Den 06.05.2019 20.01, skrev Noralf Trønnes: > This moves the modesetting code from drm_fb_helper to drm_client so it > can be shared by all internal clients. > > Changes this time: > - Use restore_fbdev_mode_force() in > drm_fb_helper_restore_fbdev_mode_unlocked() to please igt tests. I'm not

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-14 Thread Daniel Vetter
On Tue, May 14, 2019 at 4:13 PM Paul Kocialkowski wrote: > > Hi, > > On Tue, 2019-05-14 at 13:09 +0200, Daniel Vetter wrote: > > On Mon, May 13, 2019 at 7:14 PM Paul Kocialkowski > > wrote: > > > Hey, > > > > > > Le lundi 13 mai 2019 à 11:34 +0200, Daniel Vetter a écrit : > > > > On Mon, May 13,

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: adding state checker for gamma lut values (rev9)

2019-05-14 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev9) URL : https://patchwork.freedesktop.org/series/58039/ State : warning == Summary == $ dim checkpatch origin/drm-tip cb7a05f563c1 drm/i915: Introduce vfunc read_luts() to create hw lut c687e9d64838 drm/i915:

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: adding state checker for gamma lut values (rev8)

2019-05-14 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev8) URL : https://patchwork.freedesktop.org/series/58039/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6078_full -> Patchwork_13014_full S

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-14 Thread Paul Kocialkowski
Hi, On Tue, 2019-05-14 at 13:09 +0200, Daniel Vetter wrote: > On Mon, May 13, 2019 at 7:14 PM Paul Kocialkowski > wrote: > > Hey, > > > > Le lundi 13 mai 2019 à 11:34 +0200, Daniel Vetter a écrit : > > > On Mon, May 13, 2019 at 11:02 AM Paul Kocialkowski > > > wrote: > > > > Hi, > > > > > > >

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-14 Thread Paul Kocialkowski
Hi, On Tue, 2019-05-14 at 16:36 +0300, Pekka Paalanen wrote: > On Tue, 14 May 2019 13:02:09 +0200 > Daniel Vetter wrote: > > > On Tue, May 14, 2019 at 10:18 AM Ser, Simon wrote: > > > On Tue, 2019-05-14 at 11:02 +0300, Pekka Paalanen wrote: > > > > On Mon, 13 May 2019 11:34:58 +0200 > > > > D

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-14 Thread Pekka Paalanen
On Tue, 14 May 2019 13:02:09 +0200 Daniel Vetter wrote: > On Tue, May 14, 2019 at 10:18 AM Ser, Simon wrote: > > > > On Tue, 2019-05-14 at 11:02 +0300, Pekka Paalanen wrote: > > > On Mon, 13 May 2019 11:34:58 +0200 > > > Daniel Vetter wrote: > > > > > > > On Mon, May 13, 2019 at 11:02 AM Pa

Re: [Intel-gfx] [v9 03/13] drm: Parse HDR metadata info from EDID

2019-05-14 Thread Shankar, Uma
>> >> >-Original Message- >> >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >> >Sent: Tuesday, May 14, 2019 12:49 AM >> >To: Shankar, Uma >> >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >> >dcasta...@chromium.org; jo...@kwiboo.se; emil.l.veli...@gma

Re: [Intel-gfx] [PATCH i-g-t 10/16] i915/gem_exec_whisper: Fork all-engine tests one-per-engine

2019-05-14 Thread Tvrtko Ursulin
On 08/05/2019 11:09, Chris Wilson wrote: Add a new mode for some more stress, submit the all-engines tests simultaneously, a stream per engine. Signed-off-by: Chris Wilson --- tests/i915/gem_exec_whisper.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) d

Re: [Intel-gfx] [PATCH i-g-t 11/16] i915/gem_exec_whisper: debugfs/next_seqno is defunct

2019-05-14 Thread Tvrtko Ursulin
On 08/05/2019 11:09, Chris Wilson wrote: We removed next_seqno in 5.1, so time to wave goodbye. Signed-off-by: Chris Wilson --- tests/i915/gem_exec_whisper.c | 12 1 file changed, 12 deletions(-) diff --git a/tests/i915/gem_exec_whisper.c b/tests/i915/gem_exec_whisper.c index

Re: [Intel-gfx] [PATCH i-g-t 09/16] i915/gem_ctx_switch: Exercise queues

2019-05-14 Thread Tvrtko Ursulin
On 08/05/2019 11:09, Chris Wilson wrote: Queues are a form of contexts that share vm and enfore a single timeline across all engines. Test switching between them, just like ordinary contexts. Signed-off-by: Chris Wilson --- tests/i915/gem_ctx_switch.c | 75 +++

Re: [Intel-gfx] [v9 04/13] drm: Enable HDR infoframe support

2019-05-14 Thread Ville Syrjälä
On Tue, May 14, 2019 at 12:36:25PM +, Kazlauskas, Nicholas wrote: > On 5/8/19 2:38 PM, Uma Shankar wrote: > > [CAUTION: External Email] > > > > Enable Dynamic Range and Mastering Infoframe for HDR > > content, which is defined in CEA 861.3 spec. > > > > The metadata will be computed based on

Re: [Intel-gfx] [v9 03/13] drm: Parse HDR metadata info from EDID

2019-05-14 Thread Ville Syrjälä
On Tue, May 14, 2019 at 09:49:03AM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > >Sent: Tuesday, May 14, 2019 12:49 AM > >To: Shankar, Uma > >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > >dc

Re: [Intel-gfx] [PATCH i-g-t 07/16] i915: Add gem_ctx_clone

2019-05-14 Thread Tvrtko Ursulin
On 08/05/2019 11:09, Chris Wilson wrote: Exercise cloning contexts, an extension of merely creating one. Signed-off-by: Chris Wilson --- tests/Makefile.sources | 1 + tests/i915/gem_ctx_clone.c | 460 + tests/meson.build | 1 + 3 files

Re: [Intel-gfx] [v9 04/13] drm: Enable HDR infoframe support

2019-05-14 Thread Shankar, Uma
>-Original Message- >From: Kazlauskas, Nicholas [mailto:nicholas.kazlaus...@amd.com] >Sent: Tuesday, May 14, 2019 6:06 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; dri- >de...@lists.freedesktop.org >Cc: dcasta...@chromium.org; jo...@kwiboo.se; emil.l.veli...@gmail.com; >seanp..

Re: [Intel-gfx] [v9 04/13] drm: Enable HDR infoframe support

2019-05-14 Thread Kazlauskas, Nicholas
On 5/8/19 2:38 PM, Uma Shankar wrote: > [CAUTION: External Email] > > Enable Dynamic Range and Mastering Infoframe for HDR > content, which is defined in CEA 861.3 spec. > > The metadata will be computed based on blending > policy in userspace compositors and passed as a connector > property blob

[Intel-gfx] ✗ Fi.CI.BAT: failure for benchmarks/gem_wsim: Perturb static_vcs selection across clients

2019-05-14 Thread Patchwork
== Series Details == Series: benchmarks/gem_wsim: Perturb static_vcs selection across clients URL : https://patchwork.freedesktop.org/series/60624/ State : failure == Summary == Series 60624 revision 1 was fully merged or fully failed: no git log __

Re: [Intel-gfx] [PATCH i-g-t 05/16] i915/gem_ctx_create: Basic checks for constructor properties

2019-05-14 Thread Tvrtko Ursulin
On 08/05/2019 11:09, Chris Wilson wrote: Check that the extended create interface accepts setparam. Signed-off-by: Chris Wilson --- tests/i915/gem_ctx_create.c | 225 ++-- 1 file changed, 213 insertions(+), 12 deletions(-) diff --git a/tests/i915/gem_ctx_cre

Re: [Intel-gfx] [PATCH i-g-t v3] benchmarks/gem_wsim: Perturb static_vcs selection across clients

2019-05-14 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-14 12:30:10) > > On 14/05/2019 12:04, Chris Wilson wrote: > > Use the client id to alternate the static_vcs balancer (-b context) > > across clients with the round robin flag (-R) - otherwise all clients > > end up on vcs0 and do not match the context balancing empl

Re: [Intel-gfx] [PATCH i-g-t v3] benchmarks/gem_wsim: Perturb static_vcs selection across clients

2019-05-14 Thread Tvrtko Ursulin
On 14/05/2019 12:04, Chris Wilson wrote: Use the client id to alternate the static_vcs balancer (-b context) across clients with the round robin flag (-R) - otherwise all clients end up on vcs0 and do not match the context balancing employed by media-driver. v2: Put it behind the -R flag. v3: D

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add support for asynchronous display power disabling (rev5)

2019-05-14 Thread Imre Deak
On Tue, May 14, 2019 at 12:06:36AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Add support for asynchronous display power disabling (rev5) > URL : https://patchwork.freedesktop.org/series/60242/ > State : success Pushed to -dinq with a checkpatch w/s and a docbook fix,

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-14 Thread Daniel Vetter
On Mon, May 13, 2019 at 11:20 PM Lyude Paul wrote: > > Hi-just wanted to give some general thoughts here. > > First off I'm 100% behind the epoch idea, that was one of the ideas I had been > thinking of proposing here in the first place but probably forgot at some > point down the road. > > A coup

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-14 Thread Daniel Vetter
On Mon, May 13, 2019 at 7:14 PM Paul Kocialkowski wrote: > > Hey, > > Le lundi 13 mai 2019 à 11:34 +0200, Daniel Vetter a écrit : > > On Mon, May 13, 2019 at 11:02 AM Paul Kocialkowski > > wrote: > > > Hi, > > > > > > On Fri, 2019-05-10 at 16:54 +0200, Daniel Vetter wrote: > > > > On Fri, May 10,

[Intel-gfx] [PATCH i-g-t v3] benchmarks/gem_wsim: Perturb static_vcs selection across clients

2019-05-14 Thread Chris Wilson
Use the client id to alternate the static_vcs balancer (-b context) across clients with the round robin flag (-R) - otherwise all clients end up on vcs0 and do not match the context balancing employed by media-driver. v2: Put it behind the -R flag. v3: Don't skip -R flag for -b context in scripts/

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-14 Thread Daniel Vetter
On Tue, May 14, 2019 at 10:18 AM Ser, Simon wrote: > > On Tue, 2019-05-14 at 11:02 +0300, Pekka Paalanen wrote: > > On Mon, 13 May 2019 11:34:58 +0200 > > Daniel Vetter wrote: > > > > > On Mon, May 13, 2019 at 11:02 AM Paul Kocialkowski > > > wrote: > > > > Hi, > > > > > > > > On Fri, 2019-05-10

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: More workaround for port F detection due to broken VBTs

2019-05-14 Thread Imre Deak
On Fri, May 10, 2019 at 05:34:35PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/icl: More workaround for port F detection due to broken VBTs > URL : https://patchwork.freedesktop.org/series/60508/ > State : success Thanks for the testing and reviews, pushed to -dinq with

[Intel-gfx] [PATCH i-g-t v2] benchmarks/gem_wsim: Perturb static_vcs selection across clients

2019-05-14 Thread Chris Wilson
Use the client id to alternate the static_vcs balancer (-b context) across clients with the round robin flag (-R) - otherwise all clients end up on vcs0 and do not match the context balancing employed by media-driver. v2: Put it behind the -R flag. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: adding state checker for gamma lut values (rev8)

2019-05-14 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev8) URL : https://patchwork.freedesktop.org/series/58039/ State : success == Summary == CI Bug Log - changes from CI_DRM_6078 -> Patchwork_13014 Summary ---

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/gem_wsim: Perturb static_vcs selection across clients

2019-05-14 Thread Tvrtko Ursulin
On 14/05/2019 11:05, Chris Wilson wrote: Use the client id to alternate the static_vcs balancer (-b context) across clients - otherwise all clients end up on vcs0 and do not match the context balancing employed by media-driver. This may want to be behind the -R flag, but I felt it was a fundame

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: adding state checker for gamma lut values (rev8)

2019-05-14 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev8) URL : https://patchwork.freedesktop.org/series/58039/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Introduce vfunc read_luts() to create hw lut Okay! C

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: adding state checker for gamma lut values (rev8)

2019-05-14 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev8) URL : https://patchwork.freedesktop.org/series/58039/ State : warning == Summary == $ dim checkpatch origin/drm-tip 12495d94dac5 drm/i915: Introduce vfunc read_luts() to create hw lut 316533acb64b drm/i915:

Re: [Intel-gfx] [v9 06/13] drm/i915: Write HDR infoframe and send to panel

2019-05-14 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Tuesday, May 14, 2019 1:06 AM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >dcasta...@chromium.org; jo...@kwiboo.se; emil.l.veli...@gmail.com; >seanp...@chro

Re: [Intel-gfx] [PATCH i-g-t 05/16] i915/gem_ctx_create: Basic checks for constructor properties

2019-05-14 Thread Tvrtko Ursulin
On 08/05/2019 11:09, Chris Wilson wrote: Check that the extended create interface accepts setparam. Signed-off-by: Chris Wilson --- tests/i915/gem_ctx_create.c | 225 ++-- 1 file changed, 213 insertions(+), 12 deletions(-) diff --git a/tests/i915/gem_ctx_cre

[Intel-gfx] [PATCH i-g-t] benchmarks/gem_wsim: Perturb static_vcs selection across clients

2019-05-14 Thread Chris Wilson
Use the client id to alternate the static_vcs balancer (-b context) across clients - otherwise all clients end up on vcs0 and do not match the context balancing employed by media-driver. This may want to be behind the -R flag, but I felt it was a fundamental property of static context balancing th

Re: [Intel-gfx] [v9 03/13] drm: Parse HDR metadata info from EDID

2019-05-14 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Tuesday, May 14, 2019 12:49 AM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >dcasta...@chromium.org; jo...@kwiboo.se; emil.l.veli...@gmail.com; >seanp...@chr

[Intel-gfx] [v6][PATCH 10/12] drm/i915: Extract ivb_read_luts()

2019-05-14 Thread Swati Sharma
In this patch, gamma and degamma hw blobs are created for IVB. v4: -No need to initialize *blob [Jani] -Removed right shifts [Jani] -Dropped dev local var [Jani] v5: -Returned blob instead of assigning it internally within the function [Ville] -Renamed ivb_get_color_config() to iv

[Intel-gfx] [v6][PATCH 08/12] drm/i915: Extract glk_read_luts()

2019-05-14 Thread Swati Sharma
In this patch, gamma and degamma hw blobs are created for GLK. v4: -No need to initialize *blob [Jani] -Removed right shifts [Jani] -Dropped dev local var [Jani] v5: -Returned blob instead of assigning it internally within the function [Ville] -Renamed glk_get_color_config() to gl

[Intel-gfx] [v6][PATCH 12/12] FOR_TESTING_ONLY: Print rgb values of hw and sw blobs

2019-05-14 Thread Swati Sharma
Signed-off-by: Swati Sharma --- drivers/gpu/drm/i915/intel_color.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index 6bbc99a..3d9e375 100644 --- a/drivers/gpu/drm/i915/intel_color.c +++ b/drivers/gpu/drm/i915/intel

[Intel-gfx] [v6][PATCH 07/12] drm/i915: Extract icl_read_luts()

2019-05-14 Thread Swati Sharma
In this patch, gamma hw blobs are created for ICL. v4: -No need to initialize *blob [Jani] -Removed right shifts [Jani] -Dropped dev local var [Jani] v5: -Returned blob instead of assigning it internally within the function [Ville] -Renamed icl_get_color_config() to icl_read_luts(

[Intel-gfx] [v6][PATCH 06/12] drm/i915: Extract i965_read_luts()

2019-05-14 Thread Swati Sharma
In this patch, hw gamma blob is created for i965. v4: -No need to initialize *blob [Jani] -Removed right shifts [Jani] -Dropped dev local var [Jani] v5: -Returned blob instead of assigning it internally within the function [Ville] -Renamed i965_get_color_config() to i965_read_lut(

[Intel-gfx] [v6][PATCH 11/12] drm/i915: Extract ilk_read_luts()

2019-05-14 Thread Swati Sharma
In this patch, hw gamma blob is created for ILK. v4: -No need to initialize *blob [Jani] -Removed right shifts [Jani] -Dropped dev local var [Jani] v5: -Returned blob instead of assigning it internally within the function [Ville] -Renamed ilk_get_color_config() to ilk_read_luts()

[Intel-gfx] [v6][PATCH 05/12] drm/i915: Extract chv_read_luts()

2019-05-14 Thread Swati Sharma
In this patch, hw gamma and degamma blob is created for cherryview. v4: -No need to initialize *blob [Jani] -Removed right shifts [Jani] -Dropped dev local var [Jani] v5: -Returned blob instead of assigning it internally within the function [Ville] -Renamed function cherryvi

[Intel-gfx] [v6][PATCH 09/12] drm/i915: Extract bdw_read_luts()

2019-05-14 Thread Swati Sharma
In this patch, gamma and degamma hw blobs are created for BDW. v4: -No need to initialize *blob [Jani] -Removed right shifts [Jani] -Dropped dev local var [Jani] v5: -Returned blob instead of assigning it internally within the function [Ville] -Renamed bdw_get_color_config() to bd

[Intel-gfx] [v6][PATCH 01/12] drm/i915: Introduce vfunc read_luts() to create hw lut

2019-05-14 Thread Swati Sharma
In this patch, a vfunc read_luts() is introduced to create a hw lut i.e. lut having values read from gamma/degamma registers which will later be used to compare with sw lut to validate gamma/degamma lut values. v3: -Rebase v4: -Renamed intel_get_color_config to intel_color_get_config [Jani] -W

[Intel-gfx] [v6][PATCH 02/12] drm/i915: Enable intel_color_get_config()

2019-05-14 Thread Swati Sharma
In this patch, intel_color_get_config() is enabled and support for read_luts() will be added platform by platform incrementally in the follow-up patches. v4: -Renamed intel_get_color_config to intel_color_get_config [Jani] -Added the user early on such that support for get_color_config()

[Intel-gfx] [v6][PATCH 04/12] drm/i915: Extract i9xx_read_luts()

2019-05-14 Thread Swati Sharma
In this patch, hw gamma blob is created for the legacy gamma. Also, function intel_color_lut_pack is added to convert hw value with given bit_precision to lut property val. v4: -No need to initialize *blob [Jani] -Removed right shifts [Jani] -Dropped dev local var [Jani] v5: -Returned blob

Re: [Intel-gfx] [PATCH i-g-t 04/16] i915/gem_ctx_param: Test set/get (copy) VM

2019-05-14 Thread Tvrtko Ursulin
On 08/05/2019 11:09, Chris Wilson wrote: Exercise reusing the GTT of one ctx in another. v2: Test setting back to the same VM v3: Check the VM still exists after the parent ctx are dead. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/i915/gem_ctx_param.c | 107 +++

[Intel-gfx] [PATCH 00/12] drm/i915: adding state checker for gamma lut values

2019-05-14 Thread Swati Sharma
In this patch series, added state checker to validate gamma and will be extended to validate degamma lut values aswell. This reads hardware state, and compares the originally requested state to the state read from hardware. v1: -Implementation done for legacy platforms (removed all the placeh

  1   2   >