Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen11: enable support for headerless msgs (rev4)

2019-05-07 Thread Peres, Martin
On 06/05/2019 23:30, Kim, Dongwon wrote: > This doesn't seem to be a valid failure. I just reran the test using > trybot and there were no failures. > > https://lists.freedesktop.org/archives/intel-gfx-trybot/2019-May/071989.html I reported this bug two days ago and added it to cibuglog, this is

Re: [Intel-gfx] [PATCH] drm/i915: Engine relative MMIO

2019-05-07 Thread Rodrigo Vivi
On Tue, May 07, 2019 at 11:55:11AM -0700, John Harrison wrote: > On 5/6/2019 14:36, Rodrigo Vivi wrote: > > On Tue, Apr 23, 2019 at 06:50:13PM -0700, john.c.harri...@intel.com wrote: > > > From: John Harrison > > > > > > With virtual engines, it is no longer possible to know which specific > > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/icl: Fix setting 10 bit deep color mode (rev3)

2019-05-07 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix setting 10 bit deep color mode (rev3) URL : https://patchwork.freedesktop.org/series/60080/ State : success == Summary == CI Bug Log - changes from CI_DRM_6062_full -> Patchwork_12982_full Summ

[Intel-gfx] ✓ Fi.CI.IGT: success for RFC: x86/smp: use printk_deferred in native_smp_send_reschedule

2019-05-07 Thread Patchwork
== Series Details == Series: RFC: x86/smp: use printk_deferred in native_smp_send_reschedule URL : https://patchwork.freedesktop.org/series/60384/ State : success == Summary == CI Bug Log - changes from CI_DRM_6061_full -> Patchwork_12981_full ==

[Intel-gfx] ✓ Fi.CI.IGT: success for HDCP2.2 Phase II (rev9)

2019-05-07 Thread Patchwork
== Series Details == Series: HDCP2.2 Phase II (rev9) URL : https://patchwork.freedesktop.org/series/57232/ State : success == Summary == CI Bug Log - changes from CI_DRM_6060_full -> Patchwork_12980_full Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.IGT: success for Enable Multi-segmented-gamma for ICL (rev2)

2019-05-07 Thread Patchwork
== Series Details == Series: Enable Multi-segmented-gamma for ICL (rev2) URL : https://patchwork.freedesktop.org/series/60126/ State : success == Summary == CI Bug Log - changes from CI_DRM_6059_full -> Patchwork_12979_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Don't apply priority boost for resets

2019-05-07 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Don't apply priority boost for resets URL : https://patchwork.freedesktop.org/series/60369/ State : success == Summary == CI Bug Log - changes from CI_DRM_6059_full -> Patchwork_12978_full Su

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-05-07 Thread Daniele Ceraolo Spurio
--- a/drivers/gpu/drm/i915/intel_device_info.c +++ b/drivers/gpu/drm/i915/intel_device_info.c @@ -84,17 +84,46 @@ void intel_device_info_dump_flags(const struct intel_device_info *info, #undef PRINT_FLAG } +#define SS_STR_MAX_SIZE (GEN_MAX_SUBSLICE_STRIDE * 2 + 1) + +static char *

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-05-07 Thread Summers, Stuart
On Tue, 2019-05-07 at 14:16 -0700, Daniele Ceraolo Spurio wrote: > > > > > > > > > --- a/drivers/gpu/drm/i915/intel_device_info.c > > > > +++ b/drivers/gpu/drm/i915/intel_device_info.c > > > > @@ -84,17 +84,46 @@ void intel_device_info_dump_flags(const > > > > struct > > > > intel_device_info *i

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-05-07 Thread Summers, Stuart
On Tue, 2019-05-07 at 12:00 -0700, Daniele Ceraolo Spurio wrote: > > On 5/3/19 2:30 PM, Stuart Summers wrote: > > Currently, the subslice_mask runtime parameter is stored as an > > array of subslices per slice. Expand the subslice mask array to > > better match what is presented to userspace throu

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Only reschedule the submission tasklet if preemption is possible

2019-05-07 Thread Patchwork
== Series Details == Series: drm/i915: Only reschedule the submission tasklet if preemption is possible URL : https://patchwork.freedesktop.org/series/60368/ State : success == Summary == CI Bug Log - changes from CI_DRM_6059_full -> Patchwork_12977_full ==

Re: [Intel-gfx] [RFC PATCH 0/5] cgroup support for GPU devices

2019-05-07 Thread Welty, Brian
On 5/6/2019 8:26 AM, Tejun Heo wrote: > Hello, > > On Wed, May 01, 2019 at 10:04:33AM -0400, Brian Welty wrote: >> The patch series enables device drivers to use cgroups to control the >> following resources within a GPU (or other accelerator device): >> * control allocation of device memory (re

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Fix setting 10 bit deep color mode (rev3)

2019-05-07 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix setting 10 bit deep color mode (rev3) URL : https://patchwork.freedesktop.org/series/60080/ State : success == Summary == CI Bug Log - changes from CI_DRM_6062 -> Patchwork_12982 Summary --

Re: [Intel-gfx] [PATCH] drm/i915: Engine relative MMIO

2019-05-07 Thread John Harrison
On 5/6/2019 14:36, Rodrigo Vivi wrote: On Tue, Apr 23, 2019 at 06:50:13PM -0700, john.c.harri...@intel.com wrote: From: John Harrison With virtual engines, it is no longer possible to know which specific physical engine a given request will be executed on at the time that request is generated.

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Expand subslice mask

2019-05-07 Thread Daniele Ceraolo Spurio
On 5/3/19 2:30 PM, Stuart Summers wrote: Currently, the subslice_mask runtime parameter is stored as an array of subslices per slice. Expand the subslice mask array to better match what is presented to userspace through the I915_QUERY_TOPOLOGY_INFO ioctl. The index into this array is then calcu

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: Flush the switch-to-kernel-context harder for DROP_IDLE

2019-05-07 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Flush the switch-to-kernel-context harder for DROP_IDLE URL : https://patchwork.freedesktop.org/series/60367/ State : success == Summary == CI Bug Log - changes from CI_DRM_6058_full -> Patchwork_12976_full

Re: [Intel-gfx] [PATCH v2] drm/i915/icl: Fix setting 10 bit deep color mode

2019-05-07 Thread Ville Syrjälä
On Tue, May 07, 2019 at 11:18:56AM -0700, Aditya Swarup wrote: > There is a bug in hdmi_deep_color_possible() - we compare pipe_bpp > <= 8*3 which returns true every time for hdmi_deep_color_possible 12 bit > deep color mode test in intel_hdmi_compute_config().(Even when the > requested color mode

[Intel-gfx] ✓ Fi.CI.BAT: success for RFC: x86/smp: use printk_deferred in native_smp_send_reschedule

2019-05-07 Thread Patchwork
== Series Details == Series: RFC: x86/smp: use printk_deferred in native_smp_send_reschedule URL : https://patchwork.freedesktop.org/series/60384/ State : success == Summary == CI Bug Log - changes from CI_DRM_6061 -> Patchwork_12981 Summar

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Fix fastset vs. pfit on/off on HSW EDP transcoder

2019-05-07 Thread Ville Syrjälä
On Thu, Apr 25, 2019 at 07:29:05PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > On HSW the pipe A panel fitter lives inside the display power well, > and the input MUX for the EDP transcoder needs to be configured > appropriately to route the data through the power well as needed. > Chan

[Intel-gfx] [PATCH v2] drm/i915/icl: Fix setting 10 bit deep color mode

2019-05-07 Thread Aditya Swarup
There is a bug in hdmi_deep_color_possible() - we compare pipe_bpp <= 8*3 which returns true every time for hdmi_deep_color_possible 12 bit deep color mode test in intel_hdmi_compute_config().(Even when the requested color mode is 10 bit through max bpc property) Comparing pipe_bpp with bpc * 3 ta

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Refactor sseu helper functions

2019-05-07 Thread Summers, Stuart
On Tue, 2019-05-07 at 11:12 -0700, Daniele Ceraolo Spurio wrote: > > On 5/3/19 2:30 PM, Stuart Summers wrote: > > Move functions to intel_sseu.h and remove inline qualifier. > > Additionally, ensure these are all prefixed with intel_sseu_* > > to match the convention of other functions in i915. >

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Refactor sseu helper functions

2019-05-07 Thread Daniele Ceraolo Spurio
On 5/3/19 2:30 PM, Stuart Summers wrote: Move functions to intel_sseu.h and remove inline qualifier. Additionally, ensure these are all prefixed with intel_sseu_* to match the convention of other functions in i915. v2: fix spacing from checkpatch warning v3: squash helper function changes into

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for RFC: x86/smp: use printk_deferred in native_smp_send_reschedule

2019-05-07 Thread Patchwork
== Series Details == Series: RFC: x86/smp: use printk_deferred in native_smp_send_reschedule URL : https://patchwork.freedesktop.org/series/60384/ State : warning == Summary == $ dim checkpatch origin/drm-tip 79bd449b8e2d RFC: x86/smp: use printk_deferred in native_smp_send_reschedule -:93: WA

[Intel-gfx] ✓ Fi.CI.BAT: success for HDCP2.2 Phase II (rev9)

2019-05-07 Thread Patchwork
== Series Details == Series: HDCP2.2 Phase II (rev9) URL : https://patchwork.freedesktop.org/series/57232/ State : success == Summary == CI Bug Log - changes from CI_DRM_6060 -> Patchwork_12980 Summary --- **SUCCESS** No regressio

[Intel-gfx] [PATCH] RFC: x86/smp: use printk_deferred in native_smp_send_reschedule

2019-05-07 Thread Daniel Vetter
console_trylock, called from within printk, can be called from pretty much anywhere. Including try_to_wake_up. Note that this isn't common, usually the box is in pretty bad shape at that point already. But it really doesn't help when then lockdep jumps in and spams the logs, potentially obscuring t

Re: [Intel-gfx] [PATCH 20/45] drm/i915: Apply an execution_mask to the virtual_engine

2019-05-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-04-29 15:12:23) > > On 25/04/2019 10:19, Chris Wilson wrote: > > static void virtual_submission_tasklet(unsigned long data) > > { > > struct virtual_engine * const ve = (struct virtual_engine *)data; > > const int prio = ve->base.execlists.queue_priorit

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for HDCP2.2 Phase II (rev9)

2019-05-07 Thread Patchwork
== Series Details == Series: HDCP2.2 Phase II (rev9) URL : https://patchwork.freedesktop.org/series/57232/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm: move content protection property to mode_config Okay! Commit: drm/i915: debugfs: HDCP2.2 cap

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for HDCP2.2 Phase II (rev9)

2019-05-07 Thread Patchwork
== Series Details == Series: HDCP2.2 Phase II (rev9) URL : https://patchwork.freedesktop.org/series/57232/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2c27a886355d drm: move content protection property to mode_config 95b249c75379 drm/i915: debugfs: HDCP2.2 capability read 896

[Intel-gfx] [PATCH v7 11/11] drm/i915: update the hdcp state with uevent

2019-05-07 Thread Ramalingam C
drm function to update the content protection property state and to generate a uevent is invoked from the intel hdcp property work. Hence whenever kernel changes the property state, userspace will be updated with a uevent. Need a ACK for uevent generating uAPI from userspace. v2: state update

[Intel-gfx] [PATCH v7 08/11] drm/i915: Attach content type property

2019-05-07 Thread Ramalingam C
Attaches the content type property for HDCP2.2 capable connectors. Implements the update of content type from property and apply the restriction on HDCP version selection. Need ACK for content type property from userspace consumer. v2: s/cp_content_type/content_protection_type [daniel] disab

[Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-05-07 Thread Ramalingam C
DRM API for generating uevent for a status changes of connector's property. This uevent will have following details related to the status change: HOTPLUG=1, CONNECTOR= and PROPERTY= Need ACK from this uevent from userspace consumer. v2: Minor fixes at KDoc comments [Daniel] v3: Check the

[Intel-gfx] [PATCH v7 01/11] drm: move content protection property to mode_config

2019-05-07 Thread Ramalingam C
Content protection property is created once and stored in drm_mode_config. And attached to all HDCP capable connectors. Signed-off-by: Ramalingam C Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic_uapi.c | 4 ++-- drivers/gpu/drm/drm_connector.c | 13 +++-- include/drm/drm_c

[Intel-gfx] [PATCH v7 03/11] drm: generic fn converting be24 to cpu and vice versa

2019-05-07 Thread Ramalingam C
Existing functions for converting a 3bytes(be24) of big endian value into u32 of little endian and vice versa are renamed as s/drm_hdcp2_seq_num_to_u32/drm_hdcp_be24_to_cpu s/drm_hdcp2_u32_to_seq_num/drm_hdcp_cpu_to_be24 Signed-off-by: Ramalingam C Suggested-by: Daniel Vetter cc: Tomas Winkler

[Intel-gfx] [PATCH v7 00/11] HDCP2.2 Phase II

2019-05-07 Thread Ramalingam C
This series adds the content type capability for HDCP through a drm connetor proeprty "HDCP Content Type". By default this property will be "Type 0". And this property is exposed by the drivers which has the HDCP2.2 capability to enable the userspace to configure for "Type 1". HDCP Content Type:

[Intel-gfx] [PATCH v7 02/11] drm/i915: debugfs: HDCP2.2 capability read

2019-05-07 Thread Ramalingam C
Adding the HDCP2.2 capability of HDCP src and sink info into debugfs entry "i915_hdcp_sink_capability" This helps the userspace tests to skip the HDCP2.2 test on non HDCP2.2 sinks. v2: Rebased. Signed-off-by: Ramalingam C Reviewed-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_debugfs.c |

[Intel-gfx] [PATCH v7 10/11] drm/hdcp: update content protection property with uevent

2019-05-07 Thread Ramalingam C
drm function is defined and exported to update a connector's content protection property state and to generate a uevent along with it. Need ACK for the uevent from userspace consumer. v2: Update only when state is different from old one. v3: KDoc is added [Daniel] Signed-off-by: Ramalingam C

[Intel-gfx] [PATCH v7 05/11] drm/i915: SRM revocation check for HDCP1.4 and 2.2

2019-05-07 Thread Ramalingam C
DRM HDCP SRM revocation check services are used from I915 for HDCP1.4 and 2.2 revocation check during the respective authentication flow. v2: Rebased. v3: %s/*_ksvs_revocated/*_check_ksvs_revoked [Daniel] unwanted noise is removed. Signed-off-by: Ramalingam C Reviewed-by: Daniel Vetter --

[Intel-gfx] [PATCH v7 07/11] drm: Add Content protection type property

2019-05-07 Thread Ramalingam C
This patch adds a DRM ENUM property to the selected connectors. This property is used for mentioning the protected content's type from userspace to kernel HDCP authentication. Type of the stream is decided by the protected content providers. Type 0 content can be rendered on any HDCP protected dis

[Intel-gfx] [PATCH v7 06/11] drm/hdcp: gathering hdcp related code into drm_hdcp.c

2019-05-07 Thread Ramalingam C
Considering the significant size of hdcp related code in drm, all hdcp related codes are moved into separate file called drm_hdcp.c. v2: Rebased. v2: Rebased. Signed-off-by: Ramalingam C Suggested-by: Daniel Vetter Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_connector.c | 44 --

[Intel-gfx] [PATCH v7 04/11] drm: revocation check at drm subsystem

2019-05-07 Thread Ramalingam C
On every hdcp revocation check request SRM is read from fw file /lib/firmware/display_hdcp_srm.bin SRM table is parsed and stored at drm_hdcp.c, with functions exported for the services for revocation check from drivers (which implements the HDCP authentication) This patch handles the HDCP1.4 and

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable Multi-segmented-gamma for ICL (rev2)

2019-05-07 Thread Patchwork
== Series Details == Series: Enable Multi-segmented-gamma for ICL (rev2) URL : https://patchwork.freedesktop.org/series/60126/ State : success == Summary == CI Bug Log - changes from CI_DRM_6059 -> Patchwork_12979 Summary --- **SUCCE

Re: [Intel-gfx] [PATCH] drm/i915/icl: Handle YCbCr to RGB conversion for BT2020 case

2019-05-07 Thread Ville Syrjälä
On Tue, May 07, 2019 at 02:35:15PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > >Of Ville > >Syrjälä > >Sent: Tuesday, May 7, 2019 7:37 PM > >To: Sharma, Shashank > >Cc: intel-gfx@lists.freedesktop.o

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Don't apply priority boost for resets

2019-05-07 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Don't apply priority boost for resets URL : https://patchwork.freedesktop.org/series/60369/ State : success == Summary == CI Bug Log - changes from CI_DRM_6059 -> Patchwork_12978 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Only reschedule the submission tasklet if preemption is possible

2019-05-07 Thread Patchwork
== Series Details == Series: drm/i915: Only reschedule the submission tasklet if preemption is possible URL : https://patchwork.freedesktop.org/series/60368/ State : success == Summary == CI Bug Log - changes from CI_DRM_6059 -> Patchwork_12977

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: disable framebuffer compression on GeminiLake (rev2)

2019-05-07 Thread Patchwork
== Series Details == Series: i915: disable framebuffer compression on GeminiLake (rev2) URL : https://patchwork.freedesktop.org/series/60090/ State : success == Summary == CI Bug Log - changes from CI_DRM_6055_full -> Patchwork_12974_full S

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Flush the switch-to-kernel-context harder for DROP_IDLE

2019-05-07 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Flush the switch-to-kernel-context harder for DROP_IDLE URL : https://patchwork.freedesktop.org/series/60367/ State : success == Summary == CI Bug Log - changes from CI_DRM_6058 -> Patchwork_12976 ==

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Bump signaler priority on adding a waiter

2019-05-07 Thread Chris Wilson
Quoting Chris Wilson (2019-05-07 14:14:01) > Quoting Tvrtko Ursulin (2019-05-07 13:46:45) > > > > On 03/05/2019 12:52, Chris Wilson wrote: > > > diff --git a/drivers/gpu/drm/i915/i915_scheduler.c > > > b/drivers/gpu/drm/i915/i915_scheduler.c > > > index 380cb7343a10..ff0ca5718f97 100644 > > > ---

Re: [Intel-gfx] [PATCH] drm/i915/icl: Handle YCbCr to RGB conversion for BT2020 case

2019-05-07 Thread Shankar, Uma
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Ville >Syrjälä >Sent: Tuesday, May 7, 2019 7:37 PM >To: Sharma, Shashank >Cc: intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH] drm/i915/icl: Handle YCbCr to RGB conversio

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Bump signaler priority on adding a waiter

2019-05-07 Thread Tvrtko Ursulin
On 07/05/2019 14:14, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-05-07 13:46:45) On 03/05/2019 12:52, Chris Wilson wrote: The handling of the no-preemption priority level imposes the restriction that we need to maintain the implied ordering even though preemption is disabled. Otherwise w

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Only reschedule the submission tasklet if preemption is possible

2019-05-07 Thread Patchwork
== Series Details == Series: drm/i915: Only reschedule the submission tasklet if preemption is possible URL : https://patchwork.freedesktop.org/series/60368/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Only reschedule the submission taskl

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915/icl: Add Multi-segmented gamma support

2019-05-07 Thread Ville Syrjälä
On Tue, May 07, 2019 at 07:26:44PM +0530, Shashank Sharma wrote: > ICL introduces a new gamma correction mode in display engine, called > multi-segmented-gamma mode. This mode allows users to program the > darker region of the gamma curve with sueprfine precision. An > example use case for this is

[Intel-gfx] [PATCH v3 3/4] drm/i915: Rename ivb_load_lut_10_max

2019-05-07 Thread Shashank Sharma
This patch renames function ivb_load_lut_10_max to ivb_load_lut_ext_max. V3: Added Vill'es r-b. Cc: Uma Shankar Suggested-by: Ville Syrjala Reviewed-by: Ville Syrjala Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_color.c | 14 +++--- 1 file changed, 7 insertions(+),

[Intel-gfx] [PATCH v3 2/4] drm/i915/icl: Add register definitions for Multi Segmented gamma

2019-05-07 Thread Shashank Sharma
From: Uma Shankar Add macros to define multi segmented gamma registers V2: Addressed Ville's comments: Add gen-lable before bit definition Addressed Jani's comment - Use REG_GENMASK() and REG_BIT() V3: Addressed Ville's comments: - Put comments at the end of line. - C

[Intel-gfx] [PATCH v3 0/4] Enable Multi-segmented-gamma for ICL

2019-05-07 Thread Shashank Sharma
This patch series enables programming of Multi-segmented-gamma palette for ICL. Shashank Sharma (3): drm/i915: Change gamma/degamma_lut_size data type to u32 drm/i915: Rename ivb_load_lut_10_max drm/i915/icl: Add Multi-segmented gamma support Uma Shankar (1): drm/i915/icl: Add register de

Re: [Intel-gfx] [PATCH] drm/i915/icl: Handle YCbCr to RGB conversion for BT2020 case

2019-05-07 Thread Ville Syrjälä
On Tue, May 07, 2019 at 06:32:57PM +0530, Shashank Sharma wrote: > From: Uma Shankar > > Currently input csc for YCbCR to RGB conversion handles only > BT601 and Bt709. Extending it to support BT2020 as well. > > Signed-off-by: Uma Shankar > Signed-off-by: Shashank Sharma > --- > drivers/gpu/

Re: [Intel-gfx] [PATCH 01/10] drm/i915: Add support for tracking wakerefs w/o power-on guarantee

2019-05-07 Thread Chris Wilson
Quoting Imre Deak (2019-05-03 00:26:39) > @@ -4521,12 +4602,12 @@ void intel_runtime_pm_cleanup(struct drm_i915_private > *i915) > struct i915_runtime_pm *rpm = &i915->runtime_pm; > int count; > > - count = atomic_fetch_inc(&rpm->wakeref_count); /* balance untrack */ > +

[Intel-gfx] [PATCH v3 4/4] drm/i915/icl: Add Multi-segmented gamma support

2019-05-07 Thread Shashank Sharma
ICL introduces a new gamma correction mode in display engine, called multi-segmented-gamma mode. This mode allows users to program the darker region of the gamma curve with sueprfine precision. An example use case for this is HDR curves (like PQ ST-2084). If we plot a gamma correction curve from v

[Intel-gfx] [PATCH v3 1/4] drm/i915: Change gamma/degamma_lut_size data type to u32

2019-05-07 Thread Shashank Sharma
Currently, data type of gamma_lut_size & degamma_lut_size elements in intel_device_info is u16, which means it can accommodate maximum 64k values. In case of ICL multisegmented gamma, the size of gamma LUT is 256K. This patch changes the data type of both of these elements to u32. Cc: Ville Syrjä

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915: Flush the switch-to-kernel-context harder for DROP_IDLE

2019-05-07 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Flush the switch-to-kernel-context harder for DROP_IDLE URL : https://patchwork.freedesktop.org/series/60367/ State : warning == Summary == $ dim checkpatch origin/drm-tip 76031545f275 drm/i915: Flush the switch-to-kernel-conte

Re: [Intel-gfx] [v8 02/10] drm: Parse HDR metadata info from EDID

2019-05-07 Thread Kazlauskas, Nicholas
On 4/9/19 12:44 PM, Uma Shankar wrote: > HDR metadata block is introduced in CEA-861.3 spec. > Parsing the same to get the panel's HDR metadata. > > v2: Rebase and added Ville's POC changes to the patch. > > v3: No Change > > v4: Addressed Shashank's review comments > > v5: Addressed Shashank's

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Bump signaler priority on adding a waiter

2019-05-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-07 13:46:45) > > On 03/05/2019 12:52, Chris Wilson wrote: > > The handling of the no-preemption priority level imposes the restriction > > that we need to maintain the implied ordering even though preemption is > > disabled. Otherwise we may end up with an AB-BA dea

[Intel-gfx] [PATCH v3 1/2] drm/i915/GLK: Properly handle plane CSC for BT2020 framebuffers

2019-05-07 Thread Shashank Sharma
Framebuffer formats P01x are supported by GLK, but the function which handles CSC on plane color control register, still expectes the input buffer to be REC709. This can cause inaccurate output for direct P01x flips. This patch checks if the color_encoding property is set to YCBCR_2020, and enable

[Intel-gfx] [PATCH] drm/i915/icl: Handle YCbCr to RGB conversion for BT2020 case

2019-05-07 Thread Shashank Sharma
From: Uma Shankar Currently input csc for YCbCR to RGB conversion handles only BT601 and Bt709. Extending it to support BT2020 as well. Signed-off-by: Uma Shankar Signed-off-by: Shashank Sharma --- drivers/gpu/drm/i915/intel_sprite.c | 24 1 file changed, 24 insertion

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Bump signaler priority on adding a waiter

2019-05-07 Thread Tvrtko Ursulin
On 03/05/2019 12:52, Chris Wilson wrote: The handling of the no-preemption priority level imposes the restriction that we need to maintain the implied ordering even though preemption is disabled. Otherwise we may end up with an AB-BA deadlock across multiple engine due to a real preemption event

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-07 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range URL : https://patchwork.freedesktop.org/series/60364/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6057 -> Patchwork_12975 ===

Re: [Intel-gfx] [PULL] gvt-next-fixes

2019-05-07 Thread Joonas Lahtinen
Thanks, pulled this now. Regards, Joonas Quoting Zhenyu Wang (2019-05-07 12:05:58) > > Hi, > > Here's gvt-next-fixes for 5.2-rc, which includes one revert for BXT > regression, one missed context mmio reg after RCS renaming, sanitize > display buffer size calculation and some klocwork warning/e

[Intel-gfx] [CI] drm/i915/execlists: Don't apply priority boost for resets

2019-05-07 Thread Chris Wilson
Do not treat reset as a normal preemption event and avoid giving the guilty request a priority boost for simply being active at the time of reset. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/gt/intel_lrc.c | 16 +--- 1 file changed, 9 insertions(

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Flush the switch-to-kernel-context harder for DROP_IDLE

2019-05-07 Thread Tvrtko Ursulin
On 07/05/2019 13:11, Chris Wilson wrote: To complete the idle worker, we must complete 2 passes of wait-for-idle. At the end of the first pass, we queue a switch-to-kernel-context and may only idle after waiting for its completion. Speed up the flush_work by doing the wait explicitly, which then

Re: [Intel-gfx] [PATCH 11/13] drm/i915: Pass i915_sched_node around internally

2019-05-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-05-07 13:12:05) > > On 03/05/2019 12:52, Chris Wilson wrote: > > To simplify the next patch, update bump_priority and schedule to accept > > the internal i915_sched_ndoe directly and not expect a request pointer. > > > > add/remove: 0/0 grow/shrink: 2/1 up/down: 8/-15

[Intel-gfx] [CI] drm/i915: Only reschedule the submission tasklet if preemption is possible

2019-05-07 Thread Chris Wilson
If we couple the scheduler more tightly with the execlists policy, we can apply the preemption policy to the question of whether we need to kick the tasklet at all for this priority bump. v2: Rephrase it as a core i915 policy and not an execlists foible. v3: Pull the kick together. Signed-off-by:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v2,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-07 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range URL : https://patchwork.freedesktop.org/series/60364/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/gtt: grab wakeref in gen6_alloc_

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-07 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range URL : https://patchwork.freedesktop.org/series/60364/ State : warning == Summary == $ dim checkpatch origin/drm-tip 85a64e026cc5 drm/i915/gtt: grab wakeref in gen6_alloc_va_range 12c78

Re: [Intel-gfx] [PATCH v6 03/10] drm: revocation check at drm subsystem

2019-05-07 Thread Singh, Satyeshwar
Acked-by: Satyeshwar Singh -Original Message- From: Roper, Matthew D Sent: Monday, May 6, 2019 2:59 PM To: Daniel Vetter Cc: C, Ramalingam ; Vetter, Daniel ; intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; Singh, Satyeshwar Subject: Re: [Intel-gfx] [PATCH v6 03/10]

Re: [Intel-gfx] [PATCH 11/13] drm/i915: Pass i915_sched_node around internally

2019-05-07 Thread Tvrtko Ursulin
On 03/05/2019 12:52, Chris Wilson wrote: To simplify the next patch, update bump_priority and schedule to accept the internal i915_sched_ndoe directly and not expect a request pointer. add/remove: 0/0 grow/shrink: 2/1 up/down: 8/-15 (-7) Function old new

[Intel-gfx] [PATCH 1/4] drm/i915: Flush the switch-to-kernel-context harder for DROP_IDLE

2019-05-07 Thread Chris Wilson
To complete the idle worker, we must complete 2 passes of wait-for-idle. At the end of the first pass, we queue a switch-to-kernel-context and may only idle after waiting for its completion. Speed up the flush_work by doing the wait explicitly, which then allows us to remove the unbounded loop tryi

[Intel-gfx] [PATCH 3/4] drm/i915: Cancel retire_worker on parking

2019-05-07 Thread Chris Wilson
Replace the racy continuation check within retire_work with a definite kill-switch on idling. The race was being exposed by gem_concurrent_blit where the retire_worker would be terminated too early leaving us spinning in debugfs/i915_drop_caches with nothing flushing the retirement queue. Although

[Intel-gfx] [PATCH 4/4] drm/i915: Stop spinning for DROP_IDLE (debugfs/i915_drop_caches)

2019-05-07 Thread Chris Wilson
If the user is racing a call to debugfs/i915_drop_caches with ongoing submission from another thread/process, we may never end up idling the GPU and be uninterruptibly spinning in debugfs/i915_drop_caches trying to catch an idle moment. Just flush the work once, that should be enough to park the s

[Intel-gfx] [PATCH 2/4] drm/i915: Remove delay for idle_work

2019-05-07 Thread Chris Wilson
The original intent for the delay before running the idle_work was to provide a hysteresis to avoid ping-ponging the device runtime-pm. Since then we have also pulled in some memory management and general device management for parking. But with the inversion of the wakeref handling, GEM is no longe

Re: [Intel-gfx] [v8 01/10] drm: Add HDR source metadata property

2019-05-07 Thread Ville Syrjälä
On Tue, May 07, 2019 at 01:25:42PM +0300, Ville Syrjälä wrote: > On Tue, May 07, 2019 at 09:03:45AM +, Shankar, Uma wrote: > > > > > > >-Original Message- > > >From: Jonas Karlman [mailto:jo...@kwiboo.se] > > >Sent: Saturday, May 4, 2019 3:48 PM > > >To: Shankar, Uma ; intel-gfx@lists

Re: [Intel-gfx] [v8 01/10] drm: Add HDR source metadata property

2019-05-07 Thread Ville Syrjälä
On Tue, Apr 09, 2019 at 10:14:35PM +0530, Uma Shankar wrote: > This patch adds a blob property to get HDR metadata > information from userspace. This will be send as part > of AVI Infoframe to panel. > > It also implements get() and set() functions for HDR output > metadata property.The blob data

Re: [Intel-gfx] [PATCH 10/13] drm/i915: Rearrange i915_scheduler.c

2019-05-07 Thread Tvrtko Ursulin
On 03/05/2019 12:52, Chris Wilson wrote: To avoid pulling in a forward declaration in the next patch, move the i915_sched_node handling to after the main dfs of the scheduler. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_scheduler.c | 210 +- 1 file chan

Re: [Intel-gfx] [PATCH 09/13] drm/i915/execlists: Don't apply priority boost for resets

2019-05-07 Thread Tvrtko Ursulin
On 03/05/2019 12:52, Chris Wilson wrote: Do not treat reset as a normal preemption event and avoid giving the guilty request a priority boost for simply being active at the time of reset. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_lrc.c | 16 +--- 1 file chang

Re: [Intel-gfx] [v8 08/10] drm/i915:Enabled Modeset when HDR Infoframe changes

2019-05-07 Thread Ville Syrjälä
On Tue, Apr 09, 2019 at 10:14:42PM +0530, Uma Shankar wrote: > This patch enables modeset whenever HDR metadata > needs to be updated to sink. > > v2: Addressed Shashank's review comments. > > v3: Added Shashank's RB. > > Signed-off-by: Ville Syrjälä > Signed-off-by: Uma Shankar > Reviewed-by:

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: add in-kernel blitter client

2019-05-07 Thread Chris Wilson
Quoting Matthew Auld (2019-05-07 11:55:57) > The plan is to use the blitter engine for async object clearing when > using local memory, but before we can move the worker to get_pages() we > have to first tame some more of our struct_mutex usage. With this in > mind we should be able to upstream the

Re: [Intel-gfx] [PATCH 08/13] drm/i915: Only reschedule the submission tasklet if preemption is possible

2019-05-07 Thread Tvrtko Ursulin
On 03/05/2019 12:52, Chris Wilson wrote: If we couple the scheduler more tightly with the execlists policy, we can apply the preemption policy to the question of whether we need to kick the tasklet at all for this priority bump. v2: Rephrase it as a core i915 policy and not an execlists foible.

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-07 Thread Chris Wilson
Quoting Matthew Auld (2019-05-07 11:55:56) > Some steps in gen6_alloc_va_range require the HW to be awake, so ideally > we should be grabbing the wakeref ourselves and not relying on the > caller already holding it for us. > > Suggested-by: Chris Wilson > Signed-off-by: Matthew Auld > --- > dri

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: disable framebuffer compression on GeminiLake (rev2)

2019-05-07 Thread Patchwork
== Series Details == Series: i915: disable framebuffer compression on GeminiLake (rev2) URL : https://patchwork.freedesktop.org/series/60090/ State : success == Summary == CI Bug Log - changes from CI_DRM_6055 -> Patchwork_12974 Summary ---

Re: [Intel-gfx] [PATCH v9] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color

2019-05-07 Thread Jani Nikula
On Tue, 07 May 2019, Ville Syrjälä wrote: > On Tue, May 07, 2019 at 09:42:48AM +0300, Jani Nikula wrote: >> On Mon, 29 Apr 2019, Aditya Swarup wrote: >> > From: Clinton Taylor >> > >> > v2: Fix commit msg to reflect why issue occurs(Jani) >> > Set GCP_COLOR_INDICATION only when we set 10/12 bit

[Intel-gfx] [drm-tip:drm-tip /8] drivers/gpu/drm/i915/i915_request.c:842:1: error: redefinition of 'already_busywaiting'

2019-05-07 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: ae28cc6cf80a2e8cbb58f255ef7cac6b2923c98a commit: 47f4a14297839cb4cedd725fb916a5da5eb9b5ba [/8] Merge remote-tracking branch 'drm-intel/drm-intel-next-queued' into drm-tip config: x86_64-rhel (attached as .config) compiler: gcc-7 (De

[Intel-gfx] [PATCH v2 1/2] drm/i915/gtt: grab wakeref in gen6_alloc_va_range

2019-05-07 Thread Matthew Auld
Some steps in gen6_alloc_va_range require the HW to be awake, so ideally we should be grabbing the wakeref ourselves and not relying on the caller already holding it for us. Suggested-by: Chris Wilson Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 +++- 1 file chang

[Intel-gfx] [PATCH v2 2/2] drm/i915: add in-kernel blitter client

2019-05-07 Thread Matthew Auld
The plan is to use the blitter engine for async object clearing when using local memory, but before we can move the worker to get_pages() we have to first tame some more of our struct_mutex usage. With this in mind we should be able to upstream the object clearing as some selftests, which should se

Re: [Intel-gfx] [PATCH 06/13] drm/i915: Cancel retire_worker on parking

2019-05-07 Thread Tvrtko Ursulin
On 03/05/2019 12:52, Chris Wilson wrote: Replace the racy continuation check within retire_work with a definite kill-switch on idling. The race was being exposed by gem_concurrent_blit where the retire_worker would be terminated too early leaving us spinning in debugfs/i915_drop_caches with noth

[Intel-gfx] [drm-tip:drm-tip 5/8] drivers/gpu/drm/i915/i915_request.c:827:1: error: redefinition of 'i915_request_await_start'

2019-05-07 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm/drm-tip drm-tip head: 73db4ec12f05160528884c0b2c845b1c6b7c6718 commit: b9a2acf7709f52c77dc752ec99e3873e392d8df6 [5/8] Merge remote-tracking branch 'drm-intel/drm-intel-next-queued' into drm-tip config: x86_64-rhel (attached as .config) compiler: gcc-7 (D

Re: [Intel-gfx] [PATCH 05/13] drm/i915: Remove delay for idle_work

2019-05-07 Thread Tvrtko Ursulin
On 03/05/2019 12:52, Chris Wilson wrote: The original intent for the delay before running the idle_work was to provide a hysteresis to avoid ping-ponging the device runtime-pm. Since then we have also pulled in some memory management and general device management for parking. But with the invers

Re: [Intel-gfx] [v5][PATCH 11/11] drm/i915: Add intel_color_lut_equal() to compare hw and sw gamma/degamma lut values

2019-05-07 Thread Ville Syrjälä
On Tue, May 07, 2019 at 12:27:07AM +0530, Sharma, Swati2 wrote: > On 07-May-19 12:03 AM, Ville Syrjälä wrote: > > > On Sat, May 04, 2019 at 10:41:40PM +0530, Swati Sharma wrote: > >> v3: Rebase > >> v4: -Renamed intel_compare_color_lut() to intel_color_lut_equal() [Jani] > >> -Added the defau

Re: [Intel-gfx] [PATCH 03/13] drm/i915: Assert the local engine->wakeref is active

2019-05-07 Thread Tvrtko Ursulin
On 03/05/2019 12:52, Chris Wilson wrote: Due to the asynchronous tasklet and recursive GT wakeref, it may happen that we submit to the engine (underneath it's own wakeref) prior to the central wakeref being marked as taken. Switch to checking the local wakeref for greater consistency. Fixes: 79

Re: [Intel-gfx] [PATCH 02/13] drm/i915: Prefer checking the wakeref itself rather than the counter

2019-05-07 Thread Tvrtko Ursulin
On 03/05/2019 12:52, Chris Wilson wrote: The counter goes to zero at the start of the parking cycle, but the wakeref itself is held until the end. Likewise, the counter becomes one at the end of the unparking, but the wakeref is taken first. If we check the wakeref instead of the counter, we inc

Re: [Intel-gfx] [PATCH v2] drm/i915: Assert breadcrumbs are correctly ordered in the signal handler

2019-05-07 Thread Tvrtko Ursulin
On 03/05/2019 16:22, Chris Wilson wrote: Inside the signal handler, we expect the requests to be ordered by their breadcrumb such that no later request may be complete if we find an earlier incomplete. Add an assert to check that the next breadcrumb should not be logically before the current. v

Re: [Intel-gfx] [PATCH] drm/i915: Acquire the signaler's timeline HWSP last

2019-05-07 Thread Tvrtko Ursulin
On 03/05/2019 15:02, Chris Wilson wrote: Acquiring the signaler's timeline takes an active reference to their HWSP that we would like to avoid if possible, so take it after performing all of our allocations required to set up the fencing. The acquisition also provides the final check that the ta

Re: [Intel-gfx] [PATCH] drm/i915: Check the target has not already completed before waiting on it

2019-05-07 Thread Tvrtko Ursulin
On 03/05/2019 14:52, Chris Wilson wrote: When we want to wait for a request to be executed, we first ask if it is not on the GPU as if it's on the gpu, there's no need to wait. However, we have to take into account that a request may not be on the GPU because it has already completed! The wind

  1   2   >