[Intel-gfx] [PATCH v2] Core-for-CI:ICL_only Disable ACPI idle driver

2019-04-08 Thread Anshuman Gupta
There were few system hung observed while running i915_pm_rpm igt test. FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840 Root cause is believed to due to page fault in ACPI idle driver. (FDO comment 18). It has been suggested by Daniel Vetter to disable ACPI idle driver for Core-for-CI, only

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/guc: Implement reset locally

2019-04-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: Implement reset locally URL : https://patchwork.freedesktop.org/series/59199/ State : success == Summary == CI Bug Log - changes from CI_DRM_5891_full -> Patchwork_12733_full =

[Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-04-08 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (powerpc allyesconfig) failed like this: drivers/gpu/drm/cirrus/cirrus.c: In function 'cirrus_fb_blit_rect': drivers/gpu/drm/cirrus/cirrus.c:310:25: error: implicit declaration of function '__io_virt'; did you mean '__do_irq'? [-W

Re: [Intel-gfx] [PATCH] Core-for-CI:ICL_only Disable ACPI idle driver

2019-04-08 Thread kbuild test robot
Hi Anshuman, Thank you for the patch! Yet something to improve: [auto build test ERROR on pm/linux-next] [also build test ERROR on v5.1-rc4 next-20190408] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[Intel-gfx] [PULL] gvt-next

2019-04-08 Thread Zhenyu Wang
Hi, This includes various code refinement and cleanups, with proper async/sync display flip handling, and also some changes required for recent drm-intel-next as guest kernel, details below. Thanks -- The following changes since commit a01b2c6f47d86c7d1a9fa822b3b91ec233b61784: drm/i915: Updat

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Always reset the context's RING registers (rev5)

2019-04-08 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Always reset the context's RING registers (rev5) URL : https://patchwork.freedesktop.org/series/59174/ State : success == Summary == CI Bug Log - changes from CI_DRM_5891_full -> Patchwork_12732_full =

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the drm tree

2019-04-08 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm-misc tree got conflicts in: drivers/gpu/drm/cirrus/cirrus_drv.h drivers/gpu/drm/cirrus/cirrus_ttm.c between commits: aa8e2435b3d4 ("drm/ttm: Define a single DRM_FILE_PAGE_OFFSET constant") 7d1500f9fbfc ("drm/ttm: Remove file_page_offset parame

Re: [Intel-gfx] [PATCH] Core-for-CI:ICL_only Disable ACPI idle driver

2019-04-08 Thread kbuild test robot
Hi Anshuman, Thank you for the patch! Yet something to improve: [auto build test ERROR on pm/linux-next] [also build test ERROR on v5.1-rc4 next-20190408] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[Intel-gfx] ✓ Fi.CI.BAT: success for IRQ initialization debloat and conversion to uncore

2019-04-08 Thread Patchwork
== Series Details == Series: IRQ initialization debloat and conversion to uncore URL : https://patchwork.freedesktop.org/series/59202/ State : success == Summary == CI Bug Log - changes from CI_DRM_5891 -> Patchwork_12734 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for IRQ initialization debloat and conversion to uncore

2019-04-08 Thread Patchwork
== Series Details == Series: IRQ initialization debloat and conversion to uncore URL : https://patchwork.freedesktop.org/series/59202/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7f73d1fe31bb drm/i915: refactor the IRQ init/reset macros -:114: CHECK:MACRO_ARG_REUSE: Macro arg

[Intel-gfx] [PATCH 1/3] drm/i915: refactor the IRQ init/reset macros

2019-04-08 Thread Paulo Zanoni
The whole point of having macros here is for the token pasting necessary to automatically have IMR, IIR and IER selected. We don't really need or want all the inlining that happens as a consequence. The good thing about the current code is that it works regardless of the relative offsets between th

[Intel-gfx] [PATCH 3/3] drm/i915: fully convert the IRQ initialization macros to intel_uncore

2019-04-08 Thread Paulo Zanoni
Make them take the uncore argument from the caller instead of passing the implicit &dev_priv->uncore directly. This will allow us to finally pass something that's not dev_priv->uncore in the future, and gets rid of the implicit variables in register macros. Signed-off-by: Paulo Zanoni --- driver

[Intel-gfx] [PATCH 0/3] IRQ initialization debloat and conversion to uncore

2019-04-08 Thread Paulo Zanoni
The first patch is a simple refactor to try to debloat our IRQ initialization and the second is a tiny conversion to the new intel_uncore model. I'm not sure how much we want patch 3 right now, but my understanding is that we want to move in that direction anyway, so why not now. Cc: Daniele Cerao

[Intel-gfx] [PATCH 2/3] drm/i915: convert the IRQ initialization functions to intel_uncore

2019-04-08 Thread Paulo Zanoni
The IRQ initialization helpers are simple and self-contained. Continue the transition started in the recent uncore rework to get us rid of I915_READ/WRITE and the implicit dev_priv variables. While the implicit dev_priv is removed from the IRQ initialization helpers, we didn't get rid of them in t

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/guc: Implement reset locally

2019-04-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: Implement reset locally URL : https://patchwork.freedesktop.org/series/59199/ State : success == Summary == CI Bug Log - changes from CI_DRM_5891 -> Patchwork_12733 Summa

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/guc: Implement reset locally

2019-04-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: Implement reset locally URL : https://patchwork.freedesktop.org/series/59199/ State : warning == Summary == $ dim checkpatch origin/drm-tip ed8431824b19 drm/i915/guc: Implement reset locally 8b244698e9bc drm/i915/execlists:

[Intel-gfx] [PATCH 2/2] drm/i915/execlists: Always reset the context's RING registers

2019-04-08 Thread Chris Wilson
During reset, we try and stop the active ring. This has the consequence that we often clobber the RING registers within the context image. When we find an active request, we update the context image to rerun that request (if it was guilty, we replace the hanging user payload with NOPs). However, we

[Intel-gfx] [PATCH 1/2] drm/i915/guc: Implement reset locally

2019-04-08 Thread Chris Wilson
Before causing guc and execlists to diverge further (breaking guc in the process), take a copy of the current reset procedure and make it local to the guc submission backend Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_guc_submission.c | 102 drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 3/3] drm/i915: do not mix workaround with normal flow

2019-04-08 Thread Rodrigo Vivi
On Thu, Apr 04, 2019 at 04:04:26PM -0700, Lucas De Marchi wrote: > Separate the two comments: one is a workaround and the other is a sanity > check. We could just compare != 1, but let's treat them differently due > to having different meaning. > > Signed-off-by: Lucas De Marchi Reviewed-by: Rod

Re: [Intel-gfx] [PATCH 2/3] drm/i915: reorder if chain to have last gen first

2019-04-08 Thread Rodrigo Vivi
On Thu, Apr 04, 2019 at 04:04:25PM -0700, Lucas De Marchi wrote: > Reorder if/else so we check for gen >= 11 first, similar to most of > other checks in the driver. > > Signed-off-by: Lucas De Marchi Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_pm.c | 11 ++- > 1 file

Re: [Intel-gfx] [PATCH 1/3] drm/i915/icl: fix step numbers in icl_display_core_init()

2019-04-08 Thread Rodrigo Vivi
On Thu, Apr 04, 2019 at 04:04:24PM -0700, Lucas De Marchi wrote: > At some point the spec was changed and we never updated the numbers to > match it. Let's try once more to keep them in sync. or maybe we just copied the numers from CNL ones? Anyway let's keep in sync with spec: Reviewed-by: Rod

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Always reset the context's RING registers (rev5)

2019-04-08 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Always reset the context's RING registers (rev5) URL : https://patchwork.freedesktop.org/series/59174/ State : success == Summary == CI Bug Log - changes from CI_DRM_5891 -> Patchwork_12732 S

Re: [Intel-gfx] [PATCH libdrm] headers: Sync with drm-next

2019-04-08 Thread Eric Engestrom
On Monday, 2019-04-08 13:44:17 +, Ayan Halder wrote: > Generated using make headers_install from the drm-next > tree - git://anongit.freedesktop.org/drm/drm > branch - drm-next > commit - 14d2bd53a47a7e1cb3e03d00a6b952734cf90f3f > > The changes were as follows :- > > core: (drm.h, drm_fourcc.

Re: [Intel-gfx] [PATCH 06/16] drm/i915: Don't call modeset related functions when display is disabled

2019-04-08 Thread Chris Wilson
Quoting Jani Nikula (2018-10-22 10:00:39) > On Mon, 22 Oct 2018, Chris Wilson wrote: > > Quoting Jani Nikula (2018-10-22 09:25:45) > >> On Fri, 12 Oct 2018, José Roberto de Souza wrote: > >> > Display features should not be initialized or deinitialized when > >> > display is disabled. > > > > I c

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/execlists: Always reset the context's RING registers (rev5)

2019-04-08 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Always reset the context's RING registers (rev5) URL : https://patchwork.freedesktop.org/series/59174/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9c116a9c7203 drm/i915/execlists: Always reset the context's RING registers -:17:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/execlists: Always reset the context's RING registers (rev4)

2019-04-08 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Always reset the context's RING registers (rev4) URL : https://patchwork.freedesktop.org/series/59174/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include/

[Intel-gfx] [PATCH v4] drm/i915/execlists: Always reset the context's RING registers

2019-04-08 Thread Chris Wilson
During reset, we try and stop the active ring. This has the consequence that we often clobber the RING registers within the context image. When we find an active request, we update the context image to rerun that request (if it was guilty, we replace the hanging user payload with NOPs). However, we

[Intel-gfx] [PATCH v4] drm/i915/execlists: Always reset the context's RING registers

2019-04-08 Thread Chris Wilson
During reset, we try and stop the active ring. This has the consequence that we often clobber the RING registers within the context image. When we find an active request, we update the context image to rerun that request (if it was guilty, we replace the hanging user payload with NOPs). However, we

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/execlists: Always reset the context's RING registers (rev3)

2019-04-08 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Always reset the context's RING registers (rev3) URL : https://patchwork.freedesktop.org/series/59174/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5891 -> Patchwork_12730 S

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/execlists: Always reset the context's RING registers (rev3)

2019-04-08 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Always reset the context's RING registers (rev3) URL : https://patchwork.freedesktop.org/series/59174/ State : warning == Summary == $ dim checkpatch origin/drm-tip bd2bb565e3c4 drm/i915/execlists: Always reset the context's RING registers -:17:

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915/psr: Update PSR2 SU corruption workaround comment

2019-04-08 Thread Souza, Jose
On Sun, 2019-04-07 at 02:45 +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/4] drm/i915/psr: Update PSR2 SU > corruption workaround comment > URL : https://patchwork.freedesktop.org/series/59087/ > State : success > > == Summary == > > CI Bug Log - changes fr

[Intel-gfx] ✓ Fi.CI.IGT: success for Core-for-CI:ICL_only Disable ACPI idle driver

2019-04-08 Thread Patchwork
== Series Details == Series: Core-for-CI:ICL_only Disable ACPI idle driver URL : https://patchwork.freedesktop.org/series/59170/ State : success == Summary == CI Bug Log - changes from CI_DRM_5888_full -> Patchwork_12727_full Summary --

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Mark live_forcewake_ops as unreliable

2019-04-08 Thread Daniele Ceraolo Spurio
On 4/7/19 12:26 PM, Chris Wilson wrote: A couple of machines in the farm show quite frequent errors in the powerwells not being released. Either there is an external agent interferring with the powerwells, or the powerwell doesn't quite behave as we anticipate -- either way, the test is not rel

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify some icl pll calculations

2019-04-08 Thread Chris Wilson
Quoting Ville Syrjälä (2019-04-08 17:06:01) > On Mon, Apr 08, 2019 at 04:49:13PM +0100, Chris Wilson wrote: > > Quoting Ville Syrjala (2019-04-08 16:27:02) > > > - /* > > > -* Adjust the original formula to delay the division by 2^22 in > > > order to > > > -* minimize possib

Re: [Intel-gfx] [PATCH v6] drm/i915/icl: Set GCP_COLOR_INDICATION only for 10/12 bit deep color

2019-04-08 Thread Ville Syrjälä
On Fri, Apr 05, 2019 at 09:34:42AM -0700, Clinton Taylor wrote: > What happened to the reset of the patch? It should have been a separate patch. Also I think this [1] oneliner might be all we need. [1] https://lists.freedesktop.org/archives/intel-gfx/2019-April/194708.html > > -Clint > > > On

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Use mul_u32_u32() more

2019-04-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Use mul_u32_u32() more URL : https://patchwork.freedesktop.org/series/59180/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5888 -> Patchwork_12729 Summary --

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify some icl pll calculations

2019-04-08 Thread Chris Wilson
Quoting Ville Syrjälä (2019-04-08 17:06:01) > On Mon, Apr 08, 2019 at 04:49:13PM +0100, Chris Wilson wrote: > > Quoting Ville Syrjala (2019-04-08 16:27:02) > > > - /* > > > -* Adjust the original formula to delay the division by 2^22 in > > > order to > > > -* minimize possib

Re: [Intel-gfx] [v2 0/7] Add Multi Segment Gamma Support

2019-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2019 at 03:59:51PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf > >Of Ville > >Syrjälä > >Sent: Monday, April 8, 2019 9:15 PM > >To: Shankar, Uma > >Cc: dcasta...@chromium.org; intel-gf

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify some icl pll calculations

2019-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2019 at 04:49:13PM +0100, Chris Wilson wrote: > Quoting Ville Syrjala (2019-04-08 16:27:02) > > - /* > > -* Adjust the original formula to delay the division by 2^22 in > > order to > > -* minimize possible rounding errors. > > -*/ > > - tmp = (u

Re: [Intel-gfx] [PATCH 05/29] drm/i915: Store the default sseu setup on the engine

2019-04-08 Thread Tvrtko Ursulin
On 08/04/2019 16:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-04-08 15:54:01) On 08/04/2019 10:17, Chris Wilson wrote: As we push for better compartmentalisation, it is more convenient to copy the default sseu configuration from the engine into the derived logical context, than it is

Re: [Intel-gfx] [PATCH 09/29] drm/i915: Pull the GEM powermangement coupling into its own file

2019-04-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-04-08 15:56:39) > > On 08/04/2019 10:17, Chris Wilson wrote: > > Split out the powermanagement portion (GT wakeref, suspend/resume) of > > GEM from i915_gem.c into its own file. > > This is the same patch I gave r-b on before? Judging from the title and > commit mess

Re: [Intel-gfx] [v2 0/7] Add Multi Segment Gamma Support

2019-04-08 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Ville >Syrjälä >Sent: Monday, April 8, 2019 9:15 PM >To: Shankar, Uma >Cc: dcasta...@chromium.org; intel-gfx@lists.freedesktop.org; dri- >de...@lists.freedesktop.org; seanp...@chromium.or

Re: [Intel-gfx] [PATCH 05/29] drm/i915: Store the default sseu setup on the engine

2019-04-08 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-04-08 15:54:01) > > On 08/04/2019 10:17, Chris Wilson wrote: > > As we push for better compartmentalisation, it is more convenient to > > copy the default sseu configuration from the engine into the derived > > logical context, than it is to dig it out from i915->runti

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Simplify some icl pll calculations

2019-04-08 Thread Chris Wilson
Quoting Ville Syrjala (2019-04-08 16:27:02) > - /* > -* Adjust the original formula to delay the division by 2^22 in order > to > -* minimize possible rounding errors. > -*/ > - tmp = (u64)m1 * m2_int * ref_clock + > - (((u64)m1 * m2_frac * ref_clock

[Intel-gfx] [PATCH v3] drm/i915/execlists: Always reset the context's RING registers

2019-04-08 Thread Chris Wilson
During reset, we try and stop the active ring. This has the consequence that we often clobber the RING registers within the context image. When we find an active request, we update the context image to rerun that request (if it was guilty, we replace the hanging user payload with NOPs). However, we

Re: [Intel-gfx] [v2 0/7] Add Multi Segment Gamma Support

2019-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2019 at 03:40:39PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > >Sent: Monday, April 8, 2019 8:27 PM > >To: Shankar, Uma > >Cc: dcasta...@chromium.org; intel-gfx@lists.freedesktop.org; dri- > >de...@l

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Use mul_u32_u32() more

2019-04-08 Thread Chris Wilson
Quoting Ville Syrjala (2019-04-08 16:27:01) > From: Ville Syrjälä > > We have a lot of '(u64)foo * bar' everywhere. Replace with > mul_u32_u32() to avoid gcc failing to use a regular 32x32->64 > multiply for this. > > Signed-off-by: Ville Syrjälä As a purely mechanical translation, Reviewed-by

Re: [Intel-gfx] [v2 0/7] Add Multi Segment Gamma Support

2019-04-08 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Monday, April 8, 2019 8:27 PM >To: Shankar, Uma >Cc: dcasta...@chromium.org; intel-gfx@lists.freedesktop.org; dri- >de...@lists.freedesktop.org; seanp...@chromium.org; Syrjala, Ville >; Lankhorst, Maar

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915: Get power refs in encoder->get_power_domains() (rev2)

2019-04-08 Thread Imre Deak
On Sun, Apr 07, 2019 at 02:40:18PM +, Patchwork wrote: > == Series Details == > > Series: series starting with [v2,1/2] drm/i915: Get power refs in > encoder->get_power_domains() (rev2) > URL : https://patchwork.freedesktop.org/series/59071/ > State : failure Thanks for the review, pushed

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Use mul_u32_u32() more

2019-04-08 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Use mul_u32_u32() more URL : https://patchwork.freedesktop.org/series/59180/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Use mul_u32_u32() more -O:drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Always reset the context's RING registers

2019-04-08 Thread Chris Wilson
Quoting Chris Wilson (2019-04-08 14:40:25) > During reset, we try and stop the active ring. This has the consequence > that we often clobber the RING registers within the context image. When > we find an active request, we update the context image to rerun that > request (if it was guilty, we repla

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/execlists: Always reset the context's RING registers (rev2)

2019-04-08 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Always reset the context's RING registers (rev2) URL : https://patchwork.freedesktop.org/series/59174/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5888 -> Patchwork_12728 S

[Intel-gfx] [PATCH 2/2] drm/i915: Simplify some icl pll calculations

2019-04-08 Thread Ville Syrjala
From: Ville Syrjälä Write some icl pll calculations in a more straightforward way. We have just enough bits for the full divisor. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_ddi.c | 15 --- drivers/gpu/drm/i915/intel_dpll_mgr.c | 2 +- 2 files changed, 5 inser

[Intel-gfx] [PATCH 1/2] drm/i915: Use mul_u32_u32() more

2019-04-08 Thread Ville Syrjala
From: Ville Syrjälä We have a lot of '(u64)foo * bar' everywhere. Replace with mul_u32_u32() to avoid gcc failing to use a regular 32x32->64 multiply for this. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_fixed.h | 6 +++--- drivers/gpu/drm/i915/intel_display.c | 10 +--

Re: [Intel-gfx] [PATCH 14/29] drm/i915: Explicitly pin the logical context for execbuf

2019-04-08 Thread Tvrtko Ursulin
On 08/04/2019 10:17, Chris Wilson wrote: In order to separate the reservation phase of building a request from its emission phase, we need to pull some of the request alloc activities from deep inside i915_request to the surface, GEM_EXECBUFFER. I had some comments and gave conditional r-b on

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/execlists: Always reset the context's RING registers (rev2)

2019-04-08 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Always reset the context's RING registers (rev2) URL : https://patchwork.freedesktop.org/series/59174/ State : warning == Summary == $ dim checkpatch origin/drm-tip 032a44d4e5e1 drm/i915/execlists: Always reset the context's RING registers -:17:

[Intel-gfx] ✓ Fi.CI.BAT: success for Core-for-CI:ICL_only Disable ACPI idle driver

2019-04-08 Thread Patchwork
== Series Details == Series: Core-for-CI:ICL_only Disable ACPI idle driver URL : https://patchwork.freedesktop.org/series/59170/ State : success == Summary == CI Bug Log - changes from CI_DRM_5888 -> Patchwork_12727 Summary --- **SUC

[Intel-gfx] ✓ Fi.CI.IGT: success for snd/hda: Detangle unwind to avoid double release of display powerwell (rev2)

2019-04-08 Thread Patchwork
== Series Details == Series: snd/hda: Detangle unwind to avoid double release of display powerwell (rev2) URL : https://patchwork.freedesktop.org/series/59158/ State : success == Summary == CI Bug Log - changes from CI_DRM_5887_full -> Patchwork_12725_full

Re: [Intel-gfx] [PATCH 17/29] drm/i915/selftests: Use the real kernel context for sseu isolation tests

2019-04-08 Thread Tvrtko Ursulin
On 08/04/2019 10:17, Chris Wilson wrote: Simply the setup slightly for the sseu selftests to use the actual kernel_context. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/selftests/i915_gem_context.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/

Re: [Intel-gfx] Baytrail DRM driver Colorkey not available

2019-04-08 Thread Ville Syrjälä
On Thu, Apr 04, 2019 at 09:38:03PM +, Jim Zhang wrote: > Dear Sir/Madam: > > I am having an issue with intel Baytrail GPU DRM driver. > > Description: > Linux kernel version 3.10.61: > Afer calling function > properties = drmModeObjectGetProperties(drmfd, plane_id, > DRM_MODE_OBJECT_PLANE);

Re: [Intel-gfx] [PATCH 15/29] drm/i915/guc: Replace preempt_client lookup with engine->preempt_context

2019-04-08 Thread Tvrtko Ursulin
On 08/04/2019 10:17, Chris Wilson wrote: Circumvent the dance we currently perform to find the preempt_client and lookup its HW context for this engine, as we know we have already pinned the preempt_context on the engine. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_guc_submiss

Re: [Intel-gfx] [v2 0/7] Add Multi Segment Gamma Support

2019-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2019 at 02:40:51PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > >Sent: Monday, April 8, 2019 6:01 PM > >To: Shankar, Uma > >Cc: dcasta...@chromium.org; intel-gfx@lists.freedesktop.org; dri- > >de...@l

Re: [Intel-gfx] [PATCH 09/29] drm/i915: Pull the GEM powermangement coupling into its own file

2019-04-08 Thread Tvrtko Ursulin
On 08/04/2019 10:17, Chris Wilson wrote: Split out the powermanagement portion (GT wakeref, suspend/resume) of GEM from i915_gem.c into its own file. This is the same patch I gave r-b on before? Judging from the title and commit message I'd say yes. But I know it is not, don't worry. Regard

Re: [Intel-gfx] [PATCH 05/29] drm/i915: Store the default sseu setup on the engine

2019-04-08 Thread Tvrtko Ursulin
On 08/04/2019 10:17, Chris Wilson wrote: As we push for better compartmentalisation, it is more convenient to copy the default sseu configuration from the engine into the derived logical context, than it is to dig it out from i915->runtime_info. Why it is more convenient? Signed-off-by: Chr

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: revert back to max link rate and lane count on eDP

2019-04-08 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: 7769db588384 drm/i915/dp: optimize eDP 1.4+ link config fast and narrow. The bot has tested the following trees: v5.0.7. v5.0.7: Failed to apply! Possible dependencies: 204474

Re: [Intel-gfx] [v2 3/7] drm: Add gamma mode property

2019-04-08 Thread Shankar, Uma
>-Original Message- >From: Sam Ravnborg [mailto:s...@ravnborg.org] >Sent: Tuesday, April 2, 2019 12:07 AM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >dcasta...@chromium.org; emil.l.veli...@gmail.com; seanp...@chromium.org; >Syrjala, Ville ; L

Re: [Intel-gfx] Baytrail DRM driver Colorkey not available

2019-04-08 Thread Jani Nikula
On Thu, 04 Apr 2019, Jim Zhang wrote: > Dear Sir/Madam: > > I am having an issue with intel Baytrail GPU DRM driver. > > Description: > Linux kernel version 3.10.61: > Afer calling function > properties = drmModeObjectGetProperties(drmfd, plane_id, > DRM_MODE_OBJECT_PLANE); > it only returns onl

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Clean up cherryview_load_luts()

2019-04-08 Thread Patchwork
== Series Details == Series: drm/i915: Clean up cherryview_load_luts() URL : https://patchwork.freedesktop.org/series/59169/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5888 -> Patchwork_12726 Summary --- **FAILURE

Re: [Intel-gfx] [v2 1/7] drm: Add gamma mode caps property

2019-04-08 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Sam >Ravnborg >Sent: Tuesday, April 2, 2019 12:03 AM >To: Shankar, Uma >Cc: dcasta...@chromium.org; intel-gfx@lists.freedesktop.org; >emil.l.veli...@gmail.com; dri-de...@lists.freedesktop

Re: [Intel-gfx] [PATCH 04/29] drm/i915: Consolidate the timeline->barrier

2019-04-08 Thread Tvrtko Ursulin
On 08/04/2019 10:17, Chris Wilson wrote: The timeline is strictly ordered, so by inserting the timeline->barrier request into the timeline->last_request it naturally provides the same barrier. Consolidate the pair of barriers into one as they serve the same purpose. Signed-off-by: Chris Wilson

Re: [Intel-gfx] [v2 0/7] Add Multi Segment Gamma Support

2019-04-08 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Monday, April 8, 2019 6:01 PM >To: Shankar, Uma >Cc: dcasta...@chromium.org; intel-gfx@lists.freedesktop.org; dri- >de...@lists.freedesktop.org; seanp...@chromium.org; Syrjala, Ville >; Lankhorst, Maar

Re: [Intel-gfx] [PATCH 03/29] drm/i915: Use static allocation for i915_globals_park()

2019-04-08 Thread Tvrtko Ursulin
On 08/04/2019 10:17, Chris Wilson wrote: In order to avoid the malloc inside i915_globals_park() occurring underneath a lock connected to the shrinker (thus causing circular lockdeps warnings), move the rcu_worker to a global. <4> [39.085073]

Re: [Intel-gfx] [PATCH 02/29] drm/i915/guc: Replace WARN with a DRM_ERROR

2019-04-08 Thread Tvrtko Ursulin
On 08/04/2019 10:17, Chris Wilson wrote: Replace the WARN with a simple if() + error message to squech the sparse warning that entire wait_for() macro was being stringified: drivers/gpu/drm/i915/intel_guc_submission.c:658:9: error: too long token expansion Signed-off-by: Chris Wilson --- d

[Intel-gfx] [PATCH libdrm] headers: Sync with drm-next

2019-04-08 Thread Ayan Halder
Generated using make headers_install from the drm-next tree - git://anongit.freedesktop.org/drm/drm branch - drm-next commit - 14d2bd53a47a7e1cb3e03d00a6b952734cf90f3f The changes were as follows :- core: (drm.h, drm_fourcc.h, drm_mode.h) - Added 'struct drm_syncobj_transfer', 'struct drm_syncobj

[Intel-gfx] [PATCH] drm/i915/execlists: Always reset the context's RING registers

2019-04-08 Thread Chris Wilson
During reset, we try and stop the active ring. This has the consequence that we often clobber the RING registers within the context image. When we find an active request, we update the context image to rerun that request (if it was guilty, we replace the hanging user payload with NOPs). However, we

[Intel-gfx] [PATCH] drm/i915/execlists: Always reset the context's RING registers

2019-04-08 Thread Chris Wilson
During reset, we try and stop the active ring. This has the consequence that we often clobber the RING registers within the context image. When we find an active request, we update the context image to rerun that request (if it was guilty, we replace the hanging user payload with NOPs). However, we

Re: [Intel-gfx] [PATCH] Core-for-CI:ICL_only Disable ACPI idle driver

2019-04-08 Thread Saarinen, Jani
+ Rafael, Mika. > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Anshuman Gupta > Sent: maanantai 8. huhtikuuta 2019 15.22 > To: intel-gfx@lists.freedesktop.org > Cc: Peres, Martin ; Vetter, Daniel > > Subject: [Intel-gfx] [PATCH] Cor

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for snd/hda: Detangle unwind to avoid double release of display powerwell (rev2)

2019-04-08 Thread Chris Wilson
Quoting Patchwork (2019-04-08 13:51:08) > Warnings > > * igt@i915_pm_rpm@module-reload: > - fi-glk-dsi: DMESG-WARN [fdo#105538] / [fdo#107732] / > [fdo#109513] -> INCOMPLETE [fdo#103359] / [k.org#198133] In other words, no that wasn't the fix it purported to be. -Chris __

[Intel-gfx] ✓ Fi.CI.BAT: success for snd/hda: Detangle unwind to avoid double release of display powerwell (rev2)

2019-04-08 Thread Patchwork
== Series Details == Series: snd/hda: Detangle unwind to avoid double release of display powerwell (rev2) URL : https://patchwork.freedesktop.org/series/59158/ State : success == Summary == CI Bug Log - changes from CI_DRM_5887 -> Patchwork_12725 ==

Re: [Intel-gfx] [v2 5/7] drm/i915/icl: Add support for multi segmented gamma mode

2019-04-08 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Monday, April 8, 2019 3:50 PM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >dcasta...@chromium.org; seanp...@chromium.org; Syrjala, Ville >; harry.wentl...@a

Re: [Intel-gfx] [v2 0/7] Add Multi Segment Gamma Support

2019-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2019 at 12:26:23PM +, Shankar, Uma wrote: > > > >-Original Message- > >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf > >Of Ville > >Syrjälä > >Sent: Friday, April 5, 2019 9:42 PM > >To: Shankar, Uma > >Cc: dcasta...@chromium.org; intel-gf

Re: [Intel-gfx] [v2 2/7] drm/i915: Define color lut range structure

2019-04-08 Thread Shankar, Uma
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Monday, April 8, 2019 3:39 PM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; >Lankhorst, >Maarten ; Syrjala, Ville >; >Sharma, Shashank ; emil.l.veli...@gmai

Re: [Intel-gfx] [PATCH] snd/hda: Detangle unwind to avoid double release of display powerwell

2019-04-08 Thread kbuild test robot
/commits/Chris-Wilson/snd-hda-Detangle-unwind-to-avoid-double-release-of-display-powerwell/20190408-185235 base: https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next config: i386-randconfig-x012-201914 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce

Re: [Intel-gfx] [v2 0/7] Add Multi Segment Gamma Support

2019-04-08 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Ville >Syrjälä >Sent: Friday, April 5, 2019 9:42 PM >To: Shankar, Uma >Cc: dcasta...@chromium.org; intel-gfx@lists.freedesktop.org; dri- >de...@lists.freedesktop.org; seanp...@chromium.or

[Intel-gfx] [PATCH] Core-for-CI:ICL_only Disable ACPI idle driver

2019-04-08 Thread Anshuman Gupta
There were system hung observed while running i915_pm_rpm test. FDO https://bugs.freedesktop.org/show_bug.cgi?id=108840 Root cause is believed to due to page fault in ACPI idle (FDO comment 18) driver, it has been suggested by Daniel to disable ACPI idle driver for CI system, this patch only meant

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for snd/hda: Detangle unwind to avoid double release of display powerwell (rev2)

2019-04-08 Thread Patchwork
== Series Details == Series: snd/hda: Detangle unwind to avoid double release of display powerwell (rev2) URL : https://patchwork.freedesktop.org/series/59158/ State : warning == Summary == $ dim checkpatch origin/drm-tip c354dafa354d snd/hda: Detangle unwind to avoid double release of displa

[Intel-gfx] [PATCH] drm/i915: Clean up cherryview_load_luts()

2019-04-08 Thread Ville Syrjala
From: Ville Syrjälä I like my functions simple, so split up the low level bits from cherryview_load_luts() into separate functions. Also rename the whole thing to chv_load_luts() to match the new world order. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_color.c | 98

Re: [Intel-gfx] [PATCH] drm/i915: Fix pipe_bpp readout for BXT/GLK DSI

2019-04-08 Thread Ville Syrjälä
On Mon, Apr 08, 2019 at 09:16:34AM +0300, Jani Nikula wrote: > On Fri, 05 Apr 2019, Imre Deak wrote: > > On Fri, Apr 05, 2019 at 05:13:49PM +0300, Ville Syrjala wrote: > >> From: Ville Syrjälä > >> > >> The only bpc information in pipe registers for BXT/GLK DSI > >> is the PIPEMISC dither bpc. L

[Intel-gfx] [PATCH v2] snd/hda: Detangle unwind to avoid double release of display powerwell

2019-04-08 Thread Chris Wilson
<4> [265.019572] Unmatched wakeref (tracking 3), count 3 <4> [265.019680] WARNING: CPU: 1 PID: 163 at drivers/gpu/drm/i915/intel_runtime_pm.c:162 cancel_intel_runtime_pm_wakeref+0x87/0x160 [i915] <4> [265.019682] Modules linked in: snd_hda_intel i915 vgem snd_hda_codec_hdmi snd_hda_codec_realtek

[Intel-gfx] ✗ Fi.CI.BAT: failure for snd/hda: Detangle unwind to avoid double release of display powerwell

2019-04-08 Thread Patchwork
== Series Details == Series: snd/hda: Detangle unwind to avoid double release of display powerwell URL : https://patchwork.freedesktop.org/series/59158/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK include

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/29] drm/i915: Mark up ips for RCU protection

2019-04-08 Thread Chris Wilson
Quoting Patchwork (2019-04-08 11:28:00) > == Series Details == > > Series: series starting with [01/29] drm/i915: Mark up ips for RCU protection > URL : https://patchwork.freedesktop.org/series/59155/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5887 -> Patchwork_12

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/29] drm/i915: Mark up ips for RCU protection

2019-04-08 Thread Patchwork
== Series Details == Series: series starting with [01/29] drm/i915: Mark up ips for RCU protection URL : https://patchwork.freedesktop.org/series/59155/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5887 -> Patchwork_12723

Re: [Intel-gfx] [v2 5/7] drm/i915/icl: Add support for multi segmented gamma mode

2019-04-08 Thread Ville Syrjälä
On Mon, Apr 01, 2019 at 11:00:09PM +0530, Uma Shankar wrote: > Gen11 introduced a new gamma mode i.e, multi segmented > gamma mode. Added support for the same. > > Signed-off-by: Uma Shankar > --- > drivers/gpu/drm/i915/intel_color.c | 161 > - > include/drm/

Re: [Intel-gfx] [v7 1/9] drm: Add HDR source metadata property

2019-04-08 Thread Jonas Karlman
On 2019-04-02 22:20, Uma Shankar wrote: > This patch adds a blob property to get HDR metadata > information from userspace. This will be send as part > of AVI Infoframe to panel. > > It also implements get() and set() functions for HDR output > metadata property.The blob data is received from users

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/29] drm/i915: Mark up ips for RCU protection

2019-04-08 Thread Patchwork
== Series Details == Series: series starting with [01/29] drm/i915: Mark up ips for RCU protection URL : https://patchwork.freedesktop.org/series/59155/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Mark up ips for RCU protection -drivers/gp

[Intel-gfx] [PATCH] fixups

2019-04-08 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- lib/igt_dummyload.c | 39 +-- lib/igt_gt.c| 14 -- lib/igt_gt.h| 2 -- tests/perf_pmu.c| 44 4 files changed, 73 insertions(+)

Re: [Intel-gfx] [v2 2/7] drm/i915: Define color lut range structure

2019-04-08 Thread Ville Syrjälä
On Mon, Apr 01, 2019 at 11:00:06PM +0530, Uma Shankar wrote: > From: Ville Syrjälä > > This defines the color lut ranges for 10bit and multi > segmented gamma range for ICL. > > Signed-off-by: Ville Syrjälä > Signed-off-by: Uma Shankar > --- > drivers/gpu/drm/i915/intel_color.c | 301 > +

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/29] drm/i915: Mark up ips for RCU protection

2019-04-08 Thread Patchwork
== Series Details == Series: series starting with [01/29] drm/i915: Mark up ips for RCU protection URL : https://patchwork.freedesktop.org/series/59155/ State : warning == Summary == $ dim checkpatch origin/drm-tip 17875d38d33a drm/i915: Mark up ips for RCU protection bb6133046abe drm/i915/guc

Re: [Intel-gfx] [PATCH] drm/i915/dp: Expose force_dsc_enable through debugfs

2019-04-08 Thread Imre Deak
On Fri, Apr 05, 2019 at 03:48:21PM -0700, Manasi Navare wrote: > Currently we use force_dsc_enable to force DSC from IGT, but > we dont expose this value to userspace through debugfs. > This patch exposes this through the same dsc_fec_support > debugfs node per connector so that we can restore its

[Intel-gfx] [PATCH] snd/hda: Detangle unwind to avoid double release of display powerwell

2019-04-08 Thread Chris Wilson
<4> [265.019572] Unmatched wakeref (tracking 3), count 3 <4> [265.019680] WARNING: CPU: 1 PID: 163 at drivers/gpu/drm/i915/intel_runtime_pm.c:162 cancel_intel_runtime_pm_wakeref+0x87/0x160 [i915] <4> [265.019682] Modules linked in: snd_hda_intel i915 vgem snd_hda_codec_hdmi snd_hda_codec_realtek

  1   2   >