Re: [Intel-gfx] [PATCH] drm/i915: Fix pipe_bpp readout for BXT/GLK DSI

On Fri, 05 Apr 2019, Imre Deak wrote: > On Fri, Apr 05, 2019 at 05:13:49PM +0300, Ville Syrjala wrote: >> From: Ville Syrjälä >> >> The only bpc information in pipe registers for BXT/GLK DSI >> is the PIPEMISC dither bpc. Let's try to use that to read >> out pipe_bpp on these platforms. However,

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Prevent use-after-free in ppgtt_free_all_spt()

On 2019.04.04 09:11:55 +0100, Chris Wilson wrote: > Quoting Zhenyu Wang (2019-04-04 08:48:34) > > On 2019.04.04 08:30:56 +0100, Chris Wilson wrote: > > > ppgtt_free_all_spt() iterates the radixtree as it is deleting it, > > > forgoing all protection against the leaves being freed in the process > >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Mark live_forcewake_ops as unreliable (rev2)

== Series Details == Series: drm/i915/selftests: Mark live_forcewake_ops as unreliable (rev2) URL : https://patchwork.freedesktop.org/series/59129/ State : success == Summary == CI Bug Log - changes from CI_DRM_5884_full -> Patchwork_12722_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Mark live_forcewake_ops as unreliable (rev2)

== Series Details == Series: drm/i915/selftests: Mark live_forcewake_ops as unreliable (rev2) URL : https://patchwork.freedesktop.org/series/59129/ State : success == Summary == CI Bug Log - changes from CI_DRM_5884 -> Patchwork_12722 Summa

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Mark live_forcewake_ops as unreliable (rev2)

== Series Details == Series: drm/i915/selftests: Mark live_forcewake_ops as unreliable (rev2) URL : https://patchwork.freedesktop.org/series/59129/ State : warning == Summary == $ dim checkpatch origin/drm-tip ef387cfc8b22 drm/i915/selftests: Mark live_forcewake_ops as unreliable -:8: WARNING:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Mark live_forcewake_ops as unreliable

== Series Details == Series: drm/i915/selftests: Mark live_forcewake_ops as unreliable URL : https://patchwork.freedesktop.org/series/59129/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5884 -> Patchwork_12721 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Mark live_forcewake_ops as unreliable

== Series Details == Series: drm/i915/selftests: Mark live_forcewake_ops as unreliable URL : https://patchwork.freedesktop.org/series/59129/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2c9755fcbe03 drm/i915/selftests: Mark live_forcewake_ops as unreliable -:8: WARNING:TYPO_SP

[Intel-gfx] [PATCH] drm/i915/selftests: Mark live_forcewake_ops as unreliable

A couple of machines in the farm show quite frequent errors in the powerwells not being released. Either there is an external agent interferring with the powerwells, or the powerwell doesn't quite behave as we anticipate -- either way, the test is not reliable enough to be enabled by default in CI.

[Intel-gfx] [PATCH] drm/i915/selftests: Mark live_forcewake_ops as unreliable

A couple of machines in the farm show quite frequent errors in the powerwells not being released. Either there is an external agent interferring with the powerwells, or the powerwell doesn't quite behave as we anticipate -- either way, the test is not reliable enough to be enabled by default in CI.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/fb-helper: Move modesetting code to drm_client (rev2)

== Series Details == Series: drm/fb-helper: Move modesetting code to drm_client (rev2) URL : https://patchwork.freedesktop.org/series/58597/ State : success == Summary == CI Bug Log - changes from CI_DRM_5884_full -> Patchwork_12720_full Su

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/fb-helper: Move modesetting code to drm_client (rev2)

== Series Details == Series: drm/fb-helper: Move modesetting code to drm_client (rev2) URL : https://patchwork.freedesktop.org/series/58597/ State : success == Summary == CI Bug Log - changes from CI_DRM_5884 -> Patchwork_12720 Summary

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/fb-helper: Move modesetting code to drm_client (rev2)

== Series Details == Series: drm/fb-helper: Move modesetting code to drm_client (rev2) URL : https://patchwork.freedesktop.org/series/58597/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/fb-helper: Move modesetting code to drm_client (rev2)

== Series Details == Series: drm/fb-helper: Move modesetting code to drm_client (rev2) URL : https://patchwork.freedesktop.org/series/58597/ State : warning == Summary == $ dim checkpatch origin/drm-tip 60e07d9925cc drm/atomic: Move __drm_atomic_helper_disable_plane/set_config() 0b30c352ab25 d

[Intel-gfx] [PATCH v2 12/12] drm/client: Hack: Add bootsplash example

An example to showcase the client API. TODO: A bootsplash client needs a way to tell drm_fb_helper to stay away, otherwise it will chime in on setup and hotplug. Most DRM drivers register fbdev before calling drm_dev_register() (the generic emulation is an exception). This have to be reversed for

[Intel-gfx] [PATCH v2 10/12] drm/fb-helper: Prepare to move out modeset config code

This prepares the modeset code so it can be moved out as-is in the next patch. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 63 +++-- include/drm/drm_fb_helper.h | 4 --- 2 files changed, 45 insertions(+), 22 deletions(-) diff --git a/driv

[Intel-gfx] [PATCH v2 09/12] drm/fb-helper: Remove drm_fb_helper_connector

All drivers add all their connectors so there's no need to keep around an array of available connectors. Rename functions which signature is changed since they will be moved to drm_client in a later patch. Signed-off-by: Noralf Trønnes --- checkpatch complains, but I'm unable to satisfy it: ER

[Intel-gfx] [PATCH v2 11/12] drm/fb-helper: Move out modeset config code

No functional changes, just moving code as-is and fixing includes. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client_modeset.c | 703 ++- drivers/gpu/drm/drm_fb_helper.c | 692 -- include/drm/drm_client.h | 4 +- 3 fil

[Intel-gfx] [PATCH v2 02/12] drm/fb-helper: Avoid race with DRM userspace

drm_fb_helper_is_bound() is used to check if DRM userspace is in control. This is done by looking at the fb on the primary plane. By the time fb-helper gets around to committing, it's possible that the facts have changed. Avoid this race by holding the drm_device->master_mutex lock while committin

[Intel-gfx] [PATCH v2 04/12] drm/fb-helper: No need to cache rotation and sw_rotations

Getting rotation info is cheap so we can do it on demand. This is done in preparation for the removal of struct drm_fb_helper_crtc. Cc: Hans de Goede Signed-off-by: Noralf Trønnes Acked-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 131 include/drm/d

[Intel-gfx] [PATCH v2 05/12] drm/fb-helper: Remove drm_fb_helper_crtc->{x, y, desired_mode}

The values are already present in the modeset. This is done in preparation for the removal of struct drm_fb_helper_crtc. Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 12 include/drm/drm_fb_helper.h | 2 -- 2 files changed, 4 i

[Intel-gfx] [PATCH v2 03/12] drm/i915/fbdev: Move intel_fb_initial_config() to fbdev helper

It is generic code and having it in the helper will let other drivers benefit from it. One change was necessary assuming this to be true: INTEL_INFO(dev_priv)->num_pipes == dev->mode_config.num_crtc Suggested-by: Daniel Vetter Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: intel-gfx

[Intel-gfx] [PATCH v2 07/12] drm/fb-helper: Prepare to move out commit code

This makes the necessary changes so the commit code can be moved out to drm_client as-is in the next patch. It's split up to ease review. Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_fb_helper.c | 122 +--- 1 file changed, 81 insertions(+), 41 deletions(-) d

[Intel-gfx] [PATCH v2 00/12] drm/fb-helper: Move modesetting code to drm_client

This moves the modesetting code from drm_fb_helper to drm_client so it can be shared by all internal clients. The main change this time is to attach the modeset array to drm_client_dev and honour the drm_fb_helper MIT license. I've dropped the display abstraction. Noralf. Cc: Emmanuel Vadot No

[Intel-gfx] [PATCH v2 08/12] drm/fb-helper: Move out commit code

Move the modeset commit code to drm_client_modeset. No changes except exporting API. v2: Move to drm_client_modeset.c instead of drm_client.c Signed-off-by: Noralf Trønnes --- drivers/gpu/drm/drm_client_modeset.c | 287 +++ drivers/gpu/drm/drm_fb_helper.c | 282

[Intel-gfx] [PATCH v2 06/12] drm/fb-helper: Remove drm_fb_helper_crtc

It now only contains the modeset so use that directly instead and attach a modeset array to drm_client_dev. drm_fb_helper will use this array. Code will later be moved to drm_client, so add code there in a new file drm_client_modeset.c with MIT license to match drm_fb_helper.c. The modeset connect

[Intel-gfx] [PATCH v2 01/12] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

Prepare for moving drm_fb_helper modesetting code to drm_client. drm_client will be linked to drm.ko, so move __drm_atomic_helper_disable_plane() and __drm_atomic_helper_set_config() out of drm_kms_helper.ko. While at it, fix two checkpatch complaints: - WARNING: Block comments use a trailing */ o

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915: Get power refs in encoder->get_power_domains() (rev2)

== Series Details == Series: series starting with [v2,1/2] drm/i915: Get power refs in encoder->get_power_domains() (rev2) URL : https://patchwork.freedesktop.org/series/59071/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5883_full -> Patchwork_12719_full ===

Re: [Intel-gfx] [PATCH] drm/i915: Track the temporary wakerefs used for hsw_get_pipe_config

On Sat, Apr 06, 2019 at 09:03:41AM +0100, Chris Wilson wrote: > Haswell+ require many power wells to probe the current HW display state. > Under the wakeref tracking scheme, we want each owner to store and > release the wakeref they use, so we can identify callers that have > leaked their wakeref.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915: Get power refs in encoder->get_power_domains() (rev2)

== Series Details == Series: series starting with [v2,1/2] drm/i915: Get power refs in encoder->get_power_domains() (rev2) URL : https://patchwork.freedesktop.org/series/59071/ State : success == Summary == CI Bug Log - changes from CI_DRM_5883 -> Patchwork_12719 =

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Get power refs in encoder->get_power_domains()

Quoting Imre Deak (2019-04-07 13:46:55) > Push getting the reference for the encoders' power domains into the > encoder get_power_domains() hook instead of doing this from the caller. > This way the encoder can store away the corresponding wakerefs. > > This fixes the DSI encoder disabling, which

[Intel-gfx] [PATCH v2 1/2] drm/i915: Get power refs in encoder->get_power_domains()

Push getting the reference for the encoders' power domains into the encoder get_power_domains() hook instead of doing this from the caller. This way the encoder can store away the corresponding wakerefs. This fixes the DSI encoder disabling, which didn't release these power references it acquired

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Get power refs in encoder->get_power_domain()

Quoting Imre Deak (2019-04-07 13:06:32) > On Sun, Apr 07, 2019 at 02:55:14PM +0300, Imre Deak wrote: > > > get_power_domains() and atomic needs to take responsibility for the > > > overlapping set of powerwells imo. > > > > ->get_power_domains() is essentially the powerref acquisition part of the

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Get power refs in encoder->get_power_domain()

On Sun, Apr 07, 2019 at 02:55:14PM +0300, Imre Deak wrote: > On Sun, Apr 07, 2019 at 12:41:08PM +0100, Chris Wilson wrote: > > Quoting Imre Deak (2019-04-07 11:25:37) > > > On Sat, Apr 06, 2019 at 05:05:53PM +0100, Chris Wilson wrote: > > > > Quoting Imre Deak (2019-04-05 16:36:56) > > > > > Push g

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Get power refs in encoder->get_power_domain()

On Sun, Apr 07, 2019 at 12:41:08PM +0100, Chris Wilson wrote: > Quoting Imre Deak (2019-04-07 11:25:37) > > On Sat, Apr 06, 2019 at 05:05:53PM +0100, Chris Wilson wrote: > > > Quoting Imre Deak (2019-04-05 16:36:56) > > > > Push getting the reference for the encoders' power domains into the > > > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Get power refs in encoder->get_power_domain()

Quoting Imre Deak (2019-04-07 11:25:37) > On Sat, Apr 06, 2019 at 05:05:53PM +0100, Chris Wilson wrote: > > Quoting Imre Deak (2019-04-05 16:36:56) > > > Push getting the reference for the encoders' power domains into the > > > encoder get_power_domain() hook instead of doing this from the caller.

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Get power refs in encoder->get_power_domain()

On Sat, Apr 06, 2019 at 03:53:36PM +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915: Get power refs in > encoder->get_power_domain() > URL : https://patchwork.freedesktop.org/series/59071/ > State : failure > > == Summary == > > CI Bug Log - chang

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Get power refs in encoder->get_power_domain()

On Sat, Apr 06, 2019 at 05:05:53PM +0100, Chris Wilson wrote: > Quoting Imre Deak (2019-04-05 16:36:56) > > Push getting the reference for the encoders' power domains into the > > encoder get_power_domain() hook instead of doing this from the caller. > > This way the encoder can store away the corr