[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: adding state checker for gamma lut values (rev2)

2019-03-27 Thread Patchwork
== Series Details == Series: drm/i915: adding state checker for gamma lut values (rev2) URL : https://patchwork.freedesktop.org/series/58039/ State : failure == Summary == Applying: drm/i915: adding state checker for gamma lut values Using index info to reconstruct a base tree... M drive

Re: [Intel-gfx] [PATCH] gpu:drm: Remove duplicate headers

2019-03-27 Thread Laurent Pinchart
Hi Jagadeesh, Thank you for the patch. On Thu, Mar 28, 2019 at 02:41:56AM +0530, jagdsh.li...@gmail.com wrote: > From: Jagadeesh Pagadala > > Remove duplicate headers which are included twice. Could you, while at it, also sort the existing #include statements alphabetically ? This should help

[Intel-gfx] [PATCH] drm/i915: adding state checker for gamma lut values

2019-03-27 Thread Swati Sharma
Added state checker to validate gamma_lut values. This reads hardware state, and compares the originally requested state to the state read from hardware. v1: -Implementation done for legacy platforms (removed all the placeholders) (Jani) -Added inverse function of drm_color_lut_extract to con

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/4] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev2)

2019-03-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev2) URL : https://patchwork.freedesktop.org/series/58273/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5825_full -> Patchwork_12613_full ==

Re: [Intel-gfx] [PATCH] drm/i915: Disable semaphore on vGPU for now

2019-03-27 Thread Zhenyu Wang
On 2019.03.27 09:15:36 +, Chris Wilson wrote: > Quoting Zhenyu Wang (2019-03-27 09:06:36) > > This is to disable semaphore usage when on vGPU for now. Unfortunately > > GVT-g hasn't fully enabled semaphore usage yet, so current guest with > > semaphore use would cause vGPU failure. > > > > Alt

Re: [Intel-gfx] [PULL] drm-intel-next

2019-03-27 Thread Dave Airlie
On Mon, 25 Mar 2019 at 22:49, Joonas Lahtinen wrote: > > Hi Dave & Daniel, > > First batch of features for 5.2, tagged last week. I asked on irc, but got no answer I saw, /home/airlied/devel/kernel/dim/src/drivers/gpu/drm/i915/i915_gem_context.c:698:12: warning: ‘context_barrier_task’ defined but

Re: [Intel-gfx] [PATCH 08/21] drm/exynos: Use drm_fb_helper_fill_info

2019-03-27 Thread Inki Dae
19. 3. 26. 오후 10:19에 Daniel Vetter 이(가) 쓴 글: > This will give the exynos fbdev a name! > > v2: Rebase > > Signed-off-by: Daniel Vetter Acked-by: Inki Dae Thanks, Inki Dae > Cc: Inki Dae > Cc: Joonyoung Shim > Cc: Seung-Woo Kim > Cc: Kyungmin Park > Cc: Kukjin Kim > Cc: Krzysztof Kozlo

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Disable semaphore on vGPU for now

2019-03-27 Thread Patchwork
== Series Details == Series: drm/i915: Disable semaphore on vGPU for now URL : https://patchwork.freedesktop.org/series/58627/ State : success == Summary == CI Bug Log - changes from CI_DRM_5823_full -> Patchwork_12611_full Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Clean up intel_color_check() (rev2)

2019-03-27 Thread Patchwork
== Series Details == Series: drm/i915: Clean up intel_color_check() (rev2) URL : https://patchwork.freedesktop.org/series/58137/ State : success == Summary == CI Bug Log - changes from CI_DRM_5829 -> Patchwork_12618 Summary --- **SUC

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Clean up intel_color_check() (rev2)

2019-03-27 Thread Patchwork
== Series Details == Series: drm/i915: Clean up intel_color_check() (rev2) URL : https://patchwork.freedesktop.org/series/58137/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Extract check_luts() Okay! Commit: drm/i915: Turn intel_color_che

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/2] drm/i915/icl: Ungate ddi clocks before IO enable (rev2)

2019-03-27 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915/icl: Ungate ddi clocks before IO enable (rev2) URL : https://patchwork.freedesktop.org/series/58527/ State : success == Summary == CI Bug Log - changes from CI_DRM_5828 -> Patchwork_12617 =

[Intel-gfx] ✓ Fi.CI.BAT: success for Device id consolidation (rev2)

2019-03-27 Thread Patchwork
== Series Details == Series: Device id consolidation (rev2) URL : https://patchwork.freedesktop.org/series/58561/ State : success == Summary == CI Bug Log - changes from CI_DRM_5827 -> Patchwork_12616 Summary --- **SUCCESS** No re

[Intel-gfx] [PATCH AUTOSEL 4.14 068/123] drm: allow render capable master with DRM_AUTH ioctls

2019-03-27 Thread Sasha Levin
From: Emil Velikov [ Upstream commit 8059add0478e29cb641936011a8fcc9ce9fd80be ] There are cases (in mesa and applications) where one would open the primary node without properly authenticating the client. Sometimes we don't check if the authentication succeeds, but there's also cases we simply

[Intel-gfx] [PATCH AUTOSEL 4.19 102/192] drm: allow render capable master with DRM_AUTH ioctls

2019-03-27 Thread Sasha Levin
From: Emil Velikov [ Upstream commit 8059add0478e29cb641936011a8fcc9ce9fd80be ] There are cases (in mesa and applications) where one would open the primary node without properly authenticating the client. Sometimes we don't check if the authentication succeeds, but there's also cases we simply

[Intel-gfx] [PATCH AUTOSEL 5.0 147/262] drm: allow render capable master with DRM_AUTH ioctls

2019-03-27 Thread Sasha Levin
From: Emil Velikov [ Upstream commit 8059add0478e29cb641936011a8fcc9ce9fd80be ] There are cases (in mesa and applications) where one would open the primary node without properly authenticating the client. Sometimes we don't check if the authentication succeeds, but there's also cases we simply

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/fb-helper: Fixup fill_info cleanup

2019-03-27 Thread Patchwork
== Series Details == Series: drm/fb-helper: Fixup fill_info cleanup URL : https://patchwork.freedesktop.org/series/58640/ State : success == Summary == CI Bug Log - changes from CI_DRM_5827 -> Patchwork_12615 Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Device id consolidation (rev2)

2019-03-27 Thread Patchwork
== Series Details == Series: Device id consolidation (rev2) URL : https://patchwork.freedesktop.org/series/58561/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Split Pineview device info into desktop and mobile -drivers/gpu/drm/i915/selftest

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Device id consolidation (rev2)

2019-03-27 Thread Patchwork
== Series Details == Series: Device id consolidation (rev2) URL : https://patchwork.freedesktop.org/series/58561/ State : warning == Summary == $ dim checkpatch origin/drm-tip 41661f3ceb00 drm/i915: Split Pineview device info into desktop and mobile 871661fc5d65 drm/i915: Remove redundant devi

Re: [Intel-gfx] [PATCH v3 10/10] drm/i915: uevent for HDCP status change

2019-03-27 Thread Daniel Vetter
On Wed, Mar 27, 2019 at 08:07:39PM +0530, Ramalingam C wrote: > On 2019-03-27 at 12:06:39 +0100, Daniel Vetter wrote: > > On Fri, Mar 22, 2019 at 06:14:48AM +0530, Ramalingam C wrote: > > > Invoking the uevent generator for the content protection property state > > > change of a connector. This hel

Re: [Intel-gfx] [PATCH v3 08/10] drm/i915: Populate downstream info for HDCP2.2

2019-03-27 Thread Daniel Vetter
On Wed, Mar 27, 2019 at 08:19:55PM +0530, Ramalingam C wrote: > On 2019-03-27 at 11:31:12 +0100, Daniel Vetter wrote: > > On Fri, Mar 22, 2019 at 06:14:46AM +0530, Ramalingam C wrote: > > > Populates the downstream info for HDCP2.2 encryption also. On success > > > of encryption Blob is updated. >

Re: [Intel-gfx] [PATCH v2 00/10] drm/i915: Clean up intel_color_check()

2019-03-27 Thread Matt Roper
On Wed, Mar 27, 2019 at 05:50:35PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Repost of the earlier series to clean up intel_color_check(). > I tried to address all of Matt's review comments (thanks!). > > All reviewed except patch 8. Patch 8 (and the rest of the series): Reviewed-b

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/fb-helper: Fixup fill_info cleanup

2019-03-27 Thread Patchwork
== Series Details == Series: drm/fb-helper: Fixup fill_info cleanup URL : https://patchwork.freedesktop.org/series/58640/ State : warning == Summary == $ dim checkpatch origin/drm-tip 255bbefc078f drm/fb-helper: Fixup fill_info cleanup -:16: WARNING:BAD_SIGN_OFF: Use a single space after Repor

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Reject rotation for some hdr formats

2019-03-27 Thread Maarten Lankhorst
Op 22-03-2019 om 15:06 schreef Ville Syrjälä: > On Fri, Mar 22, 2019 at 02:59:54PM +0100, Maarten Lankhorst wrote: >> 90/270 rotation is not supported for Y21x and the 12/16 bits XVYU formats, >> reject support for them. >> >> Signed-off-by: Maarten Lankhorst > Reviewed-by: Ville Syrjälä > >> ---

Re: [Intel-gfx] [PATCH 16/16] drm/vc4: Call drm_dev_register() after all setup is done

2019-03-27 Thread Eric Anholt
Noralf Trønnes writes: > drm_dev_register() initializes internal clients like bootsplash as the > last thing it does, so all setup needs to be done at this point. > > Fix by calling vc4_kms_load() before registering. > Also check the error code returned from that function. > > Cc: Eric Anholt >

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm: connector firmware nodes

2019-03-27 Thread Tvrtko Ursulin
On 27/03/2019 15:38, Heikki Krogerus wrote: Hi Jani, On Tue, Mar 26, 2019 at 03:16:29PM +, Saarinen, Jani wrote: -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Heikki Krogerus Sent: tiistai 26. maaliskuuta 2019 10.32 To: intel-gfx@

[Intel-gfx] [PATCH v2 09/10] drm/i915: Drop the pointless linear legacy LUT load on CHV

2019-03-27 Thread Ville Syrjala
From: Ville Syrjälä We now bypass the legacy LUT when it's not needed, so no point in filling it up with a linear LUT. Signed-off-by: Ville Syrjälä Reviewed-by: Matt Roper --- drivers/gpu/drm/i915/intel_color.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --gi

[Intel-gfx] [PATCH v2 10/10] drm/i915: Skip the linear degamma LUT load on ICL+

2019-03-27 Thread Ville Syrjala
From: Ville Syrjälä Don't load the linear degamma LUT on ICL. The hardware no longer has any silly linkages between the CSC enable and degamma LUT enable so the degamma LUT is only needed when it's actually enabled. Also add comments to explain the situation on GLK. v2: Drop useless parens arou

[Intel-gfx] [PATCH v2 04/10] drm/i915: Extract chv_color_check()

2019-03-27 Thread Ville Syrjala
From: Ville Syrjälä Since CHV has the CGM unit we require a custom implementation of .color_check(). This fixes the computation of gamma_enable as previously we left it enabled even when were using the CGM gamma instead. Now we turn off the legacy LUT unless it's actually required. v2: Add some

[Intel-gfx] [PATCH v2 06/10] drm/i915: Extract glk_color_check()

2019-03-27 Thread Ville Syrjala
From: Ville Syrjälä Unlike the earlier platforms GLK has dedicated degamma and gamma LUTs. And quite curiously the degamma LUT is actually controlled via the PLANE_COLOR_CTL CSC enable bit. Hence we must compute gamma_enable and csc_enable differently to pre-GLK platforms. Signed-off-by: Ville S

[Intel-gfx] [PATCH v2 08/10] drm/i915: Extract ilk_color_check()

2019-03-27 Thread Ville Syrjala
From: Ville Syrjälä With everything else moved out of the way only ilk+ remains using _intel_color_check(). Streamline the logic into ilk_color_check(). v2: Add some comments explaining we that we don't expose the full hardware capabilities currently (Matt) Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 07/10] drm/i915: Extract bdw_color_check()

2019-03-27 Thread Ville Syrjala
From: Ville Syrjälä Provide a separate .color_check() for BDW+ where we currently provide the split gamma mode etc. Signed-off-by: Ville Syrjälä Reviewed-by: Matt Roper --- drivers/gpu/drm/i915/intel_color.c | 39 ++ 1 file changed, 39 insertions(+) diff --git a/d

[Intel-gfx] [PATCH v2 05/10] drm/i915: Extract icl_color_check()

2019-03-27 Thread Ville Syrjala
From: Ville Syrjälä ICL is rather easy when it comes to .color_check() as it finally provides us with a full color pipeline with individual knobs for each stage. We'll also start bypassing each LUT individually when it is not needed. Signed-off-by: Ville Syrjälä Reviewed-by: Matt Roper --- d

[Intel-gfx] [PATCH v2 03/10] drm/i915: Extract i9xx_color_check()

2019-03-27 Thread Ville Syrjala
From: Ville Syrjälä Apart from CHV the other gmch platforms don't currently require much work in .color_check(). So let's start by extracting i9xx_color_check(). Signed-off-by: Ville Syrjälä Reviewed-by: Matt Roper --- drivers/gpu/drm/i915/intel_color.c | 33 +- 1

[Intel-gfx] [PATCH v2 00/10] drm/i915: Clean up intel_color_check()

2019-03-27 Thread Ville Syrjala
From: Ville Syrjälä Repost of the earlier series to clean up intel_color_check(). I tried to address all of Matt's review comments (thanks!). All reviewed except patch 8. Ville Syrjälä (10): drm/i915: Extract check_luts() drm/i915: Turn intel_color_check() into a vfunc drm/i915: Extract i

[Intel-gfx] [PATCH v2 01/10] drm/i915: Extract check_luts()

2019-03-27 Thread Ville Syrjala
From: Ville Syrjälä In prepartion for per-platform color_check() functions extract the common code into a separate function. v2: Improve the C8 comment (Matt) Signed-off-by: Ville Syrjälä Reviewed-by: Matt Roper --- drivers/gpu/drm/i915/intel_color.c | 68 ++ 1 fi

[Intel-gfx] [PATCH v2 02/10] drm/i915: Turn intel_color_check() into a vfunc

2019-03-27 Thread Ville Syrjala
From: Ville Syrjälä The current intel_color_check() is a mess, and worse yet it is in fact incorrect for several platforms. The hardware has evolved quite a bit over the years, so let's just go for a clean split between the platforms by turning this into a vfunc. The actual work to split it up wi

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm: connector firmware nodes

2019-03-27 Thread Heikki Krogerus
Hi Jani, On Tue, Mar 26, 2019 at 03:16:29PM +, Saarinen, Jani wrote: > > -Original Message- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > > Of Heikki > > Krogerus > > Sent: tiistai 26. maaliskuuta 2019 10.32 > > To: intel-gfx@lists.freedesktop.org >

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Drop new chunks of context creation ABI (for now) (rev2)

2019-03-27 Thread Chris Wilson
Quoting Patchwork (2019-03-27 15:06:09) > == Series Details == > > Series: drm/i915: Drop new chunks of context creation ABI (for now) (rev2) > URL : https://patchwork.freedesktop.org/series/58635/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_5825 -> Patchwork_12614

Re: [Intel-gfx] [PATCH 09/16] drm/fb-helper: Move out commit code

2019-03-27 Thread Emmanuel Vadot
On Wed, 27 Mar 2019 16:01:01 +0100 Noralf Trønnes wrote: > > > Den 27.03.2019 15.13, skrev Emmanuel Vadot: > > > > Hi Noralf, > > > > On Tue, 26 Mar 2019 18:55:39 +0100 > > Noralf Trønnes wrote: > > > >> Move the modeset commit code to drm_client. > >> No changes except exporting API. > >>

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Drop new chunks of context creation ABI (for now) (rev2)

2019-03-27 Thread Patchwork
== Series Details == Series: drm/i915: Drop new chunks of context creation ABI (for now) (rev2) URL : https://patchwork.freedesktop.org/series/58635/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5825 -> Patchwork_12614 Sum

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Introduce concept of a sub-platform

2019-03-27 Thread Jani Nikula
On Wed, 27 Mar 2019, Tvrtko Ursulin wrote: > On 27/03/2019 12:03, Jani Nikula wrote: >> A lot of this could go away if we were able to encode a bunch of the >> flags in a single array similar to pciidtable. > > I don't see how we can encode everything to distinguish a platform in an > unsigned lo

Re: [Intel-gfx] [v3 1/2] drm/i915/icl: Ungate ddi clocks before IO enable

2019-03-27 Thread Jani Nikula
On Mon, 25 Mar 2019, Vandita Kulkarni wrote: > IO enable sequencing needs ddi clocks enabled. > These clocks will be gated at a later point in > the enable sequence. > > v2: Fix the commit header (Uma) > v3: Remove the redundant read (Ville) > > Signed-off-by: Vandita Kulkarni > Reviewed-by: Uma

Re: [Intel-gfx] [PATCH 09/16] drm/fb-helper: Move out commit code

2019-03-27 Thread Noralf Trønnes
Den 27.03.2019 15.13, skrev Emmanuel Vadot: > > Hi Noralf, > > On Tue, 26 Mar 2019 18:55:39 +0100 > Noralf Trønnes wrote: > >> Move the modeset commit code to drm_client. >> No changes except exporting API. >> >> Signed-off-by: Noralf Trønnes >> --- >> drivers/gpu/drm/drm_client.c| 236

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Set DP min_bpp to 8*3 for non-RGB output formats

2019-03-27 Thread Ville Syrjälä
On Tue, Mar 26, 2019 at 04:25:56PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > 6bpc is only legal for RGB and RAW pixel encodings. For the rest > the minimum is 8bpc. Set our lower limit accordingly. > > Signed-off-by: Ville Syrjälä Pushed everything except this one. Thanks for the r

Re: [Intel-gfx] [PATCH v3 08/10] drm/i915: Populate downstream info for HDCP2.2

2019-03-27 Thread Ramalingam C
On 2019-03-27 at 11:31:12 +0100, Daniel Vetter wrote: > On Fri, Mar 22, 2019 at 06:14:46AM +0530, Ramalingam C wrote: > > Populates the downstream info for HDCP2.2 encryption also. On success > > of encryption Blob is updated. > > > > Additional two variable are added to downstream info blob. Such

Re: [Intel-gfx] [PATCH v3 09/10] drm: uevent for connector status change

2019-03-27 Thread Ramalingam C
On 2019-03-27 at 12:01:37 +0100, Daniel Vetter wrote: > On Fri, Mar 22, 2019 at 06:14:47AM +0530, Ramalingam C wrote: > > DRM API for generating uevent for a status changes of connector's > > property. > > > > Signed-off-by: Ramalingam C > > --- > > drivers/gpu/drm/drm_sysfs.c | 28 +

Re: [Intel-gfx] [PATCH v3 10/10] drm/i915: uevent for HDCP status change

2019-03-27 Thread Ramalingam C
On 2019-03-27 at 12:06:39 +0100, Daniel Vetter wrote: > On Fri, Mar 22, 2019 at 06:14:48AM +0530, Ramalingam C wrote: > > Invoking the uevent generator for the content protection property state > > change of a connector. This helps the userspace to detect the new state > > change without polling th

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/4] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev2)

2019-03-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev2) URL : https://patchwork.freedesktop.org/series/58273/ State : success == Summary == CI Bug Log - changes from CI_DRM_5825 -> Patchwork_12613

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Introduce concept of a sub-platform

2019-03-27 Thread Tvrtko Ursulin
On 27/03/2019 12:03, Jani Nikula wrote: On Wed, 27 Mar 2019, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-03-27 11:35:41) On 26/03/2019 09:53, Chris Wilson wrote: Quoting Jani Nikula (2019-03-26 09:34:45) Not to block this series, but looking further outside the box... I've still got

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: fix i386 build of 64b raw_uncore functions

2019-03-27 Thread Patchwork
== Series Details == Series: drm/i915: fix i386 build of 64b raw_uncore functions URL : https://patchwork.freedesktop.org/series/58611/ State : success == Summary == CI Bug Log - changes from CI_DRM_5819_full -> Patchwork_12610_full Summary

Re: [Intel-gfx] [PATCH 03/16] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-03-27 Thread Noralf Trønnes
Den 27.03.2019 14.55, skrev Daniel Vetter: > On Wed, Mar 27, 2019 at 2:42 PM Noralf Trønnes wrote: >> >> >> >> Den 26.03.2019 21.48, skrev Daniel Vetter: >>> On Tue, Mar 26, 2019 at 06:55:33PM +0100, Noralf Trønnes wrote: Prepare for moving drm_fb_helper modesetting code to drm_client.

[Intel-gfx] [PATCH v8 4/4] drm/i915: Introduce concept of a sub-platform

2019-03-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Concept of a sub-platform already exist in our code (like ULX and ULT platform variants and similar),implemented via the macros which check a list of device ids to determine a match. With this patch we consolidate device ids checking into a single function called during earl

Re: [Intel-gfx] [PATCH v3 06/10] drm: Add CP downstream_info property

2019-03-27 Thread Daniel Vetter
On Wed, Mar 27, 2019 at 2:58 PM Ramalingam C wrote: > > On 2019-03-27 at 11:25:04 +0100, Daniel Vetter wrote: > > On Fri, Mar 22, 2019 at 06:14:44AM +0530, Ramalingam C wrote: > > > This patch adds a optional CP downstream info blob property to the > > > connectors. This enables the Userspace to r

Re: [Intel-gfx] [PATCH 09/16] drm/fb-helper: Move out commit code

2019-03-27 Thread Emmanuel Vadot
Hi Noralf, On Tue, 26 Mar 2019 18:55:39 +0100 Noralf Trønnes wrote: > Move the modeset commit code to drm_client. > No changes except exporting API. > > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/drm_client.c| 236 > drivers/gpu/drm/drm_fb_hel

Re: [Intel-gfx] [PATCH] drm/fb-helper: Fixup fill_info cleanup

2019-03-27 Thread Daniel Vetter
On Wed, Mar 27, 2019 at 02:29:01PM +0100, Noralf Trønnes wrote: > > > Den 27.03.2019 13.58, skrev Daniel Vetter: > > I forgot the !CONFIG_FBDEV case. Also some kerneldoc needed more > > adjusting. > > > > Cc: Noralf Trønnes > > Cc: Alex Deucher > > Signed-off-by: Daniel Vetter > > --- > > Re

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Make sure we have enough memory bandwidth on ICL

2019-03-27 Thread Maarten Lankhorst
Op 20-03-2019 om 22:46 schreef Ville Syrjala: > From: Ville Syrjälä > > ICL has so many planes that it can easily exceed the maximum > effective memory bandwidth of the system. We must therefore check > that we don't exceed that limit. > > The algorithm is very magic number heavy and lacks suffici

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/4] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev2)

2019-03-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915: Force 2*96 MHz cdclk on glk/cnl when audio power is enabled (rev2) URL : https://patchwork.freedesktop.org/series/58273/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Forc

Re: [Intel-gfx] [PATCH 03/16] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-03-27 Thread Daniel Vetter
On Wed, Mar 27, 2019 at 2:42 PM Noralf Trønnes wrote: > > > > Den 26.03.2019 21.48, skrev Daniel Vetter: > > On Tue, Mar 26, 2019 at 06:55:33PM +0100, Noralf Trønnes wrote: > >> Prepare for moving drm_fb_helper modesetting code to drm_client. > >> drm_client will be linked to drm.ko, so move > >>

Re: [Intel-gfx] [PATCH v3 06/10] drm: Add CP downstream_info property

2019-03-27 Thread Ramalingam C
On 2019-03-27 at 11:25:04 +0100, Daniel Vetter wrote: > On Fri, Mar 22, 2019 at 06:14:44AM +0530, Ramalingam C wrote: > > This patch adds a optional CP downstream info blob property to the > > connectors. This enables the Userspace to read the information of HDCP > > authenticated downstream topolo

Re: [Intel-gfx] [PATCH 00/16] drm/fb-helper: Move modesetting code to drm_client

2019-03-27 Thread Thomas Zimmermann
Hi Am 27.03.19 um 14:45 schrieb Noralf Trønnes: > > > Den 26.03.2019 18.55, skrev Noralf Trønnes: >> This moves the modesetting code from drm_fb_helper to drm_client so it >> can be shared by all internal clients. >> >> I have also added a client display abstraction and a bootsplash example >> c

Re: [Intel-gfx] [PATCH v3 04/10] drm/i915: HDCP SRM parsing and revocation check

2019-03-27 Thread Ramalingam C
On 2019-03-27 at 11:16:40 +0100, Daniel Vetter wrote: > On Fri, Mar 22, 2019 at 06:14:42AM +0530, Ramalingam C wrote: > > Implements the SRM table parsing for HDCP 1.4 and 2.2. > > And also revocation check is added at authentication of HDCP1.4 > > and 2.2 > > > > Signed-off-by: Ramalingam C > >

Re: [Intel-gfx] [PATCH 00/16] drm/fb-helper: Move modesetting code to drm_client

2019-03-27 Thread Noralf Trønnes
Den 26.03.2019 18.55, skrev Noralf Trønnes: > This moves the modesetting code from drm_fb_helper to drm_client so it > can be shared by all internal clients. > > I have also added a client display abstraction and a bootsplash example > client to show where this might be heading. Hopefully Max St

Re: [Intel-gfx] [PATCH 03/16] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2019-03-27 Thread Noralf Trønnes
Den 26.03.2019 21.48, skrev Daniel Vetter: > On Tue, Mar 26, 2019 at 06:55:33PM +0100, Noralf Trønnes wrote: >> Prepare for moving drm_fb_helper modesetting code to drm_client. >> drm_client will be linked to drm.ko, so move >> __drm_atomic_helper_disable_plane() and __drm_atomic_helper_set_confi

Re: [Intel-gfx] [PATCH v3 03/10] drm/i915: Attach content type property

2019-03-27 Thread Ramalingam C
On 2019-03-27 at 11:00:17 +0100, Daniel Vetter wrote: > On Fri, Mar 22, 2019 at 06:14:41AM +0530, Ramalingam C wrote: > > Attaches the content type property for HDCP2.2 capable connectors. > > > > Implements the update of content type from property and apply the > > restriction on HDCP version sel

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/icl: Fix VEBOX mismatch BUG_ON()

2019-03-27 Thread Patchwork
== Series Details == Series: drm/i915/icl: Fix VEBOX mismatch BUG_ON() URL : https://patchwork.freedesktop.org/series/58609/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5819_full -> Patchwork_12609_full Summary ---

Re: [Intel-gfx] [PATCH v3 02/10] drm: Add Content protection type property

2019-03-27 Thread Ramalingam C
On 2019-03-27 at 10:56:32 +0100, Daniel Vetter wrote: > On Fri, Mar 22, 2019 at 06:14:40AM +0530, Ramalingam C wrote: > > This patch adds a DRM ENUM property to the selected connectors. > > This property is used for mentioning the protected content's type > > from userspace to kernel HDCP authentic

Re: [Intel-gfx] [PATCH 06/16] drm/i915/fbdev: Move intel_fb_initial_config() to fbdev helper

2019-03-27 Thread Jani Nikula
On Tue, 26 Mar 2019, Noralf Trønnes wrote: > It is generic code and having it in the helper will let other drivers > benefit from it. > > One change was necessary assuming this to be true: > INTEL_INFO(dev_priv)->num_pipes == dev->mode_config.num_crtc This holds after intel_modeset_init(), in tim

Re: [Intel-gfx] [PATCH] drm/fb-helper: Fixup fill_info cleanup

2019-03-27 Thread Noralf Trønnes
Den 27.03.2019 13.58, skrev Daniel Vetter: > I forgot the !CONFIG_FBDEV case. Also some kerneldoc needed more > adjusting. > > Cc: Noralf Trønnes > Cc: Alex Deucher > Signed-off-by: Daniel Vetter > --- Really nice that we have all these bots helping us out. Reviewed-by: Noralf Trønnes >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Fix an IS_ERR() vs NULL check (rev3)

2019-03-27 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Fix an IS_ERR() vs NULL check (rev3) URL : https://patchwork.freedesktop.org/series/58557/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5824 -> Patchwork_12612 Summary -

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do not enable FEC without DSC

2019-03-27 Thread Ville Syrjälä
On Tue, Mar 26, 2019 at 11:10:44AM -0700, Manasi Navare wrote: > On Tue, Mar 26, 2019 at 06:16:57PM +0200, Ville Syrjälä wrote: > > On Tue, Mar 26, 2019 at 09:00:27AM -0700, Manasi Navare wrote: > > > On Tue, Mar 26, 2019 at 04:49:02PM +0200, Ville Syrjala wrote: > > > > From: Ville Syrjälä > > >

[Intel-gfx] [PATCH] drm/fb-helper: Fixup fill_info cleanup

2019-03-27 Thread Daniel Vetter
I forgot the !CONFIG_FBDEV case. Also some kerneldoc needed more adjusting. Cc: Noralf Trønnes Cc: Alex Deucher Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 5 ++--- include/drm/drm_fb_helper.h | 18 ++ 2 files changed, 8 insertions(+), 15 deletions(-

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable semaphore on vGPU for now

2019-03-27 Thread Patchwork
== Series Details == Series: drm/i915: Disable semaphore on vGPU for now URL : https://patchwork.freedesktop.org/series/58627/ State : success == Summary == CI Bug Log - changes from CI_DRM_5823 -> Patchwork_12611 Summary --- **SUCCE

Re: [Intel-gfx] [v6 01/16] drm: Add Enhanced Gamma LUT precision structure

2019-03-27 Thread Lankhorst, Maarten
tis 2019-03-19 klockan 14:14 +0530 skrev Uma Shankar: > Existing LUT precision structure is having only 16 bit > precision. This is not enough for upcoming enhanced hardwares > and advance usecases like HDR processing. Hence added a new > structure with 32 bit precision values. Also added the code,

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Introduce concept of a sub-platform

2019-03-27 Thread Jani Nikula
On Wed, 27 Mar 2019, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2019-03-27 11:35:41) >> >> On 26/03/2019 09:53, Chris Wilson wrote: >> > Quoting Jani Nikula (2019-03-26 09:34:45) >> >> Not to block this series, but looking further outside the box... >> >> >> >> I've still got the constant vs.

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Introduce concept of a sub-platform

2019-03-27 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-03-27 11:35:41) > > On 26/03/2019 09:53, Chris Wilson wrote: > > Quoting Jani Nikula (2019-03-26 09:34:45) > >> Not to block this series, but looking further outside the box... > >> > >> I've still got the constant vs. runtime device info split > >> unfinished. We've g

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Introduce concept of a sub-platform

2019-03-27 Thread Tvrtko Ursulin
On 26/03/2019 08:39, Jani Nikula wrote: On Tue, 26 Mar 2019, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Concept of a sub-platform already exist in our code (like ULX and ULT platform variants and similar),implemented via the macros which check a list of device ids to determine a match. With

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Introduce concept of a sub-platform

2019-03-27 Thread Tvrtko Ursulin
On 26/03/2019 09:53, Chris Wilson wrote: Quoting Jani Nikula (2019-03-26 09:34:45) Not to block this series, but looking further outside the box... I've still got the constant vs. runtime device info split unfinished. We've got so many things that are mostly constant, but occasionally need cha

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree

2019-03-27 Thread Stephen Rothwell
Hi Joonas, On Wed, 27 Mar 2019 13:07:40 +0200 Joonas Lahtinen wrote: > > Quoting Stephen Rothwell (2019-03-27 04:59:04) > > > > After merging the drm-intel tree, today's linux-next build (i386 > > defconfig) failed like this: > > We had a CI reporting mishap, where a failed 32-bit build resu

Re: [Intel-gfx] [PATCH 11/21] drm/i915: Use drm_fb_helper_fill_info

2019-03-27 Thread Daniel Vetter
On Wed, Mar 27, 2019 at 12:10 PM Joonas Lahtinen wrote: > > Quoting Daniel Vetter (2019-03-26 15:19:58) > > This changes the fb name from "inteldrmfb" to "i915drmfb". > > I'm fairly sure I already commented that is is Acked-by in the > case the other drivers are doing the same consolidation. > > J

Re: [Intel-gfx] [PATCH 11/21] drm/i915: Use drm_fb_helper_fill_info

2019-03-27 Thread Joonas Lahtinen
Quoting Daniel Vetter (2019-03-26 15:19:58) > This changes the fb name from "inteldrmfb" to "i915drmfb". I'm fairly sure I already commented that is is Acked-by in the case the other drivers are doing the same consolidation. Just have to make sure we don't break any IGTs that might depend on the

Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel tree

2019-03-27 Thread Joonas Lahtinen
Quoting Stephen Rothwell (2019-03-27 04:59:04) > Hi all, > > After merging the drm-intel tree, today's linux-next build (i386 > defconfig) failed like this: We had a CI reporting mishap, where a failed 32-bit build resulted in a misleading success e-mail being sent. The tree is now fixed and we'

Re: [Intel-gfx] [PATCH v3 10/10] drm/i915: uevent for HDCP status change

2019-03-27 Thread Daniel Vetter
On Fri, Mar 22, 2019 at 06:14:48AM +0530, Ramalingam C wrote: > Invoking the uevent generator for the content protection property state > change of a connector. This helps the userspace to detect the new state > change without polling the property val. > > Signed-off-by: Ramalingam C > --- > dri

Re: [Intel-gfx] [PATCH v2] drm/i915: Drop new chunks of context creation ABI (for now)

2019-03-27 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-03-27 12:58:14) > The intent was to expose these as part of the means to perform full > context recovery (though not the SINGLE_TIMELINE, that is for later and > just sucked as collateral damage). As that requires a couple more > patches to complete the series, roll back

Re: [Intel-gfx] [PATCH v3 09/10] drm: uevent for connector status change

2019-03-27 Thread Daniel Vetter
On Fri, Mar 22, 2019 at 06:14:47AM +0530, Ramalingam C wrote: > DRM API for generating uevent for a status changes of connector's > property. > > Signed-off-by: Ramalingam C > --- > drivers/gpu/drm/drm_sysfs.c | 28 > include/drm/drm_sysfs.h | 5 - > 2 files

Re: [Intel-gfx] [PATCH v3 09/10] drm: uevent for connector status change

2019-03-27 Thread Daniel Vetter
On Fri, Mar 22, 2019 at 06:14:47AM +0530, Ramalingam C wrote: > DRM API for generating uevent for a status changes of connector's > property. > > Signed-off-by: Ramalingam C > --- > drivers/gpu/drm/drm_sysfs.c | 28 > include/drm/drm_sysfs.h | 5 - > 2 files

Re: [Intel-gfx] [PATCH] drm/i915: Drop new chunks of context creation ABI (for now)

2019-03-27 Thread Joonas Lahtinen
Quoting Chris Wilson (2019-03-27 12:37:35) > The intent was to expose these as part of the means to perform full > context recovery (though not the SINGLE_TIMELINE, that is for later and > just sucked as collateral damage). As that requires a couple more > patches to complete the series, roll back

[Intel-gfx] [PATCH v2] drm/i915: Drop new chunks of context creation ABI (for now)

2019-03-27 Thread Chris Wilson
The intent was to expose these as part of the means to perform full context recovery (though not the SINGLE_TIMELINE, that is for later and just sucked as collateral damage). As that requires a couple more patches to complete the series, roll back the earlier chunks of ABI for an intervening PR. We

Re: [Intel-gfx] [PATCH v5 2/5] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-03-27 Thread Tvrtko Ursulin
On 27/03/2019 01:58, Carlos Santa wrote: [snip] v13: Rebase v14: Rebase, skip checking for the guilty seqno in the tasklet (Tvrtko) IIRC I only asked about it so I guess you tried it and it works well? Can you also post the IGTs so we can see the test coverage? Regards, Tvrtko Yeah, the

[Intel-gfx] [PATCH] drm/i915: Drop new chunks of context creation ABI (for now)

2019-03-27 Thread Chris Wilson
The intent was to expose these as part of the means to perform full context recovery (though not the SINGLE_TIMELINE, that is for later and just sucked as collateral damage). As that requires a couple more patches to complete the series, roll back the earlier chunks of ABI for an intervening PR. We

Re: [Intel-gfx] [PATCH v3 08/10] drm/i915: Populate downstream info for HDCP2.2

2019-03-27 Thread Daniel Vetter
On Fri, Mar 22, 2019 at 06:14:46AM +0530, Ramalingam C wrote: > Populates the downstream info for HDCP2.2 encryption also. On success > of encryption Blob is updated. > > Additional two variable are added to downstream info blob. Such as > ver_in_force and content type. > > v2: > s/cp_downstrea

Re: [Intel-gfx] [PATCH v3 07/10] drm/i915: Populate downstream info for HDCP1.4

2019-03-27 Thread Daniel Vetter
On Fri, Mar 22, 2019 at 06:14:45AM +0530, Ramalingam C wrote: > Implements drm blob property content_protection_downstream_info > property on HDCP capable connectors. > > Downstream topology info is gathered across authentication stages > and stored in intel_hdcp. When HDCP authentication is compl

Re: [Intel-gfx] [PATCH v3 06/10] drm: Add CP downstream_info property

2019-03-27 Thread Daniel Vetter
On Fri, Mar 22, 2019 at 06:14:44AM +0530, Ramalingam C wrote: > This patch adds a optional CP downstream info blob property to the > connectors. This enables the Userspace to read the information of HDCP > authenticated downstream topology. > > Driver will updated this blob with all downstream inf

Re: [Intel-gfx] [PATCH v3 04/10] drm/i915: HDCP SRM parsing and revocation check

2019-03-27 Thread Daniel Vetter
On Fri, Mar 22, 2019 at 06:14:42AM +0530, Ramalingam C wrote: > Implements the SRM table parsing for HDCP 1.4 and 2.2. > And also revocation check is added at authentication of HDCP1.4 > and 2.2 > > Signed-off-by: Ramalingam C > --- > drivers/gpu/drm/i915/i915_drv.c | 1 + > drivers/gpu/drm/

[Intel-gfx] [PATCH v9 4/4] drm/i915: Skip modeset for cdclk changes if possible

2019-03-27 Thread Imre Deak
From: Ville Syrjälä If we have only a single active pipe and the cdclk change only requires the cd2x divider to be updated bxt+ can do the update with forcing a full modeset on the pipe. Try to hook that up. v2: - Wait for vblank after an optimized CDCLK change. - Avoid optimization if the pipe

Re: [Intel-gfx] [PATCH v3 03/10] drm/i915: Attach content type property

2019-03-27 Thread Daniel Vetter
On Fri, Mar 22, 2019 at 06:14:41AM +0530, Ramalingam C wrote: > Attaches the content type property for HDCP2.2 capable connectors. > > Implements the update of content type from property and apply the > restriction on HDCP version selection. > > v2: > s/cp_content_type/content_protection_type [

Re: [Intel-gfx] [PATCH v3 02/10] drm: Add Content protection type property

2019-03-27 Thread Daniel Vetter
On Fri, Mar 22, 2019 at 06:14:40AM +0530, Ramalingam C wrote: > This patch adds a DRM ENUM property to the selected connectors. > This property is used for mentioning the protected content's type > from userspace to kernel HDCP authentication. > > Type of the stream is decided by the protected con

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check

2019-03-27 Thread Chris Wilson
Quoting Mika Kuoppala (2019-03-27 09:32:14) > The live_context() function returns error pointers. It never returns > NULL. > > v2: don't clamp the err (Chris) > > Fixes: 52c0fdb25c7c ("drm/i915: Replace global breadcrumbs with per-context > interrupt tracking") > Signed-off-by: Mika Kuoppala R

Re: [Intel-gfx] [PATCH v3 01/10] drm/i915: debugfs: HDCP2.2 capability read

2019-03-27 Thread Daniel Vetter
On Fri, Mar 22, 2019 at 06:14:39AM +0530, Ramalingam C wrote: > Adding the HDCP2.2 capability of HDCP src and sink info into debugfs > entry "i915_hdcp_sink_capability" > > This helps the userspace tests to skip the HDCP2.2 test on non HDCP2.2 > sinks. > > Signed-off-by: Ramalingam C Still not

Re: [Intel-gfx] [PATCH] drm/i915: Disable semaphore on vGPU for now

2019-03-27 Thread Chris Wilson
Quoting Zhenyu Wang (2019-03-27 09:06:36) > This is to disable semaphore usage when on vGPU for now. Unfortunately > GVT-g hasn't fully enabled semaphore usage yet, so current guest with > semaphore use would cause vGPU failure. > > Although current semaphore failure with vGPU can be simply resolv

Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix VEBOX mismatch BUG_ON()

2019-03-27 Thread Tvrtko Ursulin
On 26/03/2019 23:06, Chris Wilson wrote: Quoting José Roberto de Souza (2019-03-26 23:02:23) GT VEBOX DISABLE is only 4 bits wide but it was using a 8 bits wide mask, the remaning reserved bits is set to 0 causing 4 more nonexistent VEBOX engines being detected as enabled, triggering the BUG_ON

  1   2   >