== Series Details ==
Series: series starting with [v12,1/8] drm/i915: Introduce CRTC output format
URL : https://patchwork.freedesktop.org/series/50897/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4976 -> Patchwork_10433 =
== Summary - SUCCESS ==
No regressions found.
== Series Details ==
Series: series starting with [v12,1/8] drm/i915: Introduce CRTC output format
URL : https://patchwork.freedesktop.org/series/50897/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
b69fba58f360 drm/i915: Introduce CRTC output format
fbd32b6ad34e drm/i915: Add
From: Tvrtko Ursulin
GEM_WARN_ON currently has dangerous semantics where it is completely
compiled out on !GEM_DEBUG builds. This can leave users who expect it to
be more like a WARN_ON, just without a warning in non-debug builds, in
complete ignorance.
Another gotcha with it is that it cannot b
From: Shashank Sharma
This patch adds support for YCBCR 4:4:4 CRTC output format.
To do this, this patch extends the existing YCBCR 4:2:0
framework by:
- Adding new parameter in for YCBCR 4:4:4 enum crtc_iutput_format.
- Adding case for YCBCR 4:4:4 in while setting AVI infoframes.
- Adding necess
Different LSPCON vendors specify their custom methods to pass
AVI infoframes to the LSPCON chip, so does Parade tech.
This patch adds functions to arrange and write AVI infoframes
into Parade LSPCON chips.
V2: rebase
V3: Added r-b from Maarten
V4: rebase
V5: rebase
V6: rebase
V7: Fixed checkpatch
From: Shashank Sharma
LSPCON is a DP branch device, so LSPCON vendors define
specific methods to pass AVI infoframes to the the chip.
This patch adds:
- a generic wrapper function for writing AVI infoframes for
all LSPCON devices.
- a vendor specific function to wrire AVI infoframes into
MCA
From: Shashank Sharma
Currently, we are using a bool in CRTC state (state->ycbcr420),
to indicate modeset, that the output format is YCBCR 4:2:0. Now in
order to support other YCBCR formats, we will need more such flags.
This patch adds a new enum parameter for YCBCR 4:2:0 outputs, in the
CRTC o
From: "Sharma, Shashank"
Intel LSPCON chip is provided by 2 vendors:
- Megachips America (MCA)
- Parade technologies (Parade tech)
Its important to know the vendor of this chip, as the address to
write AVI infoframes is different for those two.
This patch reads the vendor OUI signature, and mar
This patch adds an enum "intel_output_format" to represent
the output format of a particular CRTC. This enum will be
used to produce a RGB/YCBCR4:4:4/YCBCR4:2:0 output format
during the atomic modeset calculations.
V5:
- Created this separate patch to introduce and init output_format.
- Initialize
In order to pass AVI infoframes to LSPCON devices, a source has to
write them in a vendor recommended method and location.
This patch series:
- adds generic LSPCON infoframe setup functions.
- registers these functions into existing AVI infoframe framework.
- triggers these functions from modeset
From: Shashank Sharma
LSPCON chips can generate YCBCR outputs, if asked nicely :).
In order to generate YCBCR 4:2:0 outputs, a source must:
- send YCBCR 4:4:4 signals to LSPCON
- program color space as 4:2:0 in AVI infoframes
Whereas for YCBCR 4:4:4 outputs, the source must:
- send YCBCR 4:4:4
== Series Details ==
Series: drm/i915/icl: enable SAGV for ICL platform
URL : https://patchwork.freedesktop.org/series/50888/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4975_full -> Patchwork_10431_full =
== Summary - WARNING ==
Minor unknown changes coming with Patch
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.19-rc7 next-20181011]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com
== Series Details ==
Series: drm/i915/cnp+: update to the new RAWCLK_FREQ recommendations
URL : https://patchwork.freedesktop.org/series/50893/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4975 -> Patchwork_10432 =
== Summary - FAILURE ==
Serious unknown changes coming
These are the new recommended values provided by our spec (18 -> 19
and 23 -> 24). It seems this should help fixing GMBUS issues. Since
we're doing pretty much the same thing for both CNP and ICP now, unify
the functions using the ICP version since it's more straightforward by
just matching the val
== Series Details ==
Series: drm/i915/icl: enable SAGV for ICL platform
URL : https://patchwork.freedesktop.org/series/50888/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4975 -> Patchwork_10431 =
== Summary - SUCCESS ==
No regressions found.
External URL:
https://p
From: Mahesh Kumar
Enable SAGV for ICL platform.
Cc: Gwan-gyeong Mun
Reviewed-by: James Ausmus
Reviewed-by: Paulo Zanoni
Signed-off-by: Mahesh Kumar
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_pm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
I had previously block
Hi Chris,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on v4.19-rc7 next-20181011]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com
== Series Details ==
Series: drm/i915/perf: Add OA buffer size uAPI parameter (rev2)
URL : https://patchwork.freedesktop.org/series/50810/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969_full -> Patchwork_10429_full =
== Summary - SUCCESS ==
No regressions found.
On Wed, Oct 10, 2018 at 11:21 PM Jani Nikula
wrote:
>
> On Wed, 10 Oct 2018, Nick Desaulniers wrote:
> > On Wed, Oct 10, 2018 at 1:30 PM Michal Wajdeczko
> > wrote:
> >>
> >> On Wed, 10 Oct 2018 14:01:40 +0200, Jani Nikula
> >> wrote:
> >>
> >> > On Tue, 09 Oct 2018, Nick Desaulniers wrote:
>
Hi Lionel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.19-rc7 next-20181011]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https
Quoting Michal Wajdeczko (2018-10-11 14:00:08)
> We need extra load failure point to better test error path in
> i915_driver_init_mmio.
>
> Suggested-by: Chris Wilson
> Signed-off-by: Michal Wajdeczko
> Cc: Chris Wilson
Reviewed-by: Chris Wilson
And pushed, thanks for the bug fix and testcase
On Thu, Oct 11, 2018 at 12:55:15AM -0700, Lisovskiy, Stanislav wrote:
> On Wed, 2018-10-10 at 17:12 -0700, Radhakrishna Sripada wrote:
> > Use the newly added "max bpc" connector property to limit pipe bpp.
> >
> > V3: Use drm_connector_state to access the "max bpc" property
> > V4: Initialize the
On Thu, Oct 11, 2018 at 09:17:52AM +1000, David Airlie wrote:
> On Thu, Oct 11, 2018 at 8:53 AM Rodrigo Vivi wrote:
> >
> > Hi all,
> >
> > I need your help to decide what to do with this round of fixes.
> >
> > I have collected these patches this week:
> >
> > commit b43e8916172a ("drm/i915/dp: L
On Thu, Oct 11, 2018 at 08:17:49PM +0200, Maarten Lankhorst wrote:
> Op 11-10-18 om 13:56 schreef Ville Syrjälä:
> > On Thu, Oct 11, 2018 at 12:04:51PM +0200, Maarten Lankhorst wrote:
> >> has_drrs is a flag we can't read out. We set it when seamless DRRS is
> >> enabled in pipe_config, so intel_du
Op 11-10-18 om 13:56 schreef Ville Syrjälä:
> On Thu, Oct 11, 2018 at 12:04:51PM +0200, Maarten Lankhorst wrote:
>> has_drrs is a flag we can't read out. We set it when seamless DRRS is
>> enabled in pipe_config, so intel_dump_pipe_config() and
>> intel_pipe_config_compare() will continue to do the
On Wed, Sep 26, 2018 at 06:06:50PM -0700, José Roberto de Souza wrote:
> This new AML PCI ID uses the same gen graphics as Coffe Lake not a
> Kaby Lake one like the other AMLs.
>
> So to make it more explicit renaming INTEL_AML_GT2_IDS to
> INTEL_AML_KBL_GT2_IDS and naming this id as INTEL_AML_CFL
Em Qua, 2018-09-05 às 16:41 -0700, Rodrigo Vivi escreveu:
> On Wed, Sep 05, 2018 at 02:32:38PM +0530, Karthik B S wrote:
> > Display Workarounds #1125 and #1126 are intended for Gen10 and
> > below platforms. These workarounds can be avoided in Gen11.
> >
> > The result blocks for WM1-WM7 should b
So I understand we agree on the change, just waiting for non-RFC version?
-Tomasz
On 2018-09-24 11:34, Jani Nikula wrote:
On Thu, 20 Sep 2018, Tvrtko Ursulin wrote:
Ping!
Any comments here?
Main goal was to allow GEM_WARN_ON as a statement, plus also protect
uses in if statements, which the
Hi Bjorn,
On Wed, Oct 10, 2018 at 1:02 AM Bjorn Helgaas wrote:
>
> On Mon, Oct 08, 2018 at 05:44:08PM +0800, Bin Meng wrote:
> > On Thu, Oct 4, 2018 at 4:12 AM Bjorn Helgaas wrote:
> > > On Thu, Sep 27, 2018 at 10:10:07AM +0800, Bin Meng wrote:
> > > > On Thu, Sep 27, 2018 at 12:57 AM Bjorn Helg
Em Ter, 2018-10-09 às 16:55 -0700, Matt Roper escreveu:
> On Thu, Oct 04, 2018 at 04:15:55PM -0700, Paulo Zanoni wrote:
> > BSpec does not show these WAs as applicable to GLK, and for CNL it
> > only shows them applicable for a super early pre-production
> > stepping
> > we shouldn't be caring abou
== Series Details ==
Series: drm/i915: Prevent machine hang from Broxton's vtd w/a and error capture
(rev4)
URL : https://patchwork.freedesktop.org/series/34969/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969_full -> Patchwork_10427_full =
== Summary - WARNING ==
Mi
On Wed, Oct 10, 2018 at 05:16:43PM -0700, Deepak Rawat wrote:
> Selftest for drm damage helper iterator functions.
>
> Cc: ville.syrj...@linux.intel.com
> Cc: Daniel Vetter
> Cc: Pekka Paalanen
> Cc: Daniel Stone
> Cc: intel-gfx@lists.freedesktop.org
> Cc: igt-...@lists.freedesktop.org
> Cc: pe
On Thu, Oct 11, 2018 at 03:11:01PM +0800, Bin Meng wrote:
> On Wed, Oct 10, 2018 at 1:02 AM Bjorn Helgaas wrote:
> > On Mon, Oct 08, 2018 at 05:44:08PM +0800, Bin Meng wrote:
> > > On Thu, Oct 4, 2018 at 4:12 AM Bjorn Helgaas wrote:
> > > > On Thu, Sep 27, 2018 at 10:10:07AM +0800, Bin Meng wrote
On Thu, 11 Oct 2018, Ville Syrjälä wrote:
> On Thu, Oct 11, 2018 at 03:14:41PM +0300, Jani Nikula wrote:
>> On Wed, 10 Oct 2018, Ville Syrjala wrote:
>> > From: Ville Syrjälä
>> >
>> > Templatize snprintf_int_array() to allow us to print
>> > different kinds of arrays without having to type all
On Thu, Oct 11, 2018 at 02:30:41AM +0530, Mahesh Kumar wrote:
> On Thu, Oct 11, 2018 at 2:19 AM Mahesh Kumar
> wrote:
> >
> > Hi,
> >
> > On Wed, Oct 10, 2018 at 11:25 PM Ville Syrjala
> > wrote:
> > >
> > > From: Ville Syrjälä
> > >
> > > The 16Gb DIMM w/a is not applicable to BXT or GLK. Limi
== Series Details ==
Series: drm/i915/selftests: Disable shrinker across mmap-exhaustion
URL : https://patchwork.freedesktop.org/series/50857/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969_full -> Patchwork_10424_full =
== Summary - SUCCESS ==
No regressions found.
>
> On Wed, Oct 10, 2018 at 05:21:01PM -0700, Deepak Rawat wrote:
> > For vmwgfx cairo surface creation fails due to stride mismatch, add a
> > igt_require_f() for surface.
>
> Hmm. What kind of pixel format are you using?
>
> It seems to me cairo should be happy with just a 4 byte aligned
> str
On Thu, Oct 11, 2018 at 03:38:11PM +, Deepak Singh Rawat wrote:
>
> > On Wed, Oct 10, 2018 at 05:21:02PM -0700, Deepak Rawat wrote:
> > > vmwgfx doesn't support fb modifier so skip igt_require_fb_modifiers()
> > > when modifier are not passed.
> > >
> > > Signed-off-by: Deepak Rawat
> > > ---
> On Wed, Oct 10, 2018 at 05:21:02PM -0700, Deepak Rawat wrote:
> > vmwgfx doesn't support fb modifier so skip igt_require_fb_modifiers()
> > when modifier are not passed.
> >
> > Signed-off-by: Deepak Rawat
> > ---
> > lib/ioctl_wrappers.c | 5 -
> > 1 file changed, 4 insertions(+), 1 delet
> > > This seems not needed? For pure generic kms tests I think it'd be great if
> > > we don't have to sprinkle driver-specific checks all over. Which you seem
> > > to achive in your series here.
> > >
> > > So not clear why this here is needed?
> > > -Daniel
> >
> > Hi Daniel,
> >
> > Thanks for
On Thu, Oct 11, 2018 at 03:17:01PM +, Deepak Singh Rawat wrote:
> >
> > On Wed, Oct 10, 2018 at 05:20:59PM -0700, Deepak Rawat wrote:
> > > Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests.
> > >
> > > v2: Don't remove second virtio_gpu
> > >
> > > Signed-off-by: Deepak Rawat
On Thu, Oct 11, 2018 at 03:23:58PM +, Deepak Singh Rawat wrote:
> > > diff --git a/tests/meson.build b/tests/meson.build
> > > index 697ff515..5acd7aa2 100644
> > > --- a/tests/meson.build
> > > +++ b/tests/meson.build
> > > @@ -9,6 +9,7 @@ test_progs = [
> > > 'debugfs_test',
> > > 'drm_im
> > diff --git a/tests/meson.build b/tests/meson.build
> > index 697ff515..5acd7aa2 100644
> > --- a/tests/meson.build
> > +++ b/tests/meson.build
> > @@ -9,6 +9,7 @@ test_progs = [
> > 'debugfs_test',
> > 'drm_import_export',
> > 'drm_mm',
> > + 'drm_plane_damage',
>
> For future pr
>
> On Wed, Oct 10, 2018 at 05:20:59PM -0700, Deepak Rawat wrote:
> > Add DRIVER_VMWGFX to represent vmwgfx device for running igt tests.
> >
> > v2: Don't remove second virtio_gpu
> >
> > Signed-off-by: Deepak Rawat
> > ---
> > lib/drmtest.c | 8
> > lib/drmtest.h | 3 +++
> > 2 files
On Wed, Oct 10, 2018 at 05:21:01PM -0700, Deepak Rawat wrote:
> For vmwgfx cairo surface creation fails due to stride mismatch, add a
> igt_require_f() for surface.
Hmm. What kind of pixel format are you using?
It seems to me cairo should be happy with just a 4 byte aligned
stride. How bad would
Quoting Mika Kuoppala (2018-10-11 15:19:24)
> Chris Wilson writes:
>
> > Quoting Mika Kuoppala (2018-10-02 15:05:52)
> >> Don't keep master disabled while we handle the current
> >> interrupts. This should help a little on latency of
> >> generating the next interrupt.
> >>
> >> Suggested-by: Ch
On Wed, Oct 10, 2018 at 05:21:02PM -0700, Deepak Rawat wrote:
> vmwgfx doesn't support fb modifier so skip igt_require_fb_modifiers()
> when modifier are not passed.
>
> Signed-off-by: Deepak Rawat
> ---
> lib/ioctl_wrappers.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff
Chris Wilson writes:
> Quoting Mika Kuoppala (2018-10-11 14:56:42)
>> Chris Wilson writes:
>>
>> > For mmap-exhaustion, we deliberately put the system under a large amount
>> > of pressure to ensure that we are able to reap mmap-offsets from dead
>> > objects. If background activity does that r
On 11/10/2018 15:30, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-10-11 14:38:41)
On 23/07/2018 10:02, Chris Wilson wrote:
Our attempt to account for bit17 swizzling of pread/pwrite onto tiled
objects was flawed due to the simple fact that we do not always know the
swizzling for a particu
Quoting Mika Kuoppala (2018-10-11 14:56:42)
> Chris Wilson writes:
>
> > For mmap-exhaustion, we deliberately put the system under a large amount
> > of pressure to ensure that we are able to reap mmap-offsets from dead
> > objects. If background activity does that reaping for us, that defeats
>
Chris Wilson writes:
> Quoting Mika Kuoppala (2018-10-02 15:05:52)
>> Don't keep master disabled while we handle the current
>> interrupts. This should help a little on latency of
>> generating the next interrupt.
>>
>> Suggested-by: Chris Wilson
>> Cc: Chris Wilson
>> Signed-off-by: Mika Kuop
Quoting Tvrtko Ursulin (2018-10-11 14:38:41)
>
> On 23/07/2018 10:02, Chris Wilson wrote:
> > Our attempt to account for bit17 swizzling of pread/pwrite onto tiled
> > objects was flawed due to the simple fact that we do not always know the
> > swizzling for a particular page (due to the swizzling
Chris Wilson writes:
> For mmap-exhaustion, we deliberately put the system under a large amount
> of pressure to ensure that we are able to reap mmap-offsets from dead
> objects. If background activity does that reaping for us, that defeats
> the purpose of the test and in some cases will fail ou
== Series Details ==
Series: drm/i915: Convert _print_param to a macro (rev2)
URL : https://patchwork.freedesktop.org/series/50789/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4968_full -> Patchwork_10422_full =
== Summary - SUCCESS ==
No regressions found.
== Kno
On 23/07/2018 10:02, Chris Wilson wrote:
Our attempt to account for bit17 swizzling of pread/pwrite onto tiled
objects was flawed due to the simple fact that we do not always know the
swizzling for a particular page (due to the swizzling varying based on
location in certain unbalanced configurat
== Series Details ==
Series: series starting with [1/2] drm/i915: Fix i915_driver_init_mmio error
path
URL : https://patchwork.freedesktop.org/series/50868/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4969 -> Patchwork_10430 =
== Summary - FAILURE ==
Serious unknown c
On Wed, Oct 10, 2018 at 05:41:23PM -0700, José Roberto de Souza wrote:
> Some eDP panels do not set a valid sink count value and even for the
> ones that sets is should always be one for eDP, that is why it is not
> cached in intel_edp_init_dpcd().
>
> But intel_dp_short_pulse() compares the old c
== Series Details ==
Series: drm/i915/perf: Add OA buffer size uAPI parameter (rev2)
URL : https://patchwork.freedesktop.org/series/50810/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969 -> Patchwork_10429 =
== Summary - SUCCESS ==
No regressions found.
External UR
On 11/10/2018 13:49, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-10-11 13:42:31)
On 11/10/2018 13:34, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-10-11 13:30:27)
From: Tvrtko Ursulin
Same as in commit 78071c2fa53d ("igt/gem_tiled_partial_pwrite_pread: Check
for known swizzling"),
== Series Details ==
Series: series starting with [v1,01/10] drm/i915: introduced pv capability for
vgpu
URL : https://patchwork.freedesktop.org/series/50851/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4968_full -> Patchwork_10421_full =
== Summary - SUCCESS ==
No re
== Series Details ==
Series: drm/i915/perf: Add OA buffer size uAPI parameter (rev2)
URL : https://patchwork.freedesktop.org/series/50810/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/perf: remove redundant oa buffer initialization
-drivers/
== Series Details ==
Series: drm/i915/perf: Add OA buffer size uAPI parameter (rev2)
URL : https://patchwork.freedesktop.org/series/50810/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c4fba7f16af5 drm/i915/perf: remove redundant oa buffer initialization
-:7: WARNING:COMMIT_LOG
We need extra load failure point to better test error path in
i915_driver_init_mmio.
Suggested-by: Chris Wilson
Signed-off-by: Michal Wajdeczko
Cc: Chris Wilson
---
drivers/gpu/drm/i915/intel_engine_cs.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_engine_c
In case of the error we missed to call i915_mmio_cleanup
that matches earlier call to i915_mmio_setup.
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Chris Wilson
Reviewed-by: Mika Kuoppala
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.c | 1 +
1 file changed, 1 insert
== Series Details ==
Series: drm/i915: Fix i915_driver_init_mmio error path
URL : https://patchwork.freedesktop.org/series/50864/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969 -> Patchwork_10428 =
== Summary - SUCCESS ==
No regressions found.
External URL:
https
We initialize the OA buffer everytime we enable the OA unit (first call in
gen[78]_oa_enable), so we don't need to initialize when preparing the metric
set.
Signed-off-by: Lionel Landwerlin
Reviewed-by: Matthew Auld
---
drivers/gpu/drm/i915/i915_drv.h | 17 -
drivers/gpu/drm/i9
We want to use some of the properties of the perf stream to program
the hardware in a later commit.
v2: Pass only perf stream as argument (Matthew)
Signed-off-by: Lionel Landwerlin
Reviewed-by: Matthew Auld
---
drivers/gpu/drm/i915/i915_drv.h | 7 +++---
drivers/gpu/drm/i915/i915_perf.c | 43
The way our hardware is designed doesn't seem to let us use the
MI_RECORD_PERF_COUNT command without setting up a circular buffer.
In the case where the user didn't request OA reports to be available
through the i915 perf stream, we can set the OA buffer to the minimum
size to avoid consuming memo
Hi all,
This version drops a patch that wasn't necessary and simplify the OA
buffer size exponent as recommended by Chris (Thanks!).
Cheers,
Lionel Landwerlin (3):
drm/i915/perf: remove redundant oa buffer initialization
drm/i915/perf: pass stream to vfuncs when possible
drm/i915/perf: add
Quoting Tvrtko Ursulin (2018-10-11 13:42:31)
>
> On 11/10/2018 13:34, Chris Wilson wrote:
> > Quoting Tvrtko Ursulin (2018-10-11 13:30:27)
> >> From: Tvrtko Ursulin
> >>
> >> Same as in commit 78071c2fa53d ("igt/gem_tiled_partial_pwrite_pread: Check
> >> for known swizzling"), to be able to compa
On Thu, Oct 11, 2018 at 03:14:41PM +0300, Jani Nikula wrote:
> On Wed, 10 Oct 2018, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Templatize snprintf_int_array() to allow us to print
> > different kinds of arrays without having to type all
> > the boilerplate for the snprintf() loop.
>
>
On 11/10/2018 13:34, Chris Wilson wrote:
Quoting Tvrtko Ursulin (2018-10-11 13:30:27)
From: Tvrtko Ursulin
Same as in commit 78071c2fa53d ("igt/gem_tiled_partial_pwrite_pread: Check
for known swizzling"), to be able to compare the bo against the test
pattern we need to skip the test if the sw
Quoting Tvrtko Ursulin (2018-10-11 13:30:27)
> From: Tvrtko Ursulin
>
> Same as in commit 78071c2fa53d ("igt/gem_tiled_partial_pwrite_pread: Check
> for known swizzling"), to be able to compare the bo against the test
> pattern we need to skip the test if the swizzling is not compatible.
>
> Sig
From: Tvrtko Ursulin
Same as in commit 78071c2fa53d ("igt/gem_tiled_partial_pwrite_pread: Check
for known swizzling"), to be able to compare the bo against the test
pattern we need to skip the test if the swizzling is not compatible.
Signed-off-by: Tvrtko Ursulin
Bugzilla: https://bugs.freedesk
== Series Details ==
Series: drm/i915: Prevent machine hang from Broxton's vtd w/a and error capture
(rev4)
URL : https://patchwork.freedesktop.org/series/34969/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969 -> Patchwork_10427 =
== Summary - SUCCESS ==
No regressio
Michal Wajdeczko writes:
> In case of the error we missed to call i915_mmio_cleanup
> that matches earlier call to i915_mmio_setup.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Joonas Lahtinen
> Cc: Chris Wilson
Reviewed-by: Mika Kuoppala
> ---
> drivers/gpu/drm/i915/i915_drv.c | 1 +
> 1 fil
Quoting Michal Wajdeczko (2018-10-11 13:19:51)
> In case of the error we missed to call i915_mmio_cleanup
> that matches earlier call to i915_mmio_setup.
True, doesn't look fatal atm; worst being we left the register bar mmapped
(which would be ok as we map it again using the same constraints on n
In case of the error we missed to call i915_mmio_cleanup
that matches earlier call to i915_mmio_setup.
Signed-off-by: Michal Wajdeczko
Cc: Joonas Lahtinen
Cc: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/
On Wed, 10 Oct 2018, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Templatize snprintf_int_array() to allow us to print
> different kinds of arrays without having to type all
> the boilerplate for the snprintf() loop.
I might just feel happier about duplicating the boilerplate...
BR,
Jani.
On Thu, Oct 11, 2018 at 12:04:54PM +0200, Maarten Lankhorst wrote:
> The CRTC is idle at this point, so we can dereference crtc->state safely.
>
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_display.c | 11 +++
> 1 file changed, 7 insertions(+), 4 deletions(-)
>
On Thu, Oct 11, 2018 at 12:04:57PM +0200, Maarten Lankhorst wrote:
> Now that most of the driver is atomic, we no longer need to worry
> about setting crtc->active right before actually enabling the pipe.
Hmm. I think we need at least that wait_for_vblank_if_active() change
we discussed. And maybe
On Thu, Oct 11, 2018 at 12:04:55PM +0200, Maarten Lankhorst wrote:
> Instead of derferencing crtc->config, look at crtc_state.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_display.c | 7 ---
> 1 file changed, 4 insertions(+), 3 deletio
On Thu, Oct 11, 2018 at 12:04:56PM +0200, Maarten Lankhorst wrote:
> We have to look at crtc_state, so pass that instead.
> Also cleanup the use of dev vs dev_priv, we really want to pass along
> dev_priv.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm
On Thu, Oct 11, 2018 at 12:04:53PM +0200, Maarten Lankhorst wrote:
> We know the crtc is idle because we're at the beginning of sanitization,
> so just dereference crtc->state instead.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_display.c
On Thu, Oct 11, 2018 at 12:04:52PM +0200, Maarten Lankhorst wrote:
> No need to look at crtc->config when we have crtc_state in the caller.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_display.c | 11 ++-
> 1 file changed, 6 insert
On Thu, Oct 11, 2018 at 12:04:51PM +0200, Maarten Lankhorst wrote:
> has_drrs is a flag we can't read out. We set it when seamless DRRS is
> enabled in pipe_config, so intel_dump_pipe_config() and
> intel_pipe_config_compare() will continue to do the right thing when
> has_drrs is set on the real s
Since capturing the error state requires fiddling around with the GGTT
to read arbitrary buffers and is itself run under stop_machine(), it
deadlocks the machine (effectively a hard hang) when run in conjunction
with Broxton's VTd workaround to serialize GGTT access.
v2: Store the ERR_PTR in first
On Thu, Oct 11, 2018 at 12:04:49PM +0200, Maarten Lankhorst wrote:
> Another user of crtc->config gone. The functions it calls also
> needed crtc->config, so convert those as well.
>
> Signed-off-by: Maarten Lankhorst
> ---
> drivers/gpu/drm/i915/intel_display.c | 61 ++--
== Series Details ==
Series: drm/i915: Prevent machine hang from Broxton's vtd w/a and error capture
(rev3)
URL : https://patchwork.freedesktop.org/series/34969/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M] d
On Thu, Oct 11, 2018 at 12:04:50PM +0200, Maarten Lankhorst wrote:
> We already have a perfectly nice pipe_config, use that instead.
>
> Signed-off-by: Maarten Lankhorst
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_display.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 de
Since capturing the error state requires fiddling around with the GGTT
to read arbitrary buffers and is itself run under stop_machine(), it
deadlocks the machine (effectively a hard hang) when run in conjunction
with Broxton's VTd workaround to serialize GGTT access.
v2: Store the ERR_PTR in first
On Wed, Oct 10, 2018 at 04:50:51PM -0700, Matt Roper wrote:
> Gen9+ platforms allow CRTC's to be programmed with a background/canvas
> color below the programmable planes. Let's expose this for use by
> compositors.
>
> Cc: dri-de...@lists.freedesktop.org
> Cc: wei.c...@intel.com
> Cc: harish.kru
On Wed, Oct 10, 2018 at 04:50:50PM -0700, Matt Roper wrote:
> Some display controllers can be programmed to present non-black colors
> for pixels not covered by any plane (or pixels covered by the
> transparent regions of higher planes). Compositors that want a UI with
> a solid color background c
== Series Details ==
Series: drm/i915/selftests: Disable shrinker across mmap-exhaustion
URL : https://patchwork.freedesktop.org/series/50857/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4969 -> Patchwork_10424 =
== Summary - SUCCESS ==
No regressions found.
Externa
== Series Details ==
Series: drm/i915: Prevent machine hang from Broxton's vtd w/a and error capture
(rev2)
URL : https://patchwork.freedesktop.org/series/34969/
State : failure
== Summary ==
Applying: drm/i915: Prevent machine hang from Broxton's vtd w/a and error
capture
Using index info t
== Series Details ==
Series: drm/i915: Remove low hanging crtc->config fruit, part 2.
URL : https://patchwork.freedesktop.org/series/50856/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4969 -> Patchwork_10423 =
== Summary - FAILURE ==
Serious unknown changes coming with
For mmap-exhaustion, we deliberately put the system under a large amount
of pressure to ensure that we are able to reap mmap-offsets from dead
objects. If background activity does that reaping for us, that defeats
the purpose of the test and in some cases will fail our sanity checks
(because of the
== Series Details ==
Series: series starting with [v2,1/6] drm/i915/psr: Use intel_psr_exit() in
intel_psr_disable_source()
URL : https://patchwork.freedesktop.org/series/50843/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4967_full -> Patchwork_10420_full =
== Summary -
On 10/10/2018 20:24, Matthew Auld wrote:
On Wed, 10 Oct 2018 at 19:55, Lionel Landwerlin
wrote:
If 2 processes race to open the perf stream, it's possible that one of them
will see that OA buffer has already been allocated, while a previous process
is still finishing to reprogram the hardware (
1 - 100 of 129 matches
Mail list logo
