Re: [Intel-gfx] [igt-dev] RFC: Migration to Gitlab

2018-08-23 Thread Jani Nikula
On Wed, 22 Aug 2018, Rodrigo Vivi wrote: > On Wed, Aug 22, 2018 at 10:19:19AM -0400, Adam Jackson wrote: >> On Wed, 2018-08-22 at 16:13 +0300, Jani Nikula wrote: >> >> > - Sticking to fdo bugzilla and disabling gitlab issues for at least >> > drm-intel for the time being. Doing that migration i

Re: [Intel-gfx] [PATCH] drm/i915/dsc: Fix PPS register definition macros for 2nd VDSC engine

2018-08-23 Thread Rodrigo Vivi
On Thu, Aug 23, 2018 at 06:48:07PM -0700, Manasi Navare wrote: > This patch fixes the PPS4 and PPS register definition macros that were > resulting into an incorect MMIO address. > > Fixes: 2efbb2f099fb ("i915/dp/dsc: Add DSC PPS register definitions") > Cc: Anusha Srivatsa > Signed-off-by: Manas

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dsc: Fix PPS register definition macros for 2nd VDSC engine

2018-08-23 Thread Patchwork
== Series Details == Series: drm/i915/dsc: Fix PPS register definition macros for 2nd VDSC engine URL : https://patchwork.freedesktop.org/series/48648/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4703_full -> Patchwork_10003_full = == Summary - SUCCESS == No regression

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsc: Fix PPS register definition macros for 2nd VDSC engine

2018-08-23 Thread Patchwork
== Series Details == Series: drm/i915/dsc: Fix PPS register definition macros for 2nd VDSC engine URL : https://patchwork.freedesktop.org/series/48648/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4703 -> Patchwork_10003 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] [PATCH] drm/i915/dsc: Fix PPS register definition macros for 2nd VDSC engine

2018-08-23 Thread Manasi Navare
This patch fixes the PPS4 and PPS register definition macros that were resulting into an incorect MMIO address. Fixes: 2efbb2f099fb ("i915/dp/dsc: Add DSC PPS register definitions") Cc: Anusha Srivatsa Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/i915_reg.h | 4 ++-- 1 file changed, 2

Re: [Intel-gfx] [PATCH 10/18] drm/i915: Extract per-platform plane->check() functions

2018-08-23 Thread Souza, Jose
On Thu, 2018-07-19 at 21:22 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Split up intel_check_primary_plane() and intel_check_sprite_plane() > into per-platform variants. This way we can get a unified behaviour > between the SKL universal planes, and we stop checking for non-SKL > specif

Re: [Intel-gfx] [PATCH 09/18] drm/i915: Nuke plane->can_scale/min_downscale

2018-08-23 Thread Souza, Jose
On Thu, 2018-07-19 at 21:22 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We can easily calculate the plane can_scale/min_downscale on demand. > And later on we'll probably want to start calculating these > dynamically > based on the cdclk just as skl already does. Reviewed-by: José Robe

Re: [Intel-gfx] [PATCH 08/18] drm/i915: s/int plane/int color_plane/

2018-08-23 Thread Souza, Jose
On Wed, 2018-08-22 at 18:14 -0700, Rodrigo Vivi wrote: > On Thu, Jul 19, 2018 at 09:22:04PM +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > To reduce the confusion between a drm plane and the planes of > > framebuffers let's desiginate the latter as "color plane". > > > what about f

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/icl: implement the tc/legacy HPD {dis, }connect flows (rev2)

2018-08-23 Thread Patchwork
== Series Details == Series: drm/i915/icl: implement the tc/legacy HPD {dis, }connect flows (rev2) URL : https://patchwork.freedesktop.org/series/47518/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4702_full -> Patchwork_10002_full = == Summary - FAILURE == Serious unkn

Re: [Intel-gfx] [PATCH] drm/i915: Free write_buf that we allocated with kzalloc.

2018-08-23 Thread Rodrigo Vivi
On Thu, Aug 23, 2018 at 11:25:42PM +0100, Chris Wilson wrote: > Quoting Rodrigo Vivi (2018-08-23 21:51:36) > > We use kzalloc to allocate the write_buf that we use for > > i2c transfer on hdcp write. But it seems that we are forgetting > > to free the memory that is not needed after i2c transfer is

Re: [Intel-gfx] [PATCH] drm/i915: Free write_buf that we allocated with kzalloc.

2018-08-23 Thread Chris Wilson
Quoting Rodrigo Vivi (2018-08-23 21:51:36) > We use kzalloc to allocate the write_buf that we use for > i2c transfer on hdcp write. But it seems that we are forgetting > to free the memory that is not needed after i2c transfer is > completed. > > Reported-by: Brian J Wood > Fixes: 2320175feb74 ("

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: implement the tc/legacy HPD {dis, }connect flows (rev2)

2018-08-23 Thread Patchwork
== Series Details == Series: drm/i915/icl: implement the tc/legacy HPD {dis, }connect flows (rev2) URL : https://patchwork.freedesktop.org/series/47518/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4702 -> Patchwork_10002 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Free write_buf that we allocated with kzalloc.

2018-08-23 Thread Patchwork
== Series Details == Series: drm/i915: Free write_buf that we allocated with kzalloc. URL : https://patchwork.freedesktop.org/series/48642/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4702_full -> Patchwork_10001_full = == Summary - WARNING == Minor unknown changes com

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Free write_buf that we allocated with kzalloc.

2018-08-23 Thread Patchwork
== Series Details == Series: drm/i915: Free write_buf that we allocated with kzalloc. URL : https://patchwork.freedesktop.org/series/48642/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4702 -> Patchwork_10001 = == Summary - SUCCESS == No regressions found. External U

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread John Stultz
On Thu, Aug 23, 2018 at 1:49 PM, Laurent Pinchart wrote: > On Thursday, 23 August 2018 20:48:40 EEST John Stultz wrote: >> On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote: >> > On Thu, Aug 23, 2018 at 10:46:15AM +0300, Laurent Pinchart wrote: >> >> Possibly slightly out of topic, but we're i

Re: [Intel-gfx] [PATCH v2 13/23] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-08-23 Thread Rodrigo Vivi
On Thu, Aug 23, 2018 at 01:34:54PM -0700, Dhinakaran Pandiyan wrote: > > > On Wed, 2018-08-08 at 22:55 -0700, Rodrigo Vivi wrote: > > On Tue, Jul 31, 2018 at 02:07:09PM -0700, Manasi Navare wrote: > > > If a eDP panel supports both PSR2 and VDSC, our HW cannot > > > support both at a time. Give p

[Intel-gfx] [PULL] drm-misc-next-fixes for -rc1 part 2

2018-08-23 Thread Sean Paul
Hi Dave, One more patch snuck in between my PR and today. drm-misc-next-fixes-2018-08-23-1: - Add quirk to Lenovo B50-80 to use 6 bpc instead of 8 (Feng) Cc: Kai-Heng Feng Cheers, Sean The following changes since commit 4acd8d01a2393f2145ad1db10b2d5c764582a98d: MAINTAINERS: drm-misc: Cha

[Intel-gfx] [PATCH] drm/i915: Free write_buf that we allocated with kzalloc.

2018-08-23 Thread Rodrigo Vivi
We use kzalloc to allocate the write_buf that we use for i2c transfer on hdcp write. But it seems that we are forgetting to free the memory that is not needed after i2c transfer is completed. Reported-by: Brian J Wood Fixes: 2320175feb74 ("drm/i915: Implement HDCP for HDMI") Cc: Ramalingam C Cc:

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Laurent Pinchart
Hi John, On Thursday, 23 August 2018 20:48:40 EEST John Stultz wrote: > On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote: > > On Thu, Aug 23, 2018 at 10:46:15AM +0300, Laurent Pinchart wrote: > >> On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote: > >>> On Mon, Aug 20, 2018 at 11:44

Re: [Intel-gfx] [PATCH v2 13/23] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-08-23 Thread Dhinakaran Pandiyan
On Wed, 2018-08-08 at 22:55 -0700, Rodrigo Vivi wrote: > On Tue, Jul 31, 2018 at 02:07:09PM -0700, Manasi Navare wrote: > > If a eDP panel supports both PSR2 and VDSC, our HW cannot > > support both at a time. Give priority to PSR2 if a requested > > resolution can be supported without compressio

Re: [Intel-gfx] [PATCH v2 13/23] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-08-23 Thread Rodrigo Vivi
On Thu, Aug 23, 2018 at 12:22:29PM -0700, Manasi Navare wrote: > Thanks Rodrigo for your review. Please find the answers below: > > On Wed, Aug 08, 2018 at 10:55:13PM -0700, Rodrigo Vivi wrote: > > On Tue, Jul 31, 2018 at 02:07:09PM -0700, Manasi Navare wrote: > > > If a eDP panel supports both PS

Re: [Intel-gfx] [PATCH v2 07/23] drm/dsc: Define Display Stream Compression PPS infoframe

2018-08-23 Thread Manasi Navare
Thanks for the review. And yes it just removes the bitfields in PPS since the packing of the bitfields and memory allocations are heavily dependent on HW. So we cant have them in DRM level. I will make sure to add this in version history and also add Suggested-by: jani.nik...@linux.intel.com Mana

Re: [Intel-gfx] [PATCH v2 07/23] drm/dsc: Define Display Stream Compression PPS infoframe

2018-08-23 Thread Manasi Navare
On Fri, Aug 17, 2018 at 12:31:51PM -0700, Srivatsa, Anusha wrote: > This patch needs to now incorporate the newly added slice_row_per_frame > parameter in PPS_16. Nope, the slice_row_per_frame and slice_per_line are only required to configure PPS on the source side. They are not DSC spec related

Re: [Intel-gfx] [PATCH v2 08/23] drm/dsc: Define VESA Display Stream Compression Capabilities

2018-08-23 Thread Harry Wentland
On 2018-07-31 05:07 PM, Manasi Navare wrote: > From: Gaurav K Singh > > This defines all the DSC parameters as per the VESA DSC spec > that will be required for DSC encoder/decoder > > v4 (From Manasi) > * Add the DSC_MUX_WORD_SIZE constants (Manasi) > > v3 (From Manasi) > * Remove the duplicat

Re: [Intel-gfx] [PATCH v2 10/23] drm/dsc: Add helpers for DSC picture parameter set infoframes

2018-08-23 Thread Harry Wentland
On 2018-07-31 05:07 PM, Manasi Navare wrote: > According to Display Stream compression spec 1.2, the picture > parameter set metadata is sent from source to sink device > using the DP Secondary data packet. An infoframe is formed > for the PPS SDP header and PPS SDP payload bytes. > This patch adds

Re: [Intel-gfx] [PATCH v2 07/23] drm/dsc: Define Display Stream Compression PPS infoframe

2018-08-23 Thread Harry Wentland
On 2018-07-31 05:07 PM, Manasi Navare wrote: > This patch defines a new header file for all the DSC 1.2 structures > and creates a structure for PPS infoframe which will be used to send > picture parameter set secondary data packet for display stream compression. > All the PPS infoframe syntax elem

Re: [Intel-gfx] [PATCH v2 13/23] drm/i915/dp: Do not enable PSR2 if DSC is enabled

2018-08-23 Thread Manasi Navare
Thanks Rodrigo for your review. Please find the answers below: On Wed, Aug 08, 2018 at 10:55:13PM -0700, Rodrigo Vivi wrote: > On Tue, Jul 31, 2018 at 02:07:09PM -0700, Manasi Navare wrote: > > If a eDP panel supports both PSR2 and VDSC, our HW cannot > > support both at a time. Give priority to P

Re: [Intel-gfx] Possible use_mm() mis-uses

2018-08-23 Thread Linus Torvalds
On Wed, Aug 22, 2018 at 11:16 PM Zhenyu Wang wrote: > > yeah, that's the clear way to fix this imo. We only depend on guest > life cycle to access guest memory properly. Here's proposed fix, will > verify and integrate it later. Thanks, this looks sane to me, Linus __

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread John Stultz
On Thu, Aug 23, 2018 at 1:09 AM, Daniel Vetter wrote: > On Thu, Aug 23, 2018 at 10:46:15AM +0300, Laurent Pinchart wrote: >> Hi John, >> >> On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote: >> > On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: >> > > Hey Noralf, all, >> > > >> > >

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread John Stultz
On Thu, Aug 23, 2018 at 10:24 AM, Ville Syrjälä wrote: > On Wed, Aug 22, 2018 at 09:14:08PM -0700, John Stultz wrote: >> On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: >> > Hey Noralf, all, >> > I've been digging for a bit on the regression that this patch has >> > tripped on the HiKey bo

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread John Stultz
On Thu, Aug 23, 2018 at 12:46 AM, Laurent Pinchart wrote: > Hi John, > > On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote: >> On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: >> > Hey Noralf, all, >> > >> > I've been digging for a bit on the regression that this patch has >> > >>

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Ville Syrjälä
On Wed, Aug 22, 2018 at 09:14:08PM -0700, John Stultz wrote: > On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: > > Hey Noralf, all, > > I've been digging for a bit on the regression that this patch has > > tripped on the HiKey board as reported here: > > https://lkml.org/lkml/2018/8/16/81 >

[Intel-gfx] [PATCH V2 i-g-t] Skip VBlank tests in modules without VBlank

2018-08-23 Thread Rodrigo Siqueira
The kms_flip test does not support drivers without VBlank which exclude some virtual drivers. This patch adds a function that checks if a module has a VBlank or not; if a module has VBlank than kms_flip will execute all the VBlank tests, otherwise, VBlank tests will be skipped. Changes since V1:

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Daniel Vetter
On Thu, Aug 23, 2018 at 6:49 PM, Noralf Trønnes wrote: > > Den 23.08.2018 09.37, skrev Daniel Vetter: >> >> On Wed, Aug 22, 2018 at 11:21:11PM -0700, John Stultz wrote: >>> >>> On Wed, Aug 22, 2018 at 10:51 PM, Daniel Vetter wrote: On Thu, Aug 23, 2018 at 6:14 AM, John Stultz wrot

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Noralf Trønnes
Den 23.08.2018 09.37, skrev Daniel Vetter: On Wed, Aug 22, 2018 at 11:21:11PM -0700, John Stultz wrote: On Wed, Aug 22, 2018 at 10:51 PM, Daniel Vetter wrote: On Thu, Aug 23, 2018 at 6:14 AM, John Stultz wrote: On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: Hey Noralf, all, I've

Re: [Intel-gfx] [PATCH 03/18] drm/i915: Add .max_stride() plane hook

2018-08-23 Thread Ville Syrjälä
On Wed, Aug 22, 2018 at 10:03:17PM +, Souza, Jose wrote: > On Thu, 2018-07-19 at 21:21 +0300, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Each plane may have different stride limitations. Let's add a new > > plane function to retutn the maximum stride for each plane. There's > > goin

Re: [Intel-gfx] [PATCH 03/18] drm/i915: Add .max_stride() plane hook

2018-08-23 Thread Ville Syrjälä
On Wed, Aug 22, 2018 at 10:19:55PM +, Souza, Jose wrote: > On Wed, 2018-08-22 at 22:03 +, Souza, Jose wrote: > > On Thu, 2018-07-19 at 21:21 +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Each plane may have different stride limitations. Let's add a new > > > plane func

Re: [Intel-gfx] [PATCH 5/5] drm/i915: use the SW-based pw->hw_enabled check instead of reading registers

2018-08-23 Thread Imre Deak
On Mon, Aug 20, 2018 at 04:31:39PM -0700, Paulo Zanoni wrote: > I can't find a reason why we would want to call is_enabled(), which > does a register read, instead of just relying on our tracking with > hw_enabled. Let's try to trust our hardware sync. The software state is indirect, so not sure w

Re: [Intel-gfx] [PATCH 4/5] drm/i915: move lookup_power_well() up

2018-08-23 Thread Imre Deak
On Mon, Aug 20, 2018 at 04:31:38PM -0700, Paulo Zanoni wrote: > There's no need for that forward declaration. > > Cc: Imre Deak > Signed-off-by: Paulo Zanoni Reviewed-by: Imre Deak > --- > drivers/gpu/drm/i915/intel_runtime_pm.c | 46 > +++-- > 1 file changed, 21

Re: [Intel-gfx] [PATCH 2/5] drm/i915: WARN() if we can't lookup_power_well()

2018-08-23 Thread Imre Deak
On Mon, Aug 20, 2018 at 04:31:36PM -0700, Paulo Zanoni wrote: > None of the current lookup_power_well() callers are actually checking > for NULL return values, they all just use the pointer right away. The > first idea was to replace these theoretical segfaults with a BUG() > since this would at l

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Simplify condition to keep DMC active during S0ix

2018-08-23 Thread Imre Deak
On Wed, Aug 22, 2018 at 12:43:00PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Simplify condition to keep DMC active during S0ix > URL : https://patchwork.freedesktop.org/series/48556/ > State : success Pushed to -dinq, thanks for the review. > > == Summary == > > =

[Intel-gfx] [PATCH] [intel-gfx][igt-dev] [PATCH i-g-t] tests/pm_backlight.c : Brightness test with DPMS and System suspend.

2018-08-23 Thread Jyoti Yadav
From: Jyoti BIOS programs few of PWM related registers during initial boot. But during System suspend those registers are cleared. This test aim to check whether display programs those registers properly after system resume. Also checks brightness programming during DPMS ON/OFF cycle to check bac

Re: [Intel-gfx] [PATCH] drm/i915: Fix subslice configuration on Gen9LP

2018-08-23 Thread Tvrtko Ursulin
On 22/08/2018 16:47, Lionel Landwerlin wrote: On 22/08/2018 16:27, Tvrtko Ursulin wrote: On 22/08/2018 16:22, Lionel Landwerlin wrote: On 22/08/2018 16:17, Tvrtko Ursulin wrote: On 22/08/2018 16:08, Lionel Landwerlin wrote: On 22/08/2018 15:29, Tvrtko Ursulin wrote: From: Tvrtko Ursulin

Re: [Intel-gfx] Possible use_mm() mis-uses

2018-08-23 Thread Paolo Bonzini
On 23/08/2018 08:07, Zhenyu Wang wrote: > On 2018.08.22 20:20:46 +0200, Paolo Bonzini wrote: >> On 22/08/2018 18:44, Linus Torvalds wrote: >>> An example of something that *isn't* right, is the i915 kvm interface, >>> which does >>> >>> use_mm(kvm->mm); >>> >>> on an mm that was initialized

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Daniel Vetter
On Thu, Aug 23, 2018 at 10:46:15AM +0300, Laurent Pinchart wrote: > Hi John, > > On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote: > > On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: > > > Hey Noralf, all, > > > > > > I've been digging for a bit on the regression that this patch

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Laurent Pinchart
Hi John, On Thursday, 23 August 2018 07:14:08 EEST John Stultz wrote: > On Mon, Aug 20, 2018 at 11:44 PM, John Stultz wrote: > > Hey Noralf, all, > > > > I've been digging for a bit on the regression that this patch has > > > > tripped on the HiKey board as reported here: > > https://lkml.org/

Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-23 Thread Daniel Vetter
On Wed, Aug 22, 2018 at 11:21:11PM -0700, John Stultz wrote: > On Wed, Aug 22, 2018 at 10:51 PM, Daniel Vetter wrote: > > On Thu, Aug 23, 2018 at 6:14 AM, John Stultz wrote: > >> On Mon, Aug 20, 2018 at 11:44 PM, John Stultz > >> wrote: > >>> Hey Noralf, all, > >>> I've been digging for a bit