== Series Details ==
Series: drm/i915/kvmgt: Fix potential Spectre v1
URL : https://patchwork.freedesktop.org/series/47640/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4608_full -> Patchwork_9845_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues
== Series Details ==
Series: drm/i915/kvmgt: Fix potential Spectre v1
URL : https://patchwork.freedesktop.org/series/47640/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4608 -> Patchwork_9845 =
== Summary - SUCCESS ==
No regressions found.
External URL:
https://patc
== Series Details ==
Series: drm/i915/kvmgt: Fix potential Spectre v1
URL : https://patchwork.freedesktop.org/series/47640/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
0ea70a869370 drm/i915/kvmgt: Fix potential Spectre v1
-:55: CHECK:PARENTHESIS_ALIGNMENT: Alignment should ma
info.index can be indirectly controlled by user-space, hence leading
to a potential exploitation of the Spectre variant 1 vulnerability.
This issue was detected with the help of Smatch:
drivers/gpu/drm/i915/gvt/kvmgt.c:1232 intel_vgpu_ioctl() warn:
potential spectre issue 'vgpu->vdev.region' [r]
On 2018.08.03 08:41:19 +0800, Yi Wang wrote:
> The 'sparse' variable may leak when return in function
> intel_vgpu_ioctl(), and this patch fixes this.
>
> Signed-off-by: Yi Wang
> Reviewed-by: Jiang Biao
> ---
Looks fine to me, will queue this up.
Thanks for the patch!
> drivers/gpu/drm/i915
Em Qui, 2018-08-02 às 16:17 -0700, Lucas De Marchi escreveu:
> On Fri, Jul 20, 2018 at 05:14:55PM +0300, Imre Deak wrote:
> > Similarly to
> > 0a445945be6d ("drm/i915: Work around GCC anonymous union
> > initialization bug")
> > we need to initialize anonymous unions inside extra braces to work
> >
== Series Details ==
Series: docs: fix typo sharding->sharing
URL : https://patchwork.freedesktop.org/series/47632/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4584_full -> IGTPW_1679_full =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1679_full need to
On Fri, Jul 20, 2018 at 05:14:55PM +0300, Imre Deak wrote:
> Similarly to
> 0a445945be6d ("drm/i915: Work around GCC anonymous union initialization bug")
> we need to initialize anonymous unions inside extra braces to work
> around a GCC4.4 build error.
Aren't we jumping to gcc 4.5 as minimum vers
Em Qui, 2018-08-02 às 15:03 +0300, Imre Deak escreveu:
> On Wed, Aug 01, 2018 at 02:39:31PM -0700, Paulo Zanoni wrote:
> > Em Sex, 2018-07-20 às 17:14 +0300, Imre Deak escreveu:
> > > It makes sense to keep unchanging data const. Extract such fields
> > > from
> > > the i915_power_well struct into
== Series Details ==
Series: docs: fix typo sharding->sharing
URL : https://patchwork.freedesktop.org/series/47632/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4606 -> IGTPW_1679 =
== Summary - WARNING ==
Minor unknown changes coming with IGTPW_1679 need to be verified
== Series Details ==
Series: series starting with [v3,1/2] drm/i915/icl: move has_resource_streamer
to GEN11_FEATURES
URL : https://patchwork.freedesktop.org/series/46884/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4608 -> Patchwork_9844 =
== Summary - FAILURE ==
Ser
>-Original Message-
>From: Yadav, Jyoti R
>Sent: Wednesday, August 1, 2018 10:34 PM
>To: Srivatsa, Anusha ; intel-
>g...@lists.freedesktop.org; Zanoni, Paulo R
>Cc: Sarvela, Tomi P ; Vivi, Rodrigo
>; Zanoni, Paulo R ; intel-
>g...@lists.freedesktop.org
>Subject: Re: [Intel-gfx] [PATCH] f
I was grepping for shard as the tests run on CI, but the only occurrence
was this one which seems to be a typo since it's about prime tests.
Fixes: 76bce773 ("docs: Update documentation generation with missing entries")
Signed-off-by: Lucas De Marchi
---
docs/reference/igt-gpu-tools/igt_test_pro
Em Sex, 2018-07-20 às 17:15 +0300, Imre Deak escreveu:
> On ICL there are 5 fused power gates, so add the two missing ones for
> clarity.
>
> Cc: Ville Syrjala
> Cc: Paulo Zanoni
Reviewed-by: Paulo Zanoni
> Cc: Jani Nikula
> Signed-off-by: Imre Deak
> ---
> drivers/gpu/drm/i915/i915_reg.h
Em Sex, 2018-07-20 às 17:15 +0300, Imre Deak escreveu:
> There is no need for separate IDs for power wells on a new platform
> with
> the same functionality as an other power well on a previous platform,
> we
> can just reuse the ID from the previous platform. This is only
> possible
> after the pr
Em Sex, 2018-07-20 às 17:15 +0300, Imre Deak escreveu:
> The format for the ID names is _DISP_PW_* so rename the IDs
> not following this accordingly. Leave BXT_DPIO_CMN_BC as-is since
> we'll
> change that to use another existing ID in the next patch.
>
> Cc: Ville Syrjala
> Cc: Paulo Zanoni
R
Em Sex, 2018-07-20 às 17:15 +0300, Imre Deak escreveu:
> Now that we removed dependence on the power well IDs to determine the
> control register and request/status flag offsets the only purpose of
> power well IDs is to look up power wells directly bypassing the power
> domains framework. However
>-Original Message-
>From: Sarvela, Tomi P
>Sent: Thursday, August 2, 2018 12:51 AM
>To: Vivi, Rodrigo ; Zanoni, Paulo R
>
>Cc: Srivatsa, Anusha ; intel-
>g...@lists.freedesktop.org; Martin Peres
>Subject: Re: [Intel-gfx] [PATCH] firmware/dmc/icl: load v1.07 on icelake.
>
>On 08/02/2018
Em Sex, 2018-07-20 às 17:15 +0300, Imre Deak escreveu:
> Similarly to the previous patch use a separate request/status HW flag
> index defined right after the corresponding control registers instead
> of
> depending for this on the power well IDs. Since the set of
> control/status registers varies
Quoting Mika Kuoppala (2018-08-02 16:30:24)
> Chris Wilson writes:
>
> > We used to reset last_adj to 0 on crossing a power domain boundary, to
> > slow down our rate of change. However, commit 60548c554be2 ("drm/i915:
> > Interactive RPS mode") accidentally caused it to be reset on every
> > fre
Quoting Rogozhkin, Dmitry V (2018-08-02 20:37:36)
> I was actually surprised why they don't rely on i915 wait function.
> They responded in was: "I would gladly always use bo_wait ioctl, but it
> has big overhead for short workloads." Thus the question: do we have an
> opportunity to improve? Can w
On Thu, 2018-08-02 at 15:54 +0100, Chris Wilson wrote:
> Quoting Tvrtko Ursulin (2018-08-02 15:47:37)
> >
> > On 28/07/2018 17:46, Chris Wilson wrote:
> > > Here we bump the busyspin for the current request to avoid
> > > sleeping and
> > > the cost of both idling and downclocking the CPU.
> > >
On Thu, 2018-08-02 at 11:00 +0100, Tvrtko Ursulin wrote:
> [Picking this point in the thread to reply on some points mentioned
> by
> folks in the whole thread.]
>
> I don't remember if any patches from Lionel's series actually had r-
> b's,
> but a few people including myself have certainly bee
== Series Details ==
Series: drm/i915/lpe: Mark LPE audio as "no callbacks"
URL : https://patchwork.freedesktop.org/series/47620/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4606_full -> Patchwork_9843_full =
== Summary - FAILURE ==
Serious unknown changes coming with
Chris Wilson writes:
> We used to reset last_adj to 0 on crossing a power domain boundary, to
> slow down our rate of change. However, commit 60548c554be2 ("drm/i915:
> Interactive RPS mode") accidentally caused it to be reset on every
> frequency update, nerfing the fast response granted by the
Hi Steven,
Thanks for your reply,
On Wed, 2018-08-01 at 21:48 -0400, Steven Rostedt wrote:
> I'm just catching up from my vacation. What about making rs->missed
> into an atomic, and have:
>
> if (!raw_spin_trylock_irqsave(&rs->lock, flags)) {
> atomic_inc(&rs->missed);
>
On 28/07/2018 17:46, Chris Wilson wrote:
A recent trend for cpufreq is to boost the CPU frequencies for
iowaiters, in particularly to benefit high frequency I/O. We do the same
and boost the GPU clocks to try and minimise time spent waiting for the
GPU. However, as the igfx and CPU share the sam
Quoting Tvrtko Ursulin (2018-08-02 15:47:37)
>
> On 28/07/2018 17:46, Chris Wilson wrote:
> > Here we bump the busyspin for the current request to avoid sleeping and
> > the cost of both idling and downclocking the CPU.
> >
> > Signed-off-by: Chris Wilson
> > Cc: Sagar Kamble
> > Cc: Eero Tammi
Quoting Patchwork (2018-08-02 15:38:35)
> Possible fixes
>
> igt@pm_rpm@basic-rte:
> {fi-byt-clapper}: FAIL (fdo#107357) -> PASS +1
\o/
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop
On 28/07/2018 17:46, Chris Wilson wrote:
Here we bump the busyspin for the current request to avoid sleeping and
the cost of both idling and downclocking the CPU.
Signed-off-by: Chris Wilson
Cc: Sagar Kamble
Cc: Eero Tamminen
Cc: Francisco Jerez
Cc: Tvrtko Ursulin
Cc: Ben Widawsky
Cc: Joo
Quoting Tvrtko Ursulin (2018-08-02 15:40:27)
>
> On 28/07/2018 17:46, Chris Wilson wrote:
> > Looking at the distribution of i915_wait_request for a set of GL
>
> What was the set?
>
> > benchmarks, we see:
> >
> > broadwell# python bcc/tools/funclatency.py -u i915_wait_request
> > usecs
On 02/08/2018 15:40, Tvrtko Ursulin wrote:
On 28/07/2018 17:46, Chris Wilson wrote:
Looking at the distribution of i915_wait_request for a set of GL
What was the set?
benchmarks, we see:
broadwell# python bcc/tools/funclatency.py -u i915_wait_request
usecs : count di
Quoting Tvrtko Ursulin (2018-08-02 15:33:33)
>
> On 28/07/2018 17:46, Chris Wilson wrote:
> > We want to expose the parameters for controlling how long it takes for
> > us to notice and park the GPU after a stream of requests in order to try
> > and tune the optimal power-efficiency vs latency of
On 28/07/2018 17:46, Chris Wilson wrote:
Looking at the distribution of i915_wait_request for a set of GL
What was the set?
benchmarks, we see:
broadwell# python bcc/tools/funclatency.py -u i915_wait_request
usecs : count distribution
0 -> 1 : 29184
== Series Details ==
Series: drm/i915/lpe: Mark LPE audio as "no callbacks"
URL : https://patchwork.freedesktop.org/series/47620/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4606 -> Patchwork_9843 =
== Summary - SUCCESS ==
No regressions found.
External URL:
https:
On 28/07/2018 17:46, Chris Wilson wrote:
We want to expose the parameters for controlling how long it takes for
us to notice and park the GPU after a stream of requests in order to try
and tune the optimal power-efficiency vs latency of a mostly idle system.
Who do we expect to tweak these and
Quoting Tvrtko Ursulin (2018-08-02 15:15:35)
>
> On 28/07/2018 17:46, Chris Wilson wrote:
> > An interesting discussion regarding "hybrid interrupt polling" for NVMe
> > came to the conclusion that the ideal busyspin before sleeping was half
> > of the expected request latency (and better if it wa
On 28/07/2018 17:46, Chris Wilson wrote:
An interesting discussion regarding "hybrid interrupt polling" for NVMe
came to the conclusion that the ideal busyspin before sleeping was half
of the expected request latency (and better if it was already halfway
through that request). This suggested tha
The LPE audio is a child device of i915, it is powered up and down
alongside the igfx and presents no independent runtime interface. This
aptly fulfils the description of a "No-Callback" Device, so mark it
thus.
Fixes: 183c00350ccd ("drm/i915: Fix runtime PM for LPE audio")
Testcase: igt/pm_rpm/ba
Op 02-08-18 om 15:03 schreef Chris Wilson:
> Quoting Maarten Lankhorst (2018-08-02 11:42:32)
>> Op 02-07-18 om 13:27 schreef Maarten Lankhorst:
>>> Op 02-07-18 om 13:16 schreef Mahesh Kumar:
Now crc-core framework verifies the source string passed by the user.
So setting bad-source will f
== Series Details ==
Series: tests/kms_pipe_crc_basic: expect setting bad source to fail (rev2)
URL : https://patchwork.freedesktop.org/series/45768/
State : success
== Summary ==
= CI Bug Log - changes from IGT_4582_full -> IGTPW_1677_full =
== Summary - SUCCESS ==
No regressions found.
== Series Details ==
Series: Improve crc-core driver interface (rev9)
URL : https://patchwork.freedesktop.org/series/45246/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4606 -> Patchwork_9842 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_9842 a
Quoting Maarten Lankhorst (2018-08-02 11:42:32)
> Op 02-07-18 om 13:27 schreef Maarten Lankhorst:
> > Op 02-07-18 om 13:16 schreef Mahesh Kumar:
> >> Now crc-core framework verifies the source string passed by the user.
> >> So setting bad-source will fail. Expect file write to fail in bad-source
>
On Thu, 2018-08-02 at 10:14 +0100, Chris Wilson wrote:
> Quoting Bartminski, Jakub (2018-08-02 09:56:10)
> > On Wed, 2018-08-01 at 15:22 +0100, Chris Wilson wrote:
> > > Quoting Jakub Bartmiński (2018-08-01 14:56:11)
> > > > [...]
> > > Though the argument that as long as its preemptible (and
> > >
On Wed, Aug 01, 2018 at 02:39:31PM -0700, Paulo Zanoni wrote:
> Em Sex, 2018-07-20 às 17:14 +0300, Imre Deak escreveu:
> > It makes sense to keep unchanging data const. Extract such fields
> > from
> > the i915_power_well struct into a new i915_power_well_desc struct
> > that
> > we initialize duri
On Wed, Aug 01, 2018 at 03:15:40PM -0700, Paulo Zanoni wrote:
> Em Sex, 2018-07-20 às 17:14 +0300, Imre Deak escreveu:
> > Atm, we determine the control/status flag offsets within the PUNIT
> > control/status registers based on the power well's ID. Since the
> > power
> > well ID enum is global acr
== Series Details ==
Series: tests/kms_pipe_crc_basic: expect setting bad source to fail (rev2)
URL : https://patchwork.freedesktop.org/series/45768/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4605 -> IGTPW_1677 =
== Summary - SUCCESS ==
No regressions found.
Exter
== Series Details ==
Series: series starting with [1/4] drm/i915: Drop stray clearing of
rps->last_adj
URL : https://patchwork.freedesktop.org/series/47600/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4605_full -> Patchwork_9841_full =
== Summary - WARNING ==
Minor un
Hi Dave,
Two fixes for 4.19 here. For an oops on the DP CEC code and a memory leak on
the vkms driver. Please pull.
Regards,
Gustavo
drm-misc-next-fixes-2018-08-02:
Fixes an oops on the DP CEC code and a memory leak on the vkms driver.
The following changes since commit 6d52aacd92c60331ec8c3117
Hi,
On 8/2/2018 4:13 PM, Maarten Lankhorst wrote:
Op 02-08-18 om 12:42 schreef Maarten Lankhorst:
Op 02-07-18 om 13:27 schreef Maarten Lankhorst:
Op 02-07-18 om 13:16 schreef Mahesh Kumar:
Now crc-core framework verifies the source string passed by the user.
So setting bad-source will fail.
== Series Details ==
Series: series starting with [1/4] drm/i915: Drop stray clearing of
rps->last_adj
URL : https://patchwork.freedesktop.org/series/47600/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4605 -> Patchwork_9841 =
== Summary - SUCCESS ==
No regressions fou
Op 02-08-18 om 12:42 schreef Maarten Lankhorst:
> Op 02-07-18 om 13:27 schreef Maarten Lankhorst:
>> Op 02-07-18 om 13:16 schreef Mahesh Kumar:
>>> Now crc-core framework verifies the source string passed by the user.
>>> So setting bad-source will fail. Expect file write to fail in bad-source
>>>
Op 02-07-18 om 13:27 schreef Maarten Lankhorst:
> Op 02-07-18 om 13:16 schreef Mahesh Kumar:
>> Now crc-core framework verifies the source string passed by the user.
>> So setting bad-source will fail. Expect file write to fail in bad-source
>> subtest of kms_pipe_crc_basic.
>>
>> Signed-off-by: Ma
On 27/07/2018 23:17, John Harrison wrote:
On 7/19/2018 2:36 AM, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Frequency timeline needs to be finished with an entry spanning to the end
of known time so that the last known frequency is displayed.
Signed-off-by: Tvrtko Ursulin
---
scripts/trace.p
On 27/07/2018 22:47, John Harrison wrote:
On 7/19/2018 2:36 AM, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Bring back the button which expands/stacks overlapping timeline boxes.
We default to no stacking, but sometimes expanding the view can be useful,
especially with deep request pipelines.
On 27/07/2018 22:37, John Harrison wrote:
On 7/19/2018 2:35 AM, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Skip accounting the context save time for anything but the last request of
the coalesced bunch, and also skip drawing those boxes on the timeline.
Signed-off-by: Tvrtko Ursulin
---
scr
On 7/31/2018 7:43 AM, Manasi Navare wrote:
From: "Srivatsa, Anusha"
Add defines for DSS_CTL registers.
These registers specify the big joiner, splitter,
overlap pixels and info regarding display stream
compression enabled on left or right branch.
v2:
- Add define to conditionally check the buf
We used to reset last_adj to 0 on crossing a power domain boundary, to
slow down our rate of change. However, commit 60548c554be2 ("drm/i915:
Interactive RPS mode") accidentally caused it to be reset on every
frequency update, nerfing the fast response granted by the slow start
algorithm.
Fixes: 6
Make sure that the RPS IIR is completely clear on disabling so we should
not get any more interrupts after idling. Since the IIR is shared with
the guc, we have to be careful to only clobber RPS events.
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
---
drivers/gpu/drm/i915/i915_irq.c | 8 +-
Currently, we note congestion for the slow start ramping up of RPS only
when we overshoot the target workload and have to reverse direction for
our reclocking. That is, if we have a period where the current GPU
frequency is enough to sustain the workload within our target
utilisation, we should not
Having stored the IIR for action, we should always clear it.
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
---
drivers/gpu/drm/i915/i915_irq.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 90628
[Picking this point in the thread to reply on some points mentioned by
folks in the whole thread.]
I don't remember if any patches from Lionel's series actually had r-b's,
but a few people including myself have certainly been reviewing them. If
I had applied the final r-b I wouldn't have mad
== Series Details ==
Series: series starting with [1/2] drm/i915: Drop stray clearing of
rps->last_adj (rev2)
URL : https://patchwork.freedesktop.org/series/47554/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4605_full -> Patchwork_9840_full =
== Summary - SUCCESS ==
N
Quoting Bartminski, Jakub (2018-08-02 09:56:10)
> On Wed, 2018-08-01 at 15:22 +0100, Chris Wilson wrote:
> > Quoting Jakub Bartmiński (2018-08-01 14:56:11)
> > > [...]
> > > + /* We have already tried preempting, but the hardware did
> > > not react */
> > > + if (engine->hangcheck.try_
On Wed, 2018-08-01 at 15:22 +0100, Chris Wilson wrote:
> Quoting Jakub Bartmiński (2018-08-01 14:56:11)
> > [...]
> > + /* We have already tried preempting, but the hardware did
> > not react */
> > + if (engine->hangcheck.try_preempt)
> > + return false;
> > +
> > +
== Series Details ==
Series: firmware/dmc/icl: load v1.07 on icelake. (rev2)
URL : https://patchwork.freedesktop.org/series/47450/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4605_full -> Patchwork_9839_full =
== Summary - SUCCESS ==
No regressions found.
== Known
== Series Details ==
Series: series starting with [1/2] drm/i915: Drop stray clearing of
rps->last_adj (rev2)
URL : https://patchwork.freedesktop.org/series/47554/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4605 -> Patchwork_9840 =
== Summary - SUCCESS ==
No regressi
On 08/02/2018 10:15 AM, Tomi Sarvela wrote:
On 08/02/2018 08:11 AM, Rodrigo Vivi wrote:
On Wed, Aug 01, 2018 at 05:30:49PM -0700, Paulo Zanoni wrote:
Em Qua, 2018-08-01 às 17:07 -0700, Anusha Srivatsa escreveu:
Add Support to load DMC on Icelake.
While at it, also add support to load the firm
== Series Details ==
Series: firmware/dmc/icl: load v1.07 on icelake. (rev2)
URL : https://patchwork.freedesktop.org/series/47450/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4605 -> Patchwork_9839 =
== Summary - SUCCESS ==
No regressions found.
External URL:
https
== Series Details ==
Series: series starting with [1/2] drm/i915: Drop stray clearing of
rps->last_adj (rev2)
URL : https://patchwork.freedesktop.org/series/47554/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_4605_full -> Patchwork_9838_full =
== Summary - FAILURE ==
S
On 08/02/2018 08:11 AM, Rodrigo Vivi wrote:
On Wed, Aug 01, 2018 at 05:30:49PM -0700, Paulo Zanoni wrote:
Em Qua, 2018-08-01 às 17:07 -0700, Anusha Srivatsa escreveu:
Add Support to load DMC on Icelake.
While at it, also add support to load the firmware
during system resume.
v2: load firmware
71 matches
Mail list logo
