Re: [Intel-gfx] [PATCH 02/10] drm/i915: Rename intel_power_domains_fini() to intel_power_domains_fini_hw()

2018-07-29 Thread Rodrigo Vivi
On Fri, Jul 20, 2018 at 05:14:56PM +0300, Imre Deak wrote: > intel_power_domains_fini() rolls back what was done in > intel_power_domains_init_hw(), so rename and move it accordingly. This > allows us adding a cleanup function later for intel_power_domains_init() > in a cleaner way. > > No functio

Re: [Intel-gfx] [PATCH 01/10] drm/i915/icl: Fix power well anonymous union initializers

2018-07-29 Thread Rodrigo Vivi
On Fri, Jul 20, 2018 at 05:14:55PM +0300, Imre Deak wrote: > Similarly to > 0a445945be6d ("drm/i915: Work around GCC anonymous union initialization bug") > we need to initialize anonymous unions inside extra braces to work > around a GCC4.4 build error. > > Cc: Chris Wilson > Cc: Ville Syrjala >

Re: [Intel-gfx] [PATCH] drm/i915: Do not use iowait while waiting for the GPU

2018-07-29 Thread Francisco Jerez
Chris Wilson writes: > Quoting Francisco Jerez (2018-07-28 21:18:50) >> Chris Wilson writes: >> >> > Quoting Francisco Jerez (2018-07-28 06:20:12) >> >> Chris Wilson writes: >> >> >> >> > A recent trend for cpufreq is to boost the CPU frequencies for >> >> > iowaiters, in particularly to bene

[Intel-gfx] [PATCH v2 i-g-t 2/2] Fix truncate string in the snprintf

2018-07-29 Thread Rodrigo Siqueira
This patch fix the following GCC warning: ../tools/intel_reg.c: In function ‘dump_decode’: ../tools/intel_reg.c:203:41: warning: ‘snprintf’ output may be truncated before the last format character [-Wformat-truncation=] snprintf(decode, sizeof(decode), "\n%s", bin); [..] ../tools/intel_reg.c:20

[Intel-gfx] [PATCH v2 i-g-t 1/2] Make string commands dynamic allocate

2018-07-29 Thread Rodrigo Siqueira
This patch fix the following GCC warning: intel_gvtg_test.c: In function ‘create_guest’: intel_gvtg_test.c:127:50: warning: ‘%s’ directive writing up to 4095 bytes into a region of size 4077 [-Wformat-overflow=] [..] intel_gvtg_test.c:127:5: note: ‘sprintf’ output between 36 and 8226 bytes into a

[Intel-gfx] [PATCH v2 i-g-t 0/2] Fix some GCC warnings

2018-07-29 Thread Rodrigo Siqueira
During the compilation, some GCC (8.1) warnings are shown. This patchset address some of the warnings problems. Changes since v2: - Reduce the total amount of bytes allocated during command handling operation - Remove unnecessary memset operation - Improved commit message Rodrigo Siqueira (