[Intel-gfx] [PULL] gvt-fixes for 4.18

2018-07-10 Thread Zhenyu Wang
Hi, Here's one gvt fix for KBL vGPU hang to update virtual register from LRI. Thanks. -- The following changes since commit a4cae23cc05ccec749c2fc70fa9d8cda7c582319: drm/i915/gvt: changed DDI mode emulation type (2018-07-02 11:09:59 +0800) are available in the Git repository at: https://g

[Intel-gfx] [PULL] gvt-next for 4.19

2018-07-10 Thread Zhenyu Wang
Hi, Here's last gvt-next pull for 4.19. Biggest change is to add vGPU huge page support for guest, with one BXT fix and gvt dependency handling. Thanks. -- The following changes since commit 57c8a484a9cbf1315b5299702d12aef04867: drm/i915: Enable KVMGT for BXT. (2018-06-13 10:57:30 +0800)

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/7] Cast void * pointer used in arithmetic to uint32_t*

2018-07-10 Thread Rodrigo Siqueira
Hi, Thanks for the feedback, I'm just a little bit confused about the next step here. Is it worth to fix this patch and the others? I got confused since you said that IGT will remove autotools and some of the warnings here does not appear on meson. Best Regards Rodrigo Siqueira On 07/10, Arkadi

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev5)

2018-07-10 Thread Patchwork
== Series Details == Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev5) URL : https://patchwork.freedesktop.org/series/6/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4467_full -> Patchwork_9606_full = == Summary - FAILURE == Serious unknown change

[Intel-gfx] [PULL] drm-intel-next for 4.19

2018-07-10 Thread Rodrigo Vivi
Hi Dave, This is probably the last big pull targeting 4.19. I will probably send another small one by the end of this week and if possible another smaller one by next one. Here goes drm-intel-next-2018-07-09: Higlights here goes to many PSR fixes and improvements; to the Ice lake work with powe

Re: [Intel-gfx] [PATCH 1/2] x86/gpu: reserve ICL's graphics stolen memory

2018-07-10 Thread Rodrigo Vivi
On Wed, Jul 04, 2018 at 07:50:42AM +0200, Ingo Molnar wrote: > > * Rodrigo Vivi wrote: > > > > Cc: Thomas Gleixner > > > > > > Cc: Ingo Molnar > > > > > > Cc: H. Peter Anvin > > > > > > Cc: x...@kernel.org > > > > > > guys, could we push this through drm-intel? ack? > > > nack? comments? > >

[Intel-gfx] [PULL] drm-intel-fixes

2018-07-10 Thread Rodrigo Vivi
Hi Dave, Things are calm around drm-intel and we have only 1 fix for hotplug irq on old platforms for this round. I saw that you already send the pull request for 4.18-rc5 So I think this could wait for the next week. But up to you. Here goes drm-intel-fixes-2018-07-10: - Fix hotplug irq ack on

Re: [Intel-gfx] [PATCH] drm/i915: Look for an active kernel context before switching

2018-07-10 Thread Rodrigo Vivi
On Tue, Jul 10, 2018 at 09:09:07PM +0100, Chris Wilson wrote: > Quoting Rodrigo Vivi (2018-07-10 20:59:26) > > Hi Chris, this failed the cherry-pick for drm-intel-fixes, but looking > > to the log it seems something we want there right?! > > It didn't become crucial until a later patch: > > commi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev5)

2018-07-10 Thread Patchwork
== Series Details == Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev5) URL : https://patchwork.freedesktop.org/series/6/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4467 -> Patchwork_9606 = == Summary - SUCCESS == No regressions found. Externa

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev5)

2018-07-10 Thread Patchwork
== Series Details == Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev5) URL : https://patchwork.freedesktop.org/series/6/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. -drivers/gpu/drm/i915/selftest

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev5)

2018-07-10 Thread Patchwork
== Series Details == Series: drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. (rev5) URL : https://patchwork.freedesktop.org/series/6/ State : warning == Summary == $ dim checkpatch origin/drm-tip 068faa878cfc drm/i915/glk: Add Quirk for GLK NUC HDMI port issues. -:36: CHECK:SPACING:

Re: [Intel-gfx] [PATCH] drm/i915: Look for an active kernel context before switching

2018-07-10 Thread Chris Wilson
Quoting Rodrigo Vivi (2018-07-10 20:59:26) > Hi Chris, this failed the cherry-pick for drm-intel-fixes, but looking > to the log it seems something we want there right?! It didn't become crucial until a later patch: commit 4dfacb0bcbee79fa2ef4b2e9e64a8f8a28598934 Author: Chris Wilson Date: Thu

[Intel-gfx] [PATCH v5] drm/i915/glk: Add Quirk for GLK NUC HDMI port issues.

2018-07-10 Thread Radhakrishna Sripada
From: Clint Taylor On GLK NUC platforms the HDMI retiming buffer needs additional disabled time to correctly sync to a faster incoming signal. When measured on a scope the highspeed lines of the HDMI clock turn off for ~400uS during a normal resolution change. The HDMI retimer on the GLK NUC a

Re: [Intel-gfx] [PATCH] drm/i915: Look for an active kernel context before switching

2018-07-10 Thread Rodrigo Vivi
On Thu, May 24, 2018 at 03:51:23PM +0100, Chris Wilson wrote: > Quoting Mika Kuoppala (2018-05-24 15:40:47) > > Chris Wilson writes: > > > > > We were not very carefully checking to see if an older request on the > > > engine was an earlier switch-to-kernel-context before deciding to emit a > > >

Re: [Intel-gfx] [PATCH] drm/dp: implement EXTENDED_RECEIVER_CAPABILITY_FIELD_PRESENT

2018-07-10 Thread Manasi Navare
Matt, is the new revision already submitted to the M-L? Manasi On Tue, Jun 26, 2018 at 07:54:19AM -0700, Atwood, Matthew S wrote: > ill uprev by EOD > > From: Navare, Manasi D > Sent: Monday, June 25, 2018 5:39 PM > To: Atwood, Matthew S > Cc: intel-gfx@li

Re: [Intel-gfx] [PATCH v4] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-10 Thread Lis, Tomasz
On 2018-07-09 18:28, Tvrtko Ursulin wrote: On 09/07/2018 14:20, Tomasz Lis wrote: The patch adds a parameter to control the data port coherency functionality on a per-context level. When the IOCTL is called, a command to switch data port coherency state is added to the ordered list. All prio

Re: [Intel-gfx] [PATCH v4] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-10 Thread Lis, Tomasz
On 2018-07-09 18:37, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-07-09 17:28:02) On 09/07/2018 14:20, Tomasz Lis wrote: +static int i915_gem_context_clear_data_port_coherent(struct i915_gem_context *ctx) +{ + int ret; + + ret = intel_lr_context_modify_data_port_coherency(ctx, fa

Re: [Intel-gfx] [PATCH 1/2] drm/i915/icl: move has_resource_streamer to GEN11_FEATURES

2018-07-10 Thread Daniele Ceraolo Spurio
On 09/07/18 17:06, Lucas De Marchi wrote: Resource streamer has been removed on GEN11 so move it to the FEATURES macro. Signed-off-by: Lucas De Marchi Reviewed-by: Daniele Ceraolo Spurio Daniele --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +- drivers/gpu/drm/i915/i915_pci.c

[Intel-gfx] ✓ Fi.CI.IGT: success for ICELAKE DSI DRIVER (rev5)

2018-07-10 Thread Patchwork
== Series Details == Series: ICELAKE DSI DRIVER (rev5) URL : https://patchwork.freedesktop.org/series/44823/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4462_full -> Patchwork_9603_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_9603_full nee

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-10 Thread Leon Romanovsky
On Tue, Jul 10, 2018 at 04:14:10PM +0200, Michal Hocko wrote: > On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > > > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > > > This is the v2 of RFC based on the feedback I've received so

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/wsim: Simulate and interpret .wsim

2018-07-10 Thread Tvrtko Ursulin
On 10/07/2018 16:40, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-07-10 16:38:14) On 10/07/2018 14:47, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-05-11 09:31:52) On 11/05/2018 08:11, Chris Wilson wrote: A little tool I've been meaning to write for a while... Convert the .wsim int

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Stop tracking MRU activity on VMA

2018-07-10 Thread Tvrtko Ursulin
On 10/07/2018 13:37, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-07-10 13:19:51) On 09/07/2018 14:02, Chris Wilson wrote: Our goal is to remove struct_mutex and replace it with fine grained locking. One of the thorny issues is our eviction logic for reclaiming space for an execbuffer (or

Re: [Intel-gfx] [PATCH v2] drm/i915: Unwind HW init after GVT setup failure

2018-07-10 Thread Chris Wilson
Quoting Michał Winiarski (2018-07-10 16:44:05) > On Tue, Jul 10, 2018 at 03:38:21PM +0100, Chris Wilson wrote: > > Following intel_gvt_init() failure, we missed unwinding our setup > > leaving pointers dangling past the module unload. For our example, the > > pm_qos: > > > > [ 441.057615] top: 00

Re: [Intel-gfx] [PATCH v2] drm/i915: Unwind HW init after GVT setup failure

2018-07-10 Thread Michał Winiarski
On Tue, Jul 10, 2018 at 03:38:21PM +0100, Chris Wilson wrote: > Following intel_gvt_init() failure, we missed unwinding our setup > leaving pointers dangling past the module unload. For our example, the > pm_qos: > > [ 441.057615] top: 6b3baf1c, n: 54d8ef33, p: 97cdf1a2 >

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/wsim: Simulate and interpret .wsim

2018-07-10 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-07-10 16:38:14) > > On 10/07/2018 14:47, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-05-11 09:31:52) > >> > >> On 11/05/2018 08:11, Chris Wilson wrote: > >>> A little tool I've been meaning to write for a while... Convert the > >>> .wsim into their dag and fin

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/wsim: Simulate and interpret .wsim

2018-07-10 Thread Tvrtko Ursulin
On 10/07/2018 14:47, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-05-11 09:31:52) On 11/05/2018 08:11, Chris Wilson wrote: A little tool I've been meaning to write for a while... Convert the .wsim into their dag and find the longest chains and evaluate them on an simulated machine. Very

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Unwind HW init after GVT setup failure (rev2)

2018-07-10 Thread Patchwork
== Series Details == Series: drm/i915: Unwind HW init after GVT setup failure (rev2) URL : https://patchwork.freedesktop.org/series/46263/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4464 -> Patchwork_9605 = == Summary - FAILURE == Serious unknown changes coming with P

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Flush the residual parking on emergency shutdown

2018-07-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Flush the residual parking on emergency shutdown URL : https://patchwork.freedesktop.org/series/46251/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4461_full -> Patchwork_9602_full = == Summary - WARNING ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Unwind HW init after GVT setup failure

2018-07-10 Thread Patchwork
== Series Details == Series: drm/i915: Unwind HW init after GVT setup failure URL : https://patchwork.freedesktop.org/series/46263/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4464 -> Patchwork_9604 = == Summary - SUCCESS == No regressions found. External URL: http

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/7] Cast void * pointer used in arithmetic to uint32_t*

2018-07-10 Thread Chris Wilson
Quoting Arkadiusz Hiler (2018-07-10 15:38:26) > On Tue, Jul 10, 2018 at 03:09:25PM +0100, Chris Wilson wrote: > > Quoting Arkadiusz Hiler (2018-07-10 14:58:49) > > > On Sat, Jul 07, 2018 at 08:22:38PM -0300, Rodrigo Siqueira wrote: > > > > This commit fixes the GCC warning: > > > > > > > > warning

Re: [Intel-gfx] [PATCH v2] drm/i915: Unwind HW init after GVT setup failure

2018-07-10 Thread Chris Wilson
Quoting Chris Wilson (2018-07-10 15:38:21) > Following intel_gvt_init() failure, we missed unwinding our setup > leaving pointers dangling past the module unload. For our example, the > pm_qos: > > [ 441.057615] top: 6b3baf1c, n: 54d8ef33, p: 97cdf1a2 >prev

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/7] Cast void * pointer used in arithmetic to uint32_t*

2018-07-10 Thread Arkadiusz Hiler
On Tue, Jul 10, 2018 at 03:09:25PM +0100, Chris Wilson wrote: > Quoting Arkadiusz Hiler (2018-07-10 14:58:49) > > On Sat, Jul 07, 2018 at 08:22:38PM -0300, Rodrigo Siqueira wrote: > > > This commit fixes the GCC warning: > > > > > > warning: pointer of type ‘void *’ used in arithmetic [-Wpointer-a

[Intel-gfx] [PATCH v2] drm/i915: Unwind HW init after GVT setup failure

2018-07-10 Thread Chris Wilson
Following intel_gvt_init() failure, we missed unwinding our setup leaving pointers dangling past the module unload. For our example, the pm_qos: [ 441.057615] top: 6b3baf1c, n: 54d8ef33, p: 97cdf1a2 prev: 54d8ef33, n: 97cdf1a2, p: 6b3

[Intel-gfx] [PATCH] drm/i915: Unwind HW init after GVT setup failure

2018-07-10 Thread Chris Wilson
Following intel_gvt_init() failure, we missed unwinding our setup leaving pointers dangling past the module unload. For our example, the pm_qos: [ 441.057615] top: 6b3baf1c, n: 54d8ef33, p: 97cdf1a2 prev: 54d8ef33, n: 97cdf1a2, p: 6b3

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-10 Thread Michal Hocko
On Tue 10-07-18 16:40:40, Leon Romanovsky wrote: > On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > > This is the v2 of RFC based on the feedback I've received so far. The > > > code even compiles as a bonus ;) I haven't runtime tes

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/7] Cast void * pointer used in arithmetic to uint32_t*

2018-07-10 Thread Chris Wilson
Quoting Arkadiusz Hiler (2018-07-10 14:58:49) > On Sat, Jul 07, 2018 at 08:22:38PM -0300, Rodrigo Siqueira wrote: > > This commit fixes the GCC warning: > > > > warning: pointer of type ‘void *’ used in arithmetic [-Wpointer-arith] > > memset(ptr + offsets[0], full_range ? 0x00 : 0x10, > >

Re: [Intel-gfx] [PATCH i-g-t 4/7] Fix truncate string in the snprintf

2018-07-10 Thread Arkadiusz Hiler
On Sat, Jul 07, 2018 at 08:23:17PM -0300, Rodrigo Siqueira wrote: > This patch fix the following GCC warning: > > intel_reg.c: In function ‘dump_decode’: > warning: ‘snprintf’ output may be truncated before the last format character > [-Wformat-truncation=] >snprintf(decode, sizeof(decode), "

Re: [Intel-gfx] [PATCH i-g-t 2/7] Cast void * pointer used in arithmetic to uint32_t*

2018-07-10 Thread Arkadiusz Hiler
On Sat, Jul 07, 2018 at 08:22:38PM -0300, Rodrigo Siqueira wrote: > This commit fixes the GCC warning: > > warning: pointer of type ‘void *’ used in arithmetic [-Wpointer-arith] > memset(ptr + offsets[0], full_range ? 0x00 : 0x10, > ^ > warning: pointer of type ‘void *’ used i

Re: [Intel-gfx] [PATCH i-g-t 1/7] Remove parameter aliases with another argument

2018-07-10 Thread Arkadiusz Hiler
On Sat, Jul 07, 2018 at 08:22:25PM -0300, Rodrigo Siqueira wrote: > This commit fixes the following GCC warning: > > warning: passing argument 2 to restrict-qualified parameter aliases with > argument 1 [-Wrestrict] > return (readlink (buf, buf, sizeof (buf)) != -1 && > > This commit fixes the

Re: [Intel-gfx] [PATCH i-g-t] benchmarks/wsim: Simulate and interpret .wsim

2018-07-10 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-11 09:31:52) > > On 11/05/2018 08:11, Chris Wilson wrote: > > A little tool I've been meaning to write for a while... Convert the > > .wsim into their dag and find the longest chains and evaluate them on an > > simulated machine. > > Very cool! Would you care to a

Re: [Intel-gfx] [RFC PATCH] mm, oom: distinguish blockable mode for mmu notifiers

2018-07-10 Thread Leon Romanovsky
On Mon, Jul 09, 2018 at 02:29:08PM +0200, Michal Hocko wrote: > On Wed 27-06-18 09:44:21, Michal Hocko wrote: > > This is the v2 of RFC based on the feedback I've received so far. The > > code even compiles as a bonus ;) I haven't runtime tested it yet, mostly > > because I have no idea how. > > >

Re: [Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

2018-07-10 Thread Chris Wilson
Quoting Mika Kuoppala (2018-07-10 14:30:15) > Chris Wilson writes: > > > As we ordinarily use a spinning batch to trigger a hang, we cannot do so > > without execbuf. On the other hand, if we do a manual reset of the > > wedged driver, we expect it to remain wedged and for the reset to fail; > >

Re: [Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

2018-07-10 Thread Mika Kuoppala
Chris Wilson writes: > As we ordinarily use a spinning batch to trigger a hang, we cannot do so > without execbuf. On the other hand, if we do a manual reset of the > wedged driver, we expect it to remain wedged and for the reset to fail; > failing the test. Even if we remove the igt_assert(!wedg

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Constrain mock_gtt tests to fit within RAM

2018-07-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Constrain mock_gtt tests to fit within RAM URL : https://patchwork.freedesktop.org/series/46247/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4460_full -> Patchwork_9601_full = == Summary - WARNING == Minor unknown change

Re: [Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

2018-07-10 Thread Chris Wilson
Quoting Mika Kuoppala (2018-07-10 14:13:39) > Chris Wilson writes: > > > As we ordinarily use a spinning batch to trigger a hang, we cannot do so > > without execbuf. On the other hand, if we do a manual reset of the > > wedged driver, we expect it to remain wedged and for the reset to fail; > >

Re: [Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-10 Thread Kumar, Mahesh
Hi, Thanks for the review. On 7/10/2018 5:19 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:27 EEST Mahesh Kumar wrote: This patch make changes to allocate crc-entries buffer before enabling CRC generation. It moves all the failure check early in

Re: [Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

2018-07-10 Thread Mika Kuoppala
Chris Wilson writes: > As we ordinarily use a spinning batch to trigger a hang, we cannot do so > without execbuf. On the other hand, if we do a manual reset of the > wedged driver, we expect it to remain wedged and for the reset to fail; by 'manual' you are referring to '-1' on i915_wedged debu

Re: [Intel-gfx] [PATCH v5 0/8] drm: Add generic fbdev emulation

2018-07-10 Thread Noralf Trønnes
Den 03.07.2018 18.03, skrev Noralf Trønnes: This patchset adds generic fbdev emulation for drivers that supports GEM based dumb buffers which support .gem_prime_vmap and gem_prime_mmap. An API is begun to support in-kernel clients in general. I've squashed the client patches to ease review. All

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Flush the residual parking on emergency shutdown

2018-07-10 Thread Chris Wilson
Quoting Matthew Auld (2018-07-10 13:34:02) > On 10 July 2018 at 10:44, Chris Wilson wrote: > > On unwinding following a critical failure inside GEM init, we also need > > to be sure to flush the workers before unloading the module. > > > > Testcase: igt/drv_module_reload/basic-reload-inject > > Si

Re: [Intel-gfx] [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-10 Thread Kumar, Mahesh
Hi, thanks foe the review. On 7/10/2018 5:07 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:24 EEST Mahesh Kumar wrote: This patch implements "verify_crc_source" callback function for rcar drm driver. Signed-off-by: Mahesh Kumar Cc: dri-de...@l

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Stop tracking MRU activity on VMA

2018-07-10 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-07-10 13:19:51) > > On 09/07/2018 14:02, Chris Wilson wrote: > > Our goal is to remove struct_mutex and replace it with fine grained > > locking. One of the thorny issues is our eviction logic for reclaiming > > space for an execbuffer (or GTT mmaping, among a few othe

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Flush the residual parking on emergency shutdown

2018-07-10 Thread Matthew Auld
On 10 July 2018 at 10:44, Chris Wilson wrote: > On unwinding following a critical failure inside GEM init, we also need > to be sure to flush the workers before unloading the module. > > Testcase: igt/drv_module_reload/basic-reload-inject > Signed-off-by: Chris Wilson For the series: Reviewed-by

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Stop tracking MRU activity on VMA

2018-07-10 Thread Tvrtko Ursulin
On 09/07/2018 14:02, Chris Wilson wrote: Our goal is to remove struct_mutex and replace it with fine grained locking. One of the thorny issues is our eviction logic for reclaiming space for an execbuffer (or GTT mmaping, among a few other examples). While eviction itself is easy to move under a

Re: [Intel-gfx] [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-10 Thread Kumar, Mahesh
Hi, On 7/10/2018 5:40 PM, Laurent Pinchart wrote: Hi Mahesh, On Tuesday, 10 July 2018 14:54:11 EEST Kumar, Mahesh wrote: On 7/10/2018 4:56 PM, Laurent Pinchart wrote: On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: This patch adds a new callback function "verify_crc_source" which w

Re: [Intel-gfx] [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-10 Thread Kumar, Mahesh
Hi, On 7/10/2018 5:39 PM, Laurent Pinchart wrote: Hi Mahesh, On Tuesday, 10 July 2018 15:01:38 EEST Kumar, Mahesh wrote: On 7/10/2018 4:52 PM, Laurent Pinchart wrote: Hi Mahesh, On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: This patch introduce a callback function "get_crc_source

Re: [Intel-gfx] [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, On Tuesday, 10 July 2018 14:54:11 EEST Kumar, Mahesh wrote: > On 7/10/2018 4:56 PM, Laurent Pinchart wrote: > > On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: > >> This patch adds a new callback function "verify_crc_source" which will > >> be used during setting the crc source

Re: [Intel-gfx] [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, On Tuesday, 10 July 2018 15:01:38 EEST Kumar, Mahesh wrote: > On 7/10/2018 4:52 PM, Laurent Pinchart wrote: > > Hi Mahesh, > > On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: > >> This patch introduce a callback function "get_crc_sources" which > >> will be called during read o

Re: [Intel-gfx] [PATCH 10/10] drm: crc: Introduce pre_crc_read function

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:29 EEST Mahesh Kumar wrote: > This patch implements a callback function "pre_crc_read" which will > be called before crc read. In this function driver can implement and > preparation work required for successfully reading CRC data.

Re: [Intel-gfx] [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-10 Thread Kumar, Mahesh
Hi, thanks for the review. On 7/10/2018 4:52 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: This patch introduce a callback function "get_crc_sources" which will be called during read of control node. It is an optional

Re: [Intel-gfx] [PATCH 09/10] Revert "drm: crc: Wait for a frame before returning from open()"

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:28 EEST Mahesh Kumar wrote: > This reverts commit e8fa5671183c80342d520ad81d14fa79a9d4a680. > > Don't wait for first CRC during crtc_crc_open. It avoids one frame wait > during open. If application want to wait after read call, it

Re: [Intel-gfx] [PATCH 06/12] mm: use for_each_if

2018-07-10 Thread Pavel Tatashin
LGTM: Reviewed-by: Pavel Tatashin ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] kernel.h: Add for_each_if()

2018-07-10 Thread NeilBrown
On Tue, Jul 10 2018, Daniel Vetter wrote: > On Mon, Jul 09, 2018 at 04:30:01PM -0700, Andrew Morton wrote: >> On Mon, 9 Jul 2018 18:25:09 +0200 Daniel Vetter >> wrote: >> >> > To avoid compilers complainig about ambigious else blocks when putting >> > an if condition into a for_each macro one

Re: [Intel-gfx] [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-10 Thread Kumar, Mahesh
Hi, Thanks for the review, On 7/10/2018 4:56 PM, Laurent Pinchart wrote: Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: This patch adds a new callback function "verify_crc_source" which will be used during setting the crc source in control node an

Re: [Intel-gfx] [PATCH 08/10] drm/crc: Cleanup crtc_crc_open function

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:27 EEST Mahesh Kumar wrote: > This patch make changes to allocate crc-entries buffer before > enabling CRC generation. > It moves all the failure check early in the function before setting > the source or memory allocation. > Now se

Re: [Intel-gfx] [PATCH 05/10] drm/rcar-du/crc: Implement verify_crc_source callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:24 EEST Mahesh Kumar wrote: > This patch implements "verify_crc_source" callback function for > rcar drm driver. > > Signed-off-by: Mahesh Kumar > Cc: dri-de...@lists.freedesktop.org > Reviewed-by: Maarten Lankhorst > --- > driv

[Intel-gfx] [PATCH i-g-t] lib: Require working GEM (!wedged) to allow hang injection

2018-07-10 Thread Chris Wilson
As we ordinarily use a spinning batch to trigger a hang, we cannot do so without execbuf. On the other hand, if we do a manual reset of the wedged driver, we expect it to remain wedged and for the reset to fail; failing the test. Even if we remove the igt_assert(!wedged), the test is suspect as we

Re: [Intel-gfx] [PATCH 01/10] drm: crc: Introduce verify_crc_source callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:20 EEST Mahesh Kumar wrote: > This patch adds a new callback function "verify_crc_source" which will > be used during setting the crc source in control node and while opening > data node for crc reading. This will help in avoiding s

Re: [Intel-gfx] [PATCH 02/10] drm: crc: Introduce get_crc_sources callback

2018-07-10 Thread Laurent Pinchart
Hi Mahesh, Thank you for the patch. On Monday, 2 July 2018 14:07:21 EEST Mahesh Kumar wrote: > This patch introduce a callback function "get_crc_sources" which > will be called during read of control node. It is an optional > callback function and if driver implements this callback, driver > shou

[Intel-gfx] ✓ Fi.CI.BAT: success for ICELAKE DSI DRIVER (rev5)

2018-07-10 Thread Patchwork
== Series Details == Series: ICELAKE DSI DRIVER (rev5) URL : https://patchwork.freedesktop.org/series/44823/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4462 -> Patchwork_9603 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedeskt

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for ICELAKE DSI DRIVER (rev5)

2018-07-10 Thread Patchwork
== Series Details == Series: ICELAKE DSI DRIVER (rev5) URL : https://patchwork.freedesktop.org/series/44823/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/icl: Configure lane sequencing of combo phy transmitter Okay! Commit: drm/i915/icl: DSI vswing programming se

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for ICELAKE DSI DRIVER (rev5)

2018-07-10 Thread Patchwork
== Series Details == Series: ICELAKE DSI DRIVER (rev5) URL : https://patchwork.freedesktop.org/series/44823/ State : warning == Summary == $ dim checkpatch origin/drm-tip 30f4f160de53 drm/i915/icl: Configure lane sequencing of combo phy transmitter c677ebaee69e drm/i915/icl: DSI vswing program

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev4)

2018-07-10 Thread Patchwork
== Series Details == Series: drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev4) URL : https://patchwork.freedesktop.org/series/46104/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4458_full -> Patchwork_9600_full = == Summary - WARNING == Minor

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Flush the residual parking on emergency shutdown

2018-07-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Flush the residual parking on emergency shutdown URL : https://patchwork.freedesktop.org/series/46251/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4461 -> Patchwork_9602 = == Summary - SUCCESS == No reg

Re: [Intel-gfx] [PATCH 08/11] drm/i915: Move fence-reg interface to i915_gem_fence_reg.h

2018-07-10 Thread Mika Kuoppala
Chris Wilson writes: > Since we have a header file for i915_gem_fence_reg, let's use it for the > interface prototypes currently hidden away in the huge i915_drv.h > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_drv.h | 15 --

Re: [Intel-gfx] [PATCH 07/11] drm/i915: Tidy i915_gem_suspend()

2018-07-10 Thread Mika Kuoppala
Chris Wilson writes: > In the next patch, we will make a fairly minor change to flush > outstanding resets before suspend. In order to keep churn to a minimum > in that functional patch, we fix up the comments and coding style now. > > Signed-off-by: Chris Wilson Reviewed-by: Mika Kuoppala >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: kill resource streamer

2018-07-10 Thread Chris Wilson
Quoting Lucas De Marchi (2018-07-10 01:06:58) > diff --git a/drivers/gpu/drm/i915/i915_gem_execbuffer.c > b/drivers/gpu/drm/i915/i915_gem_execbuffer.c > index 1932bc227942..a5eec97a40fe 100644 > --- a/drivers/gpu/drm/i915/i915_gem_execbuffer.c > +++ b/drivers/gpu/drm/i915/i915_gem_execbuffer.c > @

[Intel-gfx] [PATCH v5 01/13] drm/i915/icl: Configure lane sequencing of combo phy transmitter

2018-07-10 Thread Madhav Chauhan
This patch set the loadgen select and latency optimization for aux and transmit lanes of combo phy transmitters. It will be used for MIPI DSI HS operations. v2: Rebase Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/icl_dsi.c | 38 ++ 1 file changed, 3

[Intel-gfx] [PATCH v5 00/13] ICELAKE DSI DRIVER

2018-07-10 Thread Madhav Chauhan
From ICELAKE platform onwards, new MIPI DSI IP controller is integrated to GPU/Display Engine and same could be extended for future Intel platforms as well. DSI IP controller supports MIPI DSI 1.3 and DPHY 1.2 specification. So, a new DSI driver has been added inside I915. Given below patches ar

[Intel-gfx] [PATCH v5 11/13] drm/i915/icl: Add macros for MMIO of DSI transcoder registers

2018-07-10 Thread Madhav Chauhan
This patch adds _MMIO_DSI and _DSI_TRANS macros for accessing DSI transcoder registers. Credits-to: Jani N Cc: Jani Nikula Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/i915_reg.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/dr

[Intel-gfx] [PATCH v5 04/13] drm/i915/icl: Define T_INIT_MASTER registers

2018-07-10 Thread Madhav Chauhan
This patch defines DSI_T_INIT_MASTER register for DSI ports 0/1 which will be used in dphy programming. Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/i915_reg.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h in

[Intel-gfx] [PATCH v5 13/13] drm/i915/icl: Configure DSI transcoders

2018-07-10 Thread Madhav Chauhan
This patch programs DSI operation mode, pixel format, BGR info, link calibration etc for the DSI transcoder. This patch also extract BGR info of the DSI panel from VBT and save it inside struct intel_dsi which used for configuring DSI transcoder. v2: Rebase Signed-off-by: Madhav Chauhan --- dri

[Intel-gfx] [PATCH v5 09/13] drm/i915/icl: Program TA_TIMING_PARAM registers

2018-07-10 Thread Madhav Chauhan
This patch programs D-PHY timing parameters for the bus turn around flow(in escape clocks) only if dsi link frequency <=800 MHz using DPHY_TA_TIMING_PARAM and its identical register DSI_TA_TIMING_PARAM (inside DSI Controller within the Display Core). Signed-off-by: Madhav Chauhan --- drivers/gpu

[Intel-gfx] [PATCH v5 08/13] drm/i915/icl: Define TA_TIMING_PARAM registers

2018-07-10 Thread Madhav Chauhan
This patch defines DSI_TA_TIMING_PARAM and DPHY_TA_TIMING_PARAM registers used in dphy programming. Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/i915_reg.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_re

[Intel-gfx] [PATCH v5 10/13] drm/i915/icl: Get DSI transcoder for a given port

2018-07-10 Thread Madhav Chauhan
This patch adds a helper function to retrieve DSI transcoder for a given DSI port using newly defined enum names for DSI transcoders. Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/icl_dsi.c | 9 + drivers/gpu/drm/i915/intel_display.h | 6 -- 2 files changed, 13 inserti

[Intel-gfx] [PATCH v5 12/13] drm/i915/icl: Define TRANS_DSI_FUNC_CONF register

2018-07-10 Thread Madhav Chauhan
This patch defines transcoder function configuration registers and its bitfields for both DSI ports. Used while programming/enabling DSI transcoder. Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/i915_reg.h | 47 + 1 file changed, 47 insertions(+)

[Intel-gfx] [PATCH v5 06/13] drm/i915/icl: Define data/clock lanes dphy timing registers

2018-07-10 Thread Madhav Chauhan
This patch defines DSI_CLK_TIMING_PARAM, DPHY_CLK_TIMING_PARAM, DSI_DATA_TIMING_PARAM, DPHY_DATA_TIMING_PARAM register used in dphy programming. Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/i915_reg.h | 40 1 file changed, 40 insertions(+) diff

[Intel-gfx] [PATCH v5 07/13] drm/i915/icl: Program DSI clock and data lane timing params

2018-07-10 Thread Madhav Chauhan
This patch programs D-PHY timing parameters for the clock and data lane (in escape clocks) of DSI controller (DSI port 0 and 1). These programmed timings would be used by DSI Controller to calculate link transition latencies of the data and clock lanes. Signed-off-by: Madhav Chauhan --- drivers/

[Intel-gfx] [PATCH v5 03/13] drm/i915/icl: Enable DDI Buffer

2018-07-10 Thread Madhav Chauhan
This patch enables DDI buffer by writing to DDI_BUF_CTL register and wait for DDI status to be *not idle* for a port. v2: Rebase Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/icl_dsi.c | 22 ++ 1 file changed, 22 insertions(+) diff --git a/drivers/gpu/drm/i915/icl_

[Intel-gfx] [PATCH v5 02/13] drm/i915/icl: DSI vswing programming sequence

2018-07-10 Thread Madhav Chauhan
This patch setup voltage swing before enabling combo PHY DDI (shared with DSI). Note that DSI voltage swing programming is for high speed data buffers. HW automatically handles the voltage swing for the low power data buffers. v2: Rebase Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/ic

[Intel-gfx] [PATCH v5 05/13] drm/i915/icl: Program T_INIT_MASTER registers

2018-07-10 Thread Madhav Chauhan
This patch programs the time (in escape clocks) to drive the link in the initialization (i.e. LP-11) state. v2: Rebase Signed-off-by: Madhav Chauhan --- drivers/gpu/drm/i915/icl_dsi.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/i915/icl_dsi.c b/drive

[Intel-gfx] [PATCH 1/2] drm/i915: Flush the residual parking on emergency shutdown

2018-07-10 Thread Chris Wilson
On unwinding following a critical failure inside GEM init, we also need to be sure to flush the workers before unloading the module. Testcase: igt/drv_module_reload/basic-reload-inject Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 2 ++ drivers/gpu/drm/i915/intel_display

[Intel-gfx] [PATCH 2/2] drm/i915: Cleanup modesetting on load-error path

2018-07-10 Thread Chris Wilson
After handling a critical failure initialising GEM we need to unwind the modesetting setup. Testcase: igt/drv_module_reload/basic-reload-inject Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i

[Intel-gfx] ✗ Fi.CI.IGT: failure for Kill resource streamer

2018-07-10 Thread Patchwork
== Series Details == Series: Kill resource streamer URL : https://patchwork.freedesktop.org/series/46224/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4458_full -> Patchwork_9599_full = == Summary - FAILURE == Serious unknown changes coming with Patchwork_9599_full abso

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Constrain mock_gtt tests to fit within RAM

2018-07-10 Thread Chris Wilson
Quoting Matthew Auld (2018-07-10 09:27:10) > On 10 July 2018 at 09:04, Chris Wilson wrote: > > Be pessimistic and presume that we actually allocate every page we > > exercise via the mock_gtt (e.g. for gvt). In which case we have to keep > > our working case under the available physical memory to

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Filter out both physical address swizzles

2018-07-10 Thread Chris Wilson
Quoting Matthew Auld (2018-07-10 09:46:13) > On 9 July 2018 at 20:49, Chris Wilson wrote: > > In our swizzling selftests, we cannot predict the physical address of > > the target page (at least not simply!) and so skip bit17 swizzles. > > However, there are two bit17 swizzle modes and we only skip

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Filter out both physical address swizzles

2018-07-10 Thread Matthew Auld
On 9 July 2018 at 20:49, Chris Wilson wrote: > In our swizzling selftests, we cannot predict the physical address of > the target page (at least not simply!) and so skip bit17 swizzles. > However, there are two bit17 swizzle modes and we only skipped on, with we only skipped one > the second bei

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Constrain mock_gtt tests to fit within RAM

2018-07-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Constrain mock_gtt tests to fit within RAM URL : https://patchwork.freedesktop.org/series/46247/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4460 -> Patchwork_9601 = == Summary - SUCCESS == No regressions found. Exter

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Constrain mock_gtt tests to fit within RAM

2018-07-10 Thread Matthew Auld
On 10 July 2018 at 09:04, Chris Wilson wrote: > Be pessimistic and presume that we actually allocate every page we > exercise via the mock_gtt (e.g. for gvt). In which case we have to keep > our working case under the available physical memory to prevent oom. > > Signed-off-by: Chris Wilson > Cc:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/selftests: Constrain mock_gtt tests to fit within RAM

2018-07-10 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Constrain mock_gtt tests to fit within RAM URL : https://patchwork.freedesktop.org/series/46247/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/selftests: Constrain mock_gtt tests to fit within RAM +drivers/gpu/drm/i9

[Intel-gfx] [PATCH] drm/i915/selftests: Constrain mock_gtt tests to fit within RAM

2018-07-10 Thread Chris Wilson
Be pessimistic and presume that we actually allocate every page we exercise via the mock_gtt (e.g. for gvt). In which case we have to keep our working case under the available physical memory to prevent oom. Signed-off-by: Chris Wilson Cc: Matthew Auld --- drivers/gpu/drm/i915/selftests/i915_ge

  1   2   >