[Intel-gfx] [PATCH 11/27] drm/i915: Refactor export_fence() after i915_vma_move_to_active()

Currently all callers are responsible for adding the vma to the active timeline and then exporting its fence. Combine the two operations into i915_vma_move_to_active() to move all the extra handling from the callers to the single site. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin ---

[Intel-gfx] [PATCH 14/27] drm/i915: Move i915_vma_move_to_active() to i915_vma.c

i915_vma_move_to_active() has grown beyond its execbuf origins, and should take its rightful place in i915_vma.c as a method for i915_vma! Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h| 3 -- drivers/gpu/drm/i915/i915_gem_execbuffer.c |

[Intel-gfx] [PATCH 16/27] drm/i915: Track the last-active inside the i915_vma

Using a VMA on more than one timeline concurrently is the exception rather than the rule (using it concurrently on multiple engines). As we expect to only use one active tracker, store the most recently used tracker inside the i915_vma itself and only fallback to the rbtree if we need a second or m

[Intel-gfx] [PATCH 10/27] drm/i915/selftests: Skip live context execution test without logical contexts

If the HW (or driver) doesn't support logical contexts, don't pretend we gain anything from trying to execute GPU commands with them. At best it reports -ENODEV, which is an unhelpful failure that we should just skip. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_gem_contex

[Intel-gfx] [PATCH 07/27] drm/i915/selftests: Skip live eviction tests when wedged

If the GPU is irrecoverably wedged, we cannot submit any requests and so cannot make the GTT busy in order to test evicting active objects. As this expectedly fails, skip over the test. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_gem_evict.c | 3 +++ 1 file changed, 3 ins

[Intel-gfx] [PATCH 08/27] drm/i915/selftests: Skip huge pages live tests if wedged

We test the GPU handling of huge pages by submitting requests that write into a huge page, but if the GPU is irrecoverably wedged we cannot submit any requests. As the test expectedly fails, skip over it. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/huge_pages.c | 3 +++ 1 file

[Intel-gfx] [PATCH 15/27] drm/i915: Track vma activity per fence.context, not per engine

In the next patch, we will want to be able to use more flexible request timelines that can hop between engines. From the vma pov, we can then not rely on the binding of this request to an engine and so can not ensure that different requests are ordered through a per-engine timeline, and so we must

[Intel-gfx] [PATCH 13/27] drm/i915: Start returning an error from i915_vma_move_to_active()

Handling such a late error in request construction is tricky, but to accommodate future patches which may allocate here, we potentially could err. To handle the error after already adjusting global state to track the new request, we must finish and submit the request. But we don't want to use the r

[Intel-gfx] [PATCH 02/27] drm/i915/selftests: Destroy partial tiling vma after use

As we keep VMA around until the object is destroyed, when testing partial tiling we instantiate many, many VMA (as the object is huge allowing for many different partial regions). We test elsewhere our handling of populating large objects with a full set of VMA and checking we can retrieve them aft

[Intel-gfx] [PATCH 01/27] drm/i915: Squelch very verbose error logging

Having found the error causing the IGT test to fail, downgrade the verbose logging so that we stop flooding the syslogs as we deliberately provoke it many thousands of time during selftests. References: 10195b1e4411 ("drm/i915: Show vma allocator stack when in doubt") Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH 12/27] drm/i915: Export i915_request_skip()

In the next patch, we will want to start skipping requests on failing to complete their payloads. So export the utility function current used to make requests inoperable following a failed gpu reset. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c

[Intel-gfx] [PATCH 03/27] drm/i915/selftests: Skip using the GPU if wedged

If the GPU is irrecoverably broken, we can not use it to dirty memory and check for cache coherency with the CPU. All we can do is simply skip over the GPU subtests and focus on the CPU domains (WC, WB) cache management. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107127 Signed-off-by:

[Intel-gfx] [PATCH 09/27] drm/i915/selftests: Skip over live context testing when wedged

If the GPU is terminally wedged we cannot submit any requests into a context, completely unfulfilling our purpose of doing so. As this expectedly fails, skip over the test. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_gem_context.c | 3 +++ 1 file changed, 3 insertions(+)

[Intel-gfx] [PATCH 19/27] drm/i915: Stop tracking MRU activity on VMA

Our goal is to remove struct_mutex and replace it with fine grained locking. One of the thorny issues is our eviction logic for reclaiming space for an execbuffer (or GTT mmaping, among a few other examples). While eviction itself is easy to move under a per-VM mutex, performing the activity tracki

[Intel-gfx] [PATCH 25/27] drm/i915: Dynamically allocate the array of drm_i915_gem_fence_reg

If we dynamically allocate the correct sized array for the fence registers, we can avoid the 4x overallocation on older, typically smaller devices and avoid having to know the static layout in advance. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 33 d

[Intel-gfx] [PATCH 22/27] drm/i915: Convert fences to use a GGTT lock rather than struct_mutex

Introduce a new mutex to guard all of the vma operations within a vm (as opposed to the BKL struct_mutex) and start by using it to guard the fence operations for a GGTT VMA. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c| 9 ++- drivers/gpu/drm/i915/i915_gem.c

[Intel-gfx] [PATCH 20/27] drm/i915: Introduce i915_address_space.mutex

Add a mutex into struct i915_address_space to be used while operating on the vma and their lists for a particular vm. As this may be called from the shrinker, we taint the mutex with fs_reclaim so that from the start lockdep warns us if we are caught holding the mutex across an allocation. (With su

[Intel-gfx] [PATCH 24/27] drm/i915: Move fence-reg interface to i915_gem_fence_reg.h

Since we have a header file for i915_gem_fence_reg, let's use it for the interface prototypes currently hidden away in the huge i915_drv.h Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h | 15 --- drivers/gpu/drm/i915/i915_gem_fence_reg.h | 16 ++

[Intel-gfx] [PATCH 21/27] drm/i915: Move fence register tracking to GGTT

As the fence registers define special regions of the mappable aperture inside the Global GTT, and we track those regions using GGTT VMA, it makes sense to pull that bookkeeping under i915_ggtt. The advantage is that we can then start using a local GGTT lock to handle the fence registers (in conjunc

[Intel-gfx] [PATCH 18/27] drm/i915: Only reset hangcheck at the start of an activity cycle

Across a reset, the seqno (and thus hangcheck) should restart and the hangcheck naturally progress, for when it does not, we want to declare an emergency. Currently, we only detect if reset and reinit fails, but we do not detect if the call to reinit succeeds but the HW is fried - as we are resetti

[Intel-gfx] [PATCH 27/27] drm/i915: Remove GPU reset dependence on struct_mutex

Now that the submission backends are controlled via their own spinlocks, with a wave of a magic wand we can lift the struct_mutex requirement around GPU reset. That is we allow the submission frontend (userspace) to keep on submitting while we process the GPU reset as we can suspend the backend ind

[Intel-gfx] [PATCH 23/27] drm/i915: Tidy i915_gem_suspend()

In the next patch, we will make a fairly minor change to flush outstanding resets before suspend. In order to keep churn to a minimum in that functional patch, we fix up the comments and coding style now. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 50 +-

[Intel-gfx] [PATCH 26/27] drm/i915: Pull all the reset functionality together into i915_reset.c

Currently the code to reset the GPU and our state is spread widely across a few files. Pull the logic together into a common file. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Makefile |3 +- drivers/gpu/drm/i915/i915_debugfs.c |2 + drivers/gpu/drm/i915

[Intel-gfx] [PATCH 05/27] drm/i915/selftests: Skip all request selftests when wedged

If the GPU is irrecoverably wedge, we cannot submit any request and so all of the request selftests will expectedly fail. Skip over them. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_request.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/sel

[Intel-gfx] [PATCH 06/27] drm/i915/selftests: Skip workaround tests when wedged

If the GPU is irrecoverably wedged, we cannot submit any request and therefore cannot query the register state of the context (which is done using the GPU command stream). So skip over the test as it expectedly fails. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_workaroun

[Intel-gfx] [PATCH 04/27] drm/i915/selftests: Skip making an object busy if the GPU is wedged

If the GPU is wedged, we cannot make the object busy as trying to submit a request will generate -EIO. Skip to the end of the test. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_gem_object.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/selftes

[Intel-gfx] [PATCH 17/27] drm/i915: Replace nested subclassing with explicit subclasses

In the next patch, we will want a third distinct class of timeline that may overlap with the current pair of client and engine timeline classes. Rather than use the ad hoc markup of SINGLE_DEPTH_NESTING, initialise the different timeline classes with an explicit subclass. Signed-off-by: Chris Wils

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Skip over live context testing when wedged

Quoting Rodrigo Vivi (2018-07-05 21:52:10) > On Thu, Jul 05, 2018 at 03:58:45PM +0100, Chris Wilson wrote: > > If the GPU is terminally wedged we cannot submit any requests into a > > context, completely unfulfilling our purpose of doing so. As this > > expectedly fails, skip over the test. > > >

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fail hangcheck testing if the GPU is wedged

Quoting Rodrigo Vivi (2018-07-05 21:44:56) > On Thu, Jul 05, 2018 at 04:02:14PM +0100, Chris Wilson wrote: > > If the GPU is irrecoverably wedged on startup, it means that it failed > > on initialisation and we have already tried to reset it but failed. We > > can ignore all further testing, as it

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Fail hangcheck testing if the GPU is wedged

== Series Details == Series: drm/i915/selftests: Fail hangcheck testing if the GPU is wedged URL : https://patchwork.freedesktop.org/series/46011/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4436_full -> Patchwork_9548_full = == Summary - WARNING == Minor unknown chang

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: remove confusing GPIO vs PCH_GPIO

== Series Details == Series: drm/i915: remove confusing GPIO vs PCH_GPIO URL : https://patchwork.freedesktop.org/series/46049/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4440 -> Patchwork_9559 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_955

[Intel-gfx] [PATCH] drm/i915: remove confusing GPIO vs PCH_GPIO

Instead of defining all registers twice, define just a PCH_GPIO_BASE that has the same address as PCH_GPIO_A and use that to calculate all the others. This also brings VLV and !HAS_GMCH_DISPLAY in line, doing the same thing. Signed-off-by: Lucas De Marchi --- As discussed on https://patchwork.fr

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Skip over live context testing when wedged

== Series Details == Series: drm/i915/selftests: Skip over live context testing when wedged URL : https://patchwork.freedesktop.org/series/46009/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4435_full -> Patchwork_9547_full = == Summary - FAILURE == Serious unknown chan

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Skip huge pages live tests if wedged

== Series Details == Series: drm/i915/selftests: Skip huge pages live tests if wedged URL : https://patchwork.freedesktop.org/series/46008/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4435_full -> Patchwork_9546_full = == Summary - WARNING == Minor unknown changes comi

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Skip live eviction tests when wedged

== Series Details == Series: drm/i915/selftests: Skip live eviction tests when wedged URL : https://patchwork.freedesktop.org/series/46007/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4435_full -> Patchwork_9545_full = == Summary - FAILURE == Serious unknown changes co

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Kill sink_crc for good

== Series Details == Series: drm/i915: Kill sink_crc for good URL : https://patchwork.freedesktop.org/series/46039/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4438 -> Patchwork_9558 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_9558 absolutel

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Skip workaround tests when wedged

== Series Details == Series: drm/i915/selftests: Skip workaround tests when wedged URL : https://patchwork.freedesktop.org/series/46006/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4434_full -> Patchwork_9544_full = == Summary - FAILURE == Serious unknown changes comin

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Kill sink_crc for good

== Series Details == Series: drm/i915: Kill sink_crc for good URL : https://patchwork.freedesktop.org/series/46039/ State : warning == Summary == $ dim checkpatch origin/drm-tip d2a9904c7bc2 drm/i915: Kill sink_crc for good -:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit descripti

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm: Extract __setplane_check() (rev3)

== Series Details == Series: series starting with [1/3] drm: Extract __setplane_check() (rev3) URL : https://patchwork.freedesktop.org/series/45589/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4438 -> Patchwork_9557 = == Summary - SUCCESS == No regressions found. Ex

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm: Extract __setplane_check() (rev3)

== Series Details == Series: series starting with [1/3] drm: Extract __setplane_check() (rev3) URL : https://patchwork.freedesktop.org/series/45589/ State : warning == Summary == $ dim checkpatch origin/drm-tip fc689c6dc4d2 drm: Extract __setplane_check() -:54: CHECK:SPACING: No space is neces

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Squelch very verbose error logging

== Series Details == Series: drm/i915: Squelch very verbose error logging URL : https://patchwork.freedesktop.org/series/46032/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4438 -> Patchwork_9556 = == Summary - SUCCESS == No regressions found. External URL: https://

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Squelch very verbose error logging

== Series Details == Series: drm/i915: Squelch very verbose error logging URL : https://patchwork.freedesktop.org/series/46032/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Squelch very verbose error logging + +Error in reading or end of file. __

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Squelch very verbose error logging

== Series Details == Series: drm/i915: Squelch very verbose error logging URL : https://patchwork.freedesktop.org/series/46032/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2465d597588b drm/i915: Squelch very verbose error logging -:10: WARNING:COMMIT_LOG_LONG_LINE: Possible u

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Split sink status into a separate debugfs node

== Series Details == Series: drm/i915/psr: Split sink status into a separate debugfs node URL : https://patchwork.freedesktop.org/series/45952/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4438 -> Patchwork_9555 = == Summary - SUCCESS == No regressions found. Externa

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftest: Skip all request selftests when wedged

== Series Details == Series: drm/i915/selftest: Skip all request selftests when wedged URL : https://patchwork.freedesktop.org/series/46005/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4434_full -> Patchwork_9543_full = == Summary - WARNING == Minor unknown changes com

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Destroy partial tiling vma after use

== Series Details == Series: drm/i915/selftests: Destroy partial tiling vma after use URL : https://patchwork.freedesktop.org/series/46031/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4438 -> Patchwork_9554 = == Summary - SUCCESS == No regressions found. External UR

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Detect unknown swizzling correctly

== Series Details == Series: drm/i915/selftests: Detect unknown swizzling correctly URL : https://patchwork.freedesktop.org/series/46026/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4438 -> Patchwork_9553 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Skip making an object busy if the GPU is wedged

== Series Details == Series: drm/i915/selftests: Skip making an object busy if the GPU is wedged URL : https://patchwork.freedesktop.org/series/46004/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4434_full -> Patchwork_9542_full = == Summary - WARNING == Minor unknown c

Re: [Intel-gfx] [PATCH] drm/i915/psr: Split sink status into a separate debugfs node

On Thu, Jul 05, 2018 at 02:27:46PM -0700, Dhinakaran Pandiyan wrote: > On Thursday, July 5, 2018 2:04:18 PM PDT Rodrigo Vivi wrote: > > On Wed, Jul 04, 2018 at 05:31:21PM -0700, Dhinakaran Pandiyan wrote: > > > This allows to read i915_edp_psr_status from tests without triggering > > > any AUX comm

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Rewrite mst suspend/resume in terms of encoders

On Thu, Jul 05, 2018 at 07:43:52PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Rather than looping over all the ports and picking the encoder based on > the port, let's just loop over all the encoders instead. Gets rid of > some irq_port[] usage, which is a bit of an eye sore. > > Sign

Re: [Intel-gfx] [PATCH] drm/i915/psr: Split sink status into a separate debugfs node

On Thursday, July 5, 2018 2:04:18 PM PDT Rodrigo Vivi wrote: > On Wed, Jul 04, 2018 at 05:31:21PM -0700, Dhinakaran Pandiyan wrote: > > This allows to read i915_edp_psr_status from tests without triggering > > any AUX communication. Take this opportunity to move this under the > > eDP-1 connector d

Re: [Intel-gfx] [PATCH] drm/i915: Kill sink_crc for good

On Thu, Jul 05, 2018 at 02:11:45PM -0700, Dhinakaran Pandiyan wrote: > On Thursday, July 5, 2018 12:25:28 PM PDT Rodrigo Vivi wrote: > > It was originally introduced following the VESA spec in order to validate > > PSR. > > > > However we found so many issues around sink_crc that instead of helpin

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Introduce for_each_intel_dp()

On Thu, Jul 05, 2018 at 07:43:50PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Add a convenience macro for iterating DP encoders. > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_display.h | 4 > drivers/gpu/drm/i915/intel_dp.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Hotplug cleanups and whanot

== Series Details == Series: drm/i915: Hotplug cleanups and whanot URL : https://patchwork.freedesktop.org/series/46022/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4438 -> Patchwork_9552 = == Summary - SUCCESS == No regressions found. External URL: https://patchwo

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Pass hpd_pin to long_pulse_detect()

On Thu, Jul 05, 2018 at 07:43:55PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We're doing a pointless translation from hpd_pin to port simply for > passing the thing to long_pulse_detect(). Let's pass the hpd_pin > directly instead. > > This removes the assumption that the hpd_pin and

Re: [Intel-gfx] [PATCH] drm/i915: Kill sink_crc for good

On Thursday, July 5, 2018 12:25:28 PM PDT Rodrigo Vivi wrote: > It was originally introduced following the VESA spec in order to validate > PSR. > > However we found so many issues around sink_crc that instead of helping PSR > development it only brought another layer of trouble to the table. > >

Re: [Intel-gfx] [PATCH] drm/i915/psr: Split sink status into a separate debugfs node

On Wed, Jul 04, 2018 at 05:31:21PM -0700, Dhinakaran Pandiyan wrote: > This allows to read i915_edp_psr_status from tests without triggering > any AUX communication. Take this opportunity to move this under the > eDP-1 connector directory as the status we print is of the sink. > > Cc: Rodrigo Vivi

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Hotplug cleanups and whanot

== Series Details == Series: drm/i915: Hotplug cleanups and whanot URL : https://patchwork.freedesktop.org/series/46022/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Introduce for_each_intel_dp() Okay! Commit: drm/i915: Introduce intel_encoder_is_dig_port() Okay

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Hotplug cleanups and whanot

== Series Details == Series: drm/i915: Hotplug cleanups and whanot URL : https://patchwork.freedesktop.org/series/46022/ State : warning == Summary == $ dim checkpatch origin/drm-tip 1684bcc70562 drm/i915: Introduce for_each_intel_dp() -:21: ERROR:COMPLEX_MACRO: Macros with complex values shou

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Skip using the GPU if wedged

== Series Details == Series: drm/i915/selftests: Skip using the GPU if wedged URL : https://patchwork.freedesktop.org/series/46001/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4434_full -> Patchwork_9541_full = == Summary - FAILURE == Serious unknown changes coming wit

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Skip over live context testing when wedged

On Thu, Jul 05, 2018 at 03:58:45PM +0100, Chris Wilson wrote: > If the GPU is terminally wedged we cannot submit any requests into a > context, completely unfulfilling our purpose of doing so. As this > expectedly fails, skip over the test. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Skip live context execution test without logical contexts

== Series Details == Series: drm/i915/selftests: Skip live context execution test without logical contexts URL : https://patchwork.freedesktop.org/series/46015/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4438 -> Patchwork_9550 = == Summary - SUCCESS == No regressions

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Fixup recursive MI_BB_START for gen3 (rev2)

== Series Details == Series: drm/i915/selftests: Fixup recursive MI_BB_START for gen3 (rev2) URL : https://patchwork.freedesktop.org/series/46014/ State : failure == Summary == Applying: drm/i915/selftests: Fixup recursive MI_BB_START for gen3 error: sha1 information is lacking or useless (dr

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fail hangcheck testing if the GPU is wedged

On Thu, Jul 05, 2018 at 04:02:14PM +0100, Chris Wilson wrote: > If the GPU is irrecoverably wedged on startup, it means that it failed > on initialisation and we have already tried to reset it but failed. We > can ignore all further testing, as it is already dead. Failing early, > prevents us from

[Intel-gfx] ✓ Fi.CI.BAT: success for ICELAKE DSI DRIVER (rev4)

== Series Details == Series: ICELAKE DSI DRIVER (rev4) URL : https://patchwork.freedesktop.org/series/44823/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4438 -> Patchwork_9549 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedeskt

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Fail hangcheck testing if the GPU is wedged

== Series Details == Series: drm/i915/selftests: Fail hangcheck testing if the GPU is wedged URL : https://patchwork.freedesktop.org/series/46011/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4436 -> Patchwork_9548 = == Summary - SUCCESS == No regressions found. Exte

[Intel-gfx] [PATCH i-g-t] igt/gem_tiled_partial_pwrite_pread: Check for known swizzling

As we want to compare a templated tiling pattern against the target_bo, we need to know that the swizzling is compatible. Or else the two tiling pattern may differ due to underlying page address that we cannot know, and so the test may sporadically fail. References: https://bugs.freedesktop.org/sh

[Intel-gfx] [PATCH] drm/i915: Kill sink_crc for good

It was originally introduced following the VESA spec in order to validate PSR. However we found so many issues around sink_crc that instead of helping PSR development it only brought another layer of trouble to the table. So, sink_crc has been a black whole for us in question of time, effort and

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v3,1/3] drm/i915/dsi: rename the current DSI files based on first platform

== Series Details == Series: series starting with [v3,1/3] drm/i915/dsi: rename the current DSI files based on first platform URL : https://patchwork.freedesktop.org/series/45984/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4433_full -> Patchwork_9539_full = == Summary -

[Intel-gfx] [PATCH v2 3/3] drm: Skip __drm_mode_set_config_internal() on atomic drivers

From: Ville Syrjälä Everything (apart from the actual ->set_config() call) __drm_mode_set_config_internal() does is now useless on atomic drivers. So let's just skip all the foreplay. v2: Use drm_drv_uses_atomic_modeset() (Daniel) Signed-off-by: Ville Syrjälä Reviewed-by: Daniel Vetter --- d

[Intel-gfx] [PATCH v2 2/3] drm: Introduce __setplane_atomic()

From: Ville Syrjälä All the plane->fb/old_fb/crtc dance of __setplane_internal() is pointless on atomic drivers. So let's just introduce a simpler version that skips all that. Ideally we could also skip the __setplane_check() as drm_atomic_plane_check() already checks for everything, but the leg

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Skip over live context testing when wedged

== Series Details == Series: drm/i915/selftests: Skip over live context testing when wedged URL : https://patchwork.freedesktop.org/series/46009/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4435 -> Patchwork_9547 = == Summary - SUCCESS == No regressions found. Exter

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Detect unknown swizzling correctly

On Thu, Jul 05, 2018 at 06:15:23PM +0100, Chris Wilson wrote: > i915_gem_detect_bit_6_swizzle() tries to hide unknown swizzling from > userspace (and ourselves) leaving us with the only clue inside > i915->quirks & QUIRK_PIN_SWIZZLED_PAGES. If we see this bit set, it > means that we really have no

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Skip huge pages live tests if wedged

== Series Details == Series: drm/i915/selftests: Skip huge pages live tests if wedged URL : https://patchwork.freedesktop.org/series/46008/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4435 -> Patchwork_9546 = == Summary - SUCCESS == No regressions found. External UR

[Intel-gfx] [PATCH] drm/i915: Squelch very verbose error logging

Having found the error causing the IGT test to fail, downgrade the verbose logging so that we stop flooding the syslogs as we deliberately provoke it many thousands of time during selftests. References: 10195b1e4411 ("drm/i915: Show vma allocator stack when in doubt") Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH] drm/i915/selftests: Destroy partial tiling vma after use

As we keep VMA around until the object is destroyed, when testing partial tiling we instantiate many, many VMA (as the object is huge allowing for many different partial regions). We test elsewhere our handling of populating large objects with a full set of VMA and checking we can retrieve them aft

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Skip live eviction tests when wedged

== Series Details == Series: drm/i915/selftests: Skip live eviction tests when wedged URL : https://patchwork.freedesktop.org/series/46007/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4435 -> Patchwork_9545 = == Summary - SUCCESS == No regressions found. External UR

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Print the long_mask alongside the pin_mask

Quoting Ville Syrjala (2018-07-05 17:43:57) > From: Ville Syrjälä > > We're printing out which pins got a hotplug, so why not also print > out which pins detected the long pulse as opposed to a short pulse. > > Signed-off-by: Ville Syrjälä Reviewed-by: Chris Wilson -Chris _

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Assert that our hpd pin bitmasks don't overflow

Quoting Ville Syrjälä (2018-07-05 18:51:16) > On Thu, Jul 05, 2018 at 05:52:16PM +0100, Chris Wilson wrote: > > Quoting Ville Syrjala (2018-07-05 17:43:56) > > > From: Ville Syrjälä > > > > > > Make sure our hpd pin count doesn't exceed the bitmasks we use > > > for tracking pending hotplugs. Not

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Assert that our hpd pin bitmasks don't overflow

On Thu, Jul 05, 2018 at 05:52:16PM +0100, Chris Wilson wrote: > Quoting Ville Syrjala (2018-07-05 17:43:56) > > From: Ville Syrjälä > > > > Make sure our hpd pin count doesn't exceed the bitmasks we use > > for tracking pending hotplugs. Not ever close to the limit yet, > > but no harm in making

[Intel-gfx] [PATCH] drm/i915/selftests: Detect unknown swizzling correctly

i915_gem_detect_bit_6_swizzle() tries to hide unknown swizzling from userspace (and ourselves) leaving us with the only clue inside i915->quirks & QUIRK_PIN_SWIZZLED_PAGES. If we see this bit set, it means that we really have no clue as to what the swizzle pattern is being used in any one page and

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Skip workaround tests when wedged

== Series Details == Series: drm/i915/selftests: Skip workaround tests when wedged URL : https://patchwork.freedesktop.org/series/46006/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4434 -> Patchwork_9544 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Assert that our hpd pin bitmasks don't overflow

Quoting Ville Syrjala (2018-07-05 17:43:56) > From: Ville Syrjälä > > Make sure our hpd pin count doesn't exceed the bitmasks we use > for tracking pending hotplugs. Not ever close to the limit yet, > but no harm in making sure either. > > Signed-off-by: Ville Syrjälä > --- > drivers/gpu/drm/i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftest: Skip all request selftests when wedged

== Series Details == Series: drm/i915/selftest: Skip all request selftests when wedged URL : https://patchwork.freedesktop.org/series/46005/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4434 -> Patchwork_9543 = == Summary - SUCCESS == No regressions found. External U

[Intel-gfx] [PATCH 4/8] drm/i915: Nuke dev_priv->irq_port[]

From: Ville Syrjälä Instead of looping over ports and hpd_pins, let's loop over the encoders when doing hotplug processing. And instead of depending on dev_priv->irq_port[] to tell us whether the encoder has the ->hpd_pulse() hook or not, we can just check for that directly. So we can just nuke i

[Intel-gfx] [PATCH 8/8] drm/i915: Print the long_mask alongside the pin_mask

From: Ville Syrjälä We're printing out which pins got a hotplug, so why not also print out which pins detected the long pulse as opposed to a short pulse. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_irq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/dr

[Intel-gfx] [PATCH 7/8] drm/i915: Assert that our hpd pin bitmasks don't overflow

From: Ville Syrjälä Make sure our hpd pin count doesn't exceed the bitmasks we use for tracking pending hotplugs. Not ever close to the limit yet, but no harm in making sure either. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_irq.c | 2 ++ 1 file changed, 2 insertions(+) diff -

[Intel-gfx] [PATCH 3/8] drm/i915: Rewrite mst suspend/resume in terms of encoders

From: Ville Syrjälä Rather than looping over all the ports and picking the encoder based on the port, let's just loop over all the encoders instead. Gets rid of some irq_port[] usage, which is a bit of an eye sore. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- dr

[Intel-gfx] [PATCH 6/8] drm/i915: Pass hpd_pin to long_pulse_detect()

From: Ville Syrjälä We're doing a pointless translation from hpd_pin to port simply for passing the thing to long_pulse_detect(). Let's pass the hpd_pin directly instead. This removes the assumption that the hpd_pin and port always match. The only other place where we make that assumption anymor

[Intel-gfx] [PATCH 5/8] drm/i915: s/int i/enum hpd_pin pin/

From: Ville Syrjälä Use the enum hpd_pin type when talking about HPD pins, and rename the variable from a very nondescript 'i' to 'pin', a name we already use in other parts of the code. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_irq.c | 12 ++-- drivers/gpu/drm/i9

[Intel-gfx] [PATCH 2/8] drm/i915: Introduce intel_encoder_is_dig_port()

From: Ville Syrjälä Add intel_encoder_is_dig_port() to match intel_encoder_is_dp(). Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_drv.h | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm

[Intel-gfx] [PATCH 1/8] drm/i915: Introduce for_each_intel_dp()

From: Ville Syrjälä Add a convenience macro for iterating DP encoders. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.h | 4 drivers/gpu/drm/i915/intel_dp.c | 38 +++- drivers/gpu/drm/i915/intel_drv.h | 14 + 3 fil

[Intel-gfx] [PATCH 0/8] drm/i915: Hotplug cleanups and whanot

From: Ville Syrjälä A colleciton of cleanups I had lying around, mostly in the hotplug area, and a few other encoder related things. Ville Syrjälä (8): drm/i915: Introduce for_each_intel_dp() drm/i915: Introduce intel_encoder_is_dig_port() drm/i915: Rewrite mst suspend/resume in terms of e

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/ddi: Simplify get_encoder_power_domains()

== Series Details == Series: drm/i915/ddi: Simplify get_encoder_power_domains() URL : https://patchwork.freedesktop.org/series/45980/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4431_full -> Patchwork_9537_full = == Summary - WARNING == Minor unknown changes coming wit

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Fixup recursive MI_BB_START for gen3

On Thu, Jul 05, 2018 at 04:32:30PM +0100, Chris Wilson wrote: > There's no magic bit0 for gen3, it's the same dword length parameter as > elsewhere and needs to be zero. > > Signed-off-by: Chris Wilson Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/selftests/i915_request.c | 5 +

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Skip making an object busy if the GPU is wedged

== Series Details == Series: drm/i915/selftests: Skip making an object busy if the GPU is wedged URL : https://patchwork.freedesktop.org/series/46004/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4434 -> Patchwork_9542 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Skip using the GPU if wedged

== Series Details == Series: drm/i915/selftests: Skip using the GPU if wedged URL : https://patchwork.freedesktop.org/series/46001/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4434 -> Patchwork_9541 = == Summary - SUCCESS == No regressions found. External URL: http

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 02/17] igt/gem_tiled_partial_pwrite_pread: Check for known swizzling

Quoting Tvrtko Ursulin (2018-07-05 16:26:51) > > Okay, then question remains if you just want to drop the local struct > and ioctl definition since AFAICS the same definitions are in the kernel > since 2012. I haven't commented on that as there's no argument here. I was lazy and copied existing

Re: [Intel-gfx] [PATCH i-g-t 05/17] lib: Spin fast, retire early

Quoting Tvrtko Ursulin (2018-07-05 16:29:32) > > On 05/07/2018 13:42, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-07-05 13:33:55) > >> > >> On 05/07/2018 12:23, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2018-07-02 16:36:28) > > On 02/07/2018 10:07, Chris Wilson wrote: >

[Intel-gfx] [PATCH v2] drm/i915/selftests: Fixup recursive MI_BB_START for gen3

There's no magic bit0 for gen3, it's the same dword length parameter as elsewhere and needs to be zero. v2: Same bug in both live_requests and live_hanghcheck. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/i915_request.c| 5 + drivers/gpu/drm/i915/selftests/intel_hangch

  1   2   3   >