Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Feng Tang
Hi, On Wed, Jun 20, 2018 at 11:45:25AM +0200, Takashi Iwai wrote: > > > > > > > > Thanks for the info, I see your intension now. > > > > > > > > In previous discussion, Jani suggested to use a completion to indicate > > > > the probe done, I can't figure out another way :) > > > > > > I suggested

Re: [Intel-gfx] [PATCH v1] drm/i915: Add IOCTL Param to control data port coherency.

2018-06-20 Thread Joonas Lahtinen
Changelog would be much appreciated. And this is not the first version of the series. It helps to remind the reviewer that original implementation was changed into IOCTl based on feedback. Please see the git log in i915 for some examples. Quoting Tomasz Lis (2018-06-20 18:03:07) > The patch adds a

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/icp: Add Interrupt Support

2018-06-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/icp: Add Interrupt Support URL : https://patchwork.freedesktop.org/series/45124/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4354_full -> Patchwork_9375_full = == Summary - WARNING == Minor unknown change

Re: [Intel-gfx] [RFC] drm/i915: Fix assert_plane() warning on bootup with external display

2018-06-20 Thread Shaikh, Azhar
>-Original Message- >From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] >Sent: Tuesday, June 19, 2018 5:00 AM >To: Shaikh, Azhar >Cc: Jani Nikula ; intel-gfx@lists.freedesktop.org >Subject: Re: [Intel-gfx] [RFC] drm/i915: Fix assert_plane() warning on bootup >with external displa

[Intel-gfx] [PULL] drm-misc-next

2018-06-20 Thread Gustavo Padovan
Hi Dave, our first pull for 4.19, over 90 patches here, probably the most important ones are for the writeback connector support. Then we have a bunch of fixes to drivers, some interesting core cleanups and new panel drivers. This contains a backmerge of drm-next due to conflicts in drm_atomic.c

Re: [Intel-gfx] [PATCH 19/24] drm/i915/icl: store the port type for TC ports

2018-06-20 Thread Paulo Zanoni
Em Qui, 2018-06-14 às 12:59 -0700, Rodrigo Vivi escreveu: > On Mon, May 21, 2018 at 05:25:53PM -0700, Paulo Zanoni wrote: > > The type is detected based on the interrupt ISR bit. Once detected, > > it's not supposed to be changed, so we have some sanity checks for > > that. > > > > Cc: Animesh Man

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/fbc/cnl: Add GLK and CNL+ hardware tracking size

2018-06-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/fbc/cnl: Add GLK and CNL+ hardware tracking size URL : https://patchwork.freedesktop.org/series/45129/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4355 -> Patchwork_9376 = == Summary - SUCCESS == No regr

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/fbc/cnl: Add GLK and CNL+ hardware tracking size

2018-06-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/fbc/cnl: Add GLK and CNL+ hardware tracking size URL : https://patchwork.freedesktop.org/series/45129/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/fbc/cnl: Add GLK and CNL+ hardware tracking size O

[Intel-gfx] [PATCH 2/2] drm/i915/fbc: Resize CFB in non-full modeset paths

2018-06-20 Thread José Roberto de Souza
A simple page flip can cause the CFB required size to increase and if it is bigger than the currently allocated CFB it needs to be resized to activate FBC again. Until now this case was not being handled but CI is starting to get some of this errors. So here it will free the old CFB and try to al

[Intel-gfx] [PATCH 1/2] drm/i915/fbc/cnl: Add GLK and CNL+ hardware tracking size

2018-06-20 Thread José Roberto de Souza
Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/intel_fbc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_fbc.c b/drivers/gpu/drm/i915/intel_fbc.c index b431b6733cc1..eb0f95390968 100644 --- a/drivers/gpu/drm/i915/intel_fbc.c +++

Re: [Intel-gfx] [PATCH 2/2] drm/i915/icl: implement icl_digital_port_connected()

2018-06-20 Thread kbuild test robot
Hi Paulo, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20180620] [cannot apply to v4.18-rc1] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/icp: Add Interrupt Support

2018-06-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/icp: Add Interrupt Support URL : https://patchwork.freedesktop.org/series/45124/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4354 -> Patchwork_9375 = == Summary - SUCCESS == No regressions found. Exter

Re: [Intel-gfx] [PATCH] drm/i915: mark expected switch fall-through

2018-06-20 Thread Gustavo A. R. Silva
On 06/20/2018 02:06 PM, Rodrigo Vivi wrote: On Wed, Jun 20, 2018 at 08:31:00AM -0500, Gustavo A. R. Silva wrote: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1470102 ("Missing break in switch") Any other

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/icp: Add Interrupt Support

2018-06-20 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/icp: Add Interrupt Support URL : https://patchwork.freedesktop.org/series/45122/ State : failure == Summary == CALLscripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i9

[Intel-gfx] [PATCH 1/2] drm/i915/icp: Add Interrupt Support

2018-06-20 Thread Anusha Srivatsa
This patch addresses Interrupts from south display engine (SDE). ICP has two registers - SHOTPLUG_CTL_DDI and SHOTPLUG_CTL_TC. Introduce these registers and their intended values. Introduce icp_irq_handler(). v2: - remove redundant register defines.(Lucas) - Change register names to be more cons

[Intel-gfx] [PATCH 2/2] drm/i915/icl: implement icl_digital_port_connected()

2018-06-20 Thread Anusha Srivatsa
From: Paulo Zanoni Do like the other functions and check for the ISR bits. We have plans to add a few more checks in this code in the next patches, that's why it's a little more verbose than it could be. v2: - Change the register names, to be consistent with the rest of the platforms. Cc: Anime

Re: [Intel-gfx] [PATCH] drm/i915: Disable bh around call to tasklet

2018-06-20 Thread Chris Wilson
Quoting Michel Thierry (2018-06-20 21:24:04) > On 6/20/2018 6:59 AM, Chris Wilson wrote: > > The guc submission backends expects to only be run from (at least) > > softirq context, but during our intel_engine_is_idle() check we would > > call into the tasklet to make sure it was flushed. As this co

[Intel-gfx] [PATCH 1/2] drm/i915/icp: Add Interrupt Support

2018-06-20 Thread Anusha Srivatsa
This patch addresses Interrupts from south display engine (SDE). ICP has two registers - SHOTPLUG_CTL_DDI and SHOTPLUG_CTL_TC. Introduce these registers and their intended values. Introduce icp_irq_handler(). v2: - remove redundant register defines.(Lucas) - Change register names to be more cons

[Intel-gfx] [PATCH 2/2] drm/i915/icl: implement icl_digital_port_connected()

2018-06-20 Thread Anusha Srivatsa
From: Paulo Zanoni Do like the other functions and check for the ISR bits. We have plans to add a few more checks in this code in the next patches, that's why it's a little more verbose than it could be. v2: - Change the register names, to be consistent with the rest of the platforms. Cc: Anime

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add Exec param to control data port coherency. (rev4)

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915: Add Exec param to control data port coherency. (rev4) URL : https://patchwork.freedesktop.org/series/40181/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4348_full -> Patchwork_9373_full = == Summary - FAILURE == Serious unknown cha

Re: [Intel-gfx] [PATCH 18/24] drm/i915/icl: implement icl_digital_port_connected()

2018-06-20 Thread Paulo Zanoni
Em Ter, 2018-06-19 às 15:28 -0700, Lucas De Marchi escreveu: > On Mon, May 21, 2018 at 05:25:52PM -0700, Paulo Zanoni wrote: > > Do like the other functions and check for the ISR bits. We have > > plans > > to add a few more checks in this code in the next patches, that's > > why > > it's a little

Re: [Intel-gfx] [PATCH] drm/i915/psr: Fix warning in intel_psr_activate()

2018-06-20 Thread Dhinakaran Pandiyan
On Mon, 2018-06-18 at 15:27 -0700, Rodrigo Vivi wrote: > On Mon, Jun 18, 2018 at 03:02:07PM -0700, Dhinakaran Pandiyan wrote: > > > > commit 5422b37c907e ("drm/i915/psr: Kill delays when activating psr > > back.") removed the call to cancel a scheduled psr_work from > > psr_disable() and instead a

Re: [Intel-gfx] [PATCH] drm/i915: Disable bh around call to tasklet

2018-06-20 Thread Michel Thierry
On 6/20/2018 6:59 AM, Chris Wilson wrote: The guc submission backends expects to only be run from (at least) softirq context, but during our intel_engine_is_idle() check we would call into the tasklet to make sure it was flushed. As this could occur from process context, occasionally we would be

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Disable bh around call to tasklet

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915: Disable bh around call to tasklet URL : https://patchwork.freedesktop.org/series/45089/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4348_full -> Patchwork_9372_full = == Summary - WARNING == Minor unknown changes coming with Patch

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: mark expected switch fall-through

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915: mark expected switch fall-through URL : https://patchwork.freedesktop.org/series/45088/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4348_full -> Patchwork_9371_full = == Summary - WARNING == Minor unknown changes coming with Patch

Re: [Intel-gfx] [PATCH] drm/i915: mark expected switch fall-through

2018-06-20 Thread Rodrigo Vivi
On Wed, Jun 20, 2018 at 08:31:00AM -0500, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Addresses-Coverity-ID: 1470102 ("Missing break in switch") Any other advantage besides coverity? Can't we addre

Re: [Intel-gfx] [PATCH][next] drm/i915/psr: fix copy-paste error with setting of tp2_wakeup_time_us

2018-06-20 Thread Rodrigo Vivi
On Wed, Jun 20, 2018 at 02:25:43PM +0100, Colin King wrote: > From: Colin Ian King > > Currently for the psr_table->tp2_tp3_wakeup_time case 3 there appears > to be a copy-paste error from the previous switch statement where > dev_priv->vbt.psr.tp1_wakeup_time_us is being assigned and I believe >

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: fix copy-paste error with setting of tp2_wakeup_time_us

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915/psr: fix copy-paste error with setting of tp2_wakeup_time_us URL : https://patchwork.freedesktop.org/series/45083/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4348_full -> Patchwork_9370_full = == Summary - WARNING == Minor unknown

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Remove unused dmabuf->kmap routines, fix the build

2018-06-20 Thread Chris Wilson
Quoting Koenig, Christian (2018-06-20 17:28:33) > > > Am 20.06.2018 18:22 schrieb Chris Wilson : > > Fix i915's CI build after the removal of the dmabuf->kmap interface that > left the mock routines intact. > > In file included from drivers/gpu/drm/i915/i915_gem_dmabuf.c:335:0: >

Re: [Intel-gfx] [PATCH 17/24] drm/i915/icl: Add 10-bit support for hdmi

2018-06-20 Thread Ville Syrjälä
On Mon, May 21, 2018 at 05:25:51PM -0700, Paulo Zanoni wrote: > From: "Sripada, Radhakrishna" > > Starting Icelake silicon supports 10-bpc hdmi to support certain > media workloads. Currently hdmi supports 8 and 12 bpc. Plumbed > in support for 10 bit hdmi. > > Cc: James Ausmus > Cc: Jani Nikul

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Remove unused dmabuf->kmap routines, fix the build

2018-06-20 Thread Koenig, Christian
Am 20.06.2018 18:22 schrieb Chris Wilson : Fix i915's CI build after the removal of the dmabuf->kmap interface that left the mock routines intact. In file included from drivers/gpu/drm/i915/i915_gem_dmabuf.c:335:0: drivers/gpu/drm/i915/selftests/mock_dmabuf.c:104:13: error: ‘mock_dmabuf_kunmap_

[Intel-gfx] [PATCH] drm/i915/selftests: Remove unused dmabuf->kmap routines, fix the build

2018-06-20 Thread Chris Wilson
Fix i915's CI build after the removal of the dmabuf->kmap interface that left the mock routines intact. In file included from drivers/gpu/drm/i915/i915_gem_dmabuf.c:335:0: drivers/gpu/drm/i915/selftests/mock_dmabuf.c:104:13: error: ‘mock_dmabuf_kunmap_atomic’ defined but not used [-Werror=unused-

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add Exec param to control data port coherency. (rev4)

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915: Add Exec param to control data port coherency. (rev4) URL : https://patchwork.freedesktop.org/series/40181/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4348 -> Patchwork_9373 = == Summary - WARNING == Minor unknown changes coming

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add Exec param to control data port coherency. (rev4)

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915: Add Exec param to control data port coherency. (rev4) URL : https://patchwork.freedesktop.org/series/40181/ State : warning == Summary == $ dim checkpatch origin/drm-tip 525e6ee946c8 drm/i915: Add IOCTL Param to control data port coherency. -:15: WARNING:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Disable bh around call to tasklet

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915: Disable bh around call to tasklet URL : https://patchwork.freedesktop.org/series/45089/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4348 -> Patchwork_9372 = == Summary - SUCCESS == No regressions found. External URL: https://p

Re: [Intel-gfx] [PATCH v2 00/12] drm: Add generic fbdev emulation

2018-06-20 Thread Noralf Trønnes
Den 20.06.2018 15.52, skrev Noralf Trønnes: Den 20.06.2018 11.34, skrev Daniel Vetter: On Mon, Jun 18, 2018 at 04:17:27PM +0200, Noralf Trønnes wrote: This patchset adds generic fbdev emulation for drivers that supports GEM based dumb buffers which support .gem_prime_vmap and gem_prime_mmap.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: mark expected switch fall-through

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915: mark expected switch fall-through URL : https://patchwork.freedesktop.org/series/45088/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4348 -> Patchwork_9371 = == Summary - SUCCESS == No regressions found. External URL: https://p

[Intel-gfx] [PATCH v1] drm/i915: Add IOCTL Param to control data port coherency.

2018-06-20 Thread Tomasz Lis
The patch adds a parameter to control the data port coherency functionality on a per-context level. When the IOCTL is called, a command to switch data port coherency state is added to the ordered list. All prior requests are executed on old coherency settings, and all exec requests after the IOCTL

[Intel-gfx] [PATCH v1] Second implementation of Data Port Coherency.

2018-06-20 Thread Tomasz Lis
The OCL Team agreed to use IOCTL instead of Exec flag to switch coherency settings. Also: 1. I will follow this patch with IGT test for the new functionality. 2. The OCL Team will publish UMD patch for it. Tomasz Lis (1): drm/i915: Add IOCTL Param to control data port coherency. drivers/gpu/d

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: fix copy-paste error with setting of tp2_wakeup_time_us

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915/psr: fix copy-paste error with setting of tp2_wakeup_time_us URL : https://patchwork.freedesktop.org/series/45083/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4348 -> Patchwork_9370 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] [PATCH] drm/i915: Disable bh around call to tasklet

2018-06-20 Thread Chris Wilson
The guc submission backends expects to only be run from (at least) softirq context, but during our intel_engine_is_idle() check we would call into the tasklet to make sure it was flushed. As this could occur from process context, occasionally we would be caught out using a wait_for_atomic() not fro

[Intel-gfx] [PATCH] drm/i915: mark expected switch fall-through

2018-06-20 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 1470102 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- drivers/gpu/drm/i915/intel_dpll_mgr.c | 1 + 1 file changed, 1 insertion(+) diff --git a

Re: [Intel-gfx] [PATCH v2 00/12] drm: Add generic fbdev emulation

2018-06-20 Thread Noralf Trønnes
Den 20.06.2018 11.34, skrev Daniel Vetter: On Mon, Jun 18, 2018 at 04:17:27PM +0200, Noralf Trønnes wrote: This patchset adds generic fbdev emulation for drivers that supports GEM based dumb buffers which support .gem_prime_vmap and gem_prime_mmap. An API is begun to support in-kernel clients i

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915/icl: Do read-modify-write as needed during MG PLL programming

2018-06-20 Thread Kulkarni, Vandita
> -Original Message- > From: Deak, Imre > Sent: Tuesday, June 19, 2018 10:11 PM > To: intel-gfx@lists.freedesktop.org > Cc: Kulkarni, Vandita ; Zanoni, Paulo R > ; Ausmus, James > Subject: [PATCH v3 2/2] drm/i915/icl: Do read-modify-write as needed > during MG PLL programming > > Some M

[Intel-gfx] [PATCH][next] drm/i915/psr: fix copy-paste error with setting of tp2_wakeup_time_us

2018-06-20 Thread Colin King
From: Colin Ian King Currently for the psr_table->tp2_tp3_wakeup_time case 3 there appears to be a copy-paste error from the previous switch statement where dev_priv->vbt.psr.tp1_wakeup_time_us is being assigned and I believe it should be dev_priv->vbt.psr.tp2_tp3_wakeup_time_us that should be as

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Don't dereference an error pointer (rev3)

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Don't dereference an error pointer (rev3) URL : https://patchwork.freedesktop.org/series/45068/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4346_full -> Patchwork_9369_full = == Summary - WARNING == Minor unknown changes

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib: Spin fast, retire early

2018-06-20 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-06-20 14:57:05) > When using the pollable spinner, we often want to use it as a means of > ensuring the task is running on the GPU before switching to something > else. In which case we don't want to add extra delay inside the spinner, > but the current 1000 NOPs add on o

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Avoid ERR_PTR dereference

2018-06-20 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-06-20 14:24:41) > Along the early error path for igt_switch_to_kernel_context we may try > to dereference an invalid error pointer. Instead, return early rather > than dump the GEM trace since we haven't yet emitted anything of > interest. > > Reported-by: Dan Carpenter

[Intel-gfx] [PATCH i-g-t 1/2] lib: Spin fast, retire early

2018-06-20 Thread Chris Wilson
When using the pollable spinner, we often want to use it as a means of ensuring the task is running on the GPU before switching to something else. In which case we don't want to add extra delay inside the spinner, but the current 1000 NOPs add on order of 5us, which is often larger than the target

Re: [Intel-gfx] [PATCH i-g-t 2/2] igt/gem_sync: Alternate stress for nop+sync

2018-06-20 Thread Chris Wilson
More pebkac. The kettle wasn't working, that's my excuse. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t 2/2] igt/perf_pmu: Fast slow then meander

2018-06-20 Thread Chris Wilson
Signed-off-by: Chris Wilson --- tests/perf_pmu.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/perf_pmu.c b/tests/perf_pmu.c index 4570f926d..a2e20b8fc 100644 --- a/tests/perf_pmu.c +++ b/tests/perf_pmu.c @@ -206,11 +206,15 @@ static unsigned long __spin_wai

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Don't dereference an error pointer (rev3)

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Don't dereference an error pointer (rev3) URL : https://patchwork.freedesktop.org/series/45068/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4346 -> Patchwork_9369 = == Summary - SUCCESS == No regressions found. Extern

[Intel-gfx] [PATCH i-g-t 2/2] igt/gem_sync: Alternate stress for nop+sync

2018-06-20 Thread Chris Wilson
Apply a different sort of stress by timing how long it takes to sync a second nop batch in the pipeline. We first start a spinner on the engine, then when we know the GPU is active, we submit the second nop; start timing as we then release the spinner and wait for the nop to complete. As with ever

[Intel-gfx] [PATCH i-g-t 1/2] lib: Spin fast, retire early

2018-06-20 Thread Chris Wilson
When using the pollable spinner, we often want to use it as a means of ensuring the task is running on the GPU before switching to something else. In which case we don't want to add extra delay inside the spinner, but the current 1000 NOPs add on order of 5us, which is often larger than the target

Re: [Intel-gfx] [PATCH v4 38/41] drm/i915: Implement the HDCP2.2 support for DP

2018-06-20 Thread C, Ramalingam
Best Regards, Ramalingam C > -Original Message- > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of > Daniel Vetter > Sent: Wednesday, June 20, 2018 5:14 PM > To: C, Ramalingam > Cc: intel-gfx ; dri-devel de...@lists.freedesktop.org>; Sean Paul ; Chris > Wilson

[Intel-gfx] [PATCH i-g-t 1/2] igt/gem_tiled_partial_pwrite_pread: Check for known swizzling

2018-06-20 Thread Chris Wilson
As we want to compare a templated tiling pattern against the target_bo, we need to know that the swizzling is compatible. Or else the two tiling pattern may differ due to underlying page address that we cannot know, and so the test may sporadically fail. References: https://bugs.freedesktop.org/sh

[Intel-gfx] [PATCH i-g-t 2/2] igt/gem_set_tiling_vs_pwrite: Show the erroneous value

2018-06-20 Thread Chris Wilson
Signed-off-by: Chris Wilson --- tests/gem_set_tiling_vs_pwrite.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/gem_set_tiling_vs_pwrite.c b/tests/gem_set_tiling_vs_pwrite.c index 006edfe4e..f0126b648 100644 --- a/tests/gem_set_tiling_vs_pwrite.c +++ b/tests/gem_set

Re: [Intel-gfx] [PATCH v4 38/41] drm/i915: Implement the HDCP2.2 support for DP

2018-06-20 Thread Daniel Vetter
On Wed, Jun 20, 2018 at 12:19 PM, Ramalingam C wrote: > > > On Thursday 31 May 2018 12:52 PM, Daniel Vetter wrote: >> >> On Mon, May 21, 2018 at 06:23:57PM +0530, Ramalingam C wrote: >>> >>> Implements the DP adaptation specific HDCP2.2 functions. >>> >>> These functions perform the DPCD read and

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Don't dereference an error pointer

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Don't dereference an error pointer URL : https://patchwork.freedesktop.org/series/45068/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4346 -> Patchwork_9368 = == Summary - FAILURE == Serious unknown changes coming with Pa

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: make the probe asynchronous (rev3)

2018-06-20 Thread Patchwork
== Series Details == Series: i915: make the probe asynchronous (rev3) URL : https://patchwork.freedesktop.org/series/44159/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4346_full -> Patchwork_9367_full = == Summary - WARNING == Minor unknown changes coming with Patchwor

Re: [Intel-gfx] [PATCH] ctx-sync

2018-06-20 Thread Chris Wilson
As fascinating as this patch is, this isn't the one I meant to send. Oops, -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915/selftests: Avoid ERR_PTR dereference

2018-06-20 Thread Chris Wilson
Along the early error path for igt_switch_to_kernel_context we may try to dereference an invalid error pointer. Instead, return early rather than dump the GEM trace since we haven't yet emitted anything of interest. Reported-by: Dan Carpenter Fixes: 09a4c02e58c1 ("drm/i915: Look for an active ker

[Intel-gfx] [PATCH] ctx-sync

2018-06-20 Thread Chris Wilson
--- drivers/gpu/drm/i915/intel_lrc.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i915/intel_lrc.c index dc556595a845..2c310754e1f9 100644 --- a/drivers/gpu/drm/i915/intel_lrc.c +++ b/drivers/gpu/drm/i915/intel_lrc.c @@

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Jani Nikula
On Wed, 20 Jun 2018, Feng Tang wrote: > On Wed, Jun 20, 2018 at 10:11:34AM +0300, Jani Nikula wrote: >> I suggested you do that within hdac_i915.c. Wait in snd_hdac_i915_init() >> below request_module(), complete in hdac_component_master_bind(). > > Sorry, I'm not familiar with the i915 HDAC detai

[Intel-gfx] [PATCH] drm/i915/selftests: Don't dereference an error pointer

2018-06-20 Thread Dan Carpenter
There is an error path where "ctx" is an error pointer so we can't pass it to kernel_context_close(). Fixes: 09a4c02e58c1 ("drm/i915: Look for an active kernel context before switching") Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_context.c b/drivers/gpu/d

Re: [Intel-gfx] [PATCH v4 38/41] drm/i915: Implement the HDCP2.2 support for DP

2018-06-20 Thread Ramalingam C
On Thursday 31 May 2018 12:52 PM, Daniel Vetter wrote: On Mon, May 21, 2018 at 06:23:57PM +0530, Ramalingam C wrote: Implements the DP adaptation specific HDCP2.2 functions. These functions perform the DPCD read and write for communicating the HDCP2.2 auth message back and forth. Note: Chris

Re: [Intel-gfx] [PATCH v4 39/41] drm/i915: Implement the HDCP2.2 support for HDMI

2018-06-20 Thread Ramalingam C
On Thursday 31 May 2018 12:54 PM, Daniel Vetter wrote: On Mon, May 21, 2018 at 06:23:58PM +0530, Ramalingam C wrote: Implements the HDMI adaptation specific HDCP2.2 operations. Basically these are DDC read and write for authenticating through HDCP2.2 messages. v2: Rebased. v3: No Chang

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: make the probe asynchronous (rev3)

2018-06-20 Thread Patchwork
== Series Details == Series: i915: make the probe asynchronous (rev3) URL : https://patchwork.freedesktop.org/series/44159/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4346 -> Patchwork_9367 = == Summary - SUCCESS == No regressions found. External URL: https://patc

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dp: try normal detection on connector force enable (rev2)

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915/dp: try normal detection on connector force enable (rev2) URL : https://patchwork.freedesktop.org/series/45056/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4346_full -> Patchwork_9366_full = == Summary - WARNING == Minor unknown ch

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for i915: make the probe asynchronous (rev3)

2018-06-20 Thread Patchwork
== Series Details == Series: i915: make the probe asynchronous (rev3) URL : https://patchwork.freedesktop.org/series/44159/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5792ad56bb06 i915: make the probe asynchronous -:21: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Takashi Iwai
On Wed, 20 Jun 2018 10:02:42 +0200, Daniel Vetter wrote: > > On Wed, Jun 20, 2018 at 10:11:34AM +0300, Jani Nikula wrote: > > On Wed, 20 Jun 2018, Feng Tang wrote: > > > Hi Takashi, > > > > > > On Wed, Jun 20, 2018 at 08:35:05AM +0200, Takashi Iwai wrote: > > >> On Wed, 20 Jun 2018 08:25:23 +020

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Feng Tang
Hi Jani, On Wed, Jun 20, 2018 at 10:11:34AM +0300, Jani Nikula wrote: > On Wed, 20 Jun 2018, Feng Tang wrote: > > Hi Takashi, > > > > On Wed, Jun 20, 2018 at 08:35:05AM +0200, Takashi Iwai wrote: > >> On Wed, 20 Jun 2018 08:25:23 +0200, > >> Feng Tang wrote: > >> > > >> > Hi Jani/Chris/Takashi,

Re: [Intel-gfx] [PATCH v2 00/12] drm: Add generic fbdev emulation

2018-06-20 Thread Daniel Vetter
On Mon, Jun 18, 2018 at 04:17:27PM +0200, Noralf Trønnes wrote: > This patchset adds generic fbdev emulation for drivers that supports GEM > based dumb buffers which support .gem_prime_vmap and gem_prime_mmap. An > API is begun to support in-kernel clients in general. > > Notable changes since ver

Re: [Intel-gfx] [PATCH v2 09/12] drm/debugfs: Add internal client debugfs file

2018-06-20 Thread Daniel Vetter
On Mon, Jun 18, 2018 at 04:17:36PM +0200, Noralf Trønnes wrote: > Print the names of the internal clients currently attached. > > Signed-off-by: Noralf Trønnes Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/drm_client.c | 28 > drivers/gpu/drm/drm_debugfs.c |

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: try normal detection on connector force enable (rev2)

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915/dp: try normal detection on connector force enable (rev2) URL : https://patchwork.freedesktop.org/series/45056/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4346 -> Patchwork_9366 = == Summary - SUCCESS == No regressions found. E

Re: [Intel-gfx] [PATCH v2 05/14] drm/sti: Try to fix up the tvout possible clones

2018-06-20 Thread Benjamin Gaignard
2018-06-18 14:38 GMT+02:00 Ville Syrjala : > From: Ville Syrjälä > > The current possible_clones setup doesn't look sensible. I'm assuming > the 0 and 1 are supposed to refer to the indexes of the hdmi and hda > encoders? So it kinda looks like we want hda+hdmi cloning, but then > dvo also claims

[Intel-gfx] [RFC PATCH v2] drm/i915/dp: try normal detection on connector force enable

2018-06-20 Thread Jani Nikula
Connector force enable on DP bypasses the detect hooks, skipping all the DPCD parameter reading and negotiation. This does not really have a chance to work, at all, and any modesets are bound to fail. Try to do the normal detection in the force hook on force enable. v2: fix unused variable warnin

[Intel-gfx] [PATCH i-g-t] lib: Spin fast, retire early

2018-06-20 Thread Chris Wilson
When using the pollable spinner, we often want to use it as a means of ensuring the task is running on the GPU before switching to something else. In which case we don't want to add extra delay inside the spinner, but the current 1000 NOPs add on order of 5us, which is often larger than the target

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: try normal detection on connector force enable

2018-06-20 Thread Patchwork
== Series Details == Series: drm/i915/dp: try normal detection on connector force enable URL : https://patchwork.freedesktop.org/series/45056/ State : failure == Summary == CALLscripts/checksyscalls.sh DESCEND objtool CHK include/generated/compile.h CC [M] drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH 02/20] drm/i915/icl: Program DSI Escape clock Divider

2018-06-20 Thread Chauhan, Madhav
> -Original Message- > From: Zanoni, Paulo R > Sent: Friday, June 15, 2018 11:41 PM > To: Chauhan, Madhav ; intel- > g...@lists.freedesktop.org > Cc: Nikula, Jani ; Shankar, Uma > ; Vivi, Rodrigo > Subject: Re: [PATCH 02/20] drm/i915/icl: Program DSI Escape clock Divider > > Em Sex, 2018-

[Intel-gfx] [RFC PATCH] drm/i915/dp: try normal detection on connector force enable

2018-06-20 Thread Jani Nikula
Connector force enable on DP bypasses the detect hooks, skipping all the DPCD parameter reading and negotiation. This does not really have a chance to work, at all, and any modesets are bound to fail. Try to do the normal detection in the force hook on force enable. Bugzilla: https://bugs.freedes

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Daniel Vetter
On Wed, Jun 20, 2018 at 10:11:34AM +0300, Jani Nikula wrote: > On Wed, 20 Jun 2018, Feng Tang wrote: > > Hi Takashi, > > > > On Wed, Jun 20, 2018 at 08:35:05AM +0200, Takashi Iwai wrote: > >> On Wed, 20 Jun 2018 08:25:23 +0200, > >> Feng Tang wrote: > >> > > >> > Hi Jani/Chris/Takashi, > >> >

Re: [Intel-gfx] [RFC] i915: make the probe asynchronous

2018-06-20 Thread Jani Nikula
On Wed, 20 Jun 2018, Feng Tang wrote: > Hi Takashi, > > On Wed, Jun 20, 2018 at 08:35:05AM +0200, Takashi Iwai wrote: >> On Wed, 20 Jun 2018 08:25:23 +0200, >> Feng Tang wrote: >> > >> > Hi Jani/Chris/Takashi, >> > >> > On Wed, Jun 06, 2018 at 11:21:43AM +0300, Jani Nikula wrote: >> > > >> >>