Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Drop preemption arbitrations points along the ring

2018-05-03 Thread Chris Wilson
Quoting Patchwork (2018-05-04 01:31:49) > == Series Details == > > Series: drm/i915/execlists: Drop preemption arbitrations points along the ring > URL : https://patchwork.freedesktop.org/series/42660/ > State : success > > == Summary == > > = CI Bug Log - changes from CI_DRM_4135_full -> Patc

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gtt: Tidy up duplicate branches in gen8_gmch_probe() (rev2)

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Tidy up duplicate branches in gen8_gmch_probe() (rev2) URL : https://patchwork.freedesktop.org/series/42662/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4135_full -> Patchwork_8904_full = == Summary - WARNING == Minor unknown

Re: [Intel-gfx] [PULL] drm-intel-next

2018-05-03 Thread Dave Airlie
On 4 May 2018 at 10:29, Dave Airlie wrote: > On 4 May 2018 at 10:19, Dave Airlie wrote: >> On 2 May 2018 at 17:03, Jani Nikula wrote: >>> >>> Hi Dave - >>> >>> drm-intel-next-2018-04-13: >>> First drm/i915 feature batch heading for v4.18: >>> >>> - drm-next backmerge to fix build (Rodrigo) >>> -

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Drop preemption arbitrations points along the ring

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Drop preemption arbitrations points along the ring URL : https://patchwork.freedesktop.org/series/42660/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4135_full -> Patchwork_8903_full = == Summary - WARNING == Minor unknow

Re: [Intel-gfx] [PULL] drm-intel-next

2018-05-03 Thread Dave Airlie
On 4 May 2018 at 10:19, Dave Airlie wrote: > On 2 May 2018 at 17:03, Jani Nikula wrote: >> >> Hi Dave - >> >> drm-intel-next-2018-04-13: >> First drm/i915 feature batch heading for v4.18: >> >> - drm-next backmerge to fix build (Rodrigo) >> - GPU documentation improvements (Kevin) >> - GuC and Hu

Re: [Intel-gfx] [PULL] drm-intel-next

2018-05-03 Thread Dave Airlie
On 2 May 2018 at 17:03, Jani Nikula wrote: > > Hi Dave - > > drm-intel-next-2018-04-13: > First drm/i915 feature batch heading for v4.18: > > - drm-next backmerge to fix build (Rodrigo) > - GPU documentation improvements (Kevin) > - GuC and HuC refactoring, host/GuC communication, logging, fixes,

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/2] drm/i915: Lazily unbind vma on close

2018-05-03 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Lazily unbind vma on close URL : https://patchwork.freedesktop.org/series/42659/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4135_full -> Patchwork_8902_full = == Summary - FAILURE == Serious unknown

[Intel-gfx] ✓ Fi.CI.IGT: success for i915: Convert to use match_string() helper

2018-05-03 Thread Patchwork
== Series Details == Series: i915: Convert to use match_string() helper URL : https://patchwork.freedesktop.org/series/42654/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4134_full -> Patchwork_8901_full = == Summary - WARNING == Minor unknown changes coming with Patchw

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: silence a static checker warning

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915/dp: silence a static checker warning URL : https://patchwork.freedesktop.org/series/42630/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4134_full -> Patchwork_8900_full = == Summary - FAILURE == Serious unknown changes coming with P

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: Tidy up duplicate branches in gen8_gmch_probe() (rev2)

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Tidy up duplicate branches in gen8_gmch_probe() (rev2) URL : https://patchwork.freedesktop.org/series/42662/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4135 -> Patchwork_8904 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: Tidy up duplicate branches in gen8_gmch_probe() (rev2)

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Tidy up duplicate branches in gen8_gmch_probe() (rev2) URL : https://patchwork.freedesktop.org/series/42662/ State : warning == Summary == $ dim checkpatch origin/drm-tip 37171cccb14b drm/i915/gtt: Tidy up duplicate branches in gen8_gmch_probe() -:14:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: fix spelling mistake: "parmaters" -> "parameters"

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix spelling mistake: "parmaters" -> "parameters" URL : https://patchwork.freedesktop.org/series/42647/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4134_full -> Patchwork_8899_full = == Summary - SUCCESS == No regression

[Intel-gfx] [PATCH] drm/i915/gtt: Tidy up duplicate branches in gen8_gmch_probe()

2018-05-03 Thread Chris Wilson
Following commit f773568b6ff8 ("drm/i915: nuke the duplicated stolen discovery"), the if-else-chain for determining the GTT size is redundant with the !chv branches all being the same. Reported-by: Ville Syrjälä References: f773568b6ff8 ("drm/i915: nuke the duplicated stolen discovery") Signed-of

[Intel-gfx] [PATCH] drm/i915/gtt: Tidy up duplicate branches in gen8_gmch_probe()

2018-05-03 Thread Chris Wilson
Following commit f773568b6ff8 ("drm/i915: nuke the duplicated stolen discovery"), the if-else-chain for determining the GTT size is redundant with the !chv branches all being the same. Reported-by: Ville Syrjälä References: f773568b6ff8 ("drm/i915: nuke the duplicated stolen discovery") Signed-of

[Intel-gfx] ✓ Fi.CI.IGT: success for dma-fence cleanup v2

2018-05-03 Thread Patchwork
== Series Details == Series: dma-fence cleanup v2 URL : https://patchwork.freedesktop.org/series/42640/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4134_full -> Patchwork_8898_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_8898_full need to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Drop preemption arbitrations points along the ring

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Drop preemption arbitrations points along the ring URL : https://patchwork.freedesktop.org/series/42660/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4135 -> Patchwork_8903 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915: Lazily unbind vma on close

2018-05-03 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Lazily unbind vma on close URL : https://patchwork.freedesktop.org/series/42659/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4135 -> Patchwork_8902 = == Summary - SUCCESS == No regressions found. E

Re: [Intel-gfx] [PATCH 1/8] drm/i915: expose helper mapping exec flag engine to intel_engine_cs

2018-05-03 Thread Chris Wilson
Quoting Lionel Landwerlin (2018-05-03 21:09:01) > On 03/05/18 19:00, Tvrtko Ursulin wrote: > >> One other thing I've been wondering is whether we should strictly > >> validate the input from userspace. > >> Right now we min/max the numbers and never raise any error. > > > > It does feel low level

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Drop preemption arbitrations points along the ring

2018-05-03 Thread Lionel Landwerlin
On 03/05/18 20:54, Chris Wilson wrote: Limit the arbitration (where preemption may occur) to inside the batch, and prevent it from happening on the pipecontrols/flushes we use to write the breadcrumb seqno. Once the user batch is complete, we have nothing left to do but serialise and emit the bre

Re: [Intel-gfx] [PATCH 1/8] drm/i915: expose helper mapping exec flag engine to intel_engine_cs

2018-05-03 Thread Lionel Landwerlin
On 03/05/18 19:00, Tvrtko Ursulin wrote: On 03/05/2018 18:31, Lionel Landwerlin wrote: On 03/05/18 18:12, Tvrtko Ursulin wrote: On 30/04/2018 15:37, Lionel Landwerlin wrote: On 25/04/18 12:50, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-04-25 12:45:14) This function will be used la

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] drm/i915: Lazily unbind vma on close

2018-05-03 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Lazily unbind vma on close URL : https://patchwork.freedesktop.org/series/42659/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Lazily unbind vma on close -drivers/gpu/drm/i915/selftests/../i915_d

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Drop preemption arbitrations points along the ring

2018-05-03 Thread Michel Thierry
On 5/3/2018 12:54 PM, Chris Wilson wrote: Limit the arbitration (where preemption may occur) to inside the batch, and prevent it from happening on the pipecontrols/flushes we use to write the breadcrumb seqno. Once the user batch is complete, we have nothing left to do but serialise and emit the

[Intel-gfx] [PATCH] drm/i915/execlists: Drop preemption arbitrations points along the ring

2018-05-03 Thread Chris Wilson
Limit the arbitration (where preemption may occur) to inside the batch, and prevent it from happening on the pipecontrols/flushes we use to write the breadcrumb seqno. Once the user batch is complete, we have nothing left to do but serialise and emit the breadcrumb; switching contexts at this point

[Intel-gfx] [CI 2/2] drm/i915: Keep one request in our ring_list

2018-05-03 Thread Chris Wilson
Don't pre-emptively retire the oldest request in our ring's list if it is the only request. We keep various bits of state alive using the active reference from the request and would rather transfer that state over to a new request rather than the more involved process of retiring and reacquiring it

[Intel-gfx] [CI 1/2] drm/i915: Lazily unbind vma on close

2018-05-03 Thread Chris Wilson
When userspace is passing around swapbuffers using DRI, we frequently have to open and close the same object in the foreign address space. This shows itself as the same object being rebound at roughly 30fps (with a second object also being rebound at 30fps), which involves us having to rewrite the

Re: [Intel-gfx] [PATCH 05/71] drm/i915/execlists: Disable submission tasklets when rescheduling

2018-05-03 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-03 18:49:27) > > On 03/05/2018 07:36, Chris Wilson wrote: > > As we reschedule the requests, we do not want the submission tasklet > > running until we finish updating the priority chains. (We start > > rewriting priorities from the oldest, but the dequeue looks at

[Intel-gfx] ✓ Fi.CI.BAT: success for i915: Convert to use match_string() helper

2018-05-03 Thread Patchwork
== Series Details == Series: i915: Convert to use match_string() helper URL : https://patchwork.freedesktop.org/series/42654/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4134 -> Patchwork_8901 = == Summary - SUCCESS == No regressions found. External URL: https://pa

[Intel-gfx] [PATCH v1] i915: Convert to use match_string() helper

2018-05-03 Thread Andy Shevchenko
The new helper returns index of the matching string in an array. We are going to use it here. Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/intel_pipe_crc.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pipe_crc.

Re: [Intel-gfx] [PATCH 1/8] drm/i915: expose helper mapping exec flag engine to intel_engine_cs

2018-05-03 Thread Tvrtko Ursulin
On 03/05/2018 18:31, Lionel Landwerlin wrote: On 03/05/18 18:12, Tvrtko Ursulin wrote: On 30/04/2018 15:37, Lionel Landwerlin wrote: On 25/04/18 12:50, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-04-25 12:45:14) This function will be used later by the per (context,engine) power prog

Re: [Intel-gfx] [PATCH 05/71] drm/i915/execlists: Disable submission tasklets when rescheduling

2018-05-03 Thread Tvrtko Ursulin
On 03/05/2018 07:36, Chris Wilson wrote: As we reschedule the requests, we do not want the submission tasklet running until we finish updating the priority chains. (We start rewriting priorities from the oldest, but the dequeue looks at the most recent in-flight, so there is a small race conditi

Re: [Intel-gfx] [PATCH 1/8] drm/i915: expose helper mapping exec flag engine to intel_engine_cs

2018-05-03 Thread Lionel Landwerlin
On 03/05/18 18:12, Tvrtko Ursulin wrote: On 30/04/2018 15:37, Lionel Landwerlin wrote: On 25/04/18 12:50, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-04-25 12:45:14) This function will be used later by the per (context,engine) power programming interface. No. This is not the appropri

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: silence a static checker warning

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915/dp: silence a static checker warning URL : https://patchwork.freedesktop.org/series/42630/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4134 -> Patchwork_8900 = == Summary - SUCCESS == No regressions found. External URL: https:/

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-05-03 Thread Tvrtko Ursulin
On 25/04/2018 12:45, Lionel Landwerlin wrote: From: Chris Wilson We want to allow userspace to reconfigure the subslice configuration for its own use case. To do so, we expose a context parameter to allow adjustment of the RPCS register stored within the context image (and currently not access

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: vbt change for psr (rev6)

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915/psr: vbt change for psr (rev6) URL : https://patchwork.freedesktop.org/series/41289/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4131_full -> Patchwork_8897_full = == Summary - SUCCESS == No regressions found. External URL: htt

Re: [Intel-gfx] [PATCH] drm/i915: Wait for PSR exit before checking for vblank evasion for an atomic update

2018-05-03 Thread Tarun Vyas
On Thu, May 03, 2018 at 09:58:56AM -0700, Rodrigo Vivi wrote: > On Wed, May 02, 2018 at 03:31:15PM -0700, Tarun Vyas wrote: > > On Wed, May 02, 2018 at 01:04:06PM -0700, Vivi, Rodrigo wrote: > > > On Wed, May 02, 2018 at 09:51:43PM +0300, Ville Syrjälä wrote: > > > > On Wed, May 02, 2018 at 11:19:1

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-03 Thread Nagaraju, Vathsala
Rodrigo, The changes are already in place on kabylake 209+ onwards, So limiting this change to only kabylake and confirmed vbt version for now. RCR is already raised for GOP team to resolve. Once we get the other platform confirmation, we can add those platforms too. Here is

Re: [Intel-gfx] [PATCH 1/8] drm/i915: expose helper mapping exec flag engine to intel_engine_cs

2018-05-03 Thread Tvrtko Ursulin
On 30/04/2018 15:37, Lionel Landwerlin wrote: On 25/04/18 12:50, Chris Wilson wrote: Quoting Lionel Landwerlin (2018-04-25 12:45:14) This function will be used later by the per (context,engine) power programming interface. No. This is not the appropriate uABI, please see intel_engine_lookup_u

Re: [Intel-gfx] [PATCH 04/71] drm/i915: Keep one request in our ring_list

2018-05-03 Thread Tvrtko Ursulin
On 03/05/2018 07:36, Chris Wilson wrote: Don't pre-emptively retire the oldest request in our ring's list if it is the only request. We keep various bits of state alive using the active reference from the request and would rather transfer that state over to a new request rather than the more inv

Re: [Intel-gfx] [PATCH 03/71] drm/i915: Lazily unbind vma on close

2018-05-03 Thread Tvrtko Ursulin
On 03/05/2018 07:36, Chris Wilson wrote: When userspace is passing around swapbuffers using DRI, we frequently have to open and close the same object in the foreign address space. This shows itself as the same object being rebound at roughly 30fps (with a second object also being rebound at 30fp

Re: [Intel-gfx] [PATCH] drm/i915: Wait for PSR exit before checking for vblank evasion for an atomic update

2018-05-03 Thread Rodrigo Vivi
On Wed, May 02, 2018 at 03:31:15PM -0700, Tarun Vyas wrote: > On Wed, May 02, 2018 at 01:04:06PM -0700, Vivi, Rodrigo wrote: > > On Wed, May 02, 2018 at 09:51:43PM +0300, Ville Syrjälä wrote: > > > On Wed, May 02, 2018 at 11:19:14AM -0700, Tarun Vyas wrote: > > > > On Mon, Apr 30, 2018 at 10:19:33A

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm: Fix rounding errors and use scaling in i915, v2.

2018-05-03 Thread Patchwork
== Series Details == Series: drm: Fix rounding errors and use scaling in i915, v2. URL : https://patchwork.freedesktop.org/series/42631/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4131_full -> Patchwork_8896_full = == Summary - FAILURE == Serious unknown changes comin

Re: [Intel-gfx] [PATCH rdma-next 01/21] drm/i915: Move u64-to-ptr helpers to general header

2018-05-03 Thread Joonas Lahtinen
Quoting Leon Romanovsky (2018-05-03 16:36:55) > From: Leon Romanovsky > > The macro u64_to_ptr() and function ptr_to_u64() are useful enough > to be part of general header, so move them there and allow RDMA > subsystem reuse them. > > Signed-off-by: Leon Romanovsky Feel free to merge this thro

Re: [Intel-gfx] [PATCH] drm/i915/dp: silence a static checker warning

2018-05-03 Thread Rodrigo Vivi
On Thu, May 03, 2018 at 01:53:22PM +0300, Dan Carpenter wrote: > Smatch warns that "n_entries" isn't always set. It would trigger a > some WARN_ON()s on that path so presumably it can't happen but it's > simple enough to initialize it to zero just to silence the warning. I usually would just ask

Re: [Intel-gfx] [PATCH 01/71] drm/i915/execlists: Drop preemption arbitrations points along the ring

2018-05-03 Thread Tvrtko Ursulin
On 03/05/2018 07:36, Chris Wilson wrote: Limit the arbitration (where preemption may occur) to inside the batch, and prevent it from happening on the pipecontrols/flushes we use to write the breadcrumb seqno. Once the user batch is complete, we have nothing left to do but serialise and emit the

Re: [Intel-gfx] [PATCH] drm/i915: Micro-optimise i915_request_retire()

2018-05-03 Thread Tvrtko Ursulin
On 03/05/2018 15:06, Chris Wilson wrote: Quoting Joonas Lahtinen (2018-05-03 14:59:35) Quoting Chris Wilson (2018-05-02 20:21:42) I caught the compiler emitting the if(!NULL) guard at the start of dma_fence_put(); on the request it should know for certain is already non-NULL. Mark up the funct

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-05-03 Thread Tvrtko Ursulin
On 03/05/2018 17:04, Joonas Lahtinen wrote: Quoting Lionel Landwerlin (2018-04-26 13:22:30) On 26/04/18 11:00, Joonas Lahtinen wrote: Quoting Lionel Landwerlin (2018-04-25 14:45:21) From: Chris Wilson We want to allow userspace to reconfigure the subslice configuration for its own use case.

Re: [Intel-gfx] [PATCH] drm/i915/icl, x86/gpu: implement ICL stolen memory support

2018-05-03 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-05-03 18:35:48) > Quoting Paulo Zanoni (2018-05-03 16:24:47) > > Em Qui, 2018-05-03 às 12:59 +0300, Joonas Lahtinen escreveu: > > > Please split the patch here and add a respective Fixes: tag to when > > > base Icelake support was introduced. Lacking this portion when > >

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-05-03 Thread Lionel Landwerlin
On 03/05/18 17:04, Joonas Lahtinen wrote: Quoting Lionel Landwerlin (2018-04-26 13:22:30) On 26/04/18 11:00, Joonas Lahtinen wrote: Quoting Lionel Landwerlin (2018-04-25 14:45:21) From: Chris Wilson We want to allow userspace to reconfigure the subslice configuration for its own use case. To

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: fix spelling mistake: "parmaters" -> "parameters"

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915/selftests: fix spelling mistake: "parmaters" -> "parameters" URL : https://patchwork.freedesktop.org/series/42647/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4134 -> Patchwork_8899 = == Summary - WARNING == Minor unknown changes c

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-05-03 Thread Chris Wilson
Quoting Joonas Lahtinen (2018-05-03 17:04:31) > More advanced tactics would include scheduling work so that we try to > avoid the slice count changes and deduct the switching time from the > execution budget of the app requesting less slices (if we had fair > time slicing). Have you been peeking a

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/dp: silence a static checker warning

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915/dp: silence a static checker warning URL : https://patchwork.freedesktop.org/series/42630/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4131_full -> Patchwork_8894_full = == Summary - FAILURE == Serious unknown changes coming with P

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-05-03 Thread Joonas Lahtinen
Quoting Lionel Landwerlin (2018-04-26 13:22:30) > On 26/04/18 11:00, Joonas Lahtinen wrote: > > Quoting Lionel Landwerlin (2018-04-25 14:45:21) > >> From: Chris Wilson > >> > >> We want to allow userspace to reconfigure the subslice configuration for > >> its own use case. To do so, we expose a co

[Intel-gfx] ✓ Fi.CI.BAT: success for dma-fence cleanup v2

2018-05-03 Thread Patchwork
== Series Details == Series: dma-fence cleanup v2 URL : https://patchwork.freedesktop.org/series/42640/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4134 -> Patchwork_8898 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedesktop.or

Re: [Intel-gfx] [PATCH 02/15] dma-fence: Make ->enable_signaling optional

2018-05-03 Thread Chris Wilson
Quoting Daniel Vetter (2018-05-03 15:25:50) > @@ -560,7 +567,7 @@ dma_fence_init(struct dma_fence *fence, const struct > dma_fence_ops *ops, >spinlock_t *lock, u64 context, unsigned seqno) > { > BUG_ON(!lock); > - BUG_ON(!ops || !ops->wait || !ops->enable_signaling |

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dma-fence cleanup v2

2018-05-03 Thread Patchwork
== Series Details == Series: dma-fence cleanup v2 URL : https://patchwork.freedesktop.org/series/42640/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0506ef5446b8 dma-fence: remove fill_driver_data callback 79de0bebf6c8 dma-fence: Make ->enable_signaling optional -:43: WARNING:

Re: [Intel-gfx] [PATCH] drm/i915/selftests: fix spelling mistake: "parmaters" -> "parameters"

2018-05-03 Thread Chris Wilson
Quoting Colin King (2018-05-03 16:45:10) > From: Colin Ian King > > Trivial fix to spelling mistake in pr_err error message > > Signed-off-by: Colin Ian King Reviewed-by: Chris Wilson -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

[Intel-gfx] [PATCH] drm/i915/selftests: fix spelling mistake: "parmaters" -> "parameters"

2018-05-03 Thread Colin King
From: Colin Ian King Trivial fix to spelling mistake in pr_err error message Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/selftests/i915_vma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/selftests/i915_vma.c b/drivers/gpu/drm/i915/selftes

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-03 Thread Rodrigo Vivi
On Thu, May 03, 2018 at 05:06:09PM +0530, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does not mention from which VBT ver

Re: [Intel-gfx] [PATCH] drm/i915/icl, x86/gpu: implement ICL stolen memory support

2018-05-03 Thread Chris Wilson
Quoting Paulo Zanoni (2018-05-03 16:24:47) > Em Qui, 2018-05-03 às 12:59 +0300, Joonas Lahtinen escreveu: > > Please split the patch here and add a respective Fixes: tag to when > > base Icelake support was introduced. Lacking this portion when > > running ICL will > > cause random memory corruptio

Re: [Intel-gfx] [PATCH] drm/i915/icl, x86/gpu: implement ICL stolen memory support

2018-05-03 Thread Paulo Zanoni
Em Qui, 2018-05-03 às 12:59 +0300, Joonas Lahtinen escreveu: > Quoting Paulo Zanoni (2018-05-03 03:23:52) > > ICL changes the registers and addresses to 64 bits. > > > > I also briefly looked at implementing an u64 version of the PCI > > config > > read functions, but I concluded this wouldn't be

Re: [Intel-gfx] [PATCH] drm/i915: Correctly populate user mode h/vdisplay with pipe src size during readout

2018-05-03 Thread Ville Syrjälä
On Thu, May 03, 2018 at 09:50:09AM +0300, Jani Nikula wrote: > On Wed, 02 May 2018, Chris Wilson wrote: > > Quoting Ville Syrjälä (2018-05-02 17:14:21) > >> On Wed, May 02, 2018 at 04:57:09PM +0100, Chris Wilson wrote: > >> > Quoting Ville Syrjälä (2018-05-02 16:52:41) > >> > > On Wed, May 02, 201

Re: [Intel-gfx] [PATCH v2] drm/i915: Remove redundant check for negative timeout while doing an atomic pipe update

2018-05-03 Thread Ville Syrjälä
On Wed, May 02, 2018 at 04:33:00PM -0700, Tarun Vyas wrote: > From: Tarun > > No functional changes, just a minor knit. Stumbled across the kernel doc for > schedule_timeout() which quotes "In all cases the return value is guaranteed > to be non-negative". Also, the return code of schedule_timeou

Re: [Intel-gfx] [PATCH] drm/atomic: Clean old_state/new_state in drm_atomic_state_default_clear()

2018-05-03 Thread Ville Syrjälä
On Thu, May 03, 2018 at 01:41:52PM +0300, Ville Syrjälä wrote: > On Thu, May 03, 2018 at 08:35:30AM +0200, Daniel Vetter wrote: > > On Wed, May 02, 2018 at 09:32:47PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Clear the old_state and new_state pointers for every object in >

[Intel-gfx] [PATCH 15/15] dma-fence: Polish kernel-doc for dma-fence.c

2018-05-03 Thread Daniel Vetter
- Intro section that links to how this is exposed to userspace. - Lots more hyperlinks. - Minor clarifications and style polish Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: Gustavo Padovan Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org --- Documentation/driver-api/dma-

[Intel-gfx] [PATCH 13/15] drm/vgem: Remove unecessary dma_fence_ops

2018-05-03 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Also remove the ->signaled callback, vgem can't peek ahead with a fastpath, returning false is the default implementation. Signed-off-by: Daniel Vetter Cc: Kees Cook Cc: Cihangir Akturk Cc: Sean Pa

[Intel-gfx] [PATCH 14/15] drm/virtio: Remove unecessary dma_fence_ops

2018-05-03 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Reviewed-by: Eric Anholt Signed-off-by: Daniel Vetter Cc: David Airlie Cc: Gerd Hoffmann Cc: virtualizat...@lists.linux-foundation.org --- drivers/gpu/drm/virtio/virtgpu_fence.c | 7 --- 1 fil

[Intel-gfx] [PATCH 08/15] drm/i915: Remove unecessary dma_fence_ops

2018-05-03 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Signed-off-by: Daniel Vetter Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Chris Wilson Cc: Tvrtko Ursulin Cc: Colin Ian King Cc: Daniel Vetter Cc: Mika Kuoppala Cc: intel-gfx@lists

[Intel-gfx] [PATCH 12/15] drm/vc4: Remove unecessary dma_fence_ops

2018-05-03 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Reviewed-by: Eric Anholt Signed-off-by: Daniel Vetter Cc: Eric Anholt --- drivers/gpu/drm/vc4/vc4_fence.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_fence.c b

[Intel-gfx] [PATCH 10/15] drm/nouveau: Remove unecessary dma_fence_ops

2018-05-03 Thread Daniel Vetter
dma_fence_default_wait is the default now. Signed-off-by: Daniel Vetter Cc: Ben Skeggs Cc: nouv...@lists.freedesktop.org --- drivers/gpu/drm/nouveau/nouveau_fence.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fenc

[Intel-gfx] [PATCH 11/15] drm/qxl: Remove unecessary dma_fence_ops

2018-05-03 Thread Daniel Vetter
The trivial enable_signaling implementation matches the default code. v2: Fix up commit message to match patch better (Eric). Cc: Eric Anholt Reviewed-by: Eric Anholt Signed-off-by: Daniel Vetter Cc: Dave Airlie Cc: Gerd Hoffmann Cc: virtualizat...@lists.linux-foundation.org --- drivers/gpu

[Intel-gfx] [PATCH 09/15] drm/msm: Remove unecessary dma_fence_ops

2018-05-03 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Signed-off-by: Daniel Vetter Cc: Rob Clark Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org --- drivers/gpu/drm/msm/msm_fence.c | 7 --- 1 file changed, 7 deletions(-) diff

[Intel-gfx] [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-03 Thread Daniel Vetter
Almost everyone uses dma_fence_default_wait. v2: Also remove the BUG_ON(!ops->wait) (Chris). Reviewed-by: Christian König (v1) Signed-off-by: Daniel Vetter Cc: Chris Wilson Cc: Sumit Semwal Cc: Gustavo Padovan Cc: linux-me...@vger.kernel.org Cc: linaro-mm-...@lists.linaro.org --- drivers/dm

[Intel-gfx] [PATCH 06/15] drm: Remove unecessary dma_fence_ops

2018-05-03 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Reviewed-by: Eric Anholt Signed-off-by: Daniel Vetter Cc: Gustavo Padovan Cc: Maarten Lankhorst Cc: Sean Paul Cc: David Airlie --- drivers/gpu/drm/drm_crtc.c | 7 --- drivers/g

[Intel-gfx] [PATCH 05/15] drm/amdgpu: Remove unecessary dma_fence_ops

2018-05-03 Thread Daniel Vetter
dma_fence_default_wait is the default now. Reviewed-by: Christian König Signed-off-by: Daniel Vetter Cc: Alex Deucher Cc: "Christian König" Cc: Monk Liu Cc: pding Cc: Andrey Grodzovsky Cc: Evan Quan Cc: Daniel Vetter Cc: Kees Cook --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_fence.c | 2

[Intel-gfx] [PATCH 00/15] dma-fence cleanup v2

2018-05-03 Thread Daniel Vetter
Hi all, Resending the entire pile because I shrugged of some CI noise which wasn't noise. Silly me :-/ Besides the BUG_ON that also Chris spotted just minor changes, which I did send out individually already. As always, feedback very much welcome. Thanks, Daniel Daniel Vetter (15): dma-fence

[Intel-gfx] [PATCH 02/15] dma-fence: Make ->enable_signaling optional

2018-05-03 Thread Daniel Vetter
Many drivers have a trivial implementation for ->enable_signaling. Let's make it optional by assuming that signalling is already available when the callback isn't present. Reviewed-by: Christian König Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: Gustavo Padovan Cc: linux-me...@vger.kernel

[Intel-gfx] [PATCH 07/15] drm/etnaviv: Remove unecessary dma_fence_ops

2018-05-03 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. Acked-by: Lucas Stach Signed-off-by: Daniel Vetter Cc: Lucas Stach Cc: Russell King Cc: Christian Gmeiner Cc: etna...@lists.freedesktop.org --- drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 7 ---

[Intel-gfx] [PATCH 01/15] dma-fence: remove fill_driver_data callback

2018-05-03 Thread Daniel Vetter
Noticed while I was typing docs. Entirely unused. v2: Remove reference in @timeline_value_str too. While at it clarify why timeline_value_str has a fence parameter - we don't have an explicit timeline structure unfortunately. Cc: Eric Anholt Reviewed-by: Eric Anholt Reviewed-by: Christian König

[Intel-gfx] [PATCH 03/15] dma-fence: Allow wait_any_timeout for all fences

2018-05-03 Thread Daniel Vetter
When this was introduced in commit a519435a96597d8cd96123246fea4ae5a6c90b02 Author: Christian König Date: Tue Oct 20 16:34:16 2015 +0200 dma-buf/fence: add fence_wait_any_timeout function v2 there was a restriction added that this only works if the dma-fence uses the dma_fence_default_wai

Re: [Intel-gfx] [PATCH i-g-t] igt/gem_wait: Relax assertion for wait completion

2018-05-03 Thread Chris Wilson
Quoting Joonas Lahtinen (2018-05-03 15:05:38) > Quoting Chris Wilson (2018-05-02 14:13:26) > > When waiting for a finite batch, all that we require is that the batch > > completes. If it takes the full second (or longer) for us to wake up and > > notice the completed batch is immaterial, so only as

Re: [Intel-gfx] [PATCH] drm/i915: Micro-optimise i915_request_retire()

2018-05-03 Thread Chris Wilson
Quoting Joonas Lahtinen (2018-05-03 14:59:35) > Quoting Chris Wilson (2018-05-02 20:21:42) > > I caught the compiler emitting the if(!NULL) guard at the start of > > dma_fence_put(); on the request it should know for certain is already > > non-NULL. Mark up the function as non-null and tell the com

Re: [Intel-gfx] [PATCH i-g-t] igt/gem_wait: Relax assertion for wait completion

2018-05-03 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-05-02 14:13:26) > When waiting for a finite batch, all that we require is that the batch > completes. If it takes the full second (or longer) for us to wake up and > notice the completed batch is immaterial, so only assert that we don't > report an infinite timeout afterw

Re: [Intel-gfx] [PATCH] drm/i915: Micro-optimise i915_request_retire()

2018-05-03 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-05-02 20:21:42) > I caught the compiler emitting the if(!NULL) guard at the start of > dma_fence_put(); on the request it should know for certain is already > non-NULL. Mark up the function as non-null and tell the compiler that > the request pointer doesn't change: > >

Re: [Intel-gfx] [PATCH 08/17] drm/etnaviv: Remove unecessary dma_fence_ops

2018-05-03 Thread Lucas Stach
Am Freitag, den 27.04.2018, 08:17 +0200 schrieb Daniel Vetter: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. > > > Signed-off-by: Daniel Vetter > > Cc: Lucas Stach > > Cc: Russell King > > Cc: Christian Gmeiner > Cc: etna...@lists.freedesk

Re: [Intel-gfx] [PATCH] drm/i915: Adjust eDP's logical vco in a reliable place.

2018-05-03 Thread Rodrigo Vivi
On Thu, May 03, 2018 at 04:17:24PM +0300, Ville Syrjälä wrote: > On Thu, May 03, 2018 at 06:07:45AM -0700, Rodrigo Vivi wrote: > > On Wed, May 02, 2018 at 10:12:51PM +0300, Ville Syrjälä wrote: > > > On Wed, May 02, 2018 at 10:52:55AM -0700, Rodrigo Vivi wrote: > > > > On intel_dp_compute_config()

Re: [Intel-gfx] [PATCH 4/5] drm/selftests: Rename the Kconfig option to CONFIG_DRM_DEBUG_SELFTEST

2018-05-03 Thread Ville Syrjälä
On Thu, May 03, 2018 at 01:22:16PM +0200, Maarten Lankhorst wrote: > We want to add more DRM selftests, and there's not much point in > having a Kconfig option for every single one of them, so make > a generic one. > > Signed-off-by: Maarten Lankhorst Seems like a reasonable idea. Reviewed-by:

Re: [Intel-gfx] [PATCH 5/5] drm/selftests: Add drm helper selftest

2018-05-03 Thread Ville Syrjälä
On Thu, May 03, 2018 at 01:22:17PM +0200, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/Kconfig | 1 + > drivers/gpu/drm/selftests/Makefile| 2 +- > .../gpu/drm/selftests/drm_helper_selftests.h | 9 + > drivers/gpu/drm

Re: [Intel-gfx] [PATCH 3/5] drm/i915: Do not adjust scale when out of bounds, v2.

2018-05-03 Thread Ville Syrjälä
On Thu, May 03, 2018 at 01:22:15PM +0200, Maarten Lankhorst wrote: > With the previous patch drm_atomic_helper_check_plane_state correctly > calculates clipping and the xf86-video-intel ddx is fixed to fall back > to GPU correctly when SetPlane fails, we can remove the hack where > we try to pan/zo

Re: [Intel-gfx] [PATCH 1/5] drm/rect: Round above 1 << 16 upwards to correct scale calculation functions.

2018-05-03 Thread Ville Syrjälä
On Thu, May 03, 2018 at 01:22:13PM +0200, Maarten Lankhorst wrote: > When calculating limits we want to be as pessimistic as possible, > so we have to explicitly say whether we want to round up or down > to accurately calculate whether we are below min_scale or above > max_scale. > > Signed-off-by

Re: [Intel-gfx] [PATCH 2/5] drm/rect: Handle rounding errors in drm_rect_clip_scaled, v3.

2018-05-03 Thread Ville Syrjälä
On Thu, May 03, 2018 at 01:22:14PM +0200, Maarten Lankhorst wrote: > Instead of relying on a scale which may increase rounding errors, > clip src by doing: src * (dst - clip) / dst and rounding the result > away from 1, so the new coordinates get closer to 1. We won't need > to fix up with a magic

Re: [Intel-gfx] [PATCH] drm/i915: Adjust eDP's logical vco in a reliable place.

2018-05-03 Thread Ville Syrjälä
On Thu, May 03, 2018 at 06:07:45AM -0700, Rodrigo Vivi wrote: > On Wed, May 02, 2018 at 10:12:51PM +0300, Ville Syrjälä wrote: > > On Wed, May 02, 2018 at 10:52:55AM -0700, Rodrigo Vivi wrote: > > > On intel_dp_compute_config() we were calculating the needed vco > > > for eDP on gen9 and we stashin

Re: [Intel-gfx] [PATCH 06/71] drm/i915: Detect if we missed kicking the execlists tasklet

2018-05-03 Thread Chris Wilson
Quoting Chris Wilson (2018-05-03 07:36:52) > If inside hangcheck we see that the engine has paused, but there is an > execlists interrupt still pending, we know that the tasklet did not > fire. Dump the GEM trace along with the current engine state, and kick > the tasklet to recovery without having

Re: [Intel-gfx] [PATCH] drm/i915: Adjust eDP's logical vco in a reliable place.

2018-05-03 Thread Rodrigo Vivi
On Wed, May 02, 2018 at 10:12:51PM +0300, Ville Syrjälä wrote: > On Wed, May 02, 2018 at 10:52:55AM -0700, Rodrigo Vivi wrote: > > On intel_dp_compute_config() we were calculating the needed vco > > for eDP on gen9 and we stashing it in > > intel_atomic_state.cdclk.logical.vco > > > > However few

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: vbt change for psr (rev6)

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915/psr: vbt change for psr (rev6) URL : https://patchwork.freedesktop.org/series/41289/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4131 -> Patchwork_8897 = == Summary - WARNING == Minor unknown changes coming with Patchwork_8897 need

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: vbt change for psr (rev6)

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915/psr: vbt change for psr (rev6) URL : https://patchwork.freedesktop.org/series/41289/ State : warning == Summary == $ dim checkpatch origin/drm-tip 824c9eb50c54 drm/i915/psr: vbt change for psr -:69: CHECK:SPACING: spaces preferred around that '<<' (ctx:VxV

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Fix rounding errors and use scaling in i915, v2.

2018-05-03 Thread Patchwork
== Series Details == Series: drm: Fix rounding errors and use scaling in i915, v2. URL : https://patchwork.freedesktop.org/series/42631/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4131 -> Patchwork_8896 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH v8 1/2] drm: content-type property for HDMI connector

2018-05-03 Thread Lisovskiy, Stanislav
On Thu, 2018-05-03 at 10:46 +, Lisovskiy, Stanislav wrote: > On Thu, 2018-05-03 at 13:18 +0300, Jani Nikula wrote: > > On Wed, 02 May 2018, StanLis wrote: > > > From: Stanislav Lisovskiy > > > > > > > > > diff --git a/Documentation/gpu/kms-properties.csv > > > b/Documentation/gpu/kms-proper

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm: Fix rounding errors and use scaling in i915, v2.

2018-05-03 Thread Patchwork
== Series Details == Series: drm: Fix rounding errors and use scaling in i915, v2. URL : https://patchwork.freedesktop.org/series/42631/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/rect: Round above 1 << 16 upwards to correct scale calculation functions. Okay! Commi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm: Fix rounding errors and use scaling in i915, v2.

2018-05-03 Thread Patchwork
== Series Details == Series: drm: Fix rounding errors and use scaling in i915, v2. URL : https://patchwork.freedesktop.org/series/42631/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9e4d573cb796 drm/rect: Round above 1 << 16 upwards to correct scale calculation functions. -:2

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Perform a chipset flush for GGTT writes

2018-05-03 Thread Patchwork
== Series Details == Series: drm/i915: Perform a chipset flush for GGTT writes URL : https://patchwork.freedesktop.org/series/42627/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4131 -> Patchwork_8895 = == Summary - FAILURE == Serious unknown changes coming with Patchwo

  1   2   >