Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-16 Thread Saarinen, Jani
+wider-list. > -Original Message- > From: Srinivas, Vidya > Sent: tiistai 17. huhtikuuta 2018 7.59 > To: 'Maarten Lankhorst' ; 'intel-gfx- > try...@lists.freedesktop.org' > Cc: Kamath, Sunil ; Saarinen, Jani > > Subject: RE: [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915: Do not do fb src adjustments for NV12

2018-04-16 Thread Saarinen, Jani
Lets move this to intel-gfx to get more eyes on it. > -Original Message- > From: Srinivas, Vidya > Sent: tiistai 17. huhtikuuta 2018 5.47 > To: Maarten Lankhorst ; intel-gfx- > try...@lists.freedesktop.org > Cc: Kamath, Sunil ; Saarinen, Jani > > Subject: RE: [PATCH v2 6/6] drm/i915: Do

Re: [Intel-gfx] [PATCH v10 10/11] drm: Add aspect ratio parsing in DRM layer

2018-04-16 Thread Nautiyal, Ankit K
On 4/6/2018 11:14 PM, Ville Syrjälä wrote: On Fri, Apr 06, 2018 at 10:55:14PM +0530, Nautiyal, Ankit K wrote: This patch is causing failure of IGT test kms_3d. The kms_3d test expects the no. of 3d modes to be 13. (The test has hard-coded value for expected no. of 3d modes as 13) But due to t

Re: [Intel-gfx] [PATCH v4] drm/i915: Enable edp psr error interrupts on hsw

2018-04-16 Thread Paulo Zanoni
Em Qui, 2018-04-05 às 15:00 -0700, Dhinakaran Pandiyan escreveu: > From: Daniel Vetter > > The definitions for the error register should be valid on bdw/skl > too, > but there we haven't even enabled DE_MISC handling yet. > > Somewhat confusing the the moved register offset on bdw is only for >

Re: [Intel-gfx] [PATCH] drm/i915: Fix LSPCON TMDS output buffer enabling from low-power state

2018-04-16 Thread Clint Taylor
On 04/16/2018 08:53 AM, Imre Deak wrote: LSPCON adapters in low-power state may ignore the first I2C write during TMDS output buffer enabling, resulting in a blank screen even with an otherwise enabled pipe. Fix this by reading back and validating the written value a few times. The problem was

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Handle a potential failure of intel_ring_begin

2018-04-16 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Handle a potential failure of intel_ring_begin URL : https://patchwork.freedesktop.org/series/41773/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4058_full -> Patchwork_8700_full = == Summary - FAILURE == Serious unknown

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v7,1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads (rev9)

2018-04-16 Thread Patchwork
== Series Details == Series: series starting with [v7,1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads (rev9) URL : https://patchwork.freedesktop.org/series/40503/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4058_full -> Patchwork_8699_full = ==

Re: [Intel-gfx] [RESEND PATCH 1/1] drm/i915/glk: Add MODULE_FIRMWARE for Geminilake

2018-04-16 Thread Srivatsa, Anusha
>-Original Message- >From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >Sent: Wednesday, April 11, 2018 5:27 AM >To: Ian W MORRISON >Cc: Vivi, Rodrigo ; Srivatsa, Anusha >; Wajdeczko, Michal >; Greg KH ; >airl...@linux.ie; joonas.lahti...@linux.intel.com; >linux-ker...@vger.kernel.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Handle a potential failure of intel_ring_begin

2018-04-16 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Handle a potential failure of intel_ring_begin URL : https://patchwork.freedesktop.org/series/41773/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4058 -> Patchwork_8700 = == Summary - WARNING == Minor unknown changes comi

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v7,1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads (rev9)

2018-04-16 Thread Patchwork
== Series Details == Series: series starting with [v7,1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads (rev9) URL : https://patchwork.freedesktop.org/series/40503/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4058 -> Patchwork_8699 = == Summary -

Re: [Intel-gfx] [PATCH v7 2/2] drm/i915: Implement WaProgramMgsrForL3BankSpecificMmioReads

2018-04-16 Thread Oscar Mateo
On 04/16/2018 02:24 PM, Yunwei Zhang wrote: L3Bank could be fused off in hardware for debug purpose, and it is possible that subslice is enabled while its corresponding L3Bank pairs are disabled. In such case, if MCR packet control register(0xFDC) is programed to point to a disabled bank pair,

Re: [Intel-gfx] [PATCH v7 1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads

2018-04-16 Thread Oscar Mateo
On 04/16/2018 02:22 PM, Yunwei Zhang wrote: WaProgramMgsrForCorrectSliceSpecificMmioReads dictate that before any MMIO read into Slice/Subslice specific registers, MCR packet control register(0xFDC) needs to be programmed to point to any enabled slice/subslice pair. Otherwise, incorrect value w

[Intel-gfx] [PATCH] drm/i915/selftests: Handle a potential failure of intel_ring_begin

2018-04-16 Thread Oscar Mateo
Silence smatch over: drivers/gpu/drm/i915/selftests/intel_workarounds.c:58 read_nonprivs() error: 'cs' dereferencing possible ERR_PTR() by handling a potential (but unlikely) failure of intel_ring_begin. Fixes: f4ecfbfc32ed ("drm/i915: Check whitelist registers across resets") Signed-off-by: Os

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v7,1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads (rev9)

2018-04-16 Thread Patchwork
== Series Details == Series: series starting with [v7,1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads (rev9) URL : https://patchwork.freedesktop.org/series/40503/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/cnl: Implement WaProgramMgsr

[Intel-gfx] [PATCH v7 2/2] drm/i915: Implement WaProgramMgsrForL3BankSpecificMmioReads

2018-04-16 Thread Yunwei Zhang
L3Bank could be fused off in hardware for debug purpose, and it is possible that subslice is enabled while its corresponding L3Bank pairs are disabled. In such case, if MCR packet control register(0xFDC) is programed to point to a disabled bank pair, a MMIO read into L3Bank range will return 0 inst

[Intel-gfx] [PATCH v7 1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads

2018-04-16 Thread Yunwei Zhang
WaProgramMgsrForCorrectSliceSpecificMmioReads dictate that before any MMIO read into Slice/Subslice specific registers, MCR packet control register(0xFDC) needs to be programmed to point to any enabled slice/subslice pair. Otherwise, incorrect value will be returned. However, that means each subse

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add LSPCON's information in i915_display_info

2018-04-16 Thread Patchwork
== Series Details == Series: drm/i915: Add LSPCON's information in i915_display_info URL : https://patchwork.freedesktop.org/series/41763/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4057_full -> Patchwork_8698_full = == Summary - WARNING == Minor unknown changes comin

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix LSPCON TMDS output buffer enabling from low-power state

2018-04-16 Thread Patchwork
== Series Details == Series: drm/i915: Fix LSPCON TMDS output buffer enabling from low-power state URL : https://patchwork.freedesktop.org/series/41759/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4057_full -> Patchwork_8697_full = == Summary - WARNING == Minor unknown

Re: [Intel-gfx] [RFC v4 00/25] drm: Add generic fbdev emulation

2018-04-16 Thread Noralf Trønnes
Den 16.04.2018 10.21, skrev Daniel Vetter: On Sat, Apr 14, 2018 at 01:52:53PM +0200, Noralf Trønnes wrote: This patchset explores the possibility of having generic fbdev emulation in DRM for drivers that supports dumb buffers which they can export. An API is added to support in-kernel clients i

Re: [Intel-gfx] [PATCH v3 3/4] drm/i915: Add code to accept valid locked WOPCM register values

2018-04-16 Thread Yaodong Li
On 04/13/2018 09:20 PM, Michal Wajdeczko wrote: On Tue, 10 Apr 2018 02:42:19 +0200, Jackie Li wrote: In current code, we only compare the locked WOPCM register values with the calculated values. However, we can continue loading GuC/HuC firmware if the locked (or partially locked) values were

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add LSPCON's information in i915_display_info

2018-04-16 Thread Patchwork
== Series Details == Series: drm/i915: Add LSPCON's information in i915_display_info URL : https://patchwork.freedesktop.org/series/41763/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4057 -> Patchwork_8698 = == Summary - WARNING == Minor unknown changes coming with Pat

Re: [Intel-gfx] [Freedreno] [PATCH 01/10] include: Move ascii85 functions from i915 to linux/ascii85.h

2018-04-16 Thread Eric Anholt
Chris Wilson writes: > Quoting Jordan Crouse (2018-04-05 23:06:53) >> On Thu, Apr 05, 2018 at 04:00:47PM -0600, Jordan Crouse wrote: >> > The i915 DRM driver very cleverly used ascii85 encoding for their >> > GPU state file. Move the encode functions to a general header file to >> > support other

Re: [Intel-gfx] [PATCH v3 2/4] drm/i915: Always set HUC_LOADING_AGENT_GUC bit in WOPCM offset register

2018-04-16 Thread Yaodong Li
On 04/13/2018 07:26 PM, Michal Wajdeczko wrote: On Tue, 10 Apr 2018 02:42:18 +0200, Jackie Li wrote: The enable_guc modparam is used to enable/disable GuC/HuC FW uploading dynamcially during i915 module loading. If WOPCM offset register was   typo D'oh! I really need a tool for this!

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix LSPCON TMDS output buffer enabling from low-power state

2018-04-16 Thread Patchwork
== Series Details == Series: drm/i915: Fix LSPCON TMDS output buffer enabling from low-power state URL : https://patchwork.freedesktop.org/series/41759/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4057 -> Patchwork_8697 = == Summary - WARNING == Minor unknown changes c

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915: Always do WOPCM partitioning based on real firmware sizes

2018-04-16 Thread Yaodong Li
On 04/13/2018 07:15 PM, Michal Wajdeczko wrote: On Tue, 10 Apr 2018 02:42:17 +0200, Jackie Li wrote: After enabled the WOPCM write-once registers locking status checking, reloading of the i915 module will fail with modparam enable_guc set to 3 (enable GuC and HuC firmware loading) if the modu

Re: [Intel-gfx] [PATCH 0/9] GPU-bound energy efficiency improvements for the intel_pstate driver.

2018-04-16 Thread Srinivas Pandruvada
On Mon, 2018-04-16 at 17:04 +0300, Eero Tamminen wrote: > Hi, > > On 14.04.2018 07:01, Srinivas Pandruvada wrote: > > Hi Francisco, > > > > [...] > > > > > Are you no longer interested in improving those aspects of the > > > non- > > > HWP > > > governor?  Is it that you're planning to delete it

Re: [Intel-gfx] [PATCH v1 2/2] i915: content-type property for HDMI connector

2018-04-16 Thread Sean Paul
On Tue, Apr 17, 2018 at 02:16:59AM +0300, StanLis wrote: > From: Stanislav Lisovskiy > > Added encoding of drm content_type property from > drm_connector_state within AVI infoframe in order to properly handle > external HDMI TV content-type setting. > > Signed-off-by: Stanislav Lisovskiy Hi St

[Intel-gfx] [PATCH] drm/i915: Add LSPCON's information in i915_display_info

2018-04-16 Thread Shashank Sharma
Sometimes it gets difficult for an end-user to know presence of a LSPCON device, as the encoder is enumerated as DP device. This patch adds a string "LSPCON present: " in the display_info so that a user can easily know if there is a active LSPCON device on this encoder. Cc: Ville Syrjala Signed-o

Re: [Intel-gfx] [PATCH v5] drm: Fix HDCP downstream dev count read

2018-04-16 Thread Sean Paul
On Thu, Apr 5, 2018 at 8:09 AM Ramalingam C wrote: > In both HDMI and DP, device count is represented by 6:0 bits of a > register(BInfo/Bstatus) > So macro for bitmasking the device_count is fixed(0x3F->0x7F). > v3: >Retained the Rb-ed. > v4: >%s/drm\/i915/drm [rodrigo] > v5: >Added

Re: [Intel-gfx] [RFC v4 21/25] drm/fb-helper: Add drm_fb_helper_fb_open/release()

2018-04-16 Thread Noralf Trønnes
Den 16.04.2018 10.46, skrev Daniel Vetter: On Sat, Apr 14, 2018 at 01:53:14PM +0200, Noralf Trønnes wrote: These helpers keep track of fbdev users and drm_driver.last_close will only restore fbdev when actually in use. Additionally the display is turned off when the last user is closing. fbcon

Re: [Intel-gfx] [RFC v4 19/25] drm/client: Finish the in-kernel client API

2018-04-16 Thread Noralf Trønnes
Den 16.04.2018 10.27, skrev Daniel Vetter: On Sat, Apr 14, 2018 at 01:53:12PM +0200, Noralf Trønnes wrote: The modesetting code is already present, this adds the rest of the API. Mentioning the TODO in the commit message would be good. Helps readers like me who have an attention span measured

[Intel-gfx] [PATCH] drm/i915: Fix LSPCON TMDS output buffer enabling from low-power state

2018-04-16 Thread Imre Deak
LSPCON adapters in low-power state may ignore the first I2C write during TMDS output buffer enabling, resulting in a blank screen even with an otherwise enabled pipe. Fix this by reading back and validating the written value a few times. The problem was noticed on GLK machines with an onboard LSPC

[Intel-gfx] ✗ Fi.CI.IGT: failure for Enabling content-type setting for external HDMI displays. (rev2)

2018-04-16 Thread Patchwork
== Series Details == Series: Enabling content-type setting for external HDMI displays. (rev2) URL : https://patchwork.freedesktop.org/series/41744/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4054_full -> Patchwork_8696_full = == Summary - FAILURE == Serious unknown ch

[Intel-gfx] [PATCH i-g-t] tests/gem_exec_latency: New subtests for checking submission from RT tasks

2018-04-16 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We want to make sure RT tasks which use a lot of CPU times can submit batch buffers with roughly the same latency (and certainly not worse) compared to normal tasks. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson --- tests/gem_exec_latency.c | 176

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Print error state times relative to capture

2018-04-16 Thread Patchwork
== Series Details == Series: drm/i915: Print error state times relative to capture URL : https://patchwork.freedesktop.org/series/41749/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4054_full -> Patchwork_8695_full = == Summary - WARNING == Minor unknown changes coming

Re: [Intel-gfx] [RFC v2] drm/i915: Engine discovery query

2018-04-16 Thread Lionel Landwerlin
On 16/04/18 03:11, Tvrtko Ursulin wrote: On 11/04/2018 17:32, Lionel Landwerlin wrote: Looks good to me, a few nits below. I'll try to find some time to display this information in gputop. Reviewed-by: Lionel Landwerlin Thanks! On 11/04/18 02:46, Tvrtko Ursulin wrote: From: Tvrtko Ursuli

[Intel-gfx] ✓ Fi.CI.BAT: success for Enabling content-type setting for external HDMI displays. (rev2)

2018-04-16 Thread Patchwork
== Series Details == Series: Enabling content-type setting for external HDMI displays. (rev2) URL : https://patchwork.freedesktop.org/series/41744/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4054 -> Patchwork_8696 = == Summary - SUCCESS == No regressions found. Ext

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Enabling content-type setting for external HDMI displays. (rev2)

2018-04-16 Thread Patchwork
== Series Details == Series: Enabling content-type setting for external HDMI displays. (rev2) URL : https://patchwork.freedesktop.org/series/41744/ State : warning == Summary == $ dim checkpatch origin/drm-tip ff3a198613ab drm: content-type property for HDMI connector -:84: CHECK:PARENTHESIS_A

[Intel-gfx] [PATCH v1 2/2] i915: content-type property for HDMI connector

2018-04-16 Thread StanLis
From: Stanislav Lisovskiy Added encoding of drm content_type property from drm_connector_state within AVI infoframe in order to properly handle external HDMI TV content-type setting. Signed-off-by: Stanislav Lisovskiy --- drivers/gpu/drm/i915/intel_atomic.c | 1 + drivers/gpu/drm/i915/intel_d

[Intel-gfx] [PATCH v1 0/2] Enabling content-type setting for external HDMI displays.

2018-04-16 Thread StanLis
From: Stanislav Lisovskiy Added content type setting property to drm_connector(part 1) and enabled transmitting it with HDMI AVI infoframes for i915(part 2). Stanislav Lisovskiy (2): drm: content-type property for HDMI connector i915: content-type property for HDMI connector Documentation/

[Intel-gfx] [PATCH v1 1/2] drm: content-type property for HDMI connector

2018-04-16 Thread StanLis
From: Stanislav Lisovskiy Added content_type property to drm_connector_state in order to properly handle external HDMI TV content-type setting. Signed-off-by: Stanislav Lisovskiy --- Documentation/gpu/kms-properties.csv | 1 + drivers/gpu/drm/drm_atomic.c | 4 drivers/gpu/drm/dr

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Print error state times relative to capture

2018-04-16 Thread Patchwork
== Series Details == Series: drm/i915: Print error state times relative to capture URL : https://patchwork.freedesktop.org/series/41749/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4054 -> Patchwork_8695 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH 0/9] GPU-bound energy efficiency improvements for the intel_pstate driver.

2018-04-16 Thread Eero Tamminen
Hi, On 14.04.2018 07:01, Srinivas Pandruvada wrote: Hi Francisco, [...] Are you no longer interested in improving those aspects of the non- HWP governor?  Is it that you're planning to delete it and move back to a generic cpufreq governor for non-HWP platforms in the near future? Yes that i

Re: [Intel-gfx] [PATCH] drm/i915: Print error state times relative to capture

2018-04-16 Thread Chris Wilson
Quoting Mika Kuoppala (2018-04-16 14:40:52) > Using plain jiffies in error state output makes the output > time differences relative to the current system time. This > is wrong as it makes output time differences dependent > of when the error state is printed rather than when it is > captured. > >

Re: [Intel-gfx] [PATCH 11/13] drm/omapdrm: Nuke omap_framebuffer_get_next_connector()

2018-04-16 Thread Tomi Valkeinen
On 09/04/18 11:41, Daniel Vetter wrote: > On Fri, Apr 06, 2018 at 09:10:43AM +0300, Tomi Valkeinen wrote: >> On 05/04/18 19:50, Daniel Vetter wrote: >>> On Thu, Apr 05, 2018 at 06:13:58PM +0300, Ville Syrjala wrote: From: Ville Syrjälä omap_framebuffer_get_next_connector() uses plan

[Intel-gfx] [PATCH] drm/i915: Print error state times relative to capture

2018-04-16 Thread Mika Kuoppala
Using plain jiffies in error state output makes the output time differences relative to the current system time. This is wrong as it makes output time differences dependent of when the error state is printed rather than when it is captured. Store capture jiffies into error state and use it when ou

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gvt: Deliver guest cursor hotspot info (rev2)

2018-04-16 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Deliver guest cursor hotspot info (rev2) URL : https://patchwork.freedesktop.org/series/41727/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4054_full -> Patchwork_8694_full = == Summary - FAILURE == Serious unknown changes comi

[Intel-gfx] [PATCH v1 0/2] Enabling content-type setting for external HDMI displays.

2018-04-16 Thread StanLis
From: Stanislav Lisovskiy Added content type setting property to drm_connector(part 1) and enabled transmitting it with HDMI AVI infoframes for i915(part 2). Stanislav Lisovskiy (2): drm: content-type property for HDMI connector i915: content-type property for HDMI connector Documentation/

Re: [Intel-gfx] [PATCH igt] igt/prime_mmap: Test for userptr support first

2018-04-16 Thread Tvrtko Ursulin
On 12/04/2018 19:08, Chris Wilson wrote: Before we start trying to use userptr to test interoperability with PRIME, we first need to check that the device in question has userptr support. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106013 Signed-off-by: Chris Wilson --- tests/prim

Re: [Intel-gfx] [RFC v2] drm/i915: Engine discovery query

2018-04-16 Thread Tvrtko Ursulin
On 11/04/2018 17:32, Lionel Landwerlin wrote: Looks good to me, a few nits below. I'll try to find some time to display this information in gputop. Reviewed-by: Lionel Landwerlin Thanks! On 11/04/18 02:46, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Engine discovery query allows userspac

Re: [Intel-gfx] [PATCH i-g-t v4] tests/perf_pmu: Avoid RT thread for accuracy test

2018-04-16 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-16 10:55:29) > > On 14/04/2018 12:35, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-04-11 14:52:36) > >> > >> On 11/04/2018 14:23, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2018-04-04 10:51:52) > From: Tvrtko Ursulin > > Realtime sched

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: Deliver guest cursor hotspot info (rev2)

2018-04-16 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Deliver guest cursor hotspot info (rev2) URL : https://patchwork.freedesktop.org/series/41727/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4054 -> Patchwork_8694 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH i-g-t v4] tests/perf_pmu: Avoid RT thread for accuracy test

2018-04-16 Thread Tvrtko Ursulin
On 14/04/2018 12:35, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-11 14:52:36) On 11/04/2018 14:23, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-04 10:51:52) From: Tvrtko Ursulin Realtime scheduling interferes with execlists submission (tasklet) so try to simplify the PWM loo

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gvt: Deliver guest cursor hotspot info (rev2)

2018-04-16 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Deliver guest cursor hotspot info (rev2) URL : https://patchwork.freedesktop.org/series/41727/ State : warning == Summary == $ dim checkpatch origin/drm-tip a117fc1be218 drm/i915/gvt: Deliver guest cursor hotspot info -:36: CHECK:UNNECESSARY_PARENTHES

Re: [Intel-gfx] [RFC v4 16/25] drm: Make ioctls available for in-kernel clients

2018-04-16 Thread Daniel Vetter
On Sat, Apr 14, 2018 at 01:53:09PM +0200, Noralf Trønnes wrote: > Make ioctl wrappers for functions that will be used by the in-kernel API. > The following functions are touched: > - drm_mode_create_dumb_ioctl() > - drm_mode_destroy_dumb_ioctl() > - drm_mode_addfb2() > - drm_mode_rmfb() > - drm_pri

Re: [Intel-gfx] [RFC v4 22/25] drm/fb-helper: Add generic fbdev emulation

2018-04-16 Thread Daniel Vetter
On Sat, Apr 14, 2018 at 01:53:15PM +0200, Noralf Trønnes wrote: > This adds generic fbdev emulation for drivers that supports > dumb buffers which they can export. > > All the driver has to do is call drm_fbdev_generic_setup(). > > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/drm/drm_fb_he

Re: [Intel-gfx] [RFC v4 21/25] drm/fb-helper: Add drm_fb_helper_fb_open/release()

2018-04-16 Thread Daniel Vetter
On Sat, Apr 14, 2018 at 01:53:14PM +0200, Noralf Trønnes wrote: > These helpers keep track of fbdev users and drm_driver.last_close will > only restore fbdev when actually in use. Additionally the display is > turned off when the last user is closing. fbcon is a user in this context. > > If struct

Re: [Intel-gfx] [RFC v4 17/25] drm/client: Bail out if there's a DRM master

2018-04-16 Thread Daniel Vetter
On Sat, Apr 14, 2018 at 01:53:10PM +0200, Noralf Trønnes wrote: > If there's a DRM master, return -EBUSY. > Block userspace from becoming master by taking the master lock while > the client is setting the mode. > > Suggested-by: Daniel Vetter > Signed-off-by: Noralf Trønnes > --- > drivers/gpu/

Re: [Intel-gfx] [RFC v4 12/25] drm/i915: Add drm_driver->initial_client_display callback

2018-04-16 Thread Daniel Vetter
On Sat, Apr 14, 2018 at 01:53:05PM +0200, Noralf Trønnes wrote: > As part of moving the modesetting code out of drm_fb_helper and into > drm_client, the drm_fb_helper_funcs->initial_config callback needs to go. > Replace it with a drm_driver->initial_client_display callback that can > work for all

Re: [Intel-gfx] [RFC v4 11/25] drm/connector: Add connector array functions

2018-04-16 Thread Daniel Vetter
On Sat, Apr 14, 2018 at 01:53:04PM +0200, Noralf Trønnes wrote: > Add functions to deal with the registred connectors as an array: > - drm_connector_get_all() > - drm_connector_put_all() > > And to get the enabled status of those connectors: > drm_connector_get_enabled_status() > > This is prep w

Re: [Intel-gfx] [RFC v4 06/25] drm/atomic: Move __drm_atomic_helper_disable_plane/set_config()

2018-04-16 Thread Daniel Vetter
On Sat, Apr 14, 2018 at 01:52:59PM +0200, Noralf Trønnes wrote: > Prepare for moving drm_fb_helper modesetting code to drm_client. > drm_client will be linked to drm.ko, so move > __drm_atomic_helper_disable_plane() and __drm_atomic_helper_set_config() > out of drm_kms_helper.ko. > > Signed-off-by

Re: [Intel-gfx] [RFC v4 19/25] drm/client: Finish the in-kernel client API

2018-04-16 Thread Daniel Vetter
On Sat, Apr 14, 2018 at 01:53:12PM +0200, Noralf Trønnes wrote: > The modesetting code is already present, this adds the rest of the API. Mentioning the TODO in the commit message would be good. Helps readers like me who have an attention span measured in seconds :-) Just commenting on the create

Re: [Intel-gfx] [RFC v4 00/25] drm: Add generic fbdev emulation

2018-04-16 Thread Daniel Vetter
On Sat, Apr 14, 2018 at 01:52:53PM +0200, Noralf Trønnes wrote: > This patchset explores the possibility of having generic fbdev emulation > in DRM for drivers that supports dumb buffers which they can export. An > API is added to support in-kernel clients in general. > > In this version I was abl

Re: [Intel-gfx] [RFC v4 00/25] drm: Add generic fbdev emulation

2018-04-16 Thread Daniel Vetter
On Thu, Apr 12, 2018 at 06:34:46PM +0200, Noralf Trønnes wrote: > I hit a 'Sending rate exceeded' error with this patchset, so it didn't go > out as it should. > I will resend the patchset when I find out how to avoid this problem. That's generally an issue with your ISP. gmail works ime for mail