Re: [Intel-gfx] [PATCH 02/10] drm: i915: Get DSC capability from DP sink

2018-03-04 Thread Dan Carpenter
Hi Gaurav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on next-20180223] [also build test WARNING on v4.16-rc3] [cannot apply to drm-intel/for-linux-next drm/drm-next v4.16-rc3 v4.16-rc2 v4.16-rc1] [if your patch is applied to the wrong git tree, please drop u

Re: [Intel-gfx] [PATCH 03/15] drm/i915/guc: Move GuC notification handling to separate function

2018-03-04 Thread Sagar Arun Kamble
On 2/27/2018 6:22 PM, Michał Winiarski wrote: From: Michal Wajdeczko To allow future code reuse. While here, fix comment style. Suggested-by: Oscar Mateo Signed-off-by: Michal Wajdeczko Signed-off-by: Michał Winiarski Cc: Chris Wilson Cc: Daniele Ceraolo Spurio Cc: Oscar Mateo Cc: Saga

Re: [Intel-gfx] [PATCH 02/15] drm/i915/guc: Create common entry points for log register/unregister

2018-03-04 Thread Sagar Arun Kamble
Overall change looks good. Could you please clarify on below: intel_uc_log_register|unregister are removed in patch later in the series. Should we just stay with inner functions then to minimize changes? Thanks Sagar On 2/27/2018 6:22 PM, Michał Winiarski wrote: We have many functions respo

Re: [Intel-gfx] [PATCH v3] drm/i915/icl: remove port A/E lane sharing limitation.

2018-03-04 Thread Kumar, Mahesh
Please review. thanks, -Mahesh On 2/6/2018 11:38 AM, Mahesh Kumar wrote: Platforms before Gen11 were sharing lanes between port-A & port-E. This limitation is no more there. Changes since V1: - optimize the code (Shashank/Jani) - create helper function to get max lanes (ville) Changes sin

Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT

2018-03-04 Thread Singh, Gaurav K
On 3/5/2018 12:13 PM, Mullah, Abid A wrote: Did u check the fix on bxt and if u didnt see any issue then u can go ahead. I will update bspec tomorrow Sent from my iPhone Tested on apollolake chromebook by stress test warm reboot with 2500 iterations and did not see any issue. With regards,

Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT

2018-03-04 Thread Mullah, Abid A
Did u check the fix on bxt and if u didnt see any issue then u can go ahead. I will update bspec tomorrow Sent from my iPhone > On Mar 4, 2018, at 10:09 PM, Singh, Gaurav K wrote: > > > >> On 2/27/2018 11:00 PM, Runyan, Arthur J wrote: >> Ok, please update the workaround page to show all th

Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT

2018-03-04 Thread Singh, Gaurav K
On 2/27/2018 11:00 PM, Runyan, Arthur J wrote: Ok, please update the workaround page to show all the impacted projects https://gfxspecs.intel.com/Predator/Home/Index/21829 Hi, Should we wait for Bspec to get updated or we can go ahead with the merge. Please advise. With regards, Gaurav

Re: [Intel-gfx] [PATCH 01/15] drm/i915/guc: Tidy guc_log_control

2018-03-04 Thread Sagar Arun Kamble
On 3/2/2018 5:22 PM, Michał Winiarski wrote: On Fri, Mar 02, 2018 at 04:39:38PM +0530, Sagar Arun Kamble wrote: On 2/27/2018 6:22 PM, Michał Winiarski wrote: We plan to decouple log runtime (mapping + relay) from verbosity control. Let's tidy the code now to reduce the churn in the following

Re: [Intel-gfx] [PATCH v2] drm/i915: add schedule out notification of preempted but completed request

2018-03-04 Thread Li, Weinan Z
Any comments? This issue impact the preemption enabling in host, without the schedule out notification, vgpu will run into wrong state. Thanks -Weinan > -Original Message- > From: Li, Weinan Z > Sent: Saturday, February 24, 2018 11:00 AM > To: intel-gfx@lists.freedesktop.org > Cc: intel-gv

Re: [Intel-gfx] [PATCH] drm/i915: Register definitions for DP Phy compiance

2018-03-04 Thread Jani Nikula
On Thu, 01 Mar 2018, clinton.a.tay...@intel.com wrote: > From: Clint Taylor > > DisplayPort Phy compliance test patterns register definitions. > > Signed-off-by: Clint Taylor > --- > drivers/gpu/drm/i915/i915_reg.h | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/driv

Re: [Intel-gfx] [PATCH] drm/i915/dp: clean up leftover references to CHV HBR2 support

2018-03-04 Thread Jani Nikula
On Fri, 02 Mar 2018, Jani Nikula wrote: > No such thing as CHV HBR2. Clean up after commit ed63baaf849e > ("drm/i915: Avoid TP3 on CHV"). > > Reported-by: Ville Syrjälä > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula This is garbage. See Ville's patch [1] instead. BR, Jani. [1] http://pat