On Tue, 02 Jan 2018, Chris Wilson wrote:
> Quoting Rodrigo Vivi (2018-01-02 19:12:18)
>> On Sun, Dec 31, 2017 at 10:34:54PM +, Stefan Brüns wrote:
>> > + edid = drm_get_edid(connector, i2c);
>> > +
>> > + if (!edid && !intel_gmbus_is_forced_bit(i2c)) {
>> > + DRM_DEBUG_KMS(
On 12/28/2017 10:43 PM, Lionel Landwerlin wrote:
On 26/12/17 05:32, Sagar Arun Kamble wrote:
On 12/22/2017 3:46 PM, Lionel Landwerlin wrote:
On 22/12/17 09:30, Sagar Arun Kamble wrote:
On 12/21/2017 6:29 PM, Lionel Landwerlin wrote:
Some more findings I made while playing with this se
For comparison, here's another one produced by the same kernel, on the
same laptop, but a different hard drive.
The OS was installed on a USB stick that I'd boot the laptop off
of. Recently I started getting lags when copying to / from the stick,
so I moved the OS to an external SSD.
Everything e
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/guc : Decoupling ADS and logs
from submission
URL : https://patchwork.freedesktop.org/series/35913/
State : warning
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-pri-indfb-draw-mmap-gtt:
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/guc : Decoupling ADS and logs
from submission
URL : https://patchwork.freedesktop.org/series/35913/
State : success
== Summary ==
Series 35913v1 series starting with [v2,1/2] drm/i915/guc : Decoupling ADS and
logs from submi
Attached. Crashed quite a bit faster than before this time.
It always seems to have something to do with opening and alt-tabbing
between windows. This time what produced the crash was an attempt to
open a new terminal.
The hanging happened right after issuing the keyboard shortcut, before
the foc
Instead of returning -EINVAL, GEM_BUG_ON when GuC reset is invoked for
platforms not supporting as we don't expect to invoke it.
v2: re-wording commit message and subject (Sagar)
Signed-off-by: Sujaritha Sundaresan
Cc: Chris Wilson
Cc: Michal Wajdeczko
Cc: Sagar Arun Kamble
Reviewed-by: Sagar
The Additional Data Struct (ADS) contains objects that are required by
GuC post FW load and are not necessarily submission-only. Even with
submission disabled we may require something inside the ADS, so it
makes more sense for them to be always created.
Similarly, we need to access GuC logs and ev
== Series Details ==
Series: drm/i915: Assert we do not try to wait on an invalid seqno
URL : https://patchwork.freedesktop.org/series/35911/
State : success
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbc-1p-primscrn-spr-indfb-draw-mmap-wc:
pass -> SKIP
On Mon, Jan 01, 2018 at 01:45:32PM +, Lohith BS wrote:
> Dynamic Refresh Rate Switch(DRRS) is used to switch the panel's
> refresh rate to the lowest vrefresh supported by panel, when frame is
> not flipped for more than a Sec.
>
> In kernel, DRRS uses the front buffer tracking infrastructure.
== Series Details ==
Series: drm/i915: Assert we do not try to wait on an invalid seqno
URL : https://patchwork.freedesktop.org/series/35911/
State : success
== Summary ==
Series 35911v1 drm/i915: Assert we do not try to wait on an invalid seqno
https://patchwork.freedesktop.org/api/1.0/series
>-Original Message-
>From: Wajdeczko, Michal
>Sent: Wednesday, December 27, 2017 12:53 PM
>To: intel-gfx@lists.freedesktop.org; Srivatsa, Anusha
>
>Cc: Vivi, Rodrigo
>Subject: Re: [PATCH] drm/i915/glk: Disable Guc and HuC on GLK
>
>On Sat, 23 Dec 2017 01:05:14 +0100, Anusha Srivatsa
> wr
>-Original Message-
>From: Vivi, Rodrigo
>Sent: Thursday, December 28, 2017 8:08 AM
>To: Srivatsa, Anusha
>Cc: intel-gfx@lists.freedesktop.org; Wajdeczko, Michal
>
>Subject: Re: [PATCH] drm/i915/glk: Disable Guc and HuC on GLK
>
>On Sat, Dec 23, 2017 at 12:05:14AM +, Anusha Srivatsa
Quoting Rodrigo Vivi (2018-01-02 19:21:08)
> On Sat, Dec 30, 2017 at 12:53:58PM +, Jiri Kosina wrote:
> > On Sat, 30 Dec 2017, Jiri Kosina wrote:
> >
> > > Seems like disabling RC6 on the kernel command line works this around,
> > > and
> > > I can dock / undock several times in a row with t
We should never insert the invalid seqno into the wait tree, so assert
we do not.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_breadcrumbs.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_breadcrumbs.c
b/drivers/gpu/drm/i915/intel_breadcrumbs.c
in
Quoting Rodrigo Vivi (2018-01-02 19:12:18)
> On Sun, Dec 31, 2017 at 10:34:54PM +, Stefan Brüns wrote:
> > + edid = drm_get_edid(connector, i2c);
> > +
> > + if (!edid && !intel_gmbus_is_forced_bit(i2c)) {
> > + DRM_DEBUG_KMS("HDMI GMBUS EDID read failed, retry using GPIO
>
On Sat, Dec 30, 2017 at 12:53:58PM +, Jiri Kosina wrote:
> On Sat, 30 Dec 2017, Jiri Kosina wrote:
>
> > Seems like disabling RC6 on the kernel command line works this around, and
> > I can dock / undock several times in a row with the image always coming
> > up properly on the external disp
On Sun, Dec 31, 2017 at 10:34:54PM +, Stefan Brüns wrote:
> The ACK/NACK implementation as found in e.g. the G965 has the falling
> clock edge and the release of the data line after the ACK for the received
> byte happen at the same time.
>
> This is conformant with the I2C specification, whic
Hi Josh, Ben, Kyle,
Please consider pulling i915 updates to linux-firmware.git.
The following changes since commit 2567e092339cd3403d697dc2e0967c31b7acb989:
nvidia: add GP108 signed firmware (2017-12-21 08:08:05 -0500)
are available in the git repository at:
https://cgit.freedesktop.org/drm
On Tue, Jan 02, 2018 at 03:12:17PM +, Chris Wilson wrote:
> i915_gem_request_assign() is not used since commit 77f0d0e925e8
> ("drm/i915/execlists: Pack the count into the low bits of the
> port.request"), so remove the defunct code
>
> References: 77f0d0e925e8 ("drm/i915/execlists: Pack the c
On Tue, 2017-12-19 at 13:16 +0100, Maarten Lankhorst wrote:
> This should get rid of unclaimed register debug warnings, if
> it still happens we should put this in a intel_crtc->active check..
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104172
The bugzilla indicates this is a reg
Quoting Alexandru Chirvasitu (2018-01-01 21:13:57)
> All right, we're in business with the new dmesg: It hung again, with a
> 4.15-rc6 kernel with kasan support.
>
> The new dmesg is attached; the trace is longer now, as you expected.
Ok, still the same poison but kasan didn't report a use-after-
== Series Details ==
Series: series starting with [01/19] drm/i915: Delete defunct
i915_gem_request_assign()
URL : https://patchwork.freedesktop.org/series/35907/
State : success
== Summary ==
Test perf:
Subgroup blocking:
pass -> FAIL (shard-hsw) fdo#10225
== Series Details ==
Series: series starting with [01/19] drm/i915: Delete defunct
i915_gem_request_assign()
URL : https://patchwork.freedesktop.org/series/35907/
State : success
== Summary ==
Series 35907v1 series starting with [01/19] drm/i915: Delete defunct
i915_gem_request_assign()
http
Quoting Matthew Auld (2018-01-02 10:36:09)
> On 23 December 2017 at 11:04, Chris Wilson wrote:
> > Reduce the number of GGTT PTE operations to speed the test up, but we
> > reduce the likelihood of spotting a coherency error in those operations.
> > However, Broxton is sporadically timing on this
Since commit 4e773c3a8a69 ("drm/i915: Wire up shrinkctl->nr_scanned"),
we track the number of objects we scan and do not wish to exceed that as
it will overly penalise our own slabs under mempressure. Given that we
now know the target number of objects to scan, use that as our guide for
deciding to
As freeing the objects require serialisation on struct_mutex, we should
prefer to use our singlethreaded driver wq that is dedicated to work
requiring struct_mutex (hence serialised).The benefit should be less
clutter on the system wq, allowing it to make progress even when the
driver/struct_mutex
Even though we wait until the HW has sent us its first CS interrupt
before believing that it is powered on, a read from the powercontext
saved CSB registers may still return garbage. So we must wait a little
bit for the right result. This, of course, assumes that we always see an
invalid result whe
As the timeout mechanism has grown more and more complicated, using
multiple deferred tasks and more than doubling the size of our struct,
split the two implementations to streamline the simpler no-timeout
callback variant.
Signed-off-by: Chris Wilson
Cc: Tvrtko Ursulin
Cc: Joonas Lahtinen
---
Currently, we record the elsp register offset inside init-hw but we only
need to do it once during engine setup (after we know the mmio
iomapping).
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_lrc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/g
When we finally decide the gpu is idle, that is a good time to shrink
our kmem_caches.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
ind
Move the clearing of the CS-interrupt into the engine reset phase,
before the current init-hw phase. This helps clarify that we clear the
pending interrupts prior to any restarting of the execlists.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_lrc.c | 33 +--
We have a hole in our busy-stat accounting if the pmu is enabled during
a long running batch, the pmu will not start accumulating busy-time
until the next context switch. This then fails tests that are only
sampling a single batch.
Signed-off-by: Chris Wilson
Cc: Tvrtko Ursulin
---
drivers/gpu/
By taking advantage of the RCU protection of the request and task
structs, we can find the appropriate signaler under the spinlock and
then release the spinlock before waking the task and signaling the
fence.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_irq.c | 40 ++
Move the register settings for enabling execlists into its own function
for clarity.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_lrc.c | 22 ++
1 file changed, 14 insertions(+), 8 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/drm/i91
To modify the global seqno may require rewriting a few registers, which
requires us to hold the rpm wakeref. We must therefore take it around
the call to i915_gem_set_global_seqno() in debugfs, on behalf of the
user.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_debugfs.c | 3 +++
1
Back up our comment that all signalers should have been signaled before
we ourselves were retired with an assert to that effect.
Signed-off-by: Chris Wilson
Cc: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_gem_request.c | 9 -
drivers/gpu/drm/i915/i915_gem_request.h | 6 ++
drivers
After staring at the list_for_each_safe macros for a bit, our current
invocation of list_safe_reset_next in execlists_schedule() simply
reduces to list_for_each.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_lrc.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git
If we remember to cancel the signaler on a request when retiring it
(after we know that the request has been signaled), we do not need to
carry an additional request in the signaler itself. This prevents an
issue whereby the signaler threads may be delayed and hold on to
thousands of request refere
In preparation for the next patch, move i915_gem_retire_work_handler()
later to avoid a forward declaration.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 228
1 file changed, 114 insertions(+), 114 deletions(-)
diff --git a/drivers/g
i915_gem_request_assign() is not used since commit 77f0d0e925e8
("drm/i915/execlists: Pack the count into the low bits of the
port.request"), so remove the defunct code
References: 77f0d0e925e8 ("drm/i915/execlists: Pack the count into the low bits
of the port.request")
Signed-off-by: Chris Wilso
If we fail to allocate a new request, make sure we recover the pages
that are in the process of being freed by inserting an RCU barrier.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem_request.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_re
Without an accompanying timer (for internal fences), we can free the
fence callback immediately as we do not need to employ the RCU barrier
to serialise with the timer. By avoiding the RCU delay, we can avoid the
extra mempressure under heavy inter-engine request utilisation.
Signed-off-by: Chris
The dependency chain must be an acyclic graph. This is checked by the
swfence, but for sanity, also do a simple check that we do not corrupt
our list iteration in execlists_schedule() by a shallow dependency
cycle.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_lrc.c | 11 ---
== Series Details ==
Series: tests/kms_frontbuffer_tracking: Idleness DRRS coverage (rev5)
URL : https://patchwork.freedesktop.org/series/32888/
State : failure
== Summary ==
Test kms_frontbuffer_tracking:
Subgroup fbc-rgb565-draw-mmap-wc:
pass -> FAIL (shar
On Tue, 28 Nov 2017, Joonas Lahtinen wrote:
> Hello,
>
> TL;DR Reply with backported patches for v4.15-rc1 latest TODAY
>
> Dear patch authors/Cc:s, the following patches failed to cleanly
> backport to v4.15-rc1, if you believe they still are valid patches to
> be included in drm-intel-fixes, ple
== Series Details ==
Series: tests/kms_frontbuffer_tracking: Idleness DRRS coverage (rev5)
URL : https://patchwork.freedesktop.org/series/32888/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
4cd4cc4873fc1c916b6bf7b058b12294e16dfd98 lib: Convert sw_sync to
On 23 December 2017 at 11:04, Chris Wilson wrote:
> From the selftests, we don't want to force an oom and would rather
> ENOMEM be reported. In this case, we would rather the allocation for the
> random array to fail.
>
> Signed-off-by: Chris Wilson
Reviewed-by: Matthew Auld
On 23 December 2017 at 11:04, Chris Wilson wrote:
> Reduce the number of GGTT PTE operations to speed the test up, but we
> reduce the likelihood of spotting a coherency error in those operations.
> However, Broxton is sporadically timing on this test, presumably because
> its GGTT operations are
== Series Details ==
Series: drm/i915: Try EDID bitbanging on HDMI after failed read (rev2)
URL : https://patchwork.freedesktop.org/series/35770/
State : success
== Summary ==
Series 35770v2 drm/i915: Try EDID bitbanging on HDMI after failed read
https://patchwork.freedesktop.org/api/1.0/serie
== Series Details ==
Series: drm: Add generic fbdev emulation
URL : https://patchwork.freedesktop.org/series/35873/
State : warning
== Summary ==
Series 35873v1 drm: Add generic fbdev emulation
https://patchwork.freedesktop.org/api/1.0/series/35873/revisions/1/mbox/
Test core_prop_blob:
== Series Details ==
Series: drm/i915: Fix Limited Range Color Handling (rev2)
URL : https://patchwork.freedesktop.org/series/35725/
State : success
== Summary ==
Series 35725v2 drm/i915: Fix Limited Range Color Handling
https://patchwork.freedesktop.org/api/1.0/series/35725/revisions/2/mbox/
== Series Details ==
Series: drm/i915: remove redundant ELD connector type update
URL : https://patchwork.freedesktop.org/series/35853/
State : success
== Summary ==
Series 35853v1 drm/i915: remove redundant ELD connector type update
https://patchwork.freedesktop.org/api/1.0/series/35853/revis
Op 22-12-17 om 09:55 schreef Mika Kahola:
> On Thu, 2017-12-07 at 14:40 +0100, Maarten Lankhorst wrote:
>> Using the fancy new DRM_CAP_CRTC_IN_VBLANK_EVENT cap I can finally
>> make this test the work I originally intended to.
>>
>> For the !modeset case that means performing a pageflip on both
>>
54 matches
Mail list logo
