[Intel-gfx] ✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking: Correctly handle debugfs errors

2017-11-28 Thread Patchwork
== Series Details == Series: tests/kms_frontbuffer_tracking: Correctly handle debugfs errors URL : https://patchwork.freedesktop.org/series/34555/ State : success == Summary == Blacklisted hosts: shard-hswtotal:2621 pass:1507 dwarn:6 dfail:2 fail:6 skip:1099 time:9215s shard-kbl

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Fix deadlock in i830_disable_pipe()

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Fix deadlock in i830_disable_pipe() URL : https://patchwork.freedesktop.org/series/34553/ State : success == Summary == Blacklisted hosts: shard-hswtotal:2654 pass:1520 dwarn:8 dfail:0 fail:10 skip:1115 time:8970s shard-snbtotal:2554

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/glk: Apply WaProgramL3SqcReg1DefaultForPerf for GLK too (rev4)

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915/glk: Apply WaProgramL3SqcReg1DefaultForPerf for GLK too (rev4) URL : https://patchwork.freedesktop.org/series/33772/ State : success == Summary == Blacklisted hosts: shard-hswtotal:2626 pass:1506 dwarn:11 dfail:0 fail:11 skip:1097 time:9023s s

Re: [Intel-gfx] [PATCH v2 0/3] drm/i915/guc: Update default GuC FW for SKL/BXT/KBL

2017-11-28 Thread Sagar Arun Kamble
On 11/29/2017 12:41 PM, Joonas Lahtinen wrote: On Wed, 2017-11-29 at 11:47 +0530, Sagar Arun Kamble wrote: With new GuC firmwares (SKL v9.33, BXT v9.29, KBL v9.39) available now at 01.org downloads, let us update the default firmware versions. I thought the agreement was for them to be at lin

Re: [Intel-gfx] [PATCH v2 0/3] drm/i915/guc: Update default GuC FW for SKL/BXT/KBL

2017-11-28 Thread Joonas Lahtinen
On Wed, 2017-11-29 at 11:47 +0530, Sagar Arun Kamble wrote: > With new GuC firmwares (SKL v9.33, BXT v9.29, KBL v9.39) available now > at 01.org downloads, let us update the default firmware versions. I thought the agreement was for them to be at linux-firmware repo? Regards, Joonas -- Joonas La

Re: [Intel-gfx] [PATCH 14/15] drm/zte: Use drm_mode_get_hv_timing() to populate plane clip rectangle

2017-11-28 Thread Shawn Guo
On Thu, Nov 23, 2017 at 09:05:01PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Use drm_mode_get_hv_timing() to fill out the plane clip rectangle. > > Note that this replaces crtc_state->adjusted_mode usage with > crtc_state->mode. The latter is the correct choice since that's the > mod

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Update default GuC FW for SKL/BXT/KBL

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915/guc: Update default GuC FW for SKL/BXT/KBL URL : https://patchwork.freedesktop.org/series/34590/ State : success == Summary == Series 34590v1 drm/i915/guc: Update default GuC FW for SKL/BXT/KBL https://patchwork.freedesktop.org/api/1.0/series/34590/revisio

[Intel-gfx] [PATCH v2 2/3] drm/i915/guc: Change default GuC FW for BXT to v9.29

2017-11-28 Thread Sagar Arun Kamble
This patch makes v9.29 firmware as default firmware for BXT. Note: GuC logging control is changed with this firmware. GuC is expecting i915 to set control bit to enable "default logging" while using GuC action UK_LOG_ENABLE_LOGGING. However i915 is currently not doing this because it is version sp

[Intel-gfx] [PATCH v2 1/3] drm/i915/guc: Change default GuC FW for SKL to v9.33

2017-11-28 Thread Sagar Arun Kamble
This patch makes v9.33 firmware as default firmware for SKL. Note: GuC logging control is changed with this firmware. GuC is expecting i915 to set control bit to enable "default logging" while using GuC action UK_LOG_ENABLE_LOGGING. However i915 is currently not doing this because it is version sp

[Intel-gfx] [PATCH v2 3/3] drm/i915/guc: Change default GuC FW for KBL to v9.39

2017-11-28 Thread Sagar Arun Kamble
This patch makes v9.39 firmware as default firmware for KBL. Note: GuC logging control is changed with this firmware. GuC is expecting i915 to set control bit to enable "default logging" while using GuC action UK_LOG_ENABLE_LOGGING. However i915 is currently not doing this because it is version sp

[Intel-gfx] [PATCH v2 0/3] drm/i915/guc: Update default GuC FW for SKL/BXT/KBL

2017-11-28 Thread Sagar Arun Kamble
With new GuC firmwares (SKL v9.33, BXT v9.29, KBL v9.39) available now at 01.org downloads, let us update the default firmware versions. Cc: Spotswood John A Cc: Anusha Srivatsa Cc: Michal Wajdeczko Cc: Rodrigo Vivi Cc: Joonas Lahtinen Sagar Arun Kamble (3): drm/i915/guc: Change default Gu

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Impletments dynamic WOPCM partitioning.

2017-11-28 Thread Yaodong Li
On 11/15/2017 09:58 AM, Chris Wilson wrote: Quoting Jackie Li (2017-11-15 17:17:08) Static WOPCM partitioning will lead to GuC loading failure if the GuC/HuC firmware size exceeded current static 512KB partition boundary. This patch enables the dynamical calculation of the WOPCM aperture used b

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Impletments dynamic WOPCM partitioning.

2017-11-28 Thread Yaodong Li
On 11/16/2017 08:00 PM, Sagar Arun Kamble wrote: On 11/17/2017 3:17 AM, Michal Wajdeczko wrote: On Thu, 16 Nov 2017 08:34:01 +0100, Sagar Arun Kamble wrote: Typo in the subject. GLK showing failure to load GuC with this approach on CI. On 11/15/2017 10:47 PM, Jackie Li wrote: Static WOPC

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Impletments dynamic WOPCM partitioning.

2017-11-28 Thread Yaodong Li
On 11/16/2017 01:47 PM, Michal Wajdeczko wrote: On Thu, 16 Nov 2017 08:34:01 +0100, Sagar Arun Kamble wrote: Typo in the subject. GLK showing failure to load GuC with this approach on CI. On 11/15/2017 10:47 PM, Jackie Li wrote: Static WOPCM partitioning will lead to GuC loading failure if

[Intel-gfx] ✗ Fi.CI.BAT: failure for intel_aubdump: Add ability to simulate execlist submission

2017-11-28 Thread Patchwork
== Series Details == Series: intel_aubdump: Add ability to simulate execlist submission URL : https://patchwork.freedesktop.org/series/34572/ State : failure == Summary == IGT patchset build failed on latest successful build 380cc811486ba3fefbe3ebe4761afa7e169dcd3e tests/perf_pmu: Sync invalid

[Intel-gfx] [PATCH i-g-t] intel_aubdump: Add ability to simulate execlist submission

2017-11-28 Thread Scott D Phillips
Newer devices do not have the legacy ring buffer submission model, so aub files generated using that model cannot be handled by some internal tools. The execlist submission modeled by this change is pretty simplistic, using GGTT only and synchronizing after every batch. --- tools/aubdump.c | 422 +

[Intel-gfx] [PATCH libdrm] intel/aub: Add new MEM_TRACE commands

2017-11-28 Thread Scott D Phillips
The memtrace aub commands are similar to the existing ones, but different. Notably memtrace has commands for register write and poll. --- intel/intel_aub.h | 26 ++ 1 file changed, 26 insertions(+) diff --git a/intel/intel_aub.h b/intel/intel_aub.h index 5f0aba8e..9ca548ed

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: apply Display WA #1178 to fix type C dongles

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915/cnl: apply Display WA #1178 to fix type C dongles URL : https://patchwork.freedesktop.org/series/34566/ State : success == Summary == Series 34566v1 drm/i915/cnl: apply Display WA #1178 to fix type C dongles https://patchwork.freedesktop.org/api/1.0/series

Re: [Intel-gfx] [PATCH v6 6/7] efifb: Set info->fbcon_rotate_hint based on drm_get_panel_orientation_quirk

2017-11-28 Thread kbuild test robot
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.15-rc1 next-20171128] [cannot apply to linus/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

[Intel-gfx] [PATCH] drm/i915/cnl: apply Display WA #1178 to fix type C dongles

2017-11-28 Thread Lucas De Marchi
Display WA #1178 is meant to fix Aux channel voltage swing too low with some type C dongles. Although it is for type C, HW engineers reported that it can be applied to all external ports even if they are not going to type C. For CNL we apply the workaround every time Aux B, C and D are powering up

Re: [Intel-gfx] [PATCH 3/4] drm/i915: expose engine availability through sysfs

2017-11-28 Thread Chris Wilson
Quoting Chris Wilson (2017-11-28 20:56:23) > Quoting Tvrtko Ursulin (2017-11-28 18:17:54) > > > > On 20/11/2017 12:23, Lionel Landwerlin wrote: > > > This enables userspace to discover the engines available on the GPU. > > > Here is the layout on a Skylake GT4: > > > > > > /sys/devices/pci:00

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: follow single notation for workaround number

2017-11-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: follow single notation for workaround number URL : https://patchwork.freedesktop.org/series/34563/ State : success == Summary == Series 34563v1 series starting with [1/2] drm/i915: follow single notation for workaround number

[Intel-gfx] [PATCH 2/2] drm/i915: add platform tag to WA

2017-11-28 Thread Lucas De Marchi
Cc: Ville Syrjälä Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_hdmi.c index 691600ce48c4..c42a6c672b73 100644 --- a/drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH 1/2] drm/i915: follow single notation for workaround number

2017-11-28 Thread Lucas De Marchi
Cc: Ville Syrjälä Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_hdmi.c| 2 +- drivers/gpu/drm/i915/intel_pm.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drive

Re: [Intel-gfx] [PATCH v6 6/7] efifb: Set info->fbcon_rotate_hint based on drm_get_panel_orientation_quirk

2017-11-28 Thread kbuild test robot
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on drm/drm-next] [also build test ERROR on v4.15-rc1 next-20171128] [cannot apply to linus/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [Intel-gfx] [PATCH] drm/i915: Fix deadlock in i830_disable_pipe()

2017-11-28 Thread Chris Wilson
Quoting Ville Syrjala (2017-11-28 15:48:53) > From: Ville Syrjälä > > i830_disable_pipe() gets called from the power well code, and thus > we're already holding the power domain mutex. That means we can't > call plane->get_hw_state() as it will also try to grab the > same mutex and will thus dead

Re: [Intel-gfx] [PATCH 3/4] drm/i915: expose engine availability through sysfs

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 18:17:54) > > On 20/11/2017 12:23, Lionel Landwerlin wrote: > > This enables userspace to discover the engines available on the GPU. > > Here is the layout on a Skylake GT4: > > > > /sys/devices/pci:00/:00:02.0/drm/card0/gt > > On this one I think Joona

Re: [Intel-gfx] [PATCH i-g-t 2/3] lib/igt_sysfs: igt_sysfs_path only works for master nodes

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 18:09:56) > From: Tvrtko Ursulin > > DRM code defines the minor range for master nodes as 0-63, so express that > explicitly near the top of the function. We do use rendernodes, so we had better support them correctly. I thought the premise of /sys/dev/char/$ma

Re: [Intel-gfx] [PATCH i-g-t 1/3] lib/igt_sysfs: Remove support for finding sysfs path with no device opened

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 18:09:55) > From: Tvrtko Ursulin > > It looks like no callers actually use this so remove it to simplify. We just added more users to the equivalent for debugfs, and accepting -1 here was simply to have consistency with our debugfs api. If that makes any diffe

Re: [Intel-gfx] [PATCH v6 5/7] drm/i915: Add "panel orientation" property to the panel connector, v6.

2017-11-28 Thread kbuild test robot
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc1 next-20171128] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[Intel-gfx] ✓ Fi.CI.BAT: success for Simplify hunting for drm card sysfs root

2017-11-28 Thread Patchwork
== Series Details == Series: Simplify hunting for drm card sysfs root URL : https://patchwork.freedesktop.org/series/34559/ State : success == Summary == IGT patchset tested on top of latest successful build 380cc811486ba3fefbe3ebe4761afa7e169dcd3e tests/perf_pmu: Sync invalid-init with i915

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Fix doc reference to intel_guc_fw.c

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915/guc: Fix doc reference to intel_guc_fw.c URL : https://patchwork.freedesktop.org/series/34557/ State : success == Summary == Series 34557v1 drm/i915/guc: Fix doc reference to intel_guc_fw.c https://patchwork.freedesktop.org/api/1.0/series/34557/revisions/1

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] lockdep: finer-grained completion key for kthread

2017-11-28 Thread Patchwork
== Series Details == Series: series starting with [1/2] lockdep: finer-grained completion key for kthread URL : https://patchwork.freedesktop.org/series/34556/ State : success == Summary == Series 34556v1 series starting with [1/2] lockdep: finer-grained completion key for kthread https://pa

Re: [Intel-gfx] [PATCH 3/4] drm/i915: expose engine availability through sysfs

2017-11-28 Thread Tvrtko Ursulin
On 20/11/2017 12:23, Lionel Landwerlin wrote: > This enables userspace to discover the engines available on the GPU. > Here is the layout on a Skylake GT4: > > /sys/devices/pci:00/:00:02.0/drm/card0/gt On this one I think Joonas had a concern that it is difficult for userspace to get to

[Intel-gfx] [PATCH i-g-t 2/3] lib/igt_sysfs: igt_sysfs_path only works for master nodes

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin DRM code defines the minor range for master nodes as 0-63, so express that explicitly near the top of the function. Signed-off-by: Tvrtko Ursulin --- lib/igt_sysfs.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c index dd057dc0494

[Intel-gfx] [PATCH i-g-t 1/3] lib/igt_sysfs: Remove support for finding sysfs path with no device opened

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It looks like no callers actually use this so remove it to simplify. Signed-off-by: Tvrtko Ursulin --- lib/igt_sysfs.c | 39 --- 1 file changed, 16 insertions(+), 23 deletions(-) diff --git a/lib/igt_sysfs.c b/lib/igt_sysfs.c index e7c6

[Intel-gfx] [PATCH i-g-t 0/3] Simplify hunting for drm card sysfs root

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Short series to clean up the code and bit. Thanks to Lionel for pointing out the convenient /sys/dev/char/: symlink. Tvrtko Ursulin (3): lib/igt_sysfs: Remove support for finding sysfs path with no device opened lib/igt_sysfs: igt_sysfs_path only works for master no

[Intel-gfx] [PATCH i-g-t 3/3] lib/igt_sysfs: Simplify igt_sysfs_path

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin There is no need to iterate over /sys/class/drm/card* directories looking for the one which matches our major and minor, when we can directly find the right one via the /sys/dev/char/: symlink. Signed-off-by: Tvrtko Ursulin Suggested-by: Lionel Landwerlin --- lib/igt_sysf

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Move execlists setup out of common

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 17:29:25) > > On 28/11/2017 16:04, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-11-28 13:07:54) > >> > >> On 28/11/2017 12:48, Chris Wilson wrote: > >>> Quoting Tvrtko Ursulin (2017-11-28 12:41:27) > From: Tvrtko Ursulin > > Move the execl

[Intel-gfx] [PATCH] drm/i915/guc: Fix doc reference to intel_guc_fw.c

2017-11-28 Thread Jonathan Neuschäfer
Sphinx complains that it can't find intel_guc_loader.c, and rightly so: The file has been renamed. Fixes: e8668bbcb0f9 ("drm/i915/guc: Rename intel_guc_loader.c to intel_guc_fw.c") Cc: Michal Wajdeczko Signed-off-by: Jonathan Neuschäfer --- Documentation/gpu/i915.rst | 4 ++-- 1 file changed,

Re: [Intel-gfx] [PATCH V3 24/29] backlight: deprecate pci_get_bus_and_slot()

2017-11-28 Thread Jingoo Han
On Monday, November 27, 2017 11:58 AM, Sinan Kaya wrote: > > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. I think that this will be useful. I introduced multi doma

Re: [Intel-gfx] [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Thomas Voegtle
On Tue, 28 Nov 2017, Daniel Vetter wrote: On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: Some drivers like i915 start with crtc's enabled, but with deferred fbcon setup they were no longer disabled as part of fbdev setup. Headless units could no longer enter pc3 state becaus

Re: [Intel-gfx] [PATCH] drm/i915/guc: Fix doc reference to intel_guc_fw.c

2017-11-28 Thread Jonathan Neuschäfer
On Tue, Nov 28, 2017 at 09:51:13AM +0100, Michal Wajdeczko wrote: > On Tue, 28 Nov 2017 07:50:52 +0100, Jonathan Neuschäfer > wrote: > > > Sphinx complains that it can't find intel_guc_loader.c, and rightly so: > > The file has been renamed. > > > > Fixes: e8668bbcb0f9 ("drm/i915/guc: Rename int

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Correctly handle debugfs errors

2017-11-28 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-11-28 17:01:15) > In commit 3f6ae7b19 ("igt/kms_frontbuffer_tracking: Keep the debugfs > dir around") we introduced custom variant of __igt_debugfs_read function > that fires assert when debugfs returns an error. Replace that assert > with proper error handling to all

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Move execlists setup out of common

2017-11-28 Thread Tvrtko Ursulin
On 28/11/2017 16:04, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-28 13:07:54) On 28/11/2017 12:48, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-28 12:41:27) From: Tvrtko Ursulin Move the execlists specific setup out of intel_engine_setup_common. This was supposed to be only

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Correctly handle debugfs errors

2017-11-28 Thread Patchwork
== Series Details == Series: tests/kms_frontbuffer_tracking: Correctly handle debugfs errors URL : https://patchwork.freedesktop.org/series/34555/ State : success == Summary == IGT patchset tested on top of latest successful build 5b3619f3751ecef55fa993984ddb59a458fcebed igt: Remove gem_ctx_ba

Re: [Intel-gfx] [PATCH 2/2] lockdep: Up MAX_LOCKDEP_CHAINS

2017-11-28 Thread Chris Wilson
Quoting Daniel Vetter (2017-11-28 17:07:07) > cross-release ftl Fwiw, this isn't cross-release but us reloading the module many times, creating a whole host of new lockclasses. Even more fun is when the module gets a slightly different address and the new lock address hashes into an old lock... I

Re: [Intel-gfx] [PATCH v4] drm/i915: Expose the busyspin durations for i915_wait_request

2017-11-28 Thread Tvrtko Ursulin
On 27/11/2017 10:10, Chris Wilson wrote: An interesting discussion regarding "hybrid interrupt polling" for NVMe came to the conclusion that the ideal busyspin before sleeping was half of the expected request latency (and better if it was already halfway through that request). This suggested tha

Re: [Intel-gfx] [PATCH v3 2/2] drm/i915: Increase busyspin limit before a context-switch

2017-11-28 Thread Tvrtko Ursulin
On 26/11/2017 12:20, Chris Wilson wrote: Looking at the distribution of i915_wait_request for a set of GL benchmarks, we see: broadwell# python bcc/tools/funclatency.py -u i915_wait_request usecs : count distribution 0 -> 1 : 29184|

Re: [Intel-gfx] [PATCH] drm/i915: Unifying debugfs return codes for unsupported features

2017-11-28 Thread Sujaritha
On 11/28/2017 07:42 AM, Michal Wajdeczko wrote: Instead of trying different seq_puts messages, lets use common -ENODEV error code to indicate missing/unsupported feature. I agree that this is the simplest way to unify the message. Regards, Sujaritha Suggested-by: Chris Wilson Signed-off-by

[Intel-gfx] [PATCH 1/2] lockdep: finer-grained completion key for kthread

2017-11-28 Thread Daniel Vetter
Ideally we'd create the key through a macro at the real callers and pass it all the way down. This would give us better coverage for cases where a bunch of kthreads are created for the same thing. But this gets the job done meanwhile and unblocks our CI. Refining later on is always possible. v2: -

[Intel-gfx] [PATCH 2/2] lockdep: Up MAX_LOCKDEP_CHAINS

2017-11-28 Thread Daniel Vetter
cross-release ftl Cc: Tvrtko Ursulin Cc: Marta Lofstedt References: https://bugs.freedesktop.org/show_bug.cgi?id=103707 Signed-off-by: Daniel Vetter --- kernel/locking/lockdep_internals.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/locking/lockdep_internals.h b/

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Return -EINVAL when selecting the inactive CPU

2017-11-28 Thread Tvrtko Ursulin
On 28/11/2017 11:14, Patchwork wrote: == Series Details == Series: drm/i915/pmu: Return -EINVAL when selecting the inactive CPU URL : https://patchwork.freedesktop.org/series/34529/ State : success == Summary == Series 34529v1 drm/i915/pmu: Return -EINVAL when selecting the inactive CPU htt

[Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Correctly handle debugfs errors

2017-11-28 Thread Michal Wajdeczko
In commit 3f6ae7b19 ("igt/kms_frontbuffer_tracking: Keep the debugfs dir around") we introduced custom variant of __igt_debugfs_read function that fires assert when debugfs returns an error. Replace that assert with proper error handling to allow use of errors like -ENODEV. Signed-off-by: Michal W

Re: [Intel-gfx] [PATCH v6 5/7] drm/i915: Add "panel orientation" property to the panel connector, v6.

2017-11-28 Thread kbuild test robot
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc1 next-20171128] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Unifying debugfs return codes for unsupported features

2017-11-28 Thread Michal Wajdeczko
On Tue, 28 Nov 2017 17:07:27 +0100, Patchwork wrote: == Series Details == Series: drm/i915: Unifying debugfs return codes for unsupported features URL : https://patchwork.freedesktop.org/series/34552/ State : failure == Summary == Series 34552v1 drm/i915: Unifying debugfs return codes fo

Re: [Intel-gfx] [PATCH V3 09/29] drm/i915: deprecate pci_get_bus_and_slot()

2017-11-28 Thread Sinan Kaya
On 11/28/2017 10:30 AM, Ville Syrjälä wrote: >> +dev_priv->bridge_dev = >> +pci_get_domain_bus_and_slot(domain, 0, PCI_DEVFN(0, 0)); > Maybe just pci_get_slot(pdev->bus, PCI_DEVFN(0, 0)) ? > > I guess if we want to be pedantic we could go for: > > bus = pci_find_host_bridge(pdev->

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix deadlock in i830_disable_pipe()

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Fix deadlock in i830_disable_pipe() URL : https://patchwork.freedesktop.org/series/34553/ State : success == Summary == Series 34553v1 drm/i915: Fix deadlock in i830_disable_pipe() https://patchwork.freedesktop.org/api/1.0/series/34553/revisions/1/mbox/

Re: [Intel-gfx] [PATCH] drm/i915: Unifying debugfs return codes for unsupported features

2017-11-28 Thread Sujaritha
On 11/28/2017 07:42 AM, Michal Wajdeczko wrote: Instead of trying different seq_puts messages, lets use common -ENODEV error code to indicate missing/unsupported feature. I agree that this is the simplest way to unify Suggested-by: Chris Wilson Signed-off-by: Michal Wajdeczko Cc: Chris Wil

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Unifying debugfs return codes for unsupported features

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Unifying debugfs return codes for unsupported features URL : https://patchwork.freedesktop.org/series/34552/ State : failure == Summary == Series 34552v1 drm/i915: Unifying debugfs return codes for unsupported features https://patchwork.freedesktop.org/ap

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Move execlists setup out of common

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 13:07:54) > > On 28/11/2017 12:48, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-11-28 12:41:27) > >> From: Tvrtko Ursulin > >> > >> Move the execlists specific setup out of intel_engine_setup_common. This > >> was supposed to be only for backend agnostic

[Intel-gfx] ✗ Fi.CI.BAT: failure for lockdep: finer-grained completion key for kthread

2017-11-28 Thread Patchwork
== Series Details == Series: lockdep: finer-grained completion key for kthread URL : https://patchwork.freedesktop.org/series/34547/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h

[Intel-gfx] [PATCH] drm/i915: Fix deadlock in i830_disable_pipe()

2017-11-28 Thread Ville Syrjala
From: Ville Syrjälä i830_disable_pipe() gets called from the power well code, and thus we're already holding the power domain mutex. That means we can't call plane->get_hw_state() as it will also try to grab the same mutex and will thus deadlock. Replace the assert_plane() calls (which calls ->g

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915: Move execlists setup out of common (rev3)

2017-11-28 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Move execlists setup out of common (rev3) URL : https://patchwork.freedesktop.org/series/34541/ State : success == Summary == Blacklisted hosts: shard-hswtotal:2643 pass:1514 dwarn:6 dfail:2 fail:17 skip:1103 time

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/glk: Apply WaProgramL3SqcReg1DefaultForPerf for GLK too (rev4)

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915/glk: Apply WaProgramL3SqcReg1DefaultForPerf for GLK too (rev4) URL : https://patchwork.freedesktop.org/series/33772/ State : success == Summary == Series 33772v4 drm/i915/glk: Apply WaProgramL3SqcReg1DefaultForPerf for GLK too https://patchwork.freedesktop

[Intel-gfx] [PATCH] drm/i915: Unifying debugfs return codes for unsupported features

2017-11-28 Thread Michal Wajdeczko
Instead of trying different seq_puts messages, lets use common -ENODEV error code to indicate missing/unsupported feature. Suggested-by: Chris Wilson Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Sagar Arun Kamble Cc: Sujaritha Sundaresan --- drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Fix for nested_enable_signaling BUG_ON

2017-11-28 Thread John Harrison
On 11/28/2017 1:40 AM, Chris Wilson wrote: Quoting john.c.harri...@intel.com (2017-11-28 09:10:59) From: John Harrison The call to enable signaling was occuring after the request had been sent to the GuC for execution on the hardware. That means that it is possible for the request to actually

Re: [Intel-gfx] [PATCH v6 6/7] efifb: Set info->fbcon_rotate_hint based on drm_get_panel_orientation_quirk

2017-11-28 Thread kbuild test robot
Hi Hans, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc1 next-20171128] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [Intel-gfx] [PATCH V3 09/29] drm/i915: deprecate pci_get_bus_and_slot()

2017-11-28 Thread Ville Syrjälä
On Mon, Nov 27, 2017 at 11:57:46AM -0500, Sinan Kaya wrote: > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove pci_get_bus_and_slot() functi

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Enable hotplug polling after registering the outputs (rev2)

2017-11-28 Thread Chris Wilson
Quoting Patchwork (2017-11-28 13:08:29) > == Series Details == > > Series: drm/i915: Enable hotplug polling after registering the outputs (rev2) > URL : https://patchwork.freedesktop.org/series/34445/ > State : success Maarten acked v2, so applied. At the worst it's an improvement which we'll h

Re: [Intel-gfx] [PATCH] drm/i915/cnl: WA Display #1178 to fix some type C dongles

2017-11-28 Thread Ville Syrjälä
On Mon, Nov 27, 2017 at 03:14:21PM -0800, Lucas De Marchi wrote: > On Thu, Nov 23, 2017 at 7:21 AM, Ville Syrjälä > wrote: > > On Wed, Nov 22, 2017 at 10:55:14AM -0800, Lucas De Marchi wrote: > >> WA Display #1178 is meant to fix Aux channel voltage swing too low with > >> some type C dongles. Alt

[Intel-gfx] [PATCH] lockdep: finer-grained completion key for kthread

2017-11-28 Thread Daniel Vetter
Ideally we'd create the key through a macro at the real callers and pass it all the way down. This would give us better coverage for cases where a bunch of kthreads are created for the same thing. But this gets the job done meanwhile and unblocks our CI. Refining later on is always possible. Signe

Re: [Intel-gfx] [GIT PULL] gvt fixes for 4.15-rc2

2017-11-28 Thread Joonas Lahtinen
Hi, Pulled these in. There was a pretty big conflict to drm-tip which I solved. Please give it some additional testing as I only compile tested. Regards, Joonas On Tue, 2017-11-28 at 17:31 +0800, Zhenyu Wang wrote: > Hi, > > Pls pull gvt fixes for 4.15-rc2, which contains one backport > from f2

[Intel-gfx] [PATCH v4] drm/i915/glk: Apply WaProgramL3SqcReg1DefaultForPerf for GLK too

2017-11-28 Thread Valtteri Rantala
Testing the texture read performance shows that the same tuning for the SQ credits is needed on GLK as on BXT/APL. This has been also confirmed by Altug from the HW team. V4: Rebase + fix Signed-off-by: Valtteri Rantala --- drivers/gpu/drm/i915/intel_engine_cs.c | 16 +--- 1 file cha

Re: [Intel-gfx] [PATCH] drm: Fix modifiers_property kernel-doc comment

2017-11-28 Thread Hans de Goede
Hi, On 28-11-17 11:28, Daniel Vetter wrote: On Sat, Nov 25, 2017 at 08:27:31PM +0100, Hans de Goede wrote: This fixes the following make kerneldocs messages: ./include/drm/drm_mode_config.h:772: warning: No description found for parameter 'modifiers_property' ./include/drm/drm_mode_config.h:7

[Intel-gfx] ✓ Fi.CI.IGT: success for tests/perf_pmu: Sync invalid-init with i915 changes

2017-11-28 Thread Patchwork
== Series Details == Series: tests/perf_pmu: Sync invalid-init with i915 changes URL : https://patchwork.freedesktop.org/series/34530/ State : success == Summary == Blacklisted hosts: shard-apltotal:2348 pass:1453 dwarn:20 dfail:18 fail:10 skip:838 time:10677s shard-hswtota

Re: [Intel-gfx] [PATCH V3 03/29] x86/PCI: deprecate pci_get_bus_and_slot()

2017-11-28 Thread Thomas Gleixner
On Mon, 27 Nov 2017, Sinan Kaya wrote: > pci_get_bus_and_slot() is restrictive such that it assumes domain=0 as > where a PCI device is present. This restricts the device drivers to be > reused for other domain numbers. > > Getting ready to remove pci_get_bus_and_slot() function in favor of > pc

Re: [Intel-gfx] [PATCH v6 0/7] drm/fbdev: Panel orientation connector property support

2017-11-28 Thread Hans de Goede
Hi, On 28-11-17 11:27, Daniel Vetter wrote: On Sat, Nov 25, 2017 at 06:33:34PM +0100, Hans de Goede wrote: Hi All, Here is v6 of my series to add a "panel orientation" property to the drm-connector for the LCD panel to let userspace know about LCD panels which are not mounted upright, as well

Re: [Intel-gfx] [PATCH v2] drm/i915: Enable hotplug polling after registering the outputs

2017-11-28 Thread Chris Wilson
Quoting Chris Wilson (2017-11-28 13:02:09) > Quoting Chris Wilson (2017-11-28 11:01:47) > > @@ -1266,6 +1271,13 @@ static void i915_driver_unregister(struct > > drm_i915_private *dev_priv) > > intel_fbdev_unregister(dev_priv); > > intel_audio_deinit(dev_priv); > > > > + /*

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] drm/i915: Move execlists setup out of common (rev3)

2017-11-28 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Move execlists setup out of common (rev3) URL : https://patchwork.freedesktop.org/series/34541/ State : success == Summary == Series 34541v3 series starting with [1/4] drm/i915: Move execlists setup out of common https://patch

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Patchwork
== Series Details == Series: drm/fb_helper: Disable all crtc's when initial setup fails. URL : https://patchwork.freedesktop.org/series/34532/ State : success == Summary == Blacklisted hosts: shard-hswtotal:2662 pass:1528 dwarn:8 dfail:2 fail:8 skip:1116 time:9259s shard-kbl

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Enable hotplug polling after registering the outputs (rev2)

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915: Enable hotplug polling after registering the outputs (rev2) URL : https://patchwork.freedesktop.org/series/34445/ State : success == Summary == Blacklisted hosts: shard-apltotal:2509 pass:1582 dwarn:15 dfail:11 fail:13 skip:883 time:11204s sha

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Move execlists setup out of common

2017-11-28 Thread Tvrtko Ursulin
On 28/11/2017 12:48, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-28 12:41:27) From: Tvrtko Ursulin Move the execlists specific setup out of intel_engine_setup_common. This was supposed to be only for backend agnostic bits. At the same time rename it to intel_engine_setup_execlist to f

[Intel-gfx] [PATCH v2 4/4] drm/i915: Add GuC support for engine busy stats

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Wire up the engine busy stats accounting to the GuC submission backend. Since there is not context out interrupt we need to place the accounting callbacks per-request. v2: Rebase. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_guc_submission.c | 4 ++-- 1 f

[Intel-gfx] [PATCH v4 3/4] drm/i915: Consolidate checks for engine stats availability

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Sagar noticed the check can be consolidated between the engine stats implementation and the PMU. My first choice was a static inline helper but that got into include ordering mess quickly fast so I went with a macro instead. At some point we should perhaps looking into takin

Re: [Intel-gfx] [PATCH v2] drm/i915: Enable hotplug polling after registering the outputs

2017-11-28 Thread Chris Wilson
Quoting Chris Wilson (2017-11-28 11:01:47) > @@ -1266,6 +1271,13 @@ static void i915_driver_unregister(struct > drm_i915_private *dev_priv) > intel_fbdev_unregister(dev_priv); > intel_audio_deinit(dev_priv); > > + /* > +* After flushing the fbdev (incl. a late async

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Consolidate checks for engine stats availability

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 12:41:29) > diff --git a/drivers/gpu/drm/i915/intel_guc_submission.c > b/drivers/gpu/drm/i915/intel_guc_submission.c > index cf1cc2cb6722..a8e63779de79 100644 > --- a/drivers/gpu/drm/i915/intel_guc_submission.c > +++ b/drivers/gpu/drm/i915/intel_guc_submission.c

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Move execlists setup out of common

2017-11-28 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-11-28 12:41:27) > From: Tvrtko Ursulin > > Move the execlists specific setup out of intel_engine_setup_common. This > was supposed to be only for backend agnostic bits. At the same time rename > it to intel_engine_setup_execlist to follow the setup vs init naming > co

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/pmu: Return -EINVAL when selecting the inactive CPU

2017-11-28 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Return -EINVAL when selecting the inactive CPU URL : https://patchwork.freedesktop.org/series/34529/ State : failure == Summary == Test gem_exec_capture: Subgroup capture-blt: pass -> DMESG-WARN (shard-snb) fdo#103950 +9

[Intel-gfx] [PATCH 2/4] drm/i915: Move engine->needs_cmd_parser to engine->flags

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Will be adding a new per-engine flags shortly so it makes sense to consolidate. v2: Keep the original code flow in intel_engine_cleanup_cmd_parser. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Suggested-by: Chris Wilson Reviewed-by: Chris Wilson Reviewed-by: Sagar

[Intel-gfx] [PATCH 3/4] drm/i915: Consolidate checks for engine stats availability

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Sagar noticed the check can be consolidated between the engine stats implementation and the PMU. My first choice was a static inline helper but that got into include ordering mess quickly fast so I went with a macro instead. At some point we should perhaps looking into takin

[Intel-gfx] [PATCH 4/4] drm/i915: Add GuC support for engine busy stats

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Wire up the engine busy stats accounting to the GuC submission backend. Since there is not context out interrupt we need to place the accounting callbacks per-request. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_guc_submission.c | 9 ++--- 1 file chan

[Intel-gfx] [PATCH 1/4] drm/i915: Move execlists setup out of common

2017-11-28 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Move the execlists specific setup out of intel_engine_setup_common. This was supposed to be only for backend agnostic bits. At the same time rename it to intel_engine_setup_execlist to follow the setup vs init naming convetion we have. Signed-off-by: Tvrtko Ursulin --- dri

[Intel-gfx] ✗ Fi.CI.BAT: warning for igt: Remove gem_ctx_basic (rev2)

2017-11-28 Thread Patchwork
== Series Details == Series: igt: Remove gem_ctx_basic (rev2) URL : https://patchwork.freedesktop.org/series/34500/ State : warning == Summary == IGT patchset tested on top of latest successful build 53f2b4b4ce2372da0b3b741d934dd5a9110ac1e2 igt/perf_pmu: Keep batch_duration_ns as the minimum

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Revert "x86/irq: Simplify hotplug vector accounting"

2017-11-28 Thread Chris Wilson
Quoting Patchwork (2017-11-28 12:22:22) > == Series Details == > > Series: Revert "x86/irq: Simplify hotplug vector accounting" > URL : https://patchwork.freedesktop.org/series/34527/ > State : failure And still the do_IRQ failures and what appears to be lost interrupts. This was not the patch

[Intel-gfx] ✗ Fi.CI.IGT: failure for Revert "x86/irq: Simplify hotplug vector accounting"

2017-11-28 Thread Patchwork
== Series Details == Series: Revert "x86/irq: Simplify hotplug vector accounting" URL : https://patchwork.freedesktop.org/series/34527/ State : failure == Summary == Test prime_busy: Subgroup wait-hang-bsd: pass -> DMESG-WARN (shard-hsw) Subgroup hang-bsd:

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/perf_pmu: Sync invalid-init with i915 changes

2017-11-28 Thread Patchwork
== Series Details == Series: tests/perf_pmu: Sync invalid-init with i915 changes URL : https://patchwork.freedesktop.org/series/34530/ State : success == Summary == IGT patchset tested on top of latest successful build 53f2b4b4ce2372da0b3b741d934dd5a9110ac1e2 igt/perf_pmu: Keep batch_duration_

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Patchwork
== Series Details == Series: drm/fb_helper: Disable all crtc's when initial setup fails. URL : https://patchwork.freedesktop.org/series/34532/ State : success == Summary == Series 34532v1 drm/fb_helper: Disable all crtc's when initial setup fails. https://patchwork.freedesktop.org/api/1.0/seri

Re: [Intel-gfx] [PATCH i-g-t] igt/kms_rotation_crc: Add RGB565 90 degree test for gen>9

2017-11-28 Thread Maarten Lankhorst
Hey, Op 21-11-17 om 15:02 schreef Juha-Pekka Heikkila: > Gen10 onwards 90 and 270 degree rotations are supported for RGB565 format. > > v2 (Ville Syrjälä): > As a side effect to keep bad-pixel-format test valid on all supported > platforms it need to use DRM_FORMAT_C8 now. > > While at it clean up

Re: [Intel-gfx] [PATCH] drm/fb_helper: Disable all crtc's when initial setup fails.

2017-11-28 Thread Daniel Vetter
On Tue, Nov 28, 2017 at 12:16:03PM +0100, Maarten Lankhorst wrote: > Some drivers like i915 start with crtc's enabled, but with deferred > fbcon setup they were no longer disabled as part of fbdev setup. > Headless units could no longer enter pc3 state because the crtc was > still enabled. > > Fix

  1   2   >