Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/cnl: WaDisableGatherAtSetShaderCommonSlice (rev2)

2017-10-08 Thread Lofstedt, Marta
Hi, It appear that both this patchwork and Paulos: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_5919/ Hit the same issue for the fi-kbl-7500u. I created: https://bugs.freedesktop.org/show_bug.cgi?id=103155 and marked it in cibuglog. Thanks for your feedback. /Marta __

Re: [Intel-gfx] [PATCH i-g-t v4 5/6] tests/kms_ccs: Test case where CCS is on a different BO

2017-10-08 Thread Gabriel Krisman Bertazi
Ben Widawsky writes: > On 17-09-27 15:34:18, Gabriel Krisman Bertazi wrote: >>Signed-off-by: Gabriel Krisman Bertazi > > Did someone recommend this test? While we have some hardware limitations on > current generations that make it difficult to use multiple BOs, it's certainly > not impossible,

Re: [Intel-gfx] [PATCH i-g-t v4 4/6] tests/kms_ccs: Test case where the CCS buffer was not provided

2017-10-08 Thread Gabriel Krisman Bertazi
Ben Widawsky writes: > On 17-09-27 15:34:17, Gabriel Krisman Bertazi wrote: >>Signed-off-by: Gabriel Krisman Bertazi >>--- >> tests/kms_ccs.c | 37 +++-- >> 1 file changed, 27 insertions(+), 10 deletions(-) >> >>diff --git a/tests/kms_ccs.c b/tests/kms_ccs.c >>inde

Re: [Intel-gfx] [PATCH i-g-t v4 6/6] tests/kms_ccs: Test case for wrong aux buffer stride size

2017-10-08 Thread Gabriel Krisman Bertazi
Ben Widawsky writes: > On 17-09-27 15:34:19, Gabriel Krisman Bertazi wrote: >>Two scenarios tested: >> - unaligned stride >> - Stride too small >> >>Signed-off-by: Gabriel Krisman Bertazi > > Jason, could you provide your opinion on this? I've always felt the kernel > interface shouldn't be va

Re: [Intel-gfx] [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

2017-10-08 Thread Masahiro Yamada
2017-10-09 3:52 GMT+09:00 Leon Romanovsky : > On Mon, Oct 09, 2017 at 01:10:01AM +0900, Masahiro Yamada wrote: > > <...> >> >> By splitting out the radix_tree_root definition, >> we can reduce the header file dependency. >> >> Reducing the header dependency will help for speeding the kernel >> buil

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: enable to read CSB and CSB write pointer from HWSP in GVT-g VM

2017-10-08 Thread Li, Weinan Z
On 10/2/2017 7:37 PM, Joonas Lahtinen wrote: On Mon, 2017-10-02 at 11:23 +0100, Chris Wilson wrote: Quoting Joonas Lahtinen (2017-10-02 11:03:30) On Sat, 2017-09-30 at 13:57 +0800, Weinan Li wrote: Let GVT-g VM read the CSB and CSB write pointer from virtual HWSP, not all the host support th

[Intel-gfx] [PATCH 12/12] drm/i915: replace with

2017-10-08 Thread Masahiro Yamada
The header drivers/gpu/drm/i915/i915_gem_context.h requires the definition of struct radix_tree_root, but does not need to know anything about other radix tree stuff. Include instead of to reduce the number of included header files. While we are here, let's add missing where radix tree accesso

[Intel-gfx] [PATCH 00/12] radix-tree: split out struct radix_tree_root out to

2017-10-08 Thread Masahiro Yamada
The motivation of this series is to cut down unnecessary header dependency in terms of radix tree. Sub-systems or drivers that use radix-tree for data management typically embed struct radix_tree_root in their data structures, like this: struct foo { ... struct radix_tree_root f

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Assert we do not try to expand VMA for hugepage inside GGTT

2017-10-08 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Assert we do not try to expand VMA for hugepage inside GGTT URL : https://patchwork.freedesktop.org/series/31549/ State : success == Summary == Test kms_cursor_legacy: Subgroup cursorA-vs-flipA-varying-size:

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Assert we do not try to expand VMA for hugepage inside GGTT

2017-10-08 Thread Matthew Auld
On 8 October 2017 at 14:43, Chris Wilson wrote: > We only apply the hugepage PD redirection inside the ppGTT, so during > i915_vma_insert() we want to exclude the GGTT from the additional > alignment constraints (thereby avoiding the extra GTT pressure from > fragmentation). Add an assert to docum

Re: [Intel-gfx] [PATCH v3] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-08 Thread Chris Wilson
Quoting Harsha Sharma (2017-10-08 15:04:07) > @@ -624,7 +624,7 @@ static bool intel_fbdev_init_bios(struct drm_device *dev, > ifbdev->preferred_bpp = fb->base.format->cpp[0] * 8; > ifbdev->fb = fb; > > - drm_framebuffer_reference(&ifbdev->fb->base); > + drm_framebuffer

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put() (rev2)

2017-10-08 Thread Patchwork
== Series Details == Series: drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put() (rev2) URL : https://patchwork.freedesktop.org/series/31283/ State : failure == Summary == Series 31283v2 drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put() https:/

[Intel-gfx] [PATCH v3] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-08 Thread Harsha Sharma
Replace instances of drm_framebuffer_reference/unreference() with *_get/put() suffixes and drm_dev_unref with *_put() suffix because get/put is shorter and consistent with the kernel use of *_get/put suffixes. Done with following coccinelle semantic patch @@ expression ex; @@ ( -drm_framebuffer_u

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Assert we do not try to expand VMA for hugepage inside GGTT

2017-10-08 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Assert we do not try to expand VMA for hugepage inside GGTT URL : https://patchwork.freedesktop.org/series/31549/ State : success == Summary == Series 31549v1 series starting with [1/3] drm/i915: Assert we do not try to expand

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Retire after wait-for-idle on evict

2017-10-08 Thread Chris Wilson
Quoting Chris Wilson (2017-10-08 14:43:21) > We have to manually retire the requests in order to unpin the contexts, > and thereby make their space available in the GGTT. So call retire after > we idle the GPU to account for the lazy pinning. Bah, no we moved the retire to i915_gem_wait_for_idle.

[Intel-gfx] [PATCH 3/3] drm/i915: Replace manual checking for idleness with active_requests counter

2017-10-08 Thread Chris Wilson
As we emit and retire requests, we track how many are still in flight. As we have this knowledge, we can make use of that inside i915_gem_evict_something() as a better test to see if the device is idle. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_evict.c | 19 +-

[Intel-gfx] [PATCH 1/3] drm/i915: Assert we do not try to expand VMA for hugepage inside GGTT

2017-10-08 Thread Chris Wilson
We only apply the hugepage PD redirection inside the ppGTT, so during i915_vma_insert() we want to exclude the GGTT from the additional alignment constraints (thereby avoiding the extra GTT pressure from fragmentation). Add an assert to document that intention alongside the comment. Signed-off-by:

[Intel-gfx] [PATCH 2/3] drm/i915: Retire after wait-for-idle on evict

2017-10-08 Thread Chris Wilson
We have to manually retire the requests in order to unpin the contexts, and thereby make their space available in the GGTT. So call retire after we idle the GPU to account for the lazy pinning. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_evict.c | 7 +-- 1 file changed, 5 i

Re: [Intel-gfx] [PATCH v2] drm/i915: Replace *_reference/unreference() or *_ref/unref with _get/put()

2017-10-08 Thread Harsha Sharma
On Fri, Sep 29, 2017 at 10:00 AM, Harsha Sharma wrote: > Replace instances of drm_framebuffer_reference/unreference() with > *_get/put() suffixes and drm_dev_unref with *_put() suffix > because get/put is shorter and consistent with the > kernel use of *_get/put suffixes. > Done with following coc