[Intel-gfx] ✓ Fi.CI.BAT: success for igt/kms_rotation_crc: Add horizontal flip subtest.

2017-10-04 Thread Patchwork
== Series Details == Series: igt/kms_rotation_crc: Add horizontal flip subtest. URL : https://patchwork.freedesktop.org/series/31407/ State : success == Summary == IGT patchset tested on top of latest successful build 7f93a2632aae7c5865823b4a2fa4cd8c2a1c0977 Update NEWS, bump version to 1.20.

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/edp: Get the Panel Power Off timestamp after panel is off

2017-10-04 Thread Jani Nikula
On Wed, 04 Oct 2017, Manasi Navare wrote: > Kernel stores the time in jiffies at which the eDP panel is turned > off. This should be obtained after the panel is off (after the > wait_panel_off). When we next attempt to turn the panel on, we > use the difference between the timestamp at which we wa

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for igt/kms_rotation_crc: Add horizontal flip subtest.

2017-10-04 Thread Arkadiusz Hiler
On Thu, Oct 05, 2017 at 01:08:56AM +, Patchwork wrote: > == Series Details == > > Series: igt/kms_rotation_crc: Add horizontal flip subtest. > URL : https://patchwork.freedesktop.org/series/31407/ > State : success > > == Summary == > > IGT patchset tested on top of latest successful build

Re: [Intel-gfx] [PATCH v3] drm/i915/mst: Use MST sideband message transactions for dpms control

2017-10-04 Thread Jani Nikula
On Wed, 04 Oct 2017, Lyude Paul wrote: > On Wed, 2017-10-04 at 11:47 +0300, Jani Nikula wrote: >> On Tue, 03 Oct 2017, Jani Nikula wrote: >> > From: Dhinakaran Pandiyan >> > >> > Use the POWER_DOWN_PHY and POWER_UP_PHY sideband message transactions to >> > set power states for downstream sinks.

[Intel-gfx] [PULL] drm-intel-fixes

2017-10-04 Thread Rodrigo Vivi
Hi Dave, Firs of all thanks for pulling previous request. Here goes another round of drm/i915 fixes. This is on top of previous one. If this gets to Linus by 4.14-rc4 the next one will be fully on right bases. All my local dim scripts already ajusted for that and a global "dim" solution is being

[Intel-gfx] [PULL] drm-misc-next

2017-10-04 Thread Daniel Vetter
Hi Dave, drm-misc-next-2017-10-05: More drm-misc for 4.15: Cross-subsystem Changes: - bunch more simple outreachy patches (Meghana Madhyastha, Aishwarya Pant, Haneen Mohammed) - Quite a pile of static checker/cocci/spelling fixups all over. - Final driver patches+core cleanup of Noralf's new d

Re: [Intel-gfx] [PATCH] drm/i915: Allow null render state batchbuffers bigger than one page

2017-10-04 Thread Rodrigo Vivi
On Thu, Aug 24, 2017 at 11:00:27PM +, Rodrigo Vivi wrote: > On Thu, Aug 24, 2017 at 3:39 PM, Oscar Mateo wrote: > > > > > > On 08/23/2017 05:01 PM, Rodrigo Vivi wrote: > >> > >> On Tue, Jul 18, 2017 at 8:15 AM, Oscar Mateo > >> wrote: > >>> > >>> > >>> > >>> On 07/14/2017 08:08 AM, Chris Wils

[Intel-gfx] ✓ Fi.CI.IGT: success for igt/kms_rotation_crc: Add horizontal flip subtest.

2017-10-04 Thread Patchwork
== Series Details == Series: igt/kms_rotation_crc: Add horizontal flip subtest. URL : https://patchwork.freedesktop.org/series/31407/ State : success == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_299/shards.html ___

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/kms_rotation_crc: Add horizontal flip subtest.

2017-10-04 Thread Patchwork
== Series Details == Series: igt/kms_rotation_crc: Add horizontal flip subtest. URL : https://patchwork.freedesktop.org/series/31407/ State : success == Summary == IGT patchset tested on top of latest successful build 7f93a2632aae7c5865823b4a2fa4cd8c2a1c0977 Update NEWS, bump version to 1.20.

[Intel-gfx] [PATCH] drm/i915: Convert timers to use timer_setup()

2017-10-04 Thread Kees Cook
In preparation for unconditionally passing the struct timer_list pointer to all timer callbacks, switch to using the new timer_setup() and from_timer() to pass the timer pointer explicitly. Cc: Daniel Vetter Cc: Jani Nikula Cc: David Airlie Cc: Chris Wilson Cc: Joonas Lahtinen Cc: Tvrtko Ursu

[Intel-gfx] [patch i-g-t] igt/kms_rotation_crc: Add horizontal flip subtest.

2017-10-04 Thread Anusha Srivatsa
From: Joseph Garvey Test that horizontal flip works with supported rotations. Includes a fix for the unrotated fb which was not being positioned correctly with portrait and landscape rectangles. v2:(from Anusha) - Change 180 degree rotation to follow the rest, use igt_swap(), make flip variable

Re: [Intel-gfx] [PATCH v5 2/5] drm/i915/guc : Removing i915_modparams.enable_guc_loading module

2017-10-04 Thread Sujaritha
On 10/03/2017 11:45 PM, Sagar Arun Kamble wrote: Subject is missing "parameter" in the end. Either keep module parameter or i915_modparams. Will fix the subject line. On 10/4/2017 4:26 AM, Sujaritha Sundaresan wrote: We currently have two module parameters that control GuC: "enable_guc_l

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Allow 2 pixel per clock on Cannonlake.

2017-10-04 Thread Paulo Zanoni
Em Ter, 2017-10-03 às 15:31 -0700, Rodrigo Vivi escreveu: > This is heavily based on a initial patch provided by Ville > plus all changes provided later by Ander. > > As Geminilake, Cannonlake also supports 2 pixels per clock. > > Different from Geminilake we are not implementing the 99% Wa. > Bu

Re: [Intel-gfx] [PATCH 09/13] drm/i915/cnl: Invert dvfs default level.

2017-10-04 Thread Manasi Navare
On Wed, Oct 04, 2017 at 03:40:11PM -0700, Manasi Navare wrote: > On Wed, Oct 04, 2017 at 12:36:42PM -0700, Rodrigo Vivi wrote: > > On Wed, Oct 04, 2017 at 09:46:41AM +, Mika Kahola wrote: > > > On Tue, 2017-10-03 at 00:06 -0700, Rodrigo Vivi wrote: > > > > According to spec "If voltage is set t

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bdw: Fix DP_AUX_CH_CTL_TIME_OUT setting

2017-10-04 Thread Runyan, Arthur J
I think the failure was with one particularly slow eDP panel, but it is safer to apply this to all ports. -Original Message- From: Vivi, Rodrigo Sent: Wednesday, 4 October, 2017 1:25 PM To: Ausmus, James Cc: intel-gfx@lists.freedesktop.org; ville.syrj...@linux.intel.com; jani.nik...@l

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Guc code reorg cont'd

2017-10-04 Thread Patchwork
== Series Details == Series: drm/i915: Guc code reorg cont'd URL : https://patchwork.freedesktop.org/series/31401/ State : success == Summary == Test perf: Subgroup blocking: fail -> PASS (shard-hsw) fdo#102252 fdo#102252 https://bugs.freedesktop.org/show_b

Re: [Intel-gfx] [PATCH 09/13] drm/i915/cnl: Invert dvfs default level.

2017-10-04 Thread Manasi Navare
On Wed, Oct 04, 2017 at 12:36:42PM -0700, Rodrigo Vivi wrote: > On Wed, Oct 04, 2017 at 09:46:41AM +, Mika Kahola wrote: > > On Tue, 2017-10-03 at 00:06 -0700, Rodrigo Vivi wrote: > > > According to spec "If voltage is set too low, > > > it will break functionality. If voltage is set too high,

Re: [Intel-gfx] [PATCH 08/13] drm/i915/cnl: DVFS for PLL disabling

2017-10-04 Thread Manasi Navare
On Tue, Oct 03, 2017 at 12:06:09AM -0700, Rodrigo Vivi wrote: > From: "Kahola, Mika" > > Display Voltage and Frequency Switching (DVFS) is used to adjust the > display voltage to match the display clock frequencies. To save power the > voltage is set to minimum when disabling PLL. > > The sequen

Re: [Intel-gfx] [PATCH 07/13] drm/i915/cnl: DVFS for PLL enabling

2017-10-04 Thread Manasi Navare
On Tue, Oct 03, 2017 at 12:06:08AM -0700, Rodrigo Vivi wrote: > From: "Kahola, Mika" > > Display Voltage and Frequency Switching (DVFS) is used to adjust the > display voltage to match the display clock frequencies. If voltage is > set too low, it will break functionality. If voltage is set too h

[Intel-gfx] ✗ Fi.CI.IGT: warning for lib/igt_kms: Convert properties to be more atomic-like. (rev11)

2017-10-04 Thread Patchwork
== Series Details == Series: lib/igt_kms: Convert properties to be more atomic-like. (rev11) URL : https://patchwork.freedesktop.org/series/30903/ State : warning == Summary == Test kms_flip: Subgroup plain-flip-fb-recreate-interruptible: pass -> FAIL (shard

Re: [Intel-gfx] [PATCH 06/13] drm/i915/cnl: Expose DVFS change functions

2017-10-04 Thread Manasi Navare
On Tue, Oct 03, 2017 at 12:06:07AM -0700, Rodrigo Vivi wrote: > From: "Kahola, Mika" > > DVFS computation needs cnl_dvfs_{pre,post}_change() functions to be exposed. > These functions will be used when computing DVFS levels in intel_dpll_mgr.c > > Cc: Ville Syrjälä > Signed-off-by: Kahola, Mika

Re: [Intel-gfx] [PATCH 05/13] drm/i915/cnl: extract cnl_dvfs_{pre, post}_change

2017-10-04 Thread Manasi Navare
Looks good and this refactoring makes since. Reviewed-by: Manasi Navare On Tue, Oct 03, 2017 at 12:06:06AM -0700, Rodrigo Vivi wrote: > From: Paulo Zanoni > > These functions even have their own page in our spec, > so extract them from cnl_set_cdclk(). > > v2: (By Rodrigo) Fixed inverted logi

Re: [Intel-gfx] [PATCH 05/13] drm/i915/cnl: extract cnl_dvfs_{pre, post}_change

2017-10-04 Thread Ausmus, James
On Tue, Oct 3, 2017 at 12:06 AM, Rodrigo Vivi wrote: > From: Paulo Zanoni > > These functions even have their own page in our spec, > so extract them from cnl_set_cdclk(). > > v2: (By Rodrigo) Fixed inverted logic on error return of > cnl_dvfs_pre_change. > > Cc: Ville Syrjälä > Signed-off-b

Re: [Intel-gfx] [PATCH 2/2] drm/i915/cnl: Fix PLL initialization for HDMI.

2017-10-04 Thread Manasi Navare
Good catch. Looks good to me as per the Bspec. Reviewed-by: Manasi Navare Manasi On Tue, Oct 03, 2017 at 03:08:59PM -0700, Rodrigo Vivi wrote: > HDMI Mode selection on CNL is on CFGCR0 for that PLL, not > on in a global CTRL1 as it was on SKL. > > The original patch addressed this difference,

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Unify and export gen9+ port_clock calculation.

2017-10-04 Thread Rodrigo Vivi
On Wed, Oct 04, 2017 at 07:38:16PM +, Rodrigo Vivi wrote: > On Wed, Oct 04, 2017 at 06:39:19AM +, Mika Kahola wrote: > > On Tue, 2017-10-03 at 00:06 -0700, Rodrigo Vivi wrote: > > > On Cannonlake the DVFS level selection depends on the > > > port clock. > > > > > > So let's re-org in a way

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v2,1/2] drm/i915/edp: Get the Panel Power Off timestamp after panel is off (rev2)

2017-10-04 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/edp: Get the Panel Power Off timestamp after panel is off (rev2) URL : https://patchwork.freedesktop.org/series/31361/ State : failure == Summary == Test gem_flink_race: Subgroup flink_close: fail

Re: [Intel-gfx] [PATCH] drm/i915: Transform whitelisting WAs into a simple reg write

2017-10-04 Thread Oscar Mateo
On 10/04/2017 06:17 AM, Chris Wilson wrote: Quoting Mika Kuoppala (2017-10-04 13:39:13) Oscar Mateo writes: RING_FORCE_TO_NONPRIV registers do not live in the logical context. They are simply global privileged MMIO registers that happen to be powercontext saved and restored (meaning only

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Fix DP_AUX_CH_CTL_TIME_OUT naming

2017-10-04 Thread Rodrigo Vivi
On Wed, Oct 04, 2017 at 08:09:21PM +, James Ausmus wrote: > Rename DP_AUX_CH_CTL_TIME_OUT_1600us to DP_AUX_CH_CTL_TIME_OUT_MAX, as > the meaning of the (3 << 26) value varies per platform, but it's always the > maximum timeout for that platform. Pre-CNL it means 1600us, and for CNL > it means 3

[Intel-gfx] ✓ Fi.CI.BAT: success for Fix HDMI as dual display on CNL.

2017-10-04 Thread Patchwork
== Series Details == Series: Fix HDMI as dual display on CNL. URL : https://patchwork.freedesktop.org/series/31352/ State : success == Summary == Series 31352v1 Fix HDMI as dual display on CNL. https://patchwork.freedesktop.org/api/1.0/series/31352/revisions/1/mbox/ fi-bdw-5557u total:289

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/bdw: Fix DP_AUX_CH_CTL_TIME_OUT setting

2017-10-04 Thread Rodrigo Vivi
On Wed, Oct 04, 2017 at 08:09:22PM +, James Ausmus wrote: > Per BSpec, 400us is "BDW+ Do not use this setting." - not just PORT_A. > Set BDW to 600us unconditionally. Besides that statement I also found on BSpec: " Workaround Project BDW, EXCLUDE(CHV) Set the Timeout timer value to at least 6

[Intel-gfx] [PATCH v2 1/2] drm/i915: Fix DP_AUX_CH_CTL_TIME_OUT naming

2017-10-04 Thread James Ausmus
Rename DP_AUX_CH_CTL_TIME_OUT_1600us to DP_AUX_CH_CTL_TIME_OUT_MAX, as the meaning of the (3 << 26) value varies per platform, but it's always the maximum timeout for that platform. Pre-CNL it means 1600us, and for CNL it means 3200us. v2: -Split in to two patches (Rodrigo) Cc: Rodrigo Vivi Sign

[Intel-gfx] [PATCH v2 2/2] drm/i915/bdw: Fix DP_AUX_CH_CTL_TIME_OUT setting

2017-10-04 Thread James Ausmus
Per BSpec, 400us is "BDW+ Do not use this setting." - not just PORT_A. Set BDW to 600us unconditionally. v2: -Split in to two patches (Rodrigo) Cc: Jani Nikula Cc: Ville Syrjälä Signed-off-by: James Ausmus --- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/9] drm/i915/preempt: Fix WaEnablePreemptionGranularityControlByUMD

2017-10-04 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915/preempt: Fix WaEnablePreemptionGranularityControlByUMD URL : https://patchwork.freedesktop.org/series/31394/ State : failure == Summary == Test gem_ctx_param: Subgroup invalid-param-get: pass ->

Re: [Intel-gfx] [PATCH 04/13] drm/i915: Unify and export gen9+ port_clock calculation.

2017-10-04 Thread Rodrigo Vivi
On Wed, Oct 04, 2017 at 06:39:19AM +, Mika Kahola wrote: > On Tue, 2017-10-03 at 00:06 -0700, Rodrigo Vivi wrote: > > On Cannonlake the DVFS level selection depends on the > > port clock. > > > > So let's re-org in a way that we can easily export without > > duplicating any code. > > > > v2:

Re: [Intel-gfx] [PATCH 09/13] drm/i915/cnl: Invert dvfs default level.

2017-10-04 Thread Rodrigo Vivi
On Wed, Oct 04, 2017 at 09:46:41AM +, Mika Kahola wrote: > On Tue, 2017-10-03 at 00:06 -0700, Rodrigo Vivi wrote: > > According to spec "If voltage is set too low, > > it will break functionality. If voltage is set too high, > >  it will waste power." > > > > So, let's prefer the waste of powe

Re: [Intel-gfx] [PATCH 2/2] drm/i915/cnl: Fix PLL initialization for HDMI.

2017-10-04 Thread Ausmus, James
On Tue, Oct 3, 2017 at 3:08 PM, Rodrigo Vivi wrote: > HDMI Mode selection on CNL is on CFGCR0 for that PLL, not > on in a global CTRL1 as it was on SKL. > > The original patch addressed this difference, but leaving behind > this single entry here. So we were checking the wrong bits during > the PL

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/edp: Get the Panel Power Off timestamp after panel is off (rev2)

2017-10-04 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/edp: Get the Panel Power Off timestamp after panel is off (rev2) URL : https://patchwork.freedesktop.org/series/31361/ State : success == Summary == Series 31361v2 series starting with [v2,1/2] drm/i915/edp: Get the Panel Pow

Re: [Intel-gfx] [PATCH 1/2] drm/i915/cnl: Fix PLL mapping.

2017-10-04 Thread Ausmus, James
On Tue, Oct 3, 2017 at 3:08 PM, Rodrigo Vivi wrote: > On PLL Enable sequence we need to "Configure DPCLKA_CFGCR0 to turn on > the clock for the DDI and map the DPLL to the DDI" > > So we first do the map and then we unset DDI_CLK_OFF to turn the clock > on. We do this in 2 separated steps. > > How

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Guc code reorg cont'd

2017-10-04 Thread Patchwork
== Series Details == Series: drm/i915: Guc code reorg cont'd URL : https://patchwork.freedesktop.org/series/31401/ State : success == Summary == Series 31401v1 drm/i915: Guc code reorg cont'd https://patchwork.freedesktop.org/api/1.0/series/31401/revisions/1/mbox/ Test kms_pipe_crc_basic:

Re: [Intel-gfx] [PATCH v3] drm/i915/mst: Use MST sideband message transactions for dpms control

2017-10-04 Thread Lyude Paul
On Wed, 2017-10-04 at 11:47 +0300, Jani Nikula wrote: > On Tue, 03 Oct 2017, Jani Nikula wrote: > > From: Dhinakaran Pandiyan > > > > Use the POWER_DOWN_PHY and POWER_UP_PHY sideband message transactions to > > set power states for downstream sinks. Apart from giving us the ability > > to set po

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size (rev3)

2017-10-04 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size (rev3) URL : https://patchwork.freedesktop.org/series/31284/ State : success == Summary == Test gem_flink_race: Subgroup flink_close: fail -> PASS (shar

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/2] drm/i915/edp: Get the Panel Power Off timestamp after panel is off (rev2)

2017-10-04 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/edp: Get the Panel Power Off timestamp after panel is off (rev2) URL : https://patchwork.freedesktop.org/series/31361/ State : failure == Summary == Series 31361v2 series starting with [v2,1/2] drm/i915/edp: Get the Panel Pow

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Introduce separate status variable for RC6 and Ring frequency setup

2017-10-04 Thread Sagar Arun Kamble
On 10/4/2017 10:36 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-10-04 15:07:25) Defined new struct intel_rc6 to hold RC6 specific state and intel_ring_pstate to hold ring specific state. What do you mean by ring? Probably not struct intel_ring. For us it would be closer to intel_e

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v2,1/5] igt/gem_workarounds: Read the workaround registers from the active context

2017-10-04 Thread Patchwork
== Series Details == Series: series starting with [v2,1/5] igt/gem_workarounds: Read the workaround registers from the active context URL : https://patchwork.freedesktop.org/series/31388/ State : warning == Summary == IGT patchset tested on top of latest successful build 7f93a2632aae7c5865823

[Intel-gfx] [PATCH v5 1/5] drm/i915/guc: Move GuC log declarations into dedicated header

2017-10-04 Thread Michal Wajdeczko
Move GuC log declarations into dedicated header as we want to keep component specific code in separate files. v2: fix includes (Chris) update commit message (Joonas) Suggested-by: Joonas Lahtinen Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Sagar Arun Kamble R

[Intel-gfx] [PATCH v5 5/5] drm/i915/uc: Unify initialization of the uC firmware helper

2017-10-04 Thread Michal Wajdeczko
Unify initialization of the uC firmware helper as we want to maximize code reuse. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/intel_guc_loader.c | 5 + drivers/gpu/drm/i915/intel_huc.c| 5 + drivers/gpu/drm/i915/intel_uc_fw.h

[Intel-gfx] [PATCH v5 3/5] drm/i915/guc: Move GuC core definitions into dedicated files

2017-10-04 Thread Michal Wajdeczko
Move GuC core definitions into dedicated files as we want to keep GuC specific code in separated files. v2: move all functions in single patch (Joonas) fix old checkpatch issues (Sagar) v3: rebased Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Sagar Arun Kamble

[Intel-gfx] [PATCH v5 0/5] drm/i915: Guc code reorg cont'd

2017-10-04 Thread Michal Wajdeczko
Leftover from https://patchwork.freedesktop.org/series/31340/ plus next round of minor improvements Michal Wajdeczko (5): drm/i915/guc: Move GuC log declarations into dedicated header drm/i915/guc: Move GuC submission declarations into dedicated header drm/i915/guc: Move GuC core definitions

[Intel-gfx] [PATCH v5 2/5] drm/i915/guc: Move GuC submission declarations into dedicated header

2017-10-04 Thread Michal Wajdeczko
Move GuC submission declarations into dedicated header as we want to keep uC specific code in separate files. v2: fix include (Chris) update commit message (Joonas) Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Sagar Arun Kamble Cc: MichaĹ Winiarski Reviewed-by

[Intel-gfx] [PATCH v5 4/5] drm/i915/uc: Fix includes order

2017-10-04 Thread Michal Wajdeczko
Fix includes order and make sure we only include required headers. Suggested-by: Chris Wilson Signed-off-by: Michal Wajdeczko Cc: Chris Wilson Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_uc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/int

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Guc code reorg

2017-10-04 Thread Patchwork
== Series Details == Series: drm/i915: Guc code reorg URL : https://patchwork.freedesktop.org/series/31391/ State : warning == Summary == Test kms_flip: Subgroup blt-wf_vblank-vs-modeset: pass -> DMESG-WARN (shard-hsw) Subgroup flip-vs-rmfb-interruptible:

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/igt_kms: Convert properties to be more atomic-like. (rev11)

2017-10-04 Thread Patchwork
== Series Details == Series: lib/igt_kms: Convert properties to be more atomic-like. (rev11) URL : https://patchwork.freedesktop.org/series/30903/ State : success == Summary == IGT patchset tested on top of latest successful build 7f93a2632aae7c5865823b4a2fa4cd8c2a1c0977 Update NEWS, bump vers

Re: [Intel-gfx] [PATCH 06/10] drm/i915/pmu: Wire up engine busy stats to PMU

2017-10-04 Thread Rogozhkin, Dmitry V
Nice data, thank you! -Original Message- From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com] Sent: Wednesday, October 4, 2017 10:35 AM To: Tvrtko Ursulin ; Intel-gfx@lists.freedesktop.org Cc: Chris Wilson ; Rogozhkin, Dmitry V Subject: Re: [Intel-gfx] [PATCH 06/10] drm/i915/pmu

Re: [Intel-gfx] [PATCH 07/10] drm/i915: Gate engine stats collection with a static key

2017-10-04 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-10-04 18:38:09) > > On 03/10/2017 11:17, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-09-29 13:34:57) > >> From: Tvrtko Ursulin > >> > >> This reduces the cost of the software engine busyness tracking > >> to a single no-op instruction when there are no listen

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Create generic function to setup ring frequency table

2017-10-04 Thread Sagar Arun Kamble
On 10/4/2017 10:34 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-10-04 15:07:23) Prepared intel_update_ring_freq function to setup ring frequency for applicable platforms determined by macro - NEEDS_RING_FREQ_UPDATE Signed-off-by: Sagar Arun Kamble Cc: Imre Deak Cc: Chris Wilson

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v2,1/2] drm/i915/edp: Get the Panel Power Off timestamp after panel is off (rev2)

2017-10-04 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915/edp: Get the Panel Power Off timestamp after panel is off (rev2) URL : https://patchwork.freedesktop.org/series/31361/ State : warning == Summary == Series 31361v2 series starting with [v2,1/2] drm/i915/edp: Get the Panel Pow

Re: [Intel-gfx] [PATCH 07/10] drm/i915: Gate engine stats collection with a static key

2017-10-04 Thread Tvrtko Ursulin
On 03/10/2017 11:17, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-09-29 13:34:57) From: Tvrtko Ursulin This reduces the cost of the software engine busyness tracking to a single no-op instruction when there are no listeners. We add a new i915 ordered workqueue to be used only for tasks n

Re: [Intel-gfx] [PATCH 06/10] drm/i915/pmu: Wire up engine busy stats to PMU

2017-10-04 Thread Tvrtko Ursulin
On 29/09/2017 13:34, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We can use engine busy stats instead of the sampling timer for better accuracy. By doing this we replace the stohastic sampling with busyness metric derived directly from engine activity. This is context switch interrupt driven,

Re: [Intel-gfx] [PATCH v5 1/5] drm/i915/guc : Unifying seq_puts messages

2017-10-04 Thread Sujaritha
On 10/04/2017 04:39 AM, Michal Wajdeczko wrote: On Wed, 04 Oct 2017 08:13:12 +0200, Sagar Arun Kamble wrote: On 10/4/2017 4:25 AM, Sujaritha Sundaresan wrote: Unifying the various seq_puts messages to the simplest one v2: Clarifying the commit message (Anusha) v3: Unify seq_puts messag

Re: [Intel-gfx] [PATCH v5 0/5] Removing enable_guc_loading module and Decoupling logs and ADS from submission

2017-10-04 Thread Sujaritha
On 10/04/2017 12:06 AM, Sagar Arun Kamble wrote: Hi Sujaritha, I am Unable to locate single series on patchwork for these changes. Please send all patches together in single series with cover letter. It will also enable CI BAT/IGT testing for the series. Thanks Sagar Sorry, I was not aware

Re: [Intel-gfx] [PATCH v5 1/5] drm/i915/guc : Unifying seq_puts messages

2017-10-04 Thread Sujaritha
On 10/03/2017 11:13 PM, Sagar Arun Kamble wrote: On 10/4/2017 4:25 AM, Sujaritha Sundaresan wrote: Unifying the various seq_puts messages to the simplest one v2: Clarifying the commit message (Anusha) v3: Unify seq_puts messages, Re-factoring code as per review (Michal) v4: Rebase v5: Se

Re: [Intel-gfx] [PATCH v3 9/9] drm/i915/guc: Move GuC core definitions into dedicated files

2017-10-04 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-10-03 17:36:07) > We want to keep GuC specific code in separated files. > > v2: move all functions in single patch (Joonas) > fix old checkpatch issues (Sagar) > > v3: rebased > > Signed-off-by: Michal Wajdeczko > Cc: Joonas Lahtinen > Cc: Chris Wilson > Cc:

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Separate RC6, RPS, Ring Frequency management

2017-10-04 Thread Patchwork
== Series Details == Series: drm/i915: Separate RC6, RPS, Ring Frequency management URL : https://patchwork.freedesktop.org/series/31387/ State : success == Summary == Test gem_flink_race: Subgroup flink_close: fail -> PASS (shard-hsw) fdo#102655 fdo#102655

Re: [Intel-gfx] [PATCH v3 8/9] drm/i915/guc: Move GuC submission declarations into dedicated header

2017-10-04 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-10-03 17:36:06) > We want to keep uC specific code in separate files. > > Signed-off-by: Michal Wajdeczko > Cc: Joonas Lahtinen > Cc: Chris Wilson > Cc: Sagar Arun Kamble > Cc: MichaĹ Winiarski > --- > drivers/gpu/drm/i915/i915_debugfs.c| 1 + > driver

Re: [Intel-gfx] [PATCH v3 7/9] drm/i915/guc: Move GuC log declarations into dedicated header

2017-10-04 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-10-03 19:28:02) > On Tue, 03 Oct 2017 19:03:58 +0200, Chris Wilson > wrote: > > > Quoting Michal Wajdeczko (2017-10-03 17:36:05) > >> We want to keep component specific code in separate files. > >> > >> Suggested-by: Joonas Lahtinen > >> Signed-off-by: Michal Waj

Re: [Intel-gfx] [PATCH 00/10] drm/i915: Separate RC6, RPS, Ring Frequency management

2017-10-04 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-10-04 15:07:15) > With GuC based SLPC, frequency control will be moved to GuC and Host will > continue to control RC6 and Ring frequency setup. This needs separate > handling of RPS, RC6 and ring frequencies in i915 flows. We still > continue use the *gt_powersave ro

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Introduce separate status variable for RC6 and Ring frequency setup

2017-10-04 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-10-04 15:07:25) > Defined new struct intel_rc6 to hold RC6 specific state and > intel_ring_pstate to hold ring specific state. What do you mean by ring? Probably not struct intel_ring. For us it would be closer to intel_engine_cs_pstate, which is a bit unwieldy but

Re: [Intel-gfx] [PATCH 08/10] drm/i915: Create generic function to setup ring frequency table

2017-10-04 Thread Chris Wilson
Quoting Sagar Arun Kamble (2017-10-04 15:07:23) > Prepared intel_update_ring_freq function to setup ring frequency > for applicable platforms determined by macro - NEEDS_RING_FREQ_UPDATE > > Signed-off-by: Sagar Arun Kamble > Cc: Imre Deak > Cc: Chris Wilson > Cc: Joonas Lahtinen > Cc: Radosla

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/9] drm/i915/preempt: Fix WaEnablePreemptionGranularityControlByUMD

2017-10-04 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915/preempt: Fix WaEnablePreemptionGranularityControlByUMD URL : https://patchwork.freedesktop.org/series/31394/ State : success == Summary == Series 31394v1 series starting with [CI,1/9] drm/i915/preempt: Fix WaEnablePreemption

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Guc code reorg

2017-10-04 Thread Joonas Lahtinen
On Tue, 2017-10-03 at 18:33 +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Guc code reorg > URL : https://patchwork.freedesktop.org/series/31340/ > State : success I've merged the series, thanks for the patches and review. Regards, Joonas -- Joonas Lahtinen Open Source T

[Intel-gfx] [PATCH v2 1/2] drm/i915/edp: Get the Panel Power Off timestamp after panel is off

2017-10-04 Thread Manasi Navare
Kernel stores the time in jiffies at which the eDP panel is turned off. This should be obtained after the panel is off (after the wait_panel_off). When we next attempt to turn the panel on, we use the difference between the timestamp at which we want to turn the panel on and timestamp at which pane

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size (rev3)

2017-10-04 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size (rev3) URL : https://patchwork.freedesktop.org/series/31284/ State : success == Summary == Series 31284v3 drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size https

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Guc code reorg

2017-10-04 Thread Patchwork
== Series Details == Series: drm/i915: Guc code reorg URL : https://patchwork.freedesktop.org/series/31391/ State : success == Summary == Series 31391v1 drm/i915: Guc code reorg https://patchwork.freedesktop.org/api/1.0/series/31391/revisions/1/mbox/ Test chamelium: Subgroup dp-hpd-fa

[Intel-gfx] [CI 9/9] drm/i915/scheduler: Support user-defined priorities

2017-10-04 Thread Chris Wilson
Use a priority stored in the context as the initial value when submitting a request. This allows us to change the default priority on a per-context basis, allowing different contexts to be favoured with GPU time at the expense of lower importance work. The user can adjust the context's priority via

[Intel-gfx] [CI 8/9] drm/i915/execlists: Preemption!

2017-10-04 Thread Chris Wilson
When we write to ELSP, it triggers a context preemption at the earliest arbitration point (3DPRIMITIVE, some PIPECONTROLs, a few other operations and the explicit MI_ARB_CHECK). If this is to the same context, it triggers a LITE_RESTORE where the RING_TAIL is merely updated (used currently to chain

[Intel-gfx] [CI 4/9] drm/i915: Introduce a preempt context

2017-10-04 Thread Chris Wilson
Add another perma-pinned context for using for preemption at any time. We cannot just reuse the existing kernel context, as first and foremost we need to ensure that we can preempt the kernel context itself, so require a distinct context id. Similar to the kernel context, we may want to interrupt e

[Intel-gfx] [CI 5/9] drm/i915/execlists: Move bdw GPGPU w/a to emit_bb

2017-10-04 Thread Chris Wilson
Move the re-enabling of MI arbitration from a per-bb w/a buffer to the emission of the batch buffer itself. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_lrc.c | 24 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a

[Intel-gfx] [CI 6/9] drm/i915/execlists: Keep request->priority for its lifetime

2017-10-04 Thread Chris Wilson
With preemption, we will want to "unsubmit" a request, taking it back from the hw and returning it to the priority sorted execution list. In order to know where to insert it into that list, we need to remember its adjust priority (which may change even as it was being executed). This also affects

[Intel-gfx] [CI 7/9] drm/i915: Expand I915_PARAM_HAS_SCHEDULER into a capability bitmask

2017-10-04 Thread Chris Wilson
In the next few patches, we wish to enable different features for the scheduler, some which may subtlety change ABI (e.g. allow requests to be reordered under different circumstances). So we need to make sure userspace is cognizant of the changes (if they care), by which we employ the usual method

[Intel-gfx] [CI 3/9] drm/i915/execlists: Distinguish the incomplete context notifies

2017-10-04 Thread Chris Wilson
Let the listener know that the context we just scheduled out was not complete, and will be scheduled back in at a later point. v2: Handle CONTEXT_STATUS_PREEMPTED in gvt by aliasing it to CONTEXT_STATUS_OUT for the moment, gvt can expand upon the difference later. Signed-off-by: Chris Wilson Cc:

[Intel-gfx] [CI 1/9] drm/i915/preempt: Fix WaEnablePreemptionGranularityControlByUMD

2017-10-04 Thread Chris Wilson
From: Jeff McGee The WA applies to all production Gen9 and requires both enabling and whitelisting of the per-context preemption control register. v2: Extend to Cannonlake. Signed-off-by: Jeff McGee Signed-off-by: Michał Winiarski Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen ---

[Intel-gfx] [CI 2/9] drm/i915/preempt: Default to disabled mid-command preemption levels

2017-10-04 Thread Chris Wilson
From: Michał Winiarski Supporting fine-granularity preemption levels may require changes in userspace batch buffer programming. Therefore, we need to fallback to safe default values, rather that use hardware defaults. Userspace is still able to enable fine-granularity, since we're whitelisting th

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/9] drm/i915/preempt: Fix WaEnablePreemptionGranularityControlByUMD

2017-10-04 Thread Chris Wilson
Quoting Patchwork (2017-10-04 16:48:31) > == Series Details == > > Series: series starting with [CI,1/9] drm/i915/preempt: Fix > WaEnablePreemptionGranularityControlByUMD > URL : https://patchwork.freedesktop.org/series/31389/ > State : failure > > == Summary == > > Series 31389v1 series star

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [CI,1/9] drm/i915/preempt: Fix WaEnablePreemptionGranularityControlByUMD

2017-10-04 Thread Patchwork
== Series Details == Series: series starting with [CI,1/9] drm/i915/preempt: Fix WaEnablePreemptionGranularityControlByUMD URL : https://patchwork.freedesktop.org/series/31389/ State : failure == Summary == Series 31389v1 series starting with [CI,1/9] drm/i915/preempt: Fix WaEnablePreemption

[Intel-gfx] [PATCH] drm/i915/cnl: Do not add an extra page for precaution in the Gen10 LRC size

2017-10-04 Thread Oscar Mateo
BSpec indicates exactly 16752 DWORDs (17 pages), plus one page for PPHWSP. Please notice that, when looking at the BSpec context image table, the right filter has to be applied (e.g. "CNL") as some rows are excluded for specific GENs. BSpec: 1383 v2: Update count and add BSpec tag (Joonas) v3: W

[Intel-gfx] [CI v4 6/6] drm/i915/guc: Move Guc early init into own function

2017-10-04 Thread Michal Wajdeczko
We don't want to make aggregate uc functions to be too detailed. This will also make future patch easier. Signed-off-by: Michal Wajdeczko Cc: Sagar Arun Kamble Cc: Joonas Lahtinen Reviewed-by: Sagar Arun Kamble Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_uc.c | 9 ++--- 1

[Intel-gfx] [CI v4 5/6] drm/i915/huc: Move HuC declarations into dedicated header

2017-10-04 Thread Michal Wajdeczko
We want to keep each uC specific code in separate files. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Sagar Arun Kamble Reviewed-by: Sagar Arun Kamble Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_huc.h | 39 +++

[Intel-gfx] [CI v4 3/6] drm/i915/uc: Create intel_uc_init_mmio

2017-10-04 Thread Michal Wajdeczko
From: Sagar Arun Kamble This patch adds new function intel_uc_init_mmio which will initialize MMIO access related variables prior to uc load/init. v2: Removed unnecessary export of guc_send_init_regs. Created intel_uc_init_mmio that currently wraps guc_init_send_regs. (Michal) v3 (Michal): add

[Intel-gfx] [CI v4 4/6] drm/i915/uc: Move uC fw helper code into dedicated files

2017-10-04 Thread Michal Wajdeczko
This is a prerequisite to unblock next steps. v2: correct include order (Joonas) v3: use common function prefix (Joonas) add kerneldoc (Michal) Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Sagar Arun Kamble Reviewed-by: Sagar Arun Kamble Reviewed-by: Joonas La

[Intel-gfx] [CI v4 0/6] drm/i915: Guc code reorg

2017-10-04 Thread Michal Wajdeczko
Reviewed patches 1-6 from https://patchwork.freedesktop.org/series/31340/ Michal Wajdeczko (5): drm/i915: Make intel_uncore.h header self-contained drm/i915/uc: Drop unnecessary forward declaration drm/i915/uc: Move uC fw helper code into dedicated files drm/i915/huc: Move HuC declaration

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move MMCD_MISC_CTRL from context w/a to standard

2017-10-04 Thread Oscar Mateo
On 10/04/2017 05:55 AM, Mika Kuoppala wrote: Chris Wilson writes: Looking at gem_workarounds shows us that MMCD_MISC_CTRL is not restored following a suspend-resume cycle. This implies that MMCD_MISC_CTRL is not stored in the context, but is an ordinary register w/a that we need to restore d

[Intel-gfx] [CI v4 1/6] drm/i915: Make intel_uncore.h header self-contained

2017-10-04 Thread Michal Wajdeczko
We're trying to resolve inter-header dependencies. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_uncore.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_uncore.h b/drivers/gp

[Intel-gfx] [CI v4 2/6] drm/i915/uc: Drop unnecessary forward declaration

2017-10-04 Thread Michal Wajdeczko
We don't need it here. Signed-off-by: Michal Wajdeczko Cc: Sagar Arun Kamble Cc: Joonas Lahtinen Reviewed-by: Sagar Arun Kamble --- drivers/gpu/drm/i915/intel_uc.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uc.h b/drivers/gpu/drm/i915/intel_uc.h index 6966

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Separate RC6, RPS, Ring Frequency management

2017-10-04 Thread Patchwork
== Series Details == Series: drm/i915: Separate RC6, RPS, Ring Frequency management URL : https://patchwork.freedesktop.org/series/31387/ State : success == Summary == Series 31387v1 drm/i915: Separate RC6, RPS, Ring Frequency management https://patchwork.freedesktop.org/api/1.0/series/31387/r

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp: Increase the T12 delay quirk to 1300ms

2017-10-04 Thread Daniel Vetter
On Tue, Oct 03, 2017 at 04:37:25PM -0700, Manasi Navare wrote: > For this specific PCI device, the eDP panel requires a higher > panel power cycle delay of 1300ms where the minimum spec > requirement of panel power cycle delay is 500ms. > This fix in combination with correct timestamp at which we g

Re: [Intel-gfx] [PATCH 1/2] drm/i915/edp: Get the Panel Power Off timestamp after panel is off

2017-10-04 Thread Daniel Vetter
On Tue, Oct 03, 2017 at 04:37:24PM -0700, Manasi Navare wrote: > Kernel stores the time in jiffies at which the eDP panel is turned > off. This should be obtained after the panel is off (after the > wait_panel_off). When we next attempt to turn the panel on, we > use the difference between the time

Re: [Intel-gfx] [PATCH v3 4/9] drm/i915/uc: Move uC fw helper code into dedicated files

2017-10-04 Thread Michal Wajdeczko
On Wed, 04 Oct 2017 16:23:50 +0200, Joonas Lahtinen wrote: On Tue, 2017-10-03 at 16:36 +, Michal Wajdeczko wrote: This is a prerequisite to unblock next steps. v2: correct include order (Joonas) Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson Cc: Sagar Arun Kamb

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove defunct trace points

2017-10-04 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-10-04 10:39:08) > > On 03/10/2017 13:50, Chris Wilson wrote: > > trace_i915_gem_evict_everything and trace_i915_gem_ring_flush stopped > > being used when their parent functions were removed. > > > > Signed-off-by: Chris Wilson > > Reviewed-by: Tvrtko Ursulin > Revi

[Intel-gfx] [CI 6/9] drm/i915/execlists: Keep request->priority for its lifetime

2017-10-04 Thread Chris Wilson
With preemption, we will want to "unsubmit" a request, taking it back from the hw and returning it to the priority sorted execution list. In order to know where to insert it into that list, we need to remember its adjust priority (which may change even as it was being executed). This also affects

[Intel-gfx] [CI 9/9] drm/i915/scheduler: Support user-defined priorities

2017-10-04 Thread Chris Wilson
Use a priority stored in the context as the initial value when submitting a request. This allows us to change the default priority on a per-context basis, allowing different contexts to be favoured with GPU time at the expense of lower importance work. The user can adjust the context's priority via

  1   2   3   >