On Mon 18.Sep'17 at 17:27:37 +0300, Joonas Lahtinen wrote:
On Thu, 2017-09-14 at 10:59 +0800, Shuo Liu wrote:
Add a silimar log mechanism as like drm. Classify GVT-g log messages
as different categories by differnt log functions.
Signed-off-by: Shuo Liu
Please split out the i915 related chan
By default the DRRS state will be at DRRS_HIGH_RR. When a Display
content is Idle for more than 1Sec Idleness will be declared and
DRRS_LOW_RR will be invoked, changing the refresh rate to the
lower most refresh rate supported by the panel. As soon as there
i
Hi Uma,
[auto build test ERROR on drm-intel/for-linux-next]
[cannot apply to v4.14-rc1 next-20170918]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Vidya-Srinivas/drm-i915-Enable-scanline-read
Switched to strncmp.
Signed-off-by: Dhinakaran Pandiyan
---
tests/kms_psr_sink_crc.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/tests/kms_psr_sink_crc.c b/tests/kms_psr_sink_crc.c
index bd3fa5e9..795b6546 100644
--- a/tests/kms_psr_sink_crc.c
+++ b/tests/km
Hi all,
Today's linux-next merge of the drm-intel tree got a conflict in:
drivers/media/v4l2-core/videobuf2-dma-contig.c
between commit:
5b6f9abe5a49 ("media: vb2: add bidirectional flag in vb2_queue")
from Linus' tree and commit:
c4860ad60564 ("lib/scatterlist: Fix offset type in sg_al
On Mon, 2017-09-18 at 12:38 +0100, Tvrtko Ursulin wrote:
> static inline void intel_engine_context_out(struct intel_engine_cs
> *engine)
> {
> unsigned long flags;
>
> - if (READ_ONCE(engine->stats.enabled) == 0)
> - return;
> -
> - spin_lock_irqsave(&engine->s
On Mon, 2017-09-18 at 16:56 -0700, Rodrigo Vivi wrote:
> "CNL PCH chance of hang when software accesses south display
> registers after hotplug is enabled.
> Workaround: Program 0xC2000 bits 11:8 = 0xF before enabling
> south display hotplug detection."
>
> "Workaround only needs to be applied
"CNL PCH chance of hang when software accesses south display
registers after hotplug is enabled.
Workaround: Program 0xC2000 bits 11:8 = 0xF before enabling
south display hotplug detection."
"Workaround only needs to be applied to pre-production steppings
used in graphics capable SKUs, but it is e
On Sat, Sep 09, 2017 at 12:10:04AM +, Pandiyan, Dhinakaran wrote:
> On Fri, 2017-09-08 at 16:45 -0700, Rodrigo Vivi wrote:
> > Don't touch other bits. My bad.
> >
> > I haven't seen any case where those other bits appeard to be
> > set before we touch it, but it is safe to avoid touching
> > o
From: "Pandiyan, Dhinakaran"
The buffer size defined is 16 bytes whereas only 14 bytes are read. Add a
macro to avoid this discrepancy.
Signed-off-by: Dhinakaran Pandiyan
Reviewed-by: James Ausmus
---
drivers/gpu/drm/i915/intel_dp.c | 15 +--
1 file changed, 5 insertions(+), 10 de
We already print training pattern used during link training and also
print if the source or sink does not support TPS3 for HBR2 link rates,
see intel_dp_training_pattern().
Signed-off-by: Dhinakaran Pandiyan
---
drivers/gpu/drm/i915/intel_dp.c | 4
1 file changed, 4 deletions(-)
diff --git
Rewriting this code without the goto, I believe, makes it more readable.
One functional change that has been included is the handling of failed ESI
register reads. Instead of disabling MST only for the first failed read, we
now disable MST on subsequent failed reads too. A failed ESI read is
proble
From: "Pandiyan, Dhinakaran"
Both mst_disable_dp and mst_post_disable_dp print number of active links
before the variable has been updated. Move the print statement in
mst_disable_dp after the decrement so that the printed values indicate
the disabing of a mst connector. Also, add some text to cl
From: "Pandiyan, Dhinakaran"
Print connector name in destroy_connect() and this doesn't add any extra
lines to dmesg. The debug macro has been moved before the unregister
call so that we don't lose the connector name and id.
Signed-off-by: Dhinakaran Pandiyan
Reviewed-by: James Ausmus
---
dri
On Fri, 2017-09-15 at 13:10 +0300, Ville Syrjälä wrote:
> On Tue, Sep 12, 2017 at 04:57:29PM -0700, Dhinakaran Pandiyan wrote:
> > The other instances of link training are protected with
> > connection_mutex, so do the same in check_mst_status() too.
> >
> > Signed-off-by: Dhinakaran Pandiyan
> >
Hello everyone,
recently I played around with my kabylake i5 nuc box and found that on some
TV's
the screen stays black as soon as I go to 4k@60.
The TV only accepts 4k@60 at yuv 4:2:0 (I also saw hdmi range extenders and
stuff that don't support yuv 4:4:4 on 4k@60).
I tried to force limited mode
Did you try tests on the system with 2 VDBOX engines? On my side 2 tests
are failing on SKL GT4e NUC:
(perf_pmu:5414) CRITICAL: Test assertion failure function
busy_check_all, file perf_pmu.c:164:
(perf_pmu:5414) CRITICAL: Failed assertion: (double)(val[i]) <= (1.0 +
tolerance) * (double)0.0f && (
On Mon, Sep 18, 2017 at 05:31:28PM +, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Most of our DP encoder hooks are split into per-platform variants.
> .disable() an exception, and thus it's a bit messy. Let's split it
> up as well. We'll leave the common parts in a helper called by
> each
On 08/31, Lionel Landwerlin wrote:
> Some of our tests measure that the OA unit produces reports at
> expected time intervals (as configured through the PERF_OPEN
> ioctl). It turns out the power management plays a role in the decision
> of the OA unit to write reports to memory. Under normal circu
On Mon, Sep 18, 2017 at 05:31:27PM +, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> It is safe to call intel_psr_disable() on a platform without PSR. We
> don't have such a check when calling intel_psr_enable() either.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_dp
On Mon, 18 Sep 2017 21:12:25 +0200, Chris Wilson
wrote:
Quoting Michal Wajdeczko (2017-09-18 19:55:07)
Our global struct with params is named exactly the same way
as new preferred name for the drm_i915_private function parameter.
To avoid such name reuse lets use different name for the globa
On Mon, 18 Sep 2017 21:11:40 +0200, Jani Nikula
wrote:
On Mon, 18 Sep 2017, Michal Wajdeczko wrote:
Our global struct with params is named exactly the same way
as new preferred name for the drm_i915_private function parameter.
To avoid such name reuse lets use different name for the global.
On 08/31, Lionel Landwerlin wrote:
> Experience shows that most of the issues we face with periodicity of
> the reports produced by the OA unit are related to power management,
> not frequency.
>
> Signed-off-by: Lionel Landwerlin
Ok.
Reviewed-by: Matthew Auld
_
On 08/31, Lionel Landwerlin wrote:
> Signed-off-by: Lionel Landwerlin
Reviewed-by: Matthew Auld
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Mon, Sep 18, 2017 at 08:52:12AM +, wrote:
> From: Lohith BS
>
> By default the DRRS state will be at DRRS_HIGH_RR. When a Display
> content is Idle for more than 1Sec Idleness will be declared and
> DRRS_LOW_RR will be invoked, changing the refresh rate to the
> lo
On 08/31, Lionel Landwerlin wrote:
> New issues that were discovered while making the tests work on Gen8+ :
>
> - we need to measure timings between periodic reports and discard all
>other kind of reports
>
> - it seems periodicity of the reports can be affected outside of RC6
>(frequen
On Mon, Sep 18, 2017 at 12:36 PM, Rodrigo Vivi wrote:
> On Sat, Sep 16, 2017 at 12:00:08AM +, Radhakrishna Sripada wrote:
>> Platforms do not support psr and drrs simultaneously.
>> Adding a subtest to make the check.
>
> I wasn't confident this was the right place for that, but
> this is defi
On Mon, Sep 18, 2017 at 12:35 PM, Rodrigo Vivi wrote:
> On Thu, Sep 14, 2017 at 06:16:41PM +, Radhakrishna Sripada wrote:
>> Some platforms do not support PSR and DRRS simultaneously.
>> Visual artifacts and flickering were reported on BDW HP Spectre
>> x360 Convertible. Deferring to PSR when
== Series Details ==
Series: drm/i915: Eliminate DDI encoder->type frobbery redux
URL : https://patchwork.freedesktop.org/series/30548/
State : failure
== Summary ==
Series 30548v1 drm/i915: Eliminate DDI encoder->type frobbery redux
https://patchwork.freedesktop.org/api/1.0/series/30548/revis
On Sat, Sep 16, 2017 at 12:00:08AM +, Radhakrishna Sripada wrote:
> Platforms do not support psr and drrs simultaneously.
> Adding a subtest to make the check.
I wasn't confident this was the right place for that, but
this is definitely the easisest and cleanest way.
>
> Cc: Rodrigo Vivi
>
On Thu, Sep 14, 2017 at 06:16:41PM +, Radhakrishna Sripada wrote:
> Some platforms do not support PSR and DRRS simultaneously.
> Visual artifacts and flickering were reported on BDW HP Spectre
> x360 Convertible. Deferring to PSR when both PSR and DRRS are
> supported by the panel.
>
> V2: Min
On Mon, Sep 18, 2017 at 09:20:03PM +0300, Jani Nikula wrote:
> Add drm_kms_helper.edid_firmware module parameter with param ops hooks
> to set drm.edid_firmware instead, for backwards compatibility.
>
> Suggested-by: Ville Syrjälä
> Cc: Abdiel Janulgue
> Cc: Daniel Vetter
> Cc: Ville Syrjälä
>
Quoting Michal Wajdeczko (2017-09-18 19:55:07)
> Our global struct with params is named exactly the same way
> as new preferred name for the drm_i915_private function parameter.
> To avoid such name reuse lets use different name for the global.
>
> v4: introduction of mkwrite()
>
> Credits-to: Co
On Mon, 18 Sep 2017, Michal Wajdeczko wrote:
> Our global struct with params is named exactly the same way
> as new preferred name for the drm_i915_private function parameter.
> To avoid such name reuse lets use different name for the global.
>
> v4: introduction of mkwrite()
Why?
I don't know w
On Mon, Sep 18, 2017 at 07:45:14PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2017-09-18 19:25:40)
> > From: Ville Syrjälä
> >
> > Pull the code to disable the port clock into a function. We already have
> > the intel_ddi_clk_select() counterpart.
> >
> > Signed-off-by: Ville Syrjälä
>
On Mon, 18 Sep 2017, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> This series aims to eliminate the DDI encoder->type shenanigans.
> Afterwards encoder->type will permanently be "DDI" for DDI DP/HDMI
> ports, and "EDP" for DDI eDP ports. To figure out in which mode
> we want to drive the port w
Quoting Chris Wilson (2017-09-18 19:40:45)
> Quoting Ville Syrjala (2017-09-18 19:25:38)
> > From: Ville Syrjälä
> >
> > All the values we put into the CNL buf_trans tables fit into 8 bits.
> > So switch over to u8 from the u32 we use currently.
> >
> > Signed-off-by: Ville Syrjälä
> Reviewed-b
On Mon, 18 Sep 2017, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Pass an old crtc state to intel_ddi_post_disable() from the MST code.
>
> Note that this crtc state won't necessaitly match the one that was
> passed to intel_ddi_pre_enable() if the first stream to be enabled isn't
> the last st
== Series Details ==
Series: drm/edid: transparent low-level override/firmware EDIDs (rev2)
URL : https://patchwork.freedesktop.org/series/30182/
State : success
== Summary ==
Series 30182v2 drm/edid: transparent low-level override/firmware EDIDs
https://patchwork.freedesktop.org/api/1.0/serie
On Mon, Sep 18, 2017 at 07:43:43PM +0100, Chris Wilson wrote:
> Quoting Ville Syrjala (2017-09-18 19:25:39)
> > From: Ville Syrjälä
> >
> > To make it easier to debug things let's dump the output types bitmask in
> > the crtc state dump. And to make life that much better, let's pretty
> > print i
On Mon, 18 Sep 2017, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> intel_edp_panel_on() will itself do the is_edp() check, so the caller
> doesn't have to bother. Pre-DDI code doesn't bother, so let's follow the
> same approach for DDI.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
On Mon, 18 Sep 2017, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> To clean up the mess in intel_ddi_post_disable() split it into two
> clean variants for HDMI and DP.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 69
>
On Mon, 18 Sep 2017, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> To untangle the mess that is intel_ddi_post_disable() move the the bits
> needed by FDI into intel_ddi_fdi_post_disable(). This way we can stop
> worrying about FDI in intel_ddi_post_disable().
>
> Signed-off-by: Ville Syrjälä
On Mon, 18 Sep 2017, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Extract the code to disable the DDI_BUF_CTL into small helper. This
> will allows us to detangle the encoder type mess in
> intel_ddi_post_disable().
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers
Our global struct with params is named exactly the same way
as new preferred name for the drm_i915_private function parameter.
To avoid such name reuse lets use different name for the global.
v4: introduction of mkwrite()
Credits-to: Coccinelle
@@
identifier n;
expression e;
@@
(
- i915.n
On Mon, 18 Sep 2017, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> To make it easier to debug things let's dump the output types bitmask in
> the crtc state dump. And to make life that much better, let's pretty
> print it as a a human reaadable string as well.
>
> Signed-off-by: Ville Syrjälä
>
On Mon, 18 Sep 2017, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> All the values we put into the BXT buf_trans tables fit into 8 bits.
> So switch over to u8 from the u32 we use currently.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/intel_ddi.c |
On Mon, 18 Sep 2017, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Some comments in intel_ddi.c are indented with spaces instead of tabs.
> Fix that up.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Jani Nikula
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 6 +++---
> 1 file changed, 3 insert
From: Ben Widawsky
Cannonlake Slice and Subslice information has changed.
This patch initially provided by Ben adds the proper sseu
initialization.
v2: This v2 done by Rodrigo includes:
- Fix on Total slices count by avoiding [1][2] and [2][2].
- Inclusion of EU Per Subslice.
- Comm
CNL adds an extra register for slice/subslice information.
Although no SKU is planed with an extra slice let's already
handle this extra piece of information so we don't have the
risk in future of getting a part that might have chosen this
part of the die instead of other slices or anything like th
Quoting Ville Syrjala (2017-09-18 19:25:40)
> From: Ville Syrjälä
>
> Pull the code to disable the port clock into a function. We already have
> the intel_ddi_clk_select() counterpart.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 24
> 1
Quoting Ville Syrjala (2017-09-18 19:25:39)
> From: Ville Syrjälä
>
> To make it easier to debug things let's dump the output types bitmask in
> the crtc state dump. And to make life that much better, let's pretty
> print it as a a human reaadable string as well.
>
> Signed-off-by: Ville Syrjälä
Quoting Ville Syrjala (2017-09-18 19:25:38)
> From: Ville Syrjälä
>
> All the values we put into the CNL buf_trans tables fit into 8 bits.
> So switch over to u8 from the u32 we use currently.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Chris Wilson
-Chris
___
Quoting Ville Syrjala (2017-09-18 19:25:38)
> From: Ville Syrjälä
>
> All the values we put into the CNL buf_trans tables fit into 8 bits.
> So switch over to u8 from the u32 we use currently.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Chris Wilson
-Chris
___
Quoting Ville Syrjala (2017-09-18 19:25:36)
> From: Ville Syrjälä
>
> Some comments in intel_ddi.c are indented with spaces instead of tabs.
> Fix that up.
>
> Signed-off-by: Ville Syrjälä
Reviewed-by: Chris Wilson
-Chris
___
Intel-gfx mailing list
I
On 18 September 2017 at 17:46, Chris Wilson wrote:
> archdata.iommu only exists when CONFIG_IOMMU_API is enabled (and only
> applies to intel-iommu in our case) so conditionally compile it when it
> doesn't exist.
>
> Fixes: b5891fb520f7 ("drm/i915/selftests: Disable iommu for the mock device")
>
From: Ville Syrjälä
intel_ddi_enable_transcoder_func() already has the crtc state so we can
use that instead of the untrustworthy encoder->type.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 15 +--
1 file changed, 5 insertions(+), 10 deletions(-)
diff --git
From: Ville Syrjälä
Handle missing buf trans tables, or out of bounds buf trans levels
the same way everywhere. These should never be hit under normal
conditions, but let's play it safe for now.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 25 -
1
From: Ville Syrjälä
Pass an old crtc state to intel_ddi_post_disable() from the MST code.
Note that this crtc state won't necessaitly match the one that was
passed to intel_ddi_pre_enable() if the first stream to be enabled isn't
the last stream to be disabled. But this is fine since the states
From: Ville Syrjälä
Most of the callers of intel_ddi_get_encoder_port() can just use
encoder->port directly instead of going through all these gynmastics.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions
From: Ville Syrjälä
SKL DDI B/C/D only have 9 usable buf trans registers for DP/eDP. That
matches the normal DP buf trans tables, but the low vswing eDP tables
have 10 entries. Thus the eDP tables can only be used safely with DDI A
and E.
We try to catch cases where DDI B/C/D gets used with the
From: Ville Syrjälä
Introduce intel_ddi_get_buf_trans_hdmi() and start using it where we
can.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 50 ++--
1 file changed, 28 insertions(+), 22 deletions(-)
diff --git a/drivers/gpu/drm/i915/in
From: Ville Syrjälä
encoder->type isn't reliable for DP/HDMI so instead extract the correct
type from the crtc state in intel_ddi_set_pipe_settings().
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 47
1 file changed, 24 insertions(
From: Ville Syrjälä
Use plain int for the DDI buf trans levels and number of entries. While
at it drop the redundant "hdmi" from some of the variable names.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 65 +++-
1 file changed, 31 inser
From: Ville Syrjälä
Currently the DDI encoder->type will change at runtime depending on
what kind of hotplugs we've processed. That's quite bad since we can't
really trust that that current value of encoder->type actually matches
the type of signal we're trying to drive through it.
Let's elimina
From: Ville Syrjälä
encoder->type is not realiable for DP/HDMI so let's switch the DPLL
selection over to using output_types.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_dpll_mgr.c | 36 +--
1 file changed, 13 insertions(+), 23 deletions(-)
diff
From: Ville Syrjälä
Eliminate intel_prepare_dp_ddi_buffers()'s reliance on the encoder->type
by passing in the crtc state.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 25 +
1 file changed, 9 insertions(+), 16 deletions(-)
diff --git a/drivers/gp
From: Ville Syrjälä
default_index contained in the BXT buf_trans tables is actually useless.
For DP we should always have a valid level selected (otherwise the link
training logic would be buggy), and for HDMI we can just do what the
other platforms do and pick the correct entry in intel_ddi_hdmi
From: Ville Syrjälä
encoder->type is unreliable for DP/HDMI, so pass it in explicity into
cnl_ddi_vswing_sequence(). This matches what we do for BXT.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 43 ++--
1 file changed, 19 insertions(+
From: Ville Syrjälä
Make BXT less special by following the CNL approach and handling
it in intel_ddi_dp_voltage_max() alognside every other DDI platform.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 69 ++--
drivers/gpu/drm/i915/intel_
From: Ville Syrjälä
encoder->type isn't reliable for DP/HDMI encoders, so pass the type
explicity to skl_set_iboost(). Also take the opportunity to streamline
the code.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 57
1 file chang
From: Ville Syrjälä
The caller of intel_prepare_hdmi_ddi_buffers() alreday figured out the
level, so let's just pass it in instead if figuring it out again.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --
From: Ville Syrjälä
Rather that plump the link parameters separately to
intel_ddi_pre_enable_dp() let's just pass the entire crtc state.
intel_ddi_pre_enable_hdmi() already took the crtc state, but for some
reason intel_ddi_pre_enable() still wanted to extract has_infoframe
from therein and pass
From: Ville Syrjälä
Untangle intel_disable_ddi() by splitting it into DP and HDMI specific
variants.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 45 +---
1 file changed, 28 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/
From: Ville Syrjälä
We'll want to use the intel_ddi_get_buf_trans_*() functions a bit
earlier in the file, so move them up. While at it start using them
in the iboost setup to get rid of the platform checks there.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 115
From: Ville Syrjälä
To clean up the mess in intel_ddi_post_disable() split it into two
clean variants for HDMI and DP.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 69 +++-
1 file changed, 40 insertions(+), 29 deletions(-)
diff --git
From: Ville Syrjälä
Untangle intel_enable_ddi() by splitting it into DP and HDMI specific
variants.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 80 +++-
1 file changed, 46 insertions(+), 34 deletions(-)
diff --git a/drivers/gpu/drm/i
From: Ville Syrjälä
To untangle the mess that is intel_ddi_post_disable() move the the bits
needed by FDI into intel_ddi_fdi_post_disable(). This way we can stop
worrying about FDI in intel_ddi_post_disable().
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 3 ++-
1 file ch
From: Ville Syrjälä
intel_edp_panel_on() will itself do the is_edp() check, so the caller
doesn't have to bother. Pre-DDI code doesn't bother, so let's follow the
same approach for DDI.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 4 ++--
1 file changed, 2 insertions(+),
From: Ville Syrjälä
Extract the code to disable the DDI_BUF_CTL into small helper. This
will allows us to detangle the encoder type mess in
intel_ddi_post_disable().
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 41 +++-
1 file changed,
From: Ville Syrjälä
Pull the code to disable the port clock into a function. We already have
the intel_ddi_clk_select() counterpart.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 24
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/d
From: Ville Syrjälä
All the values we put into the BXT buf_trans tables fit into 8 bits.
So switch over to u8 from the u32 we use currently.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu
From: Ville Syrjälä
All the values we put into the CNL buf_trans tables fit into 8 bits.
So switch over to u8 from the u32 we use currently.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/
From: Ville Syrjälä
To make it easier to debug things let's dump the output types bitmask in
the crtc state dump. And to make life that much better, let's pretty
print it as a a human reaadable string as well.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 50 +
From: Ville Syrjälä
This series aims to eliminate the DDI encoder->type shenanigans.
Afterwards encoder->type will permanently be "DDI" for DDI DP/HDMI
ports, and "EDP" for DDI eDP ports. To figure out in which mode
we want to drive the port we use the output_types bitmask, which
for DDI will be
From: Ville Syrjälä
Some comments in intel_ddi.c are indented with spaces instead of tabs.
Fix that up.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_ddi.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm
Add drm_kms_helper.edid_firmware module parameter with param ops hooks
to set drm.edid_firmware instead, for backwards compatibility.
Suggested-by: Ville Syrjälä
Cc: Abdiel Janulgue
Cc: Daniel Vetter
Cc: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/drm_edid_load.c | 1
On Fri, 15 Sep 2017, Ville Syrjälä wrote:
> Hmm. Wouldn't you just have to have custom kernel_param_ops and
> that's about it? Seems like that could be a bit cleaner.
Here's a shot at that. Completely untested, but seems like this should
do the trick, and is less complex than I anticipated.
BR,
== Series Details ==
Series: drm/i915: Unset legacy_cursor_update early in intel_atomic_commit, v2.
URL : https://patchwork.freedesktop.org/series/30503/
State : warning
== Summary ==
Test perf:
Subgroup blocking:
pass -> FAIL (shard-hsw) fdo#102252
Test drv
== Series Details ==
Series: IGT PMU support (rev2)
URL : https://patchwork.freedesktop.org/series/28253/
State : success
== Summary ==
IGT patchset tested on top of latest successful build
2e93946e4e15cb8e7e978334cb62677f9ead82fe meson: Fix IGT_GIT_SHA1 handling
with latest DRM-Tip kernel bu
== Series Details ==
Series: series starting with [1/2] drm/i915: Drop useless HAS_PSR() check
URL : https://patchwork.freedesktop.org/series/30543/
State : warning
== Summary ==
Series 30543v1 series starting with [1/2] drm/i915: Drop useless HAS_PSR() check
https://patchwork.freedesktop.org/
== Series Details ==
Series: drm/i915/selftests: Only touch archdata.iommu when it exists
URL : https://patchwork.freedesktop.org/series/30541/
State : failure
== Summary ==
Series 30541v1 drm/i915/selftests: Only touch archdata.iommu when it exists
https://patchwork.freedesktop.org/api/1.0/se
From: Ville Syrjälä
It is safe to call intel_psr_disable() on a platform without PSR. We
don't have such a check when calling intel_psr_enable() either.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_dp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/driver
From: Ville Syrjälä
Most of our DP encoder hooks are split into per-platform variants.
.disable() an exception, and thus it's a bit messy. Let's split it
up as well. We'll leave the common parts in a helper called by
each platform specific hook.
There is a subtle change on VLV/CHV where we now d
Hi Maarten,
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on v4.14-rc1 next-20170918]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/drm-i915
== Series Details ==
Series: series starting with [1/2] drm/i915: Only wake the waiter from the
interrupt if passed
URL : https://patchwork.freedesktop.org/series/30540/
State : success
== Summary ==
Series 30540v1 series starting with [1/2] drm/i915: Only wake the waiter from
the interrupt
== Series Details ==
Series: drm/i915: Enable scanline read for gen9 dsi (rev5)
URL : https://patchwork.freedesktop.org/series/30032/
State : failure
== Summary ==
Series 30032v5 drm/i915: Enable scanline read for gen9 dsi
https://patchwork.freedesktop.org/api/1.0/series/30032/revisions/5/mbox
archdata.iommu only exists when CONFIG_IOMMU_API is enabled (and only
applies to intel-iommu in our case) so conditionally compile it when it
doesn't exist.
Fixes: b5891fb520f7 ("drm/i915/selftests: Disable iommu for the mock device")
Signed-off-by: Chris Wilson
Cc: Matthew Auld
---
drivers/gpu
Quoting Chris Wilson (2017-09-14 17:22:40)
> On some machines, the iommu cannot allocate a domain for the mock device
> causing the dma_map_sg() to fail, and the selftest to fail with -ENOMEM.
> For the mock selftests, we are using a fake device and do not care about
> iommu; so convince intel_iomm
== Series Details ==
Series: i915 PMU and engine busy stats (rev9)
URL : https://patchwork.freedesktop.org/series/27488/
State : success
== Summary ==
Test perf:
Subgroup polling:
fail -> PASS (shard-hsw) fdo#102252
Test kms_atomic_transition:
Subgro
1 - 100 of 206 matches
Mail list logo
