Re: [Intel-gfx] [PATCH] drm/i915: Stop using long platform names on clock gating functions.

2017-08-28 Thread Jani Nikula
On Tue, 29 Aug 2017, Rodrigo Vivi wrote: > No functional changes. > > Our code was only a bit messy with mixed style there so > let's clean up a bit using the short codenames for the platforms. > > Cc: Dhinakaran Pandiyan > Signed-off-by: Rodrigo Vivi Acked-by: Jani Nikula > --- > drivers/g

Re: [Intel-gfx] [PATCH] drm/i915/cnp: Wa 1181: Fix Backlight issue

2017-08-28 Thread Jani Nikula
On Tue, 29 Aug 2017, Rodrigo Vivi wrote: > This workaround fixes a CNL PCH bug when changing > backlight from a lower frequency to a higher frequency. > > During random reboot cycles, display backlight seems to > be off/ dim for 2-3 mins. > > The only functional change on this patch is to > set bi

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/cnp: Wa 1181: Fix Backlight issue

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915/cnp: Wa 1181: Fix Backlight issue URL : https://patchwork.freedesktop.org/series/29452/ State : success == Summary == Test kms_flip: Subgroup plain-flip-ts-check: fail -> PASS (shard-hsw) shard-hswtotal:2230 pas

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Stop using long platform names on clock gating functions.

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915: Stop using long platform names on clock gating functions. URL : https://patchwork.freedesktop.org/series/29453/ State : success == Summary == Series 29453v1 drm/i915: Stop using long platform names on clock gating functions. https://patchwork.freedesktop

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnp: Wa 1181: Fix Backlight issue

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915/cnp: Wa 1181: Fix Backlight issue URL : https://patchwork.freedesktop.org/series/29452/ State : success == Summary == Series 29452v1 drm/i915/cnp: Wa 1181: Fix Backlight issue https://patchwork.freedesktop.org/api/1.0/series/29452/revisions/1/mbox/ Test k

[Intel-gfx] [PATCH] drm/i915: Stop using long platform names on clock gating functions.

2017-08-28 Thread Rodrigo Vivi
No functional changes. Our code was only a bit messy with mixed style there so let's clean up a bit using the short codenames for the platforms. Cc: Dhinakaran Pandiyan Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_pm.c | 44 - 1 file change

[Intel-gfx] [PATCH] drm/i915/cnp: Wa 1181: Fix Backlight issue

2017-08-28 Thread Rodrigo Vivi
This workaround fixes a CNL PCH bug when changing backlight from a lower frequency to a higher frequency. During random reboot cycles, display backlight seems to be off/ dim for 2-3 mins. The only functional change on this patch is to set bit 13 of 0xC2020 for CNL PCH. The rest of patch is organ

[Intel-gfx] ✓ Fi.CI.IGT: success for tests/gem_exec_reuse: Adds cleanup at the end of test.

2017-08-28 Thread Patchwork
== Series Details == Series: tests/gem_exec_reuse: Adds cleanup at the end of test. URL : https://patchwork.freedesktop.org/series/29447/ State : success == Summary == Test kms_flip: Subgroup plain-flip-ts-check: fail -> PASS (shard-hsw) shard-hswto

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/gem_exec_reuse: Adds cleanup at the end of test.

2017-08-28 Thread Patchwork
== Series Details == Series: tests/gem_exec_reuse: Adds cleanup at the end of test. URL : https://patchwork.freedesktop.org/series/29447/ State : success == Summary == IGT patchset tested on top of latest successful build d937dd7997059bc2801095ffb0c50f646da1ab01 docs: Add user documentation ab

[Intel-gfx] [PATCH v2 2/2] drm/i915/guc : Decouple logs from submission

2017-08-28 Thread Sujaritha Sundaresan
The Additional Data Struct (ADS) contains objects that are required by guc post FW load and are not necessarily submission-only (although that's our current only use-case). If in the future we load GuC with submission disabled to use some other GuC feature we might still end up requiring something

[Intel-gfx] [PATCH v2 1/2] drm/i915/guc : Removing enable_guc_loading module

2017-08-28 Thread Sujaritha Sundaresan
We currently have two module parameters that control GuC: "enable_guc_loading" and "enable_guc_submission". Whenever we need i915.enable_guc_submission=1, we also need enable_guc_loading=1. We also need enable_guc_loading=1 when we want to verify the HuC, which is every time we have a HuC (but a

[Intel-gfx] [PATCH i-g-t] tests/gem_exec_reuse: Adds cleanup at the end of test.

2017-08-28 Thread Antonio Argenziano
This patch introduces a fixture at the end of the test to destroy objects that have been created and stop the hang detector. Cc: Chris Wilson Signed-off-by: Antonio Argenziano --- tests/gem_exec_reuse.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/gem_exec_reuse.c b/tests/g

Re: [Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-28 Thread Rogozhkin, Dmitry V
On Wed, 2017-08-23 at 20:22 +0200, Peter Zijlstra wrote: > On Wed, Aug 23, 2017 at 05:51:38PM +, Rogozhkin, Dmitry V wrote: > > > Anyhow, returning to the metrics i915 exposes. Some metrics are just > > exposure of some counters supported already inside i915 PMU which do not > > require any sp

Re: [Intel-gfx] [RFC v2 2/3] drm/i915/pmu: serve global events and support perf stat

2017-08-28 Thread Rogozhkin, Dmitry V
Peter, any comments? On Wed, 2017-08-23 at 23:38 +, Rogozhkin, Dmitry V wrote: > On Wed, 2017-08-23 at 08:26 -0700, Dmitry Rogozhkin wrote: > > +static cpumask_t i915_pmu_cpumask = CPU_MASK_CPU0; > > > Peter, this hardcoding of cpumask to use CPU0 works, but should I > implement something sm

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] lib: Add some syncobj helpers (v2)

2017-08-28 Thread Patchwork
== Series Details == Series: series starting with [1/4] lib: Add some syncobj helpers (v2) URL : https://patchwork.freedesktop.org/series/29439/ State : success == Summary == Test kms_flip: Subgroup plain-flip-ts-check: fail -> PASS (shard-hsw) Test vgem_bas

Re: [Intel-gfx] [PATCH i-g-t 1/4] lib: Add some syncobj helpers (v2)

2017-08-28 Thread Daniel Vetter
On Mon, Aug 28, 2017 at 02:10:12PM -0700, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand gtkdocs would be lovely for this, if I can motivate you ... Thanks, Daniel > --- > lib/Makefile.sources | 2 + > lib/igt_syncobj.c| 207 > +++ >

Re: [Intel-gfx] [i-g-t PATCH 00/10] tools/intel_vbt_decode: switch to using kernel intel_vbt_defs.h

2017-08-28 Thread Daniel Vetter
On Mon, Aug 28, 2017 at 03:19:52PM +0300, Jani Nikula wrote: > There's little point in duplicating the efforts of describing the same > data in two places. This series lets us use the verbatim copy of the > intel_vbt_defs.h from kernel. Going forward, we should add the changes > in kernel first, th

Re: [Intel-gfx] [PATCH 0/6] Adding NV12 support

2017-08-28 Thread Daniel Vetter
On Mon, Aug 28, 2017 at 04:22:16PM +0530, Vidya Srinivas wrote: > This patch series is adding NV12 support for Broxton display after > rebasing on latest drm-intel-nightly. Initial series of the patches > can be found here: > https://lists.freedesktop.org/archives/intel-gfx/2015-May/066786.html >

Re: [Intel-gfx] [PATCH] drm/i915: Remove excess indent in intel_finish_reset() caught by sparse

2017-08-28 Thread Daniel Vetter
On Mon, Aug 28, 2017 at 11:46:04AM +0100, Chris Wilson wrote: > CHECK drivers/gpu/drm/i915/intel_display.c > drivers/gpu/drm/i915/intel_display.c:3753 intel_finish_reset() warn: > inconsistent indenting > > Signed-off-by: Chris Wilson Ooops, I think that was me :-( Reviewed-by: Daniel Vett

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/4] lib: Add some syncobj helpers (v2)

2017-08-28 Thread Patchwork
== Series Details == Series: series starting with [1/4] lib: Add some syncobj helpers (v2) URL : https://patchwork.freedesktop.org/series/29439/ State : success == Summary == IGT patchset tested on top of latest successful build d937dd7997059bc2801095ffb0c50f646da1ab01 docs: Add user documenta

[Intel-gfx] [PULL] drm-misc-next-fixes

2017-08-28 Thread Sean Paul
Hi Dave, Only one change in -misc-next-fixes as well. Simply a rename to use consistent types across ioctl structs. drm-misc-next-fixes-2017-08-28: UAPI Changes: - Rename u32 to __u32 in struct drm_format_modifier_blob (Lionel) Cc: Lionel Landwerlin Cheers, Sean The following changes since co

[Intel-gfx] [PULL] drm-misc-fixes

2017-08-28 Thread Sean Paul
Hi Dave, Apologies for the late pull req. This is a regression fix to a patch committed in Feb which prevents writes to an incorrect register. Andrzej: once this lands in Linus' tree, please send it over to stable@ so they can add it to the stable releases of the affected trees. drm-misc-fixes-2

[Intel-gfx] [PATCH i-g-t 2/4] tests/syncobj: Convert the basic test over to the helpers

2017-08-28 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- tests/syncobj_basic.c | 77 +-- 1 file changed, 19 insertions(+), 58 deletions(-) diff --git a/tests/syncobj_basic.c b/tests/syncobj_basic.c index a7a6742..0a304f1 100644 --- a/tests/syncobj_basic.c +++ b/tests/syn

[Intel-gfx] [PATCH i-g-t 3/4] tests/syncobj: Add some wait and reset tests (v7)

2017-08-28 Thread Jason Ekstrand
This adds both trivial error-checking tests as well as more complex tests which actually test whether or not waits do what they're supposed to do. They only currently work on i915 but it should be simple to hook them up for other drivers by simply implementing the little function pointer hook prov

[Intel-gfx] [PATCH i-g-t 4/4] syncobj: Add a test for SYNCOBJ_CREATE_SIGNALED

2017-08-28 Thread Jason Ekstrand
--- tests/syncobj_basic.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tests/syncobj_basic.c b/tests/syncobj_basic.c index 0a304f1..acc4a64 100644 --- a/tests/syncobj_basic.c +++ b/tests/syncobj_basic.c @@ -146,6 +146,16 @@ test_bad_create_flags(int fd) igt_assert(ret

[Intel-gfx] [PATCH i-g-t 1/4] lib: Add some syncobj helpers (v2)

2017-08-28 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- lib/Makefile.sources | 2 + lib/igt_syncobj.c| 207 +++ lib/igt_syncobj.h| 71 ++ 3 files changed, 280 insertions(+) create mode 100644 lib/igt_syncobj.c create mode 100644 lib/igt_synco

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Clear local engine-needs-reset bit if in progress elsewhere

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915: Clear local engine-needs-reset bit if in progress elsewhere URL : https://patchwork.freedesktop.org/series/29437/ State : warning == Summary == Test kms_flip: Subgroup basic-flip-vs-modeset: pass -> DMESG-WARN (shard-hsw)

Re: [Intel-gfx] [PATCH] drm/i915: Clear local engine-needs-reset bit if in progress elsewhere

2017-08-28 Thread Jeff McGee
On Mon, Aug 28, 2017 at 08:44:48PM +0100, Chris Wilson wrote: > Quoting jeff.mc...@intel.com (2017-08-28 20:25:30) > > From: Jeff McGee > > > > If someone else is resetting the engine we should clear our own bit as > > part of skipping that engine. Otherwise we will later believe that it > > has

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Always wake the device to flush the GTT

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915: Always wake the device to flush the GTT URL : https://patchwork.freedesktop.org/series/29436/ State : success == Summary == Test kms_flip: Subgroup plain-flip-ts-check: fail -> PASS (shard-hsw) Test kms_setmode:

Re: [Intel-gfx] [PATCH i-g-t v2 3/3] docs: Add user documentation about audio support

2017-08-28 Thread Lyude Paul
With some small typos I fixed (nothing major): Reviewed-by: Lyude Paul I've already pushed the patches upstream, thanks! On Mon, 2017-08-28 at 11:12 +0300, Paul Kocialkowski wrote: > This introduces plain-text documentation about the audio test, aimed > at > users who wish to setup and run the

Re: [Intel-gfx] [PATCH] drm/i915: Clear local engine-needs-reset bit if in progress elsewhere

2017-08-28 Thread Jeff McGee
On Mon, Aug 28, 2017 at 12:41:58PM -0700, Michel Thierry wrote: > On 28/08/17 12:25, jeff.mc...@intel.com wrote: > >From: Jeff McGee > > > >If someone else is resetting the engine we should clear our own bit as > >part of skipping that engine. Otherwise we will later believe that it > >has not bee

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Clear local engine-needs-reset bit if in progress elsewhere

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915: Clear local engine-needs-reset bit if in progress elsewhere URL : https://patchwork.freedesktop.org/series/29437/ State : success == Summary == Series 29437v1 drm/i915: Clear local engine-needs-reset bit if in progress elsewhere https://patchwork.freedes

Re: [Intel-gfx] [PATCH] drm/i915: Clear local engine-needs-reset bit if in progress elsewhere

2017-08-28 Thread Chris Wilson
Quoting jeff.mc...@intel.com (2017-08-28 20:25:30) > From: Jeff McGee > > If someone else is resetting the engine we should clear our own bit as > part of skipping that engine. Otherwise we will later believe that it > has not been reset successfully and then trigger full gpu reset. If the > othe

Re: [Intel-gfx] [PATCH] drm/i915: Clear local engine-needs-reset bit if in progress elsewhere

2017-08-28 Thread Michel Thierry
On 28/08/17 12:25, jeff.mc...@intel.com wrote: From: Jeff McGee If someone else is resetting the engine we should clear our own bit as part of skipping that engine. Otherwise we will later believe that it has not been reset successfully and then trigger full gpu reset. If the other guy's reset

[Intel-gfx] [PATCH] drm/i915: Clear local engine-needs-reset bit if in progress elsewhere

2017-08-28 Thread jeff . mcgee
From: Jeff McGee If someone else is resetting the engine we should clear our own bit as part of skipping that engine. Otherwise we will later believe that it has not been reset successfully and then trigger full gpu reset. If the other guy's reset actually fails, he will trigger the full gpu rese

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Always wake the device to flush the GTT

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915: Always wake the device to flush the GTT URL : https://patchwork.freedesktop.org/series/29436/ State : success == Summary == Series 29436v1 drm/i915: Always wake the device to flush the GTT https://patchwork.freedesktop.org/api/1.0/series/29436/revisions/1

[Intel-gfx] [PATCH] drm/i915: Always wake the device to flush the GTT

2017-08-28 Thread Chris Wilson
Experimental patch for bxt/gem_pwrite. --- drivers/gpu/drm/i915/i915_gem.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 37fbc64d9ffe..4f6af401320c 100644 --- a/drivers/gpu/drm/i915/i915_gem.c

Re: [Intel-gfx] [PATCH 3/4] drm/i915/bios: amend child device flags based on intel_vbt_decode

2017-08-28 Thread Jani Nikula
On Fri, 25 Aug 2017, Ville Syrjälä wrote: > On Fri, Aug 25, 2017 at 05:11:22PM +0300, Jani Nikula wrote: >> Copy over some fields defined in the intel_vbt_decode tool. No >> functional changes. >> >> Cc: Ville Syrjälä >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/intel_vbt_defs.

[Intel-gfx] ✓ Fi.CI.IGT: success for tools/intel_vbt_decode: switch to using kernel intel_vbt_defs.h

2017-08-28 Thread Patchwork
== Series Details == Series: tools/intel_vbt_decode: switch to using kernel intel_vbt_defs.h URL : https://patchwork.freedesktop.org/series/29427/ State : success == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test perf:

[Intel-gfx] ✗ Fi.CI.BAT: warning for tests/chamelium: Let the Chamelium itself wait for a stable video input

2017-08-28 Thread Patchwork
== Series Details == Series: tests/chamelium: Let the Chamelium itself wait for a stable video input URL : https://patchwork.freedesktop.org/series/29432/ State : warning == Summary == IGT patchset tested on top of latest successful build 60f6a12195395934f179d5ecc080353190d19a6c tests: chameli

[Intel-gfx] [PATCH i-g-t] tests/chamelium: Let the Chamelium itself wait for a stable video input

2017-08-28 Thread Paul Kocialkowski
Before capturing video, the Chamelium will always wait for the video input to be stable (and perform the FSM if it was not). This means that there is no need to explicitly do it beforehand. When the receiver needs to be reset, the call will result in a timeout, after which the follow-up call to ca

Re: [Intel-gfx] [PATCH 00/12] drm/i915: Fix up the CCS code

2017-08-28 Thread Ville Syrjälä
On Mon, Aug 28, 2017 at 02:35:54PM +0100, Daniel Stone wrote: > Hi Daniel, > > On 25 August 2017 at 18:17, Daniel Vetter wrote: > > Which of these do we need to cherry-pick over to -next-fixes? There's no > > annotations about that. If the answer is "most" I'm leaning towards > > disabling CCS fo

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Beef up of Beef up the IPS vs. CRC workaround (rev2)

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915: Beef up of Beef up the IPS vs. CRC workaround (rev2) URL : https://patchwork.freedesktop.org/series/29425/ State : success == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test perf:

Re: [Intel-gfx] [PATCH v2] drm/i915: Beef up of Beef up the IPS vs. CRC workaround

2017-08-28 Thread Ville Syrjälä
On Mon, Aug 28, 2017 at 03:18:10PM +0300, Marta Lofstedt wrote: > Commit 6e644626945c7c1a7f4d4f83b806b898297846d0 was I fixed that commit reference to use the correct format and pushed the patch to dinq. Thanks for fixing my mess. > supposed to solve below bug. However, the patch I tested > is no

Re: [Intel-gfx] [PATCH 18/23] drm/i915/selftests: huge page tests

2017-08-28 Thread Chris Wilson
Excuse the piggy-backing, the original never arrived! +static int cpu_check(struct drm_i915_gem_object *obj, u32 dword, u32 val) +{ + enum i915_map_type level; + int err; + + for (level = I915_MAP_WB; level <= I915_MAP_WC; level++) { + u32 *map, offset; + +

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_chamelium: Remove any special handling for the connector FSM

2017-08-28 Thread Paul Kocialkowski
On Fri, 2017-08-04 at 17:10 +0300, Paul Kocialkowski wrote: > No specific treatment should be required for handling the connector > FSM, > since the chamelium-side daemon will automatically send an HPD event > to > reset the source. > > The event is sufficient to make the receiver on the chamelium

Re: [Intel-gfx] [PATCH v2 00/10] Improve robustness of the i915 perf tests

2017-08-28 Thread Arkadiusz Hiler
On Mon, Aug 28, 2017 at 02:33:13PM +0100, Lionel Landwerlin wrote: > On 28/08/17 08:21, Arkadiusz Hiler wrote: > > On Wed, Aug 23, 2017 at 10:43:08AM +0100, Lionel Landwerlin wrote: > > > Hi all, > > > > > > Here is an updated patch series containing mostly cleanups. > > > > > > Cheers, > > Hi, >

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: dspaddr_offset doesn't need to be more than local variable

2017-08-28 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: dspaddr_offset doesn't need to be more than local variable URL : https://patchwork.freedesktop.org/series/29429/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/versi

[Intel-gfx] [PATCH 2/3] drm/i915: Unify skylake plane update

2017-08-28 Thread Juha-Pekka Heikkila
Don't handle skylake primary plane separately as it is similar plane as the others. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/intel_display.c | 79 +--- drivers/gpu/drm/i915/intel_drv.h | 3 ++ drivers/gpu/drm/i915/intel_sprite.c | 2 +- 3

[Intel-gfx] [PATCH 3/3] drm/i915: Unify skylake plane disable

2017-08-28 Thread Juha-Pekka Heikkila
Don't handle skylake primary plane separately as it is similar plane as the others. Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/intel_display.c | 19 +-- drivers/gpu/drm/i915/intel_drv.h | 1 + drivers/gpu/drm/i915/intel_sprite.c | 2 +- 3 files changed, 3

[Intel-gfx] [PATCH 1/3] drm/i915: dspaddr_offset doesn't need to be more than local variable

2017-08-28 Thread Juha-Pekka Heikkila
Move u32 dspaddr_offset from struct intel_crtc member into local variable in i9xx_update_primary_plane() Signed-off-by: Juha-Pekka Heikkila --- drivers/gpu/drm/i915/intel_display.c | 11 ++- drivers/gpu/drm/i915/intel_drv.h | 1 - 2 files changed, 6 insertions(+), 6 deletions(-) di

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Recreate vmapping even when the object is pinned (rev2)

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915: Recreate vmapping even when the object is pinned (rev2) URL : https://patchwork.freedesktop.org/series/29388/ State : success == Summary == shard-hswtotal:2230 pass:1232 dwarn:0 dfail:0 fail:16 skip:982 time:9615s == Logs == For more detai

Re: [Intel-gfx] [PATCH v2] drm/i915: Recreate vmapping even when the object is pinned

2017-08-28 Thread Joonas Lahtinen
On Mon, 2017-08-28 at 11:46 +0100, Chris Wilson wrote: > Sometimes we know we are the only user of the bo, but since we take a > protective pin_pages early on, an attempt to change the vmap on the > object is denied because it is busy. i915_gem_object_pin_map() cannot > tell from our single pin_cou

Re: [Intel-gfx] [PATCH 00/12] drm/i915: Fix up the CCS code

2017-08-28 Thread Daniel Stone
Hi Daniel, On 25 August 2017 at 18:17, Daniel Vetter wrote: > Which of these do we need to cherry-pick over to -next-fixes? There's no > annotations about that. If the answer is "most" I'm leaning towards > disabling CCS for 4.14, minimal set would be ideal (and first in the patch > series). My

Re: [Intel-gfx] [PATCH v2 00/10] Improve robustness of the i915 perf tests

2017-08-28 Thread Lionel Landwerlin
On 28/08/17 08:21, Arkadiusz Hiler wrote: On Wed, Aug 23, 2017 at 10:43:08AM +0100, Lionel Landwerlin wrote: Hi all, Here is an updated patch series containing mostly cleanups. Cheers, Hi, Our CI hasn't pick this series up for a spin due to missing a "i-g-t" tag. Direct quote from CONTRIBUT

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Remove excess indent in intel_finish_reset() caught by sparse

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915: Remove excess indent in intel_finish_reset() caught by sparse URL : https://patchwork.freedesktop.org/series/29424/ State : warning == Summary == Test perf: Subgroup blocking: pass -> FAIL (shard-hsw) fdo#102252 Test km

[Intel-gfx] ✓ Fi.CI.BAT: success for tools/intel_vbt_decode: switch to using kernel intel_vbt_defs.h

2017-08-28 Thread Patchwork
== Series Details == Series: tools/intel_vbt_decode: switch to using kernel intel_vbt_defs.h URL : https://patchwork.freedesktop.org/series/29427/ State : success == Summary == IGT patchset tested on top of latest successful build 60f6a12195395934f179d5ecc080353190d19a6c tests: chamelium: Elim

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Beef up of Beef up the IPS vs. CRC workaround (rev2)

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915: Beef up of Beef up the IPS vs. CRC workaround (rev2) URL : https://patchwork.freedesktop.org/series/29425/ State : success == Summary == Series 29425v2 drm/i915: Beef up of Beef up the IPS vs. CRC workaround https://patchwork.freedesktop.org/api/1.0/serie

[Intel-gfx] [i-g-t PATCH 07/10] tools/intel_vbt_decode: migrate psr dumping to kernel struct

2017-08-28 Thread Jani Nikula
No functional changes. Signed-off-by: Jani Nikula --- tools/intel_bios.h | 15 --- tools/intel_vbt_decode.c | 26 ++ tools/intel_vbt_defs.h | 18 ++ 3 files changed, 32 insertions(+), 27 deletions(-) diff --git a/tools/intel_bios.h b/t

[Intel-gfx] [i-g-t PATCH 06/10] tools/intel_vbt_decode: migrate child device dumping to kernel struct

2017-08-28 Thread Jani Nikula
Retain the legacy definition for the obsolete child device block, at least for now. No functional changes. Signed-off-by: Jani Nikula --- tools/intel_bios.h | 58 + tools/intel_vbt_decode.c | 45 ++- tools/intel_vbt_defs.h | 96

[Intel-gfx] [i-g-t PATCH 08/10] tools/intel_vbt_decode: migrate edp dumping to kernel struct

2017-08-28 Thread Jani Nikula
No functional changes. Signed-off-by: Jani Nikula --- tools/intel_bios.h | 33 - tools/intel_vbt_decode.c | 7 --- tools/intel_vbt_defs.h | 35 +++ 3 files changed, 39 insertions(+), 36 deletions(-) diff --git a/tools/

[Intel-gfx] [i-g-t PATCH 10/10] tools/intel_vbt_defs: migrate backlight dumping to kernel struct

2017-08-28 Thread Jani Nikula
Drop obsolete field dumping. Signed-off-by: Jani Nikula --- tools/intel_bios.h | 16 tools/intel_vbt_decode.c | 20 2 files changed, 8 insertions(+), 28 deletions(-) diff --git a/tools/intel_bios.h b/tools/intel_bios.h index 85aa38e085be..4e06ef74e459

[Intel-gfx] [i-g-t PATCH 09/10] tools/intel_vbt_decode: migrate child device type bits decoding to kernel defs

2017-08-28 Thread Jani Nikula
This lets us use the verbatim copy of the kernel intel_vbt_defs.h file. Signed-off-by: Jani Nikula --- tools/intel_bios.h | 18 -- tools/intel_vbt_decode.c | 47 +-- tools/intel_vbt_defs.h | 16 3 files changed,

[Intel-gfx] [i-g-t PATCH 04/10] tools/intel_vbt_decode: start migrating to kernel intel_vbt_defs.h

2017-08-28 Thread Jani Nikula
Copy over most of intel_vbt_defs.h, and use everything that matches with minor changes from there. Signed-off-by: Jani Nikula --- tools/intel_bios.h | 305 - tools/intel_vbt_decode.c | 20 +- tools/intel_vbt_defs.h | 701 ++

[Intel-gfx] [i-g-t PATCH 00/10] tools/intel_vbt_decode: switch to using kernel intel_vbt_defs.h

2017-08-28 Thread Jani Nikula
There's little point in duplicating the efforts of describing the same data in two places. This series lets us use the verbatim copy of the intel_vbt_defs.h from kernel. Going forward, we should add the changes in kernel first, then copy the header over to igt. If we need local tweaks, we can stil

[Intel-gfx] [i-g-t PATCH 02/10] tools/intel_vbt_decode: remove unused definitions from intel_bios.h

2017-08-28 Thread Jani Nikula
This is prep work for refactoring VBT definitions. Signed-off-by: Jani Nikula --- tools/intel_bios.h | 268 - 1 file changed, 268 deletions(-) diff --git a/tools/intel_bios.h b/tools/intel_bios.h index f2ccb55ab6c3..c998031041fd 100644 --- a/t

[Intel-gfx] [i-g-t PATCH 03/10] tools/intel_vbt_decode: clean up struct lvds_dvo_timing

2017-08-28 Thread Jani Nikula
For reasons unknown, we have two copies of the struct. Deduplicate. Signed-off-by: Jani Nikula --- tools/intel_bios.h | 19 --- tools/intel_vbt_decode.c | 6 +++--- 2 files changed, 3 insertions(+), 22 deletions(-) diff --git a/tools/intel_bios.h b/tools/intel_bios.h inde

[Intel-gfx] [i-g-t PATCH 05/10] tools/intel_vbt_decode: migrate timing dumping to kernel struct

2017-08-28 Thread Jani Nikula
Adapt the dumping according to the changes, and do what the kernel does. Signed-off-by: Jani Nikula --- tools/intel_bios.h | 28 tools/intel_vbt_decode.c | 9 ++--- tools/intel_vbt_defs.h | 31 +++ 3 files changed, 37 insertio

[Intel-gfx] [i-g-t PATCH 01/10] tools/intel_lid: use local register definition

2017-08-28 Thread Jani Nikula
This makes the future intel_vbt_decode refactoring easier. Signed-off-by: Jani Nikula --- tools/intel_lid.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/intel_lid.c b/tools/intel_lid.c index 0703e2e1e14e..37c6ba5e443f 100644 --- a/tools/intel_lid.c +++ b/tools/i

[Intel-gfx] [PATCH v2] drm/i915: Beef up of Beef up the IPS vs. CRC workaround

2017-08-28 Thread Marta Lofstedt
Commit 6e644626945c7c1a7f4d4f83b806b898297846d0 was supposed to solve below bug. However, the patch I tested is not the same as the one that got merged. With this addition the test pass. V2: removed unused: "struct intel_crtc *intel_crtc" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/1] igt/dapc: Test Driver Assisted Performance Capture (DAPC)

2017-08-28 Thread Patchwork
== Series Details == Series: series starting with [1/1] igt/dapc: Test Driver Assisted Performance Capture (DAPC) URL : https://patchwork.freedesktop.org/series/29418/ State : failure == Summary == IGT patchset build failed on latest successful build 60f6a12195395934f179d5ecc080353190d19a6c t

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Beef up of Beef up the IPS vs. CRC workaround

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915: Beef up of Beef up the IPS vs. CRC workaround URL : https://patchwork.freedesktop.org/series/29425/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelea

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Recreate vmapping even when the object is pinned (rev2)

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915: Recreate vmapping even when the object is pinned (rev2) URL : https://patchwork.freedesktop.org/series/29388/ State : success == Summary == Series 29388v2 drm/i915: Recreate vmapping even when the object is pinned https://patchwork.freedesktop.org/api/1.0

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove excess indent in intel_finish_reset() caught by sparse

2017-08-28 Thread Patchwork
== Series Details == Series: drm/i915: Remove excess indent in intel_finish_reset() caught by sparse URL : https://patchwork.freedesktop.org/series/29424/ State : success == Summary == Series 29424v1 drm/i915: Remove excess indent in intel_finish_reset() caught by sparse https://patchwork.fre

[Intel-gfx] [PATCH] drm/i915: Beef up of Beef up the IPS vs. CRC workaround

2017-08-28 Thread Marta Lofstedt
Commit 6e644626945c7c1a7f4d4f83b806b898297846d0 was supposed to solve below bug. However, the patch I tested is not the same as the one that got merged. With this addition the test pass. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101664 Signed-off-by: Marta Lofstedt --- drivers/gpu/

[Intel-gfx] ✗ Fi.CI.BAT: failure for Adding NV12 support (rev2)

2017-08-28 Thread Patchwork
== Series Details == Series: Adding NV12 support (rev2) URL : https://patchwork.freedesktop.org/series/28103/ State : failure == Summary == Series 28103v2 Adding NV12 support https://patchwork.freedesktop.org/api/1.0/series/28103/revisions/2/mbox/ Test gem_exec_flush: Subgroup basic-b

[Intel-gfx] ✗ Fi.CI.IGT: failure for i915 perf support for command stream based OA, GPU and workload metrics capture (rev2)

2017-08-28 Thread Patchwork
== Series Details == Series: i915 perf support for command stream based OA, GPU and workload metrics capture (rev2) URL : https://patchwork.freedesktop.org/series/28104/ State : failure == Summary == Test perf: Subgroup short-reads: pass -> FAIL (shard-hsw)

[Intel-gfx] [PATCH v2] drm/i915: Recreate vmapping even when the object is pinned

2017-08-28 Thread Chris Wilson
Sometimes we know we are the only user of the bo, but since we take a protective pin_pages early on, an attempt to change the vmap on the object is denied because it is busy. i915_gem_object_pin_map() cannot tell from our single pin_count if the operation is safe. Instead we must pass that informat

[Intel-gfx] [PATCH] drm/i915: Remove excess indent in intel_finish_reset() caught by sparse

2017-08-28 Thread Chris Wilson
CHECK drivers/gpu/drm/i915/intel_display.c drivers/gpu/drm/i915/intel_display.c:3753 intel_finish_reset() warn: inconsistent indenting Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 5/6] drm/i915: Add NV12 as supported format for sprite plane

2017-08-28 Thread Vidya Srinivas
From: Chandra Konduru This patch adds NV12 to list of supported formats for sprite plane. v2: Rebased (me) v3: Review comments by Ville addressed - Removed skl_plane_formats_with_nv12 and added NV12 case in existing skl_plane_formats - Added the 10bpc RGB formats v4: Ad

[Intel-gfx] [PATCH 3/6] drm/i915: Upscale scaler max scale for NV12

2017-08-28 Thread Vidya Srinivas
From: Chandra Konduru This patch updates scaler max limit support for NV12 v2: Rebased (me) v3: Rebased (me) v4: Missed the Tested-by/Reviewed-by in the previous series Adding the same to commit message in this version. v5: Addressed review comments from Ville and rebased - ca

[Intel-gfx] [PATCH 1/6] drm/i915: Set scaler mode for NV12

2017-08-28 Thread Vidya Srinivas
From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling v2: Review comments from Ville addressed NV12 case to be checked first for setting the scaler v3:

[Intel-gfx] [PATCH 6/6] drm/i915: Add NV12 support to intel_framebuffer_init

2017-08-28 Thread Vidya Srinivas
From: Chandra Konduru This patch adds NV12 as supported format to intel_framebuffer_init and performs various checks. v2: -Fix an issue in checks added (Chandra Konduru) v3: rebased (me) v4: Review comments by Ville addressed Added platform check for NV12 in intel_framebuffer_init

[Intel-gfx] [PATCH 4/6] drm/i915: Add NV12 as supported format for primary plane

2017-08-28 Thread Vidya Srinivas
From: Chandra Konduru This patch adds NV12 to list of supported formats for primary plane v2: Rebased (Chandra Konduru) v3: Rebased (me) v4: Review comments by Ville addressed Removed the skl_primary_formats_with_nv12 and added NV12 case in existing skl_primary_formats v5: Reb

[Intel-gfx] [PATCH 2/6] drm/i915: Update format_is_yuv() to include NV12

2017-08-28 Thread Vidya Srinivas
From: Chandra Konduru This patch adds NV12 to format_is_yuv() function for sprite planes. v2: -Use intel_ prefix for format_is_yuv (Ville) v3: Rebased (me) v4: Rebased and addressed review comments from Clinton A Taylor. "static function in intel_sprite.c is not available to th

[Intel-gfx] [PATCH 0/6] Adding NV12 support

2017-08-28 Thread Vidya Srinivas
This patch series is adding NV12 support for Broxton display after rebasing on latest drm-intel-nightly. Initial series of the patches can be found here: https://lists.freedesktop.org/archives/intel-gfx/2015-May/066786.html Previous revision history: Patches were initial reviewed last when floated

Re: [Intel-gfx] [PATCH i-g-t] pm_rps: Extended testcases with checking PMINTRMSK register value

2017-08-28 Thread Dec, Katarzyna
On Wed, 2017-08-23 at 17:04 +0200, Daniel Vetter wrote: > On Tue, Aug 22, 2017 at 01:14:19PM +, Szwichtenberg, Radoslaw > wrote: > > On Tue, 2017-08-22 at 13:33 +0100, Chris Wilson wrote: > > > Quoting Szwichtenberg, Radoslaw (2017-08-22 12:56:00) > > > > On Tue, 2017-08-22 at 01:31 +0300, Arka

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/8] drm/i915: Separate GuC/HuC specific functionality from intel_uc

2017-08-28 Thread Patchwork
== Series Details == Series: series starting with [1/8] drm/i915: Separate GuC/HuC specific functionality from intel_uc URL : https://patchwork.freedesktop.org/series/29420/ State : failure == Summary == Series 29420v1 series starting with [1/8] drm/i915: Separate GuC/HuC specific functional

[Intel-gfx] ✗ Fi.CI.IGT: warning for pm_rps: Changes in waitboost scenario (rev6)

2017-08-28 Thread Patchwork
== Series Details == Series: pm_rps: Changes in waitboost scenario (rev6) URL : https://patchwork.freedesktop.org/series/28966/ State : warning == Summary == Test kms_setmode: Subgroup basic: pass -> FAIL (shard-hsw) fdo#99912 Test tools_test: Subgro

[Intel-gfx] ✓ Fi.CI.BAT: success for i915 perf support for command stream based OA, GPU and workload metrics capture (rev2)

2017-08-28 Thread Patchwork
== Series Details == Series: i915 perf support for command stream based OA, GPU and workload metrics capture (rev2) URL : https://patchwork.freedesktop.org/series/28104/ State : success == Summary == Series 28104v2 i915 perf support for command stream based OA, GPU and workload metrics captu

Re: [Intel-gfx] [PATCH 5/8] drm/i915/guc: Change default GuC FW for SKL to v9.33

2017-08-28 Thread Daniel Stone
Hi Sagar, On 28 August 2017 at 10:56, Sagar Arun Kamble wrote: > This patch makes v9.33 firmware as default firmware for SKL. > This update includes (since v6.1): https://01.org/linuxgraphics/downloads/firmware does not include v9.33, only 6.1. Please do not push this patch until it has at leas

[Intel-gfx] [PATCH 8/8] HAX enable guc submission for CI

2017-08-28 Thread Sagar Arun Kamble
From: Chris Wilson --- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c index 38dd283..d16dc39 100644 --- a/drivers/gpu/drm/i915/i915_params.c +++ b/drivers/gpu/drm/

[Intel-gfx] [PATCH 3/8] drm/i915/guc: Fix GuC HW/SW state cleanup in unload path

2017-08-28 Thread Sagar Arun Kamble
Teardown of GuC HW/SW state was not properly done in unload path. During unload, we can rely on intel_guc_reset_prepare being done as part of i915_gem_suspend for disabling GuC interfaces. We will have to disable GuC submission prior to suspend as that involves communication with GuC to destroy doo

[Intel-gfx] [PATCH 4/8] drm/i915/guc: Disable critical logging in GuC by default from GuC v9

2017-08-28 Thread Sagar Arun Kamble
critical logging in GuC to enable capturing minimal important logs in production systems. i915.guc_log_level controls the verbosity and logging in GuC for logs other than critical logs. By default, logging in GuC is disabled through i915.guc_log_level. This patch introduces new kernel param i915.en

[Intel-gfx] [PATCH 7/8] drm/i915/guc: Change default GuC FW for KBL to v9.39

2017-08-28 Thread Sagar Arun Kamble
This patch makes v9.39 firmware as default firmware for KBL. This update includes (since v9.14): - DCC spec changes for BXT + DCT enabling - Bug Fix for power conservation feature SLPC_DCC - Scheduler 1-element submission during DCC cycles. - SB based Pre-ETM/ETM flow enabling for debug signed GuC

[Intel-gfx] [PATCH 5/8] drm/i915/guc: Change default GuC FW for SKL to v9.33

2017-08-28 Thread Sagar Arun Kamble
This patch makes v9.33 firmware as default firmware for SKL. This update includes (since v6.1): - HuC RSA Keys updated. - Adding per engine preemption support in GuC scheduler - Minor bug fixes. - Added support to log media reset count for host to read it - Sub-feature level control for power mana

[Intel-gfx] [PATCH 2/8] drm/i915/guc: Fix GuC interaction in reset/suspend scenarios

2017-08-28 Thread Sagar Arun Kamble
Tearing down of guc_ggtt_invalidate/guc_interrupts/guc_communication setup should happen towards end of reset/suspend as these are setup back again during recovery/resume. Prepared helpers intel_guc_pause and intel_guc_unpause that will do teardown/bringup of this setup along with suspension/resum

[Intel-gfx] [PATCH 6/8] drm/i915/guc: Change default GuC FW for BXT to v9.29

2017-08-28 Thread Sagar Arun Kamble
This patch makes v9.29 firmware as default firmware for BXT. This update includes (since v8.7): - Added support to log media reset count for host to read it - BXT WA for fixing MTP hangs. WaDisableDOPRenderClkGatingAtSubmit - Sub-feature level control for power management features. - Minor clean-u

[Intel-gfx] [PATCH 1/8] drm/i915: Separate GuC/HuC specific functionality from intel_uc

2017-08-28 Thread Sagar Arun Kamble
Removed unnecessary intel_uc.h includes as it is present in i915_drv.h. Created intel_guc.c and intel_guc.h for placing GuC specific code. Created intel_huc.h to refer to HuC specific functions. v2: Prepared intel_uc_common.h. huc_auth code declaration adjusted. Moved enable/disable_communication

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for igt/gem_exec_nop: Headless requires DRM_MASTER for modesetting

2017-08-28 Thread Petri Latvala
On Sat, Aug 26, 2017 at 02:17:40PM +, Patchwork wrote: > CC gem_exec_nop.o > Makefile:3922: recipe for target 'gem_exec_nop.o' failed > Makefile:4407: recipe for target 'all-recursive' failed > Makefile:530: recipe for target 'all-recursive' failed > Makefile:462: recipe for target 'all

  1   2   >