Re: [Intel-gfx] [PATCH] drm/i915: Add more latency to avoid display flicker

2017-08-23 Thread Mahesh Kumar
Hi, Adding random latency is not a right solution for any flicker. This will affect the configuration which can be supported in all other platforms. There are many unanswered questions here: Which customer? which platform? changes & root-cause of the issue? Please find what are the changes in

Re: [Intel-gfx] [maintainer-tools PATCH] qf: Fix qf_help: Remove attempt to grab DIM_PREFIX.

2017-08-23 Thread Daniel Vetter
On Wed, Aug 23, 2017 at 10:36:22AM -0700, Rodrigo Vivi wrote: > This is not available here nor will be available on > qfrc. So let's avoid duplication and just grab the qf.rst > file from whatever repository this command is called from. > > Cc: Jani Nikula > Cc: Daniel Vetter > Cc: Joonas Lahtin

Re: [Intel-gfx] [maintainer-tools PATCH] qf: Introduce .qfrc.

2017-08-23 Thread Daniel Vetter
On Wed, Aug 23, 2017 at 10:23:34AM -0700, Rodrigo Vivi wrote: > Soon we will need to extend qf for very specific > usages of our internal maintenance and rebase bot. > > So let's start with the only environment configuration > we have but also let's allow qfrc to extend qf commands > and aliases.

Re: [Intel-gfx] [PATCH 1/2] mm: Track actual nr_scanned during shrink_slab()

2017-08-23 Thread Minchan Kim
Hello Chris, On Tue, Aug 22, 2017 at 02:53:24PM +0100, Chris Wilson wrote: > Some shrinkers may only be able to free a bunch of objects at a time, and > so free more than the requested nr_to_scan in one pass. Whilst other > shrinkers may find themselves even unable to scan as many objects as > the

[Intel-gfx] glxgears corruption when plug power adapter, no without

2017-08-23 Thread Wang, Quanxian
Hi, All Anyone could give me a hint about that? Platform is KBL (8086:5917, 8086:5916) https://bugs.freedesktop.org/show_bug.cgi?id=101691 Thanks Regards Quanxian Wang ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesk

Re: [Intel-gfx] [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result

2017-08-23 Thread Manasi Navare
On Wed, Aug 23, 2017 at 03:40:28PM -0700, Puthikorn Voravootivat wrote: > If the full detect is already done, we shouldn't need to do it > again. > > This fixes the screen blinking issue that happen when calling > DRM_IOCTL_MODE_GETCONNECTOR while PSR is active. The blinking > is caused by full dp

[Intel-gfx] ✗ Fi.CI.BAT: failure for igt/gem_ringfill: Adds ringbuffer full preemption test

2017-08-23 Thread Patchwork
== Series Details == Series: igt/gem_ringfill: Adds ringbuffer full preemption test URL : https://patchwork.freedesktop.org/series/29252/ State : failure == Summary == IGT patchset build failed on latest successful build 7552c5af1f43386424085c32bca3cbd0cb0dfe48 intel-ci: Add fast chamelium tes

[Intel-gfx] [PATCH i-g-t] igt/gem_ringfill: Adds ringbuffer full preemption test

2017-08-23 Thread Antonio Argenziano
The testcase added here, stimulates this scenario where a high priority request is sent while another process keeps submitting requests and filling its ringbuffer. From RFC (Chris): - Use two FDs, one for each priority submission. - Move from gem_ringfill to gem_exec_schedule.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Make some RPS functions static

2017-08-23 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Make some RPS functions static URL : https://patchwork.freedesktop.org/series/29251/ State : success == Summary == Series 29251v1 series starting with [1/2] drm/i915: Make some RPS functions static https://patchwork.freedesktop

Re: [Intel-gfx] [PATCH] drm/i915: Allow null render state batchbuffers bigger than one page

2017-08-23 Thread Rodrigo Vivi
On Tue, Jul 18, 2017 at 8:15 AM, Oscar Mateo wrote: > > > > On 07/14/2017 08:08 AM, Chris Wilson wrote: >> >> Quoting Oscar Mateo (2017-07-14 15:52:59) >>> >>> >>> >>> On 07/13/2017 03:28 PM, Rodrigo Vivi wrote: On Wed, May 3, 2017 at 9:31 AM, Chris Wilson wrote: > > On Wed

[Intel-gfx] [PATCH 2/2] drm/i915: Create vfuncs for the reset/enable/disable GuC functions

2017-08-23 Thread Oscar Mateo
Facilitates creating Gen-specific versions of these functions later on. Cc: Rodrigo Vivi Cc: Tvrtko Ursulin Cc: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Signed-off-by: Oscar Mateo --- drivers/gpu/drm/i915/i915_guc_submission.c | 4 ++-- drivers/gpu/drm/i915/i915_irq.c| 12 +++

[Intel-gfx] [PATCH 1/2] drm/i915: Make some RPS functions static

2017-08-23 Thread Oscar Mateo
They are not used anywhere else. Also, fix a small typo in a comment. No functional changes. Cc: Sagar Arun Kamble Cc: Rodrigo Vivi Signed-off-by: Oscar Mateo --- drivers/gpu/drm/i915/i915_irq.c | 8 drivers/gpu/drm/i915/intel_drv.h | 3 --- 2 files changed, 4 insertions(+), 7 delet

Re: [Intel-gfx] [RFC v2 3/3] drm/i915/pmu: deny perf driver level sampling of i915 PMU

2017-08-23 Thread Rogozhkin, Dmitry V
Hi Chris, Why we had event->hw->hrtimer in i915 PMU? Was there any particular reason? You had some use case which did not work? According to Peter we should not expose the timer out of our pmu, and I do not see the reason why we need it at the first place. So, I went forward and wiped it out and

Re: [Intel-gfx] [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result

2017-08-23 Thread Rodrigo Vivi
On Wed, Aug 23, 2017 at 4:32 PM, Puthikorn Voravootivat wrote: >> what about instead of removing this "detect_done=false" like we move >> to another place like whenever conector is disconected? > > Look like that is already done in > https://patchwork.freedesktop.org/patch/113363/ hmm indeed that

Re: [Intel-gfx] [RFC v2 2/3] drm/i915/pmu: serve global events and support perf stat

2017-08-23 Thread Rogozhkin, Dmitry V
On Wed, 2017-08-23 at 08:26 -0700, Dmitry Rogozhkin wrote: > +static cpumask_t i915_pmu_cpumask = CPU_MASK_CPU0; Peter, this hardcoding of cpumask to use CPU0 works, but should I implement something smarter or this will be sufficient? I see that cstate.c you have pointed me to tries to track CPUs

Re: [Intel-gfx] [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result

2017-08-23 Thread Puthikorn Voravootivat
> what about instead of removing this "detect_done=false" like we move > to another place like whenever conector is disconected? Look like that is already done in https://patchwork.freedesktop.org/patch/113363/ On Wed, Aug 23, 2017 at 4:00 PM, Rodrigo Vivi wrote: > On Wed, Aug 23, 2017 at 3:40 P

[Intel-gfx] [RFC v2 2/3] drm/i915/pmu: serve global events and support perf stat

2017-08-23 Thread Dmitry Rogozhkin
This patch should probably be squashed with Tvrtko's PMU enabling patch... Making perf-stat workable with i915 PMU. The major point is that current implementation of i915 PMU exposes global counter rather thatn per-task counters. Thus, required changes are: * Register PMU with .task_ctx_nr=perf_in

[Intel-gfx] [RFC v2 3/3] drm/i915/pmu: deny perf driver level sampling of i915 PMU

2017-08-23 Thread Dmitry Rogozhkin
This patch should probably be squashed with Tvrtko's PMU enabling patch... As per discussion with Peter, i915 PMU is an example of uncore PMU which are prohibited to support perf driver level sampling. This patch removes hrtimer which we expose to perf core and denies events creation with non-zero

[Intel-gfx] [RFC v2 1/3] drm/i915/pmu: reorder function to suite next patch

2017-08-23 Thread Dmitry Rogozhkin
This patch is doing nover except reordering functions to highlight changes in the next patch. Change-Id: I0cd298780503ae8f6f8035b86c59fc8b5191356b Signed-off-by: Dmitry Rogozhkin Cc: Tvrtko Ursulin Cc: Peter Zijlstra --- drivers/gpu/drm/i915/i915_pmu.c | 180 ---

[Intel-gfx] [RFC v2 0/3] Support perf stat with i915 PMU

2017-08-23 Thread Dmitry Rogozhkin
These patches depend on the RFC patches enabling i915 PMU from Tvrtko: https://patchwork.freedesktop.org/series/27488/ Thus, CI failure to build them is expected. I think that my patches should be squeashed in Tvrtko's one actually. The first patch simply reorders functions and does nothing comp

Re: [Intel-gfx] [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result

2017-08-23 Thread Rodrigo Vivi
On Wed, Aug 23, 2017 at 3:40 PM, Puthikorn Voravootivat wrote: > If the full detect is already done, we shouldn't need to do it > again. > > This fixes the screen blinking issue that happen when calling > DRM_IOCTL_MODE_GETCONNECTOR while PSR is active. The blinking > is caused by full dp detect i

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Don't invalidate intel_dp_detect result

2017-08-23 Thread Patchwork
== Series Details == Series: drm/i915/dp: Don't invalidate intel_dp_detect result URL : https://patchwork.freedesktop.org/series/29247/ State : success == Summary == Series 29247v1 drm/i915/dp: Don't invalidate intel_dp_detect result https://patchwork.freedesktop.org/api/1.0/series/29247/revis

[Intel-gfx] [drm-intel:drm-intel-nightly 1258/1268] drivers/gpu/drm/tve200/tve200_display.c:339:9: error: passing argument 6 of 'drm_simple_display_pipe_init' from incompatible pointer type

2017-08-23 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-nightly head: 3adc9e3cacefe82619fc56ec78a0ca3a67a4b00c commit: 179c02fe90a4104d32e92a46b9ff4ecc32bf3647 [1258/1268] drm/tve200: Add new driver for TVE200 config: i386-allmodconfig (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2

[Intel-gfx] [PATCH] drm/i915/dp: Don't invalidate intel_dp_detect result

2017-08-23 Thread Puthikorn Voravootivat
If the full detect is already done, we shouldn't need to do it again. This fixes the screen blinking issue that happen when calling DRM_IOCTL_MODE_GETCONNECTOR while PSR is active. The blinking is caused by full dp detect in intel_dp_long_pulse(). Signed-off-by: Puthikorn Voravootivat --- drive

Re: [Intel-gfx] [PATCH 01/23] mm/shmem: introduce shmem_file_setup_with_mnt

2017-08-23 Thread Andrew Morton
On Wed, 23 Aug 2017 12:31:28 +0300 Joonas Lahtinen wrote: > This patch has been floating around for a while now Acked and without > further comments. It is blocking us from merging huge page support to > drm/i915. > > Would you mind merging it, or prodding the right people to get it in? > > Re

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc : Enable GuC logs even when submission is not enabled

2017-08-23 Thread Srivatsa, Anusha
>-Original Message- >From: Sundaresan, Sujaritha >Sent: Wednesday, August 23, 2017 3:13 PM >To: intel-gfx@lists.freedesktop.org >Cc: Sundaresan, Sujaritha ; Ceraolo Spurio, >Daniele ; Lahtinen, Joonas >; Srivatsa, Anusha >Subject: [PATCH 2/2] drm/i915/guc : Enable GuC logs even when subm

Re: [Intel-gfx] [PATCH 1/2] drm/i915/guc : Removing enable_guc_loading module

2017-08-23 Thread Srivatsa, Anusha
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Sujaritha Sundaresan >Sent: Wednesday, August 23, 2017 3:12 PM >To: intel-gfx@lists.freedesktop.org >Cc: Lahtinen, Joonas ; Sundaresan, Sujaritha > >Subject: [Intel-gfx] [PATCH 1/2] drm/i91

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: WaForceEnableNonCoherent

2017-08-23 Thread Patchwork
== Series Details == Series: drm/i915/cnl: WaForceEnableNonCoherent URL : https://patchwork.freedesktop.org/series/29243/ State : success == Summary == Series 29243v1 drm/i915/cnl: WaForceEnableNonCoherent https://patchwork.freedesktop.org/api/1.0/series/29243/revisions/1/mbox/ Test kms_pipe_

Re: [Intel-gfx] [PATCH 0/2] Changes to GuC loading and GuC logs

2017-08-23 Thread Srivatsa, Anusha
>-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >Sujaritha Sundaresan >Sent: Wednesday, August 23, 2017 3:10 PM >To: intel-gfx@lists.freedesktop.org >Cc: Sundaresan, Sujaritha >Subject: [Intel-gfx] [PATCH 0/2] Changes to GuC loading and

Re: [Intel-gfx] [PATCH v3 06/12] tests/perf: rework oa-exponent test

2017-08-23 Thread Matthew Auld
On 08/23, Lionel Landwerlin wrote: > New issues that were discovered while making the tests work on Gen8+ : > > - we need to measure timings between periodic reports and discard all >other kind of reports > > - it seems periodicity of the reports can be affected outside of RC6 >(frequen

[Intel-gfx] [PATCH 2/2] drm/i915/guc : Enable GuC logs even when submission is not enabled

2017-08-23 Thread Sujaritha Sundaresan
Currently, we only enable GuC logs when enable_guc_submission is set. But we could be interested in getting GuC logs in other cases as well. Cc: Daniele Ceraolo Spurio Cc: Joonas Lahtinen Cc: Anusha Srivatsa Signed-off-by: Sujaritha Sundaresan --- drivers/gpu/drm/i915/i915_drv.h|

[Intel-gfx] [PATCH 0/2] Changes to GuC loading and GuC logs

2017-08-23 Thread Sujaritha Sundaresan
*** BLURB HERE *** Sujaritha Sundaresan (2): drm/i915/guc : Removing enable_guc_loading module drm/i915/guc : Enable GuC logs even when submission is not enabled drivers/gpu/drm/i915/i915_debugfs.c| 12 +++-- drivers/gpu/drm/i915/i915_drv.c| 2 +- drivers/gpu/drm/i915/i9

[Intel-gfx] [PATCH 1/2] drm/i915/guc : Removing enable_guc_loading module

2017-08-23 Thread Sujaritha Sundaresan
Whenever we need i915.enable_guc_submission=1, we also need enable_guc_loading=1. We also need enable_guc_loading=1 when we want to verify the HuC, which is every time we have a HuC (but all platforms with HuC have a GuC and viceversa). We don't need the user to tell when to enable the GuC loadi

[Intel-gfx] [PATCH] drm/i915/cnl: WaForceEnableNonCoherent

2017-08-23 Thread Rodrigo Vivi
Must Force Non-Coherent whenever executing a 3D context. This is a workaround for a possible hang in the unlikely event a TLB invalidation occurs during a PSD flush. Set masked bit 4 in 0x7300 during boot. Cc: Mika Kuoppala Cc: Oscar Mateo Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH] drm/i915/cnl: WaForceContextSaveRestoreNonCoherent

2017-08-23 Thread Rodrigo Vivi
patch merged to dinq. thanks for the review and suggestion. On Wed, Aug 23, 2017 at 1:35 PM, Rodrigo Vivi wrote: > To avoid a potential hang condition with TLB invalidation > we need to enable masked bit 5 of MMIO 0xE5F0 at boot. > > Same workaround was in place for previous platforms, > but the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: WaForceContextSaveRestoreNonCoherent (rev2)

2017-08-23 Thread Patchwork
== Series Details == Series: drm/i915/cnl: WaForceContextSaveRestoreNonCoherent (rev2) URL : https://patchwork.freedesktop.org/series/29184/ State : success == Summary == Series 29184v2 drm/i915/cnl: WaForceContextSaveRestoreNonCoherent https://patchwork.freedesktop.org/api/1.0/series/29184/re

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Don't reset the display on gdg

2017-08-23 Thread Patchwork
== Series Details == Series: drm/i915: Don't reset the display on gdg URL : https://patchwork.freedesktop.org/series/29235/ State : failure == Summary == Series 29235v1 drm/i915: Don't reset the display on gdg https://patchwork.freedesktop.org/api/1.0/series/29235/revisions/1/mbox/ Test drv_h

Re: [Intel-gfx] [PATCH] drm/i915/cnl: WaPushConstantDereferenceHoldDisable

2017-08-23 Thread Rodrigo Vivi
merged to dinq. thanks for the patch and for updating the commit message. On Wed, Aug 23, 2017 at 12:56 PM, Oscar Mateo wrote: > CS sometimes hangs on 3D Push Constant dispatches with the new > deref enhancement logic in CNL. > > v2: Improve the commit message (Rodrigo) > > Cc: Mika Kuoppala >

[Intel-gfx] [PATCH] drm/i915/cnl: WaForceContextSaveRestoreNonCoherent

2017-08-23 Thread Rodrigo Vivi
To avoid a potential hang condition with TLB invalidation we need to enable masked bit 5 of MMIO 0xE5F0 at boot. Same workaround was in place for previous platforms, but the register offset has changed for CNL. But also BSpec doesn't mention the bit 15 as set on gen9 platforms and mark bit as rese

Re: [Intel-gfx] [PATCH i-g-t 2/3] aubdump: Use write_reloc for filling out the ringbuffer

2017-08-23 Thread Lionel Landwerlin
Reviewed-by: Lionel Landwerlin On 23/08/17 18:14, Jason Ekstrand wrote: --- tools/aubdump.c | 66 - 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/tools/aubdump.c b/tools/aubdump.c index c14c9fa..567de3d 100644 --- a/to

[Intel-gfx] [PATCH] drm/i915: Don't reset the display on gdg

2017-08-23 Thread Chris Wilson
Not a real fix, just to try and provoke some insight into the problem. After lots of inconclusion bisecting, the only thing that is clear is that between commit e2c8b8701e2d0cb5b89fa3b5c8acae9dc4f76259 Author: Maarten Lankhorst Date: Tue Feb 16 10:06:14 2016 +0100 drm/i915: Use atomic hel

Re: [Intel-gfx] [PATCH i-g-t 1/3] aubdump: Reject execbuffer2 calls with bad BOs

2017-08-23 Thread Lionel Landwerlin
Heh, fixed the same in ksim. Don't know why I didn't see it while using aubdump recently... Reviewed-by: Lionel Landwerlin On 23/08/17 18:14, Jason Ekstrand wrote: This is required for the supports_48b_addresses check in the Vulkan driver to work without messing up the resulting aub. --- to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: WaPushConstantDereferenceHoldDisable (rev3)

2017-08-23 Thread Patchwork
== Series Details == Series: drm/i915/cnl: WaPushConstantDereferenceHoldDisable (rev3) URL : https://patchwork.freedesktop.org/series/29182/ State : success == Summary == Series 29182v3 drm/i915/cnl: WaPushConstantDereferenceHoldDisable https://patchwork.freedesktop.org/api/1.0/series/29182/re

Re: [Intel-gfx] [PATCH] drm/i915/cnl: WaForceContextSaveRestoreNonCoherent

2017-08-23 Thread Oscar Mateo
On 08/22/2017 04:27 PM, Rodrigo Vivi wrote: To avoid a potential hang condition with TLB invalidation we need to enable masked bit 5 of MMIO 0xE5F0 at boot. Same workaround was in place for previous platforms, but the change for CNL is more on the register offset. "but the register offset ha

[Intel-gfx] [PATCH] drm/i915/cnl: WaPushConstantDereferenceHoldDisable

2017-08-23 Thread Oscar Mateo
CS sometimes hangs on 3D Push Constant dispatches with the new deref enhancement logic in CNL. v2: Improve the commit message (Rodrigo) Cc: Mika Kuoppala Signed-off-by: Oscar Mateo Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_reg.h| 1 + drivers/gpu/drm/i915/intel_engine_cs

Re: [Intel-gfx] [PATCH] drm/i915/cnl: WaPushConstantDereferenceHoldDisable

2017-08-23 Thread Oscar Mateo
Oops... forgot to add v2 tag. Hang on a second. On 08/23/2017 12:53 PM, Oscar Mateo wrote: CS sometimes hangs on 3D Push Constant dispatches with the new deref enhancement logic in CNL. Cc: Mika Kuoppala Signed-off-by: Oscar Mateo Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_re

[Intel-gfx] [PATCH] drm/i915/cnl: WaPushConstantDereferenceHoldDisable

2017-08-23 Thread Oscar Mateo
CS sometimes hangs on 3D Push Constant dispatches with the new deref enhancement logic in CNL. Cc: Mika Kuoppala Signed-off-by: Oscar Mateo Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_reg.h| 1 + drivers/gpu/drm/i915/intel_engine_cs.c | 3 +++ 2 files changed, 4 insertions(

Re: [Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-23 Thread Peter Zijlstra
On Wed, Aug 23, 2017 at 07:00:33PM +, Rogozhkin, Dmitry V wrote: > On Wed, 2017-08-23 at 20:22 +0200, Peter Zijlstra wrote: > > On Wed, Aug 23, 2017 at 05:51:38PM +, Rogozhkin, Dmitry V wrote: > > > > > Anyhow, returning to the metrics i915 exposes. Some metrics are just > > > exposure of

Re: [Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-23 Thread Peter Zijlstra
On Wed, Aug 23, 2017 at 06:38:05PM +, Rogozhkin, Dmitry V wrote: > On Wed, 2017-08-23 at 20:04 +0200, Peter Zijlstra wrote: > > On Wed, Aug 23, 2017 at 05:51:38PM +, Rogozhkin, Dmitry V wrote: > > > > > > The above command tries to add an event 'i915/rcs0-busy/' to a task. How > > > > are

Re: [Intel-gfx] [PATCH i-g-t 1/3] tests/chamelium: Introduce fast basic hpd tests, with limited toggles

2017-08-23 Thread Lyude Paul
R-B'd and pushed, thanks! On Wed, 2017-08-23 at 18:21 +0300, Paul Kocialkowski wrote: > This introduces a fast fashion of testing basic hotplug detect, with > only 3 toggles. It drastically reduces the run time of the test, > which > is necessary for the fast-feedback test list. > > Signed-off-by

Re: [Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-23 Thread Rogozhkin, Dmitry V
On Wed, 2017-08-23 at 20:22 +0200, Peter Zijlstra wrote: > On Wed, Aug 23, 2017 at 05:51:38PM +, Rogozhkin, Dmitry V wrote: > > > Anyhow, returning to the metrics i915 exposes. Some metrics are just > > exposure of some counters supported already inside i915 PMU which do not > > require any sp

Re: [Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-23 Thread Rogozhkin, Dmitry V
On Wed, 2017-08-23 at 20:01 +0200, Peter Zijlstra wrote: > On Wed, Aug 23, 2017 at 05:51:38PM +, Rogozhkin, Dmitry V wrote: > > > https://patchwork.freedesktop.org/patch/171953/. This patch makes 'perf > > stat -e i915/rcs0-busy/' to error out and supports 'perf stat -e > > i915/rcs0-busy/ -a

Re: [Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-23 Thread Rogozhkin, Dmitry V
On Wed, 2017-08-23 at 20:04 +0200, Peter Zijlstra wrote: > On Wed, Aug 23, 2017 at 05:51:38PM +, Rogozhkin, Dmitry V wrote: > > > > The above command tries to add an event 'i915/rcs0-busy/' to a task. How > > > are i915 resource associated to any one particular task? > > > > Currently in no w

Re: [Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-23 Thread Peter Zijlstra
On Wed, Aug 23, 2017 at 05:51:38PM +, Rogozhkin, Dmitry V wrote: > Anyhow, returning to the metrics i915 exposes. Some metrics are just > exposure of some counters supported already inside i915 PMU which do not > require any special sampling: at any given moment you can request the > counter v

Re: [Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-23 Thread Peter Zijlstra
On Wed, Aug 23, 2017 at 05:51:38PM +, Rogozhkin, Dmitry V wrote: > And there is another problem associated with the "perf stat -e > -a": since 8 events are initialized, I get metric values multiplied by > 8. How I am supposed to fix that? I suspect that this is somehow related > to cpumask att

Re: [Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-23 Thread Peter Zijlstra
On Wed, Aug 23, 2017 at 05:51:38PM +, Rogozhkin, Dmitry V wrote: > > The above command tries to add an event 'i915/rcs0-busy/' to a task. How > > are i915 resource associated to any one particular task? > > Currently in no way, they are global. Right. So no per DRM context things. Can you ha

Re: [Intel-gfx] [PATCH i-g-t 3/3] aubdump: Log some information about the execbuf calls

2017-08-23 Thread Scott D Phillips
Jason Ekstrand writes: > --- > tools/aubdump.c | 8 +++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/tools/aubdump.c b/tools/aubdump.c > index 567de3d..cf4c6e8 100644 > --- a/tools/aubdump.c > +++ b/tools/aubdump.c > @@ -405,6 +405,8 @@ dump_execbuffer2(int fd, struct d

Re: [Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-23 Thread Peter Zijlstra
On Wed, Aug 23, 2017 at 05:51:38PM +, Rogozhkin, Dmitry V wrote: > https://patchwork.freedesktop.org/patch/171953/. This patch makes 'perf > stat -e i915/rcs0-busy/' to error out and supports 'perf stat -e > i915/rcs0-busy/ -a -C0'. I still think I miss something since 'perf stat > -e i915/rcs

Re: [Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-23 Thread Rogozhkin, Dmitry V
On Tue, 2017-08-22 at 20:17 +0200, Peter Zijlstra wrote: > On Sat, Aug 12, 2017 at 02:15:13AM +, Rogozhkin, Dmitry V wrote: > > $ perf stat -e instructions,i915/rcs0-busy/ workload.sh > > <... wrokload.sh output...> > > > > Performance counter stats for 'workload.sh': > > 1,204,616,268

Re: [Intel-gfx] [PATCH 04/20] drm/i915: Ignore duplicate VMA stored within the per-object handle LUT

2017-08-23 Thread Michał Winiarski
On Wed, Aug 23, 2017 at 10:14:58AM +0100, Chris Wilson wrote: > By using drm_gem_flink/drm_gem_open on an object using the same fd, it > is possible for a client to create multiple handles pointing to the same > object (tied to the same contexts and VMA), as exemplified by > igt::gem_handle_to_libd

[Intel-gfx] [maintainer-tools PATCH] qf: Fix qf_help: Remove attempt to grab DIM_PREFIX.

2017-08-23 Thread Rodrigo Vivi
This is not available here nor will be available on qfrc. So let's avoid duplication and just grab the qf.rst file from whatever repository this command is called from. Cc: Jani Nikula Cc: Daniel Vetter Cc: Joonas Lahtinen Signed-off-by: Rodrigo Vivi --- qf | 9 +++-- 1 file changed, 3 in

[Intel-gfx] [maintainer-tools PATCH] dim.rst: Fix dimrc command block doc.

2017-08-23 Thread Rodrigo Vivi
Duh! Jani had warned I had forgotten these ":" in some intermediate version, but I forgot again to remove on latest version that end up getting merged. I noticed when adding same for qfrc here. Cc: Jani Nikula Signed-off-by: Rodrigo Vivi --- dim.rst | 4 ++-- 1 file changed, 2 insertions(+), 2

[Intel-gfx] ✗ Fi.CI.BAT: failure for aubdump: A few improvements

2017-08-23 Thread Patchwork
== Series Details == Series: aubdump: A few improvements URL : https://patchwork.freedesktop.org/series/29225/ State : failure == Summary == IGT patchset tested on top of latest successful build 42b42c99cd9d1b890807ae97cbd1c593396ae051 tests/Makefile.am: Wrap audio test with dedicated conditi

[Intel-gfx] [maintainer-tools PATCH] dim: Properly handle series on apply_branch

2017-08-23 Thread Rodrigo Vivi
So far we could use *dim* to apply a whole series in a mbox, but only the very last patch was receiving all the checks and patchwork link. So this patch remove this limitation by using git mailsplit to split the mbox and than use git am and checks individually on each patch. v2: a. Don't loop wit

[Intel-gfx] [maintainer-tools PATCH] qf: Introduce .qfrc.

2017-08-23 Thread Rodrigo Vivi
Soon we will need to extend qf for very specific usages of our internal maintenance and rebase bot. So let's start with the only environment configuration we have but also let's allow qfrc to extend qf commands and aliases. Cc: Daniel Vetter Cc: Jani Nikula Cc: Joonas Lahtinen Signed-off-by: R

[Intel-gfx] New #intel-3d IRC channel on Freenode

2017-08-23 Thread Kenneth Graunke
Hello, The Intel Mesa team would like to welcome you to a new public IRC channel on Freenode: #intel-3d. The topic is Mesa development for Intel GPUs, in particular the "i965" OpenGL and "anv" Vulkan drivers. The open source graphics community has grown a lot over the last few years, and as a re

[Intel-gfx] [PATCH i-g-t 1/3] aubdump: Reject execbuffer2 calls with bad BOs

2017-08-23 Thread Jason Ekstrand
This is required for the supports_48b_addresses check in the Vulkan driver to work without messing up the resulting aub. --- tools/aubdump.c | 8 1 file changed, 8 insertions(+) diff --git a/tools/aubdump.c b/tools/aubdump.c index 610526c..c14c9fa 100644 --- a/tools/aubdump.c +++ b/tools

[Intel-gfx] [PATCH i-g-t 3/3] aubdump: Log some information about the execbuf calls

2017-08-23 Thread Jason Ekstrand
--- tools/aubdump.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tools/aubdump.c b/tools/aubdump.c index 567de3d..cf4c6e8 100644 --- a/tools/aubdump.c +++ b/tools/aubdump.c @@ -405,6 +405,8 @@ dump_execbuffer2(int fd, struct drm_i915_gem_execbuffer2 *execbuffer2)

[Intel-gfx] [PATCH i-g-t 2/3] aubdump: Use write_reloc for filling out the ringbuffer

2017-08-23 Thread Jason Ekstrand
--- tools/aubdump.c | 66 - 1 file changed, 32 insertions(+), 34 deletions(-) diff --git a/tools/aubdump.c b/tools/aubdump.c index c14c9fa..567de3d 100644 --- a/tools/aubdump.c +++ b/tools/aubdump.c @@ -262,9 +262,36 @@ aub_write_trace_block

[Intel-gfx] [PATCH i-g-t 0/3] aubdump: A few improvements

2017-08-23 Thread Jason Ekstrand
These three patches are improvements that I've had locally in my tree for some period of time. The first one is required for Vulkan to work correctly with aubdump ever since we turned on 48-bit addressing. The second is just a bit of future-proofing. The third makes the tool dump some informatio

Re: [Intel-gfx] [PATCH 02/20] drm/i915: Assert the context is not closed on object-close

2017-08-23 Thread Chris Wilson
Quoting Michał Winiarski (2017-08-23 17:50:59) > On Wed, Aug 23, 2017 at 10:14:56AM +0100, Chris Wilson wrote: > > During the context-close, we should be decoupling all the vma from the > > object so that upon object-closing we shouldn't see any vma from the > > already closed contexts. So include

Re: [Intel-gfx] [PATCH 03/20] drm/i915: Assert that the handle->vma lut is empty on object close

2017-08-23 Thread Michał Winiarski
On Wed, Aug 23, 2017 at 10:14:57AM +0100, Chris Wilson wrote: > Make sure that we are not leaking an entry in the ctx->handles_lut by > asserting that the object was removed prior to being freed. This should > be enforced by all such handles being removed by i915_gem_close_object. > > Signed-off-b

Re: [Intel-gfx] [PATCH 02/20] drm/i915: Assert the context is not closed on object-close

2017-08-23 Thread Michał Winiarski
On Wed, Aug 23, 2017 at 10:14:56AM +0100, Chris Wilson wrote: > During the context-close, we should be decoupling all the vma from the > object so that upon object-closing we shouldn't see any vma from the > already closed contexts. So include a check upon closing the object that > the context is s

Re: [Intel-gfx] [PATCH igt v2] igt: Add gem_close

2017-08-23 Thread Michał Winiarski
On Tue, Aug 22, 2017 at 12:10:41PM +0100, Chris Wilson wrote: > What transpired recently was that we allow a single process to create > multiple handles to the same VMA (which I broke). Make sure we test! > > References: https://bugs.freedesktop.org/show_bug.cgi?id=102355 > Signed-off-by: Chris Wi

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/pm_rpm: Use libc 'ftw' rather than opencoding our own filetree walk (rev2)

2017-08-23 Thread Patchwork
== Series Details == Series: igt/pm_rpm: Use libc 'ftw' rather than opencoding our own filetree walk (rev2) URL : https://patchwork.freedesktop.org/series/29141/ State : success == Summary == IGT patchset tested on top of latest successful build 42b42c99cd9d1b890807ae97cbd1c593396ae051 tests/

[Intel-gfx] [PATCH igt v2] igt/pm_rpm: Use libc 'ftw' rather than opencoding our own filetree walk

2017-08-23 Thread Chris Wilson
By using ftw, we avoid the issue of having to handle directory recursion ourselves and can focus on the test of checking the reading a sysfs/debugfs does not break runtime suspend. In the process, disregard errors when opening the individual files as they may fail for other reasons. v2: Bracket th

[Intel-gfx] [PATCH v3 12/12] tests/perf: prevent power management to kick in when necessary

2017-08-23 Thread Lionel Landwerlin
Some of our tests measure that the OA unit produces reports at expected time intervals (as configured through the PERF_OPEN ioctl). It turns out the power management plays a role in the decision of the OA unit to write reports to memory. Under normal circumstances we don't really mind if the unit m

[Intel-gfx] [PATCH v3 08/12] tests/perf: make buffer-fill more reliable

2017-08-23 Thread Lionel Landwerlin
Filling rate of the buffer must discard context switch reports as they do not depend upon the periodicity, instead they're a factor on the amount of different applications concurrently running on the system. Signed-off-by: Lionel Landwerlin Tested-by: Matthew Auld Reviewed-by: Matthew Auld ---

[Intel-gfx] [PATCH v3 11/12] tests/perf: estimate number of blocking/polling based on time spent

2017-08-23 Thread Lionel Landwerlin
Blocking & polling tests define an amount of time to spend in the test and then estimate the number of syscalls that should successfully return. The problem is that while running the test we might spend slightly more time than initiallly planned. This change estimates the number of syscalls based o

[Intel-gfx] [PATCH v3 09/12] tests/perf: add Kabylake support

2017-08-23 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld --- tests/perf.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/tests/perf.c b/tests/perf.c index 59cd50aa..b7d9f96d 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -,8 +,23 @@ init_sys_info

[Intel-gfx] [PATCH v3 06/12] tests/perf: rework oa-exponent test

2017-08-23 Thread Lionel Landwerlin
New issues that were discovered while making the tests work on Gen8+ : - we need to measure timings between periodic reports and discard all other kind of reports - it seems periodicity of the reports can be affected outside of RC6 (frequency change), we can detect this by looking at the

[Intel-gfx] [PATCH v3 10/12] tests/perf: add Geminilake support

2017-08-23 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld --- tests/perf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index b7d9f96d..9f12da40 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1124,6 +1124,9 @@ init_sys_info(void)

[Intel-gfx] [PATCH v3 07/12] tests/perf: make enable-disable more reliable

2017-08-23 Thread Lionel Landwerlin
Estimation of the amount of reports can only refer to periodic ones, as context switch reports completely depend on what happens on the system. Also generate some load to prevent clock frequency changes to impact our measurement. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 96 +++

[Intel-gfx] [PATCH v3 05/12] tests/perf: remove frequency related changes

2017-08-23 Thread Lionel Landwerlin
Experience shows that most of the issues we face with periodicity of the reports produced by the OA unit are related to power management, not frequency. Signed-off-by: Lionel Landwerlin --- tests/perf.c | 141 --- 1 file changed, 9 insertio

[Intel-gfx] [PATCH v3 02/12] tests/perf: add per context filtering test for gen8+

2017-08-23 Thread Lionel Landwerlin
From: Robert Bragg Signed-off-by: Robert Bragg Signed-off-by: Lionel Landwerlin --- tests/perf.c | 777 --- 1 file changed, 745 insertions(+), 32 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index ca5bfdc5..5058315c 100644 --- a

[Intel-gfx] [PATCH v3 01/12] tests/perf: make stream_fd a global variable

2017-08-23 Thread Lionel Landwerlin
When debugging unstable tests on new platforms we currently we don't cleanup everything well in between different tests. Since only a single OA stream fd can be opened at a time, having the stream_fd as a global variable helps us cleanup the state between tests. Signed-off-by: Lionel Landwerlin -

[Intel-gfx] [PATCH v3 00/12] Improve robustness of the i915 perf tests

2017-08-23 Thread Lionel Landwerlin
Hi all, Finally figured the final issue with the flakyness of the tests on Broadwell (patch 12). Some fallout of that generated patch 11. Cheers, Lionel Landwerlin (11): tests/perf: make stream_fd a global variable tests/perf: update max buffer size for reading reports tests/perf: rc6: try

[Intel-gfx] [PATCH v3 03/12] tests/perf: update max buffer size for reading reports

2017-08-23 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- tests/perf.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/perf.c b/tests/perf.c index 5058315c..bc5ea133 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -1280,9 +1280,7 @@ read_2_oa_reports(int format_id, /* Note: w

[Intel-gfx] [PATCH v3 04/12] tests/perf: rc6: try to guess when rc6 is disabled

2017-08-23 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- tests/perf.c | 13 + 1 file changed, 13 insertions(+) diff --git a/tests/perf.c b/tests/perf.c index bc5ea133..1b441601 100644 --- a/tests/perf.c +++ b/tests/perf.c @@ -3445,6 +3445,17 @@ gen8_test_single_ctx_render_target_writes_a_counter(void)

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Pass the new crtc state to color management code

2017-08-23 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Pass the new crtc state to color management code URL : https://patchwork.freedesktop.org/series/29219/ State : success == Summary == Series 29219v1 series starting with [1/7] drm/i915: Pass the new crtc state to color manageme

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] tests/chamelium: Introduce fast basic hpd tests, with limited toggles

2017-08-23 Thread Patchwork
== Series Details == Series: series starting with [1/3] tests/chamelium: Introduce fast basic hpd tests, with limited toggles URL : https://patchwork.freedesktop.org/series/29218/ State : success == Summary == IGT patchset tested on top of latest successful build 42b42c99cd9d1b890807ae97cbd1c

[Intel-gfx] [PATCH 6/7] drm/i915: Eliminate crtc->state usage from intel_update_pipe_config()

2017-08-23 Thread ville . syrjala
From: Ville Syrjälä Pass the correct new crtc state to intel_update_pipe_config() instead of using crtc->state. Reviewed-by: Maarten Lankhorst Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 19 +-- 1 file changed, 9 insertions(+), 10 deletions(-) diff

[Intel-gfx] [PATCH 7/7] drm/i915: Eliminate crtc->state usage from intel_atomic_commit_tail and .crtc_update()

2017-08-23 Thread ville . syrjala
From: Ville Syrjälä We already have the correct new crtc state so just use that instead of crtc->state. Reviewed-by: Maarten Lankhorst Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/dr

[Intel-gfx] [PATCH 5/7] drm/i915: Eliminate obj->state usage from pre/post plane update

2017-08-23 Thread ville . syrjala
From: Ville Syrjälä Dig up the appropriate new crtc and plane states from the top level atomic state in intel_pre_plane_update() and intel_post_plane_update(). Reviewed-by: Maarten Lankhorst Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 9 ++--- 1 file changed, 6

[Intel-gfx] [PATCH 4/7] drm/i915: Pass proper old/new states to intel_plane_atomic_check_with_state()

2017-08-23 Thread ville . syrjala
From: Ville Syrjälä Eliminate plane->state and crtc->state usage from intel_plane_atomic_check_with_state() and its callers. Instead pass the proper states in or dig them up from the top level atomic state. Note that intel_plane_atomic_check_with_state() itself isn't allowed to use the top level

[Intel-gfx] [PATCH 2/7] drm/i915: Pass the crtc state explicitly to intel_pipe_update_start/end()

2017-08-23 Thread ville . syrjala
From: Ville Syrjälä Pass the appropriate new crtc state explicitly to intel_pipe_update_start/end() instead of of mucking around with crtc->state. v2: The mmio flip stuff is gone Reviewed-by: Maarten Lankhorst #v1 Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 14 +++

[Intel-gfx] [PATCH 1/7] drm/i915: Pass the new crtc state to color management code

2017-08-23 Thread ville . syrjala
From: Ville Syrjälä In an effort to eliminate the obj->state usage let's pass on the new crtc state pointer (which we already have!) to the color management code. Reviewed-by: Maarten Lankhorst Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- 1 file changed, 2 i

[Intel-gfx] [PATCH 3/7] drm/i915: Eliminate obj->state usage in g4x/vlv/chv wm computation

2017-08-23 Thread ville . syrjala
From: Ville Syrjälä Use explicit old/new states instead of relying on obj->state. Reviewed-by: Maarten Lankhorst Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.h | 9 + drivers/gpu/drm/i915/intel_drv.h | 8 drivers/gpu/drm/i915/intel_pm.c | 30

[Intel-gfx] [PATCH i-g-t 2/3] tests/chamelium: Introduce fast CRC tests, with a single mode

2017-08-23 Thread Paul Kocialkowski
This introduces a fast fashion of testing display CRC, that only tests a single mode (the highest resolution). It drastically reduces the run time of the test, which is necessary for the fast-feedback test list. Signed-off-by: Paul Kocialkowski --- tests/chamelium.c | 22 --

[Intel-gfx] [PATCH i-g-t 3/3] intel-ci: Add fast chamelium tests to the fast-feedback list

2017-08-23 Thread Paul Kocialkowski
This adds the fastest chamelium tests to the Intel CI fast-feedback list, with the objective of running in under a minute. Signed-off-by: Paul Kocialkowski --- tests/intel-ci/fast-feedback.testlist | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/intel-ci/fast-feedback.testlist

  1   2   >