Re: [Intel-gfx] [PATCH] drm/i915: Eliminate dead code in intel_sanitize_enable_ppgtt()

2017-07-27 Thread Zhenyu Wang
Chris, as we're ready to enable 48bit full ppgtt for guest, so patch like https://patchwork.freedesktop.org/patch/162507/ will change this part too. I'd like you to send this one, so Tina can refresh against this to apply. Thanks On 2017.07.26 15:44:00 +0100, Chris Wilson wrote: > > I was looki

[Intel-gfx] [PULL] drm-intel-fixes

2017-07-27 Thread Daniel Vetter
Hi Dave, drm-intel-fixes-2017-07-27: i915 fixes for -rc3 Bit more than usual since we missed -rc2. 4x cc: stable, 2 gvt patches, but all fairly minor stuff. Last minute rebase was to add a few missing cc: stable, I did prep the pull this morning already and made sure CI approves. Cheers, Daniel

Re: [Intel-gfx] [GIT PULL] GVT-g fixes for 4.13-rc3

2017-07-27 Thread Daniel Vetter
On Wed, Jul 26, 2017 at 03:56:21PM +0800, Zhenyu Wang wrote: > > Hi, here's current gvt fixes for 4.13. One vblank timer close bug > fixed by Fred and enable more KBL SKUs besides E3 server. > > Thanks. Applied, thanks. -Daniel > -- > The following changes since commit 0cf5ec41839d82ee7f8fbb47f

[Intel-gfx] [PULL] drm-misc-fixes

2017-07-27 Thread Sean Paul
Hi Dave, Only a handful of patches for -fixes from -misc. Everything is pretty easy to rationalize, nothing newsworthy. drm-misc-fixes-2017-07-27: Core Changes: - dp: A few fixes in drm_dp_downstream_debug() (Chris) - rockchip: sanitize the Kconfig dependencies (fallout from EXTCON) (Arnd) - host1

Re: [Intel-gfx] [PATCH 0/5] drm/atomic: Interruptible locks for everyone!

2017-07-27 Thread Emil Velikov
On 27 July 2017 at 16:30, Daniel Vetter wrote: > On Thu, Jul 27, 2017 at 03:45:11PM +0100, Emil Velikov wrote: >> Hi Maarten >> >> On 27 July 2017 at 13:58, Maarten Lankhorst >> wrote: >> > drm_atomic_commit could previous have always failed when waits failed, >> > but locking was always done uni

Re: [Intel-gfx] [PATCH 1/5] drm/atomic: Prepare drm_modeset_lock infrastructure for interruptible waiting

2017-07-27 Thread Maarten Lankhorst
Op 27-07-17 om 17:19 schreef Daniel Vetter: > On Thu, Jul 27, 2017 at 02:58:36PM +0200, Maarten Lankhorst wrote: >> When we want to make drm_atomic_commit interruptible, there are a lot of >> places that call the lock function, which we don't have control over. >> >> Rather than trying to convert e

[Intel-gfx] [PATCH i-g-t] tests: kms_pipe_color: only test existing properties

2017-07-27 Thread Lionel Landwerlin
Some platforms might not have degamma or ctm support. We can only verify whether those properties behave properly if they're available. Fixes: aa55641d4 ("tests/kms_color: New test for pipe level color management") Signed-off-by: Lionel Landwerlin --- tests/kms_pipe_color.c | 85

Re: [Intel-gfx] [PATCH] drm/i915: Disable GPU resets for 915g (earliest gen3 desktop)

2017-07-27 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-27 15:36:49) > On Mon, Jul 24, 2017 at 11:14:13AM +0100, Chris Wilson wrote: > > The CI farm reports that trying to write to the PCI config (GDRST: 0xc0) > > results in an immediate and silent reboot on Grantsdale (i915g). Until > > that is resolved, stop killing the

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Call uncore_suspend before platform suspend handlers

2017-07-27 Thread Imre Deak
On Thu, Jul 06, 2017 at 09:24:49PM +0200, Hans de Goede wrote: > Quoting Ville: "the forcewake timer might still be active until the uncore > suspend, and having active forcewakes while we've already told the GT wake > stuff to stop acting normally doesn't seem quite right to me." > > Reported-by:

Re: [Intel-gfx] [PATCH v2 2/4] drm/i915: Re-register PMIC bus access notifier on runtime resume

2017-07-27 Thread Imre Deak
On Thu, Jul 06, 2017 at 09:24:48PM +0200, Hans de Goede wrote: > intel_uncore_suspend() unregisters the uncore code's PMIC bus access > notifier and gets called on both normal and runtime suspend. > > intel_uncore_resume_early() re-registers the notifier, but only on > normal resume. Add a new int

Re: [Intel-gfx] [PATCH 0/5] drm/atomic: Interruptible locks for everyone!

2017-07-27 Thread Daniel Vetter
On Thu, Jul 27, 2017 at 03:45:11PM +0100, Emil Velikov wrote: > Hi Maarten > > On 27 July 2017 at 13:58, Maarten Lankhorst > wrote: > > drm_atomic_commit could previous have always failed when waits failed, > > but locking was always done uninterruptibly. Add infrastructure to make > > it possibl

Re: [Intel-gfx] [PATCH 3/5] drm/atomic: Convert pageflip ioctl locking to interruptible.

2017-07-27 Thread Daniel Vetter
On Thu, Jul 27, 2017 at 02:58:38PM +0200, Maarten Lankhorst wrote: > Pass DRM_MODESET_ACQUIRE_INTERRUPTIBLE to acquire_init, and handle > drm_modeset_backoff which can now fail by returning the error. > > Signed-off-by: Maarten Lankhorst Same comment as the atomic ioctl. With the testcase added

Re: [Intel-gfx] [PATCH 2/5] drm/atomic: Convert atomic ioctl locking to interruptible.

2017-07-27 Thread Daniel Vetter
On Thu, Jul 27, 2017 at 02:58:37PM +0200, Maarten Lankhorst wrote: > Pass DRM_MODESET_ACQUIRE_INTERRUPTIBLE to acquire_init, and > handle drm_modeset_backoff which can now fail by returning the error. > > Signed-off-by: Maarten Lankhorst Requires a testcase, with that addressed: Reviewed-by: Da

Re: [Intel-gfx] [PATCH 1/5] drm/atomic: Prepare drm_modeset_lock infrastructure for interruptible waiting

2017-07-27 Thread Daniel Vetter
On Thu, Jul 27, 2017 at 02:58:36PM +0200, Maarten Lankhorst wrote: > When we want to make drm_atomic_commit interruptible, there are a lot of > places that call the lock function, which we don't have control over. > > Rather than trying to convert every single one, it's easier to toggle > interrup

Re: [Intel-gfx] [PATCH 0/5] drm/atomic: Interruptible locks for everyone!

2017-07-27 Thread Emil Velikov
Hi Maarten On 27 July 2017 at 13:58, Maarten Lankhorst wrote: > drm_atomic_commit could previous have always failed when waits failed, > but locking was always done uninterruptibly. Add infrastructure to make > it possible for callers to choose interruptible locking, and convert the > 4 most comm

Re: [Intel-gfx] [PATCH] drm/i915: Disable GPU resets for 915g (earliest gen3 desktop)

2017-07-27 Thread Chris Wilson
Quoting Daniel Vetter (2017-07-27 15:36:49) > On Mon, Jul 24, 2017 at 11:14:13AM +0100, Chris Wilson wrote: > > The CI farm reports that trying to write to the PCI config (GDRST: 0xc0) > > results in an immediate and silent reboot on Grantsdale (i915g). Until > > that is resolved, stop killing the

Re: [Intel-gfx] [PATCH] drm/i915: Disable GPU resets for 915g (earliest gen3 desktop)

2017-07-27 Thread Daniel Vetter
On Mon, Jul 24, 2017 at 11:14:13AM +0100, Chris Wilson wrote: > The CI farm reports that trying to write to the PCI config (GDRST: 0xc0) > results in an immediate and silent reboot on Grantsdale (i915g). Until > that is resolved, stop killing the machine! > > Bugzilla: https://bugs.freedesktop.org

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915: Fix false-positive assert_rpm_wakelock_held in i915_pmic_bus_access_notifier

2017-07-27 Thread Imre Deak
Hi, On Thu, Jul 06, 2017 at 09:24:47PM +0200, Hans de Goede wrote: > assert_rpm_wakelock_held is triggered from i915_pmic_bus_access_notifier > even though it gets unregistered on (runtime) suspend, this is caused > by a race happening under the following circumstances: > > intel_runtime_pm_put d

Re: [Intel-gfx] [PATCH] drm/i915: Disable GPU resets for 915g (earliest gen3 desktop)

2017-07-27 Thread Chris Wilson
Quoting Chris Wilson (2017-07-24 11:14:13) > The CI farm reports that trying to write to the PCI config (GDRST: 0xc0) > results in an immediate and silent reboot on Grantsdale (i915g). Until > that is resolved, stop killing the machine! > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=10

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/atomic: Interruptible locks for everyone!

2017-07-27 Thread Patchwork
== Series Details == Series: drm/atomic: Interruptible locks for everyone! URL : https://patchwork.freedesktop.org/series/27987/ State : success == Summary == Series 27987v1 drm/atomic: Interruptible locks for everyone! https://patchwork.freedesktop.org/api/1.0/series/27987/revisions/1/mbox/

[Intel-gfx] [PATCH i-g-t] lib/aux: Better debug output for rtcwake

2017-07-27 Thread Daniel Vetter
Printing the error code is kinda useful. Also tune down the blame shifting away from i915, this could very well be an i915 bug, not just a setup issue. Also move the notice to the require test, not the failure, and suggest to look into dmesg. v2: Dont print errno, igt_require/assert already do tha

[Intel-gfx] [PATCH 3/5] drm/atomic: Convert pageflip ioctl locking to interruptible.

2017-07-27 Thread Maarten Lankhorst
Pass DRM_MODESET_ACQUIRE_INTERRUPTIBLE to acquire_init, and handle drm_modeset_backoff which can now fail by returning the error. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_plane.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_plane.

[Intel-gfx] [PATCH 1/5] drm/atomic: Prepare drm_modeset_lock infrastructure for interruptible waiting

2017-07-27 Thread Maarten Lankhorst
When we want to make drm_atomic_commit interruptible, there are a lot of places that call the lock function, which we don't have control over. Rather than trying to convert every single one, it's easier to toggle interruptible waiting per acquire_ctx. If drm_modeset_acquire_init is called with DRM

[Intel-gfx] [PATCH 4/5] drm/legacy: Convert cursor ioctl locking to interruptible.

2017-07-27 Thread Maarten Lankhorst
Pass DRM_MODESET_ACQUIRE_INTERRUPTIBLE to acquire_init, and handle drm_modeset_backoff which can now fail by returning the error. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_plane.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_plane.

[Intel-gfx] [PATCH 2/5] drm/atomic: Convert atomic ioctl locking to interruptible.

2017-07-27 Thread Maarten Lankhorst
Pass DRM_MODESET_ACQUIRE_INTERRUPTIBLE to acquire_init, and handle drm_modeset_backoff which can now fail by returning the error. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_atomi

[Intel-gfx] [PATCH 5/5] drm/legacy: Convert setplane ioctl locking to interruptible.

2017-07-27 Thread Maarten Lankhorst
Pass DRM_MODESET_ACQUIRE_INTERRUPTIBLE to acquire_init, and handle drm_modeset_backoff which can now fail by returning the error. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_plane.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_plane.

[Intel-gfx] [PATCH 0/5] drm/atomic: Interruptible locks for everyone!

2017-07-27 Thread Maarten Lankhorst
drm_atomic_commit could previous have always failed when waits failed, but locking was always done uninterruptibly. Add infrastructure to make it possible for callers to choose interruptible locking, and convert the 4 most common ioctl's to use it. All other atomic helpers can be converted when Da

Re: [Intel-gfx] [PATCH] drm/i915: Avoid the gpu reset vs. modeset deadlock

2017-07-27 Thread Tvrtko Ursulin
On 20/07/2017 21:23, Daniel Vetter wrote: ... using the biggest hammer we have. This is essentially a weaponized version of the timeout-based wedging Chris added in commit 36703e79a982c8ce5a8e43833291f2719e92d0d1 Author: Chris Wilson Date: Thu Jun 22 11:56:25 2017 +0100 drm/i915: Break

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unused i915_err_print_instdone (rev2)

2017-07-27 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused i915_err_print_instdone (rev2) URL : https://patchwork.freedesktop.org/series/27975/ State : success == Summary == Series 27975v2 drm/i915: Remove unused i915_err_print_instdone https://patchwork.freedesktop.org/api/1.0/series/27975/revision

[Intel-gfx] [PATCH v2] drm/i915: Remove unused i915_err_print_instdone

2017-07-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Just a simple code cleanup, below commit forgot to remove a function which it made unused: commit eaa14c24864ecfc60fb591f3b20747af7c67d446 Author: Chris Wilson Date: Wed Oct 19 13:52:03 2016 +0100 drm/i915: Stop reporting error details in dmesg as well as the error-

[Intel-gfx] [PATCH] dim: Continue also for dry runs

2017-07-27 Thread Daniel Vetter
It's a bit silly to have to spec both -d and -f to see what dim would all complain about. And dry-run should never cause bad side-effects. Signed-off-by: Daniel Vetter --- dim | 2 ++ 1 file changed, 2 insertions(+) diff --git a/dim b/dim index c0cbe352b165..96aaf7101d6b 100755 --- a/dim +++ b/

Re: [Intel-gfx] [PATCH 0/4] Userptr bo slab use optimization

2017-07-27 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-07-27 11:46:03) > > On 27/07/2017 10:25, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-07-27 10:05:00) > >> From: Tvrtko Ursulin > >> > >> Yet another attempt to get this series reviewed and merged... > >> > >> I've heard Vulkan might be creating a lot of userp

Re: [Intel-gfx] [PATCH 0/4] Userptr bo slab use optimization

2017-07-27 Thread Tvrtko Ursulin
On 27/07/2017 10:25, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-07-27 10:05:00) From: Tvrtko Ursulin Yet another attempt to get this series reviewed and merged... I've heard Vulkan might be creating a lot of userptr objects so might be interesting to check what benefit it brings to tho

Re: [Intel-gfx] [PATCH v2 09/12] drm/tilcdc: Handle drm_atomic_helper_swap_state failure

2017-07-27 Thread Maarten Lankhorst
Op 27-07-17 om 09:49 schreef Jyri Sarha: > On 07/11/17 17:33, Maarten Lankhorst wrote: >> drm_atomic_helper_swap_state() will be changed to interruptible waiting >> in the next few commits, so all drivers have to be changed to handling >> failure. >> >> Signed-off-by: Maarten Lankhorst >> Cc: Jyri

[Intel-gfx] ✓ Fi.CI.BAT: success for Userptr bo slab use optimization

2017-07-27 Thread Patchwork
== Series Details == Series: Userptr bo slab use optimization URL : https://patchwork.freedesktop.org/series/27976/ State : success == Summary == Series 27976v1 Userptr bo slab use optimization https://patchwork.freedesktop.org/api/1.0/series/27976/revisions/1/mbox/ Test gem_ringfill:

Re: [Intel-gfx] [PATCH 0/4] Userptr bo slab use optimization

2017-07-27 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-07-27 10:05:00) > From: Tvrtko Ursulin > > Yet another attempt to get this series reviewed and merged... > > I've heard Vulkan might be creating a lot of userptr objects so might be > interesting to check what benefit it brings to those use cases. Optimist :) My thi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unused i915_err_print_instdone

2017-07-27 Thread Patchwork
== Series Details == Series: drm/i915: Remove unused i915_err_print_instdone URL : https://patchwork.freedesktop.org/series/27975/ State : success == Summary == Series 27975v1 drm/i915: Remove unused i915_err_print_instdone https://patchwork.freedesktop.org/api/1.0/series/27975/revisions/1/mbo

[Intel-gfx] [PATCH 1/4] lib/scatterlist: Fix offset type in sg_alloc_table_from_pages

2017-07-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Scatterlist entries have an unsigned int for the offset so correct the sg_alloc_table_from_pages function accordingly. Since these are offsets withing a page, unsigned int is wide enough. Also converts callers which were using unsigned long locally with the lower_32_bits an

[Intel-gfx] [PATCH 2/4] lib/scatterlist: Avoid potential scatterlist entry overflow

2017-07-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Since the scatterlist length field is an unsigned int, make sure that sg_alloc_table_from_pages does not overflow it while coallescing pages to a single entry. v2: Drop reference to future use. Use UINT_MAX. v3: max_segment must be page aligned. v4: Do not rely on compiler t

[Intel-gfx] [PATCH 0/4] Userptr bo slab use optimization

2017-07-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Yet another attempt to get this series reviewed and merged... I've heard Vulkan might be creating a lot of userptr objects so might be interesting to check what benefit it brings to those use cases. As an introduction, this allows i915 to create fewer sg table entries for t

[Intel-gfx] [PATCH 4/4] drm/i915: Use __sg_alloc_table_from_pages for userptr allocations

2017-07-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin With the addition of __sg_alloc_table_from_pages we can control the maximum coallescing size and eliminate a separate path for allocating backing store here. Similar to 871dfbd67d4e ("drm/i915: Allow compaction upto SWIOTLB max segment size") this enables more compact sg lis

[Intel-gfx] [PATCH 3/4] lib/scatterlist: Introduce and export __sg_alloc_table_from_pages

2017-07-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Drivers like i915 benefit from being able to control the maxium size of the sg coallesced segment while building the scatter- gather list. Introduce and export the __sg_alloc_table_from_pages function which will allow it that control. v2: Reorder parameters. (Chris Wilson)

Re: [Intel-gfx] [PATCH] drm/i915: Remove unused i915_err_print_instdone

2017-07-27 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-07-27 09:28:05) > From: Tvrtko Ursulin > > Somewhere, sometime, in some refactoring it seems to have been > left behind with no callers. commit eaa14c24864ecfc60fb591f3b20747af7c67d446 Author: Chris Wilson Date: Wed Oct 19 13:52:03 2016 +0100 drm/i915: Stop r

[Intel-gfx] [PATCH] drm/i915: Remove unused i915_err_print_instdone

2017-07-27 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Somewhere, sometime, in some refactoring it seems to have been left behind with no callers. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_irq.c | 26 -- 1 file changed, 26 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c b/dr

Re: [Intel-gfx] [PATCH 16/21] drm/i915/selftests: huge page tests

2017-07-27 Thread kbuild test robot
-Auld/huge-gtt-pages/20170727-150519 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-x013-201730 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All

Re: [Intel-gfx] [PATCH v2 09/12] drm/tilcdc: Handle drm_atomic_helper_swap_state failure

2017-07-27 Thread Jyri Sarha
On 07/11/17 17:33, Maarten Lankhorst wrote: > drm_atomic_helper_swap_state() will be changed to interruptible waiting > in the next few commits, so all drivers have to be changed to handling > failure. > > Signed-off-by: Maarten Lankhorst > Cc: Jyri Sarha > Cc: Tomi Valkeinen This has probably

Re: [Intel-gfx] [PATCH 16/21] drm/i915/selftests: huge page tests

2017-07-27 Thread kbuild test robot
/huge-gtt-pages/20170727-150519 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: i386-randconfig-x015-201730 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=i386 All