Re: [Intel-gfx] Ubuntu 16.04.2 LTS with Intel Corporation Sky Lake Integrated Graphics (rev 06)

2017-02-19 Thread Jani Nikula
On Fri, 17 Feb 2017, Eric Johansson wrote: > On 2/17/2017 at 2:30 PM, "Jani Nikula" wrote: >>Relevant bug report >>https://bugs.freedesktop.org/show_bug.cgi?id=97822 > > Thanks, however, I probably did something stupid since it didn't work > for me. I went into BIOS: F10 > BIOS Setup > Advanced

Re: [Intel-gfx] [PATCH i-g-t] tools/intel_guc_logger: Fix the assert for the verbosity level

2017-02-19 Thread Robert Foss
Applied to upstream/master Rob. On 2017-02-17 11:35 AM, Daniele Ceraolo Spurio wrote: Reviewed-by: Daniele Ceraolo Spurio On 16/02/17 06:31, Oscar Mateo wrote: I guess no one has needed to change the verbosity level of the GuC logs. Signed-off-by: Oscar Mateo --- tools/intel_guc_logger.c

Re: [Intel-gfx] [PATCH i-g-t 5/5] lib/igt_kms: Remove redundant cursor code

2017-02-19 Thread Robert Foss
On 2017-02-17 12:54 PM, Brian Starkey wrote: The dynamic plane support means that there should never be gaps in the pipe->planes array. This means we should never need to move the cursor plane from the last slot to another. Remove the unnecessary code, and add an assert that makes sure nothing

Re: [Intel-gfx] [PATCH i-g-t 4/5] lib/igt_kms: Fix memory corruption when there's no cursor plane

2017-02-19 Thread Robert Foss
On 2017-02-17 12:54 PM, Brian Starkey wrote: The dynamic plane support means that if there's no cursor plane, then there is no space in the pipe->planes array for it, and thus assigning a "drm_plane-less" plane is out-of-bounds and leads to heap corruption and later crashes. The "drm_plane-les

Re: [Intel-gfx] [PATCH i-g-t 3/5] lib/igt_kms: Fix possible out-of-bounds access

2017-02-19 Thread Robert Foss
On 2017-02-17 12:54 PM, Brian Starkey wrote: If there's no primary plane, pipe->plane_primary == -1, and the assert meant to check that it's valid will access pipe->planes[-1]. Fix that to check that pipe->plane_primary has been set instead. Reviewed-by: Robert Foss Rob. Fixes: 3665623

Re: [Intel-gfx] [PATCH i-g-t 2/5] lib/igt_kms: Neaten up pipe->planes[] assignment

2017-02-19 Thread Robert Foss
On 2017-02-17 12:54 PM, Brian Starkey wrote: Remove a bunch of branches, functionally equivalent. Signed-off-by: Brian Starkey --- lib/igt_kms.c | 34 ++ 1 file changed, 10 insertions(+), 24 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 4ca9

Re: [Intel-gfx] [PATCH i-g-t 1/5] lib/igt_kms: Fix drm_plane leak

2017-02-19 Thread Robert Foss
On 2017-02-17 12:54 PM, Brian Starkey wrote: In the loop looking for planes on a pipe, we always want to free up the drm_plane afterwards. Fixes: 36656239ef96 lib/igt_kms: Implement dynamic plane count support Signed-off-by: Brian Starkey --- Hi, This series cleans up igt_display_init a bit

Re: [Intel-gfx] [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes

2017-02-19 Thread Thomas Hellstrom
So I think we need a quick revert of this commit or a quick stable follow-up to unbreak things on our side. /Thomas On 02/19/2017 03:54 PM, Thomas Hellstrom wrote: > Hi! > > This patch breaks the vmwgfx resolutionKMS daemon which opens a control > node to tell DRM about the monitor layout... > >

Re: [Intel-gfx] [PATCH] [RFC] drm: Nerf DRM_CONTROL nodes

2017-02-19 Thread Thomas Hellstrom
Hi! This patch breaks the vmwgfx resolutionKMS daemon which opens a control node to tell DRM about the monitor layout... /Thomas On 10/28/2016 10:10 AM, Daniel Vetter wrote: > Looking at the ioctl permission checks I noticed that it's impossible > to import gem buffers into a control nodes, and