Re: [Intel-gfx] [PATCH 2/3] drm: Pull together probe + setup for drm_fb_helper

On Wed, Nov 23, 2016 at 02:04:16PM +, Chris Wilson wrote: > drm_fb_helper_probe_connector_modes() is always called before > drm_setup_crtcs(), so just move the call into drm_setup_crtcs for a > small bit of code compaction. > > Signed-off-by: Chris Wilson This drops drm_modeset_lock_all() ar

Re: [Intel-gfx] [PATCH 3/3] drm: Protect fb_helper list manipulation with a mutex

On Wed, Nov 23, 2016 at 02:04:17PM +, Chris Wilson wrote: > Though we only walk the kernel_fb_helper_list inside a panic (or single > thread debugging), we still need to protect the list manipulation on > creating/removing a framebuffer device in order to prevent list > corruption. > > Signed-

Re: [Intel-gfx] [PATCH 3/3] drm: Track framebuffer references at the point of assignment

On Fri, Nov 25, 2016 at 03:32:31PM +, Chris Wilson wrote: > We can simplify the code greatly if both legacy and atomic paths updated > the references as they assigned the framebuffer to the planes. Long > before framebuffer reference counting was added, the code had to keep > the old_fb around

[Intel-gfx] [i-g-t PATCH v15 3/6] lib: add igt_dummyload

A lot of igt testcases need some GPU workload to make sure a race window is big enough. Unfortunately having a fixed amount of workload leads to spurious test failures or overly long runtimes on some fast/slow platforms. This library contains functionality to submit GPU workloads that should consum

Re: [Intel-gfx] [PATCH 1/3] drm: Hold mode_config.lock to prevent hotplug whilst setting up crtcs

On Wed, Nov 23, 2016 at 02:04:15PM +, Chris Wilson wrote: > The fb_helper->connector_count is modified when a new connector is > constructed following a hotplug event (e.g. DP-MST). This causes trouble > for drm_setup_crtcs() and friends that assume that fb_helper is > constant: > > [ 1250.872

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use helper for setting plane->state->fb

On Fri, Nov 25, 2016 at 03:32:29PM +, Chris Wilson wrote: > We are told not to set plane_state->fb directly, but use > drm_atomic_set_fb_for_plane() instead. Using the helper, means one less > piece of code that needs fixing should the interface change... > > Signed-off-by: Chris Wilson Revi

Re: [Intel-gfx] [PATCH 3/3] drm: Fix shift operations for drm_fb_helper::drm_target_preferred()

On Sun, Nov 27, 2016 at 05:09:10PM +, Chris Wilson wrote: > smatch correctly warns: > > drivers/gpu/drm/drm_fb_helper.c:1960 drm_target_preferred() warn: > should '1 << i' be a 64 bit type? > drivers/gpu/drm/drm_fb_helper.c:2001 drm_target_preferred() warn: > should '1 << i' be a

Re: [Intel-gfx] [PATCH 1/2] drm: Add some kselftests for the DRM range manager (struct drm_mm)

On Sun, Nov 27, 2016 at 02:08:34PM +, Chris Wilson wrote: > A set of test cases to capture some annoying bugs and to ensure that > correct behaviour does not regress whilst fixing those! > > Signed-off-by: Chris Wilson Adding kselftest mailing list and cc. -Daniel > --- > drivers/gpu/drm/K

Re: [Intel-gfx] [PATCH 1/3] drm: Use u64_to_user_ptr() helper for blob ioctls

On su, 2016-11-27 at 17:09 +, Chris Wilson wrote: > Remove the ugly sparse casts by using the helper u64_to_user_ptr() > instead. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___

[Intel-gfx] [Regression report] Weekly regression report WW48

Total regressions: 47 This week regressions: 0 +---+-+++ | BugId | Summary | Created on | Bisect | +---+-+++ Previous regressions: 47 +---+--+--

Re: [Intel-gfx] [RFC PATCH v3 1/7] drm/i915: setup bridge for HDMI LPE audio driver

Jani, Last time , it took close to 10 days when my patches were reflected on the gfx mailing list. Not sure what is the problem ?? Let me try sending it again ?? Regards, Jerome > -Original Message- > From: Jani Nikula [mailto:jani.nik...@linux.intel.com] > Sent: Friday, November 25, 20

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm: Promote drm_mm alignment to u64

== Series Details == Series: drm: Promote drm_mm alignment to u64 URL : https://patchwork.freedesktop.org/series/16002/ State : failure == Summary == Series 16002v1 drm: Promote drm_mm alignment to u64 https://patchwork.freedesktop.org/api/1.0/series/16002/revisions/1/mbox/ Test gem_close_rac

[Intel-gfx] [PATCH] drm: Promote drm_mm alignment to u64

In places (e.g. i915.ko), the alignment is exported to userspace as u64 and there now exists hardware for which we can indeed utilize a u64 alignment. As such, we need to keep 64bit integers throughout when handling alignment. Testcase: igt/drm_mm/align64 Testcase: igt/gem_exec_alignment Signed-of

Re: [Intel-gfx] [alsa-devel] [RFC PATCH v3 1/7] drm/i915: setup bridge for HDMI LPE audio driver

On 11/24/16 7:31 AM, Ville Syrjälä wrote: +static void lpe_audio_irq_unmask(struct irq_data *d) +{ + struct drm_device *dev = d->chip_data; + struct drm_i915_private *dev_priv = to_i915(dev); + unsigned long irqflags; + u32 val = (I915_LPE_PIPE_A_INTERRUPT | +

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/3] drm: Use u64_to_user_ptr() helper for blob ioctls

== Series Details == Series: series starting with [1/3] drm: Use u64_to_user_ptr() helper for blob ioctls URL : https://patchwork.freedesktop.org/series/16000/ State : warning == Summary == Series 16000v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/16000/revis

[Intel-gfx] [PATCH 3/3] drm: Fix shift operations for drm_fb_helper::drm_target_preferred()

smatch correctly warns: drivers/gpu/drm/drm_fb_helper.c:1960 drm_target_preferred() warn: should '1 << i' be a 64 bit type? drivers/gpu/drm/drm_fb_helper.c:2001 drm_target_preferred() warn: should '1 << i' be a 64 bit type? Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_f

[Intel-gfx] [PATCH 1/3] drm: Use u64_to_user_ptr() helper for blob ioctls

Remove the ugly sparse casts by using the helper u64_to_user_ptr() instead. Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_property.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c index d1e50a

[Intel-gfx] [PATCH 2/3] drm: Avoid NULL dereference for DRM_LEGACY debug message

smatch warns: drivers/gpu/drm/drm_lock.c:188 drm_legacy_lock() warn: variable dereferenced before check 'master->lock.hw_lock' (see line 177) Signed-off-by: Chris Wilson --- drivers/gpu/drm/drm_lock.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

Re: [Intel-gfx] [PATCH 1/2] drm: Add some kselftests for the DRM range manager (struct drm_mm)

Am 27.11.2016 um 15:08 schrieb Chris Wilson: A set of test cases to capture some annoying bugs and to ensure that correct behaviour does not regress whilst fixing those! Signed-off-by: Chris Wilson Acked-by: Christian König . --- drivers/gpu/drm/Kconfig | 13 + drivers/gpu

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm: Add some kselftests for the DRM range manager (struct drm_mm)

== Series Details == Series: series starting with [1/2] drm: Add some kselftests for the DRM range manager (struct drm_mm) URL : https://patchwork.freedesktop.org/series/15997/ State : failure == Summary == HOSTCC scripts/basic/fixdep HOSTCC scripts/kconfig/conf.o SHIPPED scripts/kcon

[Intel-gfx] [PATCH 2/2] drm/i915: Build DRM range manager selftests for CI

Build the struct drm_mm selftests so that we can trivially run them within our CI. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Kconfig.debug | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/Kconfig.debug b/drivers/gpu/drm/i915/Kconfig.debug index f0e769290e0b..e

[Intel-gfx] [PATCH 1/2] drm: Add some kselftests for the DRM range manager (struct drm_mm)

A set of test cases to capture some annoying bugs and to ensure that correct behaviour does not regress whilst fixing those! Signed-off-by: Chris Wilson --- drivers/gpu/drm/Kconfig | 13 + drivers/gpu/drm/Makefile | 2 + drivers/gpu/drm/test-drm_mm.c | 829 +