guc_send(), guc_recv() and related functions were introduced in the
i915_guc_submission.c and their scope was limited only to that file.
Those are not submission specific though.
This patch moves moves them to intel_uc.c with intel_ prefix added.
v2: rename intel_guc_log_* functions and clean up
Cc: Chris Wilson
Cc: Michal Winiarski
Signed-off-by: Arkadiusz Hiler
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_guc_submission.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c
b/drivers/gpu/drm/i915/i915_guc_submission.c
index 4d12a7
send_mutex is used to serialise communication with GuC via
intel_guc_send().
Since functions that utilize it are no longer limited to submission,
initialization should be handled as a part of general setup.
v2: move initialization to *_early()
Cc: Chris Wilson
Cc: Michal Winiarski
Signed-off-b
GuC is not the only one micro controller we have.
There are also HuC and DMC.
Making the file more general will help with code organization.
Cc: Chris Wilson
Cc: Michal Winiarski
Signed-off-by: Arkadiusz Hiler
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h |
To facilitate code reorganization we are renaming everything that
contains guc2host or host2guc.
host2guc_action() and host2guc_action_response() become guc_send()
and guc_recv() respectively.
Other host2guc_*() functions become simply guc_*().
Other entities are renamed basing on context they a
With HuC being imminent we could benefit from some code reorganization.
There will be more uC than just GuC so we should name files accordingly.
There is also need to use host2guc_*() family of functions, which are currently
limited to submission only.
In effect host2guc and guc2host entities wer
== Series Details ==
Series: series starting with [1/3] drm/i915: Use helper for setting
plane->state->fb
URL : https://patchwork.freedesktop.org/series/15972/
State : success
== Summary ==
Series 15972v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/15972/revis
We can simplify the code greatly if both legacy and atomic paths updated
the references as they assigned the framebuffer to the planes. Long
before framebuffer reference counting was added, the code had to keep
the old_fb around until after the operation was completed - but now we
can simply leave
In a couple of places currently, and with the intent to add more, we
update a pointer to a framebuffer to hold a new fb reference (evicting
the old).
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_atomic.c | 8 ++--
include/drm/drm_framebuffer.h | 18 ++
2 files change
We are told not to set plane_state->fb directly, but use
drm_atomic_set_fb_for_plane() instead. Using the helper, means one less
piece of code that needs fixing should the interface change...
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_display.c | 6 +-
1 file changed, 1 inser
On Fri, Nov 25, 2016 at 04:41:14PM +0200, Abdiel Janulgue wrote:
> A lot of igt testcases need some GPU workload to make sure a race
> window is big enough. Unfortunately having a fixed amount of
> workload leads to spurious test failures or overly long runtimes
> on some fast/slow platforms. This
---
dim | 3 +++
1 file changed, 3 insertions(+)
diff --git a/dim b/dim
index a1a821d..a9ba6b3 100755
--- a/dim
+++ b/dim
@@ -855,6 +855,9 @@ function checkpatch_commit
git --no-pager log --oneline -1 $commit
$cmd | scripts/checkpatch.pl -q --emacs --strict - || true
+ if
On Thu, 2016-11-24 at 17:31 +0200, Ville Syrjälä wrote:
> On Thu, Nov 24, 2016 at 03:09:30PM +, Saarinen, Jani wrote:
> >
> > >
> > > == Series Details ==
> > >
> > > Series: drm/i915: Don't sanitize has_decoupled_mmio if platform is not
> > > broxton (rev2)
> > > URL : https://patchwork.f
On Wed, 2016-11-23 at 16:46 +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Pass dev_priv to intel_setup_outputs() (rev2)
> URL : https://patchwork.freedesktop.org/series/15820/
> State : success
Pushed. Thanks for the review.
Ander
On Tue, 15 Nov 2016, libin.y...@intel.com wrote:
> From: Libin Yang
>
> When bootup, audio driver may not know it is MST or not. The audio
> driver will poll all the port & pipe combinations in either MST or
> Non-MST mode. get_saved_enc() should handle this situation.
>
> Signed-off-by: Libin Yan
From: Lyude
Since we're going to be using lists for keeping track of EDIDs we've
allocated on the chamelium, add some generic list helpers from the
wayland project.
Signed-off-by: Lyude
Changes since v1:
- Rename list helpers to be more like those from the Linux kernel
---
lib/igt_aux.c | 27
A lot of igt testcases need some GPU workload to make sure a race
window is big enough. Unfortunately having a fixed amount of
workload leads to spurious test failures or overly long runtimes
on some fast/slow platforms. This library contains functionality
to submit GPU workloads that should consum
On Wed, Nov 23, 2016 at 02:27:35PM -0800, Anusha Srivatsa wrote:
> These patches add HuC loading support. The userspace
> patches that check for a fully loaded HuC firmware and use
> it can be found at:
> https://lists.freedesktop.org/archives/libva/2016-September/004554.html
> https://lists.freede
On Fri, Nov 25, 2016 at 03:22:13PM +0100, Arkadiusz Hiler wrote:
> guc_send(), guc_recv() and related functions were introduced in the
> i915_guc_submission.c and their scope was limited only to that file.
>
> Those are not submission specific though.
> This patch moves moves them to intel_uc.c wi
On Mon, 14 Nov 2016, libin.y...@intel.com wrote:
> From: Libin Yang
>
> (This patch is developed by Dave Airlie originally)
>
> This patch adds support for DP MST audio in i915.
>
> Enable audio codec when DP MST is enabled if has_audio flag is set.
> Disable audio codec when DP MST is disabled i
guc_send(), guc_recv() and related functions were introduced in the
i915_guc_submission.c and their scope was limited only to that file.
Those are not submission specific though.
This patch moves moves them to intel_uc.c with intel_ prefix added.
v2: rename intel_guc_log_* functions and clean up
To facilitate code reorganization we are renaming everything that
contains guc2host or host2guc.
host2guc_action() and host2guc_action_response() become guc_send()
and guc_recv() respectively.
Other host2guc_*() functions become simply guc_*().
Other entities are renamed basing on context they a
== Series Details ==
Series: series starting with [CI,1/4] drm/i915: Add is-completed assert to
request retire entrypoint
URL : https://patchwork.freedesktop.org/series/15965/
State : success
== Summary ==
Series 15965v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/se
Currently, we have an active reference for the request until it is
retired. Though it cannot be retired before it has been executed by
hardware, the request may be completed before we have finished
processing the execute fence, i.e. we may continue to process that fence
as we free the request.
Fix
Add the tracking required to enable debugobjects for fences to improve
error detection in BAT. The debugobject interface lets us track the
lifetime and phases of the fences even while being embedded into larger
structs, i.e. to check they are not used after they have been released.
v2: Don't popul
Before we return the request back to the kmem_cache after a failed
i915_gem_request_alloc(), we should assert that it has not been added to
any global state tracking.
Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_gem_request.c | 5 +
1 file changed,
While we will check that the request is completed prior to being
retired, by placing an assert that the request is complete at the
entrypoint of the function we can more clearly document the function's
preconditions.
Signed-off-by: Chris Wilson
Reviewed-by: Joonas Lahtinen
---
drivers/gpu/drm/i
On Fri, Nov 25, 2016 at 01:29:21PM +0100, Arkadiusz Hiler wrote:
> diff --git a/drivers/gpu/drm/i915/intel_guc_fwif.h
> b/drivers/gpu/drm/i915/intel_guc_fwif.h
> index 324ea90..9ccb8f8 100644
> --- a/drivers/gpu/drm/i915/intel_guc_fwif.h
> +++ b/drivers/gpu/drm/i915/intel_guc_fwif.h
> @@ -489,18 +
The target is that we report the vblank time accurate to within a
scanline (limit of the hw with which we can reliably compensate).
Signed-off-by: Chris Wilson
---
tests/kms_setmode.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/tests/kms_setmode.
To facilitate code reorganization we are renaming everything that
contains guc2host or host2guc.
host2guc_action() and host2guc_action_response() become guc_send()
and guc_recv() respectively.
Other host2guc_*() functions become simply guc_*().
Other entities are renamed basing on context they a
On Fri, Nov 25, 2016 at 11:23:19AM +, Chris Wilson wrote:
> > +int intel_guc_logging_control(struct intel_guc *guc, u32 control_val)
> > +{
> > + u32 data[2];
> > +
> > + data[0] = INTEL_GUC_ACTION_UK_LOG_ENABLE_LOGGING;
> > + data[1] = control_val;
> > +
> > + return intel_guc_send(guc
On Fri, Nov 25, 2016 at 12:00:43PM +0200, Petri Latvala wrote:
> On Thu, Nov 17, 2016 at 01:48:36PM +, Chris Wilson wrote:
> > Signed-off-by: Chris Wilson
> > Cc: Petri Latvala
> > ---
> > tests/intel-ci/fast-feedback.testlist | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/t
On Fri 2016-11-18 11:14:16, Chris Wilson wrote:
> On Fri, Nov 18, 2016 at 12:02:56PM +0100, Pavel Machek wrote:
> > Hi!
> >
> > With v4.9, if I maximize "nowcast -x" application, I get broken
> > display (as if someone split the window into rectangles and shuffled
> > them a bit). Switching virtua
On Fri, Nov 25, 2016 at 01:40:31PM +0200, Abdiel Janulgue wrote:
> Since we're going to be using lists for keeping track of spinners
> add some generic list helpers from the kernel.
I should also say look at the chamelium patches so that we only have to
import a circular list once (i.e. make sure
On Fri, Nov 25, 2016 at 01:40:31PM +0200, Abdiel Janulgue wrote:
> Since we're going to be using lists for keeping track of spinners
> add some generic list helpers from the kernel.
>
> Signed-off-by: Abdiel Janulgue
> ---
> lib/igt_aux.c | 39 +++
> lib/igt_a
On Fri, Nov 25, 2016 at 01:30:38PM +0200, Ville Syrjälä wrote:
> On Fri, Nov 25, 2016 at 12:57:01PM +0200, Imre Deak wrote:
> > commit 848496e5902833600f7992f4faa82dc1546051ba
> > Author: Ville Syrjälä
> > Date: Wed Jul 13 16:32:03 2016 +0300
> >
> > drm/i915: Wait up to 3ms for the pcu to
Since we're going to be using lists for keeping track of spinners
add some generic list helpers from the kernel.
Signed-off-by: Abdiel Janulgue
---
lib/igt_aux.c | 39 +++
lib/igt_aux.h | 46 ++
2 files changed, 85 i
A lot of igt testcases need some GPU workload to make sure a race
window is big enough. Unfortunately having a fixed amount of
workload leads to spurious test failures or overly long runtimes
on some fast/slow platforms. This library contains functionality
to submit GPU workloads that should consum
On Fri, Nov 25, 2016 at 12:57:01PM +0200, Imre Deak wrote:
> commit 848496e5902833600f7992f4faa82dc1546051ba
> Author: Ville Syrjälä
> Date: Wed Jul 13 16:32:03 2016 +0300
>
> drm/i915: Wait up to 3ms for the pcu to ack the cdclk change request on
> SKL
>
> increased the timeout to match
On Fri, Nov 25, 2016 at 12:39:25PM +0200, Joonas Lahtinen wrote:
> On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote:
> > Before we return the request back to the kmem_cache after a failed
> > i915_gem_request_alloc(), we should assert that it has not been added to
> > any global state tracking.
On Thu, Nov 24, 2016 at 05:13:21PM +0100, Arkadiusz Hiler wrote:
> guc_send(), guc_recv() and related functions were introduced in the
> i915_guc_submission.c and their scope was limited only to that file.
>
> Those are not submission specific though.
> This patch moves moves them to intel_uc.c wi
== Series Details ==
Series: series starting with [1/2] drm/i915/gen6+: Clear upper data byte during
PCODE write (rev2)
URL : https://patchwork.freedesktop.org/series/15911/
State : success
== Summary ==
Series 15911v2 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/seri
send_mutex is used to serialise communication with GuC via
intel_guc_send().
Since functions that utilize it are no longer limited to submission,
initialization should be handled as a part of general setup.
v2: move initialization to *_early()
Cc: Chris Wilson
Cc: Michal Winiarski
Signed-off-b
On Fri, Nov 25, 2016 at 12:57:01PM +0200, Imre Deak wrote:
> commit 848496e5902833600f7992f4faa82dc1546051ba
> Author: Ville Syrjälä
> Date: Wed Jul 13 16:32:03 2016 +0300
>
> drm/i915: Wait up to 3ms for the pcu to ack the cdclk change request on
> SKL
>
> increased the timeout to match
commit 848496e5902833600f7992f4faa82dc1546051ba
Author: Ville Syrjälä
Date: Wed Jul 13 16:32:03 2016 +0300
drm/i915: Wait up to 3ms for the pcu to ack the cdclk change request on SKL
increased the timeout to match the spec, but we still see a timeout on
at least one SKL. A CDCLK change req
Jerome -
The same as last time, I didn't receive any of the patches, neither the
intel-gfx nor alsa-devel list archives have them, patchwork doesn't have
them, they're not in intel-gfx moderation queueu. I only have the
replies.
Please check your setup, and make sure your patches actually hit th
On Fri, Nov 25, 2016 at 12:31:03PM +0200, Joonas Lahtinen wrote:
> On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote:
> > Currently, we have an active reference for the request until it is
> > retired. Though it cannot be retired before it has been executed by
> > hardware, the request may be co
== Series Details ==
Series: drm/i915: Moving scaler numbers to runtime init (rev4)
URL : https://patchwork.freedesktop.org/series/15726/
State : success
== Summary ==
Series 15726v4 drm/i915: Moving scaler numbers to runtime init
https://patchwork.freedesktop.org/api/1.0/series/15726/revision
On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote:
> Before we return the request back to the kmem_cache after a failed
> i915_gem_request_alloc(), we should assert that it has not been added to
> any global state tracking.
>
> Signed-off-by: Chris Wilson
> ---
> drivers/gpu/drm/i915/i915_gem
On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote:
> While we will check that the request is completed prior to being
> retired, by placing an assert that the request is complete at the
> entrypoint of the function we can more clearly document the function's
> preconditions.
>
> Signed-off-by:
On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote:
> Only once the debugobject symbols are exported can we enable support for
> debugging swfences when i915 is built as a module. Requires commit
> 2617fdca3f68 ("lib/debugobjects: export for use in modules")
>
> Signed-off-by: Chris Wilson
Rev
On 11/25/2016 3:14 PM, Chris Wilson wrote:
On Fri, Nov 25, 2016 at 03:16:58PM +0530, Nabendu Maiti wrote:
In future patches, we require greater flexibility in describing
the number of scalers available on each CRTC. To ease that transition
we move the current assignment to intel_device_info.
On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote:
> Currently, we have an active reference for the request until it is
> retired. Though it cannot be retired before it has been executed by
> hardware, the request may be completed before we have finished
> processing the execute fence, i.e. we m
On pe, 2016-11-25 at 09:30 +, Chris Wilson wrote:
> Add the tracking required to enable debugobjects to improve error
> detection in BAT. The debugobject interface lets us to track the
> lifetime of the fences even while being embedded into larger structs,
> i.e. to check they are not used aft
On Fri, Nov 25, 2016 at 05:42:38AM +, Anand, Jerome wrote:
>
>
> > -Original Message-
> > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com]
> > Sent: Thursday, November 24, 2016 7:02 PM
> > To: Anand, Jerome
> > Cc: intel-gfx@lists.freedesktop.org; alsa-de...@alsa-project.or
== Series Details ==
Series: series starting with [01/15] drm: Hold mode_config.lock to prevent
hotplug whilst setting up crtcs
URL : https://patchwork.freedesktop.org/series/15950/
State : warning
== Summary ==
Series 15950v1 Series without cover letter
https://patchwork.freedesktop.org/api/
On Thu, Nov 17, 2016 at 01:48:36PM +, Chris Wilson wrote:
> Signed-off-by: Chris Wilson
> Cc: Petri Latvala
> ---
> tests/intel-ci/fast-feedback.testlist | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tests/intel-ci/fast-feedback.testlist
> b/tests/intel-ci/fast-feedback.testlist
On Mon, Oct 17, 2016 at 03:39:04PM +0300, Imre Deak wrote:
> Add gem_exec_suspend/basic-s3-devices and basic-s4-devices subtests to
> BAT. At the same time remove basic-s4 from the list, which is atm
> implicitly disabled via HIBERNATION=n in kconfig. We would need at least
> basic S4 coverage prov
On Fri, Nov 25, 2016 at 03:16:58PM +0530, Nabendu Maiti wrote:
> In future patches, we require greater flexibility in describing
> the number of scalers available on each CRTC. To ease that transition
> we move the current assignment to intel_device_info.
>
> Scaler structure initialisation is don
In future patches, we require greater flexibility in describing
the number of scalers available on each CRTC. To ease that transition
we move the current assignment to intel_device_info.
Scaler structure initialisation is done if scaler is available on the CRTC.
Gen9 check is not required as on de
Before we return the request back to the kmem_cache after a failed
i915_gem_request_alloc(), we should assert that it has not been added to
any global state tracking.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem_request.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/
Currently, we have an active reference for the request until it is
retired. Though it cannot be retired before it has been executed by
hardware, the request may be completed before we have finished
processing the execute fence, i.e. we may continue to process that fence
as we free the request.
Fix
Set the initial value of the doorbell cookie from the client.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_guc_submission.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c
b/drivers/gpu/drm/i915/i915_guc_submission.c
in
On Fri, Nov 25, 2016 at 09:23:01AM +, Chris Wilson wrote:
> On Thu, Nov 24, 2016 at 05:32:59PM +0200, Imre Deak wrote:
> > commit 848496e5902833600f7992f4faa82dc1546051ba
> > Author: Ville Syrjälä
> > Date: Wed Jul 13 16:32:03 2016 +0300
> >
> > drm/i915: Wait up to 3ms for the pcu to a
Something I missed before sending off the partial series was that the
non-scheduler guc reset path was broken (in the full series, this is
pushed to the execlists reset handler). The issue is that after a reset,
we have to refill the GuC workqueues, which we do by resubmitting the
requests. However
---
drivers/gpu/drm/i915/i915_params.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_params.c
b/drivers/gpu/drm/i915/i915_params.c
index 0e280fbd52f1..ef1e9921a2af 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_p
The client->cookie is a shadow of the doorbell->cookie value, so rename
it to indicate its association with the doorbell, like the doorbell id
and offset.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_debugfs.c| 2 +-
drivers/gpu/drm/i915/i915_guc_submission.c | 6 +++---
dri
Only once the debugobject symbols are exported can we enable support for
debugging swfences when i915 is built as a module. Requires commit
2617fdca3f68 ("lib/debugobjects: export for use in modules")
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/Kconfig.debug | 4 ++--
1 file changed, 2
In order to avoid some complexity in trying to reconstruct the
workqueues across reset, remember them instead. The issue comes when we
have to handle a reset between request allocation and submission, the
request has reserved space in the wq, but is not in any list so we fail
to restore the reserve
Switching the GuC on for BAT testing another patch revealed I had broken
(made spammy at least) resets with requests in flight on the GuC. In the
course of fixing that, I kept tripping over a nasty timing issue in the
reuse of requests (with many threads running in parallel we would retire
a reques
Just a couple of naked 64bit divides causing link errors on 32bit
builds, with:
ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined!
v2: do_div() is only u64/u32, we need a u32/u64!
v3: div_u64() == u64/u32, div64_u64() == u64/u64
Reported-by: kbuild test robot
Fixes: d79651522e
drm_fb_helper_probe_connector_modes() is always called before
drm_setup_crtcs(), so just move the call into drm_setup_crtcs for a
small bit of code compaction.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_fb_helper.c | 37 +++--
1 file changed, 11 insertion
Though we only walk the kernel_fb_helper_list inside a panic (or single
thread debugging), we still need to protect the list manipulation on
creating/removing a framebuffer device in order to prevent list
corruption.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/drm_fb_helper.c | 5 +
1 fi
i915_guc_info() (part of debugfs output) tries to avoid holding
struct_mutex for a long period by copying onto the stack. This causes a
warning that the stack frame is massive, so stop doing that. We can even
forgo holding the struct_mutex here as that doesn't serialise the values
being read (and t
The fb_helper->connector_count is modified when a new connector is
constructed following a hotplug event (e.g. DP-MST). This causes trouble
for drm_setup_crtcs() and friends that assume that fb_helper is
constant:
[ 1250.872997] BUG: KASAN: slab-out-of-bounds in drm_setup_crtcs+0x320/0xf80 at
add
While we will check that the request is completed prior to being
retired, by placing an assert that the request is complete at the
entrypoint of the function we can more clearly document the function's
preconditions.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem_request.c | 2 ++
Add the tracking required to enable debugobjects to improve error
detection in BAT. The debugobject interface lets us to track the
lifetime of the fences even while being embedded into larger structs,
i.e. to check they are not used after they have been released.
Signed-off-by: Chris Wilson
---
On Thu, Nov 24, 2016 at 05:32:59PM +0200, Imre Deak wrote:
> commit 848496e5902833600f7992f4faa82dc1546051ba
> Author: Ville Syrjälä
> Date: Wed Jul 13 16:32:03 2016 +0300
>
> drm/i915: Wait up to 3ms for the pcu to ack the cdclk change request on
> SKL
>
> increased the timeout to match
On Thu, Nov 24, 2016 at 12:16:11PM +0200, Abdiel Janulgue wrote:
> A lot of igt testcases need some GPU workload to make sure a race
> window is big enough. Unfortunately having a fixed amount of
> workload leads to spurious test failures or overly long runtimes
> on some fast/slow platforms. This
79 matches
Mail list logo
