On ke, 2016-10-05 at 17:53 +0100, Tvrtko Ursulin wrote:
> On 05/10/2016 17:50, Tvrtko Ursulin wrote:
> >
> >
> > On 05/10/2016 16:07, Joonas Lahtinen wrote:
> > >
> > > On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote:
> > > >
> > > > From: Tvrtko Ursulin
> > > >
> > > > Use types of mo
On ke, 2016-10-05 at 21:05 +0100, Chris Wilson wrote:
> In order not to trigger hangcheck on a idle-but-waiting engine, we need
> to distinguish between the pending request queue and the actual
> execution queue. This is done later in "drm/i915: Enable multiple
> timelines" but for now we need a te
On Wed, Oct 05, 2016 at 04:20:04PM -0700, Anusha Srivatsa wrote:
> Proper functioning of HuC requires GuC to be
> loaded. Make GuC loads default so that HuC works
> seemlessly.
> Also, note that GuC submission is not made default
> and still needs to be given as a kernel parameter.
> Once the issue
On Thu, Oct 06, 2016 at 09:31:32AM +0300, Petri Latvala wrote:
> See tests/intel-ci/README for rationale and explanation.
A lot of those tests are garbage and not future proof making them
useless for regression testing. Including them just adds noise and us
ignoring the results.
-Chris
--
Chris
See tests/intel-ci/README for rationale and explanation.
Signed-off-by: Petri Latvala
---
The plans for CI are to use explicit test lists in the future, as laid
out in this commit. Comments, acks, nacks, flames, etc would be very
welcome.
The only list so far is a fattened version of the curre
== Series Details ==
Series: drm/i915/guc: Sanitory checks for platform that dont have GuC
URL : https://patchwork.freedesktop.org/series/13358/
State : failure
== Summary ==
Series 13358v1 drm/i915/guc: Sanitory checks for platform that dont have GuC
https://patchwork.freedesktop.org/api/1.0/
On Tue, 2016-10-04 at 10:05 +0300, Jani Nikula wrote:
> On Tue, 04 Oct 2016, "Vivi, Rodrigo" wrote:
> > On Mon, 2016-10-03 at 13:50 +0300, Jani Nikula wrote:
> >> On Fri, 30 Sep 2016, Rodrigo Vivi wrote:
> >> > According to spec: "KBL re-uses SKL values, except where
> >> > specific KBL values a
i915.enable_guc_loading/submission=2 forces the usage of GuC.
For platforms that do not have a GuC, asking the kernel to
use a GuC should not result in an error state. Do extra checks
to see if the platform even has a GuC or not, regardless of the
kernel parameter.
Cc: Zanoni Paulo
Signed-off-by:
== Series Details ==
Series: i915/GuC: Make GuC loads default
URL : https://patchwork.freedesktop.org/series/13356/
State : warning
== Summary ==
Series 13356v1 i915/GuC: Make GuC loads default
https://patchwork.freedesktop.org/api/1.0/series/13356/revisions/1/mbox/
Test drv_module_reload_bas
Hi Daniel,
So, can we close https://bugs.freedesktop.org/show_bug.cgi?id=97573 with
wontfix or notabug?
I don't have a strong side on that actually, but Jani was against it it
seems.
Thanks,
Rodrigo.
On Wed, 2016-10-05 at 15:50 +0200, Daniel Vetter wrote:
> On Thu, Sep 22, 2016 at 04:55:07PM +0
Proper functioning of HuC requires GuC to be
loaded. Make GuC loads default so that HuC works
seemlessly.
Also, note that GuC submission is not made default
and still needs to be given as a kernel parameter.
Once the issues around GuC submission is resolved it
is intended to make it default as well
From: Lionel Landwerlin
Signed-off-by: Lionel Landwerlin
Cc: Sirisha Gandikota
---
tools/intel_aubdump.in | 4
1 file changed, 4 deletions(-)
diff --git a/tools/intel_aubdump.in b/tools/intel_aubdump.in
index feee23a..3666b6e 100644
--- a/tools/intel_aubdump.in
+++ b/tools/intel_aubdump.
This comes handy if you want to look at your application output without
having to save it into a file. For example, use this with aubinator from
Mesa :
$ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app
v2: Fix handling empty command line option
Signed-off-by: Lionel Landwerlin
Cc: Sir
On Wed, Oct 05, 2016 at 06:44:04PM -0300, Paulo Zanoni wrote:
> Em Qua, 2016-10-05 às 11:33 -0400, Lyude escreveu:
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > index dd15ae2..c580d3d 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > ++
Em Qua, 2016-10-05 às 11:33 -0400, Lyude escreveu:
> Now that we've make skl_wm_levels make a little more sense, we can
> remove all of the redundant wm information. Up until now we'd been
> storing two copies of all of the skl watermarks: one being the
> skl_pipe_wm structs, the other being the gl
Reviewed-by: Rodrigo Vivi
On Mon, Oct 03, 2016 at 11:43:01AM -0700, Anusha Srivatsa wrote:
> From: Peter Antoine
>
> This patch returns the GuC status to the caller. It is used so
> that the userspace knows if the GuC has been loaded.
>
> v4: rebase.
> v5: rebased.
>
> Signed-off-by: Anusha
Reviewed-by: Rodrigo Vivi
On Mon, Oct 03, 2016 at 11:43:02AM -0700, Anusha Srivatsa wrote:
> From: Peter Antoine
>
> This patch will allow for getparams to return the status of the HuC.
> As the HuC has to be validated by the GuC this patch uses the validated
> status to show when the HuC is
== Series Details ==
Series: drm/i915: Distinguish last emitted request from last submitted request
URL : https://patchwork.freedesktop.org/series/13347/
State : success
== Summary ==
Series 13347v1 drm/i915: Distinguish last emitted request from last submitted
request
https://patchwork.freed
Em Qua, 2016-10-05 às 11:33 -0400, Lyude escreveu:
> Having skl_wm_level contain all of the watermarks for each plane is
> annoying since it prevents us from having any sort of object to
> represent a single watermark level, something we take advantage of in
> the next commit to cut down on all of
Em Qua, 2016-10-05 às 11:33 -0400, Lyude escreveu:
> Next part of cleaning up the watermark code for skl. This is easy,
> since
> it seems that we never actually needed to keep track of the linetime
> in
> the skl_wm_values struct anyway.
Reviewed-by: Paulo Zanoni
>
> Signed-off-by: Lyude
> Cc
Em Qua, 2016-10-05 às 11:33 -0400, Lyude escreveu:
> First part of cleaning up all of the skl watermark code. This moves
> the
> structures for storing the ddb allocations of each pipe into
> intel_crtc_state, along with moving the structures for storing the
> current ddb allocations active on hard
In order not to trigger hangcheck on a idle-but-waiting engine, we need
to distinguish between the pending request queue and the actual
execution queue. This is done later in "drm/i915: Enable multiple
timelines" but for now we need a temporary fix to prevent blaming the
wrong engine for a GPU hang
Em Qua, 2016-10-05 às 11:33 -0400, Lyude escreveu:
> This option allows us to manually control the SAGV at module load
> time.
> This can be useful in situations such as trying to debug watermark
> changes, since enabled SAGV + incorrect watermarks = total GPU
> annihilation.
I'm not a huge fan of
On Wed, Oct 05, 2016 at 01:33:31PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> This saves 3248 bytes of .rodata strings.
>
> Signed-off-by: Tvrtko Ursulin
> ---
> drivers/gpu/drm/i915/i915_drv.h | 8 +++---
> drivers/gpu/drm/i915/intel_crt.c | 10 +++
> drivers/gpu/
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc
head: a4fce9cb782ad340ee5576a38e934e5e75832dc6
commit: a4fce9cb782ad340ee5576a38e934e5e75832dc6 [25/25] drm/prime: Take a ref
on the drm_dev when exporting a dma_buf
reproduce: make htmldocs
All warnings (new ones prefixed by >>):
On Wed, Oct 05, 2016 at 01:33:30PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Use types of more appropriate size in struct
> intel_watermark_params to save 512 bytes of .rodata.
>
> Signed-off-by: Tvrtko Ursulin
> ---
> drivers/gpu/drm/i915/intel_drv.h | 10 +-
> drivers/g
Hi,
I'm preparing a fixes pull request, and I'll include this one if it
hasn't been applied by others already.
Sinclair
On Wed, Oct 05, 2016 at 09:41:22PM +0530, Sumit Semwal wrote:
> Hi Thomas, Sinclair,
>
> On 23 September 2016 at 18:26, Daniel Vetter wrote:
> > On Mon, Aug 29, 2016 at 08:0
On Wed, Oct 05, 2016 at 01:33:28PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> unsigned long is too wide - use smaller types in
> struct cxsr_latency to save 800-something bytes of .rodata.
>
> Signed-off-by: Tvrtko Ursulin
> ---
> drivers/gpu/drm/i915/intel_drv.h | 16
On 05/10/2016 17:50, Tvrtko Ursulin wrote:
On 05/10/2016 16:07, Joonas Lahtinen wrote:
On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Use types of more appropriate size in struct
intel_watermark_params to save 512 bytes of .rodata.
Signed-off-by: Tvrtko Ursuli
On 05/10/2016 16:07, Joonas Lahtinen wrote:
On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Use types of more appropriate size in struct
intel_watermark_params to save 512 bytes of .rodata.
Signed-off-by: Tvrtko Ursulin
The code does seem to use datatypes very
== Series Details ==
Series: Start of skl watermark cleanup
URL : https://patchwork.freedesktop.org/series/1/
State : warning
== Summary ==
Series 1v1 Start of skl watermark cleanup
https://patchwork.freedesktop.org/api/1.0/series/1/revisions/1/mbox/
Test gem_exec_flush:
S
Hi Lucas,
On 23 September 2016 at 18:25, Daniel Vetter wrote:
> On Mon, Aug 29, 2016 at 08:08:25AM +0100, Chris Wilson wrote:
>> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a
>> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not
>> need to handle such c
Hi Thomas, Sinclair,
On 23 September 2016 at 18:26, Daniel Vetter wrote:
> On Mon, Aug 29, 2016 at 08:08:28AM +0100, Chris Wilson wrote:
>> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a
>> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not
>> need to ha
Hi Ben,
On 23 September 2016 at 18:25, Daniel Vetter wrote:
> On Mon, Aug 29, 2016 at 08:08:27AM +0100, Chris Wilson wrote:
>> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a
>> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not
>> need to handle such con
Hi Alex,
On 23 September 2016 at 18:24, Daniel Vetter wrote:
> On Mon, Aug 29, 2016 at 08:08:24AM +0100, Chris Wilson wrote:
>> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a
>> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not
>> need to handle such co
Having skl_wm_level contain all of the watermarks for each plane is
annoying since it prevents us from having any sort of object to
represent a single watermark level, something we take advantage of in
the next commit to cut down on all of the copy paste code in here.
Signed-off-by: Lyude
Cc: Maa
Finally, add some debugging output for ddb changes in the atomic debug
output. This makes it a lot easier to spot bugs from incorrect ddb
allocations.
Signed-off-by: Lyude
Cc: Maarten Lankhorst
Cc: Ville Syrjälä
Cc: Matt Roper
---
drivers/gpu/drm/i915/intel_pm.c | 57 +
Now that we've make skl_wm_levels make a little more sense, we can
remove all of the redundant wm information. Up until now we'd been
storing two copies of all of the skl watermarks: one being the
skl_pipe_wm structs, the other being the global wm struct in
drm_i915_private containing the raw regis
> > On Mon, 03 Oct 2016, Jairo Miramontes
> > wrote:
> > > This week regressions
> >
> > In the past we used "regression", "bisect_pending", and "bisected" in
> > the bugzilla "Keywords" field. Can we start using those again, please?
>
> I think this is a very good idea Jani. So we can start to s
>
> On Mon, 03 Oct 2016, Jairo Miramontes
> wrote:
> > This week regressions
>
> In the past we used "regression", "bisect_pending", and "bisected" in
> the bugzilla "Keywords" field. Can we start using those again, please?
I think this is a very good idea Jani. So we can start to scrub current
While it (mostly) works, the code for handling watermarks on Skylake has been
kind of ugly for a while. As well a lot of it isn't that friendly to atomic
transactions, Lots of copy paste, redundant wm values, etc. While this isn't a
full cleanup, it's a good start. As well, we add a couple of featu
First part of cleaning up all of the skl watermark code. This moves the
structures for storing the ddb allocations of each pipe into
intel_crtc_state, along with moving the structures for storing the
current ddb allocations active on hardware into intel_crtc.
Signed-off-by: Lyude
Cc: Maarten Lank
This option allows us to manually control the SAGV at module load time.
This can be useful in situations such as trying to debug watermark
changes, since enabled SAGV + incorrect watermarks = total GPU
annihilation.
Signed-off-by: Lyude
Cc: Maarten Lankhorst
Cc: Ville Syrjälä
Cc: Matt Roper
--
Next part of cleaning up the watermark code for skl. This is easy, since
it seems that we never actually needed to keep track of the linetime in
the skl_wm_values struct anyway.
Signed-off-by: Lyude
Cc: Maarten Lankhorst
Cc: Ville Syrjälä
Cc: Matt Roper
---
drivers/gpu/drm/i915/i915_drv.h
On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Use types of more appropriate size in struct
> intel_watermark_params to save 512 bytes of .rodata.
>
> Signed-off-by: Tvrtko Ursulin
The code does seem to use datatypes very sloppily. Where did you pick
up thes
On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira wrote:
> Use struct bxt_ddi_phy_info to hold information of where the Rcomp
> resistor is located, instead of hard coding it in the init sequence.
>
> Note that this moves the enabling of the phy with the Rcomp resistor out
> of the pow
== Series Details ==
Series: .rodata diet
URL : https://patchwork.freedesktop.org/series/13323/
State : warning
== Summary ==
Series 13323v1 .rodata diet
https://patchwork.freedesktop.org/api/1.0/series/13323/revisions/1/mbox/
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-a:
On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira wrote:
> Information about which phy is dual channel is hardcoded in the phy init
> sequence. Split that to a separate struct so the init sequence is more
> generic.
>
> Signed-off-by: Ander Conselvan de Oliveira
> ---
> drivers/gpu/d
On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote:
> > From: Tvrtko Ursulin
>
> Saves 1520 bytes of .rodata strings.
>
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gf
On Mon, Sep 26, 2016 at 12:20:44PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> This reverts commit 10b6ee4a87811a110cb01eaca01eb04da6801baf.
>
> According to [1] Dell XPS8700 VBT says 'int_crt_support 0', so thanks
> to commit e4abb733bb72 ("drm/i915: Check VBT for CRT
On Wed, Oct 05, 2016 at 02:39:16PM +0100, Tvrtko Ursulin wrote:
>
> On 05/10/2016 14:01, Jani Nikula wrote:
>
> >On Wed, 05 Oct 2016, Tvrtko Ursulin wrote:
> >>Dynamic typing in __I915__ (INTEL_INFO) has and unfortuante consequence that
> >>for every time it is called under a WARN it generates a
On Thu, Sep 22, 2016 at 04:55:07PM +, Vivi, Rodrigo wrote:
> On Wed, 2016-09-21 at 18:00 -0300, Paulo Zanoni wrote:
> > Em Qua, 2016-09-21 às 11:22 -0700, Rodrigo Vivi escreveu:
> > > Avoid any kind of GuC handling if GuC is not supported
> > > on a giving platform.
> > >
> > > Besides being u
On 04/10/2016 16:46, Praveen Paneri wrote:
Decoupled MMIO is an alternative way to access forcewake domain
registers, which requires less cycles for a single read/write and
avoids frequent software forcewake.
This certainly gives advantage over the forcewake as this new
mechanism “decouples” CPU
On Wed, Oct 05, 2016 at 07:23:23AM +0200, Greg KH wrote:
> On Tue, Oct 04, 2016 at 08:43:03PM -0300, Gaston Gonzalez wrote:
> > Hi,
> >
> > After hibernation I get the following error when I tried to connect to
> > monitor
> > through hdmi:
> >
> > $ xrandr --output LVDS1 --off --output HDMI1
On Wed, Oct 05, 2016 at 02:40:09PM +0100, Chris Wilson wrote:
> On Wed, Oct 05, 2016 at 03:11:00PM +0200, Daniel Vetter wrote:
> > On Fri, Sep 30, 2016 at 02:59:59PM +0100, Chris Wilson wrote:
> > > In order to keep the dmabuf alive whilst the mmap is, we need to hold a
> > > reference to the dmabu
On Wed, Oct 05, 2016 at 03:11:00PM +0200, Daniel Vetter wrote:
> On Fri, Sep 30, 2016 at 02:59:59PM +0100, Chris Wilson wrote:
> > In order to keep the dmabuf alive whilst the mmap is, we need to hold a
> > reference to the dmabuf and not the backing object. This is important as
> > the dmabuf not
On 05/10/2016 14:01, Jani Nikula wrote:
On Wed, 05 Oct 2016, Tvrtko Ursulin wrote:
Dynamic typing in __I915__ (INTEL_INFO) has and unfortuante consequence that
for every time it is called under a WARN it generates a very verbose string
placed into the appropriate .rodata section.
AFAIK the i
== Series Details ==
Series: series starting with [v4,1/3] drm/prime: Pass the right module owner
through to dma_buf_export()
URL : https://patchwork.freedesktop.org/series/13322/
State : warning
== Summary ==
Series 13322v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.
On ke, 2016-10-05 at 15:22 +0300, Joonas Lahtinen wrote:
> So nothing related to the series, good to merge unless there's a
> direct
> Nack. Jani?
Not-Ncked on IRC, so merged, thanks for the review!
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
__
On Fri, Sep 30, 2016 at 02:59:59PM +0100, Chris Wilson wrote:
> In order to keep the dmabuf alive whilst the mmap is, we need to hold a
> reference to the dmabuf and not the backing object. This is important as
> the dmabuf not only keeps the object alive, but also the device so that
>
> dma
For the series:
Reviewed-by: Petri Latvala
On 10/05/2016 03:21 PM, Chris Wilson wrote:
dma_buf_export() adds a reference to the owning module to the dmabuf (to
prevent the driver from being unloaded whilst a third party still refers
to the dmabuf). However, drm_gem_prime_export() was passing i
On Wed, 05 Oct 2016, Tvrtko Ursulin wrote:
> Dynamic typing in __I915__ (INTEL_INFO) has and unfortuante consequence that
> for every time it is called under a WARN it generates a very verbose string
> placed into the appropriate .rodata section.
AFAIK the idea all along was to use this "dynamic
On Mon, 03 Oct 2016, Jairo Miramontes
wrote:
> This week regressions
In the past we used "regression", "bisect_pending", and "bisected" in
the bugzilla "Keywords" field. Can we start using those again, please?
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
== Series Details ==
Series: Broxton ddi phy refactoring
URL : https://patchwork.freedesktop.org/series/13320/
State : warning
== Summary ==
Series 13320v1 Broxton ddi phy refactoring
https://patchwork.freedesktop.org/api/1.0/series/13320/revisions/1/mbox/
Test kms_pipe_crc_basic:
Sub
From: Tvrtko Ursulin
Saves 944 bytes of .rodata strings and 128 bytes of .text.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_gem_fence.c | 2 +-
drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++--
drivers/gpu/drm/i915/intel_crt.c
From: Tvrtko Ursulin
Saves 1392 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/i915_drv.h | 5 +++--
drivers/gpu/drm/i915/i915_gem_gtt.c | 40 +
drivers/gpu/drm/i915/
From: Tvrtko Ursulin
Saves 1520 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel_engine_cs.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c
b/drivers/gpu/drm/i915/intel_engine_cs.c
index d
From: Tvrtko Ursulin
Saves 1416 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_debugfs.c| 4 +-
drivers/gpu/drm/i915/i915_drv.c| 6 +--
drivers/gpu/drm/i915/i915_drv.h| 16 +++---
drivers/gpu/drm/i915/i915_gem.c
From: Tvrtko Ursulin
Saves 472 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_irq.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_
From: Tvrtko Ursulin
Saves 4472 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.c| 14 +++--
drivers/gpu/drm/i915/i915_drv.h| 111 +
drivers/gpu/drm/i915/i915_gem.c| 36 +--
drivers/gpu/
From: Tvrtko Ursulin
Saves 944 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 619bec953b0d..06320001f3a8 1006
From: Tvrtko Ursulin
Saves 968 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_gem_render_state.c | 6 +++---
drivers/gpu/drm/i915/intel_display.c | 2 +-
drivers/gpu/drm/i915/intel_sprite.c
From: Tvrtko Ursulin
Saves 472 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h| 2 +-
drivers/gpu/drm/i915/i915_gem_stolen.c | 5 +++--
drivers/gpu/drm/i915/i915_suspend.c| 4 ++--
drivers/gpu/drm/i915/intel_crt.c | 2 +-
driver
From: Tvrtko Ursulin
Use types of more appropriate size in struct
intel_watermark_params to save 512 bytes of .rodata.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel_drv.h | 10 +-
drivers/gpu/drm/i915/intel_pm.c | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-
From: Tvrtko Ursulin
Saves 1016 bytes of .rodata strings and couple hundred of .text.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
drivers/gpu/drm/i915/intel_guc_loader.c | 2 +-
3 files changed, 3 insertions(
From: Tvrtko Ursulin
Saves 960 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.c | 4 ++--
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +--
3 files changed, 4 insertions(+), 5 deletions(-)
diff -
From: Tvrtko Ursulin
Saves 848 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.c | 19 +++
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_gem.c | 2 +-
drivers/gpu/drm/i915/i915_gem_context.c
From: Tvrtko Ursulin
Saves 864 bytes of .rodata strings and ~100 of .text.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/i915_drv.h | 8 ++--
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
drivers/gpu/drm/i915/intel_audio.c
From: Tvrtko Ursulin
Pack the struct _sdvo_cmd_name to save 736 bytes of .rodata.
This is fine since the name pointers are used only for debug.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel_sdvo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/d
From: Tvrtko Ursulin
This saves 3248 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 8 +++---
drivers/gpu/drm/i915/intel_crt.c | 10 +++
drivers/gpu/drm/i915/intel_display.c | 49 ++-
drivers/gpu/dr
From: Tvrtko Ursulin
Saves 1808 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.c | 6 --
drivers/gpu/drm/i915/i915_drv.h | 6 +++---
drivers/gpu/drm/i915/i915_gem.c | 5 +++--
drivers/gpu/drm/i915/i915_gem_gtt.c | 2
From: Tvrtko Ursulin
More .rodata string saving by avoid __I915__ magic inside WARNs.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h| 2 +-
drivers/gpu/drm/i915/intel_color.c | 6 +++---
drivers/gpu/drm/i915/intel_display.c | 8
drivers/gpu
From: Tvrtko Ursulin
Saves 2432 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_gem.c | 2 +-
drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++--
drivers/gpu/drm/i915/i915_irq.c | 4 ++--
drivers/gpu/dr
From: Tvrtko Ursulin
Dynamic typing in __I915__ (INTEL_INFO) has and unfortuante consequence that
for every time it is called under a WARN it generates a very verbose string
placed into the appropriate .rodata section.
Each instance of that can can several hundred bytes to the binary. One exampl
From: Tvrtko Ursulin
Saves 1320 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.c | 10 +-
drivers/gpu/drm/i915/i915_drv.h | 6 +++---
drivers/gpu/drm/i915/i915_gem_stolen.c | 2 +-
drivers/gpu/drm/i915/intel_ddi.c| 1
From: Tvrtko Ursulin
unsigned long is too wide - use smaller types in
struct cxsr_latency to save 800-something bytes of .rodata.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/intel_drv.h | 16
drivers/gpu/drm/i915/intel_pm.c | 4 ++--
2 files changed, 10 insertions
From: Tvrtko Ursulin
This saves 1872 bytes of .rodata strings.
Signed-off-by: Tvrtko Ursulin
---
drivers/gpu/drm/i915/i915_drv.h | 16 ++--
drivers/gpu/drm/i915/i915_gem.c | 2 +-
drivers/gpu/drm/i915/i915_gpu_error.c | 4 +--
drivers/gpu/drm/i915/i915_irq.c | 20 ++
In order to keep the dmabuf alive whilst the mmap is, we need to hold a
reference to the dmabuf and not the backing object. This is important as
the dmabuf not only keeps the object alive, but also the device so that
dmabuf = vgem_create_dmabuf();
ptr = mmap(... dmabuf ...);
dma_buf may live a long time, longer than the last direct user of the
driver. We already hold a reference to the owner module (that prevents
the object code from disappearing), but there is no reference to the
drm_dev - so the pointers to the driver backend themselves may vanish.
v2: Resist tempta
dma_buf_export() adds a reference to the owning module to the dmabuf (to
prevent the driver from being unloaded whilst a third party still refers
to the dmabuf). However, drm_gem_prime_export() was passing its own
THIS_MODULE (i.e. drm.ko) rather than the driver. Extract the right
owner from the de
On ke, 2016-10-05 at 11:19 +, Patchwork wrote:
> Test kms_pipe_crc_basic:
> Subgroup nonblocking-crc-pipe-a:
> pass -> DMESG-WARN (fi-skl-6700k)
[drm:intel_cpu_fifo_underrun_irq_handler [i915]] *ERROR* CPU pipe B FIFO
underrun
Existing bug;
https://bugs
The mapping from the BXT_DPIO_CMN_* power wells to their respective phys
required a detour implemented in the bxt_power_well_to_phy() function.
Instead, embed that information directly into the power_well struct, by
resurrecting the data field.
Signed-off-by: Ander Conselvan de Oliveira
---
dri
Use struct bxt_ddi_phy_info to hold information of where the Rcomp
resistor is located, instead of hard coding it in the init sequence.
Note that this moves the enabling of the phy with the Rcomp resistor out
of the power well enable code. That should be safe since
bxt_ddi_phy_init() is called whi
Information about which phy is dual channel is hardcoded in the phy init
sequence. Split that to a separate struct so the init sequence is more
generic.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/i915_reg.h | 9 +++--
drivers/gpu/drm/i915/intel_dpio_phy.c | 63 ++
Hi,
This is a small refactoring of the broxton ddi phy code that splits the
knowledge of each phy's configuration from the code itself and makes
the connection between the ports and the channels in the phy more
obvious.
I took the oppurtunity to move the code to intel_dpio_phy.c, since there
are
Move the DPIO phy documentation section to intel_dpio_phy.c, since that
is a more suitable place now that there is a source file dedicated for
those phys.
Signed-off-by: Ander Conselvan de Oliveira
---
Documentation/gpu/i915.rst| 2 +-
drivers/gpu/drm/i915/i915_reg.h | 91 +--
The vswing sequence is related to the DPIO phy, so move it closer to the
rest of DPIO phy related code.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/i915_drv.h | 3 +++
drivers/gpu/drm/i915/intel_ddi.c | 38 +-
drivers/gpu/drm/i
The phy in broxton is also a dpio phy, similar to cherryview but with
programming through MMIO. So move the code together with the other
similar phys.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/i915_drv.h | 12 ++
drivers/gpu/drm/i915/intel_ddi.c | 322 +
The port registers related to the phys in broxton map to different
channels and specific phys. Make that mapping explicit.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/i915_drv.h | 2 +
drivers/gpu/drm/i915/i915_reg.h | 211 +-
Calling it data seems to imply arbitrary data can be associated with the
power well. However, that field is used for look ups and expected to be
unique, so rename it.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/i915_drv.h | 3 +-
drivers/gpu/drm/i915/intel_runt
1 - 100 of 112 matches
Mail list logo
