On ti, 2016-10-04 at 15:54 +0200, Michał Winiarski wrote:
> Since "Dynamic page table allocations" were introduced, our page tables
> can grow (being dynamically allocated) with address space range usage.
> Unfortunately, their lifetime is bound to vm. This is not a huge problem
> when we're not us
Hi Chris,
On Wednesday 05 October 2016 01:26 AM, Chris Wilson wrote:
On Tue, Oct 04, 2016 at 09:16:06PM +0530, Praveen Paneri wrote:
+#define HAS_DECOUPLED_MMIO(dev) (INTEL_INFO(dev)->has_decoupled_mmio \
+ && IS_BXT_REVID(dev, BXT_REVID_C0, REVID_FOREVER))
Edit dev_priv->info.h
On ti, 2016-10-04 at 15:54 +0200, Michał Winiarski wrote:
> We're no longer using any invalid PTEs - everything that's not used
> should be pointing to scratch.
>
> Cc: Chris Wilson
> Cc: Joonas Lahtinen
> Cc: Michel Thierry
> Cc: Mika Kuoppala
> Signed-off-by: Michał Winiarski
Reviewed-by:
I wonder if GCC is doing the right thing, do we have some benchmark for
this, Chris, Mika? The code is much more readable in my eyes after the
changes.
On ti, 2016-10-04 at 15:54 +0200, Michał Winiarski wrote:
> +static void gen8_ppgtt_clear_pt(struct i915_address_space *vm,
> +
Thanks Chris for the review. Will fix these and resend.
~Praveen
On Wednesday 05 October 2016 01:26 AM, Chris Wilson wrote:
On Tue, Oct 04, 2016 at 09:16:06PM +0530, Praveen Paneri wrote:
+#define HAS_DECOUPLED_MMIO(dev) (INTEL_INFO(dev)->has_decoupled_mmio \
+ && IS_BXT_REVID(de
Hello, I've recently tried to combine HD display with laptop HDPI display
(1920x1200 + 3200x1800)
I've tried to follow this instruction
https://wiki.archlinux.org/index.php/HiDPI#Side_display
And final script looks like this
xrandr --output DP1 --scale 2x2 --mode 1920x1200 --fb 3840x4200 --pos 0x
== Series Details ==
Series: series starting with [CI,1/8] drm/i915: Share the computation of ring
size for RING_CTL register
URL : https://patchwork.freedesktop.org/series/13295/
State : success
== Summary ==
Series 13295v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.
On Braswell, at least, we observe that the context image is written in
multiple phases. The first phase is to clear the register state, and
subsequently rewrite it. A GPU reset at the right moment can interrupt
the context update leaving it corrupt, and our update of the RING_HEAD
is not sufficient
Check that there was not a late recovery between us declaring the GPU
hung and processing the reset. If the GPU did recover by itself, let the
request remain on the active list and see if it hangs again!
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
Reviewed-by: Mika Kuoppala
---
drivers/gpu/d
Knowing where the RINGs are pointing is extremely useful in diagnosing
if the engines are executing the ringbuffers you expect - and igt may be
suppressing the usual method of looking in the GPU error state.
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
Reviewed-by: Mika Kuoppala
---
drivers/g
It is convenient to know what processes are waiting when looking at
hangcheck status in debugfs.
Signed-off-by: Chris Wilson
Reviewed-by: Mika Kuoppala
---
drivers/gpu/drm/i915/i915_debugfs.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
Include the position of the active request in the ring, and display that
alongside the current RING registers (on a GPU hang).
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
Reviewed-by: Mika Kuoppala
---
drivers/gpu/drm/i915/i915_drv.h | 3 +++
drivers/gpu/drm/i915/i915_gpu_error.c | 9 +
After a GPU reset, we want to replay our queue of requests. However, the
GPU reset clobbered the state and we only fixup the state for the guilty
request - and engines deemed innocent we try to leave untouched so that
we recover as completely as possible. However, we need to clear the sw
tracking o
Since both legacy and execlists want to populate the RING_CTL register,
share the computation of the right bits for the ring->size. We can then
stop masking errors and explicitly forbid them during creation!
Signed-off-by: Chris Wilson
Cc: Mika Kuoppala
Reviewed-by: Mika Kuoppala
---
drivers/g
Whilst we reset the GPU, we want to prevent execlists from submitting
new work (which it does via an interrupt handler). To achieve this we
disable the irq (and drain the irq tasklet) around the reset. When we
enable it again afters, the interrupt queue should be empty and we can
reinitialise from
On Tue, Oct 04, 2016 at 09:16:06PM +0530, Praveen Paneri wrote:
> +#define HAS_DECOUPLED_MMIO(dev) (INTEL_INFO(dev)->has_decoupled_mmio \
> + && IS_BXT_REVID(dev, BXT_REVID_C0, REVID_FOREVER))
Edit dev_priv->info.has_decoupled_mmio on init.
> +static void __gen9_decoupled_mmio_access(
== Series Details ==
Series: drm/i915/gen9: fix DDB partitioning for multi-screen cases
URL : https://patchwork.freedesktop.org/series/13293/
State : success
== Summary ==
Series 13293v1 drm/i915/gen9: fix DDB partitioning for multi-screen cases
https://patchwork.freedesktop.org/api/1.0/series
Em Ter, 2016-10-04 às 14:37 -0300, Paulo Zanoni escreveu:
> With the previous code we were only recomputing the DDB partitioning
> for the CRTCs included in the atomic commit, so any other active
> CRTCs
> would end up having their DDB registers zeroed. In this patch we make
> sure that the compute
Is this still an embargoed feature? why?
With Apollolake out there we need to work to get permission to upstream
this feature already and post it to intel-gfx@lists.freedesktop.org in
order to get this merged upstream.
A decoupled version for BXT stayed in the internal for so long time and
caused
With the previous code we were only recomputing the DDB partitioning
for the CRTCs included in the atomic commit, so any other active CRTCs
would end up having their DDB registers zeroed. In this patch we make
sure that the computed state starts as a copy of the current
partitioning, and then we on
== Series Details ==
Series: drm/i915/bxt: Broxton decoupled MMIO (rev3)
URL : https://patchwork.freedesktop.org/series/12028/
State : warning
== Summary ==
Series 12028v3 drm/i915/bxt: Broxton decoupled MMIO
https://patchwork.freedesktop.org/api/1.0/series/12028/revisions/3/mbox/
Test drv_mo
Decoupled MMIO is an alternative way to access forcewake domain
registers, which requires less cycles for a single read/write and
avoids frequent software forcewake.
This certainly gives advantage over the forcewake as this new
mechanism “decouples” CPU cycles and allow them to complete even
when G
== Series Details ==
Series: series starting with [1/3] drm/i915/gtt: Split
gen8_ppgtt_clear_pte_range
URL : https://patchwork.freedesktop.org/series/13282/
State : failure
== Summary ==
Series 13282v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/13282/revision
This comes handy if you want to look at your application output without
having to save it into a file. For example, use this with aubinator from
Mesa :
$ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app
Signed-off-by: Lionel Landwerlin
Cc: Kristian Høgsberg
---
tools/aubdump.c
On Tue, 04 Oct 2016, Joonas Lahtinen wrote:
> Get rid of SEP_SEMICOLON and SEP_BLANK in DEV_INFO_FOR_EACH_FLAG.
>
> Signed-off-by: Joonas Lahtinen
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 6 +-
> drivers/gpu/drm/i915/i915_drv.h | 98
> +++-
> driv
Since "Dynamic page table allocations" were introduced, our page tables
can grow (being dynamically allocated) with address space range usage.
Unfortunately, their lifetime is bound to vm. This is not a huge problem
when we're not using softpin - drm_mm is creating an upper bound on used
range by c
Let's use more top-down approach, where each gen8_ppgtt_clear_* function
is responsible for clearing the struct passed as an argument and calling
relevant clear_range functions on lower-level tables.
Doing this rather than operating on PTE ranges makes the implementation
of shrinking page tables qu
We're no longer using any invalid PTEs - everything that's not used
should be pointing to scratch.
Cc: Chris Wilson
Cc: Joonas Lahtinen
Cc: Michel Thierry
Cc: Mika Kuoppala
Signed-off-by: Michał Winiarski
---
drivers/gpu/drm/i915/i915_gem.c| 6 +-
drivers/gpu/drm/i915/i915_gem_
== Series Details ==
Series: series starting with [1/2] drm/i915: Reduce trickery in
DEV_INFO_FOR_EACH_FLAG
URL : https://patchwork.freedesktop.org/series/13278/
State : warning
== Summary ==
Series 13278v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/13278/rev
On Tue, Oct 04, 2016 at 03:42:58PM +0300, Joonas Lahtinen wrote:
> Sort DEV_INFO_FOR_EACH_FLAG to alphabetical order (except is_*).
>
> Signed-off-by: Joonas Lahtinen
Ok. Looks like it should be easier to read.
Reviewed-by: Chris Wilson
Could you add something like:
/* Keep is_* in chronologi
Reviewed-by: Lyude
On Tue, 2016-10-04 at 12:29 +0300, Jani Nikula wrote:
> Fix sparse warning:
>
> drivers/gpu/drm/i915/intel_pm.c:3970:1: warning: symbol
> 'skl_ddb_add_affected_planes' was not declared. Should it be static?
>
> Fixes: 7f60e200e254 ("drm/i915/gen9: only add the planes actually
== Series Details ==
Series: Shared DPLL kernel doc and improvements
URL : https://patchwork.freedesktop.org/series/13277/
State : warning
== Summary ==
Series 13277v1 Shared DPLL kernel doc and improvements
https://patchwork.freedesktop.org/api/1.0/series/13277/revisions/1/mbox/
Test kms_pip
On Tue, Oct 04, 2016 at 03:42:57PM +0300, Joonas Lahtinen wrote:
> #define PRINT_S(name) "%s"
> -#define SEP_EMPTY
> -#define PRINT_FLAG(name) info->name ? #name "," : ""
> -#define SEP_COMMA ,
> +#define PRINT_FLAG(name) info->name ? #name "," : "",
> DRM_DEBUG_DRIVER("i915 device info: gen
Chris Wilson writes:
> Signed-off-by: Chris Wilson
With commit message stating the obvious added,
Reviewed-by: Mika Kuoppala
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gp
On Tue, Oct 04, 2016 at 03:35:20PM +0300, Mika Kuoppala wrote:
> Chris Wilson writes:
> > + rcu_read_unlock();
> > +
> > + addr = intel_engine_get_active_head(engine);
> > + seq_printf(m, "\tACTHD: 0x%08x_%08x\n",
> > + upper_32_bits(addr), lower
On Tue, Oct 04, 2016 at 03:41:24PM +0300, Mika Kuoppala wrote:
> Chris Wilson writes:
>
> The commit message is missing.
>
> > Signed-off-by: Chris Wilson
> > ---
> > drivers/gpu/drm/i915/i915_debugfs.c | 12
> > 1 file changed, 12 insertions(+)
> >
> > diff --git a/drivers/gpu/dr
Chris Wilson writes:
> On Mon, Oct 03, 2016 at 01:52:39PM +0100, Chris Wilson wrote:
>> Since both legacy and execlists want to poopulate the RING_CTL register,
>> share the computation of the right bits for the ring->size. We can then
>> stop masking errors and explicitly forbid them during crea
Sort DEV_INFO_FOR_EACH_FLAG to alphabetical order (except is_*).
Signed-off-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_drv.h | 36 ++--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i9
Get rid of SEP_SEMICOLON and SEP_BLANK in DEV_INFO_FOR_EACH_FLAG.
Signed-off-by: Joonas Lahtinen
---
drivers/gpu/drm/i915/i915_debugfs.c | 6 +-
drivers/gpu/drm/i915/i915_drv.h | 98 +++-
drivers/gpu/drm/i915/i915_gpu_error.c| 6 +-
drivers/gpu/drm
Chris Wilson writes:
The commit message is missing.
> Signed-off-by: Chris Wilson
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
> b/drivers/gpu/drm/i915/i915_debugfs.c
> index 9c95ce73f2aa
Chris Wilson writes:
> Knowing where the RINGs are pointing is extremely useful in diagnosing
> if the engines are executing the ringbuffers you expect - and igt may be
> suppressing the usual method of looking in the GPU error state.
>
> Signed-off-by: Chris Wilson
> Cc: Mika Kuoppala
> ---
>
Abstract the platform specific bits of mapping the dplls under a
platform independ entrypoints so the differences between platforms are
contained in the dpll code. I.e., it removes IS_PLATFORM() macros from
other parts of the code.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/
The documentation for most of the non-static members and structs were
missing. Fix that.
v2: Fix typos (Durga)
v3: Rebase.
Fix make docs warnings.
Document more.
Signed-off-by: Ander Conselvan de Oliveira
---
Documentation/gpu/i915.rst| 12 +++
drivers/gpu/drm/i915/intel_
The hook is called from intel_prepare_shared_dpll(). The name doesn't
make sense after all the changes to modeset code. So just call it
prepare.
Signed-off-by: Ander Conselvan de Oliveira
Reviewed-by: Durgadoss R
---
drivers/gpu/drm/i915/intel_dpll_mgr.c | 8
drivers/gpu/drm/i915/inte
Remove the IS_PLATFORM() macros from intel_dump_pipe_config() and split
that logic in platform specific implementations inside the dpll code,
accessed through a platform independent interface.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/intel_display.c | 35 +---
Struct intel_shared_dpll_config is used to hold the state of the DPLL in
the "atomic" sense, so call it state like everything else atomic.
Signed-off-by: Ander Conselvan de Oliveira
---
drivers/gpu/drm/i915/i915_debugfs.c | 12 +++
drivers/gpu/drm/i915/intel_atomic.c | 6 ++--
drivers/
The function intel_shared_dpll_commit() performs the equivalent of
drm_atomic_helper_swap_state() for the shared dpll state, which is not
handled by the helpers. So rename it for consistency.
v2: Fix typo in the commit message. (Durga)
v3: Rebase.
Signed-off-by: Ander Conselvan de Oliveira
Revie
While the details of getting a shared dpll are wrapped by
intel_get_shared_dpll(), the release was still hand rolled into the
modeset code. Fix that by creating an entry point for releasing the
pll and move that code there.
v2: Take old_dpll from crtc->state instead of crtc_state. (CI)
Signed-off-
Hi,
This is a resend of some previous patches adding documentation to the
shared dpll stuff, which I didn't merge since the first patch still
lacks review, plus some more changes on top to make the interface
more self contained.
Thanks,
Ander
Ander Conselvan de Oliveira (7):
drm/i915: Introduc
Chris Wilson writes:
> Include the position of the active request in the ring, and display that
> alongside the current RING registers (on a GPU hang).
>
> Signed-off-by: Chris Wilson
Reviewed-by: Mika Kuoppala
> Cc: Mika Kuoppala
> ---
> drivers/gpu/drm/i915/i915_drv.h | 3 +++
> dri
== Series Details ==
Series: series starting with [RESEND,1/2] drm/i915: workaround sparse warning
on variable length arrays
URL : https://patchwork.freedesktop.org/series/13269/
State : warning
== Summary ==
Series 13269v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0
On Tue, 04 Oct 2016, Joonas Lahtinen wrote:
> On ti, 2016-10-04 at 12:29 +0300, Jani Nikula wrote:
>> Fix sparse warning:
>>
>> drivers/gpu/drm/i915/intel_pm.c:3970:1: warning: symbol
>> 'skl_ddb_add_affected_planes' was not declared. Should it be static?
>>
>> Fixes: 7f60e200e254 ("drm/i915/gen
On ti, 2016-10-04 at 12:29 +0300, Jani Nikula wrote:
> Fix sparse warning:
>
> drivers/gpu/drm/i915/intel_pm.c:3970:1: warning: symbol
> 'skl_ddb_add_affected_planes' was not declared. Should it be static?
>
> Fixes: 7f60e200e254 ("drm/i915/gen9: only add the planes actually affected by
> ddb ch
== Series Details ==
Series: drm/i915: make skl_ddb_add_affected_planes static
URL : https://patchwork.freedesktop.org/series/13267/
State : warning
== Summary ==
Series 13267v1 drm/i915: make skl_ddb_add_affected_planes static
https://patchwork.freedesktop.org/api/1.0/series/13267/revisions/1
On 04/10/2016 10:37, Joonas Lahtinen wrote:
On ti, 2016-10-04 at 10:18 +0100, Tvrtko Ursulin wrote:
Joonas what do you think, worth merging on balance?
+1 on merging.
Pushed to dinq, first one from the new office. :)
Thanks for the review guys!
Regards,
Tvrtko
__
On ti, 2016-10-04 at 12:54 +0300, Jani Nikula wrote:
> drivers/gpu/drm/i915/i915_gem_execbuffer.c:432:52: warning: incorrect type in
> argument 1 (different address spaces)
> drivers/gpu/drm/i915/i915_gem_execbuffer.c:432:52:expected void [noderef]
> *vaddr
> drivers/gpu/drm/i915/i915_gem_exe
On Tue, 04 Oct 2016, Joonas Lahtinen wrote:
> On ti, 2016-10-04 at 12:54 +0300, Jani Nikula wrote:
>> @@ -192,7 +192,7 @@ static void broadwell_sseu_info_init(struct
>> drm_i915_private *dev_priv)
>> struct sseu_dev_info *sseu = &mkwrite_device_info(dev_priv)->sseu;
>> const int s_max =
On ti, 2016-10-04 at 12:54 +0300, Jani Nikula wrote:
> @@ -192,7 +192,7 @@ static void broadwell_sseu_info_init(struct
> drm_i915_private *dev_priv)
> struct sseu_dev_info *sseu = &mkwrite_device_info(dev_priv)->sseu;
> const int s_max = 3, ss_max = 3, eu_max = 8;
Does sparse shut up
drivers/gpu/drm/i915/i915_gem_execbuffer.c:432:52: warning: incorrect type in
argument 1 (different address spaces)
drivers/gpu/drm/i915/i915_gem_execbuffer.c:432:52:expected void [noderef]
*vaddr
drivers/gpu/drm/i915/i915_gem_execbuffer.c:432:52:got void *
drivers/gpu/drm/i915/i915_gem_e
Fix sparse warning:
drivers/gpu/drm/i915/intel_device_info.c:195:31: warning: Variable
length array is used.
In truth the array does have constant length, but sparse is too dumb to
realize. This is a bit ugly, but silence the warning no matter what.
Fixes: 91bedd34abf0 ("drm/i915/bdw: Check for
On ti, 2016-10-04 at 10:18 +0100, Tvrtko Ursulin wrote:
>
> Joonas what do you think, worth merging on balance?
>
+1 on merging.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
___
Intel-gfx mailing list
Intel-gfx@
Fix sparse warning:
drivers/gpu/drm/i915/intel_pm.c:3970:1: warning: symbol
'skl_ddb_add_affected_planes' was not declared. Should it be static?
Fixes: 7f60e200e254 ("drm/i915/gen9: only add the planes actually affected by
ddb changes")
Cc: Lyude
Cc: Paulo Zanoni
Signed-off-by: Jani Nikula
-
== Series Details ==
Series: drm/dp/i915: Enable audio codec after the HDA audio driver is
initialized
URL : https://patchwork.freedesktop.org/series/13265/
State : warning
== Summary ==
Series 13265v1 drm/dp/i915: Enable audio codec after the HDA audio driver is
initialized
https://patchwor
On Tue, 04 Oct 2016, Chris Wilson wrote:
> On Tue, Oct 04, 2016 at 10:53:48AM +0300, Jani Nikula wrote:
>> Move the outcast intel_fbdev_output_poll_changed() stub for
>> CONFIG_DRM_FBDEV_EMULATION=n next to its friends.
>>
>> Signed-off-by: Jani Nikula
> Reviewed-by: Chris Wilson
Thanks, pushe
On 04/10/2016 09:55, Chris Wilson wrote:
On Tue, Oct 04, 2016 at 09:46:50AM +0100, Tvrtko Ursulin wrote:
On 03/10/2016 10:27, Patchwork wrote:
fi-bdw-5557u total:236 pass:220 dwarn:0 dfail:0 fail:0 skip:15
fi-bxt-t5700 total:236 pass:205 dwarn:0 dfail:0 fail:0 skip:30
On Tue, Oct 04, 2016 at 09:46:50AM +0100, Tvrtko Ursulin wrote:
> On 03/10/2016 10:27, Patchwork wrote:
> >fi-bdw-5557u total:236 pass:220 dwarn:0 dfail:0 fail:0 skip:15
> >fi-bxt-t5700 total:236 pass:205 dwarn:0 dfail:0 fail:0 skip:30
> >fi-byt-j1900 total:236 pass:202
On 03/10/2016 10:27, Patchwork wrote:
== Series Details ==
Series: Forcewake binary search & code shrink (rev6)
URL : https://patchwork.freedesktop.org/series/13080/
State : warning
== Summary ==
Series 13080v6 Forcewake binary search & code shrink
https://patchwork.freedesktop.org/api/1.0/
This fixes the underruns that are seen in DP MST multi-monitor
setups when audio is enabled with
commit 3708d5e082c3 ("drm/i915: start adding dp mst audio"). The underruns
triggered continuous cycles of display on/off cycles.
Signed-off-by: Dhinakaran Pandiyan
Cc: Libin Yang
Cc: Ville Syrjälä
C
== Series Details ==
Series: drm/i915: keep CONFIG_DRM_FBDEV_EMULATION=n function stubs together
URL : https://patchwork.freedesktop.org/series/13262/
State : success
== Summary ==
Series 13262v1 drm/i915: keep CONFIG_DRM_FBDEV_EMULATION=n function stubs
together
https://patchwork.freedesktop
On Tue, Oct 04, 2016 at 10:53:48AM +0300, Jani Nikula wrote:
> Move the outcast intel_fbdev_output_poll_changed() stub for
> CONFIG_DRM_FBDEV_EMULATION=n next to its friends.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Chris Wilson
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
__
Move the outcast intel_fbdev_output_poll_changed() stub for
CONFIG_DRM_FBDEV_EMULATION=n next to its friends.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_display.c | 6 --
drivers/gpu/drm/i915/intel_drv.h | 4
2 files changed, 4 insertions(+), 6 deletions(-)
diff --gi
On Tue, 04 Oct 2016, "Vivi, Rodrigo" wrote:
> On Mon, 2016-10-03 at 13:50 +0300, Jani Nikula wrote:
>> On Fri, 30 Sep 2016, Rodrigo Vivi wrote:
>> > According to spec: "KBL re-uses SKL values, except where
>> > specific KBL values are listed."
>> >
>> > And recently spec has changed adding differ
72 matches
Mail list logo
