Em Qua, 2016-09-21 às 11:22 -0700, Rodrigo Vivi escreveu:
> Avoid any kind of GuC handling if GuC is not supported
> on a giving platform.
>
> Besides being useless handling, our driver needs
> to be smarter than the user trying to use an invalid paramenter.
So the problem is when a platform does
Em Qua, 2016-09-14 às 17:24 +0530, Kumar, Mahesh escreveu:
> From: Mahesh Kumar
>
> This patch enables Transition WM for SKL+ platforms.
>
> Transition WM are used if IPC is enabled, to decide, number of blocks
> to be fetched before reducing the priority of display to fetch from
> memory.
>
>
Em Sex, 2016-09-09 às 13:31 +0530, Kumar, Mahesh escreveu:
> From: Mahesh Kumar
>
> It implements the WA to enable IDLE_WAKEMEM bit of CHICKEN_DCPR_1
> register for Broxton platform. When IPC is enabled & Y-tile is
> enabled in any of the enabled plane, above bit should be set.
> Without this WA
== Series Details ==
Series: drm/i915/dp: DP audio API changes for MST (rev8)
URL : https://patchwork.freedesktop.org/series/10571/
State : success
== Summary ==
Series 10571v8 drm/i915/dp: DP audio API changes for MST
https://patchwork.freedesktop.org/api/1.0/series/10571/revisions/8/mbox/
T
Hi
Lots of nitpicking in my review. Feel free to disagree with them.
Em Sex, 2016-09-09 às 13:31 +0530, Kumar, Mahesh escreveu:
> From: Mahesh Kumar
>
> This patch adds IPC support for platforms. This patch enables IPC
> only for BXT platform as for SKL recommendation is to keep is
> disabled
From: "Pandiyan, Dhinakaran"
DP MST provides the capability to send multiple video and audio streams
through a single port. This requires the API's between i915 and audio
drivers to distinguish between multiple audio capable displays that can be
connected to a port. Currently only the port identi
== Series Details ==
Series: drm/i915/audio: audio cleanups, 4k fixes
URL : https://patchwork.freedesktop.org/series/12754/
State : warning
== Summary ==
Series 12754v1 drm/i915/audio: audio cleanups, 4k fixes
https://patchwork.freedesktop.org/api/1.0/series/12754/revisions/1/mbox/
Test kms_p
== Series Details ==
Series: drm/i915: Don't try to handle GuC when GuC is not supported.
URL : https://patchwork.freedesktop.org/series/12753/
State : success
== Summary ==
Series 12753v1 drm/i915: Don't try to handle GuC when GuC is not supported.
https://patchwork.freedesktop.org/api/1.0/se
On Mon, 12 Sep 2016, "Yang, Libin" wrote:
> Any comments?
Apologies for the way too long delay. I felt it would have been unfair
to ask you to do the changes I thought were necessary after such a
delay, so I sent them as patches... The last one still needs review, but
at least the mundane stuff i
From: Libin Yang
HDMI audio should use crtc_clock to get the TMDS clock.
This patch renames mode to adjusted_mode to unify the name.
Reviewed-by: Ville Syrjälä
Signed-off-by: Libin Yang
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_audio.c | 9 +
1 file changed, 5 insert
The code for dp and hdmi are already different, and they're about to
diverge even more. Split them for clarity in future work. No functional
changes.
Cc: Libin Yang
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_audio.c | 55 +++---
1 file changed, 34
From: Libin Yang
This patch applies setting proper N/M, N/CTS on more platforms.
Reviewed-by: Ville Syrjälä
Signed-off-by: Libin Yang
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_audio.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i91
If it was wrong, we'd be screwed already.
Cc: Libin Yang
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_audio.c | 12 ++--
1 file changed, 2 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_audio.c
b/drivers/gpu/drm/i915/intel_audio.c
index 1af6812e595
It gets fragile to duplicate the code for updating HSW_AUD_CFG. The only
change should be that the hdmi pixel clock is also updated in
i915_audio_component_sync_audio_rate(), but it should not be any
different.
Cc: Libin Yang
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_audio.c | 2
We'll be getting a function and a table for dp parameters soon enough,
so rename the function and table for hdmi. No functional changes.
Cc: Libin Yang
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_audio.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff
From: Libin Yang
When modeset occurs and the LS_CLK is set to some
special values in DP mode, the N/M need to be set
manually if audio is playing. Otherwise the first
several seconds may be silent in audio playback.
The relationship of Maud and Naud is expressed in
the following equation:
Maud/N
Have generic macros in line with the rest of the register bit definition
macros instead of a dedicated function in intel_audio.c, and use them.
No functional changes.
Cc: Libin Yang
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_reg.h| 4
drivers/gpu/drm/i915/intel_audio.c |
I started to review Libin's series at [1], but decided that
intel_audio.c is badly in need of some cleanup before moving forward
with the patches. I think the prep work makes Libin's patches cleaner
too. I ended up rebasing the patches myself, but it was a rather quick
job, with no testing, so plea
Prepare for using the same code for updating HSW_AUD_CFG register. No
functional changes.
Cc: Libin Yang
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_audio.c | 68 ++
1 file changed, 40 insertions(+), 28 deletions(-)
diff --git a/drivers/gpu/drm
Hi
Em Sex, 2016-09-09 às 13:31 +0530, Kumar, Mahesh escreveu:
> From: Mahesh Kumar
First of all, good catch with this patch!
>
> This patch changes Watermak calculation to fixed point calculation.
> Problem with current calculation is during plane_blocks_per_line
> calculation we divide interm
Avoid any kind of GuC handling if GuC is not supported
on a giving platform.
Besides being useless handling, our driver needs
to be smarter than the user trying to use an invalid paramenter.
Cc: Jani Nikula
Cc: Anusha Srivatsa
Cc: Christophe Prigent
Bugzilla: https://bugs.freedesktop.org/show_
== Series Details ==
Series: series starting with [CI,1/3] drm/i915: Restore current RPS state after
reset
URL : https://patchwork.freedesktop.org/series/12741/
State : failure
== Summary ==
Series 12741v1 Series without cover letter
https://patchwork.freedesktop.org/api/1.0/series/12741/revi
Hi,
On 9/20/2016 1:55 PM, Ville Syrjälä wrote:
On Tue, Aug 30, 2016 at 10:30:54AM +0530, Nabendu Maiti wrote:
Following patch series add pipe scaler functionality in atomic path.The pipe
scaler can be changed dynamically without modeset.Apart from default panel
fitter supported scaling modes -
Em Qua, 2016-09-21 às 19:18 +0530, Mahesh Kumar escreveu:
> there are two main reason I want to pass complete pipe_wm to compute
> function
>
> 1. for transition WM calculation, else we need to pass
> trans_wm.plane_res_b & trans_wm.plane_res_l also as a parameter,
>
> that will increase
Following commit 821ed7df6e2a ("drm/i915: Update reset path to fix
incomplete requests") we no longer mark the context as lost on reset as
we keep the requests (and contexts) alive. However, RPS remains reset
and we need to restore the current state to match the in-flight
requests.
Signed-off-by:
There is a disparity in the context image saved to disk and our own
bookkeeping - that is we presume the RING_HEAD and RING_TAIL match our
stored ce->ring->tail value. However, as we emit WA_TAIL_DWORDS into the
ring but may not tell the GPU about them, the GPU may be lagging behind
our bookkeeping
At the point of creating the hibernation image, the runtime power manage
core is disabled - and using the rpm functions triggers a warn.
i915_gem_shrink_all() tries to unbind objects, which requires device
access and so tries to how an rpm reference triggering a warning:
[ 44.235420] ---
On ti, 2016-09-20 at 12:24 +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: Queue page flip work with high priority (rev3)
> URL : https://patchwork.freedesktop.org/series/12336/
> State : warning
>
> == Summary ==
>
> Series 12336v3 drm/i915: Queue page flip work with high
there are two main reason I want to pass complete pipe_wm to compute
function
1. for transition WM calculation, else we need to pass
trans_wm.plane_res_b & trans_wm.plane_res_l also as a parameter,
that will increase the parameter-list. And trans_wm will be used
(calculation will happen
Hi Maarten,
thanks for pointing out the issue,
not only start value, end value is also incorrect. I got the root-cause
for both.
but this end value issue seems to be always there. end value should be
-1 (because start block should also be counted)
Will fix both & upload the reworked patches.
On ti, 2016-09-20 at 14:23 +, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [v2,RESEND,1/2] drm/i915: Cleanup
> instdone collection
> URL : https://patchwork.freedesktop.org/series/12714/
> State : warning
>
> == Summary ==
>
> Series 12714v1 Series without cover
On ti, 2016-09-20 at 09:29 +0100, Chris Wilson wrote:
> Add lockdep_assert_held(struct_mutex) to the API preamble of the
> internal GEM interfaces.
>
Heck yeah!
Reviewed-by: Joonas Lahtinen
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
On ti, 2016-09-20 at 09:29 +0100, Chris Wilson wrote:
> Quite a few of our objects used for internal hardware programming do not
> benefit from being swappable or from being zero initialised. As such
> they do not benefit from using a shmemfs backing storage and since they
> are internal and never
I've raised https://bugs.freedesktop.org/show_bug.cgi?id=97888 I'll
attach the info you requested once I get back to my machine
On 21 September 2016 at 07:56, Maarten Lankhorst
wrote:
> Hey,
>
> Op 20-09-16 om 20:45 schreef Mike Lothian:
>> Hi
>>
>> I've bisected back to this commit in the drm-in
On Mon, Sep 19, 2016 at 03:40:48PM -0700, Dhinakaran Pandiyan wrote:
> Corrected typo in bridge and encoder comparison. Also, added a one-line
> encoder description from the previous documentation.
>
> Cc: Daniel Vetter
> Cc: Archit Taneja
>
> Signed-off-by: Dhinakaran Pandiyan
Thanks for spo
Kerneldoc could help with getting grip of the convention introduced
here.
Does this really have visible results in real world workloads? It adds
further complexity.
On ti, 2016-09-20 at 09:29 +0100, Chris Wilson wrote:
> @@ -2383,6 +2390,28 @@ i915_gem_object_has_active_engine(const struct
> drm
On ti, 2016-09-20 at 09:29 +0100, Chris Wilson wrote:
> Our low-level wait routine has evolved from our generic wait interface
> that handled unlocked, RPS boosting, waits with time tracking. If we
> push our GEM fence tracking to use reservation_objects (required for
> handling multiple timelines)
On ti, 2016-09-20 at 09:29 +0100, Chris Wilson wrote:
> + if (!fence_is_array(fence)) {
> + ret = i915_sw_fence_await_dma_fence(&req->submit,
> + fence, 10*HZ,
#define I915_MAX_USERSPACE_WAIT or something. We already have two
instance
On ti, 2016-09-20 at 09:29 +0100, Chris Wilson wrote:
> @@ -175,6 +176,110 @@ static void i915_error_puts(struct
> drm_i915_error_state_buf *e,
> #define err_printf(e, ...) i915_error_printf(e, __VA_ARGS__)
> #define err_puts(e, s) i915_error_puts(e, s)
>
> +#ifdef CONFIG_DRM_I915_COMPRESS_ERR
On Mon, Sep 19, 2016 at 4:11 PM, Daniel Vetter wrote:
> On Tue, Sep 06, 2016 at 12:59:31PM -0400, Sean Paul wrote:
>> On Wed, Aug 31, 2016 at 12:09 PM, Daniel Vetter
>> wrote:
>> > Just pure code movement, cleanup and polish will happen in later
>> > patches.
>> >
>> > v2: Don't forget all the i
On Tue, Sep 20, 2016 at 11:29 AM, Chris Wilson wrote:
> drm_atomic_state has a complicated single owner model that tracks the
> single reference from allocation through to destruction on another
> thread - or perhaps on a local error path. We can simplify this tracking
> by using reference countin
On ti, 2016-09-20 at 09:29 +0100, Chris Wilson wrote:
> + /* Reserve a mappable slot for our lockless error capture */
> + ret = drm_mm_insert_node_in_range_generic(&ggtt->base.mm,
> + &ggtt->gpu_error,
'error_page' would arguably be better na
Will do.
On Wed, 21 Sep 2016 at 07:56 Maarten Lankhorst <
maarten.lankho...@linux.intel.com> wrote:
> Hey,
>
> Op 20-09-16 om 20:45 schreef Mike Lothian:
> > Hi
> >
> > I've bisected back to this commit in the drm-intel-nightly branch
> >
> > 05a76d3d6ad1ee9f9814f88949cc9305fc165460 is the first
43 matches
Mail list logo
