Re: [Intel-gfx] [PATCH 0/2] drm/i915/opregion: proper handling of DIDL and CADL

2016-08-27 Thread Peter Wu
Hi Jani, The method is somehow not reliable. At boot I was still able to capture brightness hotkeys (via acpi_listen). After starting SSDM and logging in, it still worked. Then I played a bit with PRIME output slaves, Xorg crashed at some points and hotkeys stopped working. Inspection of CADL (vi

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: add lane_count check in intel_dp_check_link_status

2016-08-27 Thread Patchwork
== Series Details == Series: drm/i915/dp: add lane_count check in intel_dp_check_link_status URL : https://patchwork.freedesktop.org/series/11667/ State : failure == Summary == Series 11667v1 drm/i915/dp: add lane_count check in intel_dp_check_link_status http://patchwork.freedesktop.org/api/1

[Intel-gfx] [PATCH] drm/i915/dp: add lane_count check in intel_dp_check_link_status

2016-08-27 Thread Matthew Auld
Currently it's entirely possible to go through the link training step without first determining the lane_count, which is silly since we end up doing a bunch of aux transfers of size = 0, as highlighted by WARN_ON(!msg->buffer != !msg->size), and can only ever result in a 'failed to update link trai

Re: [Intel-gfx] Display problems after upgrade to X v1.18.3

2016-08-27 Thread Jim Abernathy
On 08/23/2016 03:20 PM, Jim Abernathy wrote: On 08/23/2016 03:06 PM, Jim Abernathy wrote: On 08/23/2016 01:10 PM, David Weinehall wrote: On Tue, Aug 23, 2016 at 11:40:53AM -0400, Jim Abernathy wrote: Not having much luck with the Distro forums on this issue so I thought I'd ask for advice

Re: [Intel-gfx] [PATCH 07/17] drm/i915: Use the precomputed value for whether to enable command parsing

2016-08-27 Thread Chris Wilson
On Wed, Aug 24, 2016 at 03:33:30PM +0100, John Harrison wrote: > On 22/08/2016 09:03, Chris Wilson wrote: > >As i915.enable_cmd_parser is an unsafe option, make it read-only at > >runtime. Now that it is constant, we can use the value determined during > >initialisation as to whether we need the cm

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [CI,1/2] drm/i915: Tidy reporting busy status during i915_gem_retire_requests()

2016-08-27 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915: Tidy reporting busy status during i915_gem_retire_requests() URL : https://patchwork.freedesktop.org/series/11664/ State : warning == Summary == Series 11664v1 Series without cover letter http://patchwork.freedesktop.org/api

[Intel-gfx] [CI 2/2] drm/i915: Make for_each_engine_masked() more compact and quicker

2016-08-27 Thread Chris Wilson
Rather than walk the full array of engines checking whether each is in the mask in turn, we can use the mask to jump to the right engines. This should quicker for a sparse array of engines or mask, whilst generating smaller code: textdata bss dec hex filename 12510104579

[Intel-gfx] [CI 1/2] drm/i915: Tidy reporting busy status during i915_gem_retire_requests()

2016-08-27 Thread Chris Wilson
As we know by inspection whether any engine is still busy as we retire all the requests, we can pass that information back via return value rather than check again afterwards. v2: A little more polish missed in patch splitting Signed-off-by: Chris Wilson Cc: Mika Kuoppala Reviewed-by: Joonas La