[Intel-gfx] ✓ Ro.CI.BAT: success for drm/i915: tidy up request alloc

2016-06-29 Thread Patchwork
== Series Details == Series: drm/i915: tidy up request alloc URL : https://patchwork.freedesktop.org/series/9300/ State : success == Summary == Series 9300v1 drm/i915: tidy up request alloc http://patchwork.freedesktop.org/api/1.0/series/9300/revisions/1/mbox Test kms_pipe_crc_basic:

[Intel-gfx] ✗ Ro.CI.BAT: warning for series starting with [01/13] drm/i915: Consolidate write_tail vfunc initializer (rev2)

2016-06-29 Thread Patchwork
== Series Details == Series: series starting with [01/13] drm/i915: Consolidate write_tail vfunc initializer (rev2) URL : https://patchwork.freedesktop.org/series/9279/ State : warning == Summary == Series 9279v2 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/9279

[Intel-gfx] [PATCH] drm/i915: tidy up request alloc

2016-06-29 Thread Hong Liu
Return the allocated request pointer directly to remove the double pointer parameter. Signed-off-by: Hong Liu --- drivers/gpu/drm/i915/i915_gem.c | 25 +++-- 1 file changed, 7 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/

Re: [Intel-gfx] [PACTH i-g-t v1] lib/igt_gt: Fix unused variable warning for non-x86 targets

2016-06-29 Thread Chris Wilson
On Mon, Jun 27, 2016 at 06:58:24AM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > Moved variable declaration inside #if case to avoid unused variable warnings > on non-x86 targets. > > Signed-off-by: Robert Foss Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open So

Re: [Intel-gfx] [RFC] i915: Add fence fds to execbuffer2 uapi

2016-06-29 Thread Chad Versace
On Tue 28 Jun 2016, John Harrison wrote: > The latest set of patches (including changes from feedback about rsvd > fields) never actually got posted to the mailing list due to the above issue > with de-staging. I have just updated my FDO git account with them instead. > The kernel patch is: > http

Re: [Intel-gfx] [RFC] i915: Add fence fds to execbuffer2 uapi

2016-06-29 Thread Chad Versace
On Mon 27 Jun 2016, Chris Wilson wrote: > On Mon, Jun 27, 2016 at 01:18:59PM -0700, Chad Versace wrote: > > On Mon 27 Jun 2016, Chad Versace wrote: > > > Let the hight 32 bits of drm_i915_gem_execbuffer2::rsvd1 contain an > > > input and/or output fence fd, whose presence is controlled by flags. >

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

2016-06-29 Thread Rodrigo Vivi
But the merge on hug/guc loading is just the minor thing Daniel asked. The major request is to stop using the fetch_status, but errnos instead. so, maybe one extra patch that simplifies this right now before this series would be the ideal so we could speed up the merge and maybe later to the unifi

[Intel-gfx] ✓ Ro.CI.BAT: success for series starting with [1/2] drm/i915: Fix log type for RC6 debug messages

2016-06-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Fix log type for RC6 debug messages URL : https://patchwork.freedesktop.org/series/9285/ State : success == Summary == Series 9285v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/9285/revisions/1/mb

Re: [Intel-gfx] [PATCH v4 0/2] drm/i915/opregion: proper handling of DIDL and CADL

2016-06-29 Thread Peter Wu
Hi Jani, I just tested your branch (2f9a317) and can confirm that the fix is still valid. evtest reports brightness up/down events. Kind regards, Peter https://lekensteyn.nl (pardon my brevity, top-posting and formatting, sent from my phone) On 29 June 2016 17:36:40 CEST, Jani Nikula wrote: >

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Consolidate legacy semaphore initialization

2016-06-29 Thread Chris Wilson
On Wed, Jun 29, 2016 at 05:34:27PM +0100, Tvrtko Ursulin wrote: > It also looks like I have broke something, wonder how CI did not > catch it or I am imagining things. "drm/i915: Consolidate > dispatch_execbuffer vfunc" looks wrong wrt add_request and > dispatch_execbuffer for gen8+. Leaving it for

[Intel-gfx] [PATCH v3] drm/i915: Consolidate dispatch_execbuffer vfunc

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin v2: Put dispatch_execbuffer before add_request. (Chris Wilson) v3: Fix add_request and irq_seqno_barrier for gen8+. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_ringbuffer.c | 27 --- 1 file changed, 8 insertions(+), 19 deletions(-)

[Intel-gfx] [PATCH v2 2/2] i915/guc: Add Kabylake GuC Loading

2016-06-29 Thread Peter Antoine
This patch added the loading of the GuC for Kabylake. It loads a 9.14 firmware. Signed-off-by: Peter Antoine Signed-off-by: Michel Thierry Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_guc_loader.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/intel

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Consolidate legacy semaphore initialization

2016-06-29 Thread Tvrtko Ursulin
On 29/06/16 17:24, Chris Wilson wrote: On Wed, Jun 29, 2016 at 05:14:11PM +0100, Tvrtko Ursulin wrote: On 29/06/16 17:00, Chris Wilson wrote: On Wed, Jun 29, 2016 at 04:41:58PM +0100, Tvrtko Ursulin wrote: On 29/06/16 16:34, Chris Wilson wrote: On Wed, Jun 29, 2016 at 04:09:31PM +0100, Tvr

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Consolidate legacy semaphore initialization

2016-06-29 Thread Chris Wilson
On Wed, Jun 29, 2016 at 05:14:11PM +0100, Tvrtko Ursulin wrote: > > On 29/06/16 17:00, Chris Wilson wrote: > >On Wed, Jun 29, 2016 at 04:41:58PM +0100, Tvrtko Ursulin wrote: > >> > >>On 29/06/16 16:34, Chris Wilson wrote: > >>>On Wed, Jun 29, 2016 at 04:09:31PM +0100, Tvrtko Ursulin wrote: > F

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915/opregion: proper handling of DIDL and CADL (rev4)

2016-06-29 Thread Patchwork
== Series Details == Series: drm/i915/opregion: proper handling of DIDL and CADL (rev4) URL : https://patchwork.freedesktop.org/series/4783/ State : failure == Summary == Series 4783v4 drm/i915/opregion: proper handling of DIDL and CADL http://patchwork.freedesktop.org/api/1.0/series/4783/revi

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Consolidate legacy semaphore initialization

2016-06-29 Thread Tvrtko Ursulin
On 29/06/16 17:00, Chris Wilson wrote: On Wed, Jun 29, 2016 at 04:41:58PM +0100, Tvrtko Ursulin wrote: On 29/06/16 16:34, Chris Wilson wrote: On Wed, Jun 29, 2016 at 04:09:31PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Replace per-engine initialization with a common half-programati

[Intel-gfx] [PATCH 2/2] drm/i915/bxt: Fix sanity check for BIOS RC6 setup

2016-06-29 Thread Imre Deak
BXT BIOS has two options related to GPU power management: "RC6(Render Standby)" and "GT PM Support". The assumption so far was that disabling either of these options would leave RC6 uninitialized. According to my tests this isn't so: for a proper RC6 setup we only need the "GT PM Support" option to

[Intel-gfx] [PATCH 1/2] drm/i915: Fix log type for RC6 debug messages

2016-06-29 Thread Imre Deak
RC6 isn't really a KMS feature, so use the more proper DRIVER log type for RC6 related debug messages. CC: Sagar Arun Kamble Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_pm.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/

Re: [Intel-gfx] [PATCH 2/2] i915/guc: Add Kabylake GuC Loading

2016-06-29 Thread Peter Antoine
Thanks. Rodrigo will sin a new patch now. Peter. On Wed, 29 Jun 2016, Rodrigo Vivi wrote: With the commit message updated feel free to use Reviewed-by: Rodrigo Vivi On Fri, Jun 3, 2016 at 2:14 AM, Antoine, Peter wrote: I'll remove the comment. :) -Original Message- From: Thierry,

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Removing PCI IDs that are no longer listed as Kabylake.

2016-06-29 Thread Vivi, Rodrigo
On Wed, 2016-06-29 at 12:24 +0300, Jani Nikula wrote: > On Fri, 24 Jun 2016, Rodrigo Vivi wrote: > > > > This is unusual. Usually IDs listed on early stages of platform > > definition are kept there as reserved for later use. > > > > However these IDs here are not listed anymore in any of steppi

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: Remove request->reset_counter

2016-06-29 Thread Chris Wilson
On Wed, Jun 29, 2016 at 03:45:27PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Remove request->reset_counter > URL : https://patchwork.freedesktop.org/series/9278/ > State : failure > > == Summary == > > Series 9278v1 drm/i915: Remove request->reset_counter > http://pa

[Intel-gfx] ✗ Ro.CI.BAT: failure for series starting with [01/13] drm/i915: Consolidate write_tail vfunc initializer

2016-06-29 Thread Patchwork
== Series Details == Series: series starting with [01/13] drm/i915: Consolidate write_tail vfunc initializer URL : https://patchwork.freedesktop.org/series/9279/ State : failure == Summary == Series 9279v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/9279/revisi

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Consolidate legacy semaphore initialization

2016-06-29 Thread Chris Wilson
On Wed, Jun 29, 2016 at 04:41:58PM +0100, Tvrtko Ursulin wrote: > > On 29/06/16 16:34, Chris Wilson wrote: > >On Wed, Jun 29, 2016 at 04:09:31PM +0100, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>Replace per-engine initialization with a common half-programatic, > >>half-data driven co

Re: [Intel-gfx] [PATCH 2/2] i915/guc: Add Kabylake GuC Loading

2016-06-29 Thread Rodrigo Vivi
With the commit message updated feel free to use Reviewed-by: Rodrigo Vivi On Fri, Jun 3, 2016 at 2:14 AM, Antoine, Peter wrote: > I'll remove the comment. :) > > -Original Message- > From: Thierry, Michel > Sent: Friday, June 3, 2016 9:44 AM > To: Antoine, Peter ; intel-gfx@lists.freede

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915/kbl: drm/i915: Avoid GuC loading for now on Kabylake."

2016-06-29 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Thu, Jun 2, 2016 at 10:01 AM, Peter Antoine wrote: > This reverts commit 2b81b84471b9 > > Signed-off-by: Peter Antoine > --- > drivers/gpu/drm/i915/i915_drv.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h b

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: Remove request->reset_counter

2016-06-29 Thread Patchwork
== Series Details == Series: drm/i915: Remove request->reset_counter URL : https://patchwork.freedesktop.org/series/9278/ State : failure == Summary == Series 9278v1 drm/i915: Remove request->reset_counter http://patchwork.freedesktop.org/api/1.0/series/9278/revisions/1/mbox Test gem_exec_flu

[Intel-gfx] [PATCH v4 1/2] drm/i915: make i915 the source of acpi device ids for _DOD

2016-06-29 Thread Jani Nikula
The graphics driver is supposed to define the DIDL, which are used for _DOD, not the BIOS. Restore that behaviour. This is basically a revert of commit 3143751ff51a163b77f7efd389043e038f3e008e Author: Zhang Rui Date: Mon Mar 29 15:12:16 2010 +0800 drm/i915: set DIDL using the ACPI video o

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Consolidate legacy semaphore initialization

2016-06-29 Thread Tvrtko Ursulin
On 29/06/16 16:34, Chris Wilson wrote: On Wed, Jun 29, 2016 at 04:09:31PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Replace per-engine initialization with a common half-programatic, half-data driven code for ease of maintenance and compactness. Signed-off-by: Tvrtko Ursulin This i

Re: [Intel-gfx] Brightness and "touchpad dis-/enable" keys not working for Fujitsu e7x6

2016-06-29 Thread Jani Nikula
On Wed, 29 Jun 2016, Jani Nikula wrote: > On Mon, 27 Jun 2016, Jan-Marek Glogowski wrote: >> Am 25.06.2016 um 11:15 schrieb Michał Kępień: > ...though if you think about it, the whole thing is absolutely hideous: > an *ACPI* driver requires cooperation from a *video* driver to notify

[Intel-gfx] [PATCH v4 0/2] drm/i915/opregion: proper handling of DIDL and CADL

2016-06-29 Thread Jani Nikula
This is v4 of [1]. The first three have already been pushed to drm-intel-next-queued. The only change here is the atomic commit. Review and testing would be much appreciated to move this forward. For testing, I've pushed this to opregion-didl-v4 branch of my repo at [2]. Maarten, please check the

[Intel-gfx] [PATCH v4 2/2] drm/i915/opregion: update cadl based on actually active outputs

2016-06-29 Thread Jani Nikula
Previously we've just shoved the first eight devices in DIDL to CADL (list of active outputs). Some of the active outputs may have been left outside of CADL. The problem is, some BIOS implementations prevent laptop brightness hotkey propagation if the flat panel is not active. Now that we have con

Re: [Intel-gfx] [PATCH 13/13] drm/i915: Trim some if-else braces

2016-06-29 Thread Chris Wilson
On Wed, Jun 29, 2016 at 04:09:32PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Just a bit of cleanup after the previous refactoring. > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson And for any earlier patches I may have skipped. -Chris -- Chris Wilson, Intel Open So

Re: [Intel-gfx] [PATCH 12/13] drm/i915: Consolidate legacy semaphore initialization

2016-06-29 Thread Chris Wilson
On Wed, Jun 29, 2016 at 04:09:31PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Replace per-engine initialization with a common half-programatic, > half-data driven code for ease of maintenance and compactness. > > Signed-off-by: Tvrtko Ursulin This is the biggest pill to swallow (s

Re: [Intel-gfx] [PATCH 11/13] drm/i915: Compact gen8_ring_sync

2016-06-29 Thread Chris Wilson
On Wed, Jun 29, 2016 at 04:09:30PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Store the semaphore offset in a temporary variable to avoid > having to get the VMA offset twice. > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson The lookup will be gone very soon, and inte

Re: [Intel-gfx] [PATCH 10/13] drm/i915: Compact Gen8 semaphore initialization

2016-06-29 Thread Chris Wilson
On Wed, Jun 29, 2016 at 04:09:29PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Replace the macro initializer with a programatic loop which > results in smaller code and hopefully just as clear. > > v2: Rebase. > > Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson We could

Re: [Intel-gfx] [PATCH 09/13] drm/i915: Move semaphore object creation into intel_ring_init_semaphores

2016-06-29 Thread Chris Wilson
On Wed, Jun 29, 2016 at 04:09:28PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > The object needs to be created before semaphores can be initialized > on any ring and it makes sense to pull it out to this semaphore > dedicated helper. > > Signed-off-by: Tvrtko Ursulin > --- > drivers

[Intel-gfx] [PATCH 13/13] drm/i915: Trim some if-else braces

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Just a bit of cleanup after the previous refactoring. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_ringbuffer.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i9

[Intel-gfx] [PATCH 09/13] drm/i915: Move semaphore object creation into intel_ring_init_semaphores

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin The object needs to be created before semaphores can be initialized on any ring and it makes sense to pull it out to this semaphore dedicated helper. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_ringbuffer.c | 45 ++--- 1 file ch

[Intel-gfx] [PATCH 05/13] drm/i915: Consolidate get/set_seqno

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c in

[Intel-gfx] [PATCH 02/13] drm/i915: Consolidate add_request vfunc

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin All engines apart from render select this based on Gen. Move it to the common helper as well. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --gi

[Intel-gfx] [PATCH 11/13] drm/i915: Compact gen8_ring_sync

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Store the semaphore offset in a temporary variable to avoid having to get the VMA offset twice. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_ringbuffer.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_r

[Intel-gfx] [PATCH 03/13] drm/i915: Consolidate seqno_barrier vfunc

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index d82e

[Intel-gfx] [PATCH 12/13] drm/i915: Consolidate legacy semaphore initialization

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Replace per-engine initialization with a common half-programatic, half-data driven code for ease of maintenance and compactness. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_ringbuffer.c | 110 ++-- 1 file changed, 48 insertions(

[Intel-gfx] [PATCH 01/13] drm/i915: Consolidate write_tail vfunc initializer

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Introduce a function which initializes vfuncs mostly common across engines and move write_tail initialization in it since only one engine overrides the default. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 27 ++

Re: [Intel-gfx] [PATCH] drm/i915: Remove request->reset_counter

2016-06-29 Thread Arun Siluvery
On 29/06/2016 15:51, Chris Wilson wrote: Since commit 2ed53a94d8cb ("drm/i915: On GPU reset, set the HWS breadcrumb to the last seqno") once a hang is completed, the seqno is advanced past all current requests. With this we know that if we wake up on waiting for a request, if a hang has occurred

[Intel-gfx] [PATCH 07/13] drm/i915: Consolidate dispatch_execbuffer vfunc

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin v2: Put dispatch_execbuffer before add_request. (Chris Wilson) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 25 ++--- 1 file changed, 6 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/dr

[Intel-gfx] [PATCH 10/13] drm/i915: Compact Gen8 semaphore initialization

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Replace the macro initializer with a programatic loop which results in smaller code and hopefully just as clear. v2: Rebase. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_ringbuffer.c | 16 ++-- drivers/gpu/drm/i915/intel_ringbuffer.h | 12 -

[Intel-gfx] [PATCH 04/13] drm/i915: Consolidate get and put irq vfuncs

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin v2: Consistent INTEL_GEN vs IS_GEN usage. (Chris Wilson) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 46 - 1 file changed, 17 insertions(+), 29 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 08/13] drm/i915: Consolidate semaphore vfuncs init

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_ringbuffer.c | 48 + 1 file changed, 18 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index a961b09

[Intel-gfx] [PATCH 06/13] drm/i915: Consolidate init_hw vfunc

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/intel_ringbuffer.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index e0e90b99bbca

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for series starting with [1/2] drm/i915/debug: Select PREEMPT_COUNT when enabling debugging (rev5)

2016-06-29 Thread Tvrtko Ursulin
On 29/06/16 12:50, Patchwork wrote: == Series Details == Series: series starting with [1/2] drm/i915/debug: Select PREEMPT_COUNT when enabling debugging (rev5) URL : https://patchwork.freedesktop.org/series/9226/ State : failure == Summary == Series 9226v5 Series without cover letter http:

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/opregion: handle missing connector types for acpi display types

2016-06-29 Thread Jani Nikula
On Mon, 13 Jun 2016, Jani Nikula wrote: > Most notably eDP, DSI, and TV. Add MISSING_CASE handling so we won't > miss this in the future. > > Reviewed-and-tested-by: Peter Wu > Signed-off-by: Jani Nikula Pushed up to and including this patch to drm-intel-next-queued, as they're fairly benign ch

[Intel-gfx] [PATCH] drm/i915: Remove request->reset_counter

2016-06-29 Thread Chris Wilson
Since commit 2ed53a94d8cb ("drm/i915: On GPU reset, set the HWS breadcrumb to the last seqno") once a hang is completed, the seqno is advanced past all current requests. With this we know that if we wake up on waiting for a request, if a hang has occurred and reset completed, our request will be co

Re: [Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

2016-06-29 Thread Dave Gordon
On 29/06/16 00:03, Rodrigo Vivi wrote: I don't believe we need to be that extreme here. Daniel asked a cleaner version, but we don't need to block the huc on a full rework of an unified fw loader. Oh, I agree, we should take this "mostly" as-is and then reunify them after. .Dave. ___

Re: [Intel-gfx] Brightness and "touchpad dis-/enable" keys not working for Fujitsu e7x6

2016-06-29 Thread Jani Nikula
On Mon, 27 Jun 2016, Jan-Marek Glogowski wrote: > Am 25.06.2016 um 11:15 schrieb Michał Kępień: ...though if you think about it, the whole thing is absolutely hideous: an *ACPI* driver requires cooperation from a *video* driver to notify the operating system about a *key press*. >>>

[Intel-gfx] ✓ Ro.CI.BAT: success for series starting with [1/2] Revert "drm/i915: Workaround CHV pipe C cursor fail" (rev3)

2016-06-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] Revert "drm/i915: Workaround CHV pipe C cursor fail" (rev3) URL : https://patchwork.freedesktop.org/series/8431/ State : success == Summary == Series 8431v3 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/8431

Re: [Intel-gfx] [RFC v2] drm/i915/chv: Clip cursor for CHV pipe C HW Cursor pos < 0

2016-06-29 Thread Shobhit Kumar
On 06/29/2016 06:24 PM, Shobhit Kumar wrote: From: Shobhit Kumar CHV pipe C hits underrun when we get negative crtc_x values of cursor. To avoid this we clip and shift the cursor image by negative crtc_x value. v2: Make a copy of cursor plane state and allocate new gem object and fb for cl

[Intel-gfx] [RFC v2] drm/i915/chv: Clip cursor for CHV pipe C HW Cursor pos < 0

2016-06-29 Thread Shobhit Kumar
From: Shobhit Kumar CHV pipe C hits underrun when we get negative crtc_x values of cursor. To avoid this we clip and shift the cursor image by negative crtc_x value. v2: Make a copy of cursor plane state and allocate new gem object and fb for clipped cursor and use that in case of negative c

[Intel-gfx] ✗ Ro.CI.BAT: failure for series starting with [1/2] drm/i915/debug: Select PREEMPT_COUNT when enabling debugging (rev5)

2016-06-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/debug: Select PREEMPT_COUNT when enabling debugging (rev5) URL : https://patchwork.freedesktop.org/series/9226/ State : failure == Summary == Series 9226v5 Series without cover letter http://patchwork.freedesktop.org/api/1.0/ser

[Intel-gfx] [PATCH igt 15/17] intel_chipset: Convert IS_G4X to device info

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index 9806f2f..e3e97ff 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -269,13 +269,6 @@ void intel_ch

[Intel-gfx] [PATCH igt 08/17] intel_chipset: Convert IS_BROADWELL to device info

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index c4f64dc..b56457a 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -376,15 +376,6 @@ void intel_check_pch(v

[Intel-gfx] [PATCH igt 12/17] intel_chipset: Convert IS_IRONLAKE to device info

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index f516d8e..4f532a9 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -280,9 +280,6 @@ void intel_check_pch(void);

[Intel-gfx] [PATCH igt 13/17] intel_chipset: Convert IS_PINEVIEW to device info

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 12 tools/intel_reg_decode.c | 4 ++-- tools/intel_watermark.c | 2 +- 3 files changed, 7 insertions(+), 11 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index 4f532a9..a40a857 100644 --- a/lib/intel

[Intel-gfx] [PATCH igt 17/17] intel_chipset: Remove unused PCI_CHIP ids

2016-06-29 Thread Chris Wilson
These are now taken from i915_pciids.h. However, some of the older ids are still used explicitly for per-devid information, and so are not yet removable. Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 150 1 file changed, 150 deletions(

[Intel-gfx] [PATCH igt 03/17] intel_chipset: Convert IS_965 to use intel_gen()

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index ce130ed..8f159ea 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -453,13 +453,6 @@ void intel_check_pch(void

[Intel-gfx] [PATCH igt 05/17] intel_chipset: Convert IS_BROXTON to device info

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index 6f7f26d..37f8ed0 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -447,11 +447,7 @@ void intel_check_pch(void);

[Intel-gfx] [PATCH igt 14/17] intel_chipset: Convert IS_915, IS_945 to device info

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index a40a857..9806f2f 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -276,18 +276,6 @@ void

[Intel-gfx] [PATCH igt 04/17] intel_chipset: Convert IS_BROADWATER, IS_CRESTLINE to device info

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index 8f159ea..6f7f26d 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -453,13 +453,8 @@ void intel_check_pch(vo

[Intel-gfx] [PATCH igt 07/17] intel_chipset: Convert IS_CHERRYVIEW to device info

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index 146c650..c4f64dc 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -385,11 +385,6 @@ void intel_check_p

[Intel-gfx] [PATCH igt 11/17] intel_chipset: Convert IS_IRONALKE to device info

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index 1c167f0..f516d8e 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -299,13 +299,6 @@ void intel_check_pch(void

[Intel-gfx] [PATCH igt 10/17] intel_chipset: Convert IS_VALLEYVIEW to device info

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index 162216e..1c167f0 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -306,11 +306,6 @@ void intel_check_pch(void);

[Intel-gfx] [PATCH igt 06/17] intel_chipset: Convert IS_SKYLAKE to device info

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index 37f8ed0..146c650 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -442,11 +442,7 @@ void intel_check_pch(void);

[Intel-gfx] [PATCH igt 09/17] intel_chipset: Convert IS_HASWELL to device info

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index b56457a..162216e 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -372,10 +372,6 @@ void intel_check_pch(void);

[Intel-gfx] [PATCH igt 01/17] lib: Start weaning off defunct intel_chipset.h

2016-06-29 Thread Chris Wilson
Several years ago we made the plan of only having one canonical source for i915_pciids.h, the kernel and everyone importing their definitions from that. For consistency, we style the intel_device_info after the kernel, most notably using a generation mask and a per-codename bitfield. This first st

[Intel-gfx] [PATCH igt 16/17] intel_chipset: Replace lookup of GT size with computation

2016-06-29 Thread Chris Wilson
Instead of a large if-chain for matching devid to GT, we can just compute it directly from the encoded devid. Signed-off-by: Chris Wilson --- debugger/eudb.c | 14 +++--- lib/intel_chipset.h | 109 +- lib/intel_device_info.c | 23 ++

[Intel-gfx] [PATCH igt 02/17] intel_chipset: Convert IS_MOBILE to intel_device_info

2016-06-29 Thread Chris Wilson
Signed-off-by: Chris Wilson --- lib/intel_chipset.h | 12 ++-- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h index 69c878b..ce130ed 100644 --- a/lib/intel_chipset.h +++ b/lib/intel_chipset.h @@ -273,16 +273,6 @@ void intel_check_p

Re: [Intel-gfx] [PATCH v5] drm/i915: Use atomic waits for short non-atomic ones

2016-06-29 Thread Chris Wilson
On Wed, Jun 29, 2016 at 12:27:22PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > usleep_range is not recommended for waits shorten than 10us. > > Make the wait_for_us use the atomic variant for such waits. > > To do so we need to reimplement the _wait_for_atomic macro to > be safe wit

[Intel-gfx] [PATCH v5] drm/i915: Use atomic waits for short non-atomic ones

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin usleep_range is not recommended for waits shorten than 10us. Make the wait_for_us use the atomic variant for such waits. To do so we need to reimplement the _wait_for_atomic macro to be safe with regards to preemption and interrupts. v2: Reimplement _wait_for_atomic to be

[Intel-gfx] [PACTH i-g-t] lib/igt_kms: Fix different order of properties and their name strings

2016-06-29 Thread robert . foss
From: Robert Foss igt_crtc_prop_names and igt_atomic_crtc_properties have different orders of properties, which is fixed in this patch. Signed-off-by: Robert Foss --- lib/igt_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index af72b90..

Re: [Intel-gfx] [PACTH i-g-t v4 00/13] Remove compile time depencencies on libdrm_intel.

2016-06-29 Thread Emil Velikov
On 23 June 2016 at 10:34, wrote: > From: Robert Foss > > > Hey, > > I've been looking at the possibilty of removing the compile time depency on > libdrm_intel. There are two technical solutions to this problem as far as > I can see; stubs and conditional compilation. > > This series uses the stu

[Intel-gfx] ✗ Ro.CI.BAT: failure for series starting with [1/2] drm/i915/debug: Select PREEMPT_COUNT when enabling debugging (rev4)

2016-06-29 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/debug: Select PREEMPT_COUNT when enabling debugging (rev4) URL : https://patchwork.freedesktop.org/series/9226/ State : failure == Summary == Series 9226v4 Series without cover letter http://patchwork.freedesktop.org/api/1.0/ser

[Intel-gfx] [PATCH i-g-t 2/3] tools/intel_reg: try to find broxton register spec by codename

2016-06-29 Thread Jani Nikula
Signed-off-by: Jani Nikula --- tools/intel_reg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/intel_reg.c b/tools/intel_reg.c index 92be1ce7719f..46745b6efc64 100644 --- a/tools/intel_reg.c +++ b/tools/intel_reg.c @@ -671,6 +671,8 @@ static const char *get_codename(uint32_t devid)

[Intel-gfx] [PATCH i-g-t 3/3] tools/intel_reg: add initial reg spec for broxton

2016-06-29 Thread Jani Nikula
Mostly just copy SKL, which is probably partly bogus for BXT, but better than nothing. Add the defs for BXT DSI, but don't dump them by default because reading them without proper power well and/or DSI PLL may hang the machine. Signed-off-by: Jani Nikula --- tools/registers/broxton | 6 +++

[Intel-gfx] [PATCH i-g-t 1/3] tools/intel_reg: add kabylake register spec file

2016-06-29 Thread Jani Nikula
Just do whatever skylake does. Signed-off-by: Jani Nikula --- tools/registers/kabylake | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 tools/registers/kabylake diff --git a/tools/registers/kabylake b/tools/registers/kabylake new file mode 100644 index ..ac923295a8b2 ---

[Intel-gfx] [PATCH v4] drm/i915: Use atomic waits for short non-atomic ones

2016-06-29 Thread Tvrtko Ursulin
From: Tvrtko Ursulin usleep_range is not recommended for waits shorten than 10us. Make the wait_for_us use the atomic variant for such waits. To do so we need to reimplement the _wait_for_atomic macro to be safe with regards to preemption and interrupts. v2: Reimplement _wait_for_atomic to be

Re: [Intel-gfx] [RFC] drm/i915: hybrid wait-for macro

2016-06-29 Thread Tvrtko Ursulin
On 28/06/16 17:56, Dave Gordon wrote: Part spin-wait, part sleep-wait. Plus one example of where it might be used. Signed-off-by: Dave Gordon --- drivers/gpu/drm/i915/i915_guc_submission.c | 2 +- drivers/gpu/drm/i915/intel_drv.h | 10 ++ 2 files changed, 11 insertions(+

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Removing PCI IDs that are no longer listed as Kabylake.

2016-06-29 Thread Jani Nikula
On Fri, 24 Jun 2016, Rodrigo Vivi wrote: > This is unusual. Usually IDs listed on early stages of platform > definition are kept there as reserved for later use. > > However these IDs here are not listed anymore in any of steppings > and devices IDs tables for Kabylake on configurations overview >

Re: [Intel-gfx] ✓ Ro.CI.BAT: success for series starting with [1/2] drm/i915/debug: Select PREEMPT_COUNT when enabling debugging (rev3)

2016-06-29 Thread Tvrtko Ursulin
On 28/06/16 20:59, Chris Wilson wrote: On Tue, Jun 28, 2016 at 05:03:20PM -, Patchwork wrote: == Series Details == Series: series starting with [1/2] drm/i915/debug: Select PREEMPT_COUNT when enabling debugging (rev3) URL : https://patchwork.freedesktop.org/series/9226/ State : success