Re: [Intel-gfx] [PATCH 19/38] drm/hisilicon: Implement some semblance of vblank event handling

On 21 June 2016 at 15:19, Daniel Vetter wrote: > On Tue, Jun 21, 2016 at 3:32 AM, Xinliang Liu wrote: >> My understanding is that drm_crtc_arm_vblank_event work together with >> drm_crtc_handle_vblank (called in vblank interrupt). >> Arm the event first in somewhere(like atomic_begin/flush) and t

[Intel-gfx] linux-next: manual merge of the drm-misc tree with the arm tree

Hi all, Today's linux-next merge of the drm-misc tree got a conflict in: drivers/gpu/drm/sti/sti_drv.c between commit: 062993b15e8e ("drm: convert DT component matching to component_match_add_release()") from the arm tree and commit: 84601dbdea36 ("drm: sti: rework init sequence") fro

[Intel-gfx] linux-next: manual merge of the drm-intel tree with the drm-intel-fixes tree

Hi all, Today's linux-next merge of the drm-intel tree got a conflict in: drivers/gpu/drm/i915/intel_fbc.c between commit: 1e3fa0acfec6 ("drm/i915/fbc: Disable on HSW by default for now") from the drm-intel-fixes tree and commit: 80788a0fbbdf ("drm/i915/fbc: sanitize i915.enable_fbc dur

Re: [Intel-gfx] [PATCH 6/6] drm/i915/huc: Add BXT HuC Loading Support

Hi Rodrigo, I tested with an old version that has been knocking about for ages. It is shipped on Android so I think it is production. I may be wrong there as Tom was handling the firmware release process and is not available to talk to. I am being "ACT'ed"/"ACT'ioned"*, so am not sure when I'll

[Intel-gfx] [PATCH v6 3/4] drm/i915/vlv: Disable HPD in valleyview_crt_detect_hotplug()

One of the things preventing us from using polling is the fact that calling valleyview_crt_detect_hotplug() when there's a VGA cable connected results in sending another hotplug. With polling enabled when HPD is disabled, this results in a scenario like this: - We enable power wells and reset the

[Intel-gfx] [PATCH v6 2/4] drm/i915/vlv: Reset the ADPA in vlv_display_power_well_init()

While VGA hotplugging worked(ish) before, it looks like that was mainly because we'd unintentionally enable it in valleyview_crt_detect_hotplug() when we did a force trigger. This doesn't work reliably enough because whenever the display powerwell on vlv gets disabled, the values set in VLV_ADPA ge

[Intel-gfx] [PATCH v6 0/4] Fixes for HPD

Latest version of: https://lists.freedesktop.org/archives/intel-gfx/2016-June/098787.html The only patch that's changed here is 4/4, the rest are just being sent so that they can be in one thread to make things easier for reviewers Lyude (4): drm/i915/vlv: Make intel_crt_reset() per-encoder

[Intel-gfx] [PATCH v6 4/4] drm/i915: Enable polling when we don't have hpd

Unfortunately, there's two situations where we lose hpd right now: - Runtime suspend - When we've shut off all of the power wells on Valleyview/Cherryview While it would be nice if this didn't cause issues, this has the ability to get us in some awkward states where a user won't be able to get the

Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window

On Tue, 2016-06-21 at 18:44 +0300, Ville Syrjälä wrote: > On Tue, Jun 21, 2016 at 09:53:15AM -0400, James Bottomley wrote: > > On Mon, 2016-06-20 at 11:03 +0300, Jani Nikula wrote: > > > Cc: Ville > > > > > > On Mon, 20 Jun 2016, James Bottomley < > > > james.bottom...@hansenpartnership.com> wrote

[Intel-gfx] [PATCH v6 1/4] drm/i915/vlv: Make intel_crt_reset() per-encoder

This lets call intel_crt_reset() in contexts where IRQs are disabled and as such, can't hold the locks required to work with the connectors. Cc: sta...@vger.kernel.org Cc: Ville Syrjälä Acked-by: Daniel Vetter Signed-off-by: Lyude --- drivers/gpu/drm/i915/intel_crt.c | 10 +- 1 file ch

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Use atomic commits for legacy page_flips

On Tue, Jun 21, 2016 at 04:23:42PM +0200, Daniel Vetter wrote: > Adding Maarten/Daniela since I'm going on vacation. > -Daniel > > On Mon, Jun 20, 2016 at 8:30 PM, Matthew Auld > wrote: > > I seem to be hitting some issues with this, at least in gnome-shell > > which I bisected to this commit. So

Re: [Intel-gfx] [PATCH driver/intel] sna/cursor: Make sure hw cursors are disabled before disabling secondary planes

On Tue, Jun 21, 2016 at 07:34:34PM +0200, Egbert Eich wrote: > When the hw cursors are not disabled before the cursor planes get disabled > we may lose the cursor later on. Thus make sure the cursors are disabled > before the cursor planes are. The cursor would already be controlled by the xf86Set

Re: [Intel-gfx] [PATCH v4 4/4] drm/i915: Enable polling when we don't have hpd

On Tue, Jun 21, 2016 at 02:18:35PM -0400, Lyude wrote: > Unfortunately, there's two situations where we lose hpd right now: > - Runtime suspend > - When we've shut off all of the power wells on Valleyview/Cherryview > > While it would be nice if this didn't cause issues, this has the > ability to

Re: [Intel-gfx] [PATCH 01/10] drm/amd-kfd: Clean up inline handling

On Tue, Jun 21, 2016 at 10:11:13PM +0300, Oded Gabbay wrote: > On Tue, Jun 21, 2016 at 12:10 PM, Daniel Vetter > wrote: > > - inline functions need to be static inline, otherwise gcc can opt to > > not inline and the linker gets unhappy. > > - no forward decls for inline functions, just include

Re: [Intel-gfx] [PATCH 01/10] drm/amd-kfd: Clean up inline handling

On Tue, Jun 21, 2016 at 12:10 PM, Daniel Vetter wrote: > - inline functions need to be static inline, otherwise gcc can opt to > not inline and the linker gets unhappy. > - no forward decls for inline functions, just include the right headers. > > Cc: Oded Gabbay > Cc: Ben Goz > Signed-off-by:

Re: [Intel-gfx] [PATCH 6/6] drm/i915/huc: Add BXT HuC Loading Support

Hi Peter, On Tue, 2016-06-21 at 19:11 +0100, Peter Antoine wrote: > This patch adds the HuC Loading for the BXT. > Version 1.x of the HuC firmware. > > Signed-off-by: Peter Antoine > --- >  drivers/gpu/drm/i915/i915_gem.c | 13 +++-- >  drivers/gpu/drm/i915/intel_guc_loader.c | 29

[Intel-gfx] [PATCH v4 4/4] drm/i915: Enable polling when we don't have hpd

Unfortunately, there's two situations where we lose hpd right now: - Runtime suspend - When we've shut off all of the power wells on Valleyview/Cherryview While it would be nice if this didn't cause issues, this has the ability to get us in some awkward states where a user won't be able to get the

[Intel-gfx] [PATCH 5/6] drm/i915/huc: Support HuC authentication

The HuC authentication is done by host2guc call. The HuC RSA keys are sent to GuC for authentication. Signed-off-by: Alex Dai Signed-off-by: Peter Antoine --- drivers/gpu/drm/i915/i915_guc_submission.c | 65 ++ drivers/gpu/drm/i915/intel_guc_fwif.h | 1 + drive

[Intel-gfx] [PATCH 3/6] drm/i915/huc: Add HuC fw loading support

From: Alex Dai The HuC loading process is similar to GuC. The intel_uc_fw_fetch() is used for both cases. HuC loading needs to be before GuC loading. The WOPCM setting must be done early before loading any of them. Signed-off-by: Alex Dai Signed-off-by: Peter Antoine --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 4/6] drm/i915/huc: Add debugfs for HuC loading status check

From: Alex Dai Add debugfs entry for HuC loading status check. Signed-off-by: Alex Dai Signed-off-by: Peter Antoine --- drivers/gpu/drm/i915/i915_debugfs.c | 32 1 file changed, 32 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/

[Intel-gfx] [PATCH 6/6] drm/i915/huc: Add BXT HuC Loading Support

This patch adds the HuC Loading for the BXT. Version 1.x of the HuC firmware. Signed-off-by: Peter Antoine --- drivers/gpu/drm/i915/i915_gem.c | 13 +++-- drivers/gpu/drm/i915/intel_guc_loader.c | 29 + drivers/gpu/drm/i915/intel_huc_loader.c | 7

[Intel-gfx] [PATCH 2/6] drm/i915/huc: Unified css_header struct for GuC and HuC

From: Alex Dai HuC firmware css header has almost exactly same definition as GuC firmware except for the sw_version. Also, add a new member fw_type into intel_uc_fw to indicate what kind of fw it is. So, the loader will pull right sw_version from header. Signed-off-by: Alex Dai Signed-off-by: P

[Intel-gfx] [PATCH 1/6] drm/i915/guc: Make the GuC fw loading helper functions general

Rename some of the GuC fw loading code to make them more general. We will utilize them for HuC loading as well. s/intel_guc_fw/intel_uc_fw/g s/GUC_FIRMWARE/UC_FIRMWARE/g Struct intel_guc_fw is renamed to intel_uc_fw. Prefix of tts members, such as 'guc' or 'guc_fw' either is renamed to 'uc

[Intel-gfx] [PATCH 0/6] HuC Loading Patches

This patch series enables the HuC loading. These patches are a port of the patches that were created by Yu Dai (Alex) and have been ported to work with the new GuC patches. The series include a patch to enable the HuC on BXT. This is a separate patch as the state of the BXT HuC firmware is still i

[Intel-gfx] [PATCH driver/intel] sna/cursor: Make sure hw cursors are disabled before disabling secondary planes

When the hw cursors are not disabled before the cursor planes get disabled we may lose the cursor later on. Thus make sure the cursors are disabled before the cursor planes are. Signed-off-by: Egbert Eich --- src/sna/sna_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/sna/sn

[Intel-gfx] [PATCH i-g-t 4/6] tests/kms_flip: Account for diff.tv_secs in jitter check

From: Ville Syrjälä Include diff.tv_secs in the jitter comparison. Signed-off-by: Ville Syrjälä --- tests/kms_flip.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 743e4ad8f673..7718e950b823 100644 --- a/tests/kms_flip.c ++

[Intel-gfx] [PATCH i-g-t 3/6] tests/kms_flip: Use USEC_PER_SEC

From: Ville Syrjälä Replace some opencoded numbers with USEC_PER_SEC, and print the usec_diff with 6 decimal digits to make things more consistent. Signed-off-by: Ville Syrjälä --- tests/kms_flip.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/kms_flip.c b/tes

[Intel-gfx] [PATCH i-g-t 6/6] tests/kms_flip: Check that the last vs. current seq/ts are consistent

From: Ville Syrjälä Let's make sure the ts vs. seq difference between the current and last events match. Signed-off-by: Ville Syrjälä --- tests/kms_flip.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index f685c945feb1..72899d9a7157 100644 ---

[Intel-gfx] [PATCH i-g-t 2/6] tests/kms_flip: Constify some function arguments

From: Ville Syrjälä Signed-off-by: Ville Syrjälä --- tests/kms_flip.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index f61d199b648f..7b526b5e8593 100644 --- a/tests/kms_flip.c +++ b/tests/kms_flip.c @@ -531,7 +531,7 @@ static

[Intel-gfx] [PATCH i-g-t 5/6] tests/kms_flip: Print the expected diff between two events

From: Ville Syrjälä To aid in diagnosing failures, print out the expected time difference between the two events. Signed-off-by: Ville Syrjälä --- tests/kms_flip.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 7718e950b823..f

[Intel-gfx] [PATCH i-g-t 1/6] tests/kms_flip: Print timestamps in a consistent form

From: Ville Syrjälä Signed-off-by: Ville Syrjälä --- tests/kms_flip.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 6ec97d0a8534..f61d199b648f 100644 --- a/tests/kms_flip.c +++ b/tests/kms_flip.c @@ -132,11 +132,11 @

[Intel-gfx] [PATCH v3 2/4] drm/i915/vlv: Reset the ADPA in vlv_display_power_well_init()

While VGA hotplugging worked(ish) before, it looks like that was mainly because we'd unintentionally enable it in valleyview_crt_detect_hotplug() when we did a force trigger. This doesn't work reliably enough because whenever the display powerwell on vlv gets disabled, the values set in VLV_ADPA ge

[Intel-gfx] [PATCH v3 3/4] drm/i915/vlv: Disable HPD in valleyview_crt_detect_hotplug()

One of the things preventing us from using polling is the fact that calling valleyview_crt_detect_hotplug() when there's a VGA cable connected results in sending another hotplug. With polling enabled when HPD is disabled, this results in a scenario like this: - We enable power wells and reset the

[Intel-gfx] [PATCH v3 1/4] drm/i915/vlv: Make intel_crt_reset() per-encoder

This lets call intel_crt_reset() in contexts where IRQs are disabled and as such, can't hold the locks required to work with the connectors. Cc: sta...@vger.kernel.org Cc: Ville Syrjälä Acked-by: Daniel Vetter Signed-off-by: Lyude --- drivers/gpu/drm/i915/intel_crt.c | 10 +- 1 file ch

[Intel-gfx] [PATCH v3 4/4] drm/i915: Enable polling when we don't have hpd

Unfortunately, there's two situations where we lose hpd right now: - Runtime suspend - When we've shut off all of the power wells on Valleyview/Cherryview While it would be nice if this didn't cause issues, this has the ability to get us in some awkward states where a user won't be able to get the

[Intel-gfx] [PATCH v3 0/4] Fixes for HPD

This is a revised version of the patchset: https://lists.freedesktop.org/archives/intel-gfx/2016-June/098787.html This patchset is intended to fix the issue of not having HPD when we're in runtime suspend, or on Valleyview/Cherryview systems when we don't have any power wells enabled. While this

Re: [Intel-gfx] [PATCH v10b 4/6] drm/i915: Interrupt driven fences

On 21/06/16 11:44, Tvrtko Ursulin wrote: On 17/06/16 12:05, john.c.harri...@intel.com wrote: From: John Harrison The intended usage model for struct fence is that the signalled status should be set on demand rather than polled. That is, there should not be a need for a 'signaled' function to

[Intel-gfx] [PATCH i-g-t 3/3] tools/intel_bios_reader: Dump out more of the eDP block

From: Ville Syrjälä Signed-off-by: Ville Syrjälä --- tools/intel_bios.h| 26 --- tools/intel_bios_reader.c | 108 ++ 2 files changed, 120 insertions(+), 14 deletions(-) diff --git a/tools/intel_bios.h b/tools/intel_bios.h index ac8c8

[Intel-gfx] [PATCH i-g-t 1/3] tools/intel_bios_reader: Dump more bits for general bit definitions block (1)

From: Ville Syrjälä Signed-off-by: Ville Syrjälä --- tools/intel_bios.h| 17 ++--- tools/intel_bios_reader.c | 35 +-- 2 files changed, 47 insertions(+), 5 deletions(-) diff --git a/tools/intel_bios.h b/tools/intel_bios.h index b7ebd48ef7e7..

[Intel-gfx] [PATCH i-g-t 2/3] tools/intel_bios_reader: Dump out more information from the child device structure

From: Ville Syrjälä Signed-off-by: Ville Syrjälä --- tools/intel_bios.h| 51 ++- tools/intel_bios_reader.c | 69 ++- 2 files changed, 107 insertions(+), 13 deletions(-) diff --git a/tools/intel_bios.h b/tools/i

Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window

On Tue, Jun 21, 2016 at 09:53:15AM -0400, James Bottomley wrote: > On Mon, 2016-06-20 at 11:03 +0300, Jani Nikula wrote: > > Cc: Ville > > > > On Mon, 20 Jun 2016, James Bottomley < > > james.bottom...@hansenpartnership.com> wrote: > > > OK, my candidate bad commit is this one: > > > > > > commit

[Intel-gfx] ✗ Ro.CI.BAT: failure for Enable lspcon support for GEN9 devices (rev2)

== Series Details == Series: Enable lspcon support for GEN9 devices (rev2) URL : https://patchwork.freedesktop.org/series/8024/ State : failure == Summary == Series 8024v2 Enable lspcon support for GEN9 devices http://patchwork.freedesktop.org/api/1.0/series/8024/revisions/2/mbox Test drv_mod

Re: [Intel-gfx] [PATCH 42/44] drm/i915: Defer enabling rc6 til after we submit the first batch/context

On Wed, Jun 15, 2016 at 01:18:27PM +0100, Chris Wilson wrote: > Some hardware requires a valid render context before it can initiate > rc6 power gating of the GPU; the default state of the GPU is not > sufficient and may lead to undefined behaviour. The first execution of > any batch will load the

Re: [Intel-gfx] [PATCH 41/44] drm/i915: Remove superfluous powersave work flushing

On Wed, Jun 15, 2016 at 01:18:26PM +0100, Chris Wilson wrote: > Instead of flushing the outstanding enabling, remember the requested > frequency to apply when the powersave work runs. > > Signed-off-by: Chris Wilson > Cc: Ville Syrjälä Ping? Everything should be in place by this point that user

Re: [Intel-gfx] [PATCH] drm/i915/guc: Remove one unnecessary variable

On Tue, Jun 21, 2016 at 03:02:57PM +0100, Tvrtko Ursulin wrote: > > On 21/06/16 14:00, Chris Wilson wrote: > >On Tue, Jun 21, 2016 at 01:48:23PM +0100, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>No need for local struct drm_device * since dev_priv is the > >>correct thing to pass in

[Intel-gfx] [PATCH v2 1/4] drm: Helper for lspcon in drm_dp_dual_mode

This patch adds lspcon support in dp_dual_mode helper. lspcon is essentially a dp->hdmi dongle with dual personality. LS mode: It works as a passive dongle, by level shifting DP++ signals to HDMI signals, in LS mode. PCON mode: It works as a protocol converter active dongle in pcon mode, by conver

Re: [Intel-gfx] ✗ Ro.CI.BAT: warning for drm/i915/guc: Remove one unnecessary variable (rev2)

On 21/06/16 15:41, Patchwork wrote: == Series Details == Series: drm/i915/guc: Remove one unnecessary variable (rev2) URL : https://patchwork.freedesktop.org/series/8995/ State : warning == Summary == Series 8995v2 drm/i915/guc: Remove one unnecessary variable http://patchwork.freedesktop.

[Intel-gfx] [PATCH v2 4/4] drm/i915: Enable lspcon initialization

This patch adds initialization code for lspcon. What we are doing here is: - Check if lspcon is configured in VBT for this port - If lspcon is configured, initialize it and configure it as DP port. V2: Addressed Ville's review comments: - Not adding AVI IF functions for L

[Intel-gfx] [PATCH v2 2/4] drm/i915: Add lspcon support for I915 driver

This patch adds a new file, to accommodate lspcon support for I915 driver. These functions probe, detect, initialize and configure an on-board lspcon device during the driver init time. Also, this patch adds a small structure for lspcon device, which will provide the runtime status of the device.

[Intel-gfx] [PATCH v2 3/4] drm/i915: Parse VBT data for lspcon

Many GEN9 boards come with on-board lspcon cards. Fot these boards, VBT configuration should properly point out if a particular port contains lspcon device, so that driver can initialize it properly. This patch adds a utility function, which checks the VBT flag for lspcon bit, and tells us if a po

[Intel-gfx] [PATCH v2 0/4] Enable lspcon support for GEN9 devices

LSPCON is essencially a dp++->hdmi adaptor with dual mode of operation. These modes are: - Level Shifter mode: In LS mode, this device works as a type2 dp->hdmi passive dongle, which steps up DP++ output to appropriate HDMI 1.4 signal. This mode doesn't do any conversion at the protocol level. -

Re: [Intel-gfx] i915 driver on Minnow board - 1920x1200 resolution not working

On Tue, 21 Jun 2016, vinoth eswaran wrote: > On Tue, Jun 21, 2016 at 12:54 PM, Jani Nikula > wrote: >> On Tue, 21 Jun 2016, vinoth eswaran wrote: >>> On Tue, Jun 21, 2016 at 11:35 AM, Jani Nikula >>> wrote: On Tue, 21 Jun 2016, vinoth eswaran wrote: > On Tue, Jun 21, 2016 at 10:17 AM,

[Intel-gfx] ✗ Ro.CI.BAT: warning for drm/i915/guc: Remove one unnecessary variable (rev2)

== Series Details == Series: drm/i915/guc: Remove one unnecessary variable (rev2) URL : https://patchwork.freedesktop.org/series/8995/ State : warning == Summary == Series 8995v2 drm/i915/guc: Remove one unnecessary variable http://patchwork.freedesktop.org/api/1.0/series/8995/revisions/2/mbox

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Use atomic commits for legacy page_flips

Adding Maarten/Daniela since I'm going on vacation. -Daniel On Mon, Jun 20, 2016 at 8:30 PM, Matthew Auld wrote: > I seem to be hitting some issues with this, at least in gnome-shell > which I bisected to this commit. Somewhat hard to describe but the > background window or desktop is partiality

[Intel-gfx] [PATCH v2] drm/i915/guc: Remove one unnecessary variable

From: Tvrtko Ursulin No need for local struct drm_device * since dev_priv is the correct thing to pass in to NEEDS_WaRsDisableCoarsePowerGating anyway. Changed the macro definition for the latter to reflect that as well. v2: Alignment bikeshed. Signed-off-by: Tvrtko Ursulin Cc: Dave Gordon Re

Re: [Intel-gfx] [PATCH] drm/i915/guc: Remove one unnecessary variable

On 21/06/16 14:00, Chris Wilson wrote: On Tue, Jun 21, 2016 at 01:48:23PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin No need for local struct drm_device * since dev_priv is the correct thing to pass in to NEEDS_WaRsDisableCoarsePowerGating anyway. Changed the macro definition for the l

Re: [Intel-gfx] [RFC i-g-t v3 08/13] lib/stubs: Add stubs for intel_bufmgr.

On 21 June 2016 at 14:41, Emil Velikov wrote: > On 21 June 2016 at 13:50, Marius Vlad wrote: >> On Mon, Jun 20, 2016 at 03:52:35PM +0100, Emil Velikov wrote: >>> Hi Rob, >>> >>> A couple of nitpicks and a case of missing git add :-) >>> >>> On 15 June 2016 at 10:51, wrote: >>> >>> > +if HAVE_LI

Re: [Intel-gfx] [RFC i-g-t v3 08/13] lib/stubs: Add stubs for intel_bufmgr.

On 21 June 2016 at 13:50, Marius Vlad wrote: > On Mon, Jun 20, 2016 at 03:52:35PM +0100, Emil Velikov wrote: >> Hi Rob, >> >> A couple of nitpicks and a case of missing git add :-) >> >> On 15 June 2016 at 10:51, wrote: >> >> > +if HAVE_LIBDRM_INTEL >> > +else >> > +libintel_tools_la_SOURCES

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915/guc: Remove one unnecessary variable

== Series Details == Series: drm/i915/guc: Remove one unnecessary variable URL : https://patchwork.freedesktop.org/series/8995/ State : failure == Summary == Series 8995v1 drm/i915/guc: Remove one unnecessary variable http://patchwork.freedesktop.org/api/1.0/series/8995/revisions/1/mbox Test

Re: [Intel-gfx] [PATCH igt] igt: Add basic framework for GVT-g testing

On Tue, Jun 21, 2016 at 01:24:26PM +, Wang, Zhi A wrote: > > + while ((vtcon = readdir(dir))) { > > + int fd, len; > > + > > + if (strncmp(vtcon->d_name, "vtcon", 5)) > > + continue; > > + > > + sprintf(buf, "%s/%s/name", path, vtcon->d_name); >

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Demidlayer driver loading

On Tue, Jun 21, 2016 at 03:27:02PM +0200, Daniel Vetter wrote: > On Tue, Jun 21, 2016 at 09:53:46AM +0100, Chris Wilson wrote: > > -int i915_driver_load(struct drm_device *dev, unsigned long flags) > > +int i915_driver_load(struct pci_dev *pdev, > > +const struct pci_device_id *ent,

Re: [Intel-gfx] [PATCH v3] drm/i915/fbc: FBC causes display flicker when VT-d is enabled on Skylake

On Tue, Jun 21, 2016 at 08:25:27AM +0100, Chris Wilson wrote: > Erratum SKL075: Display Flicker May Occur When Both VT-d And FBC Are Enabled > > "Display flickering may occur when both FBC (Frame Buffer Compression) > and VT - d (Intel® Virtualization Technology for Directed I/O) are enabled > and

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Move connector registration to driver registration

On Tue, Jun 21, 2016 at 03:18:12PM +0200, Daniel Vetter wrote: > On Tue, Jun 21, 2016 at 09:53:44AM +0100, Chris Wilson wrote: > > +void intel_modeset_register(struct drm_i915_private *dev_priv) > > +{ > > + drm_connector_register_all(dev_priv->dev); > > +} > > + > > +void intel_modeset_unregiste

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Remove redundant drm_connector_register_all()

On Tue, Jun 21, 2016 at 09:53:48AM +0100, Chris Wilson wrote: > drm_connector_register_all() is now automatically called by > drm_dev_register(), and so we no longer have to do so ourselves (via > intel_modeset_register() after calling drm_dev_register()). Similarly > for unregistering. > > Signed

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Demidlayer driver loading

On Tue, Jun 21, 2016 at 09:53:46AM +0100, Chris Wilson wrote: > Take control over allocating, loading and registering the driver from the > DRM midlayer by performing it manually from i915_pci_probe. This allows > us to carefully control the order of when we setup the hardware vs when > it becomes

Re: [Intel-gfx] [PATCH] drm/i915: Limit i915_ring_test_irq debugfs to actual rings

On Fri, Jun 17, 2016 at 02:35:05PM +0100, Chris Wilson wrote: > For simplicity in testing, only report known rings in the mask. This > allows userspace to try and trigger a missed irq on every ring and do a > comparison between i915_ring_test_irq and i915_ring_missed_irq to see if > any rings faile

Re: [Intel-gfx] [PATCH igt] igt: Add basic framework for GVT-g testing

Thanks. I'm learning the test framework :P Just have a few questions: > -Original Message- > From: Chris Wilson [mailto:chris.ickle.wil...@gmail.com] On Behalf Of Chris > Wilson > Sent: Tuesday, June 21, 2016 2:36 PM > To: intel-gfx@lists.freedesktop.org > Cc: Chris Wilson ; Wang, Zhi A >

Re: [Intel-gfx] [PATCH 5/8] drm/i915: Register debugfs interface last

On Tue, Jun 21, 2016 at 09:53:45AM +0100, Chris Wilson wrote: > Currently debugfs files are created before the driver is even loads. > This gives the opportunity for userspace to open that interface and poke > around before the backing data structures are initialised - with the > possibility of oop

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Move connector registration to driver registration

On Tue, Jun 21, 2016 at 09:53:44AM +0100, Chris Wilson wrote: > +void intel_modeset_register(struct drm_i915_private *dev_priv) > +{ > + drm_connector_register_all(dev_priv->dev); > +} > + > +void intel_modeset_unregister(struct drm_i915_private *dev_priv) > +{ > + drm_connector_unregister_

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm: Refactor drop/set master code a bit

== Series Details == Series: drm: Refactor drop/set master code a bit URL : https://patchwork.freedesktop.org/series/8993/ State : failure == Summary == Applying: drm: Refactor drop/set master code a bit fatal: sha1 information is lacking or useless (include/drm/drmP.h). error: could not build

Re: [Intel-gfx] [PATCH] drm/i915/guc: Remove one unnecessary variable

On Tue, Jun 21, 2016 at 01:48:23PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > No need for local struct drm_device * since dev_priv is the > correct thing to pass in to NEEDS_WaRsDisableCoarsePowerGating > anyway. Changed the macro definition for the latter to reflect > that as well.

Re: [Intel-gfx] [PATCH] drm/i915/guc: Remove one unnecessary variable

On Tue, Jun 21, 2016 at 01:48:23PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > No need for local struct drm_device * since dev_priv is the > correct thing to pass in to NEEDS_WaRsDisableCoarsePowerGating > anyway. Changed the macro definition for the latter to reflect > that as well.

Re: [Intel-gfx] ✗ Ro.CI.BAT: warning for drm/i915: Fix power sequencer use before init

On ti, 2016-06-21 at 09:45 +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fix power sequencer use before init > URL   : https://patchwork.freedesktop.org/series/8967/ > State : warning > > == Summary == > > Series 8967v1 drm/i915: Fix power sequencer use before init > http:

Re: [Intel-gfx] [PATCH v10 2/6] drm/i915: Convert requests to use struct fence

Op 16-06-16 om 14:54 schreef john.c.harri...@intel.com: > From: John Harrison > > There is a construct in the linux kernel called 'struct fence' that is > intended to keep track of work that is executed on hardware. I.e. it > solves the basic problem that the drivers 'struct > drm_i915_gem_request

[Intel-gfx] ✓ Ro.CI.BAT: success for drm: Lobotomize set_busid nonsense for !pci drivers

== Series Details == Series: drm: Lobotomize set_busid nonsense for !pci drivers URL : https://patchwork.freedesktop.org/series/8989/ State : success == Summary == Series 8989v1 drm: Lobotomize set_busid nonsense for !pci drivers http://patchwork.freedesktop.org/api/1.0/series/8989/revisions/1

[Intel-gfx] [PATCH] drm/i915/guc: Remove one unnecessary variable

From: Tvrtko Ursulin No need for local struct drm_device * since dev_priv is the correct thing to pass in to NEEDS_WaRsDisableCoarsePowerGating anyway. Changed the macro definition for the latter to reflect that as well. Signed-off-by: Tvrtko Ursulin Cc: Dave Gordon --- drivers/gpu/drm/i915/i

Re: [Intel-gfx] [PATCH v10 1/6] drm/i915: Add per context timelines for fence objects

Op 16-06-16 om 14:54 schreef john.c.harri...@intel.com: > From: John Harrison > > The purpose of this patch series is to convert the requst structure to > use fence objects for the underlying completion tracking. The fence > object requires a sequence number. The ultimate aim is to use the same >

Re: [Intel-gfx] [RFC i-g-t v3 08/13] lib/stubs: Add stubs for intel_bufmgr.

On Mon, Jun 20, 2016 at 03:52:35PM +0100, Emil Velikov wrote: > Hi Rob, > > A couple of nitpicks and a case of missing git add :-) > > On 15 June 2016 at 10:51, wrote: > > > +if HAVE_LIBDRM_INTEL > > +else > > +libintel_tools_la_SOURCES += \ > > +stubs/drm/intel_bufmgr.c

Re: [Intel-gfx] [PATCH i-g-t v2] tests/drm_lib.sh: Extract fake getopt options so it can sourced into tests that require it.

On Tue, Jun 21, 2016 at 03:34:07PM +0300, Marius Vlad wrote: > This should allow tests/vgem_reload_basic to pass check target and it > doesn't depend of i915 being present. > > v2: Do not source drm_lib.sh, only fake getopt parsing > option to again access to --list-subtests option (Chris) > > Si

[Intel-gfx] [PATCH] drm: Drop mode_config.mutex from get_resources ioctl

The only thing this protected is the connector_list, which is now protected differently. v2: Also remove comment (Chris). Cc: Chris Wilson Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_crtc.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu

Re: [Intel-gfx] [PATCH] drm: Don't compute obj counts expensively in get_resources

On Tue, Jun 21, 2016 at 02:29:48PM +0200, Daniel Vetter wrote: > Looping when we keep track of this is silly. Only thing we have to > be careful is with sampling the connector count. To avoid inconsisten > results due to gcc re-computing this, use READ_ONCE. > > And to avoid surprising userspace,

[Intel-gfx] [PATCH i-g-t v2] tests/drm_lib.sh: Extract fake getopt options so it can sourced into tests that require it.

This should allow tests/vgem_reload_basic to pass check target and it doesn't depend of i915 being present. v2: Do not source drm_lib.sh, only fake getopt parsing option to again access to --list-subtests option (Chris) Signed-off-by: Marius Vlad CC: Chris Wilson --- tests/drm_getopt.sh |

[Intel-gfx] [PATCH] drm: Don't compute obj counts expensively in get_resources

Looping when we keep track of this is silly. Only thing we have to be careful is with sampling the connector count. To avoid inconsisten results due to gcc re-computing this, use READ_ONCE. And to avoid surprising userspace, make sure we don't copy more connectors than planned, and report the actu

Re: [Intel-gfx] [PATCH v10 6/6] drm/i915: Cache last IRQ seqno to reduce IRQ overhead

Op 16-06-16 om 14:54 schreef john.c.harri...@intel.com: > From: John Harrison > > The notify function can be called many times without the seqno > changing. Some are to prevent races due to the requirement of not > enabling interrupts until requested. However, when interrupts are > enabled the IRQ

[Intel-gfx] ✗ Ro.CI.BAT: failure for Documentation: convert DocBook gpu.tmpl to reStructuredText (rev2)

== Series Details == Series: Documentation: convert DocBook gpu.tmpl to reStructuredText (rev2) URL : https://patchwork.freedesktop.org/series/8931/ State : failure == Summary == Applying: Documentation/gpu: add new gpu.rst converted from DocBook gpu.tmpl Using index info to reconstruct a base

Re: [Intel-gfx] [PATCH igt] igt: Add basic framework for GVT-g testing

Ha, I see. Additional signal handler to call the exit handlers. :P > -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Tuesday, June 21, 2016 3:22 PM > To: Wang, Zhi A > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH igt] igt: Add basic framework

Re: [Intel-gfx] [PATCH igt] igt: Add basic framework for GVT-g testing

On Tue, Jun 21, 2016 at 12:17:48PM +, Wang, Zhi A wrote: > To me, atexit is not reliable. As if something wrong happened during the test > and an unexpected signal was received, the prog would be aborted. atexit() > would not work on that case. Better do failsafe work in parent process and >

Re: [Intel-gfx] [PATCH 02/10] drm: Don't compute obj counts expensively in get_resources

On Tue, Jun 21, 2016 at 10:48:08AM +0100, Chris Wilson wrote: > On Tue, Jun 21, 2016 at 11:10:27AM +0200, Daniel Vetter wrote: > > And to avoid surprising userspace, make sure we don't copy more > > connectors than planned, and report the actual number of connectors > > copied. That way any racing

[Intel-gfx] [PATCH] drm: Refactor drop/set master code a bit

File open/set_maseter ioctl and file close/drop_master ioctl share the same master handling code. Extract it. Note that vmwgfx's master_set callback needs to know whether the master is a new one or has been used already, so thread this through. On the close/drop side a similar parameter existed, b

Re: [Intel-gfx] [PATCH igt] igt: Add basic framework for GVT-g testing

> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Tuesday, June 21, 2016 3:08 PM > To: Wang, Zhi A > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH igt] igt: Add basic framework for GVT-g testing > > On Tue, Jun 21, 2016 at 12:01:02PM +,

Re: [Intel-gfx] [PATCH v2 0/7] Documentation: convert DocBook gpu.tmpl to reStructuredText

On Tue, Jun 21, 2016 at 02:48:56PM +0300, Jani Nikula wrote: > Take two of [1], see the cover letter there. > > I've renamed drm-userland-interfaces.rst to drm-uapi.rst and added a > further split-up patch of drm internals, extracting mm, kms and kms > helpers to separate documents. All applied t

Re: [Intel-gfx] [PATCH igt] igt: Add basic framework for GVT-g testing

> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Tuesday, June 21, 2016 3:08 PM > To: Wang, Zhi A > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH igt] igt: Add basic framework for GVT-g testing > > On Tue, Jun 21, 2016 at 12:01:02PM +,

[Intel-gfx] [PATCH] drm: Lobotomize set_busid nonsense for !pci drivers

We already have a fallback in place to fill out the unique from dev->unique, which is set to something reasonable in drm_dev_alloc. Which means we only need to have a special set_busid for pci devices, to be able to care the backwards compat code for drm 1.1 around, which libdrm still needs. Whil

Re: [Intel-gfx] [PATCH igt] igt: Add basic framework for GVT-g testing

On Tue, Jun 21, 2016 at 12:01:02PM +, Wang, Zhi A wrote: > > > > -Original Message- > > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > > Sent: Tuesday, June 21, 2016 2:55 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Wang, Zhi A > > Subject: Re: [PATCH igt] igt: Add basi

Re: [Intel-gfx] [PATCH igt] igt: Add basic framework for GVT-g testing

> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Tuesday, June 21, 2016 2:55 PM > To: intel-gfx@lists.freedesktop.org > Cc: Wang, Zhi A > Subject: Re: [PATCH igt] igt: Add basic framework for GVT-g testing > > On Tue, Jun 21, 2016 at 12:36:06PM +0100,

Re: [Intel-gfx] [PATCH igt] igt: Add basic framework for GVT-g testing

On Tue, Jun 21, 2016 at 12:36:06PM +0100, Chris Wilson wrote: > +static bool is_gvt_enabled(void) > +{ > + FILE *file; > + int value; > + bool enabled = false; > + > + file = fopen("/sys/module/i915/parameters/enable_gvt", "r"); > + if (!file) > + return false; > + >

[Intel-gfx] [PATCH v2 0/7] Documentation: convert DocBook gpu.tmpl to reStructuredText

Take two of [1], see the cover letter there. I've renamed drm-userland-interfaces.rst to drm-uapi.rst and added a further split-up patch of drm internals, extracting mm, kms and kms helpers to separate documents. BR, Jani. [1] http://mid.gmane.org/cover.1466434348.git.jani.nik...@intel.com Jan

[Intel-gfx] [PATCH v2 4/7] Documentation/gpu: use recommended order of heading markers

While splitting the document up, the headings "shifted" from what pandoc generated. Use the following order for headings for consistency: == Document title == First = Second -- Third ~ Leave the lower level headings as they are; I think those are less import

[Intel-gfx] [PATCH v2 3/7] MAINTAINERS: add Documentation/gpu and Documentation/gpu/i915.rst

We'll want to keep an eye on what's going on in these files. Signed-off-by: Jani Nikula --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index cb88f724e07c..ce9c23dd02c6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3857,6 +3857,7 @@ F:driv

Re: [Intel-gfx] [PATCH] drm/i915/gvt: Mark i915.enable_gvt as false if loading fails

> -Original Message- > From: Chris Wilson [mailto:chris.ickle.wil...@gmail.com] On Behalf Of Chris > Wilson > Sent: Tuesday, June 21, 2016 2:07 PM > To: intel-gfx@lists.freedesktop.org > Cc: Chris Wilson ; Wang, Zhi A > > Subject: [PATCH] drm/i915/gvt: Mark i915.enable_gvt as false if load

  1   2   >