Re: [Intel-gfx] [PATCH] drm/i915: Force vblanks around evasion when i915.watermark_test is set.

2016-06-13 Thread Maarten Lankhorst
Op 13-06-16 om 16:45 schreef Daniel Vetter: > On Thu, Jun 09, 2016 at 01:36:50PM +0200, Maarten Lankhorst wrote: >> This will make it more likely that intermediary watermarks cause fifo >> underruns, which is useful when writing watermark specific tests, >> to make it more likely to trigger FIFO un

[Intel-gfx] ✗ Ro.CI.BAT: warning for drm/i915: Fix missing unlock on error in i915_ppgtt_info()

2016-06-13 Thread Patchwork
== Series Details == Series: drm/i915: Fix missing unlock on error in i915_ppgtt_info() URL : https://patchwork.freedesktop.org/series/8657/ State : warning == Summary == Series 8657v1 drm/i915: Fix missing unlock on error in i915_ppgtt_info() http://patchwork.freedesktop.org/api/1.0/series/86

Re: [Intel-gfx] [PATCH] drm/i915: Fix missing unlock on error in i915_ppgtt_info()

2016-06-13 Thread Daniel Vetter
On Mon, Jun 13, 2016 at 11:42:00PM +, weiyj...@163.com wrote: > From: Wei Yongjun > > Add the missing unlock before return from function i915_ppgtt_info() > in the error handling case. > > Fixes: 1d2ac403ae3b(drm: Protect dev->filelist with its own mutex) > Signed-off-by: Wei Yongjun Appli

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915/skl: Increase cursor ddb blocks in multi-pipe config

2016-06-13 Thread Patchwork
== Series Details == Series: drm/i915/skl: Increase cursor ddb blocks in multi-pipe config URL : https://patchwork.freedesktop.org/series/8656/ State : failure == Summary == Series 8656v1 drm/i915/skl: Increase cursor ddb blocks in multi-pipe config http://patchwork.freedesktop.org/api/1.0/ser

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915/guc: updates to GuC doorbell handling (rev2)

2016-06-13 Thread Patchwork
== Series Details == Series: drm/i915/guc: updates to GuC doorbell handling (rev2) URL : https://patchwork.freedesktop.org/series/8553/ State : failure == Summary == Series 8553v2 drm/i915/guc: updates to GuC doorbell handling http://patchwork.freedesktop.org/api/1.0/series/8553/revisions/2/mb

[Intel-gfx] linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2016-06-13 Thread Stephen Rothwell
Hi Dave, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/i915/intel_display.c between commit: a5aac5ab876a ("drm/i915: Check VBT for port presence in addition to the strap on VLV/CHV") from the drm-intel-fixes tree and commit: 457c52d87e5d ("drm/i915: Only i

Re: [Intel-gfx] [PATCH 3/3] drm/i915/psr: Do not activate PSR when vblank interrupts are enabled

2016-06-13 Thread Vivi, Rodrigo
On Wed, 2016-06-08 at 18:46 -0700, Dhinakaran Pandiyan wrote: > PSR in CHV, unlike HSW, can get activated even if vblanks interrupts > are > enabled. But, the pipe is not expected to generate timings signals > when PSR is active. Specifically, we do not get vblank interrupts in > CHV > if PSR becom

[Intel-gfx] [PATCH] drm/i915: Fix missing unlock on error in i915_ppgtt_info()

2016-06-13 Thread weiyj_lk
From: Wei Yongjun Add the missing unlock before return from function i915_ppgtt_info() in the error handling case. Fixes: 1d2ac403ae3b(drm: Protect dev->filelist with its own mutex) Signed-off-by: Wei Yongjun --- drivers/gpu/drm/i915/i915_debugfs.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[Intel-gfx] [PATCH] drm/i915/skl: Increase cursor ddb blocks in multi-pipe config

2016-06-13 Thread Radhakrishna Sripada
The bspec suggests giving cursor planes a fixed allocation of 8 blocks when running in a multi-CRTC configuration. However we have found that this small allocation can only accommodate level 0 watermarks on many platforms, which in turn prevents the system from entering deeper sleep states. Let's

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915:bxt: Enable Pooled EU support

2016-06-13 Thread Michał Winiarski
On Fri, Jun 03, 2016 at 06:34:33AM +0100, Arun Siluvery wrote: > This mode allows to assign EUs to pools which can process work collectively. > The command to enable this mode should be issued as part of context > initialization. > > The pooled mode is global, once enabled it has to stay the same

[Intel-gfx] [PATCH v3 5/7] drm/i915/guc: refactor doorbell management code

2016-06-13 Thread Dave Gordon
This patch refactors the driver's handling and tracking of doorbells, in preparation for a later one which will resolve a suspend-resume issue. There are three resources to be managed: 1. Cachelines: a single line within the client-object's page 0 is snooped by doorbell hardware for writes from

[Intel-gfx] [PATCH v3 3/7] drm/i915/guc: remove writes to GEN8_DRBREG registers

2016-06-13 Thread Dave Gordon
These registers are not actually writable by the CPU; only the GuC can actually program them. So let's not do writes that have no effect. Signed-off-by: Dave Gordon Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_guc_submission.c | 5 - 1 file changed, 5 deletions(-) diff --git a

[Intel-gfx] [PATCH v3 7/7] drm/i915/guc: (re)initialise doorbell h/w when enabling GuC submission

2016-06-13 Thread Dave Gordon
During a hibernate/resume cycle, the whole system is reset, including the GuC and the doorbell hardware. Then the system is booted up, drivers are loaded, etc -- the GuC firmware may be loaded and set running at this point. But then, the booted kernel is replaced by the hibernated image, and this r

[Intel-gfx] [PATCH v3 6/7] drm/i915/guc: replace assign_doorbell() with select_doorbell_register()

2016-06-13 Thread Dave Gordon
This version doesn't update the doorbell bitmap, as that will be done when the selected doorbell is associated with a client. The call is now slightly earlier, just on the general principle that potentially-failing operations should be done as early as possible, to eliminate late failures and simp

[Intel-gfx] [PATCH v3 0/7] drm/i915/guc: updates to GuC doorbell handling

2016-06-13 Thread Dave Gordon
Various GuC (doorbell) related patches, some trivial. The bulk of the changes are in [patch 5/7], but it's mostly just reorganisation of existing code; and [patch 6/7] is just a followup to that, kept as a separate change for reasons of clarity. The new functionality is implemented in a single new

[Intel-gfx] [PATCH v3 4/7] drm/i915/guc: move guc_ring_doorbell() nearer to callsite

2016-06-13 Thread Dave Gordon
Just code movement, no actual change to the function. This is in preparation for the next patch, which will reorganise all the other doorbell code, but doesn't change this function. So let's shuffle it down near its caller rather than leaving it mixed in with the setup code. Unlike the doorbell man

[Intel-gfx] [PATCH v3 2/7] drm/i915/guc: prefer __set/clear_bit() to bitmap_set/clear()

2016-06-13 Thread Dave Gordon
Bitmap operators are overkill when touching only one bit. Signed-off-by: Dave Gordon Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_guc_submission.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_guc_submission.c b/drivers/gpu/drm/i

[Intel-gfx] [PATCH v3 1/7] drm/i915/guc: add doorbell map to debugfs/i915_guc_info

2016-06-13 Thread Dave Gordon
To properly verify the driver->doorbell->GuC functionality, validation needs to know how the driver has assigned the doorbell cache lines and registers, so make them visible through debugfs. v2: use kernel bitmap-printing format (%pb) rather than %x. Signed-off-by: Dave Gordon Reviewed-by: Tvrtk

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Add output_types bitmask into the crtc state

2016-06-13 Thread Ville Syrjälä
On Mon, Jun 13, 2016 at 04:25:55PM +0200, Daniel Vetter wrote: > On Wed, Jun 08, 2016 at 01:41:38PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Rather than looping through encoders to see which encoder types > > are being driven by the pipe, add an output_types bit

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for series starting with [v2,RESEND,1/6] drm/i915/bxt: Wait for PHY1 GRC calibration synchronously

2016-06-13 Thread Imre Deak
On ma, 2016-06-13 at 14:23 +, Patchwork wrote: > == Series Details == > > Series: series starting with [v2,RESEND,1/6] drm/i915/bxt: Wait for > PHY1 GRC calibration synchronously > URL   : https://patchwork.freedesktop.org/series/8627/ > State : failure > > == Summary == > > Series 8627v1 Se

[Intel-gfx] [PATCH v2 7/6] drm/i915/guc: replace assign_doorbell() with select_doorbell_register()

2016-06-13 Thread Dave Gordon
This version doesn't update the doorbell bitmap, as that will be done when the selected doorbell is associated with a client. Also it's called a little earlier, just on the general principle that potentially-failing operations should be done before those that can't fail, to simplify error handling

Re: [Intel-gfx] [PATCH v2 5/6] drm/i915/guc: refactor doorbell management code

2016-06-13 Thread Tvrtko Ursulin
On 13/06/16 16:59, Dave Gordon wrote: On 13/06/16 11:53, Tvrtko Ursulin wrote: On 13/06/16 11:25, Dave Gordon wrote: On 13/06/16 10:48, Tvrtko Ursulin wrote: On 10/06/16 17:51, Dave Gordon wrote: This patch refactors the driver's handling and tracking of doorbells, in preparation for a lat

Re: [Intel-gfx] [PATCH v2 5/6] drm/i915/guc: refactor doorbell management code

2016-06-13 Thread Dave Gordon
On 13/06/16 11:53, Tvrtko Ursulin wrote: On 13/06/16 11:25, Dave Gordon wrote: On 13/06/16 10:48, Tvrtko Ursulin wrote: On 10/06/16 17:51, Dave Gordon wrote: This patch refactors the driver's handling and tracking of doorbells, in preparation for a later one which will resolve a suspend-resu

Re: [Intel-gfx] ✗ Ro.CI.BAT: warning for series starting with [1/2] drm/i915/guc: prefer 'dev_priv' to 'dev' for static functions

2016-06-13 Thread Tvrtko Ursulin
On 13/06/16 16:42, Dave Gordon wrote: On 11/06/16 06:50, Patchwork wrote: == Series Details == Series: series starting with [1/2] drm/i915/guc: prefer 'dev_priv' to 'dev' for static functions URL : https://patchwork.freedesktop.org/series/8556/ State : warning == Summary == Series 8556v1 S

Re: [Intel-gfx] [PATCH v9 4/6] drm/i915: Interrupt driven fences

2016-06-13 Thread John Harrison
On 07/06/2016 13:02, Maarten Lankhorst wrote: Op 02-06-16 om 15:25 schreef Tvrtko Ursulin: On 01/06/16 18:07, john.c.harri...@intel.com wrote: From: John Harrison The intended usage model for struct fence is that the signalled status should be set on demand rather than polled. That is, there

Re: [Intel-gfx] ✗ Ro.CI.BAT: warning for series starting with [1/2] drm/i915/guc: prefer 'dev_priv' to 'dev' for static functions

2016-06-13 Thread Dave Gordon
On 11/06/16 06:50, Patchwork wrote: == Series Details == Series: series starting with [1/2] drm/i915/guc: prefer 'dev_priv' to 'dev' for static functions URL : https://patchwork.freedesktop.org/series/8556/ State : warning == Summary == Series 8556v1 Series without cover letter http://patch

Re: [Intel-gfx] [PATCH] drm/i915: prefer INTEL_GEN(dev_priv) to INTEL_INFO(dev)->gen

2016-06-13 Thread Dave Gordon
On 13/06/16 10:28, Tvrtko Ursulin wrote: On 10/06/16 18:35, Dave Gordon wrote: More Coccinellery ... Wherever we find "INTEL_INFO(dev)->gen", and have a suitable "dev_priv" in scope, replace it with "INTEL_GEN(dev_priv)". At this time, we've found 189 instances, and each replacement saves one

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Move fb_bits updating later in atomic_commit

2016-06-13 Thread Chris Wilson
On Mon, Jun 13, 2016 at 04:13:48PM +0200, Daniel Vetter wrote: > Currently it's part of prepare_fb, still in the first phase of > atomic_commit which might fail. Which means that we need to have some > heuristics in cleanup_fb to figure out whether things failed, or > whether we just clean up the o

[Intel-gfx] [PATCH i-g-t] demos/intel_sprite_on: Fix connector iteration bug

2016-06-13 Thread Jim Bride
Instead of looping until the first disconnected port is found, now go through all possible connectors, drawing the sprite on any connected display. Signed-off-by: Jim Bride --- demos/intel_sprite_on.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/demos/intel_sprite_on

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gen9: Compute data rates for all planes on first commit

2016-06-13 Thread Daniel Vetter
On Thu, Jun 09, 2016 at 03:14:54PM -0700, Matt Roper wrote: > When we sanitize our DDB and watermark info during the first atomic > commit, we need to calculate the total data rate. Since we haven't > explicitly added the planes for each CRTC to our atomic state, the total > data rate calculation

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gen9: Initialize intel_state->active_crtcs during WM sanitization

2016-06-13 Thread Daniel Vetter
On Thu, Jun 09, 2016 at 03:14:53PM -0700, Matt Roper wrote: > intel_state->active_crtcs is usually only initialized when doing a > modeset. During our first atomic commit after boot, we're effectively > faking a modeset to sanitize the DDB/wm setup, so ensure that this field > gets initialized bef

Re: [Intel-gfx] [PATCH] drm/i915: Force vblanks around evasion when i915.watermark_test is set.

2016-06-13 Thread Daniel Vetter
On Thu, Jun 09, 2016 at 01:36:50PM +0200, Maarten Lankhorst wrote: > This will make it more likely that intermediary watermarks cause fifo > underruns, which is useful when writing watermark specific tests, > to make it more likely to trigger FIFO underruns in intermediary watermarks. That's surpr

Re: [Intel-gfx] [RESENT PATCH] drm/i915: use #defines for qemu subsystem ids

2016-06-13 Thread Jani Nikula
On Mon, 13 Jun 2016, Jani Nikula wrote: > On Mon, 13 Jun 2016, Gerd Hoffmann wrote: >> Signed-off-by: Gerd Hoffmann > > Reviewed-by: Jani Nikula And pushed to drm-intel-next-queued, thanks for the patch. BR, Jani. > > >> --- >> drivers/gpu/drm/i915/i915_drv.c | 6 -- >> 1 file changed,

[Intel-gfx] ✗ Ro.CI.BAT: failure for series starting with [1/5] drm/i915: Signal drm events for atomic

2016-06-13 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Signal drm events for atomic URL : https://patchwork.freedesktop.org/series/8632/ State : failure == Summary == Series 8632v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/8632/revisions/1/mbox Tes

Re: [Intel-gfx] [patch] drm/i915/mocs: || vs | typo in get_mocs_settings()

2016-06-13 Thread Mika Kuoppala
Dan Carpenter writes: > It seems pretty clear that bitwise OR was intended here and not logical > OR. > > Fixes: 6fc29133eafb ('drm/i915/gen9: Add WaDisableSkipCaching') > Signed-off-by: Dan Carpenter Pushed to drm-intel-next-queued. Thanks for patch. -Mika > > diff --git a/drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on FIFO underruns

2016-06-13 Thread Zanoni, Paulo R
Em Seg, 2016-06-13 às 13:47 +0200, Stefan Richter escreveu: > On Jun 10 Paulo Zanoni wrote: > > > > Since my test machines don't produce FIFO underrun errors, I tested > > this by > > creating a debugfs file that just calls > > intel_fbc_handle_fifo_underrun(). I'd > > appreciate some Tested-by ta

Re: [Intel-gfx] [PATCH] drm/i915: Don't unregister fbdev twice

2016-06-13 Thread Daniel Vetter
On Wed, Jun 08, 2016 at 07:03:02PM +0200, Lukas Wunner wrote: > On Wed, Jun 08, 2016 at 02:09:40PM +0200, Daniel Vetter wrote: > > On Wed, Jun 08, 2016 at 01:15:22PM +0200, Lukas Wunner wrote: > > > Calling drm_framebuffer_unregister_private() in intel_fbdev_destroy() is > > > superfluous because t

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Add output_types bitmask into the crtc state

2016-06-13 Thread Daniel Vetter
On Wed, Jun 08, 2016 at 01:41:38PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Rather than looping through encoders to see which encoder types > are being driven by the pipe, add an output_types bitmask into > the crtc state and populate it prior to compute_config and du

[Intel-gfx] ✗ Ro.CI.BAT: failure for series starting with [v2,RESEND,1/6] drm/i915/bxt: Wait for PHY1 GRC calibration synchronously

2016-06-13 Thread Patchwork
== Series Details == Series: series starting with [v2,RESEND,1/6] drm/i915/bxt: Wait for PHY1 GRC calibration synchronously URL : https://patchwork.freedesktop.org/series/8627/ State : failure == Summary == Series 8627v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/ser

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Crop cursor image for CHV pipe C cursor issue

2016-06-13 Thread Daniel Vetter
On Fri, Jun 10, 2016 at 03:14:36PM +0530, Agrawal, Akshu wrote: > On 6/8/2016 2:10 PM, Daniel Vetter wrote: > > On Wed, Jun 08, 2016 at 01:57:44PM +0530, Akshu Agrawal wrote: > > > CHV pipe C hits underrun when we get -ve X values of cursor. To avoid > > > this we crop the cursor image for by -ve X

Re: [Intel-gfx] [PATCH 29/38] drm/i915: Remove locking for get_tiling

2016-06-13 Thread Daniel Vetter
On Wed, Jun 08, 2016 at 11:11:07AM +0100, Chris Wilson wrote: > On Wed, Jun 08, 2016 at 12:02:01PM +0200, Daniel Vetter wrote: > > On Fri, Jun 03, 2016 at 05:55:44PM +0100, Chris Wilson wrote: > > > Since we are not concerned with userspace racing itself with set-tiling > > > (the order is indeterm

[Intel-gfx] [PATCH 3/5] drm/i915: nonblocking commit

2016-06-13 Thread Daniel Vetter
Simply split intel_atomic_commit in half and place the new nonblocking commit helpers at the right spots. NOTE: There's still trouble with obj->frontbuffer bits getting mangled when pipelining atomic commits. v2: - Remove the check for nonblocking which returned -EINVAL. - Do wait for requests in

[Intel-gfx] [PATCH 4/5] drm/i915: Move fb_bits updating later in atomic_commit

2016-06-13 Thread Daniel Vetter
Currently it's part of prepare_fb, still in the first phase of atomic_commit which might fail. Which means that we need to have some heuristics in cleanup_fb to figure out whether things failed, or whether we just clean up the old fbs. That's fragile, and worse, once we start pipelining commits ge

[Intel-gfx] [PATCH 5/5] drm/i915: Use atomic commits for legacy page_flips

2016-06-13 Thread Daniel Vetter
Note that I didn't start garbage collecting all the legacy flip code yet, to make it easier to revert this. But there will be _lots_ of code that can be removed once this is tested on all platforms. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 3 ++- 1 file changed, 2

[Intel-gfx] [PATCH 2/5] drm/i915: Roll out the helper nonblock tracking

2016-06-13 Thread Daniel Vetter
Right now still all blocking, no worker anywhere to be seen. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index a4eb

[Intel-gfx] [PATCH 1/5] drm/i915: Signal drm events for atomic

2016-06-13 Thread Daniel Vetter
This is part of what atomic must implement. And it's also required to be able to use the helper nonblocking support. v2: Always send out the drm event, remove the planes_changed check. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 13 ++--- drivers/gpu/drm/i915

Re: [Intel-gfx] ✗ Ro.CI.BAT: warning for drm/i915/gen9: implement WaConextSwitchWithConcurrentTLBInvalidate (rev3)

2016-06-13 Thread Tvrtko Ursulin
On 13/06/16 14:35, Gore, Tim wrote: Tim Gore Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ -Original Message- From: Patchwork [mailto:patchw...@emeril.freedesktop.org] Sent: Monday, June 13, 2016 12:40 PM To: Gore, Tim Cc: intel-gfx@lists.freedesktop.o

[Intel-gfx] [PATCH i-g-t 2/2] tests/kms_rmfb: Use for_each_pipe_with_valid_output.

2016-06-13 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- tests/kms_rmfb.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/kms_rmfb.c b/tests/kms_rmfb.c index a3fde9f43788..89aa323210dd 100644 --- a/tests/kms_rmfb.c +++ b/tests/kms_rmfb.c @@ -144,12 +144,9 @@ run_rmfb_test(struct rm

[Intel-gfx] [PATCH i-g-t 1/2] lib/igt_kms: Add for_each_pipe_with_valid_output and for_each_valid_output_on_pipe.

2016-06-13 Thread Maarten Lankhorst
There are a lot of places where we do either for_each_pipe { igt_subtest_f(... "-pipe-C", pipe_name()) for_each_connected_output() /* Run subtest */ } or: igt_subtest_f(...) { for_each_pipe() for_each_connected_output()

Re: [Intel-gfx] [PATCH i-g-t 2/2] tests/kms_chv_cursor_fail: Run the tests with fewer steps.

2016-06-13 Thread Maarten Lankhorst
Op 08-06-16 om 16:52 schreef Ville Syrjälä: > On Wed, Jun 08, 2016 at 04:47:48PM +0200, Maarten Lankhorst wrote: >> Op 08-06-16 om 15:35 schreef Ville Syrjälä: >>> On Wed, Jun 08, 2016 at 03:23:33PM +0200, Maarten Lankhorst wrote: Op 08-06-16 om 15:12 schreef Ville Syrjälä: > On Wed, Jun 0

[Intel-gfx] [PATCH v2 RESEND 2/6] drm/i915: Factor out intel_power_well_get/put

2016-06-13 Thread Imre Deak
These helpers will be needed by the next patch, so factor them out. No functional change. v2: - Move the refcount==0 WARN to the new put helper. (Ville) CC: Ville Syrjälä Signed-off-by: Imre Deak Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_runtime_pm.c | 33

[Intel-gfx] [PATCH v2 RESEND 3/6] drm/i915/bxt: Move DDI PHY enabling/disabling to the power well code

2016-06-13 Thread Imre Deak
So far we depended on the HW to dynamically power down unused PHYs and so we enabled them manually once during driver loading/resuming. There are indications however that we can achieve better power savings by manual powering toggling. So make the PHY enabling/disabling to happen on-demand whenever

[Intel-gfx] [PATCH v2 RESEND 5/6] drm/i915/bxt: Rename broxton to bxt in PHY/CDCLK function prefixes

2016-06-13 Thread Imre Deak
Rename these remaining function prefixes to better align with the corresponding SKL functions. No functional change. Signed-off-by: Imre Deak Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_ddi.c| 13 ++--- drivers/gpu/drm/i915/intel_display.c| 28 ++--

[Intel-gfx] [PATCH v2 RESEND 4/6] drm/i915/bxt: Set DDI PHY lane latency optimization during modeset

2016-06-13 Thread Imre Deak
So far we configured a static lane latency optimization during driver loading/resuming. The specification changed at one point and now this configuration depends on the lane count, so move the configuration to modeset time accordingly. It's not clear when this lane configuration takes effect. The

[Intel-gfx] [PATCH v2 RESEND 6/6] drm/i915/bxt: Sanitiy check the PHY lane power down status

2016-06-13 Thread Imre Deak
We can check the power state of the PHY data and common lanes as reported by the PHY. Do this in case we need to debug problems where the PHY gets stuck in an unexpected state. Note that I only check these when the lanes are expected to be powered on purpose, since it's not clear at what point the

[Intel-gfx] [PATCH v2 RESEND 1/6] drm/i915/bxt: Wait for PHY1 GRC calibration synchronously

2016-06-13 Thread Imre Deak
A follow-up patch moves the PHY enabling to the power well code where enabling/disabling the PHYs will happen independently. Because of this waiting for the GRC calibration in PHY1 asynchronously would need some additional logic. Instead of adding that let's keep things simple for now and wait sync

Re: [Intel-gfx] ✗ Ro.CI.BAT: warning for drm/i915/gen9: implement WaConextSwitchWithConcurrentTLBInvalidate (rev3)

2016-06-13 Thread Gore, Tim
Tim Gore  Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ > -Original Message- > From: Patchwork [mailto:patchw...@emeril.freedesktop.org] > Sent: Monday, June 13, 2016 12:40 PM > To: Gore, Tim > Cc: intel-gfx@lists.freedesktop.org > Subject: ✗ Ro.CI.BAT: wa

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Allow DP ports to set/readout infoframe state (WIP)

2016-06-13 Thread Sharma, Shashank
Regards Shashank On 6/3/2016 1:25 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä The video DIP can be used with DP ports as well. So let's at least read out the state, and disable all infoframes when disabling the port. Otherwise we might get left with whatever the previous guy w

Re: [Intel-gfx] [PATCH] drm/i915: pwrite/pread do not require obj->base.filp, just pages

2016-06-13 Thread Chris Wilson
On Mon, Jun 13, 2016 at 02:12:46PM +0100, Tvrtko Ursulin wrote: > > On 13/06/16 13:52, Chris Wilson wrote: > >On Mon, Jun 13, 2016 at 01:45:56PM +0100, Tvrtko Ursulin wrote: > >> > >>On 13/06/16 13:40, Chris Wilson wrote: > >>>The idea behind relaxing the restriction for pread/pwrite was to handle

[Intel-gfx] [PATCH i-g-t] tests/drv_missed_irq_hang: Fix gem_blt path

2016-06-13 Thread Mika Kuoppala
Don't add SOURCE_DIR to the path for gem_blt as if this script is invocated on some other directory, the path to gem_blt will be concatenated two times. References: https://bugs.freedesktop.org/show_bug.cgi?id=88437 Cc: Chris Wilson Signed-off-by: Mika Kuoppala --- tests/drv_missed_irq_hang | 4

Re: [Intel-gfx] [PATCH v10 00/10] Introduce the implementation of GVT context

2016-06-13 Thread Wang, Zhi A
Also CC Daniel. I have got "Reviewed-by" and passed the ABAT tests. Is there anything I should do before patches get picked? Thanks, Zhi. > -Original Message- > From: Wang, Zhi A > Sent: Monday, June 13, 2016 4:17 PM > To: intel-gfx@lists.freedesktop.org > Cc: ch...@chris-wilson.co.uk; L

Re: [Intel-gfx] [RESENT PATCH] drm/i915: use #defines for qemu subsystem ids

2016-06-13 Thread Jani Nikula
On Mon, 13 Jun 2016, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index f

Re: [Intel-gfx] [PATCH v10 00/10] Introduce the implementation of GVT context

2016-06-13 Thread Wang, Zhi A
Hi Chris: As Joonas is on vacation, can you pick my patches? or if you have some comments I can continue improving them. Thanks, Zhi. > -Original Message- > From: Wang, Zhi A > Sent: Thursday, June 09, 2016 9:44 PM > To: intel-gfx@lists.freedesktop.org > Cc: ch...@chris-wilson.co.uk;

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Remove mostly duplicated video DIP handling from PSR code

2016-06-13 Thread Sharma, Shashank
Regards Shashank On 6/13/2016 5:57 PM, Ville Syrjälä wrote: On Mon, Jun 13, 2016 at 05:39:47PM +0530, Sharma, Shashank wrote: Regards Shashank On 6/3/2016 1:25 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Now that the infoframe hooks are part of the intel_dig_port, we can us

Re: [Intel-gfx] [PATCH] drm/i915: pwrite/pread do not require obj->base.filp, just pages

2016-06-13 Thread Tvrtko Ursulin
On 13/06/16 13:52, Chris Wilson wrote: On Mon, Jun 13, 2016 at 01:45:56PM +0100, Tvrtko Ursulin wrote: On 13/06/16 13:40, Chris Wilson wrote: The idea behind relaxing the restriction for pread/pwrite was to handle !obj->base.flip, i.e. non-shmemfs backed objects, which only requires that the

[Intel-gfx] ✗ Ro.CI.BAT: failure for series starting with drm/i915: pwrite/pread do not require obj->base.filp, just pages (rev3)

2016-06-13 Thread Patchwork
== Series Details == Series: series starting with drm/i915: pwrite/pread do not require obj->base.filp, just pages (rev3) URL : https://patchwork.freedesktop.org/series/8528/ State : failure == Summary == Applying: drm/i915: pwrite/pread do not require obj->base.filp, just pages Applying: drm

[Intel-gfx] ✗ Ro.CI.BAT: warning for drm/i915: use #defines for qemu subsystem ids (rev2)

2016-06-13 Thread Patchwork
== Series Details == Series: drm/i915: use #defines for qemu subsystem ids (rev2) URL : https://patchwork.freedesktop.org/series/2918/ State : warning == Summary == Series 2918v2 drm/i915: use #defines for qemu subsystem ids http://patchwork.freedesktop.org/api/1.0/series/2918/revisions/2/mbox

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Move infoframe vfuncs into intel_digital_port

2016-06-13 Thread Sharma, Shashank
Reviewed-by: Shashank Sharma Regards Shashank On 6/13/2016 5:55 PM, Ville Syrjälä wrote: On Mon, Jun 13, 2016 at 03:47:13PM +0530, Sharma, Shashank wrote: Regards Shashank On 6/3/2016 1:25 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä DP ports will also want to utilize the vi

Re: [Intel-gfx] [PATCH] drm/i915: pwrite/pread do not require obj->base.filp, just pages

2016-06-13 Thread Chris Wilson
On Mon, Jun 13, 2016 at 01:45:56PM +0100, Tvrtko Ursulin wrote: > > On 13/06/16 13:40, Chris Wilson wrote: > >The idea behind relaxing the restriction for pread/pwrite was to handle > >!obj->base.flip, i.e. non-shmemfs backed objects, which only requires > >that the object provide struct pages. >

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Disable infoframes when shutting down DDI HDMI

2016-06-13 Thread Sharma, Shashank
Ok, apart from this, looks good to me. Reviewed-by: Shashank Sharma Regards Shashank On 6/13/2016 5:54 PM, Ville Syrjälä wrote: On Mon, Jun 13, 2016 at 03:36:19PM +0530, Sharma, Shashank wrote: Regards Shashank On 6/3/2016 1:25 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä D

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Check has_infoframes when enabling infoframes

2016-06-13 Thread Sharma, Shashank
Regards Shashank On 6/13/2016 5:54 PM, Ville Syrjälä wrote: On Mon, Jun 13, 2016 at 01:40:50PM +0530, Sharma, Shashank wrote: Regards Shashank On 6/3/2016 1:25 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä has_infoframe is what tells us whether infoframes should be enabled, s

Re: [Intel-gfx] [PATCH] drm/i915: pwrite/pread do not require obj->base.filp, just pages

2016-06-13 Thread Tvrtko Ursulin
On 13/06/16 13:40, Chris Wilson wrote: The idea behind relaxing the restriction for pread/pwrite was to handle !obj->base.flip, i.e. non-shmemfs backed objects, which only requires that the object provide struct pages. v2: Remove excess (). Note enough editing after copy'n'paste. Signed-off-by

[Intel-gfx] [PATCH] drm/i915: pwrite/pread do not require obj->base.filp, just pages

2016-06-13 Thread Chris Wilson
The idea behind relaxing the restriction for pread/pwrite was to handle !obj->base.flip, i.e. non-shmemfs backed objects, which only requires that the object provide struct pages. v2: Remove excess (). Note enough editing after copy'n'paste. Signed-off-by: Chris Wilson Cc: Ankitprasad Sharma Cc

[Intel-gfx] [RESENT PATCH] drm/i915: use #defines for qemu subsystem ids

2016-06-13 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- drivers/gpu/drm/i915/i915_drv.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index f313b4d..3099390 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/drivers/gpu/drm/i9

[Intel-gfx] ✗ Ro.CI.BAT: failure for series starting with drm/i915: pwrite/pread do not require obj->base.filp, just pages (rev2)

2016-06-13 Thread Patchwork
== Series Details == Series: series starting with drm/i915: pwrite/pread do not require obj->base.filp, just pages (rev2) URL : https://patchwork.freedesktop.org/series/8528/ State : failure == Summary == Applying: drm/i915: pwrite/pread do not require obj->base.filp, just pages Applying: drm

[Intel-gfx] [PATCH] drm/i915: pwrite/pread do not require obj->base.filp, just pages

2016-06-13 Thread Chris Wilson
The idea behind relaxing the restriction for pread/pwrite was to handle !obj->base.flip, i.e. non-shmemfs backed objects, which only requires that the object provide struct pages. Signed-off-by: Chris Wilson Cc: Ankitprasad Sharma Cc: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c | 7

Re: [Intel-gfx] [drm:intel_set_cpu_fifo_underrun_reporting]

2016-06-13 Thread Petko Manolov
On 16-06-13 13:29:46, Petko Manolov wrote: > Hello guys, > > Running xorg on my Lenovo Yoga 2 Pro (MY2013) on recent kernels turn into a > major PITA. After a couple of minutes the screen starts to flicker and only > killing xorg or reboot fixes the problem. This is what i typically see

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Remove mostly duplicated video DIP handling from PSR code

2016-06-13 Thread Ville Syrjälä
On Mon, Jun 13, 2016 at 05:39:47PM +0530, Sharma, Shashank wrote: > Regards > Shashank > > On 6/3/2016 1:25 AM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Now that the infoframe hooks are part of the intel_dig_port, we can use > > the normal .write_infoframe() hook to up

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Move infoframe vfuncs into intel_digital_port

2016-06-13 Thread Ville Syrjälä
On Mon, Jun 13, 2016 at 03:47:13PM +0530, Sharma, Shashank wrote: > Regards > Shashank > > On 6/3/2016 1:25 AM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > DP ports will also want to utilize the video DIP for SDP transmission. > > So let's move the vfuncs into the dig_por

Re: [Intel-gfx] [PATCH 3/7] drm/i915: Disable infoframes when shutting down DDI HDMI

2016-06-13 Thread Ville Syrjälä
On Mon, Jun 13, 2016 at 03:36:19PM +0530, Sharma, Shashank wrote: > Regards > Shashank > > On 6/3/2016 1:25 AM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Disabling the video DIP when shutting the port down seems like a good > > idea. > > > > Bspec says: > > "When disabl

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Check has_infoframes when enabling infoframes

2016-06-13 Thread Ville Syrjälä
On Mon, Jun 13, 2016 at 01:40:50PM +0530, Sharma, Shashank wrote: > Regards > Shashank > > On 6/3/2016 1:25 AM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > has_infoframe is what tells us whether infoframes should be enabled, so > > let's pass that instead of has_hdmi_sink

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Remove mostly duplicated video DIP handling from PSR code

2016-06-13 Thread Sharma, Shashank
Regards Shashank On 6/3/2016 1:25 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Now that the infoframe hooks are part of the intel_dig_port, we can use the normal .write_infoframe() hook to update the VSC SDP. We do need to deal with the size difference between the VSC DIP and t

Re: [Intel-gfx] [PATCH v3] drm/i915/gen9: implement WaConextSwitchWithConcurrentTLBInvalidate

2016-06-13 Thread Arun Siluvery
On 13/06/2016 16:45, tim.g...@intel.com wrote: From: Tim Gore This patch enables a workaround for a mid thread preemption issue where a hardware timing problem can prevent the context restore from happening, leading to a hang. v2: move to gen9_init_workarounds (Arun) v3: move to start of gen9_

Re: [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on FIFO underruns

2016-06-13 Thread Stefan Richter
On Jun 10 Paulo Zanoni wrote: > Since my test machines don't produce FIFO underrun errors, I tested this by > creating a debugfs file that just calls intel_fbc_handle_fifo_underrun(). I'd > appreciate some Tested-by tags, if possible. Since May 8 I have been using 4.6.0-rc6 patched with drm-intel-

Re: [Intel-gfx] [PATCH 5/7] drm/i915: Init infoframe vfuncs for DP encoders as well

2016-06-13 Thread Sharma, Shashank
Reviewed-by: Shashank Sharma Regards Shashank On 6/3/2016 1:25 AM, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä DP ports may want to use the video DIP for SDP transmission, so let's initiialize the vfuncs for DP encoders as well. The only exception is port A eDP prior to HSW as th

[Intel-gfx] ✗ Ro.CI.BAT: warning for drm/i915/gen9: implement WaConextSwitchWithConcurrentTLBInvalidate (rev3)

2016-06-13 Thread Patchwork
== Series Details == Series: drm/i915/gen9: implement WaConextSwitchWithConcurrentTLBInvalidate (rev3) URL : https://patchwork.freedesktop.org/series/8487/ State : warning == Summary == Series 8487v3 drm/i915/gen9: implement WaConextSwitchWithConcurrentTLBInvalidate http://patchwork.freedeskt

[Intel-gfx] [PATCH v3] drm/i915/gen9: implement WaConextSwitchWithConcurrentTLBInvalidate

2016-06-13 Thread tim . gore
From: Tim Gore This patch enables a workaround for a mid thread preemption issue where a hardware timing problem can prevent the context restore from happening, leading to a hang. v2: move to gen9_init_workarounds (Arun) v3: move to start of gen9_init_workarounds (Arun) Signed-off-by: Tim Gore

[Intel-gfx] [drm:intel_set_cpu_fifo_underrun_reporting]

2016-06-13 Thread Petko Manolov
Hello guys, Running xorg on my Lenovo Yoga 2 Pro (MY2013) on recent kernels turn into a major PITA. After a couple of minutes the screen starts to flicker and only killing xorg or reboot fixes the problem. This is what i typically see in dmesg: [0.00] microcode: microcode up

Re: [Intel-gfx] [PATCH v2 5/6] drm/i915/guc: refactor doorbell management code

2016-06-13 Thread Tvrtko Ursulin
On 13/06/16 11:25, Dave Gordon wrote: On 13/06/16 10:48, Tvrtko Ursulin wrote: On 10/06/16 17:51, Dave Gordon wrote: This patch refactors the driver's handling and tracking of doorbells, in preparation for a later one which will resolve a suspend-resume issue. There are three resources to be

[Intel-gfx] ✓ Ro.CI.BAT: success for series starting with [RESEND,1/7] drm/i915/dsi: don't debug log "missing" sequences

2016-06-13 Thread Patchwork
== Series Details == Series: series starting with [RESEND,1/7] drm/i915/dsi: don't debug log "missing" sequences URL : https://patchwork.freedesktop.org/series/8611/ State : success == Summary == Series 8611v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/8611/re

Re: [Intel-gfx] [patch] drm/i915/mocs: || vs | typo in get_mocs_settings()

2016-06-13 Thread Mika Kuoppala
Dan Carpenter writes: > It seems pretty clear that bitwise OR was intended here and not logical > OR. > > Fixes: 6fc29133eafb ('drm/i915/gen9: Add WaDisableSkipCaching') > Signed-off-by: Dan Carpenter Reviewed-by: Mika Kuoppala > > diff --git a/drivers/gpu/drm/i915/intel_mocs.c > b/drivers/g

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915/opregion: proper handling of DIDL and CADL (rev3)

2016-06-13 Thread Patchwork
== Series Details == Series: drm/i915/opregion: proper handling of DIDL and CADL (rev3) URL : https://patchwork.freedesktop.org/series/4783/ State : failure == Summary == Series 4783v3 drm/i915/opregion: proper handling of DIDL and CADL http://patchwork.freedesktop.org/api/1.0/series/4783/revi

Re: [Intel-gfx] [PATCH v2 5/5] drm/i915/opregion: update cadl based on actually active outputs

2016-06-13 Thread kbuild test robot
-i915-opregion-proper-handling-of-DIDL-and-CADL/20160613-173347 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-rhel (attached as .config) compiler: gcc-4.9 (Debian 4.9.3-14) 4.9.3 reproduce: # save the attached .config to linux build tree make ARCH=x86_64

Re: [Intel-gfx] [PATCH v2 5/6] drm/i915/guc: refactor doorbell management code

2016-06-13 Thread Dave Gordon
On 13/06/16 10:48, Tvrtko Ursulin wrote: On 10/06/16 17:51, Dave Gordon wrote: This patch refactors the driver's handling and tracking of doorbells, in preparation for a later one which will resolve a suspend-resume issue. There are three resources to be managed: 1. Cachelines: a single line w

[Intel-gfx] [PATCH RESEND 3/7] drm/i915/dsi: add skip functions for spi and pmic elements

2016-06-13 Thread Jani Nikula
In sequence block v3 these are gracefully skipped anyway, but add the functions so we can have some debug breadcrumbs. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dsi_pa

[Intel-gfx] [PATCH RESEND 6/7] drm/i915/bios: log about presence of DSI sequences we do not run

2016-06-13 Thread Jani Nikula
Leave behind some debugging clues in case some panels don't work properly. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c index da5ed4a850b9..e2f47ff15

[Intel-gfx] [PATCH RESEND 7/7] drm/i915/dsi: double check element parsing against size if present

2016-06-13 Thread Jani Nikula
Be a little paranoid in case the specs change or something. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c index d078c57

[Intel-gfx] [PATCH RESEND 5/7] drm/i915/dsi: run backlight on/off sequences in panel enable/disable hooks

2016-06-13 Thread Jani Nikula
Based on the documentation alone, it's anyone's guess when exactly we should be running these sequences. Add them where it feels logical. The drm panel hooks don't currently offer us more granularity anyway. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++ 1 file

[Intel-gfx] [PATCH RESEND 4/7] drm/i915/dsi: run power on/off sequences in panel prepare/unprepare hooks

2016-06-13 Thread Jani Nikula
Based on the documentation alone, it's anyone's guess when exactly we should be running these sequences. Add them where it feels logical. The drm panel hooks don't currently offer us more granularity anyway. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 2 ++ 1 file

Re: [Intel-gfx] [PATCH v2 6/6] drm/i915/guc: (re)initialise doorbell h/w when enabling GuC submission

2016-06-13 Thread Tvrtko Ursulin
On 10/06/16 17:51, Dave Gordon wrote: During a hibernate/resume cycle, the whole system is reset, including the GuC and the doorbell hardware. Then the system is booted up, drivers are loaded, etc -- the GuC firmware may be loaded and set running at this point. But then, the booted kernel is rep

  1   2   >