Re: [Intel-gfx] [CI-ping 15/15] drm/i915: Late request cancellations are harmful

2016-04-22 Thread John Harrison
On 21/04/2016 14:04, John Harrison wrote: On 19/04/2016 13:35, Dave Gordon wrote: On 13/04/16 15:21, John Harrison wrote: On 13/04/2016 10:57, Daniel Vetter wrote: On Tue, Apr 12, 2016 at 09:03:09PM +0100, Chris Wilson wrote: Conceptually, each request is a record of a hardware transaction -

[Intel-gfx] [PATCH i-g-t] igt: Add intel_mst_decode utility

2016-04-22 Thread Jim Bride
The intel_mst_decode utility parses the i915_dp_mst_info debugfs node (either in-place or as a captured file via a command-line argument) and prints information about the MST topology in an easy to read, hierarchical format. If a file is not specified on the command-line then the utility will read

Re: [Intel-gfx] [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.

2016-04-22 Thread Marius Vlad
Think you can squash the last two into one (you're removing what you've added in the previous one). Also see https://lists.freedesktop.org/archives/intel-gfx/2016-March/090617.html. On Fri, Apr 22, 2016 at 05:25:00PM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > Add support f

Re: [Intel-gfx] [PATCH 16/16] drm/i915: Support for capturing MMIO register values

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 05:04:05PM +0530, sourab.gu...@intel.com wrote: > + if (i915.enable_execlists) { > + for (i = 0; i < num_mmio; i++) { > + uint32_t cmd; > + > + addr = mmio_addr + > + i * sizeof(dev_priv->per

Re: [Intel-gfx] [PATCH] mm/vmalloc: Keep a separate lazy-free list

2016-04-22 Thread Andrew Morton
On Fri, 15 Apr 2016 12:14:31 +0100 Chris Wilson wrote: > > > purge_fragmented_blocks() manages per-cpu lists, so that looks safe > > > under its own rcu_read_lock. > > > > > > Yes, it looks feasible to remove the purge_lock if we can relax sync. > > > > what is still left is waiting on vmap_are

[Intel-gfx] [PATCH i-g-t 4/7] kms_panel_fitting: Switched DRM format to a hardware agnostic alternative.

2016-04-22 Thread robert . foss
From: Robert Foss Changed the DRM format to LOCAL_DRM_FORMAT_MOD_NONE since it is hardware agnostic. Also fixed formatting/tabs. Signed-off-by: Robert Foss --- tests/kms_panel_fitting.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/kms_panel_fitting.c b/

[Intel-gfx] [PATCH i-g-t 3/7] kms_panel_fitting: Remove un-used variable.

2016-04-22 Thread robert . foss
From: Robert Foss ref_crc is never assigned or read, and can be safely removed. Signed-off-by: Robert Foss --- tests/kms_panel_fitting.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c index b64e829..dface97 100644 --- a/tests/kms_panel_

[Intel-gfx] [PATCH i-g-t 1/7] kms_panel_fitting: Remove un-read variable.

2016-04-22 Thread robert . foss
From: Robert Foss Remove devid from data_t since it is never read. Also remove one assignment to devid. Signed-off-by: Robert Foss --- tests/kms_panel_fitting.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c index 829d9cd..ab06d25 100

[Intel-gfx] [PATCH i-g-t 0/7] Improve kms_panel_fitting.

2016-04-22 Thread robert . foss
From: Robert Foss This series removes some dead code from kms_panel_fitting and enables support for LVDS and DSI connectors. Robert Foss (7): kms_panel_fitting: Remove un-read variable. kms_panel_fitting: Remove un-read variable pipe_crc. kms_panel_fitting: Remove un-used variable. kms_p

[Intel-gfx] [PATCH i-g-t 7/7] kms_panel_fitting: Add support for LVDS and DSI connectors.

2016-04-22 Thread robert . foss
From: Robert Foss Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI connectors. Signed-off-by: Robert Foss --- tests/kms_panel_fitting.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c index

[Intel-gfx] [PATCH i-g-t 5/7] kms_panel_fitting: Enabled test on non-Intel hardware.

2016-04-22 Thread robert . foss
From: Robert Foss Switched from DRIVER_INTEL to DRIVER_ANY to enable test on all hardware. Signed-off-by: Robert Foss --- tests/kms_panel_fitting.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/kms_panel_fitting.c b/tests/kms_panel_fitting.c index ec7ce21..2398a5e 1

[Intel-gfx] [PATCH i-g-t 2/7] kms_panel_fitting: Remove un-read variable pipe_crc.

2016-04-22 Thread robert . foss
From: Robert Foss pipe_crc in data_t is assigned an allocated memory space and then later free'd. But it is never used for any comparisons. It should therefore be safe to remove pipe_crc and the crc requirement. Signed-off-by: Robert Foss --- tests/kms_panel_fitting.c | 9 - 1 file cha

[Intel-gfx] [PATCH i-g-t 6/7] kms_panel_fitting: Don't skip test after finding an incompatible connector.

2016-04-22 Thread robert . foss
From: Robert Foss If an incompatible connector is found, don't skip the test, but rather keep looking for valid connectors. Signed-off-by: Robert Foss --- tests/kms_panel_fitting.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/kms_panel_fitting.c b/tests/kms_pa

[Intel-gfx] [PATCH 1/4] drm: Improve kerneldoc for new mode object refcounting

2016-04-22 Thread Daniel Vetter
Slipped through the cracks in my review. The one issue I spotted is that drm_mode_object_find now acquires references and can be used on FB objects, which caused follow-on bugs in get/set_prop ioctls. Follow-up patches will fix that. Cc: Dave Airlie Signed-off-by: Daniel Vetter --- drivers/gpu/

[Intel-gfx] [PATCH 2/4] drm: Fix fb leaks and WARN spew in get/set_prop ioctls

2016-04-22 Thread Daniel Vetter
Dave Airlie had at least the refcount leak fixed in a later patch (but that patch does other things which need a bit more work). But we still have the trouble that silly userspace could hit the WARN_ON in drm_mode_object_find. Fix this all up to make sure we don't leak objects, and don't spew into

[Intel-gfx] [PATCH 3/4] drm/atomic-helpers: Don't duplicate code in destroy helpers

2016-04-22 Thread Daniel Vetter
Random drive-by refactoring I spotted. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_atomic_helper.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c index 40c7b268a9bc..d25abce

[Intel-gfx] [PATCH 4/4] drm: Switch blobs to the new generic modeset obj refcounting

2016-04-22 Thread Daniel Vetter
Need to move the free function around a bit, but otherwise mostly just removing code. Specifically we can nuke all the _locked variants since the weak idr reference is now protected by the idr_mutex, which we never hold anywhere expect in the lookup/reg/unreg functions. And those never call anythi

Re: [Intel-gfx] [PATCH 15/16] drm/i915: Mechanism to forward clock monotonic time in perf samples

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 05:04:04PM +0530, sourab.gu...@intel.com wrote: > +static u64 get_current_gpu_ts(struct drm_i915_private *dev_priv) > +{ > + return ((u64)I915_READ(GT_TIMESTAMP_COUNT_UDW) << 32) | > + I915_READ(GT_TIMESTAMP_COUNT); return I915_READ64_2x32(GT_TIMESTAMP_COUN

[Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-04-22 Thread ville . syrjala
From: Ville Syrjälä GPIO lookup tables are supposed to be zero terminated. Let's do that and avoid accidentally walking off the end. Cc: Shobhit Kumar Cc: Samuel Ortiz Cc: Linus Walleij Cc: Alexandre Courbot Cc: Thierry Reding Cc: Lee Jones Cc: sta...@vger.kernel.org Fixes: 61dd2ca2d44e ("

Re: [Intel-gfx] [PATCH v2 15/16] drm/i915/gen9: Reject display updates that exceed wm limitations

2016-04-22 Thread Matt Roper
On Fri, Apr 22, 2016 at 10:21:20AM -0400, Lyude Paul wrote: > Unfortunately dropping that patch just results with the screen staying blank > starting from the moment the driver loads.  > > As for the external monitors question: the only time this issue seems to > happen > with this patchset is wh

Re: [Intel-gfx] [PATCH] lib: Always NUL terminate ucs2_as_utf8

2016-04-22 Thread Matt Fleming
On Thu, 21 Apr, at 06:21:11PM, Laszlo Ersek wrote: > > ... How about this instead? Your patch looks fine to me. I've gone ahead and stuck it in the urgent EFI queue. Thanks everyone! ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://li

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: default to using GuC submission where possible

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 07:45:15PM +0100, Chris Wilson wrote: > On Fri, Apr 22, 2016 at 07:22:55PM +0100, Dave Gordon wrote: > > This patch simply changes the default value of "enable_guc_submission" > > from 0 (never) to -1 (auto). This means that GuC submission will be > > used if the platform ha

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: default to using GuC submission where possible

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 07:22:55PM +0100, Dave Gordon wrote: > This patch simply changes the default value of "enable_guc_submission" > from 0 (never) to -1 (auto). This means that GuC submission will be > used if the platform has a GuC, the GuC supports the request submission > protocol, and any r

[Intel-gfx] [PATCH 1/2] drm/i915/guc: add enable_guc_loading parameter

2016-04-22 Thread Dave Gordon
Split the function of "enable_guc_submission" into two separate options. The new one ("enable_guc_loading") controls only the *fetching and loading* of the GuC firmware image. The existing one is redefined to control only the *use* of the GuC for batch submission once the firmware is loaded. In a

[Intel-gfx] [PATCH v3 2/3] drm/i915: Correct the i915_frequency_info debugfs output

2016-04-22 Thread akash . goel
From: Akash Goel There are certain registers, which captures the time elapsed in the in current Up/Down EI, for how long GT has been Idle/Busy/Avg in the current Up/Down EI and also in the previous Up/Down EI. These register values are reported by the i915_frequency_info debugfs interface. The Dr

[Intel-gfx] [PATCH v2 3/3] drm/i915/bxt: Explicitly clear the Turbo control register

2016-04-22 Thread akash . goel
From: Akash Goel As a part of WaGsvDisableTurbo, Driver makes an early exit from the Gen9 Turbo enabling function, so doesn't program the Turbo Control register. But BIOS could leave the Hw Turbo as enabled, so need to explicitly clear out the Control register just to avoid inconsitency with debu

[Intel-gfx] [PATCH 2/2] drm/i915/guc: default to using GuC submission where possible

2016-04-22 Thread Dave Gordon
This patch simply changes the default value of "enable_guc_submission" from 0 (never) to -1 (auto). This means that GuC submission will be used if the platform has a GuC, the GuC supports the request submission protocol, and any required GuC firmwware was successfully loaded. If any of these condit

[Intel-gfx] [PATCH 1/3] drm/i915: Macros to convert PM time interval values to microseconds

2016-04-22 Thread akash . goel
From: Akash Goel Added a new GT_PM_INTERVAL_TO_US macro to perform the platform specific conversion of PM time interval values to microseconds unit. Reviewed-by: Chris Wilson Signed-off-by: Akash Goel --- drivers/gpu/drm/i915/i915_reg.h | 9 + 1 file changed, 9 insertions(+) diff --g

[Intel-gfx] [PATCH] drm/i915: rename i915_gem_alloc_object() to i915_gem_object_create()

2016-04-22 Thread Dave Gordon
Because having both i915_gem_object_alloc() and i915_gem_alloc_object() (with different return conventions) is just too confusing! (i915_gem_object_alloc() is the low-level memory allocator, and remains unchanged, whereas i915_gem_alloc_object() is a constructor that ALSO initialises the newly-all

Re: [Intel-gfx] [RFC/PATCH xf86-video-intel] sna: Let modestting + glamor handle gen9+

2016-04-22 Thread Hans de Goede
Hi, On 22-04-16 15:17, Timo Aaltonen wrote: 08.04.2016, 16:21, Hans de Goede kirjoitti: Hi, Hi, sorry for the delay.. On 11-03-16 11:07, Timo Aaltonen wrote: I've been trying to make this work, but there are cases where it fails bad: # a config file with a Device section that loads 'inte

[Intel-gfx] [PATCH xf86-video-intel] Fix fd (and mem) leak when intel_scrn_create fails

2016-04-22 Thread Hans de Goede
The probe functions in intel_module.c call intel_open_device() before calling intel_scrn_create(), but if the later fails because of e.g. an unsupported (new) pci-id they were not cleaning up the resources claimed by intel_open_device(), esp. leaking the fd is a problem because this breaks the fall

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Make RPS EI/thresholds multiple of 25 on SNB

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 08:18:22PM +0300, Ville Syrjälä wrote: > On Thu, Apr 21, 2016 at 12:40:24PM -, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: Make RPS EI/thresholds multiple of 25 on SNB > > URL : https://patchwork.freedesktop.org/series/5987/ > > State : warning

Re: [Intel-gfx] [PATCH] drm: i915: Improve behavior in case of broken HDMI EDID

2016-04-22 Thread Ezequiel Garcia
On 22 April 2016 at 14:02, Daniel Vetter wrote: > On Fri, Apr 22, 2016 at 12:18:07PM -0300, Ezequiel Garcia wrote: >> On 22 Apr 10:15 AM, Daniel Vetter wrote: >> > On Thu, Apr 21, 2016 at 03:13:51PM -0300, Ezequiel Garcia wrote: >> > > Daniel, >> > > >> > > Thanks a lot for the quick reply! >> > >

Re: [Intel-gfx] [PATCH] drm/i915: Make RPS EI/thresholds multiple of 25 on SNB

2016-04-22 Thread Ville Syrjälä
On Thu, Apr 21, 2016 at 02:20:35PM +0200, Patrik Jakobsson wrote: > On Wed, Apr 20, 2016 at 04:43:56PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Somehow my SNB GT1 (Dell XPS 8300) gets very unhappy around > > GPU hangs if the RPS EI/thresholds aren't suitably ali

Re: [Intel-gfx] [PATCH v3] drm/i915: Fake HDMI live status

2016-04-22 Thread Ville Syrjälä
On Thu, Apr 21, 2016 at 04:48:32PM +0530, Shashank Sharma wrote: > This patch does the following: > - Fakes live status of HDMI as connected (even if that's not). > While testing certain (monitor + cable) combinations with > various intel platforms, it seems that live status register > doesn

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fake HDMI live status (rev3)

2016-04-22 Thread Ville Syrjälä
On Thu, Apr 21, 2016 at 04:54:28PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Fake HDMI live status (rev3) > URL : https://patchwork.freedesktop.org/series/6038/ > State : success > > == Summary == > > Series 6038v3 drm/i915: Fake HDMI live status > http://patchwork.f

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Make RPS EI/thresholds multiple of 25 on SNB

2016-04-22 Thread Ville Syrjälä
On Thu, Apr 21, 2016 at 12:40:24PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Make RPS EI/thresholds multiple of 25 on SNB > URL : https://patchwork.freedesktop.org/series/5987/ > State : warning > > == Summary == > > Series 5987v1 drm/i915: Make RPS EI/thresholds mul

Re: [Intel-gfx] [PATCH] drm: i915: Improve behavior in case of broken HDMI EDID

2016-04-22 Thread Daniel Vetter
On Fri, Apr 22, 2016 at 12:18:07PM -0300, Ezequiel Garcia wrote: > On 22 Apr 10:15 AM, Daniel Vetter wrote: > > On Thu, Apr 21, 2016 at 03:13:51PM -0300, Ezequiel Garcia wrote: > > > Daniel, > > > > > > Thanks a lot for the quick reply! > > > > > > On 20 Apr 01:34 PM, Daniel Vetter wrote: > > > >

Re: [Intel-gfx] [PATCH v5 4/4] drm/i915: Get rid of intel_dp_dpcd_read_wake()

2016-04-22 Thread Daniel Vetter
On Wed, Apr 13, 2016 at 10:58:33AM -0400, Lyude wrote: > Since we've fixed up drm_dp_dpcd_read() to allow for retries when things > timeout, there's no use for having this function anymore. Good riddens. > > Signed-off-by: Lyude All applied to drm-misc, thanks. -Daniel > --- > drivers/gpu/drm/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Cache DisplayPort link signal levels

2016-04-22 Thread Patchwork
== Series Details == Series: drm/i915: Cache DisplayPort link signal levels URL : https://patchwork.freedesktop.org/series/5973/ State : success == Summary == Series 5973v1 drm/i915: Cache DisplayPort link signal levels http://patchwork.freedesktop.org/api/1.0/series/5973/revisions/1/mbox/ b

Re: [Intel-gfx] [isg-gms] [PATCH] drm/i915: Get audio power domain during initial hw readout (v2)

2016-04-22 Thread Xiong, James
-Original Message- From: isg-gms-requ...@eclists.intel.com [mailto:isg-gms-requ...@eclists.intel.com] On Behalf Of Paauwe, Bob J Sent: Wednesday, April 20, 2016 1:38 PM To: isg-gms ; intel-gfx Cc: Paauwe, Bob J ; Ville Syrjälä Subject: [isg-gms] [PATCH] drm/i915: Get audio power doma

[Intel-gfx] ✓ Fi.CI.BAT: success for lib: Always NUL terminate ucs2_as_utf8

2016-04-22 Thread Patchwork
== Series Details == Series: lib: Always NUL terminate ucs2_as_utf8 URL : https://patchwork.freedesktop.org/series/5969/ State : success == Summary == Series 5969v1 lib: Always NUL terminate ucs2_as_utf8 http://patchwork.freedesktop.org/api/1.0/series/5969/revisions/1/mbox/ bdw-nuci7

Re: [Intel-gfx] [PATCH v6 00/34] GPU scheduler for i915 driver

2016-04-22 Thread John Harrison
This patch series can be pulled from 'ssh://people.freedesktop.org/~johnharr/scheduler' as the 'scheduler' branch. On 20/04/2016 18:13, john.c.harri...@intel.com wrote: From: John Harrison Implemented a batch buffer submission scheduler for the i915 DRM driver. The general theory of operat

Re: [Intel-gfx] [PATCH v7 0/8] Convert requests to use struct fence

2016-04-22 Thread John Harrison
This patch series can be pulled from 'ssh://people.freedesktop.org/~johnharr/scheduler' as the 'fence' branch. On 20/04/2016 18:09, john.c.harri...@intel.com wrote: From: John Harrison There is a construct in the linux kernel called 'struct fence' that is intended to keep track of work that

Re: [Intel-gfx] [PATCH] drm: i915: Improve behavior in case of broken HDMI EDID

2016-04-22 Thread Ezequiel Garcia
On 22 Apr 10:15 AM, Daniel Vetter wrote: > On Thu, Apr 21, 2016 at 03:13:51PM -0300, Ezequiel Garcia wrote: > > Daniel, > > > > Thanks a lot for the quick reply! > > > > On 20 Apr 01:34 PM, Daniel Vetter wrote: > > > On Tue, Apr 19, 2016 at 02:31:13PM -0300, Ezequiel Garcia wrote: > > > > Current

[Intel-gfx] [PATCH i-g-t 1/2] kms_flip: Shorten basic tests a bit

2016-04-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Seems like an overkill for a basic test to keep flipping for a full minute. Dial it down a bit. Signed-off-by: Tvrtko Ursulin --- tests/kms_flip.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 3d445440

[Intel-gfx] [PATCH i-g-t 2/2] kms_flip: Run basic tests only on one pipe

2016-04-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It brings enough value for the basic test set to check one connector with one pipe only, rather every connector with all possible pipes. Signed-off-by: Tvrtko Ursulin --- tests/kms_flip.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git

Re: [Intel-gfx] [PATCH i-g-t 1/2] kms_pipe_crc_basic: Only test one pipe in the basic set

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 03:41:55PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > I would argue it is enough to test one pipe in the BAT set. > > Signed-off-by: Tvrtko Ursulin > --- > tests/kms_pipe_crc_basic.c | 23 +-- > 1 file changed, 13 insertions(+), 10 delet

[Intel-gfx] [PATCH i-g-t 1/2] kms_pipe_crc_basic: Only test one pipe in the basic set

2016-04-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I would argue it is enough to test one pipe in the BAT set. Signed-off-by: Tvrtko Ursulin --- tests/kms_pipe_crc_basic.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c in

[Intel-gfx] [PATCH i-g-t 2/2] kms_pipe_crc_basic: Rename test to kms_pipe_crc

2016-04-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Previous patch has marked individual subtests as basic so now rename the test binary name accordingly. Signed-off-by: Tvrtko Ursulin --- tests/Makefile.sources | 2 +- tests/kms_pipe_crc.c | 246 + tests/kms_pipe_crc_

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Warn there are any unfreed contexts when we shutdown

2016-04-22 Thread Patchwork
== Series Details == Series: drm/i915: Warn there are any unfreed contexts when we shutdown URL : https://patchwork.freedesktop.org/series/6157/ State : failure == Summary == Series 6157v1 drm/i915: Warn there are any unfreed contexts when we shutdown http://patchwork.freedesktop.org/api/1.0/s

Re: [Intel-gfx] [PATCH] drm/i915: Make RPS EI/thresholds multiple of 25 on SNB

2016-04-22 Thread Ville Syrjälä
On Thu, Apr 21, 2016 at 02:20:35PM +0200, Patrik Jakobsson wrote: > On Wed, Apr 20, 2016 at 04:43:56PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Somehow my SNB GT1 (Dell XPS 8300) gets very unhappy around > > GPU hangs if the RPS EI/thresholds aren't suitably ali

Re: [Intel-gfx] [PATCH v2 15/16] drm/i915/gen9: Reject display updates that exceed wm limitations

2016-04-22 Thread Lyude Paul
Unfortunately dropping that patch just results with the screen staying blank starting from the moment the driver loads.  As for the external monitors question: the only time this issue seems to happen with this patchset is when there's no external monitors connected. If I boot with just the laptop

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix PHY init with partial BIOS config (rev2)

2016-04-22 Thread Ville Syrjälä
On Fri, Apr 22, 2016 at 04:37:29PM +0300, Imre Deak wrote: > On pe, 2016-04-22 at 07:27 +, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915/bxt: Fix PHY init with partial BIOS config (rev2) > > URL   : https://patchwork.freedesktop.org/series/6010/ > > State : failure > > >

[Intel-gfx] [PATCH i-g-t v2 3/6] lib/igt_kms: Fix plane counting in igt_display_init.

2016-04-22 Thread robert . foss
From: Robert Foss Fix issue where the plane counting fails due to the number and configuration of planes being unlike the intel configuration. Signed-off-by: Robert Foss --- lib/igt_kms.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c in

[Intel-gfx] [PATCH i-g-t v2 1/6] lib/igt_kms: Move IGT_MAX_PLANES into the igt_plane enum

2016-04-22 Thread robert . foss
From: Robert Foss Makes sure we automatically extend that when adding more planes. Inspired by a patch from Robert Foss who extended the max, but forgot all about the enum. While at it, also fix up the whitespace damage. Cc: robert.f...@collabora.com Author: Daniel Vetter Signed-off-by: Daniel

[Intel-gfx] [PATCH i-g-t v2 6/6] kms_vblank: Switch from using crtc0 statically to explicitly setting mode.

2016-04-22 Thread robert . foss
From: Robert Foss Previously crtc0 was statically used for VBLANK tests, but that assumption is not valid for the VC4 platform. Instead we're now explicitly setting the mode. Also add support for testing all connected connectors during the same test. Signed-off-by: Robert Foss --- tests/kms_v

[Intel-gfx] [PATCH i-g-t v2 0/6] kms_flip_event_leak and kms_vblank fixes for VC4

2016-04-22 Thread robert . foss
From: Robert Foss Changes since v1: - Removed un-used members of data_t struct in kms_vblank.c. - Renamed plane_counter to n_planes. - Removed un-needed handling CURSOR plane location. - Added names for additional planes in update kmstest_plane_name. Robert Foss (6): lib/igt_kms: Move IGT_MAX

[Intel-gfx] [PATCH i-g-t v2 2/6] lib/igt_kms: Add support for up to 10 planes.

2016-04-22 Thread robert . foss
From: Robert Foss Increase the number of planes supported to 10. kmstest_plane_name only previously supported 4 planes, this patch adds support for up to 10 planes. Signed-off-by: Robert Foss --- lib/igt_kms.c | 6 ++ lib/igt_kms.h | 11 ++- 2 files changed, 16 insertions(+), 1 d

[Intel-gfx] [PATCH i-g-t v2 4/6] lib/igt_kms: Switch to verbose assert.

2016-04-22 Thread robert . foss
From: Robert Foss Switch igt_assert to igt_assert_lte to provide more diagnostic information. Signed-off-by: Robert Foss --- lib/igt_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 5751913..99b6279 100644 --- a/lib/igt_kms.c +++ b/l

[Intel-gfx] [PATCH i-g-t v2 5/6] kms_flip_event_leak: Enable test on DRIVER_ANY.

2016-04-22 Thread robert . foss
From: Robert Foss Change DRIVER_INTEL to DRIVER_ANY to enable tests/kms_flip_event_leak on any driver. Switch the tiling format to something intel indenpendant. Signed-off-by: Robert Foss --- tests/kms_flip_event_leak.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Propagate error from drm_gem_object_init()

2016-04-22 Thread Joonas Lahtinen
On pe, 2016-04-22 at 12:59 +0100, Dave Gordon wrote: > On 22/04/16 11:57, Matthew Auld wrote: > > > > From: Chris Wilson > > > > Propagate the real error from drm_gem_object_init(). Note this also > > fixes some confusion in the error return from i915_gem_alloc_object... > > > > v2: > > (Matthe

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix PHY init with partial BIOS config (rev2)

2016-04-22 Thread Imre Deak
On pe, 2016-04-22 at 07:27 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/bxt: Fix PHY init with partial BIOS config (rev2) > URL   : https://patchwork.freedesktop.org/series/6010/ > State : failure > Thanks for the review I pushed the patchset to -dinq. Explanation for the f

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Canonicalize stolen memory calculations (rev2)

2016-04-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Canonicalize stolen memory calculations (rev2) URL : https://patchwork.freedesktop.org/series/6153/ State : warning == Summary == Series 6153v2 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/6153/re

[Intel-gfx] re Fi.CI.BAT: failure for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)

2016-04-22 Thread Gore, Tim
Fi.CI.BAT: failure output (BAT didn't send me an email - at least not yet. Cut and pasted from patchwork archive) > Series: drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4) > URL : https://patchwork.freedesktop.org/series/5990/ > State : failure > Series 5990v4 drm/i915:bxt: im

[Intel-gfx] [RFC] x86/e820: Add E820_RESERVED_GFX for graphics memory

2016-04-22 Thread Joonas Lahtinen
Add a type of memory alongside E820_RESERVED_KERN that is specifically reserved for graphics usage, E820_RESERVED_GFX. An example is Intel Gen graphics stolen memory. Cc: Chris Wilson Signed-off-by: Joonas Lahtinen --- arch/x86/include/uapi/asm/e820.h | 5 + arch/x86/kernel/e820.c

Re: [Intel-gfx] [PATCH i-g-t] tests: atomic: add test to verify page flip event emissions

2016-04-22 Thread Lionel Landwerlin
On 22/04/16 13:59, Daniel Vetter wrote: On Thu, Apr 21, 2016 at 05:01:31PM +0100, Lionel Landwerlin wrote: It seems we don't have a test verifying events with atomic commits yet. Here is a first step. Cc: Maarten Lankhorst Signed-off-by: Lionel Landwerlin Feel like also making a testcase var

Re: [Intel-gfx] [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown

2016-04-22 Thread Joonas Lahtinen
On pe, 2016-04-22 at 14:03 +0100, Chris Wilson wrote: > When tearing down the device, emit a warning if there are any contexts > remaining, as they all should be freed by this point. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen Reviewed-by: Jo

Re: [Intel-gfx] [PATCH i-g-t 3/7] lib/igt_kms: Make sure that default planes aren't overwritten.

2016-04-22 Thread Robert Foss
On 04/22/2016 08:53 AM, Daniel Vetter wrote: On Thu, Apr 21, 2016 at 01:31:48PM -0400, Robert Foss wrote: On 04/21/2016 10:50 AM, Daniel Vetter wrote: On Wed, Apr 20, 2016 at 10:59:45AM -0400, robert.f...@collabora.com wrote: From: Robert Foss Avoid overwriting planes with statically asig

Re: [Intel-gfx] [RFC/PATCH xf86-video-intel] sna: Let modestting + glamor handle gen9+

2016-04-22 Thread Timo Aaltonen
08.04.2016, 16:21, Hans de Goede kirjoitti: > Hi, Hi, sorry for the delay.. > On 11-03-16 11:07, Timo Aaltonen wrote: >> >> I've been trying to make this work, but there are cases where it fails >> bad: >> >> # a config file with a Device section that loads 'intel' makes the >> server fail >> [

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix PHY init with partial BIOS config

2016-04-22 Thread Imre Deak
On to, 2016-04-21 at 12:05 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/bxt: Fix PHY init with partial BIOS config > URL   : https://patchwork.freedesktop.org/series/6010/ > State : failure > > == Summary == > > Series 6010v1 drm/i915/bxt: Fix PHY init with partial BIOS co

Re: [Intel-gfx] [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown

2016-04-22 Thread Daniel Vetter
On Fri, Apr 22, 2016 at 02:03:02PM +0100, Chris Wilson wrote: > When tearing down the device, emit a warning if there are any contexts > remaining, as they all should be freed by this point. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen I guess

[Intel-gfx] [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown

2016-04-22 Thread Chris Wilson
When tearing down the device, emit a warning if there are any contexts remaining, as they all should be freed by this point. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Tvrtko Ursulin Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_gem_context.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fixes for runtime and system suspend/resume

2016-04-22 Thread Imre Deak
On to, 2016-04-21 at 12:05 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/bxt: Fixes for runtime and system suspend/resume > URL   : https://patchwork.freedesktop.org/series/6009/ > State : failure > > == Summary == There was a previous email with 'success' for this same tes

Re: [Intel-gfx] [PATCH] kms_atomic: Fix crtc_id comparison failing.

2016-04-22 Thread Daniel Vetter
On Fri, Apr 22, 2016 at 12:54:59PM +0300, Marius Vlad wrote: > You've already sent this yesterday. Its pushed. When you push patches (especially from other people), please send out a quick confirmation mail to the mailing list. Avoids confusion like this one here. -Daniel > > On Thu, Apr 21, 201

Re: [Intel-gfx] [PATCH i-g-t] tests: atomic: add test to verify page flip event emissions

2016-04-22 Thread Daniel Vetter
On Thu, Apr 21, 2016 at 05:01:31PM +0100, Lionel Landwerlin wrote: > It seems we don't have a test verifying events with atomic commits > yet. Here is a first step. > > Cc: Maarten Lankhorst > Signed-off-by: Lionel Landwerlin Feel like also making a testcase variant for the other cases of crtc'

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Macros to convert PM time interval values to microseconds

2016-04-22 Thread Daniel Vetter
On Fri, Apr 22, 2016 at 05:22:24PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > Added a new GT_PM_INTERVAL_TO_US macro to perform the platform > specific conversion of PM time interval values to microseconds unit. > > Signed-off-by: Akash Goel Note that if you submit a new series

Re: [Intel-gfx] [PATCH i-g-t 4/7] lib/igt_kms: Only move the in cursor plane for Intel hw.

2016-04-22 Thread Daniel Vetter
On Thu, Apr 21, 2016 at 01:24:53PM -0400, Robert Foss wrote: > > > On 04/21/2016 10:48 AM, Daniel Vetter wrote: > >On Wed, Apr 20, 2016 at 10:59:46AM -0400, robert.f...@collabora.com wrote: > >>From: Robert Foss > >> > >>Avoid moving the cursor plane when on non-intel hardware. > >>Running the m

Re: [Intel-gfx] [PATCH i-g-t 3/7] lib/igt_kms: Make sure that default planes aren't overwritten.

2016-04-22 Thread Daniel Vetter
On Thu, Apr 21, 2016 at 01:31:48PM -0400, Robert Foss wrote: > > > On 04/21/2016 10:50 AM, Daniel Vetter wrote: > >On Wed, Apr 20, 2016 at 10:59:45AM -0400, robert.f...@collabora.com wrote: > >>From: Robert Foss > >> > >>Avoid overwriting planes with statically asigned indices > >>with planes th

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt

2016-04-22 Thread Patchwork
== Series Details == Series: drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt URL : https://patchwork.freedesktop.org/series/6152/ State : failure == Summary == Series 6152v1 drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt http://patchwork.freedesktop.org/api/1.0/series/6152/r

Re: [Intel-gfx] [PATCH] drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt

2016-04-22 Thread Joonas Lahtinen
On pe, 2016-04-22 at 12:09 +0100, Matthew Auld wrote: > Remove dev local and use to_i915() in gen8_ppgtt_notify_vgt. > > v2: use dev_priv directly for QUESTION_MACROS (Joonas Lahtinen) > > Cc: Joonas Lahtinen > Signed-off-by: Matthew Auld > Reviewed-by: Joonas Lahtinen Merged, thanks for the

[Intel-gfx] [PATCH v2 2/2] drm/i915: Function per early graphics quirk

2016-04-22 Thread Joonas Lahtinen
Move graphics stolen memory related early quirk into a function to allow easy adding of other graphics quirks to fix memory maps on machines running old BIOS versions. While at it; - _funcs -> _ops to follow de facto naming - make the iteration code tad more readable - remove unused variables Cc:

[Intel-gfx] [PATCH v2 1/2] drm/i915: Canonicalize stolen memory calculations

2016-04-22 Thread Joonas Lahtinen
Move the better constructs/comments from i915_gem_stolen.c to early-quirks.c and increase readability in preparation of only having one set of functions. - intel_stolen_base -> gen3_stolen_base - use phys_addr_t instead of u32 for address for future proofing v2: - Print the invalid register value

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Function per early graphics quirk

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 03:07:42PM +0300, Joonas Lahtinen wrote: > On pe, 2016-04-22 at 12:55 +0100, Chris Wilson wrote: > > On Fri, Apr 22, 2016 at 02:25:07PM +0300, Joonas Lahtinen wrote: > > > > > > Move graphics stolen memory related early quirk into a function to > > > allow easy adding of ot

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Call intel_unpin_fb_obj() on release

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 12:59:12PM +0100, Tvrtko Ursulin wrote: > > On 22/04/16 10:00, Chris Wilson wrote: > >Something about CI results being hidden and not seeing the same failures > >locally... > > Didn't really understand any of that. Is think blocking the > premature unpin series? Is the war

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Function per early graphics quirk

2016-04-22 Thread Joonas Lahtinen
On pe, 2016-04-22 at 12:55 +0100, Chris Wilson wrote: > On Fri, Apr 22, 2016 at 02:25:07PM +0300, Joonas Lahtinen wrote: > > > > Move graphics stolen memory related early quirk into a function to > > allow easy adding of other graphics quirks to fix memory maps on > > machines running old BIOS ver

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Correct the i915_frequency_info debugfs output

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 05:22:25PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > There are certain registers, which captures the time elapsed in the > in current Up/Down EI, for how long GT has been Idle/Busy/Avg in the > current Up/Down EI and also in the previous Up/Down EI. > These

Re: [Intel-gfx] [PATCH] drm/i915: Propagate error from drm_gem_object_init()

2016-04-22 Thread Dave Gordon
On 22/04/16 11:57, Matthew Auld wrote: From: Chris Wilson Propagate the real error from drm_gem_object_init(). Note this also fixes some confusion in the error return from i915_gem_alloc_object... v2: (Matthew Auld) - updated new users of gem_alloc_object from latest drm-nightly - replac

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Call intel_unpin_fb_obj() on release

2016-04-22 Thread Tvrtko Ursulin
On 22/04/16 10:00, Chris Wilson wrote: On Fri, Apr 22, 2016 at 09:47:47AM +0100, Tvrtko Ursulin wrote: On 22/04/16 08:47, Chris Wilson wrote: When releasing the intel_fbdev, we should unpin the framebuffer that we pinned during construction. Signed-off-by: Chris Wilson --- I'm hoping this e

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Macros to convert PM time interval values to microseconds

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 05:22:24PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > Added a new GT_PM_INTERVAL_TO_US macro to perform the platform > specific conversion of PM time interval values to microseconds unit. > > Signed-off-by: Akash Goel Reviewed-by: Chris Wilson -Chris --

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)

2016-04-22 Thread Patchwork
== Series Details == Series: drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4) URL : https://patchwork.freedesktop.org/series/5990/ State : warning == Summary == Series 5990v4 drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf http://patchwork.freedesktop.org/api/1.0/series

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Function per early graphics quirk

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 02:25:07PM +0300, Joonas Lahtinen wrote: > Move graphics stolen memory related early quirk into a function to > allow easy adding of other graphics quirks to fix memory maps on > machines running old BIOS versions. > > While at it; > - _funcs -> _ops to follow de facto nami

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Canonicalize stolen memory calculations

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 02:25:06PM +0300, Joonas Lahtinen wrote: > Move the better constructs/comments from i915_gem_stolen.c to > early-quirks.c and increase readability in preparation of only > having one set of functions. > > - intel_stolen_base -> gen3_stolen_base > - use phys_addr_t instead o

[Intel-gfx] [PATCH v2 3/3] drm/i915/bxt: Explicitly clear the Turbo control register

2016-04-22 Thread akash . goel
From: Akash Goel As a part of WaGsvDisableTurbo, Driver makes an early exit from the Gen9 Turbo enabling function, so doesn't program the Turbo Control register. But BIOS could leave the Hw Turbo as enabled, so need to explicitly clear out the Control register just to avoid inconsitency with debu

[Intel-gfx] [PATCH 1/3] drm/i915: Macros to convert PM time interval values to microseconds

2016-04-22 Thread akash . goel
From: Akash Goel Added a new GT_PM_INTERVAL_TO_US macro to perform the platform specific conversion of PM time interval values to microseconds unit. Signed-off-by: Akash Goel --- drivers/gpu/drm/i915/i915_reg.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH v2 2/3] drm/i915: Correct the i915_frequency_info debugfs output

2016-04-22 Thread akash . goel
From: Akash Goel There are certain registers, which captures the time elapsed in the in current Up/Down EI, for how long GT has been Idle/Busy/Avg in the current Up/Down EI and also in the previous Up/Down EI. These register values are reported by the i915_frequency_info debugfs interface. The Dr

[Intel-gfx] [PATCH 16/16] drm/i915: Support for capturing MMIO register values

2016-04-22 Thread sourab . gupta
From: Sourab Gupta This patch adds support for capturing MMIO register values through i915 perf interface. The userspace can request upto 8 MMIO register values to be dumped. The addresses of these registers can be passed through the corresponding property 'value' field while opening the stream.

[Intel-gfx] [PATCH 08/16] drm/i915: Handle the overflow condition for command stream buf

2016-04-22 Thread sourab . gupta
From: Sourab Gupta Add a compile time option for detecting the overflow condition of command stream buffer, and not overwriting the old entries in such a case. Also, set a status flag to forward the overflow condition to userspace if overflow is detected. Signed-off-by: Sourab Gupta --- driver

[Intel-gfx] [PATCH 13/16] drm/i915: Extract raw GPU timestamps from OA reports to forward in perf samples

2016-04-22 Thread sourab . gupta
From: Sourab Gupta The OA reports contain the least significant 32 bits of the gpu timestamp. This patch enables retrieval of the timestamp field from OA reports, to forward as 64 bit raw gpu timestamps in the perf samples. Signed-off-by: Sourab Gupta --- drivers/gpu/drm/i915/i915_drv.h | 1

[Intel-gfx] [PATCH 15/16] drm/i915: Mechanism to forward clock monotonic time in perf samples

2016-04-22 Thread sourab . gupta
From: Sourab Gupta Currently, we have the ability to only forward the GPU timestamps in the samples (which are generated via OA reports or PIPE_CONTROL commands inserted in the ring). This limits the ability to correlate these samples with the system events. If we scale the GPU timestamps accordi

  1   2   >