Re: [Intel-gfx] [PATCH v2 05/11] drm/i915: Allow mmio updates on all platforms, v2.

2016-04-17 Thread Maarten Lankhorst
Op 15-04-16 om 14:31 schreef Ander Conselvan De Oliveira: > On Wed, 2016-04-13 at 11:18 +0200, Maarten Lankhorst wrote: >> Rename intel_unpin_work to intel_flip_work and use it for mmio flips >> and unpinning. > I think the rename should be a separate patch. > intel_unpin_work becomes used for mmio

Re: [Intel-gfx] [PATCH v2 02/11] drm/i915: Remove stallcheck special handling.

2016-04-17 Thread Maarten Lankhorst
Op 15-04-16 om 09:07 schreef Ander Conselvan De Oliveira: > On Wed, 2016-04-13 at 11:18 +0200, Maarten Lankhorst wrote: >> Re-use unpin_work->pending, but also set vblank count before >> intel_mark_page_flip_active to be sure. > Be sure of what? > >> Signed-off-by: Maarten Lankhorst >> --- >> dri

Re: [Intel-gfx] [PATCH v2 03/11] drm/i915: Remove intel_prepare_page_flip.

2016-04-17 Thread Maarten Lankhorst
Op 15-04-16 om 14:21 schreef Ander Conselvan De Oliveira: > On Wed, 2016-04-13 at 11:18 +0200, Maarten Lankhorst wrote: >> Do it in 1 step instead, use atomic_read since INTEL_FLIP_COMPLETE >> is no longer useful. > What's the deal with "use atomic_read"? I couldn't find where that is > different

[Intel-gfx] [PATCH] drm/i915: Avoid stalling on pending flips for legacy cursor updates

2016-04-17 Thread Chris Wilson
The legacy cursor ioctl expects to be asynchronous with respect to other screen updates, in particular page flips. As X updates the cursor from a signal context, if the cursor blocks then it will stall both the input and output chains causing bad stuttering and horrible UX. Reported-and-tested-by:

Re: [Intel-gfx] [PATCH v5 13/24] input: misc: max8997: explicitly apply PWM config extracted from pwm_args

2016-04-17 Thread Boris Brezillon
Hi Dmitry, On Sun, 17 Apr 2016 05:45:48 -0700 Dmitry Torokhov wrote: > On Thu, Apr 14, 2016 at 09:17:33PM +0200, Boris Brezillon wrote: > > Call pwm_apply_args() just after requesting the PWM device so that the > > polarity and period are initialized according to the information provided > > in

Re: [Intel-gfx] [PATCH v5 13/24] input: misc: max8997: explicitly apply PWM config extracted from pwm_args

2016-04-17 Thread Dmitry Torokhov
On Thu, Apr 14, 2016 at 09:17:33PM +0200, Boris Brezillon wrote: > Call pwm_apply_args() just after requesting the PWM device so that the > polarity and period are initialized according to the information provided > in pwm_args. > > This is an intermediate state, and pwm_apply_args() should be dro