Re: [Intel-gfx] Information about Intel_GPU_TOP tool

2016-03-18 Thread Sanchez, AdolfoX
Thanks for your suggestion I will take a look at this tool. Regards, Adolfo From: Martinez Rodriguez, Sergio Sent: Friday, March 18, 2016 10:32 AM To: intel-gfx@lists.freedesktop.org Cc: Sanchez, AdolfoX ; Bragg, Robert Subject: RE: Information about Intel_GPU_TOP tool Hi Adolfo! We are work

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Rename local struct intel_ringbuffer variables

2016-03-18 Thread Tvrtko Ursulin
On 16/03/16 16:00, Chris Wilson wrote: On Wed, Mar 16, 2016 at 03:40:54PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Majority of the code calls these ringbuf so fix up a few places which use something else to be consistent. I absolutely detest ringbuf as a name. The point of calling

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use GPLL ref clock to calculate GPU freqs on VLV/CHV

2016-03-18 Thread Imre Deak
On Wed, 2016-03-16 at 19:47 +0200, Ville Syrjälä wrote: > On Wed, Mar 16, 2016 at 07:17:51PM +0200, Imre Deak wrote: > > On Fri, 2016-03-04 at 21:43 +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > Extract the GPLL reference frequency from CCK and use it in th

[Intel-gfx] [PATCH v2 3/6] drm/i915: abstract get config for cpu transcoder

2016-03-18 Thread Jani Nikula
Makes it neater to add the same for DSI transcoder. No functional changes. v2: rename to hsw_get_transcoder_state and add a comment about grabbing power reference (Ville) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_display.c | 87 +--- 1 file ch

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: add another virtual PCH bridge for passthrough support

2016-03-18 Thread Patchwork
== Series Details == Series: drm/i915: add another virtual PCH bridge for passthrough support URL : https://patchwork.freedesktop.org/series/4539/ State : warning == Summary == Series 4539v1 drm/i915: add another virtual PCH bridge for passthrough support http://patchwork.freedesktop.org/api/1

[Intel-gfx] [PATCH igt] lib/igt_aux: Framework for measuring latency in raising signals

2016-03-18 Thread Chris Wilson
Not sure how best to put this to use yet, we need a set of benchmarks to track changes as well as a few hard fail criteria. But at least this is a start towards measuring how long we block signals whilst in the driver. Any ideas on how to stop the -lrt prolifieration? -Chris --- benchmarks/Makef

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

2016-03-18 Thread Tomi Sarvela
On Wednesday 16 March 2016 10:48:43 Imre Deak wrote: > Tomi, noticed two things that maybe infrastructure related, see below: > > > Test drv_module_reload_basic: > > skip -> PASS (bdw-nuci7) > > Test gem_ringfill: > > Subgroup basic-default-s3: > >

[Intel-gfx] [PATCH v2] drm/i915: Fix eDP low vswing for Broadwell

2016-03-18 Thread Mika Kahola
It was noticed on bug #94087 that module parameter i915.edp_vswing=2 that should override the VBT setting to use default voltage swing (400 mV) was not applied for Broadwell. This patch provides a fix for this by checking if default i.e. higher voltage swing is requested to be used and applies the

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Rename local struct intel_engine_cs variables

2016-03-18 Thread Ville Syrjälä
On Wed, Mar 16, 2016 at 03:45:08PM +, Tvrtko Ursulin wrote: > > On 16/03/16 15:40, Ville Syrjälä wrote: > > On Wed, Mar 16, 2016 at 03:35:13PM +, Tvrtko Ursulin wrote: > >> > >> On 16/03/16 15:01, Patchwork wrote: > >>> == Series Details == > >>> > >>> Series: series starting with [1/5] dr

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Tune down init error message due to failure injection (rev6)

2016-03-18 Thread Imre Deak
On Fri, 2016-03-18 at 12:38 +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Tune down init error message due to failure > injection (rev6) > URL   : https://patchwork.freedesktop.org/series/4577/ > State : failure > > == Summary == > > Series 4577v6 drm/i915: Tune down init

[Intel-gfx] [PATCH v2 5/6] drm/i915/dsi: use the BIT macro for clarity

2016-03-18 Thread Jani Nikula
No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c index 1981212ffc8d..dd6f7bc4f444 100644 --- a/drivers/gpu/drm/

[Intel-gfx] [PATCH v3 02/19] drm/i915: Move load time PCH detect, DPIO, power domain SW init earlier

2016-03-18 Thread Imre Deak
These are all SW only init steps not accessing the device and they only need the platform identification macros to work, which are already available earlier, so move these init steps earlier. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/i915_dma.c | 12 +--- 1 file changed, 5 insert

Re: [Intel-gfx] [PATCH v2 (rebased) 4/4] drm/i915: Add locking to pll updates, v2.

2016-03-18 Thread Ander Conselvan De Oliveira
On Wed, 2016-03-16 at 18:48 +0100, Maarten Lankhorst wrote: > Op 16-03-16 om 17:19 schreef Ander Conselvan De Oliveira: > > On Mon, 2016-03-14 at 09:27 +0100, Maarten Lankhorst wrote: > > > With async modesets this is no longer protected with connection_mutex, > > > so ensure that each pll has its

Re: [Intel-gfx] [PATCH] drm/i915: simplify bind_to_vm init code

2016-03-18 Thread Tvrtko Ursulin
On 17/03/16 13:41, Matthew Auld wrote: Hi, If we don't do any of the fence business for !i915_is_gtt, then will this not change the following code: if (alignment == 0) alignment = flags & PIN_MAPPABLE ? fence_alignment : unfenced_alignment; Or am I missing something? No I missed that b

Re: [Intel-gfx] [PATCH] drm/i915/kbl: Adding missing IS_KABYLAKE checks.

2016-03-18 Thread Daniel Vetter
On Wed, Mar 16, 2016 at 05:15:37PM +0200, Jani Nikula wrote: > On Wed, 16 Mar 2016, Michel Thierry wrote: > > [ text/plain ] > > On 2/29/2016 2:35 PM, Jani Nikula wrote: > >> On Fri, 26 Feb 2016, Rodrigo Vivi wrote: > >>> Hi Jani and Daniel, > >>> > >>> I believe I forgot to cc:stable on this one

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/dsi: lose the loose 666 format name in favor of packed

2016-03-18 Thread Jani Nikula
On Wed, 16 Mar 2016, Patchwork wrote: > [ text/plain ] > == Series Details == > > Series: series starting with [1/2] drm/i915/dsi: lose the loose 666 format > name in favor of packed > URL : https://patchwork.freedesktop.org/series/4505/ > State : failure > > == Summary == > > Series 4505v1 Ser

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gtt: Reference mappable_end variable from pointer

2016-03-18 Thread Joonas Lahtinen
On pe, 2016-03-18 at 08:21 +, Chris Wilson wrote: > On Fri, Mar 18, 2016 at 09:53:08AM +0200, Joonas Lahtinen wrote: > > > > Reference variable value from pointer, not assumed pointer destination. > > > > Since: > > > > commit c44ef60e437019b8ca1dab8b4d2e8761fd4ce1e9 > > Author: Mika Kuoppal

Re: [Intel-gfx] [PATCH 1/2] mm/vmap: Add a notifier for when we run out of vmap address space

2016-03-18 Thread Roman Peniaev
Hi, Chris. Comment is below. On Thu, Mar 17, 2016 at 12:59 PM, Chris Wilson wrote: > vmaps are temporary kernel mappings that may be of long duration. > Reusing a vmap on an object is preferrable for a driver as the cost of > setting up the vmap can otherwise dominate the operation on the object

[Intel-gfx] [PATCH i-g-t 1/2] tests/kms_rotation_crc: exercise invalid rotations

2016-03-18 Thread Matthew Auld
Add expect-to-fail tests for invalid rotations on each of the plane types. v2: (Ville Syrjälä) - use igt_create_fb - y-tiled will be rejected by gen < 9 - don't hardcode all the plane rotation failure combinations v3: - use valid pixel format for cursor plane Cc: Joonas Lahtinen

[Intel-gfx] [PATCH v2 4/4] drm/i915: Codify our assumption that the Global GTT is <= 4GiB

2016-03-18 Thread Joonas Lahtinen
From: Chris Wilson Throughout the code base, we use u32 for offsets into the global GTT. If we ever see any hardware with a larger GGTT, then we run the real risk of silent corruption. So test for our assumption up front so that we have a nice reminder should the time come when it fails. Signed-

Re: [Intel-gfx] [PATCH 1/2] mm/vmap: Add a notifier for when we run out of vmap address space

2016-03-18 Thread Chris Wilson
On Thu, Mar 17, 2016 at 01:37:06PM +0100, Roman Peniaev wrote: > > + freed = 0; > > + blocking_notifier_call_chain(&vmap_notify_list, 0, &freed); > > It seems to me that alloc_vmap_area() was designed not to sleep, > at least on GFP_NOWAIT path (__GFP_DIRECT_RECLAIM is not set). > > B

[Intel-gfx] [PATCH 7/8] drm/i915/chv: add more IOSF port definitions

2016-03-18 Thread Jani Nikula
Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index d4a298f715f4..e58d4342c94e 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_re

Re: [Intel-gfx] [PATCH] drm/i915: simplify bind_to_vm init code

2016-03-18 Thread Tvrtko Ursulin
On 18/03/16 10:46, Matthew Auld wrote: No functional change, just makes the code easier to follow. v2: - Remove local fence_size variable (Tvrtko Ursulin) - Remove redundant NULL ggtt_view check - Reuse size variable Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH v2 3/9] drm/i915/dsi: clean up vlv gpio table and definitions

2016-03-18 Thread Jani Nikula
Define and store the pad base offset in the array, and reference the pconf0 and padval registers through macros. Add VLV prefixes to macros. Use spec nomenclature for pconf0 and padval. v2: Address Ville's review comments, squash another patch here. Signed-off-by: Jani Nikula --- drivers/gpu/dr

Re: [Intel-gfx] New snd-hda warning spew

2016-03-18 Thread Takashi Iwai
On Fri, 18 Mar 2016 20:07:53 +0100, Ville Syrjälä wrote: > > On Fri, Mar 18, 2016 at 07:56:36PM +0100, Takashi Iwai wrote: > > On Fri, 18 Mar 2016 19:51:43 +0100, > > Takashi Iwai wrote: > > > > > > On Fri, 18 Mar 2016 18:49:19 +0100, > > > Ville Syrjälä wrote: > > > > > > > > On Fri, Mar 18, 20

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Rename local struct intel_engine_cs variables

2016-03-18 Thread Tvrtko Ursulin
On 16/03/16 15:01, Patchwork wrote: == Series Details == Series: series starting with [1/5] drm/i915: Rename local struct intel_engine_cs variables URL : https://patchwork.freedesktop.org/series/4508/ State : failure == Summary == Series 4508v1 Series without cover letter http://patchwork.

Re: [Intel-gfx] [PATCH 2/2] igt/gem_stolen: No support for stolen backed objects if Intel RST present

2016-03-18 Thread Ankitprasad Sharma
On Thu, 2016-03-17 at 09:45 +, Chris Wilson wrote: > On Thu, Mar 17, 2016 at 11:52:50AM +0530, ankitprasad.r.sha...@intel.com > wrote: > > From: Ankitprasad Sharma > > > > Skip gem_stolen and pread/pwrite on stolen backed objects if Intel > > RST device is present. > > This has to be checki

[Intel-gfx] [PATCH v2 4/9] drm/i915/dsi: add gpio indexes to the gpio table

2016-03-18 Thread Jani Nikula
This lets us specify the exact gpios we want to let through, without leaving holes in the array. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 54 ++ 1 file changed, 32 insertions(+), 22 deletions(-) diff --git a/drivers/gpu/drm/i915/int

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Use shorter route to dev_private where possible

2016-03-18 Thread Chris Wilson
On Wed, Mar 16, 2016 at 03:40:53PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Where we have a request we can use req->i915 directly instead > of going through the engine and device. Coccinelle script: > > @@ > function f; > identifier r; > @@ > f(..., struct drm_i915_gem_request *r,

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915: split set pipeconf to pipeconf, pipemisc, pipe_gamma

2016-03-18 Thread Ville Syrjälä
On Fri, Mar 18, 2016 at 05:05:40PM +0200, Jani Nikula wrote: > Prep work for DSI transcoders. No functional changes. > > v2: call split functions at a higher level (Ville) > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_display.c | 32 ++-- > 1 file

Re: [Intel-gfx] [PATCH i-g-t v3 3/6] tests/gem_scheduler: Add gem_scheduler test

2016-03-18 Thread Daniele Ceraolo Spurio
On 10/03/16 11:03, Derek Morton wrote: This is intended to test the scheduler behaviour is correct. The subtests are -basic Tests that batch buffers of the same priority submitted to a ring execute in the order they are submitted. -read Submits a batch buffer with a read dependency to a buffer

[Intel-gfx] [PATCH v5] drm/i915: Tune down init error message due to failure injection

2016-03-18 Thread Imre Deak
Atm, in case failure injection forces an error the subsequent "*ERROR* failed to init modeset" error message will make automated tests (CI) report this event as a breakage even though the event is expected. To fix this print the error message with debug log level in this case. While at it print th

[Intel-gfx] [PATCH 1/3] drm/i915/gtt: Reference mappable_end variable from pointer

2016-03-18 Thread Joonas Lahtinen
Reference variable value from pointer, not assumed pointer destination. Since: commit c44ef60e437019b8ca1dab8b4d2e8761fd4ce1e9 Author: Mika Kuoppala Date: Thu Jun 25 18:35:05 2015 +0300 drm/i915/gtt: Allow >= 4GB sizes for vm. Cc: Mika Kuoppala Signed-off-by: Joonas Lahtinen --- drive

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Drop locking/rpm resume/flush_delayed_work for cur/min/max freq sysfs read

2016-03-18 Thread Ville Syrjälä
On Wed, Mar 16, 2016 at 08:07:03PM +0200, Imre Deak wrote: > On Fri, 2016-03-04 at 21:43 +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > cur_freq, min/max_freq_softlimit, efficient_freq are just single > > values > > stored under dev_priv.rps, so there's no real point

[Intel-gfx] [PATCH 01/10] drm/i915: Add support for mapping an object page by page

2016-03-18 Thread ankitprasad . r . sharma
From: Chris Wilson Introduced a new vm specfic callback insert_page() to program a single pte in ggtt or ppgtt. This allows us to map a single page in to the mappable aperture space. This can be iterated over to access the whole object by using space as meagre as page size. v2: Added low level r

[Intel-gfx] [PATCH 09/10] drm/i915: Migrate stolen objects before hibernation

2016-03-18 Thread ankitprasad . r . sharma
From: Chris Wilson Ville reminded us that stolen memory is not preserved across hibernation, and a result of this was that context objects now being allocated from stolen were being corrupted on S4 and promptly hanging the GPU on resume. We want to utilise stolen for as much as possible (nothing

[Intel-gfx] [PATCH v2 7/9] drm/i915/chv: add more IOSF port definitions

2016-03-18 Thread Jani Nikula
Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_reg.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 07e04495cd9a..6e36c0d51023 100644 --- a/drivers/gpu/drm/i915/i915_reg.h +++ b/drivers/gpu/drm/i915/i915_re

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Get rid of intel_dp_dpcd_read_wake()

2016-03-18 Thread Ville Syrjälä
On Thu, Mar 17, 2016 at 11:40:45AM -0400, Lyude wrote: > Since we've fixed up drm_dp_dpcd_read() to allow for retries when things > timeout, there's no use for having this function anymore. Good riddens. > > Signed-off-by: Lyude > --- > drivers/gpu/drm/i915/intel_dp.c | 79 > ---

[Intel-gfx] [PATCH v3] drm/i915/gen9: add WaClearFlowControlGpgpuContextSave

2016-03-18 Thread tim . gore
From: Tim Gore This allows writes to EU flow control registers. Together with SIP code from the user-mode driver this resolves a hang seen in some pre-emption scenarios. Note that this patch is just the kernel mode part of this workaround. v2. Oops, add FLOW_CONTROL_ENABLE macro to i915_reg.h.

Re: [Intel-gfx] [PATCH] drm/i915: Restrict usage of live status check

2016-03-18 Thread Sharma, Shashank
Regards Shashank On 3/17/2016 6:34 PM, Ville Syrjälä wrote: On Thu, Mar 17, 2016 at 01:29:25PM +0530, Shashank Sharma wrote: This patch restricts usage of live status check for HDMI detection. While testing certain (monitor + cable) combinations with various intel platforms, it seems that live

[Intel-gfx] [PATCH v3 19/19] drm/i915: Add fault injection support

2016-03-18 Thread Imre Deak
Add support for forcing an error at selected places in the driver. As an example add 4 options to fail during driver loading. Requested by Chris. v2: - Add fault point for modeset initialization - Print debug message when injecting an error v3: - Rename inject_fault to inject_load_failure, rename

Re: [Intel-gfx] [PATCH] drm/i915: Fix race condition in intel_dp_destroy_mst_connector()

2016-03-18 Thread Lyude Paul
On Wed, 2016-03-16 at 21:39 +0200, Ville Syrjälä wrote: > On Wed, Mar 16, 2016 at 03:18:04PM -0400, Lyude wrote: > > > > After unplugging a DP MST display from the system, we have to go through > > and destroy all of the DRM connectors associated with it since none of > > them are valid anymore. U

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [RESEND,1/7] drm/i915: move VBT based TV presence check to intel_bios.c

2016-03-18 Thread Patchwork
== Series Details == Series: series starting with [RESEND,1/7] drm/i915: move VBT based TV presence check to intel_bios.c URL : https://patchwork.freedesktop.org/series/4506/ State : failure == Summary == Series 4506v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/serie

Re: [Intel-gfx] [RFC] drm/i915: Smarten up and use to_i915() everywhere

2016-03-18 Thread Jani Nikula
On Fri, 18 Mar 2016, Tvrtko Ursulin wrote: > However, going back to Jani's comment, I am not sure that multiple > T_to_i915(p) are better than a little bit of fake dynamic typing for > this special case. The road to hell is paved with insignificant little special cases. ;) BR, Jani. -- Jani

Re: [Intel-gfx] [PATCH V11] drm/i915/skl: SKL CDCLK change on modeset tracking VCO

2016-03-18 Thread Clint Taylor
On 03/16/2016 12:27 AM, Daniel Vetter wrote: On Tue, Mar 15, 2016 at 02:34:05PM -0700, clinton.a.tay...@intel.com wrote: From: Clint Taylor WARNING: Using ChromeOS with an eDP panel and a 4K@60 DP monitor connected to DDI1 the system will hard hang during a cold boot. Occurs when DDI1 is enabl

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Call intel_dp_mst_resume() before resuming displays

2016-03-18 Thread Lyude Paul
On Sun, 2016-03-13 at 19:45 +0100, Daniel Vetter wrote: > On Fri, Mar 11, 2016 at 10:57:01AM -0500, Lyude wrote: > > > > Since we need MST devices ready before we try to resume displays, > > calling this after intel_display_resume() can result in some issues with > > various laptop docks where the

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: split get/set pipe timings to timings and src size

2016-03-18 Thread Ville Syrjälä
On Fri, Mar 18, 2016 at 05:05:39PM +0200, Jani Nikula wrote: > Prep work for DSI transcoders. No functional changes. > > v2: call split functions at a higher level (Ville) > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_display.c | 24

Re: [Intel-gfx] [PATCH] drm/i915: Name the anonymous per-engine context struct

2016-03-18 Thread Chris Wilson
On Fri, Mar 18, 2016 at 03:00:56PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > This anonymous struct was causing a good amount of overly > verbose code. Also, if we name it and cache the pointer locally > when there are multiple accesses to it, not only the code is > more readable, bu

Re: [Intel-gfx] linux-firmware-i915 pull request (skl guc 6.1)

2016-03-18 Thread Kyle McMartin
On Wed, Mar 16, 2016 at 10:43:37PM +, Vivi, Rodrigo wrote: > Hi, > > Please consider pulling i915 updates to linux-firmware.git: > > The following changes since commit > 0a0c97667d0e80c56de8fd999d17bf2b553aab8f: > > linux-firmware/i915: Major GuC release for Skylake - ver 6.1 (2016-03 > -1

Re: [Intel-gfx] [PATCH v6] igt/gem_trtt: Exercise the TRTT hardware

2016-03-18 Thread Chris Wilson
On Fri, Mar 18, 2016 at 09:19:35PM +0530, Goel, Akash wrote: > On 3/18/2016 4:02 PM, Chris Wilson wrote: > >The point about looping is to try and ensure that every possible code > >path is interrupted (since we only interrupt every 2us and the code paths > >tend to be shorter than than!). > > Than

Re: [Intel-gfx] [PATCH v2 4/6] drm/i915/bxt: add dsi transcoders

2016-03-18 Thread Ville Syrjälä
On Fri, Mar 18, 2016 at 05:05:42PM +0200, Jani Nikula wrote: > The BXT display connections have DSI transcoders A and C that can be > muxed to any pipe, not unlike the eDP transcoder. Add the notion of DSI > transcoders. > > The "normal" transcoders A, B and C are not used with BXT DSI, so care >

Re: [Intel-gfx] [PATCH v2] prime_mmap_coherency: Add return error tests for prime sync ioctl

2016-03-18 Thread Chris Wilson
On Thu, Mar 17, 2016 at 06:18:06PM -0300, Tiago Vignatti wrote: > +static void test_ioctl_errors(void) > +{ > + int i; > + int num_children = 8*sysconf(_SC_NPROCESSORS_ONLN); > + > + igt_fork_signal_helper(); > + igt_fork(child, num_children) { Actually there is a danger here in on

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/dp_helper: retry on -ETIMEDOUT in drm_dp_dpcd_access()

2016-03-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp_helper: retry on -ETIMEDOUT in drm_dp_dpcd_access() URL : https://patchwork.freedesktop.org/series/4589/ State : failure == Summary == Series 4589v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/4589/

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Move CSB MMIO reads out of the execlists lock (rev4)

2016-03-18 Thread Tvrtko Ursulin
On 18/03/16 07:02, Patchwork wrote: == Series Details == Series: drm/i915: Move CSB MMIO reads out of the execlists lock (rev4) URL : https://patchwork.freedesktop.org/series/3973/ State : failure == Summary == Series 3973v4 drm/i915: Move CSB MMIO reads out of the execlists lock http://pat

Re: [Intel-gfx] [PATCH v2 5/6] drm/i915/dsi: use the BIT macro for clarity

2016-03-18 Thread Ville Syrjälä
On Fri, Mar 18, 2016 at 05:05:43PM +0200, Jani Nikula wrote: > No functional changes. > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_dsi.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/i915/in

Re: [Intel-gfx] [PATCH v3] prime_mmap_coherency: Add return error tests for prime sync ioctl

2016-03-18 Thread Chris Wilson
On Fri, Mar 18, 2016 at 03:08:56PM -0300, Tiago Vignatti wrote: > This patch adds ioctl-errors subtest to be used for exercising prime sync > ioctl > errors. > > The subtest constantly interrupts via signals a function doing concurrent blit > to stress out the right usage of prime_sync_*, making

[Intel-gfx] [PATCH 5/6] drm/i915: Teach to_i915() how to extract drm_i915_private from requests

2016-03-18 Thread Chris Wilson
Since drm_i915_gem_request already contains a backpointer to drm_i915_private, this is a fairly trivial operation. However, using a consistent interface does lean convenience to when we need to query device properties, for example. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH i-g-t 6/6] test/kms_pipe_color: add test to verify legacy ioctl resets GAMMA_LUT

2016-03-18 Thread Lionel Landwerlin
The GAMMA_LUT/DEGAMMA_LUT/CTM properties must be updated when the legacy ioctl is triggered to ensure the new properties do not impact older userspace code. v2: Add checks verifying the content of CTM & DEGAMMA_LUT properties Signed-off-by: Lionel Landwerlin Reviewed-by: Matt Roper --- tests/k

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: lose the loose 666 format name in favor of packed

2016-03-18 Thread Jani Nikula
On Wed, 16 Mar 2016, Ville Syrjälä wrote: > [ text/plain ] > On Wed, Mar 16, 2016 at 12:21:39PM +0200, Jani Nikula wrote: >> The enum mipi_dsi_pixel_format defines MIPI_DSI_FMT_RGB666 for the >> "loose" 24 bpp format and MIPI_DSI_FMT_RGB666_PACKED for the 18 bpp >> format. We have this the other w

[Intel-gfx] ✗ Fi.CI.BAT: failure for Pipe level color management (rev11)

2016-03-18 Thread Patchwork
== Series Details == Series: Pipe level color management (rev11) URL : https://patchwork.freedesktop.org/series/2720/ State : failure == Summary == Series 2720v11 Pipe level color management http://patchwork.freedesktop.org/api/1.0/series/2720/revisions/11/mbox/ Test gem_mmap_gtt: Sub

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dsi: start using enum mipi_dsi_pixel_format

2016-03-18 Thread Ville Syrjälä
On Wed, Mar 16, 2016 at 12:21:40PM +0200, Jani Nikula wrote: > A small step moving us closer to DRM MIPI DSI code. Use enum > mipi_dsi_pixel_format instead of our own. The first benefit is being > able to use common mipi_dsi_pixel_format_to_bpp(). > > There's a little back and forth conversion wit

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

2016-03-18 Thread Tomi Sarvela
On Friday 18 March 2016 09:00:13 Takashi Iwai wrote: > On Fri, 18 Mar 2016 08:36:27 +0100, > > Do you have the commit of the last working kernel? > > > The unit tests that hang quite reliably on first run are > > igt@gem_ringfill_basic-default-s3 > > igt@drv_module_reload_basic > > igt@kms_pipe_c

[Intel-gfx] [PATCH v7] igt/gem_trtt: Exercise the TRTT hardware

2016-03-18 Thread akash . goel
From: Akash Goel This patch provides the testcase to exercise the TRTT hardware. Some platforms have an additional address translation hardware support in form of Tiled Resource Translation Table (TR-TT) which provides an extra level of abstraction over PPGTT. This is useful for mapping Sparse/T

[Intel-gfx] [PATCH 1/6] drm/i915: Rename the magic polymorphic macro __I915__

2016-03-18 Thread Chris Wilson
To open up the future of using a generic to_i915() convenience macro, rename the existing __I915__ superconvenience macro. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH v3 09/19] drm/i915: Move load time shrinker registration later

2016-03-18 Thread Imre Deak
According to the new init phases scheme we should register the driver with frameworks/userspace only one the device is setup fully. So move the shrinker registration later accordingly. Also fix the shrinker unregistration order wrt. the acpi unregistration to fix the corresponding init order. Sig

Re: [Intel-gfx] [PATCH] drm/i915: add another virtual PCH bridge for passthrough support

2016-03-18 Thread Kay, Allen M
This patch is require for running i915 in a VM in universal passthrough (UPT) mode on some systems. UPT mode allows IGD to be passed through to a VM without hypervisor quirks. Reviewed-by: Allen Kay > -Original Message- > From: Jesse Barnes [mailto:jbar...@virtuousgeek.org] > Sent: W

Re: [Intel-gfx] [PATCH i-g-t v2] igt/gem_pipe_control_store_loop: Add qword write tests

2016-03-18 Thread Chris Wilson
On Wed, Mar 16, 2016 at 01:52:10PM +0100, Michał Winiarski wrote: > Test description suggested that all platforms were testing qword writes, > while in fact only gen4-gen5 did. > > v2: Test dword/qword writes for all available platforms > > Cc: Chris Wilson > Signed-off-by: Michał Winiarski > -

Re: [Intel-gfx] [RFC PATCH 02/10] drm/i915: make transcoder_name return a string

2016-03-18 Thread Ville Syrjälä
On Tue, Mar 15, 2016 at 09:51:10PM +0200, Jani Nikula wrote: > Nicer for eDP (actually "eDP" instead of "D"), and makes future > expansion for DSI transcoders easier. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.h| 17 - > drivers/gpu/drm/i915/

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: improved gpio element support for vlv/chv

2016-03-18 Thread Patchwork
== Series Details == Series: drm/i915/dsi: improved gpio element support for vlv/chv URL : https://patchwork.freedesktop.org/series/4578/ State : failure == Summary == Series 4578v1 drm/i915/dsi: improved gpio element support for vlv/chv http://patchwork.freedesktop.org/api/1.0/series/4578/rev

[Intel-gfx] [PATCH 3/8] drm/i915/dsi: do not define VLV gpio pad registers separately

2016-03-18 Thread Jani Nikula
They seem to be all just function register offset + 8. No functional changes, apart from saving some space. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 41 +++--- 1 file changed, 15 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/d

[Intel-gfx] [PATCH v2 5/9] drm/i915/dsi: abstract VLV gpio element execution to a separate function

2016-03-18 Thread Jani Nikula
Prepare for future. No functional changes. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 63 -- 1 file changed, 34 insertions(+), 29 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dsi_panel_vbt.c b/drivers/gpu/drm/i915/intel_dsi_p

[Intel-gfx] [PATCH i-g-t] scripts/run-test.sh: Piglit overwrite option.

2016-03-18 Thread Rodrigo Vivi
The following piglit commit adds one option to overwrite files: commit ec317ece07afdf9c8a26de04bdec8a94e5d7b2db Author: Dylan Baker Date: Mon Feb 1 15:08:23 2016 -0800 framework/programs/run.py: Add option for overwriting files So our run-script.sh test that creates the directory before e

[Intel-gfx] [PATCH v2 2/9] drm/i915/dsi: add support for DSI sequence block v2 gpio element

2016-03-18 Thread Jani Nikula
In sequence block v2, and only in v2, the gpio source (i.e. IOSF port) is specified separately. v2: initialize gpio_source to 0 and handle v1 and v2 in the same branch Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 22 ++ 1 file changed, 18 inser

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Tune down init error message due to failure injection (rev6)

2016-03-18 Thread Patchwork
== Series Details == Series: drm/i915: Tune down init error message due to failure injection (rev6) URL : https://patchwork.freedesktop.org/series/4577/ State : failure == Summary == Series 4577v6 drm/i915: Tune down init error message due to failure injection http://patchwork.freedesktop.org/

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Get rid of intel_dp_dpcd_read_wake()

2016-03-18 Thread Ville Syrjälä
On Fri, Mar 18, 2016 at 07:00:29PM +0100, Daniel Vetter wrote: > On Fri, Mar 18, 2016 at 06:41:40PM +0200, Ville Syrjälä wrote: > > On Fri, Mar 18, 2016 at 06:12:35PM +0200, Ville Syrjälä wrote: > > > On Fri, Mar 18, 2016 at 04:13:45PM +0200, Ville Syrjälä wrote: > > > > On Thu, Mar 17, 2016 at 11:

Re: [Intel-gfx] [PATCH 1/3] drm/i915/tdr: Initialize hangcheck struct for each engine

2016-03-18 Thread Chris Wilson
On Fri, Mar 18, 2016 at 09:22:55PM +, Arun Siluvery wrote: > On 18/03/2016 20:48, Chris Wilson wrote: > >On Fri, Mar 18, 2016 at 08:07:54PM +, Arun Siluvery wrote: > >>From: Tomas Elf > >> > >>Initialize hangcheck struct during driver load. Since we do the same after > >>recovering from a

Re: [Intel-gfx] [PATCH 3/3] drm/i915/gtt: Clean up GGTT probing code

2016-03-18 Thread Chris Wilson
On Fri, Mar 18, 2016 at 09:53:10AM +0200, Joonas Lahtinen wrote: > Use less pointers with the probing code, making it much less confusing > to read. > > Cc: Mika Kuoppala > Signed-off-by: Joonas Lahtinen Reasonable first step. I have something very similar sitting around waiting for a good home

Re: [Intel-gfx] [PATCH v6] igt/gem_trtt: Exercise the TRTT hardware

2016-03-18 Thread Goel, Akash
On 3/18/2016 2:06 PM, Chris Wilson wrote: On Fri, Mar 18, 2016 at 02:07:40PM +0530, akash.g...@intel.com wrote: +/* emit_store_qword + * populate batch buffer with MI_STORE_DWORD_IMM command + * @fd: drm file descriptor + * @cmd_buf: batch buffer + * @dw_offset: write offset in batch buffer +

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Tune down init error message due to failure injection (rev6)

2016-03-18 Thread Imre Deak
On Fri, 2016-03-18 at 15:29 +0200, Imre Deak wrote: > On Fri, 2016-03-18 at 12:38 +, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: Tune down init error message due to failure > > injection (rev6) > > URL   : https://patchwork.freedesktop.org/series/4577/ > > State : failu

Re: [Intel-gfx] [PATCH v6] igt/gem_trtt: Exercise the TRTT hardware

2016-03-18 Thread Goel, Akash
On 3/18/2016 4:02 PM, Chris Wilson wrote: On Fri, Mar 18, 2016 at 03:22:51PM +0530, Goel, Akash wrote: On 3/18/2016 2:52 PM, Chris Wilson wrote: On Fri, Mar 18, 2016 at 02:31:23PM +0530, Goel, Akash wrote: Hopefully final comments! Missed EINTR handling during evict, If you repeat the b

Re: [Intel-gfx] [PATCH v5] drm/i915: Tune down init error message due to failure injection

2016-03-18 Thread Chris Wilson
On Fri, Mar 18, 2016 at 10:16:28AM +0200, Imre Deak wrote: > On Fri, 2016-03-18 at 07:58 +, Chris Wilson wrote: > > On Fri, Mar 18, 2016 at 08:50:37AM +0200, Imre Deak wrote: > > > Atm, in case failure injection forces an error the subsequent "*ERROR* > > > failed to init modeset" error message