Re: [Intel-gfx] [PATCH v4] drm/i915: edp resume/On time optimization.

2016-01-30 Thread Kumar, Abhay
On 1/21/2016 9:48 PM, Kumar, Shobhit wrote: On 01/21/2016 05:47 PM, Kumar, Abhay wrote: On 1/20/2016 5:06 AM, Ville Syrjälä wrote: On Wed, Jan 20, 2016 at 03:29:00PM +0530, Kumar, Shobhit wrote: On 01/20/2016 02:30 PM, Daniel Vetter wrote: On Tue, Jan 19, 2016 at 02:37:55PM -0800, Kumar, A

[Intel-gfx] Fwd: [linux] drm/i915: Eliminate usage of plane_wm_parameters from ILK-style WM code (v2) (43d59ed)

2016-01-30 Thread Daniel Vetter
It's a github comment so pretty hopeless to follow up with the reporter, but it sounds like we have a culprit for the ilk wm issues/fifo underruns. -Daniel -- Forwarded message -- From: Manfred G Kitzbichler Date: Sat, Jan 30, 2016 at 5:42 AM Subject: Re: [linux] drm/i915: Elimina

Re: [Intel-gfx] [PATCH v4 2/6] drm/i915: tidy up initialisation failure paths (GEM & LRC)

2016-01-30 Thread Chris Wilson
On Sat, Jan 30, 2016 at 10:56:27AM +, Chris Wilson wrote: > On Fri, Jan 29, 2016 at 07:19:27PM +, Dave Gordon wrote: > > 1. add call to i915_gem_context_fini() to deallocate the default > >context(s) if the call to init_rings() fails, so that we don't > >leak the context in that sit

Re: [Intel-gfx] [PATCH v4 6/6] drm/i915: fix context/engine cleanup order

2016-01-30 Thread Chris Wilson
On Fri, Jan 29, 2016 at 07:19:31PM +, Dave Gordon wrote: > From: Nick Hoath > > Swap the order of context & engine cleanup, so that contexts are cleaned > up first, and *then* engines. This is a more sensible order anyway, but > in particular has become necessary since the 'intel_ring_initial

Re: [Intel-gfx] [PATCH v4 5/6] drm/i915: HWSP should be unmapped earlier in LRC teardown sequence

2016-01-30 Thread Chris Wilson
On Fri, Jan 29, 2016 at 07:19:30PM +, Dave Gordon wrote: > In LRC mode, the HWSP is part of the default context object, and > therefore does not exist independently. Worse, it doesn't contribute > to the refcount on the default context object either. > > Currently, the default context is deall

Re: [Intel-gfx] [PATCH v4 4/6] drm/i915: consolidate LRC mode HWSP setup & teardown

2016-01-30 Thread Chris Wilson
On Fri, Jan 29, 2016 at 07:19:29PM +, Dave Gordon wrote: > In legacy ringbuffer mode, the HWSP is a separate GEM object with its > own pinning and reference counts. In LRC mode, however, it's not; > instead its part of the default context object. The LRC-mode setup & > teardown code therefore n

Re: [Intel-gfx] [PATCH v4 3/6] drm/i915: unmap the correct page in intel_logical_ring_cleanup()

2016-01-30 Thread Chris Wilson
On Fri, Jan 29, 2016 at 07:19:28PM +, Dave Gordon wrote: > The kunmap() call here didn't match the corresponding kmap(). > The kmap()ing was changed with the introduction of the GuC-compatible > layout of context objects and the introduction of "LRC_PPHWSP_PN", in > > d167519 drm/i915: Int

Re: [Intel-gfx] [PATCH v4 2/6] drm/i915: tidy up initialisation failure paths (GEM & LRC)

2016-01-30 Thread Chris Wilson
On Fri, Jan 29, 2016 at 07:19:27PM +, Dave Gordon wrote: > 1. add call to i915_gem_context_fini() to deallocate the default >context(s) if the call to init_rings() fails, so that we don't >leak the context in that situation. > > 2. remove useless code in intel_logical_ring_cleanup(), p

Re: [Intel-gfx] [PATCH v4 1/6] drm/i915: tidy up initialisation failure paths (legacy)

2016-01-30 Thread Chris Wilson
On Fri, Jan 29, 2016 at 07:19:26PM +, Dave Gordon wrote: > 1. Fix intel_cleanup_ring_buffer() to handle the error cleanup >case where the ringbuffer has been allocated but map-and-pin >failed. Unpin it iff it's previously been mapped-and-pinned. > > 2. Fix the error path in intel_init_

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Handle fb->offsets[] and rewrite fb rotation handling to be more generic (v2) (rev2)

2016-01-30 Thread Patchwork
== Summary == Series 2679v2 drm/i915: Handle fb->offsets[] and rewrite fb rotation handling to be more generic (v2) 2016-01-29T18:01:25.652420 http://patchwork.freedesktop.org/api/1.0/series/2679/revisions/2/mbox/ Applying: drm/i915: Rename the rotated gtt view member to 'rotated' Using index in