[Intel-gfx] [PATCH] drm/i915: A better maximum brightness for users.

2015-11-08 Thread Shih-Yuan Lee (FourDollars)
The PWM brightness level of Dell XPS 13 (2015) is from 10 to 937 however the sysfs brightness level always starts from 0 so it is better to use 927 as the sysfs maximum brightness level and it becomes easier to map from the PWM brightness level to the sysfs brightness level. Signed-off-by: Shih-Yu

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Move the fbdev async_schedule() into intel_fbdev.c

2015-11-08 Thread Lukas Wunner
Hi Ville, On Fri, Nov 06, 2015 at 03:08:33PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Reading the driver load/unload code leaves one confused as there's > an async_schedule() in the load, but not async_synchronize_full() > in sight. In fact it's hidden inside intel_f

[Intel-gfx] [PATCH v2 2/2] drm/i915: Tear down fbdev if initialization fails

2015-11-08 Thread Lukas Wunner
Currently if intelfb_create() errors out, it unrefs the bo even though the fb now owns that reference. (Spotted by Ville Syrjälä.) We should unref the fb instead of the bo. However the fb was not necessarily allocated by intelfb_create(), it could be inherited from BIOS (the fb struct was then all

[Intel-gfx] [PATCH v2 1/2] drm/i915: Fix oops caused by fbdev initialization failure

2015-11-08 Thread Lukas Wunner
intelfb_create() is called once on driver initialization. If it fails, ifbdev->helper.fbdev, ifbdev->fb or ifbdev->fb->obj may be NULL. intel_fbdev_destroy() is called on driver unload and dereferences ifbdev->fb. intel_fbdev_set_suspend() is called on suspend/resume and dereferences ifbdev->help

[Intel-gfx] [PATCH v2 0/2] fbdev fixes (need review)

2015-11-08 Thread Lukas Wunner
On Fri, Oct 30, 2015 at 07:23:45PM +0100, Daniel Vetter wrote: > I don't think there's a leak here really. We always assign ifbdev->fb in > intelfb_alloc, which means the fbdev teardown code will take care of it. > The correct approach is probably to not unref anything at all, or if we > unref then