Re: [Intel-gfx] [PATCH 18/18] drm/i915/gen9: Removed byte swapping for csr firmware.

2015-07-25 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6864 -Summary- Platform Delta drm-intel-nightly Series Applied ILK -1

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Also call frontbuffer flip when disabling planes.

2015-07-25 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6860 -Summary- Platform Delta drm-intel-nightly Series Applied ILK -1

[Intel-gfx] [PATCH 14/18] drm/i915/gen9: Use flush_work to synchronize with dmc loader

2015-07-25 Thread Animesh Manna
As power well 1 is superset of power well 2 and always pw2 will be disabled first and then pw1. On the other hand dmc is responsible to save & restore back pw1 when display engine goes and come back from low power state. Before disabling pw1 dmc must be loaded, so adding flush_work() while disablin

[Intel-gfx] [PATCH 18/18] drm/i915/gen9: Removed byte swapping for csr firmware.

2015-07-25 Thread Animesh Manna
Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vatsala Nagaraju --- drivers/gpu/drm/i915/intel_csr.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr

[Intel-gfx] [PATCH 12/18] drm/i915/gen9: Use dev_priv in csr functions

2015-07-25 Thread Animesh Manna
From: Daniel Vetter As all csr firmware related opertion are not using any any data structures of drm framework level, so better to use dev_priv instead of dev. it's a new style! :) Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Daniel Vetter Signed-off-by: Animesh Manna -

[Intel-gfx] [PATCH 06/18] drm/i915/gen9: move assert_csr_loaded into intel_rpm.c

2015-07-25 Thread Animesh Manna
From: Daniel Vetter Avoids non-static functions since all the callers are in intel_rpm.c. Only thing we need for that is to move the register definitions into i915_reg.h. Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Daniel Vetter Signed-off-by: Animesh Manna --- drivers

[Intel-gfx] [PATCH 17/18] drm/i915/skl: Removed csr firmware load in resume path.

2015-07-25 Thread Animesh Manna
As csr firmware is taking care of loading the firmware, so no need for driver to load again. Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vathsala Nagaraju --- drivers/gpu/drm/i915/i915_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/

[Intel-gfx] [PATCH 10/18] drm/i915/gen9: extract parse_csr_fw.

2015-07-25 Thread Animesh Manna
From: Daniel Vetter The loader function will get a bit more complicated soon, extract the parsing code to make the control flow clearer. While doing that just use dev_priv->csr.dmc_payload as the indicator for whether it all suceeded or not. Also restrict the forced big-edian casting to just one

[Intel-gfx] [PATCH 09/18] drm/i915/gen9: Simplify csr loading failure printing.

2015-07-25 Thread Animesh Manna
From: Daniel Vetter If we really want to we can be more verbose here, but we really don't need an entire function for this. Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Daniel Vetter Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/i915_drv.c | 20

[Intel-gfx] [PATCH 04/18] drm/i915/gen9: block disable call for pw1 if dmc firmware is present.

2015-07-25 Thread Animesh Manna
Grabbing a runtime pm reference with intel_runtime_pm_get will only prevent device D3. But dmc firmware is required even earlier (namely for the skl power well 1). DMC is responsible to save the status of power well 1 and shut off the power well when panel is self refresh mode of display is complet

[Intel-gfx] [PATCH 11/18] drm/i915/gen9: Don't try to load garbage dmc firmware on resume

2015-07-25 Thread Animesh Manna
From: Daniel Vetter We need to make sure we don't put garbage into the hw if dmc firmware loading failed mid-thru. Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Daniel Vetter Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH 13/18] drm/i915: Use request_firmware and our own async work

2015-07-25 Thread Animesh Manna
From: Daniel Vetter Two benefits: - We can use FW_LOADER_USERSPACE_FALLBACK. - We can use flush_work to synchronize with the oustanding worker, which is a notch more obvious what it does than having a special completion. The next patch will properly synchronize against the async loader in th

[Intel-gfx] [PATCH 16/18] drm/i915/skl: Do not disable cdclk PLL if csr firmware is present.

2015-07-25 Thread Animesh Manna
While display engine entering into low power state no need to disable cdclk pll as CSR firmware of dmc will take care. If pll is already enabled firmware execution sequence will be blocked. This is one of the criteria for dmc to work properly. Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath S

[Intel-gfx] [PATCH 15/18] drm/i915/skl: Making DC6 entry is the last call in suspend flow.

2015-07-25 Thread Animesh Manna
Mmio register access after dc6/dc5 entry is causing the system hang, so enabling dc6 as the last call in suspend flow. Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna Signed-off-by: Vathsala Nagaraju Signed-off-by: Rajneesh Bhardwaj --- drivers/gpu/drm/i915/i9

[Intel-gfx] [PATCH 08/18] drm/i915/gen9: Align line continuations in intel_csr.c.

2015-07-25 Thread Animesh Manna
From: Daniel Vetter Standard is to align continuations of parameter lists and if conditions to the opening ( in i915 and drm code. Apply this across the entire file since it was sticking out a bit too much. Also align register definitions while at it. Cc: Damien Lespiau Cc: Imre Deak Cc: Sun

[Intel-gfx] [PATCH 07/18] drm/i915/gen9: Remove csr.state, csr_lock and related code.

2015-07-25 Thread Animesh Manna
From: Daniel Vetter This removes two anti-patterns: - Locking shouldn't be used to synchronize with async work (of any form, whether callbacks, workers or other threads). This is what the mutex_lock/unlock seems to have been for in intel_csr_load_program. Instead ordering should be ensured

[Intel-gfx] [PATCH 05/18] drm/i915/gen9: csr_init after runtime pm enable

2015-07-25 Thread Animesh Manna
As skl is fully dependent on dmc to go to low power state (dc5/dc6) which requires a trigger from rpm and to ensure the dmc firmware is available for runtime pm support rpm-reference-count is used by not releasing the rpm reference acquire when starting the firmware loader work. So moved the intel

[Intel-gfx] [PATCH 03/18] drm/i915/bxt: Stepping info added for bxt.

2015-07-25 Thread Animesh Manna
Added stepping info in intel_csr.c which is required to extract specific firmware from packaged dmc firmware. Cc: Vetter, Daniel Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/intel_csr.c | 11 +++ 1 file changed, 11 insertions

[Intel-gfx] [PATCH 02/18] drm/i915/bxt: Modified HAS_CSR, added support for BXT.

2015-07-25 Thread Animesh Manna
Modified HAS_CSR macro defination which earlier only supported for skl, now added support for BXT. Cc: Vetter, Daniel Cc: Damien Lespiau Cc: Imre Deak Cc: Sunil Kamath Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/i915_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[Intel-gfx] [PATCH 01/18] drm/i915/bxt: Path added of dmc firmware ver1 for BXT

2015-07-25 Thread Animesh Manna
Cc: Damien Lespiau Cc: Rodrigo Vivi Cc: Sunil Kamath Signed-off-by: Animesh Manna --- drivers/gpu/drm/i915/intel_csr.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_csr.c b/drivers/gpu/drm/i915/intel_csr.c index 6d8a7bf..1866426 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH 00/18] Redesign of dmc firmware loading.

2015-07-25 Thread Animesh Manna
Display microcontroller(DMC) used to save and restore display engine status while entering into low power display states for gen9 platform. Though skylake and broxton both are gen9 platform but dmc act diferently. Skylake is solely dependednt on dmc for entering into low power state - namely dc5 an

[Intel-gfx] [QA 2015/07/17 ww30] Testing report for `drm-intel-testing`

2015-07-25 Thread christophe . prigent
Hello, We launched Intel GPU Tools on 6 platforms: Skylake-Y, Braswell-M, Broadwell-U, Baytrail M and T, Haswell-ULT to validate kernel 4.12-rc2 tag drm-intel-testing-2015-07-17. Here are the results: New bugs reported: https://bugs.freedesktop.org/show_bug.cg

Re: [Intel-gfx] [intelddx] v2.99.917-392-g8090a65e2df5: Broken with llvm/clang v3.6.1

2015-07-25 Thread Chris Wilson
On Sat, Jul 25, 2015 at 12:52:10PM +0200, Sedat Dilek wrote: > Hi, > > my build breaks like this on Ubuntu/precise AMD64... commit bff0272b4fbd0e786f77a0f5a9e4ad1eb6df893e Author: Chris Wilson Date: Sat Jul 25 11:54:04 2015 +0100 sna: Put the assert(!kgem->can_fence) back to where they we

Re: [Intel-gfx] [PATCH] drm/i915: VLV/CHV PSR: Increase wait delay time before active PSR.

2015-07-25 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6861 -Summary- Platform Delta drm-intel-nightly Series Applied ILK