[Intel-gfx] [PULL] topic/drm-fixes

2015-07-22 Thread Daniel Vetter
Hi Dave, Regression fix for systemd getting confused about unknown connector state after resume. Just stop setting the state to unknown, turned out to be a silly idea anyway. What drivers imo really should do (and i915 still does that) is forcing a full reprobe on resume to make sure connector cha

[Intel-gfx] [PULL] drm-intel-fixes

2015-07-22 Thread Daniel Vetter
Hi Dave, arb_timer kernel side fix from Chris. Cheers, Daniel The following changes since commit 52721d9d3334c1cb1f76219a161084094ec634dc: Linux 4.2-rc3 (2015-07-19 14:45:02 -0700) are available in the git repository at: git://anongit.freedesktop.org/drm-intel tags/drm-intel-fixes-2015-0

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread David Henningsson
On 2015-07-23 08:17, David Henningsson wrote: I'm about to go on vacation so it would be good to get some closure here. If you both prefer this setup, how about I remove "struct i915_audio_hotplug_info" for now? We will then have: const struct i915_audio_component_audio_ops { voi

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread David Henningsson
On 2015-07-22 22:31, Takashi Iwai wrote: On Wed, 22 Jul 2015 19:52:23 +0200, David Henningsson wrote: On 2015-07-22 16:13, Vinod Koul wrote: On Wed, Jul 22, 2015 at 10:55:55AM +0200, Takashi Iwai wrote: On Wed, 22 Jul 2015 10:50:03 +0200, David Henningsson wrote: struct i915_audio_

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread Vinod Koul
On Wed, Jul 22, 2015 at 10:31:45PM +0200, Takashi Iwai wrote: > > > That depends on the device we register this with. Actually this makes more > > > sense to me :) > > > > > > If we register with struct device *audio_dev, which in this case would be > > > the codec device we create while probing th

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread Takashi Iwai
On Wed, 22 Jul 2015 19:52:23 +0200, David Henningsson wrote: > > > > On 2015-07-22 16:13, Vinod Koul wrote: > > On Wed, Jul 22, 2015 at 10:55:55AM +0200, Takashi Iwai wrote: > >> On Wed, 22 Jul 2015 10:50:03 +0200, > >> David Henningsson wrote: > >>> > >struct i915_audio_component { > >>

Re: [Intel-gfx] [BISECTED][BUG] Bug 91133 : GPU hang on G45

2015-07-22 Thread Vincent Legoll
> But unfortunately the culprit commit does not revert properly from > current linus tree. In fact the patch does revert with a bit of fuzz on current linus's tree, and I tested the bug disappear with the revert. Should I ask on LKML for a revert, during the bug fixing process ? -- Vincent Lego

[Intel-gfx] [PATCH igt] lib: add igt_debugfs_read()

2015-07-22 Thread Paulo Zanoni
From: Paulo Zanoni A helpful function for when you want to read a whole debugfs file to a string and don't want to worry about opening and closing file descriptors and asserting buffer sizes. We've been using this already for kms_frontbuffer_tracking and kms_fbcon_fbt, so the only test with new

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread David Henningsson
On 2015-07-22 16:13, Vinod Koul wrote: On Wed, Jul 22, 2015 at 10:55:55AM +0200, Takashi Iwai wrote: On Wed, 22 Jul 2015 10:50:03 +0200, David Henningsson wrote: struct i915_audio_component { struct device *dev; + struct hdac_bus *hdac_bus; If we want to be more generic,

[Intel-gfx] [BISECTED][BUG] Bug 91133 : GPU hang on G45

2015-07-22 Thread Vincent Legoll
Hello, I finally managed to bisect properly that GPU hang, more info here: https://bugs.freedesktop.org/show_bug.cgi?id=91133 But unfortunately the culprit commit does not revert properly from current linus tree. I first met that bug about 2 monthes ago, but had no time to investigate back then,

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2015-07-22 Thread Tvrtko Ursulin
On 07/22/2015 05:05 PM, Daniel Vetter wrote: On Wed, Jul 22, 2015 at 04:46:00PM +0100, Tvrtko Ursulin wrote: But also, why it is even necessary to drop the mutex here? Locking inversion with our own pagefault handler. Happens since at least mesa can return gtt mmaps to gl clients, which can t

Re: [Intel-gfx] [PATCH 2/3] igt/gem_pread: Support to verify pread/pwrite for non-shmem backed obj

2015-07-22 Thread Tvrtko Ursulin
Hi, On 07/22/2015 02:45 PM, ankitprasad.r.sha...@intel.com wrote: From: Ankitprasad Sharma This patch adds support to verify pread/pwrite for non-shmem backed objects. It also shows the pread/pwrite speed. It also tests speeds for pread with and without user side page faults v2: Fixed Rebase

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2015-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2015 at 04:46:00PM +0100, Tvrtko Ursulin wrote: > But also, why it is even necessary to drop the mutex here? Locking inversion with our own pagefault handler. Happens since at least mesa can return gtt mmaps to gl clients, which can then in turn try to upload that with pwrite somew

Re: [Intel-gfx] [PATCH 1/3] igt/gem_stolen: Verifying extended gem_create ioctl

2015-07-22 Thread Tvrtko Ursulin
Hi, On 07/22/2015 02:45 PM, ankitprasad.r.sha...@intel.com wrote: From: Ankitprasad Sharma This patch adds the testcases for verifying the new extended gem_create ioctl. By means of this extended ioctl, memory placement of the GEM object can be specified, i.e. either shmem or stolen memory. T

Re: [Intel-gfx] [PATCH 0/4] i915 to call hda driver on HDMI plug/unplug

2015-07-22 Thread David Henningsson
On 2015-07-21 19:37, R, Durgadoss wrote: Hi David, -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of David Henningsson Sent: Tuesday, July 21, 2015 1:27 PM To: alsa-de...@alsa-project.org; intel-gfx@lists.freedesktop.org; ti...@suse.de;

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2015-07-22 Thread Tvrtko Ursulin
Hi, On 07/22/2015 02:51 PM, ankitprasad.r.sha...@intel.com wrote: From: Ankitprasad Sharma This patch adds support for extending the pread/pwrite functionality for objects not backed by shmem. The access will be made through gtt interface. This will cover prime objects as well as stolen memor

[Intel-gfx] [PATCH 4/4] ALSA: hda - Wake the codec up on hotplug notify events

2015-07-22 Thread David Henningsson
As a first cautious step, we're not going to trust the information coming directly from the i915 driver, we're just going to use the fact that there was an event to wakeup the codec and ask for its status. This fixes the issue with lost unsol events in power save mode, the codec and controller can

[Intel-gfx] [PATCH v2 0/4] i915 to call hda driver on HDMI plug/unplug

2015-07-22 Thread David Henningsson
Changes since previous version: * Renames and refactorings according to Daniel's and Takashi's suggestions. * Debug message slightly improved. * Braswell now has all three pins too, Baytrail still has only one pin. It would still be good with some confirmation from Intel that this is c

[Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread David Henningsson
This struct will be used to transfer information from the i915 driver to the hda driver on HDMI hotplug events. Signed-off-by: David Henningsson --- include/drm/i915_component.h | 18 ++ 1 file changed, 18 insertions(+) diff --git a/include/drm/i915_component.h b/include/drm/i

[Intel-gfx] [PATCH 2/4] drm/i915: Call audio hotplug notify function

2015-07-22 Thread David Henningsson
On HDMI hotplug events, notify the audio driver. This will enable the audio driver to get the information at all times (even when audio is in different powersave states), and also without reading it from the hardware. Signed-off-by: David Henningsson --- drivers/gpu/drm/i915/i915_drv.h|1

[Intel-gfx] [PATCH 3/4] ALSA: hda - Dispatch incoming HDMI hotplug i915 callback

2015-07-22 Thread David Henningsson
This lets interested codec(s) be notified of HDMI hotplug events sent from the i915 driver. Signed-off-by: David Henningsson --- include/sound/hdaudio.h |4 sound/hda/hdac_i915.c | 26 ++ 2 files changed, 30 insertions(+) diff --git a/include/sound/hdaudio.h

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Support for creating Stolen memory backed objects

2015-07-22 Thread Chris Wilson
On Wed, Jul 22, 2015 at 04:14:37PM +0100, Tvrtko Ursulin wrote: > > Hi, > > On 07/22/2015 02:51 PM, ankitprasad.r.sha...@intel.com wrote: > >From: Ankitprasad Sharma > > > >Extend the drm_i915_gem_create structure to add support for > >creating Stolen memory backed objects. Added a new flag thro

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Clearing buffer objects via CPU/GTT

2015-07-22 Thread Chris Wilson
On Wed, Jul 22, 2015 at 04:16:20PM +0100, Tvrtko Ursulin wrote: > > On 07/22/2015 04:06 PM, Chris Wilson wrote: > >On Wed, Jul 22, 2015 at 04:01:33PM +0100, Tvrtko Ursulin wrote: > >>This I don't understand. Why it is OK to release a fence and never > >>re-establish it? Could that surprise some ca

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Clearing buffer objects via CPU/GTT

2015-07-22 Thread Tvrtko Ursulin
On 07/22/2015 04:06 PM, Chris Wilson wrote: On Wed, Jul 22, 2015 at 04:01:33PM +0100, Tvrtko Ursulin wrote: This I don't understand. Why it is OK to release a fence and never re-establish it? Could that surprise some callers? We always call get_fence() before we need it (and pin it as require

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Support for creating Stolen memory backed objects

2015-07-22 Thread Tvrtko Ursulin
Hi, On 07/22/2015 02:51 PM, ankitprasad.r.sha...@intel.com wrote: From: Ankitprasad Sharma Extend the drm_i915_gem_create structure to add support for creating Stolen memory backed objects. Added a new flag through which user can specify the preference to allocate the object from stolen memor

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Add support for stealing purgable stolen pages

2015-07-22 Thread Chris Wilson
On Wed, Jul 22, 2015 at 07:21:48PM +0530, ankitprasad.r.sha...@intel.com wrote: > +struct drm_i915_gem_object * > +i915_gem_object_create_stolen(struct drm_device *dev, u32 size) > +{ > + struct drm_i915_private *dev_priv = dev->dev_private; > + struct drm_i915_gem_object *obj; > + stru

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Clearing buffer objects via CPU/GTT

2015-07-22 Thread Chris Wilson
On Wed, Jul 22, 2015 at 04:01:33PM +0100, Tvrtko Ursulin wrote: > This I don't understand. Why it is OK to release a fence and never > re-establish it? Could that surprise some callers? We always call get_fence() before we need it (and pin it as required), because it can be revoked at anytime as t

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Clearing buffer objects via CPU/GTT

2015-07-22 Thread Chris Wilson
On Wed, Jul 22, 2015 at 04:01:33PM +0100, Tvrtko Ursulin wrote: > >+ret = i915_gem_obj_ggtt_pin(obj, alignment, PIN_MAPPABLE); > >+if (ret) { > >+DRM_ERROR("Mapping of gem object to GTT failed\n"); > > Maybe end the sentence with "!" ? Or better yet, don't do anything. The err

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Clearing buffer objects via CPU/GTT

2015-07-22 Thread Tvrtko Ursulin
Hi, On 07/22/2015 02:51 PM, ankitprasad.r.sha...@intel.com wrote: From: Ankitprasad Sharma This patch adds support for clearing buffer objects via CPU/GTT. This is particularly useful for clearing out the non shmem backed objects. Currently intend to use this only for buffers allocated from s

[Intel-gfx] [drm-intel:topic/connector-locking 31/98] drivers/gpu/drm/drm_gem_cma_helper.c:384:21: warning: unused variable 'dev'

2015-07-22 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel topic/connector-locking head: e84b76da88bf67085d2e5ee7f385bb52639b252d commit: 2e34a1bc4f9ce5f4d69cbdcf9f9d6958f6774231 [31/98] drm/cma-helper: Fix locking in drm_fb_cma_debugfs_show config: arm-imx_v6_v7_defconfig (attached as .config) reproduce:

Re: [Intel-gfx] [RFC 3/9] drm/i915: Convert requests to use struct fence

2015-07-22 Thread Tvrtko Ursulin
On 07/17/2015 03:31 PM, john.c.harri...@intel.com wrote: From: John Harrison There is a construct in the linux kernel called 'struct fence' that is intended to keep track of work that is executed on hardware. I.e. it solves the basic problem that the drivers 'struct drm_i915_gem_request' is tr

Re: [Intel-gfx] [PATCH 14/14] drm: gc now dead mode_group code

2015-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2015 at 03:05:06PM +0200, Maarten Lankhorst wrote: > Op 09-07-15 om 23:44 schreef Daniel Vetter: > > Two nice things here: > > - drm_dev_register will truly register everything in the right order > > if the driver doesn't have a ->load callback. Before this we had to > > init th

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2015-07-22 Thread Chris Wilson
On Wed, Jul 22, 2015 at 07:21:49PM +0530, ankitprasad.r.sha...@intel.com wrote: > static int > i915_gem_shmem_pread(struct drm_device *dev, >struct drm_i915_gem_object *obj, > @@ -754,17 +850,20 @@ i915_gem_pread_ioctl(struct drm_device *dev, void *data, > goto o

Re: [Intel-gfx] [RFC 3/9] drm/i915: Convert requests to use struct fence

2015-07-22 Thread Tvrtko Ursulin
Hi, On 07/17/2015 03:31 PM, john.c.harri...@intel.com wrote: From: John Harrison There is a construct in the linux kernel called 'struct fence' that is intended to keep track of work that is executed on hardware. I.e. it solves the basic problem that the drivers 'struct drm_i915_gem_request'

[Intel-gfx] [drm-intel:topic/connector-locking 97/98] drivers/gpu/drm/drm_atomic_helper.c:992:2: error: too many arguments to function 'drm_atomic_helper_commit_planes'

2015-07-22 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel topic/connector-locking head: e84b76da88bf67085d2e5ee7f385bb52639b252d commit: 2c6c6ef756cd3ebb297eab6b302c340045740b08 [97/98] drm/atomic-helper: Add option to update planes only on active crtc config: i386-randconfig-i0-201529 (attached as .confi

[Intel-gfx] [drm-intel:topic/connector-locking 63/98] drivers/gpu/drm/drm_ioctl.c:572:5: warning: "CONFIG_AGP" is not defined

2015-07-22 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel topic/connector-locking head: e84b76da88bf67085d2e5ee7f385bb52639b252d commit: 69edb03c45c8b06d1740245af3d4e75ed62e7851 [63/98] drm: Remove __OS_HAS_AGP config: x86_64-randconfig-i0-201529 (attached as .config) reproduce: git checkout 69edb03c45c

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread Vinod Koul
On Wed, Jul 22, 2015 at 10:55:55AM +0200, Takashi Iwai wrote: > On Wed, 22 Jul 2015 10:50:03 +0200, > David Henningsson wrote: > > > > >> struct i915_audio_component { > > >> struct device *dev; > > >> +struct hdac_bus *hdac_bus; > > > > > > If we want to be more generic, using

[Intel-gfx] [PATCH v5 0/4] Support for creating/using Stolen memory backed objects

2015-07-22 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch series adds support for creating/using Stolen memory backed objects. Despite being a unified memory architecture (UMA) some bits of memory are more equal than others. In particular we have the thorny issue of stolen memory, memory stolen from the system by the

[Intel-gfx] [PATCH 2/4] drm/i915: Support for creating Stolen memory backed objects

2015-07-22 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma Extend the drm_i915_gem_create structure to add support for creating Stolen memory backed objects. Added a new flag through which user can specify the preference to allocate the object from stolen memory, which if set, an attempt will be made to allocate the object from s

[Intel-gfx] [PATCH 1/4] drm/i915: Clearing buffer objects via CPU/GTT

2015-07-22 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch adds support for clearing buffer objects via CPU/GTT. This is particularly useful for clearing out the non shmem backed objects. Currently intend to use this only for buffers allocated from stolen region. Testcase: igt/gem_stolen Signed-off-by: Ankitprasad Sh

[Intel-gfx] [PATCH 4/4] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2015-07-22 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch adds support for extending the pread/pwrite functionality for objects not backed by shmem. The access will be made through gtt interface. This will cover prime objects as well as stolen memory backed objects but for userptr objects it is still forbidden. v2: D

[Intel-gfx] [PATCH 3/4] drm/i915: Add support for stealing purgable stolen pages

2015-07-22 Thread ankitprasad . r . sharma
From: Chris Wilson If we run out of stolen memory when trying to allocate an object, see if we can reap enough purgeable objects to free up enough contiguous free space for the allocation. This is in principle very much like evicting objects to free up enough contiguous space in the vma when bind

[Intel-gfx] [PATCH 3/3] igt/gem_create: Test to validate parameters for GEM_CREATE ioctl

2015-07-22 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This test validates the two parameters (size and flags) GEM_CREATE ioctl. v2: Added IGT_TEST_DESCRIPTION (Thomas Wood) v3: Removed use of hard coded values, updated comments (Tvrtko) Signed-off-by: Ankitprasad Sharma --- tests/Makefile.sources | 1 + tests/gem_crea

[Intel-gfx] [PATCH 2/3] igt/gem_pread: Support to verify pread/pwrite for non-shmem backed obj

2015-07-22 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch adds support to verify pread/pwrite for non-shmem backed objects. It also shows the pread/pwrite speed. It also tests speeds for pread with and without user side page faults v2: Fixed Rebase conflicts (Ankit) v3: Precalculating values to avoid redundant funct

[Intel-gfx] [PATCH 1/3] igt/gem_stolen: Verifying extended gem_create ioctl

2015-07-22 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch adds the testcases for verifying the new extended gem_create ioctl. By means of this extended ioctl, memory placement of the GEM object can be specified, i.e. either shmem or stolen memory. These testcases include functional tests and interface tests for testin

[Intel-gfx] [PATCH v3 0/3] Tests for verifying the old and extended GEM_CREATE ioctl

2015-07-22 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This new set of tests verifies the old and the new extended GEM_CREATE ioctl gem_stolen tries to verify the new extended GEM_CREATE ioctl, which tries to create an object backed by stolen memory and performs basic operations on it. It verifies the creation as well as the

Re: [Intel-gfx] [PATCH 3/4] ALSA: hda - Dispatch incoming HDMI hotplug i915 callback

2015-07-22 Thread Takashi Iwai
On Wed, 22 Jul 2015 15:56:37 +0200, Vinod Koul wrote: > > On Wed, Jul 22, 2015 at 10:30:57AM +0200, Takashi Iwai wrote: > > On Tue, 21 Jul 2015 09:57:26 +0200, > > David Henningsson wrote: > > > > > > This lets interested codec(s) be notified of HDMI hotplug > > > events sent from the i915 driver

Re: [Intel-gfx] [PATCH 3/4] ALSA: hda - Dispatch incoming HDMI hotplug i915 callback

2015-07-22 Thread Vinod Koul
On Wed, Jul 22, 2015 at 10:30:57AM +0200, Takashi Iwai wrote: > On Tue, 21 Jul 2015 09:57:26 +0200, > David Henningsson wrote: > > > > This lets interested codec(s) be notified of HDMI hotplug > > events sent from the i915 driver. > > > > Signed-off-by: David Henningsson > > --- > > include/sou

Re: [Intel-gfx] [PATCH v1.1 2/5] drm/atomic: Make prepare_fb/cleanup_fb only take state, v2.

2015-07-22 Thread Rob Clark
On Thu, Jul 16, 2015 at 10:13 AM, Maarten Lankhorst wrote: > This removes the need to separately track fb changes i915. > > Changes since v1: > - Add dri-devel to cc. > - Fix a check in intel's prepare and cleanup fb to take rotation > into account. > > Cc: dri-de...@lists.freedesktop.org > Sign

Re: [Intel-gfx] [PATCH 14/14] drm: gc now dead mode_group code

2015-07-22 Thread Maarten Lankhorst
Op 09-07-15 om 23:44 schreef Daniel Vetter: > Two nice things here: > - drm_dev_register will truly register everything in the right order > if the driver doesn't have a ->load callback. Before this we had to > init the primary mode_group after the device nodes where already > registered. > >

Re: [Intel-gfx] [PATCH] drm/i915: fix checksum write for automated test reply

2015-07-22 Thread Sivakumar Thulasimani
On 7/22/2015 5:30 PM, Daniel Vetter wrote: On Wed, Jul 22, 2015 at 03:36:48PM +0530, Sivakumar Thulasimani wrote: From: "Thulasimani,Sivakumar" DP spec requires the checksum of the last block read to be written when replying to TEST_EDID_READ. This patch fixes the current code to do the same

[Intel-gfx] [PATCH] drm/i915: fix checksum write for automated test reply

2015-07-22 Thread Sivakumar Thulasimani
From: "Thulasimani,Sivakumar" DP spec requires the checksum of the last block read to be written when replying to TEST_EDID_READ. This patch fixes the current code to do the same. Signed-off-by: Sivakumar Thulasimani --- drivers/gpu/drm/i915/intel_dp.c |9 - 1 file changed, 8 inser

Re: [Intel-gfx] drivers/gpu/drm/i915/intel_display.c:9717 intel_check_page_flip+0xb3/0xd2()

2015-07-22 Thread Marc MERLIN
On Wed, Jul 15, 2015 at 04:13:23PM +, Marc MERLIN wrote: > kernel: 3.19.8 > xserver-xorg-video-intel 2:2.99.917-1 on debian > X.Org X Server 1.17.1 > > [254670.214607] pool[30720]: segfault at 20 ip 7f0e68d3f534 sp > 7f0dd57f9500 error 4 in libgio-2.0.so.0.4200.1[7f0e68cfa000+171000]

Re: [Intel-gfx] [PATCH] drm/i915/bxt: WA for swapped HPD pins in A stepping

2015-07-22 Thread Sivakumar Thulasimani
On 7/22/2015 5:32 PM, Jindal, Sonika wrote: On 7/22/2015 5:01 PM, Sivakumar Thulasimani wrote: On 7/22/2015 4:39 PM, Jindal, Sonika wrote: On 7/22/2015 4:03 PM, Sivakumar Thulasimani wrote: On 7/22/2015 3:37 PM, Sonika Jindal wrote: As per bspec, on BXT A0/A1, sw needs to activate D

Re: [Intel-gfx] [PATCH] drm/i915/bxt: WA for swapped HPD pins in A stepping

2015-07-22 Thread Jindal, Sonika
On 7/22/2015 5:01 PM, Sivakumar Thulasimani wrote: On 7/22/2015 4:39 PM, Jindal, Sonika wrote: On 7/22/2015 4:03 PM, Sivakumar Thulasimani wrote: On 7/22/2015 3:37 PM, Sonika Jindal wrote: As per bspec, on BXT A0/A1, sw needs to activate DDIA HPD logic and interrupts to check the exter

Re: [Intel-gfx] [PATCH] drm/i915: fix checksum write for automated test reply

2015-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2015 at 03:36:48PM +0530, Sivakumar Thulasimani wrote: > From: "Thulasimani,Sivakumar" > > DP spec requires the checksum of the last block read to be written > when replying to TEST_EDID_READ. This patch fixes the current code > to do the same. > > Signed-off-by: Sivakumar Thulas

Re: [Intel-gfx] [PATCH] drm/i915: add error path

2015-07-22 Thread Sudip Mukherjee
On Wed, Jul 22, 2015 at 12:39:37PM +0100, Chris Wilson wrote: > On Wed, Jul 22, 2015 at 04:58:47PM +0530, Sudip Mukherjee wrote: > > If any of the debug file creation fails we were just returning the > > error code to the drm layer. But the debug files that we created in the > > process were not re

Re: [Intel-gfx] [PATCH] drm/i915: add error path

2015-07-22 Thread Chris Wilson
On Wed, Jul 22, 2015 at 04:58:47PM +0530, Sudip Mukherjee wrote: > If any of the debug file creation fails we were just returning the > error code to the drm layer. But the debug files that we created in the > process were not removed. And debugfs files are not automatically > cleaned up. Just han

Re: [Intel-gfx] [PATCH] drm/i915/bxt: WA for swapped HPD pins in A stepping

2015-07-22 Thread Sivakumar Thulasimani
On 7/22/2015 4:39 PM, Jindal, Sonika wrote: On 7/22/2015 4:03 PM, Sivakumar Thulasimani wrote: On 7/22/2015 3:37 PM, Sonika Jindal wrote: As per bspec, on BXT A0/A1, sw needs to activate DDIA HPD logic and interrupts to check the external panel connection and DDIC HPD logic for edp panel.

[Intel-gfx] [PATCH] drm/i915: add error path

2015-07-22 Thread Sudip Mukherjee
If any of the debug file creation fails we were just returning the error code to the drm layer. But the debug files that we created in the process were not removed. And debugfs files are not automatically cleaned up. Signed-off-by: Sudip Mukherjee --- Hi Daniel, Whom should i keep Cc: for this p

Re: [Intel-gfx] [PATCH] drm/i915/bxt: WA for swapped HPD pins in A stepping

2015-07-22 Thread Jindal, Sonika
On 7/22/2015 4:03 PM, Sivakumar Thulasimani wrote: On 7/22/2015 3:37 PM, Sonika Jindal wrote: As per bspec, on BXT A0/A1, sw needs to activate DDIA HPD logic and interrupts to check the external panel connection and DDIC HPD logic for edp panel. v2: For DP, irq_port is used to determine the

Re: [Intel-gfx] [PATCH] drm/i915/bxt: WA for swapped HPD pins in A stepping

2015-07-22 Thread Sivakumar Thulasimani
On 7/22/2015 3:37 PM, Sonika Jindal wrote: As per bspec, on BXT A0/A1, sw needs to activate DDIA HPD logic and interrupts to check the external panel connection and DDIC HPD logic for edp panel. v2: For DP, irq_port is used to determine the encoder instead of hpd_pin and removing the edp HPD l

[Intel-gfx] [PATCH] drm/i915/bxt: WA for swapped HPD pins in A stepping

2015-07-22 Thread Sonika Jindal
As per bspec, on BXT A0/A1, sw needs to activate DDIA HPD logic and interrupts to check the external panel connection and DDIC HPD logic for edp panel. v2: For DP, irq_port is used to determine the encoder instead of hpd_pin and removing the edp HPD logic because port A HPD is not present(Imre) v3

[Intel-gfx] [PATCH] drm/i915: fix checksum write for automated test reply

2015-07-22 Thread Sivakumar Thulasimani
From: "Thulasimani,Sivakumar" DP spec requires the checksum of the last block read to be written when replying to TEST_EDID_READ. This patch fixes the current code to do the same. Signed-off-by: Sivakumar Thulasimani --- drivers/gpu/drm/i915/intel_dp.c | 11 ++- 1 file changed, 10 in

[Intel-gfx] [PATCH] drm/i915/bxt: Update HAS_PSR macro to include all gen>=8 platforms

2015-07-22 Thread Sonika Jindal
This is to get PSR support for bxt. v2: Adding bxt prefix in title (Damien) Signed-off-by: Sonika Jindal Reviewed-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.h |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/

Re: [Intel-gfx] interference on display, Intel 945GM, 32bit system, kernel next

2015-07-22 Thread Krzysztof Kolasa
On 22.07.2015 10:27, Daniel Vetter wrote: > On Tue, Jul 21, 2015 at 08:07:47PM +0200, Krzysztof Kolasa wrote: >> On 21.07.2015 16:03, Daniel Vetter wrote: >>> On Tue, Jul 21, 2015 at 02:48:21PM +0200, Krzysztof Kolasa wrote: On 21.07.2015 11:43, Chris Wilson wrote: > On Tue, Jul 21, 2015 a

Re: [Intel-gfx] [PATCH] mfd: Add GPIOLIB dependency if INTEL_SOC_PMIC is to be enabled

2015-07-22 Thread Daniel Vetter
On Wed, Jul 22, 2015 at 02:01:44PM +0530, Shobhit Kumar wrote: > This is needed as the CRC PMIC has support for Panel > enable/diable as gpio which needs 'gpiod_add_lookup_table' > and 'gpiod_remove_lookup_table' from gpiolib. This patch > can be squashed with below commit in topic/crc-pmic branch

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread Takashi Iwai
On Wed, 22 Jul 2015 10:50:03 +0200, David Henningsson wrote: > > >> struct i915_audio_component { > >>struct device *dev; > >> + struct hdac_bus *hdac_bus; > > > > If we want to be more generic, using a struct device would be better, > > e.g. > > struct device *audio_dev; > > Does this

Re: [Intel-gfx] [PATCH 0/4] i915 to call hda driver on HDMI plug/unplug

2015-07-22 Thread Takashi Iwai
On Tue, 21 Jul 2015 19:37:17 +0200, R, Durgadoss wrote: > > Hi David, > > >-Original Message- > >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > >Of David Henningsson > >Sent: Tuesday, July 21, 2015 1:27 PM > >To: alsa-de...@alsa-project.org; intel-gfx@lists.

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread David Henningsson
On 2015-07-22 10:22, Takashi Iwai wrote: On Tue, 21 Jul 2015 09:57:24 +0200, David Henningsson wrote: This struct will be used to transfer information from the i915 driver to the hda driver on HDMI hotplug events. Signed-off-by: David Henningsson Looks good to me, just a few nitpicking:

Re: [Intel-gfx] [PATCH 0/3] drm/i915/bxt: HPD long/short pulse detect support on port A

2015-07-22 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 10:42:11AM -0700, Imre Deak wrote: > On Tue, 2015-07-21 at 11:40 +0530, Jindal, Sonika wrote: > > For the patch 3, the commit message can be changed to only "long pulse > > detection" instead of "long/short" because you are not adding support > > for short pulse detection.

[Intel-gfx] [PATCH] mfd: Add GPIOLIB dependency if INTEL_SOC_PMIC is to be enabled

2015-07-22 Thread Shobhit Kumar
This is needed as the CRC PMIC has support for Panel enable/diable as gpio which needs 'gpiod_add_lookup_table' and 'gpiod_remove_lookup_table' from gpiolib. This patch can be squashed with below commit in topic/crc-pmic branch commit 61dd2ca2d44e493b050adbbb75bc50db11c367dd Author

Re: [Intel-gfx] [PATCH 3/3] drm/i915/bxt: add support for HPD long/short pulse detection on HPD_PORT_A pin

2015-07-22 Thread Sivakumar Thulasimani
On 7/21/2015 3:13 AM, Imre Deak wrote: This is a requirement for enabling display port HPD support on the port A HPD pin. This support is to be added by follow-up patches. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/i915_irq.c | 18 +- drivers/gpu/drm/i915/i915_reg.h

Re: [Intel-gfx] [PATCH 3/4] ALSA: hda - Dispatch incoming HDMI hotplug i915 callback

2015-07-22 Thread Takashi Iwai
On Tue, 21 Jul 2015 09:57:26 +0200, David Henningsson wrote: > > This lets interested codec(s) be notified of HDMI hotplug > events sent from the i915 driver. > > Signed-off-by: David Henningsson > --- > include/sound/hdaudio.h |4 > sound/hda/hdac_i915.c | 24 +

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: don't use HPD_PORT_A as an alias for HPD_NONE

2015-07-22 Thread Sivakumar Thulasimani
On 7/22/2015 4:02 AM, Imre Deak wrote: Curren tly HPD_PORT_A is used as an alias for HPD_NONE to mean that the given port doesn't support long/short HPD pulse detection. SDVO and CRT ports are like this and for these ports we only want to know whether an hot plug event was detected on the corre

Re: [Intel-gfx] interference on display, Intel 945GM, 32bit system, kernel next

2015-07-22 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 08:07:47PM +0200, Krzysztof Kolasa wrote: > On 21.07.2015 16:03, Daniel Vetter wrote: > > On Tue, Jul 21, 2015 at 02:48:21PM +0200, Krzysztof Kolasa wrote: > >> On 21.07.2015 11:43, Chris Wilson wrote: > >>> On Tue, Jul 21, 2015 at 11:07:20AM +0200, Daniel Vetter wrote: > >>

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-22 Thread Takashi Iwai
On Tue, 21 Jul 2015 09:57:24 +0200, David Henningsson wrote: > > This struct will be used to transfer information from the i915 > driver to the hda driver on HDMI hotplug events. > > Signed-off-by: David Henningsson Looks good to me, just a few nitpicking: > --- > include/drm/i915_component.h

Re: [Intel-gfx] [drm-intel:topic/crc-pmic 2/7] intel_soc_pmic_core.c:undefined reference to `gpiod_remove_lookup_table'

2015-07-22 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 11:32:47PM +0530, Kumar, Shobhit wrote: > On Tuesday 21 July 2015 11:10 PM, Daniel Vetter wrote: > >On Tue, Jul 21, 2015 at 09:17:21PM +0530, Kumar, Shobhit wrote: > >>On Tuesday 21 July 2015 07:35 PM, Daniel Vetter wrote: > >>>On Tue, Jul 21, 2015 at 07:22:37PM +0800, kbuil

Re: [Intel-gfx] [PATCH i-g-t v2 1/2] lib/igt_fb : Add more overlay plane support for bxt

2015-07-22 Thread Patrik Jakobsson
On Wed, Jul 22, 2015 at 04:34:27AM +, Gharpure, Mayuresh S wrote: > Hi Nabendu, > > PFA. I came across this patch from Damien Lespiau which prevents the topmost > plane from being exposed to user space. > > Once this patch is merged, the following correction in i-g-t won't be > required as

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: combine i9xx_get_hpd_pins and pch_get_hpd_pins

2015-07-22 Thread Sivakumar Thulasimani
On 7/22/2015 4:02 AM, Imre Deak wrote: These functions are quite similar, so combine them with the use of a new argument for a function that detects long pulses. This will be also needed by an upcoming patch adding support for BXT long pulse detection. No functional change. v2: - rebase on to

Re: [Intel-gfx] 8086:1616 [Lenovo ThinkPad T450s] External monitor is disabled after resume

2015-07-22 Thread Daniel Vetter
Can you please test this patch: http://www.spinics.net/lists/intel-gfx/msg71925.html Thanks, Daniel On Mon, Jul 20, 2015 at 09:05:18PM +0200, crs wrote: > [1.] One line summary of the problem: > 8086:1616 [Lenovo ThinkPad T450s] External monitor is disabled after > resume > > [2.] Full descrip

Re: [Intel-gfx] [PATCH 1/3] drm/i915: combine i9xx_get_hpd_pins and pch_get_hpd_pins

2015-07-22 Thread Sivakumar Thulasimani
On 7/21/2015 11:28 PM, Imre Deak wrote: On Tue, 2015-07-21 at 13:50 +0530, Sivakumar Thulasimani wrote: On 7/21/2015 3:13 AM, Imre Deak wrote: These functions are quite similar, so combine them with the use of a new argument for a function that detects long pulses. This will be also needed by